diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2016-10-04 03:05:47 +0200 |
|---|---|---|
| committer | Peter Wu <peter@lekensteyn.nl> | 2016-10-04 01:11:14 +0000 |
| commit | a59e64c9069aabd42a2df349e2d478e6f2147ffa (patch) | |
| tree | 808d7418ff5d3b69bc743890f336f0044314b1ca /epan/uat.h | |
| parent | 1fdbdf7fcaf30661ac95a5d0af3c2aa105b6274f (diff) | |
uat: fix PT_TXTMOD_HEXBYTES/PT_TXTMOD_ENUM comments
The PT_TXTMOD_HEXBYTES comment was misleading, edit it to reflect the
actual implementation in GTK+/Qt.
Change-Id: I1506ad9189296dcc09cc20eafb0d65eaf291d79f
Reviewed-on: https://code.wireshark.org/review/18058
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'epan/uat.h')
| -rw-r--r-- | epan/uat.h | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/epan/uat.h b/epan/uat.h index 7c659a050a..b9829cef73 100644 --- a/epan/uat.h +++ b/epan/uat.h @@ -176,7 +176,7 @@ typedef enum _uat_text_mode_t { /* file: reads: - ,"\x20\x00\x30", as " \00",3 + ,"\x20\x00\x30", as " \00",3 ("space nil zero" of length 3) ,"", as "",0 ,, as NULL,0 writes: @@ -191,19 +191,21 @@ typedef enum _uat_text_mode_t { /* file: reads: - ,A1b2C3d4, as "\001\002\003\004",4 + ,A1b2C3d4, as "\xa1\xb2\xc3\xd4",4 ,, as NULL,0 writes: ,, on NULL, * - ,a1b2c3d4, on "\001\002\003\004",4 + ,a1b2c3d4, on "\xa1\xb2\xc3\xd4",4 dialog: - "a1b2c3d4" as "\001\002\003\004",4 - "a1 b2:c3d4" as "\001\002\003\004",4 + interprets the following input ... as ...: + "a1b2c3d4" as "\xa1\xb2\xc3\xd4",4 + "a1 b2:c3d4" as "\xa1\xb2\xc3\xd4",4 "" as NULL,0 "invalid" as NULL,3 "a1b" as NULL, 1 */ PT_TXTMOD_ENUM, + /* Read/Writes/displays the string value (not number!) */ PT_TXTMOD_FILENAME, /* processed like a PT_TXTMOD_STRING, but shows a filename dialog */ @@ -454,7 +456,6 @@ static void basename ## _ ## field_name ## _tostr_cb(void* rec, char** out_ptr, * BUFFER macros, * a buffer_ptr contained in (((rec_t*)rec)->(field_name)) * and its len in (((rec_t*)rec)->(len_name)) - * XXX: UNTESTED and probably BROKEN */ #define UAT_BUFFER_CB_DEF(basename,field_name,rec_t,ptr_element,len_element) \ static void basename ## _ ## field_name ## _set_cb(void* rec, const char* buf, guint len, const void* UNUSED_PARAMETER(u1), const void* UNUSED_PARAMETER(u2)) {\ |