diff options
| author | Gerald Combs <gerald@wireshark.org> | 2012-04-04 21:54:22 +0000 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2012-04-04 21:54:22 +0000 |
| commit | 8b3024e57cfdec74a5eadfcea9c3e936fb2f1bef (patch) | |
| tree | cb0deddd0e89e760109f821527ec69be1bb2c712 /epan/to_str.h | |
| parent | c67d24077ef60cbe997467f6294f8b856351cfd4 (diff) | |
Make bit_offset in _tvb_get_bits64 and related functions unsigned. This
removes a potential buffer overflow and should fix a bunch of Coverity
errors mentioned in bug 6878.
We might want to do the same for no_of_bits.
svn path=/trunk/; revision=41945
Diffstat (limited to 'epan/to_str.h')
| -rw-r--r-- | epan/to_str.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/to_str.h b/epan/to_str.h index fb1cad9982..3093dffa59 100644 --- a/epan/to_str.h +++ b/epan/to_str.h @@ -87,7 +87,7 @@ extern gchar* rel_time_to_secs_str(const nstime_t*); extern gchar* guid_to_str(const e_guid_t*); extern gchar* guid_to_str_buf(const e_guid_t*, gchar*, int); -extern char *decode_bits_in_field(const gint bit_offset, const gint no_of_bits, const guint64 value); +extern char *decode_bits_in_field(const guint bit_offset, const gint no_of_bits, const guint64 value); extern char *other_decode_bitfield_value(char *buf, const guint32 val, const guint32 mask, const int width); |