diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2018-05-04 22:10:46 +0200 |
|---|---|---|
| committer | Roland Knall <rknall@gmail.com> | 2018-05-05 05:57:25 +0000 |
| commit | 1ebbb09c5bc7a73765e1fa84f6a29ad06731e3b6 (patch) | |
| tree | 04babc2ac929505edd32a01cc369f0edcef0c9df /epan/plugin_if.c | |
| parent | 8569b8000f68b0ee901d1c13e1d5aa324814aabf (diff) | |
plugin_if: fix small memory leak in ext_menubar_add_separator
No need to clone memory as ext_menubar_add_generic_entry g_strdups the
label argument. Found by Clang Static Analyzer.
Change-Id: I7ffe3d0cae0093410f2015e6beb8b8e97a871b2a
Fixes: v1.99.6rc0-213-geeed4d1121 ("UI: Implementing menus for plugins")
Reviewed-on: https://code.wireshark.org/review/27342
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
Diffstat (limited to 'epan/plugin_if.c')
| -rw-r--r-- | epan/plugin_if.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/plugin_if.c b/epan/plugin_if.c index ab3f1935df..c8b45a44ae 100644 --- a/epan/plugin_if.c +++ b/epan/plugin_if.c @@ -182,7 +182,7 @@ extern void ext_menubar_add_website(ext_menu_t * parent, const gchar *label, extern void ext_menubar_add_separator(ext_menu_t *parent) { - ext_menubar_add_generic_entry ( EXT_MENUBAR_SEPARATOR, parent, g_strdup("-"), NULL, NULL, NULL ); + ext_menubar_add_generic_entry ( EXT_MENUBAR_SEPARATOR, parent, "-", NULL, NULL, NULL ); } /* Implementation of external toolbar handlers */ |