diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2018-07-04 21:53:53 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-07-06 07:24:46 +0000 |
| commit | c40c26c04c6a39ef7867a35c50293c666255c9a4 (patch) | |
| tree | 2a29719dcd64d6b6646d6a6b1233255c16863afc /epan/follow.h | |
| parent | 2d36c475f985e0499431ffb93bc65c8738370549 (diff) | |
Follow Stream: ensure linear performance with many packets
Reverse the payload chunks list to achieve a running time of O(n) rather
than O(n²) for insertion of all chunks. Executing a RelWithDebInfo+ASAN
build with `tshark -r chargen-session.pcapng.gz -qz follow,tcp,hex,0`
previously took 11m5s to complete, but now finishes in 16 seconds.
Tested using a capture file with 152k TCP packets (from bug 11777).
Backport note: must update ui/gtk/follow_stream.c too.
Change-Id: Icf70d45f33d4399e53209fb6199d3809608c8d99
Reviewed-on: https://code.wireshark.org/review/28595
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/follow.h')
| -rw-r--r-- | epan/follow.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/follow.h b/epan/follow.h index e3301fee24..99b2050a8a 100644 --- a/epan/follow.h +++ b/epan/follow.h @@ -84,7 +84,7 @@ typedef struct { typedef struct _follow_info { show_stream_t show_stream; char *filter_out_filter; - GList *payload; + GList *payload; /* "follow_record_t" entries, in reverse order. */ guint bytes_written[2]; /* Index with FROM_CLIENT or FROM_SERVER for readability. */ guint32 seq[2]; /* TCP only */ GList *fragments[2]; /* TCP only */ |