aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-umts_fp.c
diff options
context:
space:
mode:
authorsswsdev <sswsdev@gmail.com>2017-04-23 19:20:26 +0300
committerPascal Quantin <pascal.quantin@gmail.com>2017-04-23 16:33:31 +0000
commit5ac71132e24beff2ff2ca1be8420f1d04fa61c48 (patch)
treee5919737e74ddbf6a210352182aa427423ad9a61 /epan/dissectors/packet-umts_fp.c
parent69762f5d1c8f420e7819a9564b8bb1d0b490b6d3 (diff)
UMTS FP: Fix bug in heuristic dissectors
The code was not allowing UDP port types, should ONLY allowed UDP ports. Change-Id: Ida5467313cbc24fcbac7cd432fb4a018cc00bdef Reviewed-on: https://code.wireshark.org/review/21301 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-umts_fp.c')
-rw-r--r--epan/dissectors/packet-umts_fp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-umts_fp.c b/epan/dissectors/packet-umts_fp.c
index bac91ad879..4c1d3d71aa 100644
--- a/epan/dissectors/packet-umts_fp.c
+++ b/epan/dissectors/packet-umts_fp.c
@@ -3899,7 +3899,7 @@ check_payload_crc_for_heur(tvbuff_t *tvb, guint16 header_length)
static guint32
generate_ue_id_for_heur(packet_info *pinfo)
{
- if (pinfo->ptype != PT_UDP && pinfo->src.type == AT_IPv4 && pinfo->dst.type == AT_IPv4) {
+ if (pinfo->ptype == PT_UDP && pinfo->src.type == AT_IPv4 && pinfo->dst.type == AT_IPv4) {
/* This logic assumes FP is delivered over IP/UDP*/
/* Will return the same ID even if the address and ports are reversed */