diff options
author | Bill Meier <wmeier@newsguy.com> | 2014-12-13 12:52:20 -0500 |
---|---|---|
committer | Bill Meier <wmeier@newsguy.com> | 2014-12-13 18:45:56 +0000 |
commit | f412c9a01aa031ef9f024ee1b8ec60bf4a73edb8 (patch) | |
tree | ce4c0543d43c0c6f7b84050a1a187e9381c6b8d0 /epan/dissectors/packet-socks.c | |
parent | 7592d39d46ee0f2442cc5263979a0f036f98468b (diff) |
Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
(for some dissectors which fetch all other integral fields using
ENC_BIG_ENDIAN).
Change-Id: Ic18e3172aad76af12b12d6732c88497be22aed56
Reviewed-on: https://code.wireshark.org/review/5748
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Diffstat (limited to 'epan/dissectors/packet-socks.c')
-rw-r--r-- | epan/dissectors/packet-socks.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/epan/dissectors/packet-socks.c b/epan/dissectors/packet-socks.c index e685dcd881..81f45e3147 100644 --- a/epan/dissectors/packet-socks.c +++ b/epan/dissectors/packet-socks.c @@ -256,7 +256,7 @@ static int display_address(tvbuff_t *tvb, int offset, proto_tree *tree) { int a_type = tvb_get_guint8(tvb, offset); - proto_tree_add_item( tree, hf_socks_address_type, tvb, offset, 1, ENC_NA); + proto_tree_add_item( tree, hf_socks_address_type, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; switch (a_type) @@ -357,7 +357,7 @@ socks_udp_dissector(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) { proto_tree_add_item(socks_tree, hf_socks_reserved2, tvb, offset, 2, ENC_BIG_ENDIAN); offset += 2; - proto_tree_add_item(socks_tree, hf_socks_fragment_number, tvb, offset, 1, ENC_NA); + proto_tree_add_item(socks_tree, hf_socks_fragment_number, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; offset = display_address( tvb, offset, socks_tree); @@ -445,7 +445,7 @@ display_socks_v4(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree_add_item( tree, hf_socks_ver, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; - proto_tree_add_item( tree, hf_socks_cmd, tvb, offset, 1, ENC_NA); + proto_tree_add_item( tree, hf_socks_cmd, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; /* Do remote port */ @@ -528,7 +528,7 @@ client_display_socks_v5(tvbuff_t *tvb, int offset, packet_info *pinfo, num_auth_methods = tvb_get_guint8(tvb, offset); proto_item_set_len(ti, num_auth_methods+1); - proto_tree_add_item( AuthTree, hf_client_auth_method_count, tvb, offset, 1, ENC_NA); + proto_tree_add_item( AuthTree, hf_client_auth_method_count, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; for( i = 0; i < num_auth_methods; ++i) { @@ -550,10 +550,10 @@ client_display_socks_v5(tvbuff_t *tvb, int offset, packet_info *pinfo, } else if (state_info->client == clientV5Command) { - proto_tree_add_item( tree, hf_socks_cmd, tvb, offset, 1, ENC_NA); + proto_tree_add_item( tree, hf_socks_cmd, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; - proto_tree_add_item( tree, hf_socks_reserved, tvb, offset, 1, ENC_NA); + proto_tree_add_item( tree, hf_socks_reserved, tvb, offset, 1, ENC_BIG_ENDIAN); offset += 1; offset = display_address(tvb, offset, tree); @@ -627,7 +627,7 @@ server_display_socks_v5(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, case serverUserReply: auth_status = tvb_get_guint8(tvb, offset); - ti = proto_tree_add_item(tree, hf_server_auth_status, tvb, offset, 1, ENC_NA); + ti = proto_tree_add_item(tree, hf_server_auth_status, tvb, offset, 1, ENC_BIG_ENDIAN); if(auth_status != 0) proto_item_append_text(ti, " (failure)"); else |