diff options
| author | Anders Broman <anders.broman@ericsson.com> | 2007-10-23 05:50:00 +0000 |
|---|---|---|
| committer | Anders Broman <anders.broman@ericsson.com> | 2007-10-23 05:50:00 +0000 |
| commit | 1950ffc2141ffdb7a0b8ec8291b0bf99ac12d9d6 (patch) | |
| tree | a3358964f8621efae38bb4df4903f6b9f3f46ea5 /epan/dissectors/packet-sna.c | |
| parent | e78cce5fbd7a11b0d3122b6d64968c15ea3106f8 (diff) | |
Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace
- col_append_fstr() with faster col_append_str()
- col_add_str() with col_set_str()
when it's safe
svn path=/trunk/; revision=23252
Diffstat (limited to 'epan/dissectors/packet-sna.c')
| -rw-r--r-- | epan/dissectors/packet-sna.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/epan/dissectors/packet-sna.c b/epan/dissectors/packet-sna.c index 8835870694..a76881572d 100644 --- a/epan/dissectors/packet-sna.c +++ b/epan/dissectors/packet-sna.c @@ -899,11 +899,11 @@ dissect_optional_0e(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) } if (bits & 0x40) { if (check_col(pinfo->cinfo, COL_INFO)) - col_add_str(pinfo->cinfo, COL_INFO, + col_set_str(pinfo->cinfo, COL_INFO, "HPR Idle Message"); } else { if (check_col(pinfo->cinfo, COL_INFO)) - col_add_str(pinfo->cinfo, COL_INFO, + col_set_str(pinfo->cinfo, COL_INFO, "HPR Status Message"); } } @@ -1217,7 +1217,7 @@ dissect_nlp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, nhdr_1 = tvb_get_guint8(tvb, index+1); if (check_col(pinfo->cinfo, COL_INFO)) - col_add_str(pinfo->cinfo, COL_INFO, "HPR NLP Packet"); + col_set_str(pinfo->cinfo, COL_INFO, "HPR NLP Packet"); if (tree) { /* Don't bother setting length. We'll set it later after we @@ -1372,7 +1372,7 @@ dissect_nlp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, index += (thdr_len << 2); if (((thdr_8 & 0x20) == 0) && thdr_dlf) { if (check_col(pinfo->cinfo, COL_INFO)) - col_add_str(pinfo->cinfo, COL_INFO, "HPR Fragment"); + col_set_str(pinfo->cinfo, COL_INFO, "HPR Fragment"); if (tvb_offset_exists(tvb, index)) { call_dissector(data_handle, tvb_new_subset(tvb, index, -1, -1), pinfo, @@ -1390,7 +1390,7 @@ dissect_nlp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, if (tvb_get_ntohs(tvb, index+2) == 0x12ce) { /* Route Setup */ if (check_col(pinfo->cinfo, COL_INFO)) - col_add_str(pinfo->cinfo, COL_INFO, + col_set_str(pinfo->cinfo, COL_INFO, "HPR Route Setup"); dissect_gds(tvb_new_subset(tvb, index, -1, -1), pinfo, tree, parent_tree); |