diff options
| author | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2005-08-19 23:28:23 +0000 |
|---|---|---|
| committer | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2005-08-19 23:28:23 +0000 |
| commit | ec488447dc368c42732728d62b1c13d8b5a67e37 (patch) | |
| tree | 184b18d6240b3b937187f770a815c92a37184ad4 /epan/dissectors/packet-smpp.c | |
| parent | 00f45a872caa132b0ad3bb829fb5059ec16e8227 (diff) | |
more sprintf removals,
replace some char arrays on the stack to ep_alloc()ed memory
svn path=/trunk/; revision=15446
Diffstat (limited to 'epan/dissectors/packet-smpp.c')
| -rw-r--r-- | epan/dissectors/packet-smpp.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/epan/dissectors/packet-smpp.c b/epan/dissectors/packet-smpp.c index 0ca039d586..8c5c5380dc 100644 --- a/epan/dissectors/packet-smpp.c +++ b/epan/dissectors/packet-smpp.c @@ -51,6 +51,7 @@ #include <epan/packet.h> #include <epan/prefs.h> +#include <epan/emem.h> #include "packet-tcp.h" /* General-purpose debug logger. @@ -966,7 +967,7 @@ smpp_handle_tlv(proto_tree *tree, tvbuff_t *tvb, int *offset) guint length; guint8 field; guint8 major, minor; - char strval[BUFSIZ]; + char *strval=NULL; if (tvb_reported_length_remaining(tvb, *offset) >= 4) { @@ -1086,7 +1087,8 @@ smpp_handle_tlv(proto_tree *tree, tvbuff_t *tvb, int *offset) field = tvb_get_guint8(tvb, *offset); minor = field & 0x0F; major = (field & 0xF0) >> 4; - sprintf(strval, "%u.%u", major, minor); + strval=ep_alloc(BUFSIZ); + g_snprintf(strval, BUFSIZ, "%u.%u", major, minor); proto_tree_add_string(sub_tree, hf_smpp_SC_interface_version, tvb, *offset, 1, strval); (*offset)++; @@ -1292,15 +1294,16 @@ bind_receiver(proto_tree *tree, tvbuff_t *tvb) int offset = 0; guint8 field; guint8 major, minor; - char strval[BUFSIZ]; + char *strval; + strval=ep_alloc(BUFSIZ); smpp_handle_string(tree, tvb, hf_smpp_system_id, &offset); smpp_handle_string(tree, tvb, hf_smpp_password, &offset); smpp_handle_string(tree, tvb, hf_smpp_system_type, &offset); field = tvb_get_guint8(tvb, offset++); minor = field & 0x0F; major = (field & 0xF0) >> 4; - sprintf(strval, "%u.%u", major, minor); + g_snprintf(strval, BUFSIZ, "%u.%u", major, minor); proto_tree_add_string(tree, hf_smpp_interface_version, tvb, offset - 1, 1, strval); smpp_handle_int1(tree, tvb, hf_smpp_addr_ton, &offset); |