diff options
| author | Hadriel Kaplan <hadrielk@yahoo.com> | 2014-03-06 04:22:31 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2014-03-07 05:03:57 +0000 |
| commit | 058527f3f19a09c332b6877030b13dedf7414c1b (patch) | |
| tree | 31a37c6e7fdfa27bc17f8d3159b43cb45ebd33a7 /epan/dissectors/packet-sip.c | |
| parent | 4fbcfc1289e6af3e090803b287fa508ece4b3822 (diff) | |
Fix bug 9835 disabled second media stream disables all media streams
When a single media line is rejected in an SDP answer, for example a second
'm=video' line, wireshark disables ALL media sessions, instead of just that
one. But per the RFCs, all it should do is disable just the one RTP media
session the m= line represents. This commit fixes that, so that a disabled
media session (one with a m= port of 0) in the SDP answer only disables its
associated/paired media stream in the offer.
Change-Id: I9bd0d3fc88b8eaa55207c9bf3f3e37da7746fd14
Reviewed-on: https://code.wireshark.org/review/526
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-sip.c')
| -rw-r--r-- | epan/dissectors/packet-sip.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c index 646c3b484b..b7a78a7211 100644 --- a/epan/dissectors/packet-sip.c +++ b/epan/dissectors/packet-sip.c @@ -3413,6 +3413,8 @@ dissect_sip_common(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tr } } + /* XXX: why is this called even if setup_sdp_transport() was called before? That will + parse the SDP a second time, for 'application/sdp' media MIME bodies */ found_match = dissector_try_string(media_type_dissector_table, media_type_str_lower_case, next_tvb, pinfo, |