diff options
| author | Anders Broman <anders.broman@ericsson.com> | 2013-07-15 04:50:03 +0000 |
|---|---|---|
| committer | Anders Broman <anders.broman@ericsson.com> | 2013-07-15 04:50:03 +0000 |
| commit | 17c037141447f660142f210b442e61e148dc4c88 (patch) | |
| tree | 984d86aed9757968702f6db5389cafeb1bdebeab /epan/dissectors/packet-scsi-osd.c | |
| parent | 58b3567ccb9e085f2ca61ccf8e8b90b43d6b2ec8 (diff) | |
From Javier Godoy:
fix partitions being inadvertently set as removed.
In dissect_osd_get_attributes and dissect_osd_set_attributes there were calls to dissect_osd_partition_id with the last parameter (is_removed) set to TRUE instead of FALSE. That caused dissect_osd_partition_id reporting the partitions as "removed".
The only service action where is_removed must be TRUE is dissect_osd_remove_partition.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8927
svn path=/trunk/; revision=50603
Diffstat (limited to 'epan/dissectors/packet-scsi-osd.c')
| -rw-r--r-- | epan/dissectors/packet-scsi-osd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-scsi-osd.c b/epan/dissectors/packet-scsi-osd.c index e5f7f4f0fc..8fb82266c2 100644 --- a/epan/dissectors/packet-scsi-osd.c +++ b/epan/dissectors/packet-scsi-osd.c @@ -2542,7 +2542,7 @@ dissect_osd_get_attributes(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, offset+=3; /* partiton id */ - dissect_osd_partition_id(pinfo, tvb, offset, tree, hf_scsi_osd_partition_id, lun_info, FALSE, TRUE); + dissect_osd_partition_id(pinfo, tvb, offset, tree, hf_scsi_osd_partition_id, lun_info, FALSE, FALSE); offset+=8; /* user_object id */ @@ -2760,7 +2760,7 @@ dissect_osd_set_attributes(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, offset+=3; /* partiton id */ - dissect_osd_partition_id(pinfo, tvb, offset, tree, hf_scsi_osd_partition_id, lun_info, FALSE, TRUE); + dissect_osd_partition_id(pinfo, tvb, offset, tree, hf_scsi_osd_partition_id, lun_info, FALSE, FALSE); offset+=8; /* user_object id */ |