diff options
| author | morriss <morriss@f5534014-38df-0310-8fa8-9805f1628bb7> | 2010-12-01 23:12:46 +0000 |
|---|---|---|
| committer | morriss <morriss@f5534014-38df-0310-8fa8-9805f1628bb7> | 2010-12-01 23:12:46 +0000 |
| commit | 75c904bd762f2881d37bb94571f197d89ca50c0b (patch) | |
| tree | 4623209fcb60da4d3b83dcfaa93acf1231fa0240 /epan/dissectors/packet-sccp.c | |
| parent | fd15cd2e6b8fe28dc12575a567232814ea0a9e43 (diff) | |
From Neil Piercy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3301 :
The packet-sccp.c has a bug in the declared valid ranges of the SSN and DPC
values in the user table used to match to a subdissector. The SSN range is 16
bits rather than 8 (not really an issue) but the DPC range is 16 bits rather
than 24 - so many traces cannot be matched by this table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35097 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'epan/dissectors/packet-sccp.c')
| -rw-r--r-- | epan/dissectors/packet-sccp.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/epan/dissectors/packet-sccp.c b/epan/dissectors/packet-sccp.c index 73a4487666..e921fefacd 100644 --- a/epan/dissectors/packet-sccp.c +++ b/epan/dissectors/packet-sccp.c @@ -2913,8 +2913,8 @@ static void sccp_users_free_cb(void*r) { UAT_DEC_CB_DEF(sccp_users, ni, sccp_user_t) -UAT_RANGE_CB_DEF(sccp_users,called_pc,sccp_user_t) -UAT_RANGE_CB_DEF(sccp_users,called_ssn,sccp_user_t) +UAT_RANGE_CB_DEF(sccp_users, called_pc,sccp_user_t) +UAT_RANGE_CB_DEF(sccp_users, called_ssn,sccp_user_t) UAT_VS_DEF(sccp_users, user, sccp_user_t, SCCP_USER_DATA, "Data") /** End SccpUsersTable **/ @@ -3333,10 +3333,10 @@ proto_register_sccp(void) static uat_field_t users_flds[] = { - UAT_FLD_DEC(sccp_users,ni,"Network Indicator","Network Indicator"), - UAT_FLD_RANGE(sccp_users,called_pc,"Called DPCs",65535,"DPCs for which this protocol is to be used"), - UAT_FLD_RANGE(sccp_users,called_ssn,"Called SSNs",65535,"Called SSNs for which this protocol is to be used"), - UAT_FLD_VS(sccp_users,user,"User protocol",sccp_users_vals,"The User Protocol"), + UAT_FLD_DEC(sccp_users, ni, "Network Indicator", "Network Indicator"), + UAT_FLD_RANGE(sccp_users, called_pc, "Called DPCs", 0xFFFFFF, "DPCs for which this protocol is to be used"), + UAT_FLD_RANGE(sccp_users, called_ssn, "Called SSNs", 255, "Called SSNs for which this protocol is to be used"), + UAT_FLD_VS(sccp_users, user, "User protocol", sccp_users_vals, "The User Protocol"), UAT_END_FIELDS }; |