diff options
| author | Pascal Quantin <pascal.quantin@gmail.com> | 2017-09-20 10:14:56 +0200 |
|---|---|---|
| committer | Pascal Quantin <pascal.quantin@gmail.com> | 2017-09-20 10:07:42 +0000 |
| commit | e27870eaa6efa1c2dac08aa41a67fe9f0839e6e0 (patch) | |
| tree | 2ca5ce6f41d0e6694ab2f3aa3a0f3b534edbb6ce /epan/dissectors/packet-rtsp.c | |
| parent | f9207b0f6c9d5aa5a1dfd7748365483795293a5d (diff) | |
RTSP: fix stack use after scope error reported by ASan
Bug: 14077
Change-Id: I9fa0e62fe354b1c18687ba9041029de97719343c
Reviewed-on: https://code.wireshark.org/review/23635
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-rtsp.c')
| -rw-r--r-- | epan/dissectors/packet-rtsp.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/epan/dissectors/packet-rtsp.c b/epan/dissectors/packet-rtsp.c index d2d44f35e0..d56ac3a48d 100644 --- a/epan/dissectors/packet-rtsp.c +++ b/epan/dissectors/packet-rtsp.c @@ -530,6 +530,7 @@ rtsp_create_conversation(packet_info *pinfo, proto_item *ti, gboolean is_video = FALSE; /* FIX ME - need to indicate video or not */ address src_addr; address dst_addr; + guint32 ip4_addr; if (rtsp_type_packet != RTSP_REPLY) { return; @@ -599,7 +600,6 @@ rtsp_create_conversation(packet_info *pinfo, proto_item *ti, else if (sscanf(tmp, "\"%u.%u.%u.%u:%u\"", &ipv4_1, &ipv4_2, &ipv4_3, &ipv4_4, &s_data_port) == 5) { guchar *tmp2; guchar *tmp3; - guint32 ip4_addr; /* Skip leading " */ tmp++; @@ -616,7 +616,6 @@ rtsp_create_conversation(packet_info *pinfo, proto_item *ti, else if (sscanf(tmp, "\"%u.%u.%u.%u\"", &ipv4_1, &ipv4_2, &ipv4_3, &ipv4_4) == 4) { guchar *tmp2; guchar *tmp3; - guint32 ip4_addr; /* Skip leading " */ tmp++; @@ -651,7 +650,6 @@ rtsp_create_conversation(packet_info *pinfo, proto_item *ti, if (sscanf(tmp, "\"%u.%u.%u.%u:%u\"", &ipv4_1, &ipv4_2, &ipv4_3, &ipv4_4, &c_data_port) == 5) { guchar *tmp2; guchar *tmp3; - guint32 ip4_addr; /* Skip leading " */ tmp++; |