diff options
| author | Martin Mathieson <martin.mathieson@keysight.com> | 2020-03-21 20:45:45 +0000 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2020-03-21 21:28:15 +0000 |
| commit | 0af8d7c091d5eca352474a71fd0423b3cebbc5d3 (patch) | |
| tree | 644d86700c88caeb5fb37e5f06989cde218ae624 /epan/dissectors/packet-opensafety.c | |
| parent | 1796abbed660cb1ec370e52d0012d98ceb90c459 (diff) | |
Some cppcheck fixes.
- UDPCP: fix test for Sync frame detection
- Avoid a couple of redundant assignemnts
Change-Id: Ib69a3ff4f0e802ddbbbd29eb2a803372c41a7ce4
Reviewed-on: https://code.wireshark.org/review/36526
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Diffstat (limited to 'epan/dissectors/packet-opensafety.c')
| -rw-r--r-- | epan/dissectors/packet-opensafety.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-opensafety.c b/epan/dissectors/packet-opensafety.c index 76f61c143d..ae1f86d934 100644 --- a/epan/dissectors/packet-opensafety.c +++ b/epan/dissectors/packet-opensafety.c @@ -2482,7 +2482,7 @@ dissect_opensafety_udpdata(tvbuff_t *message_tvb, packet_info *pinfo, proto_tree /* check for openSAFETY frame at beginning of data */ frameFound = findSafetyFrame(message_tvb, 0, global_udp_frame2_first, &frameOffset, &frameLength, NULL ); - if ( ! frameFound || ( frameFound && frameOffset >= 11 ) ) + if ( ! frameFound || ( frameOffset >= 11 ) ) { dissector_handle_t udp_transport = find_dissector ( "opensafety_udp_transport" ); if ( udp_transport != NULL ) |