diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-ntlmssp.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-ntlmssp.c')
| -rw-r--r-- | epan/dissectors/packet-ntlmssp.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/epan/dissectors/packet-ntlmssp.c b/epan/dissectors/packet-ntlmssp.c index 8ca4c2820c..dcf9a3daab 100644 --- a/epan/dissectors/packet-ntlmssp.c +++ b/epan/dissectors/packet-ntlmssp.c @@ -273,6 +273,8 @@ static expert_field ei_ntlmssp_blob_len_too_long = EI_INIT; static expert_field ei_ntlmssp_target_info_attr = EI_INIT; static expert_field ei_ntlmssp_message_type = EI_INIT; +static dissector_handle_t ntlmssp_handle, ntlmssp_wrap_handle; + /* Configuration variables */ const char *gbl_nt_password = NULL; @@ -3277,8 +3279,8 @@ proto_register_ntlmssp(void) "NT Password (used to decrypt payloads)", &gbl_nt_password); - register_dissector("ntlmssp", dissect_ntlmssp, proto_ntlmssp); - register_dissector("ntlmssp_payload", dissect_ntlmssp_payload, proto_ntlmssp); + ntlmssp_handle = register_dissector("ntlmssp", dissect_ntlmssp, proto_ntlmssp); + ntlmssp_wrap_handle = register_dissector("ntlmssp_payload", dissect_ntlmssp_payload, proto_ntlmssp); register_dissector("ntlmssp_data_only", dissect_ntlmssp_payload_only, proto_ntlmssp); register_dissector("ntlmssp_verf", dissect_ntlmssp_verf, proto_ntlmssp); } @@ -3286,12 +3288,8 @@ proto_register_ntlmssp(void) void proto_reg_handoff_ntlmssp(void) { - dissector_handle_t ntlmssp_handle, ntlmssp_wrap_handle; - /* Register protocol with the GSS-API module */ - ntlmssp_handle = find_dissector("ntlmssp"); - ntlmssp_wrap_handle = find_dissector("ntlmssp_verf"); gssapi_init_oid("1.3.6.1.4.1.311.2.2.10", proto_ntlmssp, ett_ntlmssp, ntlmssp_handle, ntlmssp_wrap_handle, "NTLMSSP - Microsoft NTLM Security Support Provider"); |