diff options
| author | Guy Harris <guy@alum.mit.edu> | 2014-10-19 23:14:50 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2014-10-20 06:15:19 +0000 |
| commit | 80e6f6251e96dd7b8a9ab0fdbf63b03a73ef6692 (patch) | |
| tree | 92d519b9b19cccba0d083a6ad20152352daa5924 /epan/dissectors/packet-ntlmssp.c | |
| parent | 0b9eb9f4b71b6632cfb4b87bcdefdfa75eaf2dd0 (diff) | |
Get rid of calls to ctype.h functions.
They don't handle values outside the range -1 to 127, and their behavior
is locale-dependent. Use g_ascii_isXXX() and g_ascii_toXXX() instead of
isXXX() and toXXX().
If you're checking for printable ASCII, don't use isascii() and don't
use iscntrl(), use g_ascii_isprint(). If you're checking for graphical
ASCII, i.e. printable ASCII except for a space, use g_ascii_isgraph().
Use ws_xton() to convert a hex digit character to the corresponding
numeric value.
Change-Id: Id3039bc586fbf66d8736c2df248c790c0d7a2330
Reviewed-on: https://code.wireshark.org/review/4851
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-ntlmssp.c')
| -rw-r--r-- | epan/dissectors/packet-ntlmssp.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/epan/dissectors/packet-ntlmssp.c b/epan/dissectors/packet-ntlmssp.c index 9ad86796ce..8ad765edf4 100644 --- a/epan/dissectors/packet-ntlmssp.c +++ b/epan/dissectors/packet-ntlmssp.c @@ -29,7 +29,6 @@ #include <stdio.h> #endif #include <string.h> -#include <ctype.h> #include <glib.h> @@ -565,7 +564,7 @@ create_ntlmssp_v2_key(const char *nt_password _U_, const guint8 *serverchallenge str_to_unicode(ntlmssph->acct_name, buf); for (j = 0; j < (2*user_len); j++) { if (buf[j] != '\0') { - user_uppercase[j] = toupper(buf[j]); + user_uppercase[j] = g_ascii_toupper(buf[j]); } } } @@ -682,7 +681,7 @@ create_ntlmssp_v1_key(const char *nt_password, const guint8 *serverchallenge, co if (password_len > NTLMSSP_KEY_LEN) password_len = NTLMSSP_KEY_LEN; for (i = 0; i < password_len; i++) { - lm_password_upper[i] = toupper(nt_password[i]); + lm_password_upper[i] = g_ascii_toupper(nt_password[i]); } } else |