aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ncp-nmas.c
diff options
context:
space:
mode:
authorgerald <gerald@f5534014-38df-0310-8fa8-9805f1628bb7>2005-01-14 17:09:11 +0000
committergerald <gerald@f5534014-38df-0310-8fa8-9805f1628bb7>2005-01-14 17:09:11 +0000
commit83bfdd47f7c92e0ac4dabb4513bc3d14f29bfaf5 (patch)
tree95d23575438891d0f07573397f7148518616b563 /epan/dissectors/packet-ncp-nmas.c
parenta840ef3700a72936dad847462d87cdcce597c548 (diff)
From Greg Morris: Improve malformed packet handling.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13034 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'epan/dissectors/packet-ncp-nmas.c')
-rw-r--r--epan/dissectors/packet-ncp-nmas.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-ncp-nmas.c b/epan/dissectors/packet-ncp-nmas.c
index 1f8b8b3a40..f5d6776deb 100644
--- a/epan/dissectors/packet-ncp-nmas.c
+++ b/epan/dissectors/packet-ncp-nmas.c
@@ -504,6 +504,8 @@ dissect_nmas_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ncp_tree, guin
foffset += 4;
break;
case 2:
+ proto_tree_add_text(atree, tvb, foffset, -1, "Verb: %s",
+ val_to_str(subverb, nmas_subverb_enum, "Unknown (%u)"));
proto_tree_add_item(atree, hf_length, tvb, foffset, 4, TRUE);
msg_length = tvb_get_letohl(tvb, foffset);
foffset +=4;
@@ -513,9 +515,7 @@ dissect_nmas_reply(tvbuff_t *tvb, packet_info *pinfo, proto_tree *ncp_tree, guin
roffset = foffset;
foffset += 4;
msg_length -= 8;
- proto_tree_add_text(atree, tvb, foffset, -1, "Verb: %s",
- val_to_str(subverb, nmas_subverb_enum, "Unknown (%u)"));
- if (return_code == 0)
+ if (return_code == 0 && msg_length > 0)
{
switch (subverb) {
case 0: /* Fragmented Ping */