diff options
| author | Jaap Keuter <jaap.keuter@xs4all.nl> | 2020-10-28 12:02:29 +0100 |
|---|---|---|
| committer | Wireshark GitLab Utility <gerald+gitlab-utility@wireshark.org> | 2020-10-28 12:40:44 +0000 |
| commit | 918db88055dd7781e69d7bfcf39c71956437c7ae (patch) | |
| tree | 844ead7113b6d68a0faebb6a5b78200882127d0e /epan/dissectors/packet-mtp3.c | |
| parent | af0c4203a06e73d367840729d6a9de67b75d0966 (diff) | |
Create protocols to the end of the TVB if length unknown upfront
Creating protocols with unknown length must be created to the end of the TVB
first and reined back using proto_set_len() once the length becomes known.
Not doing so can make indentification of problems harder and prevents analysis
engines like MATE from properly processing the generated protocol trees.
With this change the remaining offending dissectors are corrected for this.
Closes #16961
Diffstat (limited to 'epan/dissectors/packet-mtp3.c')
| -rw-r--r-- | epan/dissectors/packet-mtp3.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-mtp3.c b/epan/dissectors/packet-mtp3.c index 71f9c6fef2..559e95a8eb 100644 --- a/epan/dissectors/packet-mtp3.c +++ b/epan/dissectors/packet-mtp3.c @@ -737,7 +737,7 @@ dissect_mtp3(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_ pref_mtp3_standard = mtp3_standard; - mtp3_item = proto_tree_add_item(tree, proto_mtp3, tvb, 0, 0, ENC_NA); + mtp3_item = proto_tree_add_item(tree, proto_mtp3, tvb, 0, -1, ENC_NA); si = tvb_get_guint8(tvb, SIO_OFFSET) & SERVICE_INDICATOR_MASK; if (mtp3_heuristic_standard) { |