diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-16 20:06:11 -0500 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-31 07:31:42 +0000 |
| commit | f4b0abc7296bbb431e64e31f85b24c29196c2ae4 (patch) | |
| tree | 68394f5fdfa1987900f0b079d0ecfd34003e8a5a /epan/dissectors/packet-mp4ves.c | |
| parent | 13964595ad09e5d1115f6c5cb604cded27f9f55d (diff) | |
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-mp4ves.c')
| -rw-r--r-- | epan/dissectors/packet-mp4ves.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/epan/dissectors/packet-mp4ves.c b/epan/dissectors/packet-mp4ves.c index d86db9ad8a..5d555fbc30 100644 --- a/epan/dissectors/packet-mp4ves.c +++ b/epan/dissectors/packet-mp4ves.c @@ -67,10 +67,13 @@ static int ett_mp4ves_config = -1; static expert_field ei_mp4ves_config_too_short = EI_INIT; static expert_field ei_mp4ves_not_dissected_bits = EI_INIT; +static dissector_handle_t mp4ves_name_handle; + /* The dynamic payload type which will be dissected as MP4V-ES */ static guint global_dynamic_payload_type = 0; +static dissector_handle_t mp4ves_handle; /* 14496-2, Annex G, Table G-1. @@ -1017,7 +1020,7 @@ proto_register_mp4ves(void) expert_register_field_array(expert_mp4ves, ei, array_length(ei)); /* Register a configuration option for port */ - register_dissector("mp4ves", dissect_mp4ves, proto_mp4ves); + mp4ves_handle = register_dissector("mp4ves", dissect_mp4ves, proto_mp4ves); register_dissector("mp4ves_config", dissect_mp4ves_config, proto_mp4ves); /* Register a configuration option for port */ @@ -1035,15 +1038,12 @@ proto_register_mp4ves(void) void proto_reg_handoff_mp4ves(void) { - static dissector_handle_t mp4ves_handle; static guint dynamic_payload_type; static gboolean mp4ves_prefs_initialized = FALSE; if (!mp4ves_prefs_initialized) { - dissector_handle_t mp4ves_name_handle; mp4ves_capability_t *ftr; - mp4ves_handle = find_dissector("mp4ves"); dissector_add_string("rtp_dyn_payload_type","MP4V-ES", mp4ves_handle); mp4ves_prefs_initialized = TRUE; |