aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_dtap.c
diff options
context:
space:
mode:
authorAnders Broman <anders.broman@ericsson.com>2009-05-08 18:10:39 +0000
committerAnders Broman <anders.broman@ericsson.com>2009-05-08 18:10:39 +0000
commitb68b9d2ccf763bdcc99acaf16244cc6a3bfb44a1 (patch)
tree67b92235c69eaac1db6a089f1657d3e550dca68e /epan/dissectors/packet-gsm_a_dtap.c
parentfef69c8dd3d698d3c6c3a466ead964e4e0f794cd (diff)
From Reinhard Speyerer:
GSM DTAP: incorrect display of Suppl. Service Message. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3452 Patch slightly modified. svn path=/trunk/; revision=28308
Diffstat (limited to 'epan/dissectors/packet-gsm_a_dtap.c')
-rw-r--r--epan/dissectors/packet-gsm_a_dtap.c13
1 files changed, 9 insertions, 4 deletions
diff --git a/epan/dissectors/packet-gsm_a_dtap.c b/epan/dissectors/packet-gsm_a_dtap.c
index 4a1084af7e..c16fc603a5 100644
--- a/epan/dissectors/packet-gsm_a_dtap.c
+++ b/epan/dissectors/packet-gsm_a_dtap.c
@@ -5742,10 +5742,15 @@ dissect_dtap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
{
/* XXX */
}
- /* In case of Mobility Management and Call Control and Call related SS messages
- * bit 7 and 8 is sequence number
+ /* 3GPP TS 24.008 version 8.5.0 Release 8
+ * Bits 5 to 8 of the first octet of every message belonging to the protocols "Call Control;
+ * call related SS messages" and "Session Management"contain the transaction identifier (TI).
+ * The transaction identifier and its use are defined in 3GPP TS 24.007 [20].
+ * 5 = Mobility Management messages
+ * 3 = Call Control; call related SS messages
+ * 10 = GPRS session management messages
*/
- if((pd==5)||(pd==3)){
+ if((pd==5)||(pd==3)||(pd==10)){
proto_tree_add_item(dtap_tree, hf_gsm_a_seq_no, tvb, offset, 1, FALSE);
}
/*
@@ -5813,7 +5818,7 @@ proto_register_gsm_a_dtap(void)
},
{ &hf_gsm_a_dtap_msg_ss_type,
{ "DTAP Non call Supplementary Service Message Type", "gsm_a.dtap_msg_ss_type",
- FT_UINT8, BASE_HEX, VALS(gsm_a_dtap_msg_ss_strings), 0x0,
+ FT_UINT8, BASE_HEX, VALS(gsm_a_dtap_msg_ss_strings), 0x3f,
NULL, HFILL }
},
{ &hf_gsm_a_dtap_msg_tp_type,