diff options
| author | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-01-05 15:23:53 +0000 |
|---|---|---|
| committer | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-01-05 15:23:53 +0000 |
| commit | ae4ef9853c553c1a0f8710abda15c4080dca159a (patch) | |
| tree | 10b24f9f633913aa7b38c62e26b3e5165c636b2f /epan/dissectors/packet-dua.c | |
| parent | 5efa40982a47b1b057faa813850d9571602cd308 (diff) | |
Don't pass the result of tvb_get_ptr() into a %s format string: the string may
not be NULL terminated. Use tvb_get_ephemeral_string() instead.
svn path=/trunk/; revision=35377
Diffstat (limited to 'epan/dissectors/packet-dua.c')
| -rw-r--r-- | epan/dissectors/packet-dua.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-dua.c b/epan/dissectors/packet-dua.c index da9f749b77..086f673f92 100644 --- a/epan/dissectors/packet-dua.c +++ b/epan/dissectors/packet-dua.c @@ -111,7 +111,7 @@ dissect_text_interface_identifier_parameter(tvbuff_t *parameter_tvb, proto_tree proto_tree_add_item(parameter_tree, hf_text_interface_id, parameter_tvb, TEXT_INTERFACE_ID_OFFSET, interface_id_length, ENC_BIG_ENDIAN); proto_item_append_text(parameter_item, " (%.*s)", interface_id_length, - (const char *)tvb_get_ptr(parameter_tvb, TEXT_INTERFACE_ID_OFFSET, interface_id_length)); + tvb_get_ephemeral_string(parameter_tvb, TEXT_INTERFACE_ID_OFFSET, interface_id_length)); } #define INFO_STRING_OFFSET PARAMETER_VALUE_OFFSET @@ -124,7 +124,7 @@ dissect_info_string_parameter(tvbuff_t *parameter_tvb, proto_tree *parameter_tre info_string_length = tvb_get_ntohs(parameter_tvb, PARAMETER_LENGTH_OFFSET) - PARAMETER_HEADER_LENGTH; proto_tree_add_item(parameter_tree, hf_info_string, parameter_tvb, INFO_STRING_OFFSET, info_string_length, ENC_BIG_ENDIAN); proto_item_append_text(parameter_item, " (%.*s)", info_string_length, - (const char *)tvb_get_ptr(parameter_tvb, INFO_STRING_OFFSET, info_string_length)); + tvb_get_ephemeral_string(parameter_tvb, INFO_STRING_OFFSET, info_string_length)); } #define DLCI_LENGTH 2 |