diff options
| author | lego <lego@f5534014-38df-0310-8fa8-9805f1628bb7> | 2007-08-25 17:29:55 +0000 |
|---|---|---|
| committer | lego <lego@f5534014-38df-0310-8fa8-9805f1628bb7> | 2007-08-25 17:29:55 +0000 |
| commit | cccb78b51386817ba76b402b44afbc0a41784564 (patch) | |
| tree | 16dfc22040ccda35eeb235e06955c929032cbca3 /epan/dissectors/packet-dop.c | |
| parent | 8e50b84e932b3a6b689e7891c5bd297fa11e8e9a (diff) | |
replace oid_to_str_buf() and oid_to_str()
fix a potential buffer overflow due to a very liberal estimate by oid_repr_len()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22659 f5534014-38df-0310-8fa8-9805f1628bb7
Diffstat (limited to 'epan/dissectors/packet-dop.c')
| -rw-r--r-- | epan/dissectors/packet-dop.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/dissectors/packet-dop.c b/epan/dissectors/packet-dop.c index bbe9339a74..bc76091968 100644 --- a/epan/dissectors/packet-dop.c +++ b/epan/dissectors/packet-dop.c @@ -2446,9 +2446,9 @@ static void dissect_ACIItem_PDU(tvbuff_t *tvb _U_, packet_info *pinfo _U_, proto static int call_dop_oid_callback(char *base_oid, tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree, char *col_info) { - char binding_param[MAX_OID_STR_LEN]; + char* binding_param; - g_snprintf(binding_param, MAX_OID_STR_LEN, "%s.%s", base_oid, binding_type ? binding_type : ""); + binding_param = ep_strdup_printf("%s.%s", base_oid, binding_type ? binding_type : ""); if (col_info && (check_col(pinfo->cinfo, COL_INFO))) col_append_fstr(pinfo->cinfo, COL_INFO, " %s", col_info); |