Put in a comment asking about the music going over the connection - we

shouldn't try to parse it as DAAP.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15231 f5534014-38df-0310-8fa8-9805f1628bb7

1 files changed, 5 insertions, 6 deletions

diff --git a/epan/dissectors/packet-daap.c b/epan/dissectors/packet-daap.c
index 9cc5db1542..4e40566187 100644
--- a/epan/dissectors/packet-daap.c
+++ b/epan/dissectors/packet-daap.c
@@ -146,12 +146,13 @@ dissect_daap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
    proto_tree *daap_tree;
    int offset = 0;
    gboolean is_request = (pinfo->destport == TCP_PORT_DAAP);
-   
-   
+
    if (check_col(pinfo->cinfo, COL_PROTOCOL)) 
       col_set_str(pinfo->cinfo, COL_PROTOCOL, "DAAP");
-   
-   
+
+   /*
+    * XXX - what about the music itself?  Check for bogus tag values?
+    */
    if (check_col(pinfo->cinfo, COL_INFO)) {
       if (is_request) {
 	 col_add_str(pinfo->cinfo, COL_INFO, "DAAP Request");
@@ -165,8 +166,6 @@ dissect_daap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
       }
    }
 
-   
-   
    if (tree) {
       ti = proto_tree_add_item(tree, proto_daap, tvb, 0, -1, FALSE);
       daap_tree = proto_item_add_subtree(ti, ett_daap);