diff options
| author | Martin Mathieson <martin.mathieson@keysight.com> | 2020-03-31 22:46:55 +0100 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2020-04-01 10:32:08 +0000 |
| commit | 71e9009825db727fd84f7cbc9cc278df988188b9 (patch) | |
| tree | 9790df3a5df69b2dd683581253539a1703114026 /epan/dissectors/packet-aoe.c | |
| parent | 9b7a54d86c197af42c7b9a0a7925b42a637acd3c (diff) | |
Check for true_false_string with identical true/false string.
Fixed a few instances where fix were obvious, others are
less clear.
The check in proto.c is protected by ENABLE_CHECK_FILTER.
Change-Id: I4edee4e67bd53bbf2eb809d68c87983a7c5a66f3
Reviewed-on: https://code.wireshark.org/review/36645
Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
Diffstat (limited to 'epan/dissectors/packet-aoe.c')
| -rw-r--r-- | epan/dissectors/packet-aoe.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/epan/dissectors/packet-aoe.c b/epan/dissectors/packet-aoe.c index c95809f0f6..4103dca878 100644 --- a/epan/dissectors/packet-aoe.c +++ b/epan/dissectors/packet-aoe.c @@ -58,10 +58,7 @@ static const true_false_string tfs_aflags_e = { "LBA48 extended command", "Normal command" }; -static const true_false_string tfs_aflags_d = { - "?", - "?" -}; + static const true_false_string tfs_aflags_a = { "ASYNCHRONOUS Write", "synchronous write" @@ -424,7 +421,7 @@ proto_register_aoe(void) { &hf_aoe_aflags_e, { "E", "aoe.aflags.e", FT_BOOLEAN, 8, TFS(&tfs_aflags_e), AOE_AFLAGS_E, "Whether this is a normal or LBA48 command", HFILL}}, { &hf_aoe_aflags_d, - { "D", "aoe.aflags.d", FT_BOOLEAN, 8, TFS(&tfs_aflags_d), AOE_AFLAGS_D, NULL, HFILL}}, + { "D", "aoe.aflags.d", FT_BOOLEAN, 8, NULL, AOE_AFLAGS_D, "Device/head register flag", HFILL}}, { &hf_aoe_aflags_a, { "A", "aoe.aflags.a", FT_BOOLEAN, 8, TFS(&tfs_aflags_a), AOE_AFLAGS_A, "Whether this is an asynchronous write or not", HFILL}}, { &hf_aoe_aflags_w, |