diff options
| author | Guy Harris <guy@alum.mit.edu> | 2011-09-22 03:10:30 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2011-09-22 03:10:30 +0000 |
| commit | fd2f8183537eb146960d864bf6b890b2dbc01a10 (patch) | |
| tree | 65569699040f312fa6b9083fa6336dfc9c23faea /epan/dissectors/packet-afs.c | |
| parent | ad1efb6b9c4c2c50289d7264d6ae79afcb1ae7b4 (diff) | |
Use ENC_ values in proto_tree_add_item() calls.
In the AgentX dissector, make the "flags" arguments guint8, to match
what's passed in.
In the AIM dissector, use val_to_str() in col_add_str() calls - it gives
the same result if there's a match, and puts a note in the Info column
if there isn't, and is less complicated.
In the AJP13 dissector:
update the URL for the protocol documentation;
add #defines for message types, and use them;
for "enumerated data type" fields, make the fields numerical
rather than strings and give them the value_string tables;
get rid of col_check() calls;
make a Boolean item an FT_BOOLEAN.
svn path=/trunk/; revision=39085
Diffstat (limited to 'epan/dissectors/packet-afs.c')
| -rw-r--r-- | epan/dissectors/packet-afs.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/epan/dissectors/packet-afs.c b/epan/dissectors/packet-afs.c index 61aee1bce6..05e23d6cbb 100644 --- a/epan/dissectors/packet-afs.c +++ b/epan/dissectors/packet-afs.c @@ -347,13 +347,13 @@ static gint ett_afs_vldb_flags = -1; /* Output a unsigned integer, stored into field 'field' Assumes it is in network byte order, converts to host before using */ #define OUT_UINT64(field) \ - proto_tree_add_item(tree, field, tvb, offset, 8, FALSE); \ + proto_tree_add_item(tree, field, tvb, offset, 8, ENC_BIG_ENDIAN); \ offset += 8; /* Output a unsigned integer, stored into field 'field' Assumes it is in network byte order, converts to host before using */ #define OUT_INT64(field) \ - proto_tree_add_item(tree, field, tvb, offset, 8, FALSE); \ + proto_tree_add_item(tree, field, tvb, offset, 8, ENC_BIG_ENDIAN); \ offset += 8; /* Output a unsigned integer, stored into field 'field' @@ -418,7 +418,7 @@ static gint ett_afs_vldb_flags = -1; i_orxs = tvb_get_ntohl(tvb, offset); \ len_orxs = ((i_orxs+4-1)/4)*4 + 4; \ proto_tree_add_item(tree, field, tvb, offset-4, len_orxs, \ - FALSE); \ + ENC_ASCII|ENC_BIG_ENDIAN); \ offset += len_orxs; \ } @@ -768,7 +768,7 @@ static gint ett_afs_vldb_flags = -1; /* Raw data */ #define OUT_BYTES(field, bytes) \ - proto_tree_add_item(tree, field, tvb, offset, bytes, FALSE);\ + proto_tree_add_item(tree, field, tvb, offset, bytes, ENC_NA);\ offset += bytes; @@ -1597,7 +1597,7 @@ dissect_afs(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) if (tree) { ti = proto_tree_add_item(tree, proto_afs, tvb, offset, -1, - FALSE); + ENC_NA); afs_tree = proto_item_add_subtree(ti, ett_afs); proto_tree_add_text(afs_tree, tvb, 0, 0, |