diff options
| author | j.novak@netsystem.cz <j.novak@netsystem.cz> | 2020-12-13 15:28:36 +0000 |
|---|---|---|
| committer | Jaap Keuter <jaap.keuter@xs4all.nl> | 2020-12-13 15:28:36 +0000 |
| commit | 7f376c7ced445c6373098b8f7f8790a78822fe0a (patch) | |
| tree | f43111fb041a5d2691a8d3fa246a0e88d0d406cd /epan/dissectors/asn1/snmp | |
| parent | 9d2481c9f53ccb86a916dbb434b2c4114653984b (diff) | |
SNMP: Fix checking of SNMP v3 auth if MD5 method is used
When the user enters row to SNMP Users table in wireshark and Authentication model is set to MD5, row is ignored in processing. The reason is that constant for MD5 is 0, but the code checks if the value is defined by simple 'usm_p.user_assoc' condition. Therefore 0 never succeeds.
As item can have only listed values, I think the check can be removed.
Function verified on sample.
I propose to cherry pick the change to all stable branches.
Diffstat (limited to 'epan/dissectors/asn1/snmp')
| -rw-r--r-- | epan/dissectors/asn1/snmp/snmp.cnf | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/epan/dissectors/asn1/snmp/snmp.cnf b/epan/dissectors/asn1/snmp/snmp.cnf index d1fc181daf..20d4bf45c7 100644 --- a/epan/dissectors/asn1/snmp/snmp.cnf +++ b/epan/dissectors/asn1/snmp/snmp.cnf @@ -201,8 +201,7 @@ BulkPDU/request-id bulkPDU_request-id #.FN_FTR SNMPv3Message if( usm_p.authenticated - && usm_p.user_assoc - && usm_p.user_assoc->user.authModel ) { + && usm_p.user_assoc ) { const gchar* error = NULL; proto_item* authen_item; proto_tree* authen_tree = proto_item_add_subtree(usm_p.auth_item,ett_authParameters); |