diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-06-05 22:24:47 -0400 |
|---|---|---|
| committer | Jaap Keuter <jaap.keuter@xs4all.nl> | 2016-06-06 06:03:58 +0000 |
| commit | 57ef06e242dbbce390547d9711f810fc60829219 (patch) | |
| tree | eaadf36f96023dd59c3fd56565bf6e14c9e57431 /echld | |
| parent | 6333b98ea6f7733b150537cbba6f80f3e2d83d43 (diff) | |
*_stdup_printf -> strdup for "single string only" formatting.
Done for performance improvements.
This could probably be done in checkAPIs.pl, but this was just
a quick manual check with grepping.
Change-Id: I91ff102cb528bb00fa2f65489de53890e7e46f2d
Reviewed-on: https://code.wireshark.org/review/15751
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Diffstat (limited to 'echld')
| -rw-r--r-- | echld/echld-int.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/echld/echld-int.h b/echld/echld-int.h index 78c6032dc0..19dadd8213 100644 --- a/echld/echld-int.h +++ b/echld/echld-int.h @@ -176,7 +176,7 @@ char* paramset_get_params_list(param_t* paramsets, const char* fmt) G_GNUC_PRINT static echld_bool_t param_set_ ## Name (char* val , char** err _U_) { char* p; int temp = (int)strtol(val, &p, 10); if (p<=val) { *err = g_strdup("not an integer"); return FALSE; } else { param_ ## Name = temp; return TRUE; } } #define PARAM_BOOL(Name, Default) static gboolean param_ ## Name = Default; \ - static char* param_get_ ## Name (char** err _U_ ) { return g_strdup_printf("%s",param_ ## Name ? "TRUE" : "FALSE"); } \ + static char* param_get_ ## Name (char** err _U_ ) { return g_strdup(param_ ## Name ? "TRUE" : "FALSE"); } \ static echld_bool_t param_set_ ## Name (char* val , char** err _U_) { param_ ## Name = (*val == 'T' || *val == 't') ? TRUE : FALSE; return TRUE;} #define PARAM(Name,Desc) {#Name, param_get_ ## Name, param_set_ ## Name, Desc} |