diff options
| author | Gerald Combs <gerald@wireshark.org> | 2017-02-16 15:31:56 -0800 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2017-02-17 17:19:06 +0000 |
| commit | 560a6c3823cf560b883e29db0a403517def86639 (patch) | |
| tree | 9bdc7d4bc914cb4698af10b329bbe31d4a2e0a82 /doc/rawshark.pod | |
| parent | 48eff6a36bac1526756bbb42a8c9841641792938 (diff) | |
Rawshark: Try to avoid a VC runtime crash.
The MSDN documentation for _read says
"If fd is invalid, the file is not open for reading, or the file is
locked, the invalid parameter handler is invoked, as described in
Parameter Validation."
This means that on Windows, if our parent has closed stdin when we call
_read we'll crash. Add a check to bail out early if that's happened.
Fix a sign cast while we're here.
Change-Id: I8afb75f6e56c6a6c2b62103ba7e2fb635dc85702
Reviewed-on: https://code.wireshark.org/review/20153
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'doc/rawshark.pod')
| -rw-r--r-- | doc/rawshark.pod | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/rawshark.pod b/doc/rawshark.pod index c2c722a2bb..9119839591 100644 --- a/doc/rawshark.pod +++ b/doc/rawshark.pod @@ -199,6 +199,10 @@ Read packet data from I<input source>. It can be either the name of a FIFO (named pipe) or ``-'' to read data from the standard input, and must have the record format specified above. +If you are sending data to rawshark from a parent process on Windows you +should not close rawshark's standard input handle prematurely, otherwise +the C runtime might trigger an exception. + =item -R E<lt>read (display) filterE<gt> Cause the specified filter (which uses the syntax of read/display filters, |