diff options
| author | Jeff Morriss <jeff.morriss.ws@gmail.com> | 2015-05-06 16:03:15 -0400 |
|---|---|---|
| committer | Jeff Morriss <jeff.morriss.ws@gmail.com> | 2015-05-06 20:27:26 +0000 |
| commit | 80358079fe0a7c620b58d3109bfe1ba7e9bf8e3c (patch) | |
| tree | e338dd9e3edb552eec75279de8ce0f659bb6aee9 /diameter | |
| parent | 0f55a0f54751649bad47b5aff53c020589c8beb9 (diff) | |
Add/clarify some comments about how the Experimental-Result-Code AVP is handled.
Specifically we put Experimental-Result-Codes specified by 3GPP in the XML file
and let other vendors' codes be handled through a dissector table.
Change-Id: I2c3977fb959ad84faa5cb90aeb3d191c8b465ede
Reviewed-on: https://code.wireshark.org/review/8319
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Diffstat (limited to 'diameter')
| -rw-r--r-- | diameter/dictionary.xml | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/diameter/dictionary.xml b/diameter/dictionary.xml index 7c9c2b62dc..a46955de02 100644 --- a/diameter/dictionary.xml +++ b/diameter/dictionary.xml @@ -1820,8 +1820,19 @@ <gavp name="Experimental-Result-Code"/> </grouped> </avp> - <!-- 3GPP TS 29.230 version 9.2.0 Release 9, ETSI TS 129 230 V9.2.0 (2010-04) --> + + <!-- Ideally we could specify, in XML, Experimental-Result-Code values for + different Vendor IDs. So far we don't have a way to do that, so: + + 1) The below values are for 3GPP (why 3GPP? Because that's the most + common Vendor ID for the people who did this). Note that + packet-diameter.c assumes that the codes specified here are from 3GPP. + + 2) Other Vendor-IDs are handled by registering a dissector to the + "diameter.vnd_exp_res" dissector table. + --> <avp name="Experimental-Result-Code" code="298" mandatory="must" may-encrypt="no" protected="mustnot" vendor-bit="mustnot"> + <!-- 3GPP TS 29.230 version 9.2.0 Release 9, ETSI TS 129 230 V9.2.0 (2010-04) --> <type type-name="Enumerated"/> <enum name="DIAMETER_FIRST_REGISTRATION" code="2001"/> <enum name="DIAMETER_SUBSEQUENT_REGISTRATION" code="2002"/> |