changes of the coloring rules sometimes crashed as dissection keeps pointers to the color_filter for later reference -> simply deleting the filters leave the pointers invalid -> crash.

for now, don't delete the filters but keep them floating around in memory (leaking) -> at least better than crashing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19421 f5534014-38df-0310-8fa8-9805f1628bb7

1 files changed, 11 insertions, 1 deletions

diff --git a/color_filters.c b/color_filters.c
index aaa132bccf..c8183513d4 100644
--- a/color_filters.c
+++ b/color_filters.c
@@ -190,7 +190,17 @@ void
 color_filters_apply(GSList *cfl)
 {
         /* remove "old" entries */
-        color_filter_list_delete(&color_filter_list);
+/*        color_filter_list_delete(&color_filter_list);*/
+
+        /* deleting the color filters crashes unpredictably 
+         * (e.g. sometimes while clearing the list) :-(
+         *
+         * for now, just clear the list and let the filters remain in memory
+         * until WS is closed -> memory leak
+         *
+         * XXX - move the filters to a "removed list" as before
+         * and delete them if the file is closed (or on rescan of packets or such?) */
+        color_filter_list = NULL;
 
         /* clone all list entries from edit to normal list */
         color_filter_list = color_filter_list_clone(cfl);