diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2015-10-08 12:00:49 +0200 |
|---|---|---|
| committer | Peter Wu <peter@lekensteyn.nl> | 2015-10-14 16:53:36 +0000 |
| commit | 14085e043a2b7f3b53d1c57fe2a06beb691c95dc (patch) | |
| tree | ba2ddda15be6c29eae7a26ada4aca382fbf41769 /cmake | |
| parent | e059e4588636bbe88b3706b962469a2003550b51 (diff) | |
Revert "Another message from Clang for unknown -f and -m flags."
This reverts commit 5e5e2019ee09fb0901f35948f570baff8a884adb.
This change was proposed in https://cmake.org/Bug/view.php?id=13194 to
catch some Clang warnings concerning invalid -m flags, but it is causing
legitimate breakage when setting CMAKE_C_FLAGS=-gsplit-dwarf.
CMakeFiles/CMakeError.log shows:
/usr/bin/clang -gsplit-dwarf -DC__W_VALID CMakeFiles/cmTC_04cc8.dir/src.c.o -o cmTC_04cc8 -rdynamic
clang-3.7: warning: argument unused during compilation: '-gsplit-dwarf'
With the additional regex, basic checks (like -Wall but also -fPIE) are
incorrectly reported as unsupported. Follow upstreams action here and
remove it, it is still not present as of CMake 3.3.2.
Change-Id: I8a1e97b16c2bb929436cca669fdb42f33612c490
Reviewed-on: https://code.wireshark.org/review/10880
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'cmake')
| -rw-r--r-- | cmake/modules/CheckCCompilerFlag.cmake | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/cmake/modules/CheckCCompilerFlag.cmake b/cmake/modules/CheckCCompilerFlag.cmake index ac21e0f756..167db21394 100644 --- a/cmake/modules/CheckCCompilerFlag.cmake +++ b/cmake/modules/CheckCCompilerFlag.cmake @@ -37,7 +37,6 @@ macro (CHECK_C_COMPILER_FLAG _FLAG _RESULT) FAIL_REGEX "command line option .* is valid for .* but not for C" # GNU FAIL_REGEX "unrecognized .*option" # GNU FAIL_REGEX "unknown .*option" # Clang - FAIL_REGEX "argument unused during compilation: " # Clang FAIL_REGEX "optimization flag .* is not supported" # Clang FAIL_REGEX "ignoring unknown option" # MSVC FAIL_REGEX "warning D9002" # MSVC, any lang |