path: root/cfile.h
diff options
authorPeter Wu <peter@lekensteyn.nl>2015-06-22 08:56:34 +0200
committerPeter Wu <peter@lekensteyn.nl>2015-06-23 05:46:18 +0000
commit0c71b13b3e444f7d6d891aa3c9a2bc22601392f5 (patch)
tree351fbdc678cb5203e06ae18d266e675f903ca94e /cfile.h
parent42c324d8182995d45910571f4a3cc7d68be1e39e (diff)
prefs: fix memleak
Calling g_list_remove_link(link, llink) does not free the removed last link llink. g_list_next or g_list_foreach+g_free followed by g_list_free should be used instead such that the data is freed before and then dropped from the list. This fixes a memleak in tshark -r dns.pcap detected by ASAN (single packet). Set pref->default_val.list = NULL just in case, and with symmetry with capture_columns handling. Change-Id: I3cc52e275784037ab40c0b42c68d0dd83b73cd98 Reviewed-on: https://code.wireshark.org/review/9026 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'cfile.h')
0 files changed, 0 insertions, 0 deletions