path: root/capchild
diff options
authorPeter Wu <peter@lekensteyn.nl>2018-04-26 13:38:07 +0200
committerPeter Wu <peter@lekensteyn.nl>2018-04-26 16:15:45 +0000
commitcfc15838bdecb44ce1a17d47ad015cb9a1e8962c (patch)
tree38031f2fb380acd60aeeb25a7f3f8259c6eb18f0 /capchild
parent1a26b56c2667144b6299d4b29b5c39645bb5bd03 (diff)
Fix crash (double-free) on refreshing interfaces list
When normal interfaces are unavailable (chmod -x dumpcap), and after toggling "Disable external capture interfaces" twice and then refreshing the interfaces list (F5), a double-free occurs in ui/iface_lists.c:147 for "global_capture_opts.ifaces_err_info". Change-Id: I98697653ab1c123186892408112c34afdd1766f5 Fixes: v1.99.0-rc1-1005-g35b4487538 ("Handle empty interface lists when the list changes.") Reviewed-on: https://code.wireshark.org/review/27161 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'capchild')
1 files changed, 1 insertions, 0 deletions
diff --git a/capchild/capture_ifinfo.c b/capchild/capture_ifinfo.c
index 0236d468be..d3e893d32f 100644
--- a/capchild/capture_ifinfo.c
+++ b/capchild/capture_ifinfo.c
@@ -92,6 +92,7 @@ capture_interface_list(int *err, char **err_str, void (*update_cb)(void))
g_log(LOG_DOMAIN_CAPTURE, G_LOG_LEVEL_MESSAGE, "Capture Interface List ...");
*err = 0;
+ *err_str = NULL;
/* Try to get our interface list */
ret = sync_interface_list_open(&data, &primary_msg, &secondary_msg, update_cb);