diff options
| author | Michael Mann <mmann78@netscape.net> | 2015-09-11 19:38:05 -0400 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2015-09-13 00:15:35 +0000 |
| commit | 648cf995b108ae2cb6df83e1144b32f34ffb8028 (patch) | |
| tree | d56f6e5f8e9699ba63059f6318a17276c34997f5 /asn1 | |
| parent | e4c0e510b8468861ec03f29859bf29c5c15edb99 (diff) | |
Make other_decode_bitfield_value private to proto.c.
This is further encouragement to not try to manually create a bitstring while formatting a field.
Change-Id: I4efbeb39a210cf1fd26203cd8560859276b333b0
Reviewed-on: https://code.wireshark.org/review/10494
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'asn1')
| -rw-r--r-- | asn1/camel/packet-camel-template.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/asn1/camel/packet-camel-template.c b/asn1/camel/packet-camel-template.c index c9c8b79e69..9986abbea1 100644 --- a/asn1/camel/packet-camel-template.c +++ b/asn1/camel/packet-camel-template.c @@ -386,20 +386,13 @@ dissect_RP_cause_ie(tvbuff_t *tvb, guint32 offset, _U_ guint len, { guint8 oct; guint32 curr_offset; - static char a_bigbuf[1024]; curr_offset = offset; oct = tvb_get_guint8(tvb, curr_offset); *cause_value = oct & 0x7f; - other_decode_bitfield_value(a_bigbuf, oct, 0x7f, 8); - proto_tree_add_uint_format(tree, hf_cause_value, - tvb, curr_offset, 1, *cause_value, - "%s : %s", - a_bigbuf, - val_to_str(*cause_value, camel_RP_Cause_values, - "Unknown Cause (%u), treated as (41) \"Temporary failure\" for MO-SMS or (111) \"Protocol error,unspecified\" for MT-SMS")); + proto_tree_add_uint(tree, hf_cause_value, tvb, curr_offset, 1, oct); curr_offset++; if ((oct & 0x80)) { @@ -1387,7 +1380,7 @@ void proto_register_camel(void) { "LocationInformationGPRS/CellGlobalIdOrServiceAreaIdOrLAI", HFILL }}, { &hf_camel_RP_Cause, { "RP Cause", "camel.RP_Cause", - FT_UINT8, BASE_DEC, NULL, 0, + FT_UINT8, BASE_DEC, VALS(camel_RP_Cause_values), 0x7F, "RP Cause Value", HFILL }}, { &hf_camel_CAMEL_AChBillingChargingCharacteristics, |