diff options
author | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
---|---|---|
committer | Bill Meier <wmeier@newsguy.com> | 2013-10-29 14:09:20 +0000 |
commit | 0ad98563a24b8685545825aac889ef43bfc58809 (patch) | |
tree | d44e5d34582bc2a05ba6be6bd8d818e9a813147f /asn1/rtse | |
parent | 86c145ecb33495023a7966030faab5a69a3067eb (diff) |
From didier gautheron: remove redundant or use faster col_xxx functions
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
Diffstat (limited to 'asn1/rtse')
-rw-r--r-- | asn1/rtse/rtse.cnf | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/asn1/rtse/rtse.cnf b/asn1/rtse/rtse.cnf index 4e470101a6..f37206ebd5 100644 --- a/asn1/rtse/rtse.cnf +++ b/asn1/rtse/rtse.cnf @@ -129,7 +129,7 @@ RTABapdu #.FN_BODY RTTPapdu VAL_PTR=&priority int priority = -1; - col_append_fstr(actx->pinfo->cinfo, COL_INFO, "Turn-Please"); + col_append_str(actx->pinfo->cinfo, COL_INFO, "Turn-Please"); %(DEFAULT_BODY)s @@ -137,7 +137,7 @@ RTABapdu col_append_fstr(actx->pinfo->cinfo, COL_INFO, " (%%d)", priority); #.FN_BODY RTORJapdu - col_append_fstr(actx->pinfo->cinfo, COL_INFO, "Refuse"); + col_append_str(actx->pinfo->cinfo, COL_INFO, "Refuse"); %(DEFAULT_BODY)s @@ -153,7 +153,7 @@ RTABapdu col_append_fstr(actx->pinfo->cinfo, COL_INFO, " (%%s)", val_to_str(reason, rtse_RefuseReason_vals, "reason(%%d)")); #.FN_BODY RTABapdu - col_append_fstr(actx->pinfo->cinfo, COL_INFO, "Abort"); + col_append_str(actx->pinfo->cinfo, COL_INFO, "Abort"); %(DEFAULT_BODY)s |