diff options
| author | Gerald Combs <gerald@wireshark.org> | 2005-01-17 22:35:40 +0000 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2005-01-17 22:35:40 +0000 |
| commit | f44455fa19a29942cde9b0c8029d094e9e726f35 (patch) | |
| tree | 511dcf4024064f21257fdb32296d283afd5d2fd6 /ChangeLog | |
| parent | eee54467b11114c6a58001d01fce5404ff76df37 (diff) | |
Updates for 0.10.9. The NEWS is downright depressing.
svn path=/trunk/; revision=13101
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 4245 |
1 files changed, 2259 insertions, 1986 deletions
@@ -1,3227 +1,3500 @@ ------------------------------------------------------------------------ -r12682 | guy | 2004-12-07 15:09:05 -0600 (Tue, 07 Dec 2004) | 7 lines +r13088 | guy | 2005-01-17 13:30:31 -0600 (Mon, 17 Jan 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - -From Rene Pilz: - - add the protocols GPRS Mobility Managment and GPRS Session - Mangement to gsm_a (dtap); - - bug fix (RAND->128Bits=16Bytes != 12 Bytes). + M /trunk/epan/addr_resolv.c ------------------------------------------------------------------------- -r12681 | gerald | 2004-12-07 15:06:55 -0600 (Tue, 07 Dec 2004) | 4 lines -Changed paths: - M /trunk/epan/dissectors/packet-snmp.c +Use WINDIR rather than SYSTEMROOT - WINDIR is apparently set on Windows +OT as well as NT, while SYSTEMROOT isn't. -The standard environment separator character under Windows is ";". -Net-SNMP expects this in the MIBS environment variable, so don't use -":" in the default MIB list if we're running under Windows. +If it's not set, don't bother looking for the hosts file, rather than +trying a path with a fixed drive letter. If it is set, try the Windows +NT location first and, if that fails, the Windows OT location. ------------------------------------------------------------------------ -r12680 | guy | 2004-12-07 12:21:21 -0600 (Tue, 07 Dec 2004) | 2 lines +r13087 | gerald | 2005-01-17 10:45:15 -0600 (Mon, 17 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/Makefile.nmake + M /trunk/packaging/nsis/ethereal.nsi + M /trunk/tools/win32-setup.sh -Get rid of an unused true_false_string value. +Switch the Windows build environment to GTK 2.4.14. Enable GTK-Wimp by +default in the installer. ------------------------------------------------------------------------ -r12679 | guy | 2004-12-07 11:59:58 -0600 (Tue, 07 Dec 2004) | 2 lines +r13086 | kukosa | 2005-01-17 05:53:36 -0600 (Mon, 17 Jan 2005) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-http.c - -From Brett Kuskie: add more HTTP headers as filterable fields. + M /trunk/tools/asn2eth.py +Support of GeneralizedTime in PER ------------------------------------------------------------------------ -r12678 | guy | 2004-12-07 11:54:08 -0600 (Tue, 07 Dec 2004) | 5 lines +r13085 | kukosa | 2005-01-17 04:09:43 -0600 (Mon, 17 Jan 2005) | 1 line Changed paths: - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h - -Add an entry for the new DLT_GPRS_LLC (so that nobody working on -Ethereal, unaware that the Ethereal team does *NOT* control libpcap -format, thinks they can just grab 169 and use it for their own -purposes). + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-per.h + M /trunk/epan/libethereal.def +ASN.1 PER VisibleString support ------------------------------------------------------------------------ -r12677 | gerald | 2004-12-07 10:17:50 -0600 (Tue, 07 Dec 2004) | 2 lines +r13084 | guy | 2005-01-17 02:13:02 -0600 (Mon, 17 Jan 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-bvlc.c - -Check for a bogus length value. + M /trunk/epan/dissectors/packet-aim-bos.c + M /trunk/epan/dissectors/packet-aim-icq.c + M /trunk/epan/dissectors/packet-aim-location.c + M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-aim-signon.c + M /trunk/epan/dissectors/packet-aim-ssi.c + M /trunk/epan/dissectors/packet-aim.c ------------------------------------------------------------------------- -r12676 | jmayer | 2004-12-07 05:13:58 -0600 (Tue, 07 Dec 2004) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-aoe.c - M /trunk/epan/dissectors/packet-dcerpc-pn-io.c - M /trunk/epan/dissectors/packet-pn-dcp.c - M /trunk/epan/dissectors/packet-pn-rt.c +If a given TLV type isn't found in an aim_tlv table, just use "Unknown" +as the description - some aim_tlv tables have NULL in the end-of-table +entry. -svn propset svn:keywords Id svn:eol-style native ..... -Add $Id: $ where missing +For those that don't, replace "Unknown" with NULL; "Unknown" is now +redundant. ------------------------------------------------------------------------ -r12675 | sahlberg | 2004-12-06 22:28:37 -0600 (Mon, 06 Dec 2004) | 3 lines +r13083 | guy | 2005-01-16 21:39:58 -0600 (Sun, 16 Jan 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-dnp.c -update one of the command names +When assembling application layer chunks, don't include the transport +layer byte in the reassembled data - including it means we have to pass +to "tvb_new_real_data()" a pointer to the *second* byte of a mallocated +chunk of data, but that would require us to have the free routine for +the new tvbuff back that pointer up before freeing it (we aren't doing +that currently, which means that "free()" either complains bitterly or, +potentially, corrupts the arena, causing crashes later). +Put in some XXX comments about some issues seen when looking at the +code. ------------------------------------------------------------------------ -r12674 | sahlberg | 2004-12-06 21:16:34 -0600 (Mon, 06 Dec 2004) | 3 lines +r13082 | guy | 2005-01-16 19:11:39 -0600 (Sun, 16 Jan 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-aoe.c - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/etypes.h - -create a proper ETHERTYPE for ATAoverEthernet + M /trunk/epan/proto.c +Add the source file name and line number to the dissector bug report +(not as useful as for bugs caught in the dissector itself, but still may +be useful). ------------------------------------------------------------------------ -r12673 | sahlberg | 2004-12-06 21:00:21 -0600 (Mon, 06 Dec 2004) | 4 lines +r13081 | guy | 2005-01-16 18:56:56 -0600 (Sun, 16 Jan 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-aoe.c - -new protocol: ATAoverETHERNET (AoE) - + M /trunk/epan/proto.c +Use REPORT_DISSECTOR_BUG() for the "bogus length" error in +"alloc_field_info()", so the error report can include the field with the +problem. (The file and line number isn't interesting - the bug isn't in +"alloc_field_info()", it's in the dissector that called the routine +calling "alloc_field_info()" - but the field name/abbrevition is +interesting, as it'd help developers identify the place in the dissector +where we're passing in a bogus length.) ------------------------------------------------------------------------ -r12672 | gerald | 2004-12-06 17:12:32 -0600 (Mon, 06 Dec 2004) | 2 lines +r13080 | lroland | 2005-01-16 18:23:43 -0600 (Sun, 16 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ppp.c - -Add more suboption length checks to dissect_bap_phone_delta_opt(). + M /trunk/tools/unix2dos.pl +Convert files with mixed (unix and DOS) EOL-style correctly. ------------------------------------------------------------------------ -r12671 | gerald | 2004-12-06 16:32:50 -0600 (Mon, 06 Dec 2004) | 2 lines +r13079 | guy | 2005-01-16 18:18:39 -0600 (Sun, 16 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sap.c + M /trunk/epan/proto.h -Check for a bogus authentication subheader length. +Add a REPORT_DISSECTOR_BUG() macro to let caller-specified messages be +used in DissectorError exceptions. ------------------------------------------------------------------------ -r12670 | ulfl | 2004-12-06 12:05:14 -0600 (Mon, 06 Dec 2004) | 2 lines +r13078 | guy | 2005-01-16 17:30:55 -0600 (Sun, 16 Jan 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-dcerpc-pn-io.c - A /trunk/epan/dissectors/packet-pn-dcp.c - A /trunk/epan/dissectors/packet-pn-rt.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/exceptions.h + M /trunk/epan/proto.c + M /trunk/epan/proto.h + +Rename the FieldError exception to DissectorError. + +Add a DISSECTOR_ASSERT() macro, which is the usual type of assertion +macro, but throws a DissectorError exception with a message giving the +flien and line number and the failed test as a string. Use that macro +in "alloc_field_info()". + +Report that exception in the Info column and the protocol tree, as well +as logging the exception failure with g_warning(). + +------------------------------------------------------------------------ +r13077 | lroland | 2005-01-16 17:26:02 -0600 (Sun, 16 Jan 2005) | 3 lines +Changed paths: + M /trunk/asn1/MAP_Dialogue/Makefile.nmake + M /trunk/asn1/cmip/Makefile.nmake + M /trunk/asn1/cms/Makefile.nmake + M /trunk/asn1/ess/Makefile.nmake + M /trunk/asn1/gsmmap/Makefile.nmake + M /trunk/asn1/h225/Makefile.nmake + M /trunk/asn1/h235/Makefile.nmake + M /trunk/asn1/h245/Makefile.nmake + M /trunk/asn1/h248/Makefile.nmake + M /trunk/asn1/h450/Makefile.nmake + M /trunk/asn1/logotype-cert-extn/Makefile.nmake + M /trunk/asn1/ns-cert-exts/Makefile.nmake + M /trunk/asn1/ocsp/Makefile.nmake + M /trunk/asn1/pkcs1/Makefile.nmake + M /trunk/asn1/pkinit/Makefile.nmake + M /trunk/asn1/pkix1explicit/Makefile.nmake + M /trunk/asn1/pkix1implicit/Makefile.nmake + M /trunk/asn1/pkixcmp/Makefile.nmake + M /trunk/asn1/pkixcrmf/Makefile.nmake + M /trunk/asn1/pkixproxy/Makefile.nmake + M /trunk/asn1/pkixqualified/Makefile.nmake + M /trunk/asn1/pkixtsp/Makefile.nmake + M /trunk/asn1/smrse/Makefile.nmake + M /trunk/asn1/x509af/Makefile.nmake + M /trunk/asn1/x509ce/Makefile.nmake + M /trunk/asn1/x509if/Makefile.nmake + M /trunk/asn1/x509sat/Makefile.nmake + +When using Cygwin's python asn2eth.py +generates dissectors with mixed EOL! SVN doesn't allow you to commit such files. +Add a target to all nmake makefiles in asn1 subdirectory which will fix these files. +------------------------------------------------------------------------ +r13076 | lroland | 2005-01-16 15:21:41 -0600 (Sun, 16 Jan 2005) | 4 lines +Changed paths: + M /trunk/asn1/h225/h225.cnf + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h -(on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland): -first part of the PROFINET dissectors (PN-RT, PN-DCP and PN-IO) still some work to be done ... +Add a few more things to the h225 dissector that got lost. +Lost things left: +-h.450 stuff +-support for the h.323 conversations tap (It is currently broken.) ------------------------------------------------------------------------ -r12669 | sahlberg | 2004-12-05 15:47:49 -0600 (Sun, 05 Dec 2004) | 6 lines +r13075 | guy | 2005-01-16 14:26:19 -0600 (Sun, 16 Jan 2005) | 7 lines Changed paths: - M /trunk/asn1/pkix1implicit/PKIX1IMPLICIT93.asn - M /trunk/asn1/pkix1implicit/packet-pkix1implicit-template.c - M /trunk/asn1/pkix1implicit/packet-pkix1implicit-template.h - M /trunk/asn1/pkix1implicit/pkix1implicit.cnf - M /trunk/asn1/pkix1implicit/pkix1implicit_exp.cnf - A /trunk/asn1/pkixtsp - A /trunk/asn1/pkixtsp/Makefile - A /trunk/asn1/pkixtsp/PKIXTSP.asn - A /trunk/asn1/pkixtsp/packet-pkixtsp-template.c - A /trunk/asn1/pkixtsp/packet-pkixtsp-template.h - A /trunk/asn1/pkixtsp/pkixtsp.cnf - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-pkix1implicit.c - M /trunk/epan/dissectors/packet-pkix1implicit.h - A /trunk/epan/dissectors/packet-pkixtsp.c - A /trunk/epan/dissectors/packet-pkixtsp.h - -updates to pkix1implicit (we have to think about how to rewrite both pkix1eplicit and pkix1implicit to avoid the crap with duplicate definitions from x509) - -New protocol : RFC3161 PKIX TimeStamp Protocol + M /trunk/epan/dissectors/packet-cops.c +Make the object length variable in some routines an "int"; we fetch a +16-bit unsigned value into it, but we might round it up to a multiple of +4 bytes, which could overflow a guint16. Make arguments corresponding +to them "int" as well. +Use the reported length in "cops_analyze_packetcable_mm_obj()". ------------------------------------------------------------------------ -r12668 | gerald | 2004-12-05 12:40:35 -0600 (Sun, 05 Dec 2004) | 2 lines +r13074 | ulfl | 2005-01-16 10:06:15 -0600 (Sun, 16 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-frame.h + M /trunk/epan/dissectors/packet-ieee8023.c + M /trunk/epan/dissectors/packet-isl.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-ses.c + M /trunk/epan/exceptions.h + M /trunk/epan/proto.c -Grab the last (and null) byte of the content type value. +throw the new FieldError exception, if a dissector tries to add a field with invalid parameters + +add a message parameter to the show_exception function +------------------------------------------------------------------------ +r13073 | jmayer | 2005-01-16 09:45:21 -0600 (Sun, 16 Jan 2005) | 1 line +Changed paths: + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_util.h + M /trunk/plugins/mate/packet-mate.c + +Some trivial warning fixes in mate +------------------------------------------------------------------------ +r13072 | guy | 2005-01-16 04:38:21 -0600 (Sun, 16 Jan 2005) | 2 lines +Changed paths: + A /trunk/asn1/MAP_Dialogue/Makefile.nmake + A /trunk/asn1/cmip/Makefile.nmake + A /trunk/asn1/cms/Makefile.nmake + A /trunk/asn1/ess/Makefile.nmake + A /trunk/asn1/gsmmap/Makefile.nmake + A /trunk/asn1/h235/Makefile.nmake + A /trunk/asn1/h245/Makefile.nmake + A /trunk/asn1/h248/Makefile.nmake + A /trunk/asn1/h450/Makefile.nmake + A /trunk/asn1/logotype-cert-extn/Makefile.nmake + A /trunk/asn1/ns-cert-exts/Makefile.nmake + A /trunk/asn1/ocsp/Makefile.nmake + A /trunk/asn1/pkcs1/Makefile.nmake + A /trunk/asn1/pkinit/Makefile.nmake + A /trunk/asn1/pkix1explicit/Makefile.nmake + A /trunk/asn1/pkix1implicit/Makefile.nmake + A /trunk/asn1/pkixcmp/Makefile.nmake + A /trunk/asn1/pkixcrmf/Makefile.nmake + A /trunk/asn1/pkixproxy/Makefile.nmake + A /trunk/asn1/pkixqualified/Makefile.nmake + A /trunk/asn1/pkixtsp/Makefile.nmake + A /trunk/asn1/smrse/Makefile.nmake + A /trunk/asn1/x509af/Makefile.nmake + A /trunk/asn1/x509ce/Makefile.nmake + A /trunk/asn1/x509if/Makefile.nmake + A /trunk/asn1/x509sat/Makefile.nmake + +Supply Makefile.nmake files. + +------------------------------------------------------------------------ +r13071 | guy | 2005-01-16 04:19:21 -0600 (Sun, 16 Jan 2005) | 5 lines +Changed paths: + M /trunk/asn1/MAP_Dialogue/Makefile + M /trunk/asn1/cmip/Makefile + M /trunk/asn1/cms/Makefile + M /trunk/asn1/ess/Makefile + M /trunk/asn1/gsmmap/Makefile + M /trunk/asn1/h225/Makefile + M /trunk/asn1/h248/Makefile + M /trunk/asn1/logotype-cert-extn/Makefile + M /trunk/asn1/ocsp/Makefile + M /trunk/asn1/pkcs1/Makefile + M /trunk/asn1/pkinit/Makefile + M /trunk/asn1/pkix1explicit/Makefile + M /trunk/asn1/pkix1implicit/Makefile + M /trunk/asn1/pkixcmp/Makefile + M /trunk/asn1/pkixcrmf/Makefile + M /trunk/asn1/pkixproxy/Makefile + M /trunk/asn1/pkixqualified/Makefile + M /trunk/asn1/pkixtsp/Makefile + M /trunk/asn1/smrse/Makefile + M /trunk/asn1/x509af/Makefile + M /trunk/asn1/x509ce/Makefile + M /trunk/asn1/x509if/Makefile + M /trunk/asn1/x509sat/Makefile ------------------------------------------------------------------------- -r12667 | jmayer | 2004-12-04 09:42:18 -0600 (Sat, 04 Dec 2004) | 1 line -Changed paths: - M /trunk/wiretap/README.airmagnet +Make the Makefile look like the h235 Makefiles, with the new rules. -Fix some typos ------------------------------------------------------------------------- -r12666 | jmayer | 2004-12-04 09:35:51 -0600 (Sat, 04 Dec 2004) | 1 line -Changed paths: - M /trunk/wiretap/README.airmagnet +Get rid of their "executable" property, and set svn:keywords to Id and +svn:eol-style to native if they're not already set. -Updates by Martin Regner ------------------------------------------------------------------------ -r12665 | jmayer | 2004-12-04 03:12:24 -0600 (Sat, 04 Dec 2004) | 1 line +r13070 | guy | 2005-01-16 04:17:53 -0600 (Sun, 16 Jan 2005) | 2 lines Changed paths: - M /trunk/wiretap/README.airmagnet + A /trunk/asn1/h235/Makefile + A /trunk/asn1/h245/Makefile + A /trunk/asn1/h450/Makefile + A /trunk/asn1/ns-cert-exts/Makefile + +Add Makefiles. -Add a bit of info that should be present in a capture ------------------------------------------------------------------------ -r12664 | guy | 2004-12-03 14:51:10 -0600 (Fri, 03 Dec 2004) | 2 lines +r13069 | guy | 2005-01-16 03:17:16 -0600 (Sun, 16 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-bittorrent.c + M /trunk/asn1/h225/Makefile.nmake -Add a URL for the BitTorrent protocol spec. +Make the dissector files depend on asn2eth.py, so they're regenerated if +it's modified. ------------------------------------------------------------------------ -r12663 | guy | 2004-12-03 03:51:16 -0600 (Fri, 03 Dec 2004) | 12 lines +r13068 | guy | 2005-01-16 03:16:36 -0600 (Sun, 16 Jan 2005) | 5 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/asn1/h225/Makefile -From Tomasz Mrugalski: - -- option values updated to match RFC3898 (NIS/NIS+ options) -- FQDN option added (draft-ietf-dhc-dhcpv6-opt-fqdn-00.txt) -- Lifetime option added (draft-ietf-dhc-dhcpv6-opt-lifetime-00.txt) -- Long lasting typo corrected (those are identiTy associations, not - identiFy associations) -- Fixed bug always reporting SIP DOMAIN option to be malformed (break was - missing) -- Domains names are now parsed (in DOMAIN_LIST, SIP_SERVER_A, NIS_DOMAIN - and NISPLUS_DOMAIN options). +Make the rules match those of Makefile.nmake - make "all" and +"generate_dissector" generate the dissector files but not copy them to +epan/dissectors, add a "copy_files" rule to copy them, and add a "clean" +rule to clean up. ------------------------------------------------------------------------ -r12662 | sahlberg | 2004-12-02 23:53:09 -0600 (Thu, 02 Dec 2004) | 3 lines +r13067 | guy | 2005-01-16 03:09:57 -0600 (Sun, 16 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - -make the tcp dissector distinguish between duplicate acks and window updates + A /trunk/asn1/h225/Makefile +Add a Makefile. ------------------------------------------------------------------------ -r12661 | guy | 2004-12-02 15:24:12 -0600 (Thu, 02 Dec 2004) | 2 lines +r13066 | guy | 2005-01-16 03:06:25 -0600 (Sun, 16 Jan 2005) | 3 lines Changed paths: - M /trunk/README.hpux + A /trunk/asn1/h225/Makefile.nmake (from /trunk/asn1/h225/makefile.nmake2:13065) + D /trunk/asn1/h225/makefile.nmake2 -Add some additional notes based on comments by Rick Jones. +Phase 2 of renaming "makefile.nmake" to "Makefile.nmake", to match other +Makefile.nmake files. ------------------------------------------------------------------------ -r12660 | lroland | 2004-12-02 14:16:17 -0600 (Thu, 02 Dec 2004) | 1 line +r13065 | guy | 2005-01-16 03:05:45 -0600 (Sun, 16 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/libethereal.def + D /trunk/asn1/h225/makefile.nmake + A /trunk/asn1/h225/makefile.nmake2 (from /trunk/asn1/h225/makefile.nmake:13053) -Don't export flags_set_truth from libethereal.dll. It can't be used in a plugin on win32 to initialize static variables, e.g. hf_register_info arrays. ------------------------------------------------------------------------- -r12659 | lroland | 2004-12-02 13:41:56 -0600 (Thu, 02 Dec 2004) | 1 line -Changed paths: - M /trunk/gtk/main.c +Phase 1 of renaming "makefile.nmake" to "Makefile.nmake" - this is a bit +of a pain on case-insensitive file systems. -Don't ethclist.h in main.c, when we don't need it. ------------------------------------------------------------------------ -r12658 | guy | 2004-12-02 13:17:40 -0600 (Thu, 02 Dec 2004) | 2 lines +r13064 | guy | 2005-01-16 02:45:11 -0600 (Sun, 16 Jan 2005) | 5 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/wiretap/pppdump.c -We don't use our own clist for GTK+ 1.3[.x], either. +When we get an EOF, only return WTAP_ERR_SHORT_READ as the error if we +were in the middle of processing a record. If we got one at the +*beginning* of the record, that just means we've come to a clean +end-of-file. ------------------------------------------------------------------------ -r12657 | guy | 2004-12-02 05:30:24 -0600 (Thu, 02 Dec 2004) | 3 lines +r13063 | guy | 2005-01-15 22:25:27 -0600 (Sat, 15 Jan 2005) | 14 lines Changed paths: M /trunk/AUTHORS - M /trunk/epan/prefs.c - M /trunk/epan/prefs.h - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/capture_info_dlg.c - M /trunk/gtk/gui_prefs.c - M /trunk/gtk/main.c - M /trunk/gtk/ui_util.c - M /trunk/gtk/ui_util.h + M /trunk/epan/dissectors/packet-stun.c -From Nathan Jennings: add a preference that supplies a prefix for window -titles. +From Jon Ringle: ------------------------------------------------------------------------- -r12656 | guy | 2004-12-02 02:38:59 -0600 (Thu, 02 Dec 2004) | 2 lines -Changed paths: - M /trunk/gtk/rtp_analysis.c + don't dissect attributes if there aren't any; -From Francisco Alcoba: handle inverted time stamps without hanging. + put each attribute into a subtree; + + register the dissector by name. + +Use "match_strval()" to check whether the message type is a known STUN +message type, and to generate the message type for the Info column. + +Don't use "tvb_bytes_exist()" to check when we run out of data - use the +length fields from the packet. Check the sanity of those lengths, too. ------------------------------------------------------------------------ -r12655 | guy | 2004-12-02 02:28:10 -0600 (Thu, 02 Dec 2004) | 3 lines +r13062 | guy | 2005-01-15 21:09:05 -0600 (Sat, 15 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c + M /trunk/Makefile.common + M /trunk/tethereal.c -From David Fort: the DNS RR type number for IPSECKEY will be changing to -45, so update the dissector. +Report a friendlier name, if possible, when capturing in Tethereal. ------------------------------------------------------------------------ -r12654 | guy | 2004-12-02 01:53:59 -0600 (Thu, 02 Dec 2004) | 3 lines +r13061 | guy | 2005-01-15 20:56:28 -0600 (Sat, 15 Jan 2005) | 4 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/Makefile.common + M /trunk/capture.c + D /trunk/capture_combo_utils.c + D /trunk/capture_combo_utils.h + A /trunk/capture_ui_utils.c (from /trunk/capture_combo_utils.c:13060) + A /trunk/capture_ui_utils.h (from /trunk/capture_combo_utils.h:13060) + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/capture_info_dlg.c + M /trunk/gtk/capture_prefs.c -We're not using our own clist for GTK+ 2.x, so call -"init_eth_clist_type()" only for GTK+ 1.2[.x]. +Rename capture_combo_utils.{c,h} to capture_ui_utils.{c,h}, as the code +in there is for UI functions including, but not limited to, the combo +box in capture dialogs. ------------------------------------------------------------------------ -r12653 | sahlberg | 2004-12-01 21:12:24 -0600 (Wed, 01 Dec 2004) | 5 lines +r13060 | guy | 2005-01-15 20:48:41 -0600 (Sat, 15 Jan 2005) | 8 lines Changed paths: - M /trunk/gtk/ethclist.c - M /trunk/gtk/ethclist.h - M /trunk/gtk/main.c - -performance enhancement: - in some profiling runs eth_clist_get_type() took ~6% change this to just a variable and initialize it explicitely from main.c + M /trunk/capture.c + M /trunk/capture_combo_utils.c + M /trunk/capture_combo_utils.h + M /trunk/gtk/capture_info_dlg.c +Use a more descriptive name, if available, for the network interface in +window titles even on UN*X, and if the user's specified a description +for an interface, use that rather than the description supplied by +libpcap. +Put the interface name into the main window title when doing a live +capture. ------------------------------------------------------------------------ -r12652 | sahlberg | 2004-12-01 18:12:54 -0600 (Wed, 01 Dec 2004) | 3 lines +r13059 | guy | 2005-01-15 19:22:53 -0600 (Sat, 15 Jan 2005) | 7 lines Changed paths: - M /trunk/gtk/main.c - M /trunk/gtk/menu.c + M /trunk/epan/dissectors/packet-x11.c -make ethereal compile with --without-pcap configuration option +The keycode_first and keycode_count arguments to "listOfKeysyms()" can +come directly from packet data, so don't abort if they define a sequence +of keycodes that goes past 255 - just report errors for the keycodes +past 255. +Clean up indentation. ------------------------------------------------------------------------ -r12651 | guy | 2004-12-01 17:55:43 -0600 (Wed, 01 Dec 2004) | 3 lines +r13058 | guy | 2005-01-15 18:48:25 -0600 (Sat, 15 Jan 2005) | 2 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-x11.c -Move the #ifdef/#endif a bit so that the entire chunk of -live-capture-related-code is inside it. +Revert to the previous formatting of the item. ------------------------------------------------------------------------ -r12650 | sahlberg | 2004-12-01 17:47:14 -0600 (Wed, 01 Dec 2004) | 4 lines +r13057 | guy | 2005-01-15 18:29:54 -0600 (Sat, 15 Jan 2005) | 7 lines Changed paths: - M /trunk/tethereal.c - -minor fix to tethereal to allow it to compile with --without-pcap + M /trunk/epan/dissectors/packet-x11.c +Display the keycode list for a modifier a bit differently (don't list +the modifier name for every keycode, just give the modifier name once +and then show all the keycodes), and use "proto_item_append_text()" +rather than building a string. +Clean up white space. ------------------------------------------------------------------------ -r12649 | gerald | 2004-12-01 17:18:20 -0600 (Wed, 01 Dec 2004) | 2 lines +r13056 | guy | 2005-01-15 17:45:37 -0600 (Sat, 15 Jan 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/dissectors/packet-gsm_sms.c -Replace GRE_FR with ETHERTYPE_RAW_FR. +Correction for TP-Validity-Period extended format, from Victor Stratan: ------------------------------------------------------------------------- -r12648 | etxrab | 2004-12-01 15:59:03 -0600 (Wed, 01 Dec 2004) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-nsip.c + Fix 1: + Offset not incremented for relative type + + Fix 2: + Semioctets not reversed for HHMMSS relative type -Make the Ericsson internal decode of IP addresses a preference instead of IF DEFS, default off. ------------------------------------------------------------------------ -r12647 | guy | 2004-12-01 15:13:39 -0600 (Wed, 01 Dec 2004) | 2 lines +r13055 | guy | 2005-01-15 17:36:24 -0600 (Sat, 15 Jan 2005) | 17 lines Changed paths: - M /trunk/etypes.h + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-l2tp.c + M /trunk/epan/dissectors/packet-mpls.c + +From Carlos Pignataro: Layer Two Tunneling Protocol version 3 [L2TPv3] +updates and enhancements: -Clean up a comment. + - Added Cookie and L2-Specific sublayer support via preferences dialog. + - Added carried payload dissecting support from draft-ietf-l2tpext-pwe3-* + and draft-townsley-l2tpv3-mpls-02.txt + - Completed missing message types (call types) and result codes for stopccn + and cdn. + - Fixed conditionals for avp_vendor_id (Vendor-Specific AVPs) + - Changed Pseudowire Capabilities List AVPs to use subtree instead of tab + - Added numeric value of result and error codes + - Added Session ID for v3 data packets and missing flags and reserved + - Added version to the L2TPv3 protocol tree + - Changed `Tunnel Id' to `Control Connection Id' for v3 + - Fixed offset for ctrl_tree on L2TPv3 over UDP + - Added `L2TPv3' in the COL_PROTOCOL and fixed handling of L2TP version ------------------------------------------------------------------------ -r12646 | guy | 2004-12-01 15:11:48 -0600 (Wed, 01 Dec 2004) | 7 lines +r13054 | guy | 2005-01-15 17:34:29 -0600 (Sat, 15 Jan 2005) | 3 lines Changed paths: - M /trunk/etypes.h - -Explain the two IEEE URLs. + M /trunk/plugins/mate/mate_util.c -Get rid of a non-ASCII character in a comment - it might or might not -display as a "registered trademark" symbol, depending on your editor and -on the character set and character encoding it's using, so just use -"(R)" instead. +Set fp to NULL before "load_loal_error()" is called, so we don't pass an +uninitalized variable to it. ------------------------------------------------------------------------ -r12645 | etxrab | 2004-12-01 15:06:30 -0600 (Wed, 01 Dec 2004) | 1 line +r13053 | ulfl | 2005-01-15 13:37:35 -0600 (Sat, 15 Jan 2005) | 1 line Changed paths: - M /trunk/greproto.h + M /trunk/docbook/eug_src/EUG_chapter_introduction.xml + M /trunk/docbook/eug_src/EUG_preface.xml -Get rid of a not needed define. +add a link to the wiki at appropriate places ------------------------------------------------------------------------ -r12644 | guy | 2004-12-01 15:05:45 -0600 (Wed, 01 Dec 2004) | 2 lines +r13052 | ulfl | 2005-01-15 13:07:05 -0600 (Sat, 15 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/dissectors/packet-gre.c + M /trunk/docbook/eug_src/EUG_chapter_customize.xml + M /trunk/docbook/eug_src/EUG_chapter_use.xml + M /trunk/docbook/eug_src/EUG_chapter_work.xml + M /trunk/docbook/user-guide.xml -Fix a typo. +I've removed the preference pages screenshots, as there was no description of the settings. I've added a link to the wiki pages and updated them accordingly (hopefully someone else might put the explanation text in there). +This way, we will have all preference descriptions at one place. ------------------------------------------------------------------------ -r12643 | etxrab | 2004-12-01 14:58:22 -0600 (Wed, 01 Dec 2004) | 1 line +r13051 | jmayer | 2005-01-15 12:39:44 -0600 (Sat, 15 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/dissectors/packet-gre.c + M /trunk/configure.in + M /trunk/plugins/Makefile.am -Add some ethertypes +Add mate to the build process (plus a few whitespace changes) ------------------------------------------------------------------------ -r12642 | etxrab | 2004-12-01 14:57:27 -0600 (Wed, 01 Dec 2004) | 1 line +r13050 | jmayer | 2005-01-15 12:34:06 -0600 (Sat, 15 Jan 2005) | 1 line Changed paths: - M /trunk/etypes.h + M /trunk/FAQ + M /trunk/help/faq.txt + M /trunk/manuf -Add some ethertypes +Update FAQ and manuf files ------------------------------------------------------------------------ -r12641 | gerald | 2004-12-01 14:51:19 -0600 (Wed, 01 Dec 2004) | 2 lines +r13049 | gerald | 2005-01-15 12:18:09 -0600 (Sat, 15 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tds.c + M /trunk/config.nmake + M /trunk/configure.in -Catch a couple of integer overflows. +Bump the version to 0.10.9. ------------------------------------------------------------------------ -r12640 | gerald | 2004-12-01 13:34:51 -0600 (Wed, 01 Dec 2004) | 2 lines +r13048 | ulfl | 2005-01-15 10:01:54 -0600 (Sat, 15 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/gtk/capture_info_dlg.c -Don't access memory that may have been freed. +Recently the capture interface name was added to the title of the capture info dialog. +On WIN32, this interface name is in a somehwat unreadable format "\Device\NPF_{242423...", display the interface description on win32 systems instead "Realtek RTL ..." ------------------------------------------------------------------------ -r12639 | gerald | 2004-12-01 10:56:37 -0600 (Wed, 01 Dec 2004) | 5 lines +r13047 | ulfl | 2005-01-15 09:52:50 -0600 (Sat, 15 Jan 2005) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/tools/win32-setup.sh - -If bash is run as a non-login shell, it doesn't read /etc/profile. Under -Cygwin this has the side effect of making the Windows "find" command appear -first in the path instead of Cygwin's "find" command. Call /usr/bin/find -explicitly in win32-setup.sh. + M /trunk/pcap-util-int.h +fix a typo ------------------------------------------------------------------------ -r12638 | guy | 2004-12-01 06:41:43 -0600 (Wed, 01 Dec 2004) | 2 lines +r13046 | guy | 2005-01-15 04:39:49 -0600 (Sat, 15 Jan 2005) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-bittorrent.c + M /trunk/ethereal_gen.py + M /trunk/plugins/giop/packet-coseventcomm.c + M /trunk/plugins/giop/packet-cosnaming.c -From Jelmer Vernooij: BitTorrent support. +Use -1 as a length value for "to the end of the tvbuff". ------------------------------------------------------------------------ -r12637 | guy | 2004-12-01 06:15:16 -0600 (Wed, 01 Dec 2004) | 4 lines +r13045 | guy | 2005-01-15 04:10:16 -0600 (Sat, 15 Jan 2005) | 2 lines Changed paths: M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-dhcpv6.c - -From Marc Poulhies: fix the handling of the authentication option when -the authentication information is missing (which it can be), and fix a -typo. - ------------------------------------------------------------------------- -r12636 | guy | 2004-12-01 05:54:41 -0600 (Wed, 01 Dec 2004) | 6 lines -Changed paths: - M /trunk/gtk/rtp_analysis.c - M /trunk/gtk/rtp_analysis.h - M /trunk/gtk/rtp_stream.c - M /trunk/gtk/rtp_stream.h - M /trunk/gtk/rtp_stream_dlg.c -From Francisco Alcoba: - - add IPv6 support; - - replace "delay" with "delta". +Add an entry for Yann. ------------------------------------------------------------------------ -r12635 | guy | 2004-12-01 05:35:27 -0600 (Wed, 01 Dec 2004) | 3 lines +r13044 | guy | 2005-01-15 04:09:00 -0600 (Sat, 15 Jan 2005) | 3 lines Changed paths: - M /trunk/Makefile.nmake + M /trunk/epan/dissectors/packet-olsr.c -From Francisco Alcoba: link with setargv.obj so that wildcards are -expanded in the command line. +From Yann: handle OLSR messages with an unknown message type, using the +message length. ------------------------------------------------------------------------ -r12634 | guy | 2004-12-01 05:29:57 -0600 (Wed, 01 Dec 2004) | 3 lines +r13043 | ulfl | 2005-01-14 17:33:03 -0600 (Fri, 14 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-h245.c - -From Martin Regner: support for the parts of H.245 version 10 that are -related to H.239. + M /trunk/docbook/eug_src/EUG_chapter_advanced.xml +(Hopefully clarified) name resolution a bit. ------------------------------------------------------------------------ -r12633 | guy | 2004-12-01 05:19:04 -0600 (Wed, 01 Dec 2004) | 4 lines +r13042 | tuexen | 2005-01-14 16:26:18 -0600 (Fri, 14 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-mtp2.c -From Yaniv Kaul: adds LZS as a compression method, per 'Transport Layer -Security (TLS) Protocol Compression UsingLempel-Ziv-Stac (LZS)' RFC (RFC -3943). +Add support for extended sequence numbers as specified in Annex A of Q.703. ------------------------------------------------------------------------ -r12632 | guy | 2004-12-01 00:48:52 -0600 (Wed, 01 Dec 2004) | 2 lines +r13041 | guy | 2005-01-14 14:27:34 -0600 (Fri, 14 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/isup_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c -Squelch some compiler warnings. +From Laurent Rabret: handle the cases where there's no capture file, or +there is but it has no packets. ------------------------------------------------------------------------ -r12631 | guy | 2004-12-01 00:44:54 -0600 (Wed, 01 Dec 2004) | 7 lines +r13040 | guy | 2005-01-14 13:28:02 -0600 (Fri, 14 Jan 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c - -According to the part of the DCE RPC spec at - - http://www.opengroup.org/onlinepubs/009629399/chap12.htm#tagcjh_17_06_01 + M /trunk/epan/dissectors/packet-rtcp.c -the number of transfer syntaxes is a u_int8, with an alignment pad byte -following it, not a u_int16. - ------------------------------------------------------------------------- -r12630 | guy | 2004-11-30 21:42:55 -0600 (Tue, 30 Nov 2004) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-smb-common.c +If an item in a source description chunk begins with 4 bytes of zero, +that doesn't mean it's padding at the end of a previous item - it might, +for example, be the *first* item in the chunk. Don't treat it as +padding. -Get rid of a long-obsolete comment. +Do, however, treat an item that begins with a zero byte as an item, but +break out of the loop processing items as soon as the item type is put +into the protocol tree, as there's no length field or data in an +RTCP_SDES_END item. Fix the comment for that loop to indicate that the +loop checks both for end-of-frame and for an RTCP_SDES_END item. ------------------------------------------------------------------------ -r12629 | gerald | 2004-11-30 19:21:22 -0600 (Tue, 30 Nov 2004) | 2 lines +r13039 | guy | 2005-01-14 12:05:08 -0600 (Fri, 14 Jan 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-ieee80211.c -bytes_to_str() returns a static value. Don't g_free() it. +Pass 0, not FALSE, as the FCS length argument (FALSE is defined as 0, +but the field is integral, not Boolean, so it's clearer if it's passed +as 0). ------------------------------------------------------------------------ -r12628 | etxrab | 2004-11-30 16:11:56 -0600 (Tue, 30 Nov 2004) | 1 line +r13038 | lroland | 2005-01-14 12:04:54 -0600 (Fri, 14 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-nsip.c + M /trunk/asn1/h225/makefile.nmake -Fix port preference handling. +With xcopy use backsplash instead of slash as directory seperator ------------------------------------------------------------------------ -r12627 | etxrab | 2004-11-30 15:32:47 -0600 (Tue, 30 Nov 2004) | 1 line +r13037 | lroland | 2005-01-14 11:56:40 -0600 (Fri, 14 Jan 2005) | 1 line Changed paths: - M /trunk/AUTHORS + M /trunk/asn1/h225/makefile.nmake -Add Susanne Edlund to authors file. +Replace another "cp" with two "xcopy"s ------------------------------------------------------------------------ -r12626 | etxrab | 2004-11-30 15:19:25 -0600 (Tue, 30 Nov 2004) | 1 line +r13036 | lroland | 2005-01-14 11:52:03 -0600 (Fri, 14 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-nsip.c + A /trunk/asn1/h225/makefile.nmake -New dissector for NSIP from Susanne Edlund, default port2 changed to unallocated port 19999 +Add nmake makefile for /asn1/h225 ------------------------------------------------------------------------ -r12625 | gerald | 2004-11-30 10:52:21 -0600 (Tue, 30 Nov 2004) | 2 lines +r13035 | lroland | 2005-01-14 11:49:30 -0600 (Fri, 14 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-wsp.c - M /trunk/epan/dissectors/packet-wtp.c - -Replace a few instances of match_strval() with val_to_str(). + M /trunk/asn1/h450/h450.cnf + M /trunk/asn1/h450/packet-h450-template.h +Fix svn properties ------------------------------------------------------------------------ -r12624 | sahlberg | 2004-11-29 22:08:16 -0600 (Mon, 29 Nov 2004) | 4 lines +r13034 | gerald | 2005-01-14 11:09:11 -0600 (Fri, 14 Jan 2005) | 3 lines Changed paths: - M /trunk/asn1/x509af/packet-x509af-template.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h - -Make ethereal dissect application/pkix-crl CertificateRevocationLists over HTTP. + M /trunk/epan/dissectors/packet-ncp-nmas.c +From Greg Morris: Improve malformed packet handling. ------------------------------------------------------------------------ -r12623 | sahlberg | 2004-11-29 21:39:34 -0600 (Mon, 29 Nov 2004) | 4 lines +r13033 | gerald | 2005-01-14 10:57:07 -0600 (Fri, 14 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - -when creating a new subset tvb for a field for further dissection by child dissectors, then if the original tvb is short and doesnt contain enough data, try to create a new subset tvb with as much data we do have instead of just bailing out. - + M /trunk/doc/Makefile.nmake +Remove another GNU cp dependency. ------------------------------------------------------------------------ -r12622 | lroland | 2004-11-29 17:48:26 -0600 (Mon, 29 Nov 2004) | 2 lines +r13032 | guy | 2005-01-14 06:20:03 -0600 (Fri, 14 Jan 2005) | 5 lines Changed paths: - M /trunk/plugins/rtnet/packet-rtnet.c + M /trunk/epan/dissectors/packet-gnutella.c -Make rtnet plugin compile again with MSVC -and some white space cleanup. ------------------------------------------------------------------------- -r12621 | gerald | 2004-11-29 13:30:12 -0600 (Mon, 29 Nov 2004) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c +Fix indentation. -Add another length check. +Catch size values >= 0x80000000 and throw an exception rather than +crashing with an assertion. ------------------------------------------------------------------------ -r12620 | guy | 2004-11-29 12:02:07 -0600 (Mon, 29 Nov 2004) | 2 lines +r13031 | kukosa | 2005-01-14 05:42:39 -0600 (Fri, 14 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c - -Get rid of a debug message. + M /trunk/asn1/h225/packet-h225-template.h +Included filename packet-H225-exp.h changed to packet-h225-exp.h ------------------------------------------------------------------------ -r12619 | gerald | 2004-11-29 11:52:38 -0600 (Mon, 29 Nov 2004) | 3 lines +r13030 | guy | 2005-01-14 05:40:05 -0600 (Fri, 14 Jan 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-ppp.c -Check for an overly large header length value in order to avoid an integer -overflow. +From Rene Pilz: + + - Fix partly wrong cause values in the gmm (found by Miklos Szurdi) + - Fix high/low nibble swap of the force to standby field (found by + Miklos Szurdi) + - Dissect all elements ------------------------------------------------------------------------ -r12618 | sahlberg | 2004-11-29 03:58:16 -0600 (Mon, 29 Nov 2004) | 4 lines +r13029 | guy | 2005-01-14 05:17:35 -0600 (Fri, 14 Jan 2005) | 2 lines Changed paths: - A /trunk/asn1/ocsp - A /trunk/asn1/ocsp/Makefile - A /trunk/asn1/ocsp/OCSP.asn - A /trunk/asn1/ocsp/ocsp.cnf - A /trunk/asn1/ocsp/packet-ocsp-template.c - A /trunk/asn1/ocsp/packet-ocsp-template.h + M /trunk/AUTHORS M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-ocsp.c - A /trunk/epan/dissectors/packet-ocsp.h - -new protocol : RFC2560 Online Certificate Status Protocol - + A /trunk/epan/dissectors/packet-rmt-alc.c + A /trunk/epan/dissectors/packet-rmt-alc.h + A /trunk/epan/dissectors/packet-rmt-common.c + A /trunk/epan/dissectors/packet-rmt-common.h + A /trunk/epan/dissectors/packet-rmt-fec.c + A /trunk/epan/dissectors/packet-rmt-fec.h + A /trunk/epan/dissectors/packet-rmt-lct.c + A /trunk/epan/dissectors/packet-rmt-lct.h + A /trunk/epan/dissectors/packet-rmt-norm.c + A /trunk/epan/dissectors/packet-rmt-norm.h +From Stefano Pettini: RMT support for ALC and NORM. ------------------------------------------------------------------------ -r12617 | sahlberg | 2004-11-29 02:43:19 -0600 (Mon, 29 Nov 2004) | 4 lines +r13028 | guy | 2005-01-14 03:47:22 -0600 (Fri, 14 Jan 2005) | 6 lines Changed paths: - M /trunk/asn1/pkix1explicit/PKIX1EXPLICIT93.asn - M /trunk/asn1/pkix1explicit/packet-pkix1explicit-template.c - M /trunk/asn1/pkix1explicit/packet-pkix1explicit-template.h - M /trunk/asn1/pkix1explicit/pkix1explicit.cnf - M /trunk/asn1/pkix1explicit/pkix1explicit_exp.cnf - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-pkix1explicit.h - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h - -export some more sympols from PKIX1EXPLICIT - + M /trunk/wiretap/netxray.c +Note that the low-order bit of hdr->hdr_2_x.xxx[8] appears to be a "bad +FCS" bit for 802.11, just as it appears to be for Ethernet, and give +more details on the 4 bytes of junk at the end of the packet (i.e., that +we haven't yet seen an 802.11 capture where it's an FCS rather than just +junk). ------------------------------------------------------------------------ -r12616 | sahlberg | 2004-11-29 01:57:19 -0600 (Mon, 29 Nov 2004) | 3 lines +r13027 | ulfl | 2005-01-13 21:22:43 -0600 (Thu, 13 Jan 2005) | 1 line Changed paths: - M /trunk/asn1/pkix1implicit/pkix1implicit.cnf - M /trunk/asn1/pkix1implicit/pkix1implicit_exp.cnf - M /trunk/epan/dissectors/packet-pkix1implicit.c - M /trunk/epan/dissectors/packet-pkix1implicit.h - -Export AuthorityInfoAccessSyntax from pkix1implicit - + M /trunk/docbook/eug_src/EUG_app_files.xml + M /trunk/docbook/eug_src/EUG_chapter_advanced.xml +add hosts file and some more name resolution info ------------------------------------------------------------------------ -r12615 | etxrab | 2004-11-28 14:52:52 -0600 (Sun, 28 Nov 2004) | 1 line +r13026 | etxrab | 2005-01-13 17:05:59 -0600 (Thu, 13 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-frame.c + A /trunk/asn1/h450/h450.cnf + A /trunk/asn1/h450/h4501.asn + A /trunk/asn1/h450/packet-h450-template.c + A /trunk/asn1/h450/packet-h450-template.h -From LEGO if Mate is pressent call it. +Add a first draft asn2eth generated H.450.x dissector ------------------------------------------------------------------------ -r12614 | etxrab | 2004-11-28 13:41:17 -0600 (Sun, 28 Nov 2004) | 1 line +r13025 | etxrab | 2005-01-13 17:05:11 -0600 (Thu, 13 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sigcomp.c + A /trunk/asn1/h450 -Bugfixes- handle zero length bytecode, handle end-off-message with implied parameters(udvm initialised to zero). +Add a ( first draft ) asn2eth generated H450.x dissector ------------------------------------------------------------------------ -r12613 | etxrab | 2004-11-28 13:39:19 -0600 (Sun, 28 Nov 2004) | 1 line +r13024 | etxrab | 2005-01-13 15:12:06 -0600 (Thu, 13 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sigcomp-udvm.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h -Bugfixes +Some minor bugfixes to H225 functions exported and an OID added and one OID for H245 ------------------------------------------------------------------------ -r12612 | etxrab | 2004-11-28 13:35:21 -0600 (Sun, 28 Nov 2004) | 1 line +r13023 | etxrab | 2005-01-13 15:10:21 -0600 (Thu, 13 Jan 2005) | 1 line Changed paths: - M /trunk/epan/strutil.c + M /trunk/asn1/h245/packet-h245-template.c -Change number of bytes displayed in bytes_to_string to 48 to facilitate display of sha1 digest of 20 bytes. +Add one OID ------------------------------------------------------------------------ -r12611 | jmayer | 2004-11-28 11:30:18 -0600 (Sun, 28 Nov 2004) | 1 line +r13022 | etxrab | 2005-01-13 15:09:45 -0600 (Thu, 13 Jan 2005) | 1 line Changed paths: - M /trunk/FAQ - M /trunk/help/faq.txt - M /trunk/manuf + M /trunk/asn1/h225/h225-exp.cnf + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c -Update manuf and FAQ +Minor bug fixes and export functions needed by h450 ------------------------------------------------------------------------ -r12610 | sahlberg | 2004-11-27 22:26:27 -0600 (Sat, 27 Nov 2004) | 2 lines +r13021 | ulfl | 2005-01-13 14:19:49 -0600 (Thu, 13 Jan 2005) | 2 lines Changed paths: - A /trunk/asn1/pkixproxy - A /trunk/asn1/pkixproxy/Makefile - A /trunk/asn1/pkixproxy/PKIXProxy.asn - A /trunk/asn1/pkixproxy/packet-pkixproxy-template.c - A /trunk/asn1/pkixproxy/packet-pkixproxy-template.h - A /trunk/asn1/pkixproxy/pkixproxy.cnf - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-pkixproxy.c - A /trunk/epan/dissectors/packet-pkixproxy.h - -new protocol : RFC3820 PKIXProxy + M /trunk/capture_loop.c +fix a bug (reported by Greg Morris) caused by code cleanup (blame it on me): +as the total packet count wasn't updated, the capture_info dialog wasn't updated accordingly ------------------------------------------------------------------------ -r12609 | gerald | 2004-11-27 22:21:30 -0600 (Sat, 27 Nov 2004) | 4 lines +r13020 | guy | 2005-01-13 11:31:33 -0600 (Thu, 13 Jan 2005) | 2 lines Changed paths: - M /trunk/asn1.c - M /trunk/epan/dissectors/packet-snmp.c + M /trunk/gtk/packet_list.c -The recent length check added to proto_tree_add_string() revealed a -couple of problems when reading the PROTOS SNMP captures. Check for -integer overflows in dissect_snmp_pdu and asn1_null_decode. +Add a missing case. ------------------------------------------------------------------------ -r12608 | sahlberg | 2004-11-26 18:11:52 -0600 (Fri, 26 Nov 2004) | 4 lines +r13019 | guy | 2005-01-13 11:26:10 -0600 (Thu, 13 Jan 2005) | 16 lines Changed paths: - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-dlsw.c -it appears that a SES_REFUSE spdu actually contains a CMIP-A-ASSOCIATE and not a CMIP-A-ABORT +Use tcp_dissect_pdus() for DLSw-over-TCP. +Have the DLSw dissector reject packets with an unknown version field. +Leave out some more fields when dissecting Capability Exchange packets, +as they're not used in those packets. ------------------------------------------------------------------------- -r12607 | sahlberg | 2004-11-26 17:14:30 -0600 (Fri, 26 Nov 2004) | 3 lines -Changed paths: - A /trunk/asn1/smrse/Makefile - M /trunk/asn1/smrse/packet-smrse-template.c - M /trunk/asn1/smrse/smrse.cnf - M /trunk/epan/dissectors/packet-smrse.c - M /trunk/epan/dissectors/packet-smrse.h +Show numbers in hex when appropriate. -prettify the printing of the octet_format field which is really just a BCD +Show the individual subfields of the flow control and SSP flags fields. +Show the frame direction field with val_to_str(), and show the raw +value. + +Clean up indentation. ------------------------------------------------------------------------ -r12606 | sahlberg | 2004-11-25 18:56:22 -0600 (Thu, 25 Nov 2004) | 3 lines +r13018 | guy | 2005-01-13 03:21:04 -0600 (Thu, 13 Jan 2005) | 4 lines Changed paths: - A /trunk/asn1/logotype-cert-extn - A /trunk/asn1/logotype-cert-extn/LogotypeCertExtn.asn - A /trunk/asn1/logotype-cert-extn/Makefile - A /trunk/asn1/logotype-cert-extn/logotype-cert-extn.cnf - A /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.c - A /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.h - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-logotypecertextn.c - A /trunk/epan/dissectors/packet-logotypecertextn.h + M /trunk/epan/dissectors/packet-nsip.c -New protocol: RFC3709 LogotypeCertificateExtensions +Updates from Susanne Edlund. +Remove bogus boilerplate from introductory comment. ------------------------------------------------------------------------ -r12605 | sahlberg | 2004-11-25 16:27:52 -0600 (Thu, 25 Nov 2004) | 3 lines +r13017 | guy | 2005-01-13 03:09:56 -0600 (Thu, 13 Jan 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/doc/ethereal.pod + M /trunk/doc/tethereal.pod + M /trunk/epan/addr_resolv.c -update dissection of unknown blobs to try to dissect even more stuff. +Add support for a personal hosts file. +Clean up the description of the global and personal ethers and ipxnets +files. ------------------------------------------------------------------------ -r12604 | sahlberg | 2004-11-25 15:30:38 -0600 (Thu, 25 Nov 2004) | 3 lines +r13016 | guy | 2005-01-13 01:51:08 -0600 (Thu, 13 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - - updates to prettify a bit when attempting to dissect an unknown blob + M /trunk/epan/dissectors/packet-dns.c +OPT RRs don't have a class field. ------------------------------------------------------------------------ -r12603 | sahlberg | 2004-11-25 15:00:17 -0600 (Thu, 25 Nov 2004) | 3 lines +r13015 | guy | 2005-01-13 01:49:31 -0600 (Thu, 13 Jan 2005) | 4 lines Changed paths: - M /trunk/asn1/x509ce/packet-x509ce-template.c - M /trunk/asn1/x509ce/x509ce.cnf - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509ce.h + M /trunk/epan/dissectors/packet-bootp.c -try to print an IPAddress as an ip address and not as a 4 byte octet string +Use symbolic names for ARP types. +Clean up indentation. ------------------------------------------------------------------------ -r12602 | sahlberg | 2004-11-25 14:44:17 -0600 (Thu, 25 Nov 2004) | 3 lines +r13014 | guy | 2005-01-13 01:47:26 -0600 (Thu, 13 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c - -from Stig: change the draft number for NAT-D + M /trunk/epan/dissectors/packet-http.c +HTTP requests have no content if there's no Content-Length header and no +Transfer-Encoding header. ------------------------------------------------------------------------ -r12601 | sahlberg | 2004-11-25 14:38:10 -0600 (Thu, 25 Nov 2004) | 4 lines +r13013 | guy | 2005-01-13 01:43:17 -0600 (Thu, 13 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-nt-sonmp.c - -From Giles Scott : updates to packet-nt-sonmp.c - + M /trunk/epan/dissectors/packet-per.c +Display PER booleans the way other bitfields are displayed. ------------------------------------------------------------------------ -r12600 | etxrab | 2004-11-24 15:55:30 -0600 (Wed, 24 Nov 2004) | 1 line +r13012 | etxrab | 2005-01-13 01:03:14 -0600 (Thu, 13 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sigcomp-udvm.c + M /trunk/epan/dissectors/packet-dlsw.c -Somethimes its difficult to get it right *sigh +Don't crash on a negative length ------------------------------------------------------------------------ -r12599 | sahlberg | 2004-11-24 15:26:52 -0600 (Wed, 24 Nov 2004) | 3 lines +r13011 | guy | 2005-01-12 19:16:53 -0600 (Wed, 12 Jan 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-giop.c - -From LEGO: make the request id and operation filterable + M /trunk/plugins/Makefile.am +Welcome to the wonderful world of "make", wherein a command in a set of +make rules must be indented with one or more tabs - no spaces, just +tabs. I seem to remember a Stu Feldman quote somewhere in which he +apologized for that requirement.... ------------------------------------------------------------------------ -r12598 | jmayer | 2004-11-24 10:37:38 -0600 (Wed, 24 Nov 2004) | 1 line +r13010 | ulfl | 2005-01-12 15:44:53 -0600 (Wed, 12 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sigcomp-udvm.c + M /trunk/epan/plugins.c + M /trunk/plugins/Xass-list + M /trunk/plugins/Xplugin_api.c + M /trunk/plugins/Xplugin_api.h + M /trunk/plugins/Xplugin_api_decls.h + M /trunk/plugins/Xplugin_table.h + M /trunk/plugins/plugin_api.h + M /trunk/plugins/plugin_api_list.c -The code didn't even compile: removed a superfluous ( +add some of the DCE/RPC functions to the plugin API ------------------------------------------------------------------------ -r12597 | jmayer | 2004-11-24 10:30:52 -0600 (Wed, 24 Nov 2004) | 1 line +r13009 | ulfl | 2005-01-12 15:41:30 -0600 (Wed, 12 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sigcomp-udvm.c - M /trunk/epan/sigcomp-udvm.h + M /trunk/ringbuffer.c -Set svn properties - without them, compilation with gcc would fail on Unix +don't use two variables for keeping the current ringbuffer file number ------------------------------------------------------------------------ -r12596 | etxrab | 2004-11-24 07:53:27 -0600 (Wed, 24 Nov 2004) | 1 line +r13008 | ulfl | 2005-01-12 15:38:09 -0600 (Wed, 12 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sigcomp-udvm.c + M /trunk/plugins/Makefile.am + M /trunk/plugins/Makefile.nmake -Fix a faulty IF statement, deflate should work now. +cleanup old files before generating xyzzy target (it drove me almost crazy to find out the right way to build this target correctly, so be a bit more "automatically" the next time) ------------------------------------------------------------------------ -r12595 | etxrab | 2004-11-24 06:25:37 -0600 (Wed, 24 Nov 2004) | 1 line +r13007 | ulfl | 2005-01-12 15:31:22 -0600 (Wed, 12 Jan 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-3g-a11.c - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/proto.c + +performance improvement: +In the past: to prevent duplicate protocol names (and alike), each time a new protocol was registered, the list of protocols were iterated and the name compared with each existing name using strcasecmp, which is slow as we have >500 protocols right now. -add some 3gpp2 AVP:s to packet-radius.c and use "vendor" table packet-3g-a11.c +Now: the protocol name to check against duplicates is first converted into a hashvalue and then only this value is checked and stored in a hashtable. This way the string to check for, has to be converted/compared only a single time! ------------------------------------------------------------------------ -r12594 | etxrab | 2004-11-24 06:23:26 -0600 (Wed, 24 Nov 2004) | 1 line +r13006 | ulfl | 2005-01-12 15:20:50 -0600 (Wed, 12 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sminmpec.c - M /trunk/epan/sminmpec.h + M /trunk/epan/dissectors/packet-dcerpc-ndr.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcerpc.h + M /trunk/epan/dissectors/packet-dcom.c -Change "Ericsson" string +add new function dissect_dcerpc_uuid_t and let dissect_ndr_uuid_t call it ------------------------------------------------------------------------ -r12593 | guy | 2004-11-24 03:13:52 -0600 (Wed, 24 Nov 2004) | 9 lines +r13005 | ulfl | 2005-01-12 15:16:53 -0600 (Wed, 12 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ascend.c - M /trunk/epan/dissectors/packet-atm.c - M /trunk/epan/dissectors/packet-cosine.c - M /trunk/epan/dissectors/packet-eth.c - M /trunk/epan/dissectors/packet-etherip.c - M /trunk/epan/dissectors/packet-fr.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-isl.c - M /trunk/epan/dissectors/packet-isl.h - M /trunk/epan/dissectors/packet-llc.c - M /trunk/epan/dissectors/packet-lwapp.c - M /trunk/epan/dissectors/packet-mpls.c - M /trunk/epan/dissectors/packet-sflow.c - M /trunk/epan/dissectors/packet-wfleet-hdlc.c - M /trunk/plugins/docsis/packet-docsis.c + M /trunk/plugins/README.interface -Export two versions of the Ethereal dissector, for use with encapsulated -Ethernet frames, one for encapsulated frames that include an FCS and one -for encapsulated frames that don't include an FCS. Use the appropriate -versions. +clarify text and describe libethereal.def +Could someone have a look at this, as I'm not 100% sure if it's correct. +------------------------------------------------------------------------ +r13004 | etxrab | 2005-01-12 00:00:31 -0600 (Wed, 12 Jan 2005) | 2 lines +Changed paths: + M /trunk/plugins/megaco/packet-megaco.c -In the ISL dissector, do the same sort of processing we do in the -Ethernet dissector to figure out whether the frame has a trailer or not -and whether it has an FCS or not. +From Tomer Shani :register_dissector call ------------------------------------------------------------------------ -r12592 | guy | 2004-11-24 03:00:23 -0600 (Wed, 24 Nov 2004) | 2 lines +r13003 | guy | 2005-01-10 18:13:42 -0600 (Mon, 10 Jan 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ipmi.c + M /trunk/capinfos.c + +Improve the error reporting. -Fix some typoes. +Remove a duplicate #include, and shuffle the includes a bit to put OS +includes before other includes. ------------------------------------------------------------------------ -r12591 | guy | 2004-11-24 02:55:40 -0600 (Wed, 24 Nov 2004) | 2 lines +r13002 | kukosa | 2005-01-10 03:06:07 -0600 (Mon, 10 Jan 2005) | 1 line Changed paths: M /trunk/epan/libethereal.def -We export flags_set_truth - add it to libethereal.def. - +Add a "hex_str_to_bytes()" routine ------------------------------------------------------------------------ -r12590 | guy | 2004-11-24 00:04:43 -0600 (Wed, 24 Nov 2004) | 3 lines +r13001 | lroland | 2005-01-09 20:37:19 -0600 (Sun, 09 Jan 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/matelib/sip.mate + M /trunk/plugins/mate/packet-mate.c -Only interpret a frame as an FW1 header if it looks like one, as per a -patch from Yaniv Kaul. +One more patch for mate: +- renamed analyze_frame() into mate_analyze_frame(). +- prepare mate to be statically linked +- use report_open_failure() , report_read_failure() and +report_failure() in case there's an error while loading the config +- some cleanup in mate_util.c +- some fixes and cleanup in examples and matelib ------------------------------------------------------------------------ -r12589 | guy | 2004-11-23 22:14:56 -0600 (Tue, 23 Nov 2004) | 3 lines +r13000 | lroland | 2005-01-09 20:19:11 -0600 (Sun, 09 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tds.c + M /trunk/asn1/h225/h225.cnf -From Yaniv Kaul: the authentication token might be NTLMSSP or it might -be GSS-API. +From Luis Ontanon: +Add another piece of code that got lost to the cnf file of the new h225 dissector. ------------------------------------------------------------------------ -r12588 | guy | 2004-11-23 21:54:40 -0600 (Tue, 23 Nov 2004) | 2 lines +r12999 | guy | 2005-01-09 15:42:39 -0600 (Sun, 09 Jan 2005) | 7 lines Changed paths: M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-ipmi.c - -From Lane Hu: add support for more IPMI commands. + M /trunk/epan/dissectors/packet-l2tp.c + M /trunk/epan/sminmpec.c + M /trunk/epan/sminmpec.h ------------------------------------------------------------------------- -r12587 | guy | 2004-11-23 21:35:17 -0600 (Tue, 23 Nov 2004) | 2 lines -Changed paths: - M /trunk/plugins/enttec/ChangeLog - M /trunk/plugins/enttec/moduleinfo.h - M /trunk/plugins/enttec/packet-enttec.c +From Deepak Jain: L2TP v3 (draft 15) support. -From Erwin Rol: Dissect DMX in a readable format, and other updates. +Add VENDOR_IETF to <epan/sminmpec.h>, and add an entry for it to +sminmpec_values[], so that the L2TP dissector can use them rather than +defining its own copy of the private enterprise number values and table +- and make it do so. ------------------------------------------------------------------------ -r12586 | guy | 2004-11-23 21:18:30 -0600 (Tue, 23 Nov 2004) | 2 lines +r12998 | guy | 2005-01-08 18:01:55 -0600 (Sat, 08 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sdp.c + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h -From Francisco Alcoba: handle RTP over IPv6. +Properly declare "dissect_h245()" and "dissect_h245_h245()" as returning +nothing. ------------------------------------------------------------------------ -r12585 | guy | 2004-11-23 20:59:49 -0600 (Tue, 23 Nov 2004) | 2 lines +r12997 | guy | 2005-01-08 17:43:29 -0600 (Sat, 08 Jan 2005) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-mtp3.c - M /trunk/epan/dissectors/packet-mtp3mg.c - A /trunk/epan/dissectors/packet-sscf-nni.c - M /trunk/epan/dissectors/packet-sscop.c - M /trunk/epan/range.h + M /trunk/epan/proto.c -From Jeff Morriss: SSCOP over UDP and SSCF-NNI support. +From Luis Ontanon: if new ett values are registered after the +tree_is_expanded array is initially allocated, grow the array ------------------------------------------------------------------------ -r12584 | guy | 2004-11-23 20:36:14 -0600 (Tue, 23 Nov 2004) | 2 lines +r12996 | guy | 2005-01-08 14:54:23 -0600 (Sat, 08 Jan 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/etypes.h - M /trunk/plugins/rtnet/moduleinfo.h - M /trunk/plugins/rtnet/packet-rtnet.c + M /trunk/epan/dissectors/packet-amr.c -Updates from Erwin Rol. +Get rid of some of the boilerplate comments from the sample dissector, +and de-boilerplate another part of the comment. ------------------------------------------------------------------------- -r12583 | etxrab | 2004-11-23 16:03:28 -0600 (Tue, 23 Nov 2004) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-sigcomp.c +Fix a test of "octet_aligned" that was setting it to false rather than +testing whether it was false. -Make it possible to fileter on partial_state create and access. ------------------------------------------------------------------------ -r12582 | etxrab | 2004-11-23 16:02:00 -0600 (Tue, 23 Nov 2004) | 1 line +r12995 | lroland | 2005-01-08 13:21:30 -0600 (Sat, 08 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sigcomp-udvm.c - M /trunk/epan/sigcomp-udvm.h - M /trunk/epan/sigcomp_state_hdlr.c - M /trunk/epan/sigcomp_state_hdlr.h + M /trunk/asn1/h225/h225-exp.cnf + M /trunk/asn1/h225/h225.asn + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h225/packet-h225-template.h + M /trunk/asn1/h245/h245-exp.cnf + M /trunk/asn1/h245/h245.asn + M /trunk/asn1/h245/h245.cnf + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/asn1/h245/packet-h245-template.h -Don't free string that don't need it. Added filter possibillity on Partial state +Fix svn file properties ------------------------------------------------------------------------ -r12581 | gerald | 2004-11-23 11:31:16 -0600 (Tue, 23 Nov 2004) | 2 lines +r12994 | etxrab | 2005-01-08 10:38:13 -0600 (Sat, 08 Jan 2005) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/tools/win32-setup.sh - -Update to GTK+ 2.4.13. + M /trunk/epan/dissectors/packet-h225.c +Reinsert dissection of h450 messages ------------------------------------------------------------------------ -r12580 | etxrab | 2004-11-22 16:19:03 -0600 (Mon, 22 Nov 2004) | 1 line +r12993 | etxrab | 2005-01-08 09:49:37 -0600 (Sat, 08 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-amr.c -Fix some memmory leaks +Add a dissector for RTP payload AMR RFC 3267 ------------------------------------------------------------------------ -r12579 | etxrab | 2004-11-22 16:18:18 -0600 (Mon, 22 Nov 2004) | 1 line +r12992 | etxrab | 2005-01-08 08:42:12 -0600 (Sat, 08 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/sigcomp-udvm.c - M /trunk/epan/sigcomp-udvm.h - M /trunk/epan/sigcomp_state_hdlr.c - M /trunk/epan/sigcomp_state_hdlr.h + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h + M /trunk/epan/dissectors/packet-h245.c -Fix some memmory leaks +Generate "conversations" code correctly, adaptions to changes in asn2eth generator. +Regenerate with latest asn2eth compiler. ------------------------------------------------------------------------ -r12578 | jmayer | 2004-11-22 10:36:26 -0600 (Mon, 22 Nov 2004) | 1 line +r12991 | etxrab | 2005-01-08 08:39:53 -0600 (Sat, 08 Jan 2005) | 1 line Changed paths: - A /trunk/wiretap/README.airmagnet + M /trunk/asn1/h245/h245.cnf + M /trunk/asn1/h245/packet-h245-template.c -Backup some notes on Airmagnet capture file format into Ethereal - I'm NOT going to write an importer in the near future though +Generate "conversations" code correctly, adaptions to changes in asn2eth generator. ------------------------------------------------------------------------ -r12577 | guy | 2004-11-22 04:26:45 -0600 (Mon, 22 Nov 2004) | 2 lines +r12990 | etxrab | 2005-01-08 08:36:10 -0600 (Sat, 08 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-fw1.c - -Get rid of an unused variable. + M /trunk/asn1/h225/packet-h225-template.c +Fixa a typo ------------------------------------------------------------------------ -r12576 | guy | 2004-11-22 02:23:00 -0600 (Mon, 22 Nov 2004) | 5 lines +r12989 | guy | 2005-01-07 16:20:28 -0600 (Fri, 07 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c + M /trunk/plugins/Xplugin_table.h -From Yaniv Kaul: increment the offset pointer *after* you use it to put -into the protocol tree the field you're incrementing past. - -Update a comment. +Fix the signature of proto_register_subtree_array(). ------------------------------------------------------------------------ -r12575 | guy | 2004-11-22 02:12:42 -0600 (Mon, 22 Nov 2004) | 2 lines +r12988 | guy | 2005-01-07 16:19:44 -0600 (Fri, 07 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tds.c + M /trunk/plugins/plugin_api_list.c -Fix a spelling error. +Fix the signature of proto_register_subtree_array(). ------------------------------------------------------------------------ -r12574 | guy | 2004-11-22 02:11:31 -0600 (Mon, 22 Nov 2004) | 3 lines +r12987 | guy | 2005-01-07 13:34:36 -0600 (Fri, 07 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tds.c + M /trunk/epan/dissectors/packet-jxta.c -Put the value of the length field in a variable-length token, not the -length of the token, into the protocol tree as the length value. +Use BASE_NONE, not FT_NONE, for the "base" value of an FT_STRING field. ------------------------------------------------------------------------ -r12573 | sahlberg | 2004-11-21 21:36:26 -0600 (Sun, 21 Nov 2004) | 7 lines +r12986 | guy | 2005-01-07 13:29:54 -0600 (Fri, 07 Jan 2005) | 19 lines Changed paths: - A /trunk/asn1/cms/Makefile - A /trunk/asn1/cms/cms-exp.cnf - M /trunk/asn1/cms/cms.cnf - D /trunk/asn1/cms/cms_exp.cnf - M /trunk/asn1/cms/packet-cms-template.c - M /trunk/asn1/cms/packet-cms-template.h - A /trunk/asn1/ess - A /trunk/asn1/ess/ExtendedSecurityServices.asn - A /trunk/asn1/ess/Makefile - A /trunk/asn1/ess/ess.cnf - A /trunk/asn1/ess/packet-ess-template.c - A /trunk/asn1/ess/packet-ess-template.h - M /trunk/asn1/ns-cert-exts/packet-ns_cert_exts-template.c - M /trunk/asn1/ns-cert-exts/packet-ns_cert_exts-template.h - M /trunk/asn1/pkcs1/packet-pkcs1-template.c - M /trunk/asn1/pkcs1/packet-pkcs1-template.h - M /trunk/asn1/pkinit/packet-pkinit-template.c - M /trunk/asn1/pkinit/packet-pkinit-template.h - M /trunk/asn1/pkinit/pkinit.cnf - M /trunk/asn1/pkixqualified/packet-pkixqualified-template.h - M /trunk/asn1/x509af/packet-x509af-template.c - M /trunk/asn1/x509af/packet-x509af-template.h - M /trunk/asn1/x509ce/packet-x509ce-template.c - M /trunk/asn1/x509ce/packet-x509ce-template.h - M /trunk/asn1/x509if/packet-x509if-template.c - M /trunk/asn1/x509if/packet-x509if-template.h - M /trunk/asn1/x509sat/packet-x509sat-template.c - M /trunk/asn1/x509sat/packet-x509sat-template.h - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h - A /trunk/epan/dissectors/packet-ess.c - A /trunk/epan/dissectors/packet-ess.h - M /trunk/epan/dissectors/packet-pkinit.c - M /trunk/epan/dissectors/packet-pkinit.h + M /trunk/epan/dissectors/packet-jxta.c -New protocol: RFC2634 ExtendedSecurityServices +Get rid of duplicate "element signature" field. -updates to cms to accomodate the new protocol +Clean up indentation. -add author to some files +The signatures are 4-byte strings - treat them as such. +Don't hide fields - dissectors should show what all bytes, other than +perhaps padding bytes, are. ------------------------------------------------------------------------- -r12572 | guy | 2004-11-21 20:12:43 -0600 (Sun, 21 Nov 2004) | 6 lines -Changed paths: - M /trunk/epan/dissectors/packet-ppp.c +Don't use the tvb_format_text-ified versions of strings as the value - +Ethereal already deals with non-printable characters when displaying +them. -Tag the compression protocol item as such. +When creating a subset tvbuff that runs to the end of the parent, use -1 +as the length, don't calculate the length ourselves. -The compression option isn't just the compression protocol, it can -include options for the protocol, so name the ett_ variable for its tree -appropriately. +Use "tvb_reported_length()", not "tvb_length()", in loops that parse the +entire packet. ------------------------------------------------------------------------ -r12571 | guy | 2004-11-21 19:58:21 -0600 (Sun, 21 Nov 2004) | 3 lines +r12985 | lroland | 2005-01-07 12:07:18 -0600 (Fri, 07 Jan 2005) | 21 lines Changed paths: - M /trunk/epan/dissectors/packet-smrse.c + M /trunk/plugins/mate/Makefile.nmake + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/matelib/h225_ras.mate + M /trunk/plugins/mate/matelib/sip.mate + M /trunk/plugins/mate/packet-mate.c -In code that checks whether to accept a packet, first check to make sure -the data being checked exists. +From Luis Ontanon: ------------------------------------------------------------------------- -r12570 | sahlberg | 2004-11-21 17:25:04 -0600 (Sun, 21 Nov 2004) | 3 lines -Changed paths: - M /trunk/asn1/cmip/CMIP.asn - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/epan/dissectors/packet-cmip.c +A new patch for mate -cmip update add all remaining functions Arguments and Results +- changed the default config file name to "" +- avoid trying to confgure mate when the config filename is "" +- add filename and line to config errors, that way one can actually +find errors in config files +- teady up the config error strings ( made them uniform ) +- fixed a crash when missing index AVPs (Name,For,On etc) in config AVPLS +- make sure we do not delete the config AVPs and AVPLs to avoid +references to unsubscribed strings been left arround +- fixed the len on LoALs +- changed the way loal_from_file reports an error. +- matelib/sip.mate was missing the Name in a PduDef (from Julien Leproust) +- matelib/h225_ras had a wrong field name (from Julien Leproust) +At this point mate is silent when it's not expressely configured by the user. +From me: +reduce compiler noise on MSVC ------------------------------------------------------------------------ -r12569 | guy | 2004-11-21 17:02:36 -0600 (Sun, 21 Nov 2004) | 4 lines +r12984 | gerald | 2005-01-07 09:08:24 -0600 (Fri, 07 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ieee802a.c -Set the length of the tvbuff to be handed to the subdissector -appropriately (minimum of reported length and length of data left -in the parent). +Define data_handle at startup. ------------------------------------------------------------------------ -r12568 | etxrab | 2004-11-21 16:26:53 -0600 (Sun, 21 Nov 2004) | 1 line +r12983 | guy | 2005-01-07 07:33:21 -0600 (Fri, 07 Jan 2005) | 4 lines Changed paths: - M /trunk/epan/sigcomp_state_hdlr.c + M /trunk/capture_loop.c -Clean-up hash table at reloading of file. ------------------------------------------------------------------------- -r12567 | etxrab | 2004-11-21 16:08:40 -0600 (Sun, 21 Nov 2004) | 1 line -Changed paths: - M /trunk/epan/sigcomp_state_hdlr.c +From Thomas Boehne: fix a call to use errmsg_len rather than sizeof +errmsg - errmsg is a pointer, so sizeof errmsg is the size of the +pointer, not the size of what it points to. -Free the statebuff and the string ------------------------------------------------------------------------ -r12566 | guy | 2004-11-21 16:03:33 -0600 (Sun, 21 Nov 2004) | 66 lines +r12982 | guy | 2005-01-07 06:58:43 -0600 (Fri, 07 Jan 2005) | 2 lines Changed paths: M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-tds.c - -From Bill Meier: - -1. Add Preferences: - - a. To allow specification of a hint as to TDS protocol being decoded - (Unspecified/TDS4/TDS5/TDS7/TDS8); Default: 'unspecified' - - The 'hint' is used only when needed to do a correct decode. - - If the protocol is unspecified, the decode is as previous. + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-jxta.c - b. To allow specification of 'ranges' of TCP ports to be treated as - 'TDS tcp ports'; i.e. if the source or destination port of a tcp - connection matches a specified range, then the connection should be - considered to be TDS. +From Mike Duigou: JXTA protocol support. - c. To allow specification of a hint as to whether TDS being decoded is - 'little-endian' or 'big-endian'. Default: 'little-endian'. +------------------------------------------------------------------------ +r12981 | guy | 2005-01-07 06:56:21 -0600 (Fri, 07 Jan 2005) | 4 lines +Changed paths: + M /trunk/epan/proto.c + M /trunk/epan/proto.h - A hint is just that; E.G. if TDS7+ packets are encountered the decode - is always 'little-endian'. +Constify a pointer, so that the array of pointers to ett_ values can be +const, although the pointers can't point to consts (as the values get +filled in as they're registered). -2, Register tcp MS SQL default ports (1433, 2433) as TDS ports - ('dissector_add'). This also enables TDS as a choice for 'decode as'. +------------------------------------------------------------------------ +r12980 | guy | 2005-01-07 06:00:01 -0600 (Fri, 07 Jan 2005) | 2 lines +Changed paths: + M /trunk/AUTHORS + M /trunk/epan/tvbuff.h -3. 'netlib_check_login_pkt' changed to check 'TDS tcp port' range(s) as - entered in preferences; +Doxygen cleanups, from Mike Duigou. -4. Change 'dissect_tds_query_packet' to handle TDS4 ascii in addition to - TDS7/8 UCS-16. +------------------------------------------------------------------------ +r12979 | guy | 2005-01-07 05:59:05 -0600 (Fri, 07 Jan 2005) | 2 lines +Changed paths: + M /trunk/doc/README.developer -5. Change 'dissect_tds_rpc' to: +Grammar and typo fix from Mike Duigou. - a. handle TDS4 ascii RPC in addition to TDS7/8 UCS-16 RPC; - b. handle Microsoft 'encoded' rpc_name; - c. fix memory leak (not freeing memory obtained using - 'tvb_fake_unicode'); +------------------------------------------------------------------------ +r12978 | guy | 2005-01-07 05:56:00 -0600 (Fri, 07 Jan 2005) | 5 lines +Changed paths: + M /trunk/epan/addr_resolv.h -6. Change 'dissect_tds_response' to: +Include <epan/address.h>, as per a suggestion by Thomas Boehne - not all +dissectors using the address resolution routines need to know about the +"address" structure, so not all of them would include <epan/address.h> +themselves. - a. handle tds4 tokens 'tds_col_name' and 'tds_col_info'; - b. dissect tokens 'tds_doneinproc' and tds 'doneproc' similarly to - 'tds_done' - c. reclaim memory allocated for 'tds_col' structures when finished - processing response - (Additional memory was being allocated each time a - tokenized tds5 response was processed) +------------------------------------------------------------------------ +r12977 | guy | 2005-01-07 05:43:05 -0600 (Fri, 07 Jan 2005) | 8 lines +Changed paths: + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-bgp.h -7. New function 'dissect_tds_col_info_token' (similar to - 'read_results_tds5') associated with handling TDS4 responses. +From Carlos Pignataro: -8. New functions 'dissect_tds_query5_packet', 'dissect_tds5_lang_token' + o BGPv4 SAFI-Specific Attribute support + - draft-kapoor-nalawade-idr-bgp-ssa-00.txt + o Tunnel SAFI support for BGP + - draft-nalawade-kapoor-tunnel-safi-02.txt + o Small length fix -9. Rework TDS token size calculation; Some TDS tokens have a length field - of other than 2 bytes. (e.g.: the length field - for TDS_LANG_TOKEN is 4 bytes) +------------------------------------------------------------------------ +r12976 | guy | 2005-01-07 05:22:18 -0600 (Fri, 07 Jan 2005) | 2 lines +Changed paths: + M /trunk/epan/addr_resolv.c -10. Update token definitions and usages; +Put back the declaration of hostspath on Windows. - a. Update based upon info from current version of FreeTDS 'tds.h' - as well as info from Sybase TDS5 document; - example: TDS_124_TOKEN renamed to TDS_PROCID_TOKEN +------------------------------------------------------------------------ +r12975 | guy | 2005-01-07 04:49:05 -0600 (Fri, 07 Jan 2005) | 3 lines +Changed paths: + M /trunk/epan/req_resp_hdrs.c - b. TDS_124_TOKEN [TDS_PROCID] was incorrectly not considered - a 'fixed-size' token in function 'tds_is_fixed_token' +From Chris Maynard: free strings fetched with "tvb_get_string()" when +we're done with them. ------------------------------------------------------------------------ -r12565 | etxrab | 2004-11-21 15:47:51 -0600 (Sun, 21 Nov 2004) | 1 line +r12974 | guy | 2005-01-07 04:44:44 -0600 (Fri, 07 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-srvloc.c + +From Chris Maynard: free strings fetched with "tvb_fake_unicode()" when +we're done with them. -If message for SIP port starts with F8 it's a SIGCOMP message - decode it. ------------------------------------------------------------------------ -r12564 | sahlberg | 2004-11-21 15:29:10 -0600 (Sun, 21 Nov 2004) | 4 lines +r12973 | guy | 2005-01-07 04:39:51 -0600 (Fri, 07 Jan 2005) | 6 lines Changed paths: - M /trunk/asn1/cmip/CMIP.asn - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-smpp.c -update to cmip -add functions m-action and m-action-confirmed +From Chris Maynard: free mallocated strings when we're done with them. +(There's still the risk of a leak if we throw an exception before we +free the string.) +Clean up indentation. ------------------------------------------------------------------------ -r12563 | guy | 2004-11-21 15:23:30 -0600 (Sun, 21 Nov 2004) | 3 lines +r12972 | guy | 2005-01-07 04:20:17 -0600 (Fri, 07 Jan 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/addr_resolv.c -From Yaniv Kaul: yet *another* place where an NTLMSSP rather than GSSAPI -blob can appear. +Move the open and close of the hosts file into "read_hosts_file()". + +On Windows, if we don't get the SYSTEMROOT environment variable, try +various locations where the hosts file is known to exist. ------------------------------------------------------------------------ -r12562 | guy | 2004-11-21 15:05:16 -0600 (Sun, 21 Nov 2004) | 25 lines +r12971 | guy | 2005-01-07 04:09:34 -0600 (Fri, 07 Jan 2005) | 23 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-aodv.c - -From Shingo Horisawa: + M /trunk/epan/dissectors/packet-slsk.c - add the "unknown sequence number" flag; +From Chris Maynard: free strings fetched with "tvb_get_string()". - fix dissection of unreachable destinations in RERR messages; +Use "format_text()" or "tvb_format_text()" with the %s format, to handle +non-printable characters. - fix prefix size in draft-perkins-manet-aodv6-01 RREP - messages to be 7 bits, not 5 bits; +When uncompressing data into a new tvbuff, add it to the list of data +sources as we do elsewhere. - put the message dissection under the top-level AODV tree rather - than at the top level; +When putting items into the protocol tree from an uncompressed tvbuff, +use the offset into the tvbuff and the length of the item. - fix labeling of source IPv6 address in RREP messages. +Fetch string lengths into a variable and use the variable rather than +repeatedly fetching the length from a tvbuff. -Update the comments at the beginning (AODV is now RFC 3561), and note -that RFC 3561 says that, for IPv6, the only change is that the address -fields are enlarged. +Use -1 rather than tvb_length_remaining() when putting a "to the end of +the tvbuff" item into the protocol tree. -Rename RREQ_DEST and RREQ_GRAT to more fully indicate what they are. +Use "proto_tree_add_item()" to put items into the tree, rather than +"proto_tree_add_xxx" calls with a "tvb_get_yyy" call as the argument. -Fix the name of the draft in the description of the -draft-perkins-manet-aodv6-01 messages. - -Fix description of Gratuitous RREP flag in RREQ messages. +If we've fetched a value into a variable, don't re-fetch it in +"proto_tree_add_xxx" calls. ------------------------------------------------------------------------ -r12561 | ulfl | 2004-11-21 05:52:34 -0600 (Sun, 21 Nov 2004) | 1 line +r12970 | lroland | 2005-01-06 21:19:39 -0600 (Thu, 06 Jan 2005) | 5 lines Changed paths: M /trunk/epan/addr_resolv.c -removed an MSVC warning +Check return value of getenv(). +It can return NULL, which would lead here to strcpy(hostspath, NULL); +*Very* bad. + +replace g_malloc(), strcpy() and strcat() with one single g_strconcat(). ------------------------------------------------------------------------ -r12560 | sahlberg | 2004-11-21 05:12:20 -0600 (Sun, 21 Nov 2004) | 2 lines +r12969 | lroland | 2005-01-06 17:21:10 -0600 (Thu, 06 Jan 2005) | 3 lines Changed paths: - M /trunk/asn1/pkix1explicit/pkix1explicit.cnf - M /trunk/epan/dissectors/packet-pkix1explicit.c + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/packet-mate.c -add a new oid +From Luis Ontanon: +Fix some MSVC warnings in MATE ------------------------------------------------------------------------ -r12559 | sahlberg | 2004-11-21 04:34:08 -0600 (Sun, 21 Nov 2004) | 8 lines +r12968 | lroland | 2005-01-06 06:39:54 -0600 (Thu, 06 Jan 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/packet-mate.c -with the autogenerated export conformance files we need a small change to packet-ber.c +From Luis Ontanon: -asn2eth generates exports for CHOICE as of BER_CLASS_UNI while the handgenerated ones specified the calss as BER_CLASS_ANY. +Another patch for mate: + - adds a "GopTree={TRUE|FALSE}" attribute to Gogs + - changes "ShowPduTree={NoTree|PduTree|FrameTree}" + - adds "implicit stop" to Gops with no Stop declared +------------------------------------------------------------------------ +r12967 | guy | 2005-01-06 02:37:43 -0600 (Thu, 06 Jan 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-ethertype.c + A /trunk/epan/dissectors/packet-ieee802a.c + A /trunk/epan/dissectors/packet-ieee802a.h + M /trunk/etypes.h -make dissect_ber_sequence() look at the tag as well and if -1 its a wildcard and anything goes. +Add a dissector to handle IEEE 802a's OUI Extended Ethertype; dissectors +can register an OUI, and PIDs for that OUI, in the same fashion that +they can do so for SNAP (after which the 802a OUI Extended Ethertype is +clearly modeled). +------------------------------------------------------------------------ +r12966 | guy | 2005-01-06 02:21:25 -0600 (Thu, 06 Jan 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-llc.c +Handle the case where nobody registers any OUIs and oui_info_table is +thus null. ------------------------------------------------------------------------ -r12558 | sahlberg | 2004-11-21 04:16:06 -0600 (Sun, 21 Nov 2004) | 3 lines +r12965 | guy | 2005-01-05 05:00:11 -0600 (Wed, 05 Jan 2005) | 4 lines Changed paths: - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/pkcs1/pkcs1.cnf - M /trunk/asn1/pkixqualified/pkixqualified.cnf - A /trunk/asn1/x509af/Makefile - A /trunk/asn1/x509af/x509af-exp.cnf - M /trunk/asn1/x509af/x509af.cnf - D /trunk/asn1/x509af/x509af_exp.cnf - M /trunk/asn1/x509ce/x509ce.cnf - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-pkcs1.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h - M /trunk/epan/dissectors/packet-x509ce.c - -cleanup for x509af + M /trunk/epan/dissectors/packet-sip.c +From Chris Maynard: catch a case where a string allocated with +"tvb_get_string()" wasn't freed. (It appears there can also be leaks if +an exception is thrown while dissecting.) ------------------------------------------------------------------------ -r12557 | sahlberg | 2004-11-21 04:00:40 -0600 (Sun, 21 Nov 2004) | 3 lines +r12964 | guy | 2005-01-05 04:55:00 -0600 (Wed, 05 Jan 2005) | 5 lines Changed paths: - M /trunk/asn1/pkixqualified/pkixqualified.cnf - M /trunk/asn1/x509af/x509af.cnf - M /trunk/asn1/x509ce/CertificateExtensions.asn - A /trunk/asn1/x509ce/Makefile - M /trunk/asn1/x509ce/packet-x509ce-template.c - A /trunk/asn1/x509ce/x509ce-exp.cnf - M /trunk/asn1/x509ce/x509ce.cnf - D /trunk/asn1/x509ce/x509ce_exp.cnf - M /trunk/epan/dissectors/packet-pkixqualified.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509ce.h + M /trunk/epan/dissectors/packet-sebek.c -cleanup for x509ce +Use tvb_format_text() with %s format items, to handle non-printable +characters. +Clean up indentation. ------------------------------------------------------------------------ -r12556 | sahlberg | 2004-11-21 02:56:09 -0600 (Sun, 21 Nov 2004) | 3 lines +r12963 | guy | 2005-01-05 04:51:05 -0600 (Wed, 05 Jan 2005) | 5 lines Changed paths: - M /trunk/asn1/x509af/x509af.cnf - M /trunk/asn1/x509ce/x509ce.cnf - M /trunk/asn1/x509if/Makefile - M /trunk/asn1/x509if/x509if.cnf - A /trunk/asn1/x509sat/Makefile - M /trunk/asn1/x509sat/SelectedAttributeTypes.asn - M /trunk/asn1/x509sat/packet-x509sat-template.c - A /trunk/asn1/x509sat/x509sat-exp.cnf - M /trunk/asn1/x509sat/x509sat.cnf - D /trunk/asn1/x509sat/x509sat_exp.cnf - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/dissectors/packet-x509sat.h + M /trunk/epan/dissectors/packet-sdp.c -SelectedAttributeTypes are now almost completely implemented also here i added a small makefile to reduce boring typing on the commandline +From Chris Maynard: don't extract strings with "tvb_get_string()" if +we're not going to use them, and free them when we're done with them. +Clean up white space. ------------------------------------------------------------------------ -r12555 | sahlberg | 2004-11-21 02:22:21 -0600 (Sun, 21 Nov 2004) | 3 lines +r12962 | guy | 2005-01-05 04:45:43 -0600 (Wed, 05 Jan 2005) | 3 lines Changed paths: - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/x509af/x509af.cnf - M /trunk/asn1/x509ce/x509ce.cnf - A /trunk/asn1/x509if/Makefile - A /trunk/asn1/x509if/x509if-exp.cnf - D /trunk/asn1/x509if/x509if_exp.cnf - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h + M /trunk/epan/dissectors/packet-q931.c -update to x509if autogenerate the exports conformance file and create a small makefile since i am tired of typing that long command line every time +From Chris Maynard: free strings allocated by "tvb_get_string()" after +we're done with them. +------------------------------------------------------------------------ +r12961 | guy | 2005-01-05 04:42:26 -0600 (Wed, 05 Jan 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-per.c + +From Chris Maynard: free strings allocated by "tvb_fake_unicode()" after +we're done with them. ------------------------------------------------------------------------ -r12554 | sahlberg | 2004-11-21 01:21:17 -0600 (Sun, 21 Nov 2004) | 3 lines +r12960 | guy | 2005-01-05 04:38:50 -0600 (Wed, 05 Jan 2005) | 5 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-app-pkix-cert.c + M /trunk/epan/dissectors/packet-multipart.c -From Yaniv Kaul : New Protocol: X509 Certificates over HTTP +From Chris Maynard: free mallocated data. +Don't assign the result of a routine that mallocates data to a const +pointer - that forces us to cast the pointer when freeing the data. ------------------------------------------------------------------------ -r12553 | sahlberg | 2004-11-21 00:40:02 -0600 (Sun, 21 Nov 2004) | 5 lines +r12959 | guy | 2005-01-05 04:27:22 -0600 (Wed, 05 Jan 2005) | 3 lines Changed paths: - M /trunk/asn1/x509if/InformationFramework.asn - M /trunk/asn1/x509if/x509if.cnf - M /trunk/asn1/x509if/x509if_exp.cnf - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h + M /trunk/epan/dissectors/packet-mmse.c -Add a whole bunch of dissector to X509IF and export them. -X509if is now almost complete. +From Chris Maynard: free strings even if we don't put them into the +protocol tree. +------------------------------------------------------------------------ +r12958 | guy | 2005-01-05 04:23:26 -0600 (Wed, 05 Jan 2005) | 2 lines +Changed paths: + M /trunk/plugins/mgcp/packet-mgcp.c +From Chris Maynard: free a string obtained with "tvb_get_string()". ------------------------------------------------------------------------ -r12552 | sahlberg | 2004-11-20 23:21:26 -0600 (Sat, 20 Nov 2004) | 3 lines +r12957 | guy | 2005-01-05 04:19:36 -0600 (Wed, 05 Jan 2005) | 6 lines Changed paths: - M /trunk/asn1/pkix1explicit/PKIX1EXPLICIT93.asn - M /trunk/asn1/pkix1explicit/pkix1explicit.cnf - M /trunk/asn1/pkix1explicit/pkix1explicit_exp.cnf - M /trunk/asn1/pkix1implicit/PKIX1IMPLICIT93.asn - M /trunk/asn1/pkix1implicit/packet-pkix1implicit-template.c - M /trunk/asn1/pkix1implicit/pkix1implicit.cnf - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-pkix1explicit.h - M /trunk/epan/dissectors/packet-pkix1implicit.c - -add dissection of AuthorityInfoAccessSyntax + M /trunk/epan/tvbuff.c +From Chris Maynard: free up the z_stream we've allocated before failure +returns. (The error returns shouldn't happen in practice, as the GLib +memory allocators never return a null pointer, they just abort the +program, but if we're going to be checking for failure and returning, we +should do the right thing anyway.) ------------------------------------------------------------------------ -r12551 | guy | 2004-11-20 21:21:02 -0600 (Sat, 20 Nov 2004) | 2 lines +r12956 | guy | 2005-01-05 04:17:09 -0600 (Wed, 05 Jan 2005) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-aodv.c + M /trunk/epan/dissectors/packet-kerberos.c -From Bart Braem: add support for the "destination only" flag. +From Chris Maynard: free strings fetched with "tvb_fake_unicode()". ------------------------------------------------------------------------ -r12550 | guy | 2004-11-20 21:01:15 -0600 (Sat, 20 Nov 2004) | 2 lines +r12955 | guy | 2005-01-05 04:13:24 -0600 (Wed, 05 Jan 2005) | 3 lines Changed paths: - M /trunk/plugins/gryphon/packet-gryphon.c + M /trunk/epan/dissectors/packet-image-jfif.c -Update a URL. +Free the image type string as soon as we're done with it, so that we +don't leak it (even if we throw an exception processing the image). ------------------------------------------------------------------------ -r12549 | sahlberg | 2004-11-20 15:26:08 -0600 (Sat, 20 Nov 2004) | 3 lines +r12954 | guy | 2005-01-05 04:05:03 -0600 (Wed, 05 Jan 2005) | 3 lines Changed paths: - M /trunk/asn1/pkix1implicit/PKIX1IMPLICIT93.asn - M /trunk/asn1/pkix1implicit/packet-pkix1implicit-template.c - M /trunk/asn1/pkix1implicit/pkix1implicit.cnf - M /trunk/epan/dissectors/packet-pkix1implicit.c - -add the oids for id-kp-xxx key purpose identifier to the pkix dissector + M /trunk/epan/dissectors/packet-image-gif.c +From Chris Maynard: add a missing free of a string fetched with +tvb_get_string(). ------------------------------------------------------------------------ -r12548 | sahlberg | 2004-11-20 01:11:08 -0600 (Sat, 20 Nov 2004) | 3 lines +r12953 | guy | 2005-01-05 04:01:04 -0600 (Wed, 05 Jan 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509if.c + M /trunk/epan/dissectors/packet-fix.c -get rid of some compiler warnings +From Chris Maynard: don't fetch a string if we're not going to use it. +Also, move up the freeing of the tag string to immediately after we're +done with it, so we don't leak it if we throw an exception getting the +value. ------------------------------------------------------------------------ -r12547 | sahlberg | 2004-11-20 01:03:27 -0600 (Sat, 20 Nov 2004) | 3 lines +r12952 | guy | 2005-01-05 03:53:03 -0600 (Wed, 05 Jan 2005) | 3 lines Changed paths: - M /trunk/tools/asn2eth.py - -add _U_ to int hf_index to reduce number of compiler warnings + M /trunk/epan/dissectors/packet-daap.c +Use "tvb_format_text()" with %s format strings, so that we handle +non-printable strings. ------------------------------------------------------------------------ -r12546 | sahlberg | 2004-11-20 00:54:45 -0600 (Sat, 20 Nov 2004) | 3 lines +r12951 | guy | 2005-01-05 03:46:43 -0600 (Wed, 05 Jan 2005) | 4 lines Changed paths: - M /trunk/asn1/x509sat/SelectedAttributeTypes.asn - M /trunk/asn1/x509sat/packet-x509sat-template.c - M /trunk/asn1/x509sat/x509sat.cnf - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/dissectors/packet-x509sat.h - -updates to sat to make the template smaller. + M /trunk/epan/dissectors/packet-cops.c +Use "tvb_format_text()" to generate the text to use in +"proto_tree_add_text()" calls, so that we handle non-printable +characters if they happen to appear in the strings. ------------------------------------------------------------------------ -r12545 | sahlberg | 2004-11-19 23:58:13 -0600 (Fri, 19 Nov 2004) | 4 lines +r12950 | guy | 2005-01-05 03:41:20 -0600 (Wed, 05 Jan 2005) | 6 lines Changed paths: - M /trunk/asn1/x509sat/SelectedAttributeTypes.asn - M /trunk/asn1/x509sat/packet-x509sat-template.c - M /trunk/asn1/x509sat/packet-x509sat-template.h - M /trunk/asn1/x509sat/x509sat.cnf - M /trunk/asn1/x509sat/x509sat_exp.cnf - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/dissectors/packet-x509sat.h + M /trunk/epan/dissectors/packet-aim.c -ean up SAT a bit remove the unneccesary implementation of DirectoryStr4ing in the template and make the export of it correct. +Use "tvb_format_text()" to extract and format the buddy name string in +the top-level item for the buddy name, rather than extracting the string +into a mallocated buffer (and not freeing it...). +Put all the code to put stuff into the protocol tree inside "if(tree)". +------------------------------------------------------------------------ +r12949 | kukosa | 2005-01-05 01:09:06 -0600 (Wed, 05 Jan 2005) | 1 line +Changed paths: + M /trunk/tools/asn2eth.py +Fixed value string names in field array when NO_PROT_PREFIX option is used ------------------------------------------------------------------------ -r12544 | sahlberg | 2004-11-18 04:46:27 -0600 (Thu, 18 Nov 2004) | 7 lines +r12948 | lroland | 2005-01-04 20:25:34 -0600 (Tue, 04 Jan 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/epan/dissectors/packet-h225.c -When we have a BER blob but we dont have the dissector for that oid implemented in ethereal (yet), -call a new function to start dissecting what unknown fields we can dissect. +Fix broken parts of the new h225 dissector: +- add more data to the Info structure of the h225 taps. +- Fix the output to the Info Column -Currently only PrintableString and INTEGER implemented but it will be easy to add other BER Universal types as needed later +This patch is not complete, but statistics should basically work now. +------------------------------------------------------------------------ +r12947 | guy | 2005-01-04 15:05:56 -0600 (Tue, 04 Jan 2005) | 7 lines +Changed paths: + M /trunk/asn1/h225/packet-h225-template.c +"dissect_h225_H323UserInformation()" returns the number of bytes +dissected, so register it as a new-style dissector. +As we register it by name, we don't need to create a dissector handle +for it to register it in a dissector table - just use "find_dissector()" +to find the handle. ------------------------------------------------------------------------ -r12543 | guy | 2004-11-17 21:35:43 -0600 (Wed, 17 Nov 2004) | 2 lines +r12946 | gerald | 2005-01-04 11:25:38 -0600 (Tue, 04 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/Makefile.nmake -Don't create a dissector handle that we don't use. +Replace a "cp" with three "xcopy"s. ------------------------------------------------------------------------ -r12542 | guy | 2004-11-17 14:09:11 -0600 (Wed, 17 Nov 2004) | 4 lines +r12945 | gerald | 2005-01-03 15:11:53 -0600 (Mon, 03 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-mq.c + M /trunk/capinfos.c + M /trunk/doc/capinfos.pod -Don't set a string pointer to point to a constant string if that pointer -will later be handed to a free-memory routine - g_strdup() the constant -string. +Let capinfos print statistics for more than one file. Normalize +capitalization. ------------------------------------------------------------------------ -r12541 | guy | 2004-11-17 13:46:34 -0600 (Wed, 17 Nov 2004) | 3 lines +r12944 | gerald | 2005-01-03 14:03:16 -0600 (Mon, 03 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/config.nmake -Fix some problems when compiling on Windows and when compiling on -systems where INET6 isn't defined. +Move "c:\cygwin\bin" to the end of the PATH. The latest Cygwin includes a +"link" command which collides with the MSVC linker. ------------------------------------------------------------------------ -r12540 | guy | 2004-11-17 13:41:56 -0600 (Wed, 17 Nov 2004) | 2 lines +r12943 | gerald | 2005-01-03 13:58:04 -0600 (Mon, 03 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/gtk/about_dlg.c -Don't assume that IPv6 addresses are aligned on 32-bit boundaries. +Make the version and library information in the about box copy-and-paste-able +under GTK+ 2.x. ------------------------------------------------------------------------ -r12539 | etxrab | 2004-11-17 13:33:31 -0600 (Wed, 17 Nov 2004) | 1 line +r12942 | kukosa | 2005-01-03 08:41:02 -0600 (Mon, 03 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isup.c + M /trunk/tools/asn2eth.py -From Martin Regner add the possibillity to disscet BICC over SCTP +Directives #.FN_* can be used for Ethereal types as well as for ASN.1 types ------------------------------------------------------------------------ -r12538 | guy | 2004-11-17 04:03:14 -0600 (Wed, 17 Nov 2004) | 2 lines +r12941 | kukosa | 2005-01-03 06:54:31 -0600 (Mon, 03 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c + M /trunk/tools/asn2eth.py + +- names for value_string tables are generated with protocol name prefix +- FROM constraint for PER supported +------------------------------------------------------------------------ +r12940 | obiot | 2005-01-03 05:26:45 -0600 (Mon, 03 Jan 2005) | 3 lines +Changed paths: + M /trunk/AUTHORS + +Change e-mail address of Olivier Biot. -Add IPv6 address<->name mappings for AAAA records. ------------------------------------------------------------------------ -r12537 | guy | 2004-11-17 03:44:41 -0600 (Wed, 17 Nov 2004) | 4 lines +r12939 | guy | 2005-01-03 04:27:20 -0600 (Mon, 03 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/addr_resolv.c - M /trunk/epan/addr_resolv.h + M /trunk/wiretap/netxray.c -Add a hash table for IPv6 addresses, and add an "add_ipv6_name()" -routine to add IPv6-address/name pairings to that table; use that when -reading the hosts file. +Add some more comments about the FCS issue. ------------------------------------------------------------------------ -r12536 | guy | 2004-11-17 02:53:20 -0600 (Wed, 17 Nov 2004) | 3 lines +r12938 | guy | 2005-01-03 04:10:23 -0600 (Mon, 03 Jan 2005) | 3 lines Changed paths: - M /trunk/epan/addr_resolv.c - M /trunk/epan/addr_resolv.h - M /trunk/epan/dissectors/packet-dns.c + M /trunk/wiretap/netxray.c -Rename some routines and structures to reflect that they're specific to -IPv4; use different data structures for port numbers. +Give a bit more information on the "are there FCSes in the frame?" +issue. ------------------------------------------------------------------------ -r12535 | sahlberg | 2004-11-17 02:42:31 -0600 (Wed, 17 Nov 2004) | 3 lines +r12937 | guy | 2005-01-02 23:27:35 -0600 (Sun, 02 Jan 2005) | 8 lines Changed paths: - A /trunk/asn1/smrse - A /trunk/asn1/smrse/SMRSE.asn - A /trunk/asn1/smrse/packet-smrse-template.c - A /trunk/asn1/smrse/packet-smrse-template.h - A /trunk/asn1/smrse/smrse.cnf - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-smrse.c - A /trunk/epan/dissectors/packet-smrse.h + M /trunk/wiretap/netxray.c -New protocol : SMRSE ShortMessageRelayService +Rename the CAPTYPE_ definitions as appropriate - many of them are +specific to particular types of captures, and the same value might +correspond to more than one CAPTYPE_ definition. +Add an additional CAPTYPE_ for some non-gigabit Ethereal capture seen by +Bill Meier, and fix the range check the time stamp units value as per +his mail. ------------------------------------------------------------------------ -r12534 | guy | 2004-11-17 02:34:36 -0600 (Wed, 17 Nov 2004) | 7 lines +r12936 | guy | 2005-01-02 21:42:23 -0600 (Sun, 02 Jan 2005) | 10 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/AUTHORS + M /trunk/wiretap/AUTHORS + M /trunk/wiretap/netxray.c + +From James Fields and Kevin Johnson: fix the handling of time stamps in +a number of Windows Sniffer captures - apparently the time stamp units +are in a field in the file header. + +Add a capture type value seen in at least one ATM capture. -Based on code from Francisco Alcoba, read the hosts file on startup if -we're using ADNS, so that we can resolve host names from the hosts file -as well as from DNS. +Update some comments, and add some comments. -"fgetline()" strips newlines from the line, so don't bother looking for -them when tokenizing the line. +Get rid of some redundant setting of "timeunit". ------------------------------------------------------------------------ -r12533 | gerald | 2004-11-16 17:29:09 -0600 (Tue, 16 Nov 2004) | 2 lines +r12935 | guy | 2005-01-02 19:36:35 -0600 (Sun, 02 Jan 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/README.win32 -Fix a cut/paste error. +Rewrap a paragraph, for the benefit of us old-timers who typically use +80-column wide terminal windows (which also lets more windows fit than +would fit with wider windows). ------------------------------------------------------------------------ -r12532 | etxrab | 2004-11-16 16:15:58 -0600 (Tue, 16 Nov 2004) | 1 line +r12934 | gerald | 2005-01-02 18:08:40 -0600 (Sun, 02 Jan 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-ip.c + +If the ICMP code is present, put it in the Info column. -Implemented state-create, handling of g_hash_table at redesection needs more work. ------------------------------------------------------------------------ -r12531 | etxrab | 2004-11-16 16:15:14 -0600 (Tue, 16 Nov 2004) | 1 line +r12933 | lroland | 2005-01-02 16:56:25 -0600 (Sun, 02 Jan 2005) | 1 line Changed paths: - M /trunk/epan/sigcomp-udvm.c - M /trunk/epan/sigcomp-udvm.h - M /trunk/epan/sigcomp_state_hdlr.c - M /trunk/epan/sigcomp_state_hdlr.h + M /trunk/asn1/h225/packet-h225-template.h + M /trunk/epan/dissectors/packet-h225.h -Implemented state-create, handling of g_hash_table at redesection needs more work. +fix a typo in new packet-h225.h ------------------------------------------------------------------------ -r12530 | guy | 2004-11-16 02:21:32 -0600 (Tue, 16 Nov 2004) | 5 lines +r12932 | etxrab | 2005-01-02 16:05:47 -0600 (Sun, 02 Jan 2005) | 1 line Changed paths: - M /trunk/gtk/follow_dlg.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h -Don't redisplay the "Follow TCP Stream" window on every toggle event for -the display style (ASCII/EBCDIC/char[]/hex) radio button set - pushing a -radio button generates *two* events, one for the button that gets turned -off and one for the button that gets turned on. +Change the dissectors to asn2eth generated ones. +------------------------------------------------------------------------ +r12931 | etxrab | 2005-01-02 16:03:12 -0600 (Sun, 02 Jan 2005) | 1 line +Changed paths: + A /trunk/asn1/h235/h235-exp.cnf +This file is needed if h225 or h245 is generated separately. ------------------------------------------------------------------------ -r12529 | etxrab | 2004-11-15 13:06:10 -0600 (Mon, 15 Nov 2004) | 1 line +r12930 | etxrab | 2005-01-02 16:01:32 -0600 (Sun, 02 Jan 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-h245.c + A /trunk/asn1/h225/h225-exp.cnf + A /trunk/asn1/h225/h225.asn + A /trunk/asn1/h225/h225.cnf + A /trunk/asn1/h225/packet-h225-template.c + A /trunk/asn1/h225/packet-h225-template.h -Add some more OID string translations +asn2eth generated h225 dissector ------------------------------------------------------------------------ -r12528 | sahlberg | 2004-11-14 03:50:24 -0600 (Sun, 14 Nov 2004) | 3 lines +r12929 | etxrab | 2005-01-02 16:00:32 -0600 (Sun, 02 Jan 2005) | 1 line Changed paths: - A /trunk/asn1/pkixqualified - A /trunk/asn1/pkixqualified/PKIXqualified.asn - A /trunk/asn1/pkixqualified/packet-pkixqualified-template.c - A /trunk/asn1/pkixqualified/packet-pkixqualified-template.h - A /trunk/asn1/pkixqualified/pkixqualified.cnf - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-pkixqualified.c - A /trunk/epan/dissectors/packet-pkixqualified.h + A /trunk/asn1/h225 -New protocol PKIXQualified from RFC3739 +asn2eth generated h225 dissector +------------------------------------------------------------------------ +r12928 | etxrab | 2005-01-02 15:58:45 -0600 (Sun, 02 Jan 2005) | 1 line +Changed paths: + A /trunk/asn1/h245/h245-exp.cnf + A /trunk/asn1/h245/h245.asn + A /trunk/asn1/h245/h245.cnf + A /trunk/asn1/h245/packet-h245-template.c + A /trunk/asn1/h245/packet-h245-template.h +asn2eth generated h245 dissector +------------------------------------------------------------------------ +r12927 | etxrab | 2005-01-02 15:58:06 -0600 (Sun, 02 Jan 2005) | 1 line +Changed paths: + A /trunk/asn1/h245 +asn2eth generated h245 dissector ------------------------------------------------------------------------ -r12527 | sahlberg | 2004-11-14 03:48:11 -0600 (Sun, 14 Nov 2004) | 5 lines +r12926 | guy | 2005-01-02 04:01:05 -0600 (Sun, 02 Jan 2005) | 2 lines Changed paths: - M /trunk/asn1/x509if/InformationFramework.asn - M /trunk/asn1/x509if/x509if.cnf - M /trunk/epan/dissectors/packet-x509if.c + M /trunk/epan/dissectors/packet-ldap.c -Since we can now handle SEQUENCE OF ANY uncomment this "difficult" field from -the Attribute SEQUENCE to make it more complete. +*Correctly* append to the filter string. +------------------------------------------------------------------------ +r12925 | guy | 2005-01-02 03:40:26 -0600 (Sun, 02 Jan 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-dns.h + M /trunk/epan/dissectors/packet-nbns.c +Unlike the detailed description of resource record types, the +detailed description of classes is pretty much redundant - remove it. ------------------------------------------------------------------------ -r12526 | sahlberg | 2004-11-14 03:45:04 -0600 (Sun, 14 Nov 2004) | 3 lines +r12924 | guy | 2005-01-01 22:01:00 -0600 (Sat, 01 Jan 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/plugins.c -make SEQUENCE OF understand a sequence of ANY +Don't cast pointers passed as arguments - pass a pointer to the right +type of variable and assign the value; that squelches "dereferencing +type-punned pointer will break strict-aliasing rules" warnings from some +versions of GCC. ------------------------------------------------------------------------ -r12525 | sahlberg | 2004-11-14 02:51:49 -0600 (Sun, 14 Nov 2004) | 3 lines +r12923 | guy | 2005-01-01 21:58:08 -0600 (Sat, 01 Jan 2005) | 3 lines Changed paths: - M /trunk/asn1/x509ce/x509ce.cnf - M /trunk/asn1/x509ce/x509ce_exp.cnf - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509ce.h + M /trunk/epan/proto.c -export GeneralName from X509CE +Cast away the constness of the argument to "g_tree_lookup()" - another +GLib function with an unfortunate signature. +------------------------------------------------------------------------ +r12922 | guy | 2005-01-01 18:23:50 -0600 (Sat, 01 Jan 2005) | 3 lines +Changed paths: + M /trunk/gtk/follow_dlg.c + M /trunk/plugins/asn1/packet-asn1.c + +Cast the values passed to the <ctype.h> macros so as to avoid +sign-extending 8-bit characters. ------------------------------------------------------------------------ -r12524 | sahlberg | 2004-11-14 02:50:37 -0600 (Sun, 14 Nov 2004) | 3 lines +r12921 | guy | 2005-01-01 17:54:32 -0600 (Sat, 01 Jan 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/rtp_analysis.c -make octet string also allow for utf8strings +Add casts of OBJECT_SET_DATA() arguments in cases where that's +appropriate. +Use %u, not %d, to convert unsigned values to strings. ------------------------------------------------------------------------ -r12523 | sahlberg | 2004-11-14 00:13:15 -0600 (Sun, 14 Nov 2004) | 4 lines +r12920 | guy | 2005-01-01 17:40:56 -0600 (Sat, 01 Jan 2005) | 4 lines Changed paths: - A /trunk/epan/dissectors/packet-cmip.c - A /trunk/epan/dissectors/packet-cmip.h + M /trunk/epan/dissectors/packet-tacacs.c -theis is the actual dissector for the new protocol : CMIP +"inet_pton()" isn't getting declared on Windows; include "inet_v6defs.h" +if NEED_INET_V6DEFS_H is defined, as is done in "packet-sdp.c", the +other module using "inet_pton()". +------------------------------------------------------------------------ +r12919 | guy | 2005-01-01 17:29:05 -0600 (Sat, 01 Jan 2005) | 6 lines +Changed paths: + M /trunk/gtk/compat_macros.h +Don't explicitly cast the last argument to OBJECT_SET_DATA() to +"gpointer" - callers should do that if appropriate (or perhaps change +the call to pass a different argument if that's more appropriate), and +even if casting it were the right thing to do, the argument needs to be +surrounded with parentheses so the correct value is cast. ------------------------------------------------------------------------ -r12522 | sahlberg | 2004-11-13 23:15:09 -0600 (Sat, 13 Nov 2004) | 10 lines +r12918 | guy | 2005-01-01 17:25:49 -0600 (Sat, 01 Jan 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-MAP_DialoguePDU.c - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-ns_cert_exts.c - M /trunk/epan/dissectors/packet-pkcs1.c - M /trunk/epan/dissectors/packet-pkinit.c - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509if.c + M /trunk/gtk/ui_util.c -various changes in the generated dissectors after asn2eth was patched. +Cast away the constness of the geom_name argument to +"window_new_with_geom()" - there's no way to tell the compiler that +we're not going to be modifying it, but we aren't. -i think it is high time to put makefiles down in asn1/ since this autogenerating dissectors "experiment" have payed off so well and it actual;ly works! +The right way to check whether a pointer is null and get a Boolean is to +test it against null, not to cast it to a Boolean type - as Boolean +types in C89/C90, at least, are just integral types, that cast might +just throw away the upper 32 bits; that probably yields the results you +want, but the compiler might well justifiably warn about that on an LP64 +platform. +------------------------------------------------------------------------ +r12917 | guy | 2005-01-01 17:22:10 -0600 (Sat, 01 Jan 2005) | 3 lines +Changed paths: + M /trunk/tap-iostat.c -i dont know anything about how autogen stuff works :-( +Fix the signature of "iostat_packet()" - the pointer to data supplied by +the dissector is a const pointer. +------------------------------------------------------------------------ +r12916 | guy | 2005-01-01 17:21:05 -0600 (Sat, 01 Jan 2005) | 6 lines +Changed paths: + M /trunk/plugins/mgcp/packet-mgcp.c +When computing a hash value based on, among other things, a +conversation, use the "index" member of the conversation_t - that lets +you get a value that fits in a guint, but without provoking the warning +you might get from a compiler if you cast a pointer to the conversation +to a guint. +------------------------------------------------------------------------ +r12915 | guy | 2005-01-01 17:19:11 -0600 (Sat, 01 Jan 2005) | 7 lines +Changed paths: + M /trunk/gtk/file_dlg.c + M /trunk/gtk/packet_history.c + M /trunk/gtk/summary_dlg.c + +The right way to check whether a pointer is null and get a Boolean is to +test it against null, not to cast it to a Boolean type - as Boolean +types in C89/C90, at least, are just integral types, that cast might +just throw away the upper 32 bits; that probably yields the results you +want, but the compiler might well justifiably warn about that on an LP64 +platform. ------------------------------------------------------------------------ -r12521 | sahlberg | 2004-11-13 23:12:49 -0600 (Sat, 13 Nov 2004) | 6 lines +r12914 | guy | 2005-01-01 17:11:46 -0600 (Sat, 01 Jan 2005) | 3 lines Changed paths: - A /trunk/asn1/cmip - A /trunk/asn1/cmip/CMIP.asn - A /trunk/asn1/cmip/cmip.cnf - A /trunk/asn1/cmip/packet-cmip-template.c - A /trunk/asn1/cmip/packet-cmip-template.h - M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/dissectors/packet-tr.c + M /trunk/epan/packet.c -New protocol for the telco people to play with : CMIP +Get rid of some warnings about variables whose values might be lost in a +longjmp, by properly qualifying those variables as volatile. + +------------------------------------------------------------------------ +r12913 | guy | 2005-01-01 06:49:54 -0600 (Sat, 01 Jan 2005) | 8 lines +Changed paths: + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + M /trunk/gtk/conversations_eth.c + M /trunk/gtk/conversations_fc.c + M /trunk/gtk/conversations_fddi.c + M /trunk/gtk/conversations_ip.c + M /trunk/gtk/conversations_ipx.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/conversations_table.h + M /trunk/gtk/conversations_tcpip.c + M /trunk/gtk/conversations_tr.c + M /trunk/gtk/conversations_udpip.c + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/h323_conversations.c + M /trunk/gtk/h323_conversations.h + M /trunk/gtk/hostlist_eth.c + M /trunk/gtk/hostlist_fc.c + M /trunk/gtk/hostlist_fddi.c + M /trunk/gtk/hostlist_ip.c + M /trunk/gtk/hostlist_ipx.c + M /trunk/gtk/hostlist_table.c + M /trunk/gtk/hostlist_table.h + M /trunk/gtk/hostlist_tcpip.c + M /trunk/gtk/hostlist_tr.c + M /trunk/gtk/hostlist_udpip.c + M /trunk/gtk/hostlist_wlan.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/rtp_stream.c + M /trunk/tap-iostat.c + M /trunk/tap-iousers.c -Only one function is implemented so fat M-Get but it would be trivial to add all the missing ones once there are example captures. +Make the signatures of functions passed to "register_tap_listener()" +match what "register_tap_listener()" expects (rather than squelching +warnings about the differences by casting function pointers to "void +*"). +Make static some functions not used outside the module in which they're +defined. + +------------------------------------------------------------------------ +r12912 | guy | 2005-01-01 06:32:28 -0600 (Sat, 01 Jan 2005) | 4 lines +Changed paths: + M /trunk/gtk/packet_list.c +Throw in a cast to squelch an (unavoidable, and probably harmless - +GTK+'s function signatures aren't necessarily what they should be) +warning. ------------------------------------------------------------------------ -r12520 | sahlberg | 2004-11-13 23:10:44 -0600 (Sat, 13 Nov 2004) | 16 lines +r12911 | guy | 2005-01-01 06:29:26 -0600 (Sat, 01 Jan 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - M /trunk/tools/asn2eth.py + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h -Major update of the ber helpers to fix a lot of bugs and make the handling of implicit_tags more sane. -It worked reasonably well mainly, I suspect, due to implicit tags are reasonably uncommon in the dissectors we have already implemented and that the bugs were masking eachothers. +"address_to_str()" and "address_to_str_buf()" don't modify the "address" +structure pointed to them by reference, so make the argument a "const" +pointer. +------------------------------------------------------------------------ +r12910 | guy | 2004-12-31 20:57:02 -0600 (Fri, 31 Dec 2004) | 12 lines +Changed paths: + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + M /trunk/epan/tap.h + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/bootp_stat.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/h225_ras_srt.c + M /trunk/gtk/h323_analysis.c + M /trunk/gtk/http_stat.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/isup_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/mgcp_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/service_response_time_table.c + M /trunk/gtk/service_response_time_table.h + M /trunk/gtk/sip_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/wsp_stat.c + M /trunk/tap-ansi_astat.c + M /trunk/tap-bootpstat.c + M /trunk/tap-dcerpcstat.c + M /trunk/tap-gsm_astat.c + M /trunk/tap-h225counter.c + M /trunk/tap-h225rassrt.c + M /trunk/tap-httpstat.c + M /trunk/tap-mgcpstat.c + M /trunk/tap-protocolinfo.c + M /trunk/tap-protohierstat.c + M /trunk/tap-rpcprogs.c + M /trunk/tap-rpcstat.c + M /trunk/tap-sipstat.c + M /trunk/tap-smbsids.c + M /trunk/tap-smbstat.c + M /trunk/tap-wspstat.c -my regression tests (limited test samples though) decodes this new one exactly the same as the old one. +As we've made the tap_specific_data field of a tap_packet_t structure a +const pointer (so that we don't get complaints when we make the +tap-specific data argument to "tap_queue_packet()" a const pointer, +allowing dissectors to hand const data to a tap without a complaint), we +should make the tap per-packet function take a const pointer as an +argument as well. Do so. +In some taps, use _U_, or actually use the argument, rather than +sticking in dummy "X = X" assignments to fake use of parameters. (This +means that the tap functions in question no longer have the notion that +they act on a particular static structure wired in.) -As a bonus by not changing anythiong in the decode is that now it is possible to get dissection of implice items to work properly, hence CMIP -(and also x509 Extensions work now) +------------------------------------------------------------------------ +r12909 | guy | 2004-12-31 16:00:44 -0600 (Fri, 31 Dec 2004) | 12 lines +Changed paths: + M /trunk/epan/dissectors/packet-fcdns.c +Note what Fibre Channel spec documents this protocol. -make heaps of dissector helpers implicit_tag aware. +Don't assign the const pointers passed to hash routines to non-const +pointers. -change asn2eth to generate code to call the implicit_tag aware integer dissector helper. +In "zonenm_to_str()", don't assume there's a null terminator in the +packet - use "tvb_get_string()" so that the buffer into which it's +copied is explicitly null-terminated. +Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string, +rather than as a string with one blank in it. ------------------------------------------------------------------------ -r12519 | sahlberg | 2004-11-13 08:16:06 -0600 (Sat, 13 Nov 2004) | 3 lines +r12908 | guy | 2004-12-31 15:40:22 -0600 (Fri, 31 Dec 2004) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h - -add new integer dissector helper that is aware of implicit tags + M /trunk/epan/dissectors/packet-fcswils.c +Don't bother copying the switch name to a buffer - we can just use +"tvb_get_ptr()". ------------------------------------------------------------------------ -r12518 | sahlberg | 2004-11-13 04:06:15 -0600 (Sat, 13 Nov 2004) | 4 lines +r12907 | guy | 2004-12-31 15:36:08 -0600 (Fri, 31 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - -fix bug in handling an optional item + M /trunk/epan/dissectors/packet-fcswils.c +Fix a bug introduced in the previous checkin. +Make the names for list record types match the names used before the +previous checkin. ------------------------------------------------------------------------ -r12517 | guy | 2004-11-12 17:14:49 -0600 (Fri, 12 Nov 2004) | 4 lines +r12906 | guy | 2004-12-31 15:20:46 -0600 (Fri, 31 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-fcip.c -Get rid of an unused prameter and an unused variable. +FC-over-IP is now covered by RFCs; update the specification references. -Use %u, not %d, for unsigned variables. +Make the protcol/version information an array of 8 bytes, not 2 guints; +not all the world's a (little-endian) PC! ------------------------------------------------------------------------ -r12516 | sahlberg | 2004-11-12 16:04:19 -0600 (Fri, 12 Nov 2004) | 9 lines +r12905 | guy | 2004-12-31 14:58:23 -0600 (Fri, 31 Dec 2004) | 22 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-fcswils.h -By popular request, -make ethereal be able to measure the time it took to transfer a PDU atop TCP. +Note what Fibre Channel spec documents this protocol. -This is great for analyzing performance issues caused by network/frame loss/congestion. +Don't assign the const pointers passed to hash routines to non-const +pointers. +Don't use "tvb_get_ptr()" to get a pointer to a data structure, and +dereference that pointer - there's no guarantee that the structure in +question will be located on an appropriate boundary in the data from the +packet (regardless of whether it's properly aligned within the data for +the protocol being dissected). -See http://wiki.ethereal.com/TcpPduTime +Put the record length for an EFP request into the protocol tree. +Check the sanity of the payload length for that request. ------------------------------------------------------------------------- -r12515 | guy | 2004-11-12 04:26:56 -0600 (Fri, 12 Nov 2004) | 3 lines -Changed paths: - M /trunk/epan/tvbuff.c +In "zonenm_to_str()", don't assume there's a null terminator in the +packet - use "tvb_get_string()" so that the buffer into which it's +copied is explicitly null-terminated. -From Charles Levert: in "tvb_fake_unicode()", convert non-ASCII -characters to '.'. +Put the Domain & Port into the protocol tree as a "0xXXXXXXXX" string, +rather than as a string with one blank in it. ------------------------------------------------------------------------ -r12514 | guy | 2004-11-12 04:17:13 -0600 (Fri, 12 Nov 2004) | 4 lines +r12904 | guy | 2004-12-31 14:35:55 -0600 (Fri, 31 Dec 2004) | 10 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-ppp.c - -From Ignacio Goyret: decode RFC 2509 and RFC 3544 IPCP options. + M /trunk/epan/dissectors/packet-fcfcs.c -Fix up the AUTHORS file. +Note what Fibre Channel spec documents this protocol. ------------------------------------------------------------------------- -r12513 | guy | 2004-11-12 04:03:53 -0600 (Fri, 12 Nov 2004) | 4 lines -Changed paths: - M /trunk/epan/dissectors/packet-ipsec.c +Don't assign the const pointers passed to hash routines to non-const +pointers. -From Mark Phillips: optionally support decoding the payload of ESP -packets using null encryption (with a heuristic to detect null -encryption). +Don't assume that strings the spec says are null-terminated are +necessarily null-terminated in the packet - use "tvb_strsize()" to find +the length of the purported null-terminated string; it'll throw the +appropriate exception if no null is found. ------------------------------------------------------------------------ -r12512 | guy | 2004-11-12 03:56:12 -0600 (Fri, 12 Nov 2004) | 3 lines +r12903 | lroland | 2004-12-31 08:53:17 -0600 (Fri, 31 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-acse.c - -From Yuriy Sidelnikov: remove some unused value_string tables, and fix -typos in other tables. + M /trunk/plugins/Xplugin_table.h + M /trunk/plugins/plugin_api_list.c +Update some function declarations in the plugin api ------------------------------------------------------------------------ -r12511 | guy | 2004-11-12 03:46:31 -0600 (Fri, 12 Nov 2004) | 6 lines +r12902 | lroland | 2004-12-31 08:27:38 -0600 (Fri, 31 Dec 2004) | 14 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c - -For dynamic DNS updates, give the counts in the message the appropriate -names. - -For RRs with a data length of 0 - as can appear in dynamic DNS updates - -don't attempt to display the data. + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/matelib/h225_ras.mate + M /trunk/plugins/mate/matelib/isup.mate + M /trunk/plugins/mate/packet-mate.c +From Luis Ontanon for Mate: +- moved gop and gog indexes into gopcfgs, which is a propedeutic +change for upcoming changes in the way gops are to be grouped +- changed the way gog-keys are kept in memory +- every gopkey attribute is copied into the gop->extras to avoid +redundancy in the configuration +- added timers to gogs mate.gog_type.StartTime and mate.gog_type.Time +- fixed a bug in scs_subscribe that mangled some strings +- minor interface improvement to scs propedeutic to having types avp +values in a future +- changed medium and large into mate_medium and mate_large in the +scs_collection +- fixed Mode=Replace in Transforms, now it works +- fixed a crash at reinit due to impropper initialization of mate_items ------------------------------------------------------------------------ -r12510 | etxrab | 2004-11-12 01:02:36 -0600 (Fri, 12 Nov 2004) | 1 line +r12901 | lroland | 2004-12-31 08:14:44 -0600 (Fri, 31 Dec 2004) | 2 lines Changed paths: - M /trunk/AUTHORS + M /trunk/tap-h225counter.c -Add Nils Ohlmeier to authors list(SIP patch) +Fix from Luis Ontanon: +Bring tap-h225counter.c in sync with newest revision of the h225 dissector ------------------------------------------------------------------------ -r12509 | guy | 2004-11-11 23:36:25 -0600 (Thu, 11 Nov 2004) | 5 lines +r12900 | guy | 2004-12-30 21:18:13 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/gtk/rpc_progs.c - -Put the file name into the window title, so if you have more than one of -them open, you know which one corresponds to which file. + M /trunk/epan/dissectors/packet-tcap.c -Clean up white space. +Use "proto_tree_add_item()" to add a chunk of bytes to the protocol +tree. ------------------------------------------------------------------------ -r12508 | guy | 2004-11-11 05:50:26 -0600 (Thu, 11 Nov 2004) | 10 lines +r12899 | guy | 2004-12-30 21:17:00 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-pflog.c -As per Sebastian Felis, don't assume that doubling the size of the line -buffer will necessarily be sufficient to make it big enough to handle -what's being added to the buffer - continue doubling the size until it -is. - -Put the code to maintain the line buffer into a routine. - -As that buffer is maintained as being large enough to handle what's -being put into it, there's no need to use "snprintf()" to print into it. +Don't assign const pointers to non-const pointers, especially if the +object pointed to by the non-const pointer won't be modified. ------------------------------------------------------------------------ -r12507 | etxrab | 2004-11-10 16:15:58 -0600 (Wed, 10 Nov 2004) | 6 lines +r12898 | guy | 2004-12-30 21:14:18 -0600 (Thu, 30 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-pres.c -From Nils Ohlmeier : patch for packet-sip.c which looks if the -Contact header in the REGISTER reply contains more then one binding. -Details: up to now each Contact header was counted as one binding. But that -is not correct, because several Contact headers (as several other SIP headers -as well) can be written in one line separated by commatas. +"string_to_hex()" doesn't modify its first argument, so make it a +"const" pointer, and don't cast away the constness of "tvb_get_ptr()"s +result when passing it to "string_to_hex()". ------------------------------------------------------------------------ -r12506 | ulfl | 2004-11-10 11:58:16 -0600 (Wed, 10 Nov 2004) | 1 line +r12897 | guy | 2004-12-30 21:12:51 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/capture.c + M /trunk/epan/dissectors/packet-ip.c + +Don't cast away the constness of pointers passed to "ip_to_str()" - +"ip_to_str()" takes a "const guint8 *" argument. -bugfix: button in capture info dialog has to stop capturing ------------------------------------------------------------------------ -r12505 | guy | 2004-11-10 04:46:40 -0600 (Wed, 10 Nov 2004) | 2 lines +r12896 | guy | 2004-12-30 21:10:11 -0600 (Thu, 30 Dec 2004) | 4 lines Changed paths: - M /trunk/plugins/opsi/packet-opsi.c + M /trunk/epan/dissectors/packet-edonkey.c -Check for bogus attribute lengths. +There are no guarantees that "strncasecmp()" works with +non-null-terminated strings, so be safe and fetch the metatag string +with "tvb_get_string()". ------------------------------------------------------------------------ -r12504 | guy | 2004-11-10 04:28:43 -0600 (Wed, 10 Nov 2004) | 6 lines +r12895 | guy | 2004-12-30 20:48:53 -0600 (Thu, 30 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-fcip.c -From Rich Coe: +Use "tvb_memeql()" to check whether specified bytes in a packet have a +specified value. - fix the heuristic code -- sometimes a conversation already - exists; - fix the dissect code to display all the tags in the PDU. +Make a constant array "const". ------------------------------------------------------------------------ -r12503 | guy | 2004-11-10 04:03:42 -0600 (Wed, 10 Nov 2004) | 16 lines +r12894 | guy | 2004-12-30 20:16:05 -0600 (Thu, 30 Dec 2004) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ncp-nmas.c + M /trunk/epan/dissectors/packet-tacacs.c -From Greg Morris: +Don't cast away the constness of argument pointers. - support 6 additional login message verbs; +Don't supply our own definition of AF_INET or our own declaration of +"inet_pton()" - use the system ones if they're available. - correct a problem with displaying proper return code values in - the reply packets. +"mkipv4_address()" doesn't modify the string passed to it - make it a +const pointer. -Clean up white space. +------------------------------------------------------------------------ +r12893 | guy | 2004-12-30 20:13:42 -0600 (Thu, 30 Dec 2004) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-gsm_a.c -Use "tvb_reported_length_remaining()" instead of -"tvb_length_remaining()", and don't use either one to avoid throwing an -exception on a short or malformed packet. +Don't roll our own code to display IPv4 or IPv6 addresses, use +"ip_to_str()" and "ip6_to_str()". -Use "val_to_str()" rather than "match_strval()", so we don't crash if a -value happens not to be valid. +Check the length of items for IPv4 and IPv6 addresses before displaying +them as such. ------------------------------------------------------------------------ -r12502 | ulfl | 2004-11-10 00:50:55 -0600 (Wed, 10 Nov 2004) | 1 line +r12892 | guy | 2004-12-30 20:11:13 -0600 (Thu, 30 Dec 2004) | 6 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/epan/dissectors/packet-ldap.c + +Don't assign the const pointers passed to hash routines to non-const +pointers. + +Now that "col_set_str()" takes a "const char *" as the second argument, +we don't have to cast away the constness of strings passed to it. -fix a typo ------------------------------------------------------------------------ -r12501 | guy | 2004-11-09 23:01:09 -0600 (Tue, 09 Nov 2004) | 2 lines +r12891 | guy | 2004-12-30 20:09:48 -0600 (Thu, 30 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/epan/dissectors/packet-mtp3.c -Don't shut down GNU ADNS if it wasn't initialized. +Don't assign a const pointer argument to a non-const pointer variable. ------------------------------------------------------------------------ -r12500 | guy | 2004-11-09 22:57:34 -0600 (Tue, 09 Nov 2004) | 6 lines +r12890 | guy | 2004-12-30 20:08:01 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcels.c + M /trunk/epan/dissectors/packet-fcfzs.c + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-sip.c -Check for errors in "adns_init()", and don't enable ADNS if we get an -error in "adns_init()". (I suspect this is what's causing the crashes -somebody's seeing when they run Ethereal on a Windows system with no -networking protocols installed - no networking protocols -> no Internet -protocols probably -> no ability to set ADNS up.) +Don't assign the const pointers passed to hash routines to non-const +pointers. ------------------------------------------------------------------------ -r12499 | etxrab | 2004-11-09 14:16:17 -0600 (Tue, 09 Nov 2004) | 1 line +r12889 | guy | 2004-12-30 20:03:16 -0600 (Thu, 30 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/column-utils.c + +Properly cast the pointer assigned to col_info->col_data. -From Luis Ontanon: Use hf_isup_parameter_type insted of hf_isup_message_type. ------------------------------------------------------------------------ -r12498 | etxrab | 2004-11-09 01:04:12 -0600 (Tue, 09 Nov 2004) | 1 line +r12888 | guy | 2004-12-30 20:02:19 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/epan/proto.c + M /trunk/epan/proto.h + +"proto_registrar_get_byname()" doesn't modify its argument, so make it +"const char *". -Rename some fields to get rid of warnings, will regenerate the files later. ------------------------------------------------------------------------ -r12497 | etxrab | 2004-11-09 01:03:04 -0600 (Tue, 09 Nov 2004) | 1 line +r12887 | guy | 2004-12-30 20:01:03 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h245.c + M /trunk/timestats.c + M /trunk/timestats.h + +Make arguments "const *" if the routine doesn't modify the object to +which they point. -Add some OID string names ------------------------------------------------------------------------ -r12496 | etxrab | 2004-11-09 00:49:35 -0600 (Tue, 09 Nov 2004) | 1 line +r12886 | jmayer | 2004-12-30 19:56:22 -0600 (Thu, 30 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h - M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-ieee80211.c -Make it possible to print name of OID strings for PER coded OID:s as well. +Make sure print_buff is \0-terminated ------------------------------------------------------------------------ -r12495 | sahlberg | 2004-11-06 14:09:00 -0600 (Sat, 06 Nov 2004) | 3 lines +r12885 | jmayer | 2004-12-30 19:37:54 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/x509if/x509if_exp.cnf - -declare the types for DistinguishedName and RDNSequence + M /trunk/epan/dissectors/packet-ieee80211.c +As pointed out by Guy: We should be able to filter on the original SSID, +so use a copy of the existing one for printing. ------------------------------------------------------------------------ -r12494 | sahlberg | 2004-11-05 23:31:03 -0600 (Fri, 05 Nov 2004) | 3 lines +r12884 | guy | 2004-12-30 18:33:54 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/x509if/x509if.cnf - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h - -export RDNSequence from x509if + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/service_response_time_table.c +In column sort routines, make the row pointers "const" pointers, as the +arguments passed in corresponding to those pointers are gconstpointers. ------------------------------------------------------------------------ -r12493 | sahlberg | 2004-11-05 23:26:31 -0600 (Fri, 05 Nov 2004) | 3 lines +r12883 | guy | 2004-12-30 18:32:00 -0600 (Thu, 30 Dec 2004) | 6 lines Changed paths: - M /trunk/asn1/x509if/x509if.cnf - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h - -export DistinguishedName from x509if + M /trunk/epan/plugins.c + M /trunk/epan/plugins.h +As "get_persconffile_path()" doesn't return a "const char *", neither +does "get_plugins_pers_dir()" - and "get_plugins_global_dir()" doesn't +return one either. Both of them return mallocated data, and making them +return a "const char *" just causes compiler whining when you try to +free them. ------------------------------------------------------------------------ -r12492 | sahlberg | 2004-11-05 20:13:38 -0600 (Fri, 05 Nov 2004) | 3 lines +r12882 | guy | 2004-12-30 18:29:09 -0600 (Thu, 30 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/x509if/InformationFramework.asn - M /trunk/asn1/x509if/x509if.cnf - D /trunk/asn1/x509if/x509if_dummy.cnf - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h - -make x509if use the new ANY type and get rid of the workaround + M /trunk/color_filters.c +"get_persconffile_path()" doesn't return a "const char *", it just +returns a "char *", so don't assign its return value to a "const char *". ------------------------------------------------------------------------ -r12491 | sahlberg | 2004-11-05 20:06:55 -0600 (Fri, 05 Nov 2004) | 3 lines +r12881 | guy | 2004-12-30 18:26:36 -0600 (Thu, 30 Dec 2004) | 21 lines Changed paths: - M /trunk/asn1/cms/CryptographicMessageSyntax.asn - M /trunk/asn1/cms/cms.cnf - D /trunk/asn1/cms/cms_dummy.cnf - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h + M /trunk/epan/filesystem.c + M /trunk/epan/filesystem.h + M /trunk/file.c + M /trunk/file.h + M /trunk/gtk/about_dlg.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/fc_stat.c + M /trunk/gtk/file_dlg.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/ldap_stat.c + M /trunk/gtk/main.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/smb_stat.c + M /trunk/gtk/tap_dfilter_dlg.c -make CMS use the new ANY type and get rid of the workaround +"gtk_entry_get_text()" returns a "const char *" - assign the result to +one. +"get_basename()" doesn't modify its argument, and its callers don't +modify the substring pointed to by the result, so make it take a "const +char *" as an argument and return a "const char *". ------------------------------------------------------------------------- -r12490 | sahlberg | 2004-11-05 20:03:14 -0600 (Fri, 05 Nov 2004) | 3 lines -Changed paths: - M /trunk/asn1/x509af/AuthenticationFramework.asn - M /trunk/asn1/x509af/x509af.cnf - D /trunk/asn1/x509af/x509af_dummy.cnf - M /trunk/epan/dissectors/packet-x509af.c +"find_last_pathname_separator()" doesn't modify its argument, so make it +a "const char *" - but some of its callers pass a non-"const" "char *" +and modify the result, so don't make its return value a "const char *". +And, as none of its callers are outside "filesystem.c", make it static. -Make X509AF use the new support for ANY type and remove the workaround +In "about_folders_page_new()", have separate variables for pathnames +returned as "const char *" (which are cached by the routine that returns +them, so you can't modify them - and can't free them, so get rid of the +commented-out "g_free()" calls for them) and pathnames returned as "char +*" (which are allocated anew for each call, and can be modified, but +have to be freed). +Clean up white space. ------------------------------------------------------------------------ -r12489 | guy | 2004-11-05 15:39:31 -0600 (Fri, 05 Nov 2004) | 10 lines +r12880 | guy | 2004-12-30 18:12:25 -0600 (Thu, 30 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/gtk/packet_list.c + M /trunk/ui_util.h -Move smb.trans2.cmd and smb.nt.function near the top of the hf[] array, -so they show up near the top of the list of fields in the dialog box for -adding a field to a filter - those are probably quite likely to be used -in filter expressions where you don't happen to remember the name of the -field, and those should show up at the top so you don't have to scroll -through the entire list of fields to find them. (I suspect most other -fields either will rarely be filtered on at all, or would be filtered -only mainly with the "Match" or "Prepare" filter items, where you don't -need to know the name or even the text of the field.) +Make the "col_data" field in a "column_info" structure a pointer to an +array of "const char *" rather than to an array of "char *", and make +the second argument of "col_set_str()" a "const char *" - there's no +guarantee that "col_data" points to something you're allowed to modify. ------------------------------------------------------------------------ -r12488 | guy | 2004-11-03 17:44:08 -0600 (Wed, 03 Nov 2004) | 8 lines +r12879 | guy | 2004-12-30 18:05:22 -0600 (Thu, 30 Dec 2004) | 6 lines Changed paths: - M /trunk/gtk/packet_history.c + M /trunk/epan/libethereal.def -When clearing the list, use "history_list", just in case -"history_current" happens to be null (that might not be possible, but -this is still perhaps a bit clearer). +Add a "tvb_bytes_to_str_punct()" routine, which wraps +"bytes_to_str_punct()", and use it instead of extracting the bytes and +formatting them by hand. -Clear "history_current" after clearing the list, as the current entry no -longer exists, so that "packet_history_add()" doesn't use the now-bogus -value. +Also, export "bytes_to_str_punct()". ------------------------------------------------------------------------ -r12487 | guy | 2004-11-03 17:19:09 -0600 (Wed, 03 Nov 2004) | 2 lines +r12878 | guy | 2004-12-30 17:57:29 -0600 (Thu, 30 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter-defs.h + M /trunk/epan/column-utils.h -Fix some typoes and clean up whitespace a bit. +Make the "col_data" field in a "column_info" structure a pointer to an +array of "const char *" rather than to an array of "char *", and make +the second argument of "col_set_str()" a "const char *" - there's no +guarantee that "col_data" points to something you're allowed to modify. ------------------------------------------------------------------------ -r12486 | etxrab | 2004-11-03 16:32:07 -0600 (Wed, 03 Nov 2004) | 1 line +r12877 | guy | 2004-12-30 17:56:12 -0600 (Thu, 30 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter-defs.h + M /trunk/epan/adler32.c + M /trunk/epan/adler32.h -Added some value strings and started to add mobile-ip changes from latest draft. ------------------------------------------------------------------------- -r12485 | etxrab | 2004-11-03 16:16:20 -0600 (Wed, 03 Nov 2004) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-sip.c +The first argument to "adler32_bytes()" is only passed on to +"update_adler32()", and the corresponding argument is a "const unsigned +char *", so that argument can be a "const unsigned char *". -Add SIP headers from: http://www.ietf.org/internet-drafts/draft-ietf-sip-resource-priority-05.txt ------------------------------------------------------------------------ -r12484 | guy | 2004-11-03 14:20:45 -0600 (Wed, 03 Nov 2004) | 6 lines +r12876 | guy | 2004-12-30 17:47:52 -0600 (Thu, 30 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c - -Check for ISL frames before checking for ETHERTYPE_UNK, as ISL fields -might have 0 in what would be the Ethernet type field. + M /trunk/epan/dissectors/packet-fcsb3.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h -Also, handle the first 5 octets of the destination address of an ISL -frame being 0C-00-0C-00-00. +Add a "tvb_bytes_to_str_punct()" routine, which wraps +"bytes_to_str_punct()", and use it instead of extracting the bytes and +formatting them by hand. ------------------------------------------------------------------------ -r12483 | guy | 2004-11-03 14:18:30 -0600 (Wed, 03 Nov 2004) | 2 lines +r12875 | guy | 2004-12-30 17:42:02 -0600 (Thu, 30 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-isl.c + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/gtk/packet_win.c + M /trunk/print.c -Add a new URL for ISL information. +Make the "col_data" field in a "column_info" structure a pointer to an +array of "const char *" rather than to an array of "char *", and make +the second argument of "col_set_str()" a "const char *" - there's no +guarantee that "col_data" points to something you're allowed to modify. ------------------------------------------------------------------------ -r12482 | guy | 2004-11-03 14:01:53 -0600 (Wed, 03 Nov 2004) | 3 lines +r12874 | guy | 2004-12-30 17:19:17 -0600 (Thu, 30 Dec 2004) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/plugins/rtnet/packet-rtnet.c + +We now require gint64/guint64 support to build Ethereal, so get rid of +the #ifdefs. -From Giles Scott: make the chunk size and data length unsigned so we -handle values > 2^31-1. +Don't use "%ll[doux]" - not all platforms use "ll" as the length +specifier for 64-bit integers in formats. Use PRI[doux]64 instead, to +handle platforms where some other length specifier is used. ------------------------------------------------------------------------ -r12481 | guy | 2004-11-03 13:52:24 -0600 (Wed, 03 Nov 2004) | 7 lines +r12873 | etxrab | 2004-12-30 16:40:21 -0600 (Thu, 30 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ftam.c - -From Yuriy Sidelnikov: - - take stuff that has to be done regardless of whether a protocol - tree is being built outside "if (tree)"; - - handle PDUs with both data and control units. + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h +Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh ------------------------------------------------------------------------ -r12480 | guy | 2004-11-03 13:46:09 -0600 (Wed, 03 Nov 2004) | 3 lines +r12872 | etxrab | 2004-12-30 16:39:28 -0600 (Thu, 30 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-pres.c - -From Yuriy Sidelnikov: take stuff that has to be done regardless of -whether a protocol tree is being built outside "if (tree)". + M /trunk/epan/libethereal.def +Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh ------------------------------------------------------------------------ -r12479 | guy | 2004-11-03 13:39:44 -0600 (Wed, 03 Nov 2004) | 2 lines +r12871 | etxrab | 2004-12-30 16:38:59 -0600 (Thu, 30 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-acse.c - -Fix some strings. + M /trunk/gtk/h225_counter.c +Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh ------------------------------------------------------------------------ -r12478 | guy | 2004-11-03 13:34:44 -0600 (Wed, 03 Nov 2004) | 3 lines +r12870 | guy | 2004-12-30 12:34:11 -0600 (Thu, 30 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-acse.c + M /trunk/plugins/Xass-list + M /trunk/plugins/Xplugin_api.c + M /trunk/plugins/Xplugin_api.h + M /trunk/plugins/Xplugin_api_decls.h + M /trunk/plugins/Xplugin_table.h -From Yuriy Sidelnikov: take stuff that has to be done regardless of -whether a protocol tree is being built outside "if (tree)". +Regenerate. ------------------------------------------------------------------------ -r12477 | guy | 2004-11-03 13:23:07 -0600 (Wed, 03 Nov 2004) | 2 lines +r12869 | guy | 2004-12-30 12:33:14 -0600 (Thu, 30 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/plugins/plugin_api_list.c -Use the #define for the eDonkey-over-TCP header length. +Fix the declaration of "tap_queue_packet()" to match its new signature. ------------------------------------------------------------------------ -r12476 | guy | 2004-11-03 13:12:49 -0600 (Wed, 03 Nov 2004) | 6 lines +r12868 | gerald | 2004-12-30 10:45:37 -0600 (Thu, 30 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-edonkey.c - -Add support for desegmentation of eDonkey-over-TCP. + M /trunk/epan/dissectors/packet-dhcpv6.c -Clean up indentation. - -Give edonkey.protocol a value_string table. +From Vincent Jardin: Fix the dissection of relayed messages. ------------------------------------------------------------------------ -r12475 | gerald | 2004-11-02 13:19:04 -0600 (Tue, 02 Nov 2004) | 2 lines +r12867 | guy | 2004-12-29 21:32:38 -0600 (Wed, 29 Dec 2004) | 2 lines Changed paths: - M /trunk/README.win32 + M /trunk/epan/libethereal.def -zlib121-dll -> zlib122-dll. +Add "get_addr_name()" to the list of items exported by libethereal. ------------------------------------------------------------------------ -r12474 | gerald | 2004-11-02 13:07:52 -0600 (Tue, 02 Nov 2004) | 4 lines +r12866 | guy | 2004-12-29 20:28:50 -0600 (Wed, 29 Dec 2004) | 2 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/config.nmake - M /trunk/tools/win32-setup.sh + M /trunk/gtk/conversations_table.c -Update the Windows build to zlib 1.2.2. - -Have win32-setup.sh download from "2004-11-02" tag directory. +Fix some cut-and-pasteos. ------------------------------------------------------------------------ -r12473 | guy | 2004-11-01 19:25:05 -0600 (Mon, 01 Nov 2004) | 2 lines +r12865 | guy | 2004-12-29 20:27:00 -0600 (Wed, 29 Dec 2004) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-null.c -Close a comment, and re-generate the GSM MAP dissector files. +In the "capture_null()" routine, handle IPv6. ------------------------------------------------------------------------ -r12472 | guy | 2004-11-01 19:19:23 -0600 (Mon, 01 Nov 2004) | 6 lines +r12864 | guy | 2004-12-29 20:21:33 -0600 (Wed, 29 Dec 2004) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/gsmmap/packet-gsm_map-template.h - -Get rid of CRs, and set svn:eol-style to native. + M /trunk/epan/dissectors/packet-windows-common.c -Set svn:keywords to ID. - -Delete the eol-style property (it's svn:eol-style). +Update a URL. ------------------------------------------------------------------------ -r12471 | gerald | 2004-11-01 17:54:05 -0600 (Mon, 01 Nov 2004) | 6 lines +r12863 | guy | 2004-12-29 20:10:24 -0600 (Wed, 29 Dec 2004) | 8 lines Changed paths: - M /trunk/config.h.win32 - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/addr_resolv.c + M /trunk/epan/addr_resolv.h + M /trunk/epan/column-utils.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/prefs.c + M /trunk/epan/tap.c + M /trunk/epan/tap.h + M /trunk/gtk/conversations_table.c + M /trunk/gtk/hostlist_table.c + M /trunk/util.c -When we dynamically discover a Kerberos key, it helps to add it to the -key list. In the Nettle code, clear the key list and re-read the key -file when the key file preference changes. +Add a "get_addr_name()" routine that takes an "address *" and attempts +to resolve it to a name. -Remove a redundant define in config.h.win32. +Fix up some const-pointer-to-non-const-pointer, and +function-pointer-to-void-*, conversions. ------------------------------------------------------------------------- -r12470 | etxrab | 2004-11-01 16:33:09 -0600 (Mon, 01 Nov 2004) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h +Fix some comments. -New GSM MAP files based on the asn2eth compiler. ------------------------------------------------------------------------ -r12469 | etxrab | 2004-11-01 16:18:14 -0600 (Mon, 01 Nov 2004) | 1 line +r12862 | guy | 2004-12-29 16:31:56 -0600 (Wed, 29 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.h + M /trunk/gtk/help_dlg.h -Fix a typo ------------------------------------------------------------------------- -r12468 | etxrab | 2004-11-01 16:06:43 -0600 (Mon, 01 Nov 2004) | 1 line -Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/gsmmap/packet-gsm_map-template.h +From Albert Chin: not all compilers support a comma after the last value +in an enum. -Change eol-style to native(?) ------------------------------------------------------------------------ -r12467 | etxrab | 2004-11-01 16:03:57 -0600 (Mon, 01 Nov 2004) | 1 line +r12861 | guy | 2004-12-29 16:17:04 -0600 (Wed, 29 Dec 2004) | 3 lines Changed paths: - A /trunk/asn1/gsmmap/GSMMAP.asn - A /trunk/asn1/gsmmap/gsmmap.cnf - A /trunk/asn1/gsmmap/packet-gsm_map-template.c - A /trunk/asn1/gsmmap/packet-gsm_map-template.h + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-nsip.c -Preparations for addition of GSM MAP dissector created by the asn2eth compiler. ------------------------------------------------------------------------- -r12466 | etxrab | 2004-11-01 16:03:12 -0600 (Mon, 01 Nov 2004) | 1 line -Changed paths: - A /trunk/asn1/gsmmap +From Albert Chin: get rid of C99/GCCisms (initializing automatic +structures with non-constant values). -Preparations for addition of GSM MAP dissector created by the asn2eth compiler. ------------------------------------------------------------------------ -r12465 | gerald | 2004-11-01 12:11:48 -0600 (Mon, 01 Nov 2004) | 2 lines +r12860 | guy | 2004-12-29 15:31:18 -0600 (Wed, 29 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/pkix1explicit/PKIX1EXPLICIT93.asn - M /trunk/asn1/pkix1explicit/packet-pkix1explicit-template.c - M /trunk/asn1/pkix1explicit/pkix1explicit.cnf - M /trunk/epan/dissectors/packet-pkix1explicit.c + M /trunk/gtk/cfilter_combo_utils.c -Add support for the dhpublicnumber OID. +From Albert Chin: "config.h" should always be included first first when +using AC_SYS_LARGEFILE. ------------------------------------------------------------------------ -r12464 | guy | 2004-11-01 11:51:07 -0600 (Mon, 01 Nov 2004) | 8 lines +r12859 | guy | 2004-12-29 15:29:53 -0600 (Wed, 29 Dec 2004) | 3 lines Changed paths: - M /trunk/tools/asn2eth.py - -From Tomas Kukosa: - - add support for ANY type; - - add support for DEFAULT { } (empty sequence); + M /trunk/capture_loop.c - some minor changes. +Pass "capture_opts" to "capture_loop_dispatch()", as +"capture_loop_dispatch()" uses it. ------------------------------------------------------------------------ -r12463 | gerald | 2004-11-01 11:49:53 -0600 (Mon, 01 Nov 2004) | 2 lines +r12858 | guy | 2004-12-29 15:20:42 -0600 (Wed, 29 Dec 2004) | 4 lines Changed paths: - M /trunk/asn1/pkinit/packet-pkinit-template.c - M /trunk/asn1/pkinit/pkinit.cnf - M /trunk/epan/dissectors/packet-pkinit.c + M /trunk/capture_sync.c -Register OID dissectors correctly. +Fix it to compile on systems without "pcap_datalink_val_to_name()" (or +with "pcap_datalink_val_to_name()" but without a declaration of it in +"pcap.h" *cough* Software Update *cough*). ------------------------------------------------------------------------ -r12462 | guy | 2004-11-01 11:48:36 -0600 (Mon, 01 Nov 2004) | 3 lines +r12857 | gerald | 2004-12-29 10:25:06 -0600 (Wed, 29 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/except.c -From Ryuji Somegawa: dissect the Registration Update Authentication -Extension. +Remove some unneeded backslashes. ------------------------------------------------------------------------ -r12461 | gerald | 2004-11-01 11:04:05 -0600 (Mon, 01 Nov 2004) | 2 lines +r12856 | gerald | 2004-12-29 09:54:55 -0600 (Wed, 29 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/make-version.pl -Create a conversation only when we see a KDC_REQ. +If we can't find the "svn" executable in the current path, look in +"c:/cygwin/lib/subversion/bin/", which is the current default location +for Subversion 1.1.1 under Cygwin. If we still can't find "svn", simply +return instead of exiting. ------------------------------------------------------------------------ -r12460 | ulfl | 2004-11-01 05:42:08 -0600 (Mon, 01 Nov 2004) | 1 line +r12855 | ulfl | 2004-12-29 06:37:06 -0600 (Wed, 29 Dec 2004) | 1 line Changed paths: - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - M /trunk/gtk/menu.c - M /trunk/gtk/menu.h - A /trunk/gtk/packet_history.c - A /trunk/gtk/packet_history.h - M /trunk/gtk/packet_list.c - M /trunk/gtk/toolbar.c - M /trunk/gtk/toolbar.h + M /trunk/capture.c + M /trunk/capture.h + M /trunk/capture_loop.c + M /trunk/gtk/font_utils.c + M /trunk/gtk/font_utils.h + M /trunk/gtk/main.c -first implementation of the packet history function +move global capture_child flag into capture_options ------------------------------------------------------------------------ -r12459 | guy | 2004-10-31 17:38:34 -0600 (Sun, 31 Oct 2004) | 3 lines +r12854 | kukosa | 2004-12-29 06:28:16 -0600 (Wed, 29 Dec 2004) | 13 lines Changed paths: - M /trunk + M /trunk/tools/asn2eth.py -Change the list of files to handle "capinfo" being renamed to -"capinfos". +- new optional parameter ETH_VAR for #.EXPORTS directive +- few fixes for last changes + +Summary of changes during last three revisions +- NULL can be used in #.PDU or #.REGISTER directive +- fix in cyclic dependency handling +- keep <proto>-exp.cnf file regardless of '-k' option +- handling of negative values in SingleValue or ValueRange constraints +- handling of all SEQUONCE/SET (OF) types including SIZE constraint +- rename ber_sequence->ber_sequence_t and ber_choice->ber_choice_t +- rename dissect_ber_integer_new()->dissect_ber_integer() +- fix number of parameters for dissect_per_GeneralString() ------------------------------------------------------------------------ -r12458 | guy | 2004-10-31 17:36:21 -0600 (Sun, 31 Oct 2004) | 3 lines +r12853 | ulfl | 2004-12-29 03:09:35 -0600 (Wed, 29 Dec 2004) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/capture.c + M /trunk/capture.h + M /trunk/capture_loop.c + M /trunk/capture_sync.c + M /trunk/capture_sync.h + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/capture_if_dlg.c + M /trunk/gtk/capture_info_dlg.c + M /trunk/gtk/main.c + M /trunk/gtk/main.h -Make the protocol tree item for ICMPv6 cover the entire ICMPv6 packet, -including any included packet. +Don't use a global capture_opts in the capturing engine (this isn't a good idea). Do some more "housekeeping" in the capturing part. +Hopefully the unspecified forward declaration of capture_options_t in main.h is portable, but buildbot will tell me. This way I need the internals of that struct only at the places I really use it. ------------------------------------------------------------------------ -r12457 | guy | 2004-10-31 17:22:14 -0600 (Sun, 31 Oct 2004) | 3 lines +r12852 | guy | 2004-12-28 19:08:20 -0600 (Tue, 28 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/packet.c + M /trunk/alert_box.c + M /trunk/capture_loop.c + M /trunk/editcap.c + M /trunk/epan/filesystem.c + M /trunk/file.c + M /trunk/gtk/color_dlg.c + M /trunk/gtk/dfilter_expr_dlg.c + M /trunk/gtk/file_dlg.c + M /trunk/gtk/font_utils.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/main.c + M /trunk/gtk/prefs_dlg.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/webbrowser.c + M /trunk/mergecap.c + M /trunk/pcap-util.c + M /trunk/tap-protocolinfo.c + M /trunk/tap-rpcstat.c + M /trunk/tethereal.c + M /trunk/version_info.c -Make sure we don't return a random value in an unset variable if an -exception is thrown while dissecting an "error packet". +Make the tone of the error messages a bit less formal, by using +contractions. (Safari does, at least when you're trying to open a file +to which you don't have read access.) ------------------------------------------------------------------------ -r12456 | ulfl | 2004-10-31 05:15:12 -0600 (Sun, 31 Oct 2004) | 1 line +r12851 | guy | 2004-12-28 18:51:29 -0600 (Tue, 28 Dec 2004) | 5 lines Changed paths: - M /trunk/docbook/edg_src/EDG_chapter_works.xml + M /trunk/capture_loop.c + +Use the "errmsg_len" argument to "capture_loop_open_output()" - +"sizeof(errmsg)', when "errmsg" is a "char *", doesn't give the size of +the string to which "errmsg" points, it gives the size of the pointer +itself, which is too small. -add some more content to the overview section ------------------------------------------------------------------------ -r12455 | guy | 2004-10-30 21:47:07 -0500 (Sat, 30 Oct 2004) | 2 lines +r12850 | guy | 2004-12-28 18:44:45 -0600 (Tue, 28 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-rs_pgo.c + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/etypes.h -Get rid of a bunch of trailing spaces. +Add Ethernet type for DEC Local Area Systems Transport. ------------------------------------------------------------------------ -r12454 | guy | 2004-10-30 21:39:39 -0500 (Sat, 30 Oct 2004) | 7 lines +r12849 | gerald | 2004-12-28 13:59:50 -0600 (Tue, 28 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-rs_pgo.c + M /trunk/epan/except.c -Add a "hf_sec_rgy_pname_t_size" hf_ value and corresponding field, and -use it ("sec_rgy_pname_t_size" had been used as an hf_ value, but it's -just a #define). - -Fix the code for some strings to advance the offset by the string size -regardless of whether it's > 1 or not. +Remove some macros that were making the "splint" utility throw a fit. ------------------------------------------------------------------------ -r12453 | guy | 2004-10-30 18:26:47 -0500 (Sat, 30 Oct 2004) | 5 lines +r12848 | ulfl | 2004-12-27 18:36:06 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - M /trunk/capture.c M /trunk/capture_loop.c - M /trunk/capture_sync.c - -Move some #defines and #includes around, and add some other #includes, -to make it compile on UN*X. Get rid of some #includes that don't appear -to be needed, at least on OS X 10.3 (they might be needed on other -platforms). + M /trunk/gtk/capture_dlg.h + M /trunk/ringbuffer.h +some code cleanup (comments changed) ------------------------------------------------------------------------ -r12452 | guy | 2004-10-30 18:05:48 -0500 (Sat, 30 Oct 2004) | 2 lines +r12847 | ulfl | 2004-12-27 18:10:04 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - M /trunk/capture.c - -Get rid of forward declarations of functions not defined in this file. + M /trunk/doc/README.developer +add a more detailed description, how to add a new dissector file ------------------------------------------------------------------------ -r12451 | ulfl | 2004-10-30 12:50:51 -0500 (Sat, 30 Oct 2004) | 1 line +r12846 | ulfl | 2004-12-27 16:04:49 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - M /trunk/Makefile.common - M /trunk/capture.c - M /trunk/capture.h - A /trunk/capture_loop.c - M /trunk/epan/packet.h - M /trunk/gtk/capture_info_dlg.c - M /trunk/gtk/main.c + M /trunk/capture_loop.c -split capture_loop from capture.c, some more code cleanup +a lot of code cleanup/refactoring ------------------------------------------------------------------------ -r12450 | ulfl | 2004-10-30 11:28:00 -0500 (Sat, 30 Oct 2004) | 1 line +r12845 | ulfl | 2004-12-27 15:35:09 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - M /trunk/docbook/edg_graphics/ethereal-capture-normal.dia - M /trunk/docbook/edg_graphics/ethereal-capture-normal.png - M /trunk/docbook/edg_graphics/ethereal-capture-sync.dia - M /trunk/docbook/edg_graphics/ethereal-capture-sync.png + M /trunk/epan/dissectors/packet-tcap.h -update capture dia's +fix a freebsd buildbot compile error, caused by myself :-( ------------------------------------------------------------------------ -r12449 | ulfl | 2004-10-30 09:30:52 -0500 (Sat, 30 Oct 2004) | 1 line +r12844 | ulfl | 2004-12-27 10:11:08 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-mtp3.h -move quit_after_cap into capture_opts +fix a solaris buildbot compile error ------------------------------------------------------------------------ -r12448 | ulfl | 2004-10-30 08:26:15 -0500 (Sat, 30 Oct 2004) | 1 line +r12843 | ulfl | 2004-12-27 08:27:27 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - M /trunk/docbook/edg_src/EDG_chapter_sources.xml + M /trunk/docbook/catalog.xml -from Olivier Biot: how to add a new file to Subversion +location of cygwin's docbook xml changed ------------------------------------------------------------------------ -r12447 | ulfl | 2004-10-30 07:54:53 -0500 (Sat, 30 Oct 2004) | 2 lines +r12842 | ulfl | 2004-12-27 07:17:20 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - M /trunk/docbook/Makefile - M /trunk/docbook/developer-guide.xml - M /trunk/docbook/edg_src/EDG_chapter_works.xml + M /trunk/epan/addr_resolv.c + M /trunk/epan/dissectors/packet-m2pa.c + M /trunk/epan/dissectors/packet-m3ua.c + M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/epan/dissectors/packet-sua.c + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/gtk/decode_as_dcerpc.c + M /trunk/gtk/decode_as_dlg.c -add a simplified overview section about the Ethereal function blocks. -Some cleanup in the docbook Makefile +Again, some warnings removed. ------------------------------------------------------------------------ -r12446 | ulfl | 2004-10-30 07:52:34 -0500 (Sat, 30 Oct 2004) | 1 line +r12841 | ulfl | 2004-12-27 04:11:28 -0600 (Mon, 27 Dec 2004) | 1 line Changed paths: - A /trunk/docbook/edg_graphics/ethereal-capture_internals.dia - A /trunk/docbook/edg_graphics/ethereal-capture_internals.png + M /trunk/epan/dissectors/packet-ieee80211.c -add a dia about the capture internals +Again, another warning (hopefully) removed. ------------------------------------------------------------------------ -r12445 | ulfl | 2004-10-30 06:44:06 -0500 (Sat, 30 Oct 2004) | 2 lines +r12840 | guy | 2004-12-26 16:52:16 -0600 (Sun, 26 Dec 2004) | 3 lines Changed paths: - M /trunk/Makefile.common - M /trunk/capture.c - A /trunk/capture_sync.c - A /trunk/capture_sync.h + M /trunk/epan/dissectors/packet-ssl.c + +From Jouni Malinen: use a length field from the packet to determine how +much data is available, rather than using "tvb_length_remaining()". -code cleanup: split capture_sync from capture.c into it's own file. -That's the part used, when "Update list of packets in real time" is used while capturing. ------------------------------------------------------------------------ -r12444 | guy | 2004-10-30 05:04:35 -0500 (Sat, 30 Oct 2004) | 15 lines +r12839 | guy | 2004-12-26 16:26:02 -0600 (Sun, 26 Dec 2004) | 7 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-udp.c - -from Mark Phillips: the length field in the UDP header includes the -length of the UDP header itself, so subtract the length of the header -when using it to limit the length of the payload tvbuff. + M /trunk/epan/Makefile.common + A /trunk/epan/arptypes.h + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-bootp.c -Clean up the computing of the captured length of the payload tvbuff (we -really should get rid of the "length" argument to "tvb_new_subset()", -and have it compute the captured length based on the supplied reported -length and the amount of that data actually present in the parent -tvbuff). +From Yaniv Kaul: add Ethernet address-to-name (or, at least, address-to- +vendor-name-and-next-three-bytes-in-hex) resolution for Ethernet/802.x +hardware addresses. -Don't fetch the length and checksum fields until we use them (so that we -don't throw an exception until then, and fail to process the source and -destination ports), and check whether the length is bogus regardless of -whether we're building a protocol tree or not. +Move the ARP hardware types into a header file, for use by dissectors +other than the ARP dissector. ------------------------------------------------------------------------ -r12443 | guy | 2004-10-30 04:19:14 -0500 (Sat, 30 Oct 2004) | 2 lines +r12838 | gerald | 2004-12-26 12:58:52 -0600 (Sun, 26 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-image-jfif.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-dhcpv6.c -Squelch some compile warnings. +From Vincent Jardin: + - support for new DHCPv6 options + - fix for the support of OPTION_RELAY_MSG ------------------------------------------------------------------------ -r12442 | guy | 2004-10-30 04:14:36 -0500 (Sat, 30 Oct 2004) | 6 lines +r12837 | ulfl | 2004-12-26 04:11:42 -0600 (Sun, 26 Dec 2004) | 1 line Changed paths: - M /trunk/wiretap/pppdump.c + M /trunk/epan/dissectors/packet-tcap.c -Check for errors from all calls to "file_getc()". +Again, some warnings removed. +------------------------------------------------------------------------ +r12836 | guy | 2004-12-25 18:28:47 -0600 (Sat, 25 Dec 2004) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ssl.c -If we get such an error, always call "file_error()" to get an indication -of what the error was and, if it returns 0, set the error to -WTAP_ERR_SHORT_READ. +From Jouni Malinen: dissect TLS extensions (RFC 3546) for ClientHello +and ServerHello. ------------------------------------------------------------------------ -r12441 | guy | 2004-10-30 03:45:10 -0500 (Sat, 30 Oct 2004) | 9 lines +r12835 | guy | 2004-12-25 18:22:16 -0600 (Sat, 25 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-dns.h + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-radius.c -The length of the protocol tree item passed to "dissect_ppp_common()" -should be the length of the packet being dissected, so that if we throw -an exception dissecting it, the item covers the entire packet (because -it's incomplete, and thus *all* of it is the beginning of the header). +From Luis Ontanon: add more filterable fields to DNS, PGM, GTP, and RADIUS. -Instead, we should pass the length of the part of the header prior to -the protocol field as an argument to "dissect_ppp_common()", and it -should use that to set the length of that item. +------------------------------------------------------------------------ +r12834 | ulfl | 2004-12-25 12:35:21 -0600 (Sat, 25 Dec 2004) | 1 line +Changed paths: + M /trunk/dftest.c + M /trunk/epan/dissectors/packet-aim-chat.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-x11.c +Again, some warnings removed. ------------------------------------------------------------------------ -r12440 | guy | 2004-10-30 02:47:50 -0500 (Sat, 30 Oct 2004) | 5 lines +r12833 | ulfl | 2004-12-25 08:46:40 -0600 (Sat, 25 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-fw1.c + M /trunk/epan/dissectors/packet-pgsql.c -The interface name field is 6 bytes if we *do* have UUID information in -the file and 10 bytes if we *don't*. +Fix a core dump causing the buildbot test menagerie to fail. It was caused by incorrectly trying to proto_tree_add_item() with a very huge length. However, someone with more SQL knowledge than me should have a qualified look at that place and do a better fix. +------------------------------------------------------------------------ +r12832 | ulfl | 2004-12-25 07:49:30 -0600 (Sat, 25 Dec 2004) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-aim-oft.c + M /trunk/epan/dissectors/packet-aim-signon.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmp.c + M /trunk/epan/dissectors/packet-dcerpc-spoolss.c + M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-ipdc.c + M /trunk/epan/dissectors/packet-ipmi.c + M /trunk/epan/dissectors/packet-ipsec.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-nlm.c + M /trunk/epan/dissectors/packet-portmap.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-tds.c + M /trunk/epan/dissectors/packet-x11.c + M /trunk/h225-persistentdata.c + M /trunk/plugins/acn/packet-acn.c + M /trunk/plugins/asn1/packet-asn1.c -Small language edits in preference text and blurb. +a lot of warnings removed, most of them about pointer to int casts without using the appropriate GLib macros +------------------------------------------------------------------------ +r12831 | ulfl | 2004-12-25 04:30:58 -0600 (Sat, 25 Dec 2004) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/epan/dissectors/packet-windows-common.c +Again, some warnings removed. ------------------------------------------------------------------------ -r12439 | guy | 2004-10-30 02:23:55 -0500 (Sat, 30 Oct 2004) | 3 lines +r12830 | ulfl | 2004-12-24 17:17:38 -0600 (Fri, 24 Dec 2004) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-symantec.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcm.c -From Martin Pichlmaier: the first 4 bytes of the Symantec firewall -header are the IP address of the interface that saw the packet. +use GLib's pointer to int conversion macros to prevent compiler warnings +------------------------------------------------------------------------ +r12829 | guy | 2004-12-24 16:21:23 -0600 (Fri, 24 Dec 2004) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-vj.c + +Note the RFC that describes VJ compression. ------------------------------------------------------------------------ -r12438 | sahlberg | 2004-10-29 21:36:58 -0500 (Fri, 29 Oct 2004) | 3 lines +r12828 | sahlberg | 2004-12-24 06:39:21 -0600 (Fri, 24 Dec 2004) | 4 lines Changed paths: - M /trunk/asn1/x509af/AuthenticationFramework.asn - M /trunk/asn1/x509af/packet-x509af-template.c - M /trunk/asn1/x509af/x509af.cnf - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h + A /trunk/asn1/pkixcmp + A /trunk/asn1/pkixcmp/CMP.asn + A /trunk/asn1/pkixcmp/Makefile + A /trunk/asn1/pkixcmp/cmp-exp.cnf + A /trunk/asn1/pkixcmp/cmp.cnf + A /trunk/asn1/pkixcmp/packet-cmp-template.c + A /trunk/asn1/pkixcmp/packet-cmp-template.h + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-cmp.c + A /trunk/epan/dissectors/packet-cmp.h + +New protocol RFC2510 PKIXCMP Certificate Management Protocol -change Extension to be implemented inside the conformance file and remove it from the template ------------------------------------------------------------------------ -r12437 | sahlberg | 2004-10-29 21:18:44 -0500 (Fri, 29 Oct 2004) | 3 lines +r12827 | sahlberg | 2004-12-24 06:22:52 -0600 (Fri, 24 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/x509af/AuthenticationFramework.asn - M /trunk/asn1/x509af/packet-x509af-template.c - M /trunk/asn1/x509af/packet-x509af-template.h - M /trunk/asn1/x509af/x509af.cnf - A /trunk/asn1/x509af/x509af_dummy.cnf - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h + M /trunk/asn1/pkix1implicit/packet-pkix1implicit-template.c + M /trunk/asn1/pkix1implicit/packet-pkix1implicit-template.h + M /trunk/asn1/pkix1implicit/pkix1implicit_exp.cnf + M /trunk/epan/dissectors/packet-pkix1implicit.c + M /trunk/epan/dissectors/packet-pkix1implicit.h -implement AlgorithmIdentifier using the conformance file and remove it from the template +export ResonFlags from pkix1implicit ------------------------------------------------------------------------ -r12436 | sahlberg | 2004-10-29 20:54:40 -0500 (Fri, 29 Oct 2004) | 4 lines +r12826 | sahlberg | 2004-12-24 06:16:27 -0600 (Fri, 24 Dec 2004) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - -fix call_ber_iod_callback() to move offset past the end of the current blob. + M /trunk/asn1/pkix1explicit/packet-pkix1explicit-template.c + M /trunk/asn1/pkix1explicit/packet-pkix1explicit-template.h + M /trunk/asn1/pkix1explicit/pkix1explicit_exp.cnf + M /trunk/epan/dissectors/packet-pkix1explicit.c + M /trunk/epan/dissectors/packet-pkix1explicit.h +export Certificate and CertificateList from pkix1explicit ------------------------------------------------------------------------ -r12435 | gram | 2004-10-29 10:09:00 -0500 (Fri, 29 Oct 2004) | 3 lines +r12825 | sahlberg | 2004-12-24 05:32:13 -0600 (Fri, 24 Dec 2004) | 3 lines Changed paths: - M /trunk/tools/Makefile.am - A /trunk/tools/netscreen2dump.py + A /trunk/asn1/pkixcrmf + A /trunk/asn1/pkixcrmf/CRMF.asn + A /trunk/asn1/pkixcrmf/Makefile + A /trunk/asn1/pkixcrmf/crmf-exp.cnf + A /trunk/asn1/pkixcrmf/crmf.cnf + A /trunk/asn1/pkixcrmf/packet-crmf-template.c + A /trunk/asn1/pkixcrmf/packet-crmf-template.h + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-crmf.c + A /trunk/epan/dissectors/packet-crmf.h + +New "protocol" the support functions from RFC2511 Certificate Request Message Format CRMF -Add netscreen2dump.py, to convert netscreen packet-trace hex dumps -to hex dumps that can be read by text2pcap. ------------------------------------------------------------------------ -r12434 | sahlberg | 2004-10-29 07:11:42 -0500 (Fri, 29 Oct 2004) | 3 lines +r12824 | sahlberg | 2004-12-24 05:24:35 -0600 (Fri, 24 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/cms/CryptographicMessageSyntax.asn + M /trunk/asn1/cms/cms-exp.cnf M /trunk/asn1/cms/cms.cnf - A /trunk/asn1/cms/cms_dummy.cnf - M /trunk/asn1/cms/packet-cms-template.c - M /trunk/asn1/cms/packet-cms-template.h M /trunk/epan/dissectors/packet-cms.c M /trunk/epan/dissectors/packet-cms.h -update to cms to use workaround to lack of ANY and reducing the template significantly +export EnvelopedData ------------------------------------------------------------------------ -r12433 | sahlberg | 2004-10-29 06:39:58 -0500 (Fri, 29 Oct 2004) | 3 lines +r12823 | sahlberg | 2004-12-23 13:56:29 -0600 (Thu, 23 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/x509if/InformationFramework.asn - M /trunk/asn1/x509if/packet-x509if-template.c - M /trunk/asn1/x509if/packet-x509if-template.h - M /trunk/asn1/x509if/x509if.cnf - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h + M /trunk/epan/dissectors/packet-tcp.c -more updates of x509if +RST segmetns are never WindowFull segments. ------------------------------------------------------------------------ -r12432 | sahlberg | 2004-10-29 06:11:11 -0500 (Fri, 29 Oct 2004) | 3 lines +r12822 | sahlberg | 2004-12-23 13:53:24 -0600 (Thu, 23 Dec 2004) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-x509if.c + M /trunk/epan/dissectors/packet-dcerpc.c -new generated version of x509if +add another error code to dcerpc ------------------------------------------------------------------------ -r12431 | sahlberg | 2004-10-29 06:10:31 -0500 (Fri, 29 Oct 2004) | 3 lines +r12821 | ulfl | 2004-12-23 07:34:02 -0600 (Thu, 23 Dec 2004) | 1 line Changed paths: - M /trunk/asn1/x509if/InformationFramework.asn - M /trunk/asn1/x509if/packet-x509if-template.c - M /trunk/asn1/x509if/x509if.cnf - A /trunk/asn1/x509if/x509if_dummy.cnf - -Update to x509if use a workaround to emulate the type ANY and remove stuff from teh template - + M /trunk/gtk/webbrowser.c +show a simple_dialog, if we use glib 1.x and trying to open a webbrowser (not implemented). This will prevent another compiler warning. ------------------------------------------------------------------------ -r12430 | guy | 2004-10-29 03:01:11 -0500 (Fri, 29 Oct 2004) | 3 lines +r12820 | lroland | 2004-12-23 02:27:30 -0600 (Thu, 23 Dec 2004) | 17 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/mate_util.h + M /trunk/plugins/mate/matelib/isup.mate + M /trunk/plugins/mate/matelib/radius.mate + M /trunk/plugins/mate/moduleinfo.h + M /trunk/plugins/mate/packet-mate.c -From Yaniv Kaul: dissect authentication data as NTLMSSP only if it -starts with "NTLMSSP", otherwise dissect it as GSS-API. +Fixes for Mate from Luis Ontanon: +- fixes crash at reinit when DiscardPduData=TRUE: check if there's an +avpl before deleting it. +- mate.pdu_type.RelativeTime had a dual use, add +mate.pdu_type.TimeInGop and leave the other alone. +- other fixes related to times (they now seem to be right) +- scs_subscribe doesn't use g_malloc anymore. it uses GMemChunks +(I had to rename two GMemChunks to make MSVC happy) +- fixes crash at reinit when DiscardPduData=TRUE: check if there's an +avpl before deleting it. +- mate.pdu_type.RelativeTime had a dual use, add +mate.pdu_type.TimeInGop and leave the other alone. +- other fixes related to times (they now seem to be right) +- fixed few things at reinit: + - reset last_id + - remove the nodes in the items hash tables ------------------------------------------------------------------------ -r12429 | guy | 2004-10-28 21:40:01 -0500 (Thu, 28 Oct 2004) | 6 lines +r12819 | ulfl | 2004-12-22 18:27:20 -0600 (Wed, 22 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radiotap.c - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h - -As Sam Leffler notes, the radiotap header isn't BSD-only, it's also used -by his madwifi Atheros driver on Linux; rename -WTAP_ENCAP_IEEE_802_11_WLAN_BSD to WTAP_ENCAP_IEEE_802_11_WLAN_RADIOTAP, -and change its text name from "ieee-802-11-bsd" to -"ieee-802-11-radiotap". + M /trunk/epan/dissectors/packet-dcom-cba-acco.c +Again, some warnings removed. ------------------------------------------------------------------------ -r12428 | guy | 2004-10-28 19:39:56 -0500 (Thu, 28 Oct 2004) | 3 lines +r12818 | sharpe | 2004-12-22 13:44:42 -0600 (Wed, 22 Dec 2004) | 5 lines Changed paths: - M /trunk/epan/strutil.c - -Have the usual three separate buffers for "format_text()", so that it -can be used multiple times in a single formatting call. + M /trunk/epan/dissectors/packet-smb.c ------------------------------------------------------------------------- -r12427 | guy | 2004-10-28 19:36:52 -0500 (Thu, 28 Oct 2004) | 10 lines -Changed paths: - M /trunk/file.c - M /trunk/merge.c - M /trunk/merge.h - M /trunk/mergecap.c -The common merge code merely needs to offer the abstraction of routines -that return the next packet from a set of {chronologically sorted, -sequential-by-file} packets; it doesn't need to have a loop over all -those packets, or any code to write packets. +Clean up one more instance of 8-byte timestamps in SMB. Have to work on +the 4-byte ones soon. -Supply those abstractions, change the code that merges packets to do its -own writing, and have the Ethereal version manage a progress bar and -have the mergecap version print packet numbers in verbose mode, as the -common merge code used to do. ------------------------------------------------------------------------ -r12426 | gerald | 2004-10-28 17:06:55 -0500 (Thu, 28 Oct 2004) | 2 lines +r12817 | guy | 2004-12-22 13:27:09 -0600 (Wed, 22 Dec 2004) | 8 lines Changed paths: - M /trunk/asn1/cms/CryptographicMessageSyntax.asn - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/cms/packet-cms-template.c - M /trunk/asn1/cms/packet-cms-template.h - M /trunk/asn1/pkinit/PKINIT.asn - M /trunk/asn1/pkinit/packet-pkinit-template.c - M /trunk/asn1/pkinit/pkinit.cnf - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h - M /trunk/epan/dissectors/packet-pkinit.c + M /trunk/epan/dissectors/packet-radius.c -Add support for pkauthdata and pkdhkeydata OIDs. +RFC 2868 says that the length of a "tagged string" field must be at +least 3 - 2 for type+length and 1 for the tag - so treat a "tagged +string" field as bad if there isn't at least one byte of data. (It's a +bit odd that the RFC says that the tag must be in the range 0x01-0x1F - +that sounds suspiciously as if they're saying "printable characters +aren't valid tags", to allow untagged strings, which might suggest that +a field with a length of 2 should be interpreted as an empty string.) ------------------------------------------------------------------------ -r12425 | sahlberg | 2004-10-28 06:35:43 -0500 (Thu, 28 Oct 2004) | 4 lines +r12816 | guy | 2004-12-22 04:44:20 -0600 (Wed, 22 Dec 2004) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-windows-common.c -fix small bug that gets offset confused for CHOICE { } OPTIONAL if there were no arms that matched +Check for all bogus ACE lengths, i.e. all lengths < 4. +Clean up indentation. +Add a comment asking whether the revision in an ACL is *really* 2 bytes +and the ACE count is *really* 4 bytes. ------------------------------------------------------------------------ -r12424 | guy | 2004-10-28 02:50:07 -0500 (Thu, 28 Oct 2004) | 11 lines +r12815 | guy | 2004-12-22 03:58:28 -0600 (Wed, 22 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-image-jfif.c + M /trunk/epan/dissectors/packet-ieee80211.c -The offset to the first IFD in a TIFF file is 4 bytes long, not 2 bytes -long. +Add only one protocol tree item for the "weak IV" flag - add it as a +non-hidden Boolean, and use "proto_tree_add_boolean_format()" to add it +to include the key byte. -The offset is relative to the first byte of the TIFF structure, which is -after the "Exif\0" *and* the extra byte after "Exif\0". +------------------------------------------------------------------------ +r12814 | guy | 2004-12-22 03:46:14 -0600 (Wed, 22 Dec 2004) | 7 lines +Changed paths: + M /trunk/gtk/conversations_wlan.c + M /trunk/gtk/hostlist_wlan.c -Loop over all IFDs. +Change the RCS ID - it's not getting expanded when it's "$Id $". -Sanity check the offset to the first IFD and the offset in each IFD to -the next IFD. +Fix a comment in conversations_wlan.c. + +Refer to "WLAN" in hostlist_wlan.c, just as we do in +conversations_wlan.c. ------------------------------------------------------------------------ -r12423 | guy | 2004-10-27 20:52:05 -0500 (Wed, 27 Oct 2004) | 7 lines +r12813 | guy | 2004-12-22 03:19:01 -0600 (Wed, 22 Dec 2004) | 4 lines Changed paths: - M /trunk/file.c - M /trunk/merge.c - M /trunk/merge.h - M /trunk/mergecap.c - -Make "merge_files()" and "merge_append_files()" return a tri-state -indication - success, read failure, write failure - and have their -callers handle read failures by looking for the file that got the read -failure and reporting the failure in question. + M /trunk/gtk/print_dlg.c -Free up the err_info string returned by "wtap_read()" after using it. +From Brett Kuskie: recalculate the ranges every time an export dialog is +opened, not just the first time, so that if the packet counts change +up-to-date values are displayed. ------------------------------------------------------------------------ -r12422 | guy | 2004-10-27 20:06:11 -0500 (Wed, 27 Oct 2004) | 9 lines +r12812 | sharpe | 2004-12-21 20:40:33 -0600 (Tue, 21 Dec 2004) | 10 lines Changed paths: - M /trunk/file.c - M /trunk/merge.c - M /trunk/merge.h - M /trunk/mergecap.c + M /trunk/epan/dissectors/packet-smb.c -Remove all the verbose-mode code from merge.c, and put most of it in -mergecap.c (get rid of the verbose printing of information for each -packet). -Have "merge_append_files()" return FALSE only on a write error, as -"merge_files()" does. +Add a dissection for the GET_NETWORK_FILE_OPEN_INFO and make some stuff that +we do in several places into a subroutine. We need to do it also with the +4-byte time stamps that are dissected all over the place. + +I had thought that that last unknown in the returned structure might be +a count of the number of clients that have the file open, but a simple test +suggests that that is not the case. -Sort the routines in "merge.c" in the order from "merge.h". ------------------------------------------------------------------------ -r12421 | guy | 2004-10-27 18:45:10 -0500 (Wed, 27 Oct 2004) | 3 lines +r12811 | guy | 2004-12-21 19:51:00 -0600 (Tue, 21 Dec 2004) | 4 lines Changed paths: - M /trunk/file.c - M /trunk/file.h - M /trunk/merge.c - M /trunk/merge.h + M /trunk/epan/dissectors/packet-radius.c -Get rid of merge_n_files() - it's only called in one place now, and -absorbing its logic into "cf_merge_files()" simplifies things a bit. +In the "rdconvertXXXtostr()" routines, check that the length passed in +is >= 0 (if it's not, that's a bug), and make the buffer index and total +length variables int as well, to match the length. ------------------------------------------------------------------------ -r12420 | guy | 2004-10-27 18:28:37 -0500 (Wed, 27 Oct 2004) | 10 lines +r12810 | guy | 2004-12-21 19:42:54 -0600 (Tue, 21 Dec 2004) | 5 lines Changed paths: - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/file_dlg.c - M /trunk/gtk/main.c - M /trunk/merge.c - M /trunk/merge.h - M /trunk/mergecap.c + M /trunk/epan/dissectors/packet-radius.c -Change some of the merge.c APIs to return more information on failure, -and use that information to provide better error messages. +Move the RADIUS_TIMESTAMP, RADIUS_INTEGER4_TAGGED, and RADIUS_UNKNOWN +case branches up, so the case branches are in the same order as the +elements of the enum are, and add length checks to RADIUS_TIMESTAMP and +RADIUS_INTEGER4_TAGGED. -Have "merge_open_outfile()" do all the work of filling in the -merge_out_file_t structure, with the values to use passed as arguments. -Get rid of some structure members that used to be used solely to pass -information to "merge_open_outfile()". +------------------------------------------------------------------------ +r12809 | guy | 2004-12-21 18:30:39 -0600 (Tue, 21 Dec 2004) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ieee80211.c -Add a "cf_merge_files()" routine to do the merging and reporting of errors. +Properly declare a variable as volatile, as the longjmp done by the +exception mechanism might clobber it otherwise. ------------------------------------------------------------------------ -r12419 | guy | 2004-10-27 16:16:18 -0500 (Wed, 27 Oct 2004) | 8 lines +r12808 | guy | 2004-12-21 18:23:55 -0600 (Tue, 21 Dec 2004) | 6 lines Changed paths: - M /trunk/asn1/MAP_Dialogue/packet-MAP-DialoguePDU-template.c - M /trunk/asn1/MAP_Dialogue/packet-MAP-DialoguePDU-template.h - M /trunk/epan/dissectors/packet-MAP_DialoguePDU.c - M /trunk/epan/dissectors/packet-MAP_DialoguePDU.h - -"dissect_MAP_Dialogue()" returns no value; declare its return value as -"void". + M /trunk/epan/dissectors/packet-radius.c -Fix a typo in the MAP Dialogue dissector template .h file. +Add some checks to make sure the AVP length is large enough for the item +we're fetching from the AVP. -Re-generate the MAP Dialogue dissector files and set svn:keywords to Id -and svn:eol-style to native for them. +In the case of a tagged string, if the length is 2 (meaning the data +length is 0), assume there's no tag. ------------------------------------------------------------------------ -r12418 | guy | 2004-10-27 15:36:20 -0500 (Wed, 27 Oct 2004) | 2 lines +r12807 | guy | 2004-12-21 17:26:01 -0600 (Tue, 21 Dec 2004) | 3 lines Changed paths: - M /trunk/asn1/cms/CryptographicMessageSyntax.asn - M /trunk/asn1/x509af/AuthenticationFramework.asn + M /trunk/epan/dissectors/packet-dnp.c -Turn off execute permission on .asn files. +Fix one comment, and put in another one giving a note about where you +can get the protocol specs. ------------------------------------------------------------------------ -r12417 | guy | 2004-10-27 15:34:21 -0500 (Wed, 27 Oct 2004) | 8 lines +r12806 | obiot | 2004-12-21 15:17:44 -0600 (Tue, 21 Dec 2004) | 7 lines Changed paths: - A /trunk/asn1/MAP_Dialogue - A /trunk/asn1/MAP_Dialogue/MAP_DialoguePDU.asn (from /trunk/asn1/MAP_Dialouge/MAP_DialoguePDU.asn:12416) - A /trunk/asn1/MAP_Dialogue/MAP_DialoguePDU.cnf (from /trunk/asn1/MAP_Dialouge/MAP_DialoguePDU.cnf:12416) - A /trunk/asn1/MAP_Dialogue/packet-MAP-DialoguePDU-template.c (from /trunk/asn1/MAP_Dialouge/packet-MAP-DialoguePDU-template.c:12416) - A /trunk/asn1/MAP_Dialogue/packet-MAP-DialoguePDU-template.h (from /trunk/asn1/MAP_Dialouge/packet-MAP-DialoguePDU-template.h:12416) - D /trunk/asn1/MAP_Dialouge + M /trunk/epan/dissectors/packet-gsm_sms.c -Fix a typo in the name of the directory for the MAP dialogue ASN.1 -files. +From Victor Stratan: GSM SMS fixes: -Set svn:eol-style to native for those files, and get rid of trailing -CRs. + - Corrected incorrect Timezone output due to byte overflow. -Set svn:keywords to Id for those files. + - Added descriptions for address string decoding. ------------------------------------------------------------------------- -r12416 | etxrab | 2004-10-27 15:17:38 -0500 (Wed, 27 Oct 2004) | 1 line -Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-MAP_DialoguePDU.c - A /trunk/epan/dissectors/packet-MAP_DialoguePDU.h -Add a MapDialouge dissector ( can be tested with the file gsm-ss-01.snoop ) ------------------------------------------------------------------------ -r12415 | etxrab | 2004-10-27 15:08:44 -0500 (Wed, 27 Oct 2004) | 1 line +r12805 | guy | 2004-12-21 14:36:50 -0600 (Tue, 21 Dec 2004) | 3 lines Changed paths: - A /trunk/asn1/MAP_Dialouge/MAP_DialoguePDU.asn - A /trunk/asn1/MAP_Dialouge/MAP_DialoguePDU.cnf - A /trunk/asn1/MAP_Dialouge/packet-MAP-DialoguePDU-template.c - A /trunk/asn1/MAP_Dialouge/packet-MAP-DialoguePDU-template.h + M /trunk/epan/dissectors/packet-mmse.c -Add a MAPdialouge dissector ------------------------------------------------------------------------- -r12414 | etxrab | 2004-10-27 15:06:45 -0500 (Wed, 27 Oct 2004) | 1 line -Changed paths: - A /trunk/asn1/MAP_Dialouge +Use "format_text()" on strings, to better handle non-printable +characters. -Add a MAPdialouge dissector ------------------------------------------------------------------------ -r12413 | etxrab | 2004-10-27 15:04:56 -0500 (Wed, 27 Oct 2004) | 1 line +r12804 | guy | 2004-12-21 14:03:47 -0600 (Tue, 21 Dec 2004) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-mmse.c -Improve OID dissection and make it possible to call an "OID" Dissector for Dialougedata parameter. ------------------------------------------------------------------------- -r12412 | etxrab | 2004-10-27 14:59:44 -0500 (Wed, 27 Oct 2004) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h +Put the strings for the X-Mms-Previously-Sent-By header under the MMSE +tree rather than at the top level. -Make it possible to register a string for an OID in the hash table. ------------------------------------------------------------------------ -r12411 | guy | 2004-10-27 14:36:48 -0500 (Wed, 27 Oct 2004) | 2 lines +r12803 | guy | 2004-12-21 13:28:48 -0600 (Tue, 21 Dec 2004) | 18 lines Changed paths: - M /trunk/merge.c + M /trunk/epan/dissectors/packet-rtcp.h + M /trunk/epan/dissectors/packet-rtp.h + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-t38.h -Fix indentation. +Make the array for the "setup method" for RTP, RTCP, and T.38 +conversations large enough to hold the maximum setup method size plus a +trailing '\0'. Make the maximum setup method size 7, so that when the +trailing '\0' is included the total array length is a power of 2. (The +longest string currently used is "Skinny", which fits in 7 characters). ------------------------------------------------------------------------- -r12410 | guy | 2004-10-27 14:36:22 -0500 (Wed, 27 Oct 2004) | 5 lines -Changed paths: - M /trunk/mergecap.c +This fixes problems in the RTP and RTCP dissectors similar to the one +found in the T.38 dissector. + +Undo the previous change to packet-t38.c, as it's now safe to store in +method[MAX_T38_SETUP_METHOD_SIZE], because the array now has +MAX_T38_SETUP_METHOD_SIZE+1 characters. -Check whether any input files were specified, and print an error for -that - otherwise, you get a "No valid input files" message, which -perhaps doesn't make it clear enough that the problem is that there were -no input files, period. +(Should we use "strlcpy()", and supply our own "strlcpy()" if the system +and/or C library doesn't supply it? Its semantics are a bit cleaner +than those of the "strncpy()"/null-terminate idiom, perhaps making it +less likely that mistakes of this sort will be made.) ------------------------------------------------------------------------ -r12409 | guy | 2004-10-27 14:26:01 -0500 (Wed, 27 Oct 2004) | 2 lines +r12802 | sahlberg | 2004-12-21 11:05:14 -0600 (Tue, 21 Dec 2004) | 5 lines Changed paths: - M /trunk/tools/Makefile.am + M /trunk/epan/dissectors/packet-ldap.c -Add unix2dos.pl to the list of files to be distributed. +from metze ------------------------------------------------------------------------- -r12408 | ulfl | 2004-10-27 14:12:51 -0500 (Wed, 27 Oct 2004) | 1 line -Changed paths: - A /trunk/docbook/edg_graphics/ethereal-capture-normal.dia - A /trunk/docbook/edg_graphics/ethereal-capture-normal.png - A /trunk/docbook/edg_graphics/ethereal-capture-sync.dia - A /trunk/docbook/edg_graphics/ethereal-capture-sync.png - M /trunk/docbook/edg_graphics/ethereal-function-blocks.dia - M /trunk/docbook/edg_graphics/ethereal-function-blocks.png +make ethereal handle gss-api encrypted ldap blobs -two more dia diagrams about Ethereals capture engine and updated the first one ------------------------------------------------------------------------- -r12407 | ulfl | 2004-10-27 12:20:25 -0500 (Wed, 27 Oct 2004) | 1 line -Changed paths: - A /trunk/docbook/edg_graphics - A /trunk/docbook/edg_graphics/ethereal-function-blocks.dia - A /trunk/docbook/edg_graphics/ethereal-function-blocks.png -a dia diagram about Ethereal development (hopefully later some more) ------------------------------------------------------------------------ -r12406 | guy | 2004-10-27 05:02:45 -0500 (Wed, 27 Oct 2004) | 9 lines +r12801 | sahlberg | 2004-12-21 10:44:11 -0600 (Tue, 21 Dec 2004) | 13 lines Changed paths: - M /trunk/epan/dissectors/packet-h450.c - M /trunk/epan/proto.c + M /trunk/epan/dissectors/packet-mmse.c -Check to make sure we don't give a protocol tree item a negative length. +abs_time_to_str() returns a staticly allocated string. dont g_free() it. -Clean up indentation. +fix two instances of wrong parameter list to proto_tree_add_string_format() + +if we call proto_tree_string() the hf field has to be of a string format as well. + + + +now it dissects christophe's capture without dumping core but it looks weird. +mmse and telco people can read the specs and find ut what it wrong. -If we dissect an octet string and then re-dissect it as a particular -type of data, don't use the end offset from the re-dissection as the -offset of the end of the octet string - just use the result of -"dissect_per_octet_string()". ------------------------------------------------------------------------- -r12405 | ulfl | 2004-10-26 23:46:17 -0500 (Tue, 26 Oct 2004) | 1 line -Changed paths: - M /trunk/doxygen.cfg.in - M /trunk/doxygen_global.cfg -fix doxygen generation ------------------------------------------------------------------------ -r12404 | ulfl | 2004-10-26 23:45:00 -0500 (Tue, 26 Oct 2004) | 1 line +r12800 | jmayer | 2004-12-21 07:18:08 -0600 (Tue, 21 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/strutil.h - M /trunk/gtk/help_dlg.h - M /trunk/gtk/main.h + M /trunk/epan/dissectors/packet-pgsql.c + +Abhijit Menon-Sen: + - Make port configurable via prefs + - Highlight keywords in addition to values in hexpane -fix doxygen tags ------------------------------------------------------------------------ -r12403 | ulfl | 2004-10-26 23:03:31 -0500 (Tue, 26 Oct 2004) | 1 line +r12799 | jmayer | 2004-12-21 06:30:24 -0600 (Tue, 21 Dec 2004) | 3 lines Changed paths: - A /trunk/doxygen.cfg.in - M /trunk/epan/doxygen.cfg.in - M /trunk/gtk/doxygen.cfg.in + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ieee80211.h + M /trunk/gtk/Makefile.common + A /trunk/gtk/conversations_wlan.c + A /trunk/gtk/hostlist_wlan.c + +Giles Scott: Add Wlan tap + -fix doxygen generation ------------------------------------------------------------------------ -r12402 | ulfl | 2004-10-26 22:59:02 -0500 (Tue, 26 Oct 2004) | 1 line +r12798 | jmayer | 2004-12-21 06:26:43 -0600 (Tue, 21 Dec 2004) | 1 line Changed paths: - D /trunk/doxygen.cfg.in - A /trunk/doxygen_global.cfg (from /trunk/doxygen.cfg.in:12400) + M /trunk/wiretap/configure.in -fix doxygen generation +Small Whitespacechange ------------------------------------------------------------------------ -r12401 | ulfl | 2004-10-26 22:57:57 -0500 (Tue, 26 Oct 2004) | 1 line +r12797 | ulfl | 2004-12-21 04:02:42 -0600 (Tue, 21 Dec 2004) | 1 line Changed paths: - M /trunk/color.h + M /trunk/epan/dissectors/packet-dcom-cba-acco.c -fix doxygen tags +Again, some warnings removed. ------------------------------------------------------------------------ -r12400 | guy | 2004-10-26 21:52:40 -0500 (Tue, 26 Oct 2004) | 5 lines +r12796 | gerald | 2004-12-20 21:50:14 -0600 (Mon, 20 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c - -Don't have two variables, in different scopes in the same routine, have -the same name. + M /trunk/epan/dissectors/packet-t38.c -Fix up alignment. +Fix an off-by-one error when terminating a string. ------------------------------------------------------------------------ -r12399 | guy | 2004-10-26 21:34:30 -0500 (Tue, 26 Oct 2004) | 8 lines +r12795 | jmayer | 2004-12-20 17:24:13 -0600 (Mon, 20 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-pgsql.c + D /trunk/epan/dissectors/packet-postgresql.c -Encapsulate into a macro the idiom +Abhijit Menon-Sen: Postgres v3 support - if(offset&0x07){ - offset=(offset&0xfffffff8)+8; - } +------------------------------------------------------------------------ +r12794 | guy | 2004-12-20 16:51:05 -0600 (Mon, 20 Dec 2004) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcom.c -for byte-aligning a bit offset. +Get rid of extra include of <string.h>. ------------------------------------------------------------------------ -r12398 | guy | 2004-10-26 18:30:33 -0500 (Tue, 26 Oct 2004) | 5 lines +r12793 | ulfl | 2004-12-20 16:29:24 -0600 (Mon, 20 Dec 2004) | 1 line Changed paths: - M /trunk/doc/ethereal.pod - -Document the personal capture and display filters list in the FILES -section, as is done for other files. Just refer to those files in the -section for the "Save" button for the capture and display filter dialog -boxes. + M /trunk/epan/dissectors/packet-dcom-cba-acco.c + M /trunk/epan/dissectors/packet-dcom-cba.c + M /trunk/epan/dissectors/packet-dcom.c +Removed some of the unix related warnings. I'll remove the remaining DCOM related ones in the next days, step by step (by looking at the buildbot output). ------------------------------------------------------------------------ -r12397 | guy | 2004-10-26 13:41:25 -0500 (Tue, 26 Oct 2004) | 2 lines +r12792 | guy | 2004-12-20 16:25:13 -0600 (Mon, 20 Dec 2004) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tsp.c + M /trunk/epan/dissectors/packet-dcom.c -Fix the file name in the initial comment. +Include <string.h> to declare various functions. ------------------------------------------------------------------------ -r12396 | gerald | 2004-10-26 11:08:16 -0500 (Tue, 26 Oct 2004) | 3 lines +r12791 | guy | 2004-12-20 16:13:48 -0600 (Mon, 20 Dec 2004) | 3 lines Changed paths: M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-image-gif.c + M /trunk/epan/dissectors/packet-image-jfif.c + M /trunk/epan/dissectors/packet-wsp.c -Rename the "boolean" enum to "val_boolean" lest the Microsoft compiler let -its displeasure be known. +Use "plurality()" rather than locally-defined "PLURALIZE()" macros, and +get rid of the definition of "PLURALIZE()" in modules that don't use it. ------------------------------------------------------------------------ -r12395 | sahlberg | 2004-10-26 09:02:02 -0500 (Tue, 26 Oct 2004) | 3 lines +r12790 | gerald | 2004-12-20 10:15:29 -0600 (Mon, 20 Dec 2004) | 2 lines Changed paths: - M /trunk/asn1/ns-cert-exts/ns_cert_exts.cnf - M /trunk/asn1/ns-cert-exts/packet-ns_cert_exts-template.c - -make the dissector use the nice #.REGISTER directive + M /trunk/epan/dissectors/packet-radius.c +Remove an unneeded "ntohl()" call. ------------------------------------------------------------------------ -r12394 | sahlberg | 2004-10-26 08:54:09 -0500 (Tue, 26 Oct 2004) | 3 lines +r12789 | jmayer | 2004-12-20 07:32:08 -0600 (Mon, 20 Dec 2004) | 4 lines Changed paths: - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/cms/packet-cms-template.c - - use the nice #.REGISTER directive instead of handcoding it in teh template + M /trunk/manuf + M /trunk/manuf.tmpl +At least in some cases some Marconi 2810 send packets with +the locally assigned flag set. +Update manuf, while I'm at it. ------------------------------------------------------------------------ -r12393 | sahlberg | 2004-10-26 08:53:30 -0500 (Tue, 26 Oct 2004) | 5 lines +r12788 | jmayer | 2004-12-20 04:56:25 -0600 (Mon, 20 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-cms.c - -new cms dissector based on updated and cleaned up conformance and template file. - -use the nice #.REGISTER directive instead of doing it by hand. + M /trunk/epan/sigcomp-udvm.h + M /trunk/epan/sigcomp_state_hdlr.c +Add NL to last line +------------------------------------------------------------------------ +r12787 | jmayer | 2004-12-20 04:49:12 -0600 (Mon, 20 Dec 2004) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-ieee80211.c +Found by Buildbot Solaris: isprint.h include only works on glib2 systems ------------------------------------------------------------------------ -r12392 | sahlberg | 2004-10-26 08:04:09 -0500 (Tue, 26 Oct 2004) | 3 lines +r12786 | guy | 2004-12-20 03:53:27 -0600 (Mon, 20 Dec 2004) | 6 lines Changed paths: - M /trunk/asn1/x509af/packet-x509af-template.c - M /trunk/asn1/x509af/x509af.cnf + M /trunk/epan/dissectors/packet-ldap.c -Use the much better #.REGISTER directive instead of the #.PDU directive +Put in a stub "dissector" for LDAP_FILTER EXTENSIBLE, so we can at least +dissect packets containing that filter type. +Note that if a dissector for a particular operation fails, we should +stop dissecting rather than trying to dissect the controls. ------------------------------------------------------------------------ -r12391 | guy | 2004-10-26 02:00:23 -0500 (Tue, 26 Oct 2004) | 13 lines +r12785 | sahlberg | 2004-12-20 02:44:10 -0600 (Mon, 20 Dec 2004) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-dcom.c -Add a "data" item to the opt_info structure, containing a "const void -*". For val_u_byte, if non-null, it points to a "value_string" table to -be used to interpret the value. Replace "toggle" and "yes_no" with -"boolean, and have the "data" pointer point to a "struct -true_false_string" to be used to interpret the value. +g_strescape only takes one parameter in glib 1.x -The NetBIOS-over-TCP/IP Node Type option can now be a regular val_u_byte -value, with the appropriate value_string table. +this makes ethereal compile for those of us that are not on the bleeding edge. +(gtk1 is much better anyway) -Construct the item for DHCP options by initializing it without the value -and appending the value to the item's string with -"proto_item_append_text()". ------------------------------------------------------------------------ -r12390 | guy | 2004-10-25 18:25:59 -0500 (Mon, 25 Oct 2004) | 3 lines +r12784 | jmayer | 2004-12-19 18:00:06 -0600 (Sun, 19 Dec 2004) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-eapol.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ieee80211.h -Make yes_no work in "dissect_netware_ip_suboption()" the way it works -elsewhere, and replace "struct o63_opt_info" with "struct opt_info". +- Diplay SSID in mangemntframes +- Display unprintable characters in SSID as '.' (SSID charaters + are of type octet, not alphanum). ------------------------------------------------------------------------ -r12389 | guy | 2004-10-25 04:31:13 -0500 (Mon, 25 Oct 2004) | 7 lines +r12783 | ulfl | 2004-12-19 11:26:23 -0600 (Sun, 19 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - -"struct o43pxeclient_opt_info" and "struct o43cablelabs_opt_info" look -just like "struct opt_info", except for the name of the "enum -field_type" field; use "opt_info" instead of them. Rename the -equivalent field in "struct o63_opt_info", as well, with an eye towards -changing "struct opt_info" to be able to replace "struct o63_opt_info" -as well. + M /trunk/epan/dissectors/packet-dcerpc-pn-io.c + M /trunk/epan/dissectors/packet-pn-rt.c +removed some gcc warnings (hopefully) ------------------------------------------------------------------------ -r12388 | guy | 2004-10-25 03:56:39 -0500 (Mon, 25 Oct 2004) | 12 lines +r12782 | ulfl | 2004-12-19 10:49:34 -0600 (Sun, 19 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - -Remove val_s_long as it's unimplemented and unused - put it back if it's -ever necessary. - -Make some options, that have only one IPv4 address, use ipv4 rather than -ipv4_list. - -Add val_u_short_list, and have val_u_short accept one and only one -16-bit integer. Give options the appropriate type. - -Shuffle the types a bit in the enum, and shuffle the cases for types -around to match the order in the enum. + M /trunk/epan/dissectors/packet-dcom-remunkn.c + M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-dcom.h +add some IRemUnknown dissectors ------------------------------------------------------------------------ -r12387 | guy | 2004-10-25 03:33:39 -0500 (Mon, 25 Oct 2004) | 7 lines +r12781 | ulfl | 2004-12-19 10:30:25 -0600 (Sun, 19 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - -Rename "ipv4" to "ipv4_list", as it's used for lists of IPv4 addresses, -and add a separate "ipv4"; use that in the dissector for Netware IP -options. - -Add a "presence" option type, for options with no value whose presence -is significant; use that in the dissector for Netware IP options. + M /trunk/epan/dissectors/packet-dcom-oxid.c +tweak some comments ------------------------------------------------------------------------ -r12386 | guy | 2004-10-25 03:17:11 -0500 (Mon, 25 Oct 2004) | 8 lines +r12780 | ulfl | 2004-12-19 10:29:08 -0600 (Sun, 19 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-dcom-remact.c -Pass to the the routines that dissect suboption lists the offset of the -end of the option, and have them do bounds checking. Also, in some -places, check the suboption length. +add dissection of RemoteActivation method +------------------------------------------------------------------------ +r12779 | ulfl | 2004-12-19 10:13:05 -0600 (Sun, 19 Dec 2004) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dcom-oxid.c + M /trunk/epan/dissectors/packet-dcom.c -In "dissect_netware_ip_suboption()", process the suboption length -(which, according to RFC 2242, is present in all suboptions), and use -val_u_byte rather than val_u_short for 1-byte options. +add a lot of dissect stuff to the OXID resolver, moved some details of the DUALSTRINGARRAY to packet-dcom.c +------------------------------------------------------------------------ +r12778 | ulfl | 2004-12-19 10:04:09 -0600 (Sun, 19 Dec 2004) | 1 line +Changed paths: + M /trunk/epan/dissectors/Makefile.common +bugfix: remove empty line, probably caused by eol confusion ------------------------------------------------------------------------ -r12385 | guy | 2004-10-24 17:53:06 -0500 (Sun, 24 Oct 2004) | 6 lines +r12777 | ulfl | 2004-12-19 08:08:03 -0600 (Sun, 19 Dec 2004) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/Makefile.common + D /trunk/epan/dissectors/packet-dcerpc-iremunkn.c + D /trunk/epan/dissectors/packet-dcerpc-iremunkn2.c + D /trunk/epan/dissectors/packet-dcerpc-oxid.c + D /trunk/epan/dissectors/packet-dcerpc-remact.c + D /trunk/epan/dissectors/packet-dcerpc-sysact.c + A /trunk/epan/dissectors/packet-dcom-dispatch.c + A /trunk/epan/dissectors/packet-dcom-oxid.c (from /trunk/epan/dissectors/packet-dcerpc-oxid.c:12776) + A /trunk/epan/dissectors/packet-dcom-remact.c (from /trunk/epan/dissectors/packet-dcerpc-remact.c:12776) + A /trunk/epan/dissectors/packet-dcom-remunkn.c (from /trunk/epan/dissectors/packet-dcerpc-iremunkn.c:12776) + A /trunk/epan/dissectors/packet-dcom-sysact.c (from /trunk/epan/dissectors/packet-dcerpc-sysact.c:12776) -Restructure the DHCP option parsing a bit, to make it a bit clearer - -and fix some bugs that this made a bit more obvious. Add checks of the -option length. +renamed all DCOM related interface dissectors from packet-dcerpc-... to packet_dcom_... and add DCOM IDispatch dissector (incomplete, but better than nothing... ;-) +------------------------------------------------------------------------ +r12776 | ulfl | 2004-12-19 07:46:09 -0600 (Sun, 19 Dec 2004) | 2 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcerpc.h + A /trunk/epan/dissectors/packet-dcom-cba-acco.c + A /trunk/epan/dissectors/packet-dcom-cba.c + A /trunk/epan/dissectors/packet-dcom.c + A /trunk/epan/dissectors/packet-dcom.h -Clean up white space. +(on behalf of the PROFIBUS Nutzerorganisation e.V. Deutschland): +another part of the PROFINET dissectors (PN-CBA, including a lot of generic DCOM dissection) still some work to be done ... +------------------------------------------------------------------------ +r12775 | ulfl | 2004-12-19 04:30:33 -0600 (Sun, 19 Dec 2004) | 1 line +Changed paths: + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-dcerpc-epm.c + D /trunk/epan/dissectors/packet-dcerpc-epm4.c +Merge dissection of EndpointMapper interfaces of version 3 and 4 into one file, as the dissection of both interface versions are (currently) identical. (Jaime, could you please check, if EPM4 dissection is still working well?) ------------------------------------------------------------------------ -r12384 | guy | 2004-10-24 05:30:03 -0500 (Sun, 24 Oct 2004) | 5 lines +r12774 | sahlberg | 2004-12-19 01:18:04 -0600 (Sun, 19 Dec 2004) | 14 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-tcp.c -Don't display the FQDN in the FQDN option if the length of the FQDN is -zero. +add detection to TCP Analysis to detect and flag segments that will completely fill the window advertized from the other side. -Clean up some field names and descriptions. +I.e. when a segment is seen that would (as far as ethereal can tell from the ACKs it has seen in the other direction) fill the window completely. ------------------------------------------------------------------------- -r12383 | guy | 2004-10-24 05:18:16 -0500 (Sun, 24 Oct 2004) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-bootp.c +It is similar to but not exactly the same as the XeroWindow detection since there are many instances where ZeroWindow detection would not work (i.e. an ACK where win==0 since many many situations occur where the window is full but no zerowindowack is ever generated) -Fix the length used for the name in the FQDN option. ------------------------------------------------------------------------- -r12382 | sahlberg | 2004-10-23 22:51:27 -0500 (Sat, 23 Oct 2004) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-ber.c +Someone that has good english could, please, update the Wiki with this option. +It is very very useful to spot performance issues where the tcp window size is too small to accomodate the enmd-to-end latency. -make SEQUENCE OF and CHOICE handle indefinite length encodings ------------------------------------------------------------------------- -r12381 | guy | 2004-10-23 20:29:03 -0500 (Sat, 23 Oct 2004) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-sysact.c -From Yaniv Kaul: name some more interface calls. ------------------------------------------------------------------------ -r12380 | guy | 2004-10-23 04:20:39 -0500 (Sat, 23 Oct 2004) | 3 lines +r12773 | sahlberg | 2004-12-18 22:10:05 -0600 (Sat, 18 Dec 2004) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-aim-buddylist.c - M /trunk/epan/dissectors/packet-aim-chat.c - M /trunk/epan/dissectors/packet-aim-generic.c + M /trunk/epan/dissectors/packet-ldap.c -Remove the include of <epan/prefs.h> from files that don't call any -preference routines. +abort trying to dissect ldap controls if the header doesnt look right. ------------------------------------------------------------------------- -r12379 | guy | 2004-10-23 03:37:21 -0500 (Sat, 23 Oct 2004) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-aim.c +it will not solve the problem in the c06- testmenageri capture that +contains unknown types of ldap commands but it will at least +stop the ldap controls dissector from dumping core. -Put the name, as well as the value, of the family and subfamily fields -into the protocol tree item that contains them. +someone interested in ldap might want to look at those "unknown ldap packets" +in the trace. ------------------------------------------------------------------------- -r12378 | guy | 2004-10-22 13:03:21 -0500 (Fri, 22 Oct 2004) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-ipdc.c -From Josh Bailey: fix the fetch of the IPDC payload length, it's only 10 -bits long. ------------------------------------------------------------------------ -r12377 | guy | 2004-10-22 12:40:58 -0500 (Fri, 22 Oct 2004) | 2 lines +r12772 | jmayer | 2004-12-18 22:04:49 -0600 (Sat, 18 Dec 2004) | 3 lines Changed paths: M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ieee80211.c -Add an item for DNS IPSECKEY RR support for David Fort. +Giles Scott: Port weak key detection from Airsnort ------------------------------------------------------------------------- -r12376 | ulfl | 2004-10-22 03:33:50 -0500 (Fri, 22 Oct 2004) | 1 line -Changed paths: - M /trunk/docbook/eug_src/EUG_app_files.xml -add a section about "Windows folders" ------------------------------------------------------------------------ -r12375 | guy | 2004-10-22 02:07:08 -0500 (Fri, 22 Oct 2004) | 7 lines +r12771 | sahlberg | 2004-12-18 21:30:46 -0600 (Sat, 18 Dec 2004) | 4 lines Changed paths: - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/file_dlg.c + M /trunk/epan/dissectors/packet-smb.c + +mark some fields as GENERATED fields + -Change some code that affects g_resolv_flags to set a flag if the check -box for the flag is active and clear it if it's inactive, rather than -clearing all but RESOLV_CONCURRENT and then setting flags if the check -box is active - or, in one case, not clearing any flags due to a typo -and then setting them, so they never get cleared. This matches what's -done with theresolution flags in some other places. ------------------------------------------------------------------------ -r12374 | guy | 2004-10-22 01:19:00 -0500 (Fri, 22 Oct 2004) | 4 lines +r12770 | sahlberg | 2004-12-18 21:19:53 -0600 (Sat, 18 Dec 2004) | 9 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-sdp.c - M /trunk/epan/dissectors/packet-t38.c - A /trunk/epan/dissectors/packet-t38.h + M /trunk/epan/dissectors/packet-smb.c -From Alejandro Vaquero: start T.38 conversations for SDP sessions. +the mid values in smb are too unreliable for request/response matching since they wrap so quickly. -"T38" -> "T.38" in the T.38 dissector. +This has the effect that if you have a capture file with a hole in it, sa say when snoop or similar stops capturing packets for a while while writing the data to disk you often end up with a packet just after the hole that is a response packet and which ethereal mistakenly matches with a request/response from before the hole. ------------------------------------------------------------------------- -r12373 | guy | 2004-10-22 01:05:03 -0500 (Fri, 22 Oct 2004) | 4 lines -Changed paths: - M /trunk/epan/dissectors/packet-mtp3.c -From Francisco Alcoba: declare the tap data as static, so it's still -there when the tap is called (which happens after dissection is -complete). +now, when the first response is seen to a request remove the entry from the unmatched table so that no other response can match the same request. ------------------------------------------------------------------------- -r12372 | guy | 2004-10-21 21:09:35 -0500 (Thu, 21 Oct 2004) | 3 lines -Changed paths: - M /trunk/doc/Makefile.am -For the .pod->.html rules, find the ".pod" files in $(srcdir), -just as we do for the .pod->.[1-9] rules. ------------------------------------------------------------------------ -r12371 | guy | 2004-10-21 21:05:53 -0500 (Thu, 21 Oct 2004) | 8 lines +r12769 | sahlberg | 2004-12-18 16:09:06 -0600 (Sat, 18 Dec 2004) | 7 lines Changed paths: - M /trunk/epan/dissectors/Makefile.am + M /trunk/epan/dissectors/packet-ndmp.c + +make ndmp use tcp_dissect_pdus() +so that it will track pdu boundaries properly -Include "Makefile.common" in the list of files to put into the -distribution. +not tracking pdu boundaries caused pain since it would miss too many +commands -Don't use ":=" - not all versions of make necessarily support it, and, -even for those that do, it doesn't mean the same thing in all versions -(it means something different in Solaris make than in GNU make, for -example). ------------------------------------------------------------------------ -r12370 | ulfl | 2004-10-21 16:43:37 -0500 (Thu, 21 Oct 2004) | 1 line +r12768 | gerald | 2004-12-17 14:42:35 -0600 (Fri, 17 Dec 2004) | 2 lines Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_advanced.xml + M /trunk/make-version.pl + +Remove debugging output. -cleanup "Packet Reassembling" section ------------------------------------------------------------------------ -r12369 | ulfl | 2004-10-21 16:09:28 -0500 (Thu, 21 Oct 2004) | 1 line +r12767 | gerald | 2004-12-17 14:41:14 -0600 (Fri, 17 Dec 2004) | 2 lines Changed paths: - M /trunk/docbook/eug_src/EUG_app_protocols.xml - D /trunk/docbook/protocols.xml - M /trunk/docbook/user-guide.xml + M /trunk/make-version.pl + +Work around a bug in the strftime() code in the Windows version of Perl. -removed the protocols list completely, as I don't want to update it to the current Ethereal features all the time and we also have a really good online version of that list available. ------------------------------------------------------------------------ -r12368 | ulfl | 2004-10-21 15:22:21 -0500 (Thu, 21 Oct 2004) | 1 line +r12766 | guy | 2004-12-17 13:27:46 -0600 (Fri, 17 Dec 2004) | 3 lines Changed paths: - M /trunk/docbook/eug_src/EUG_app_files.xml + M /trunk/epan/dissectors/packet-lmp.c + +When the LMP dissector rejects a packet because it {is, isn't} UDP, let +some other dissector have it. -add info about temporary capture files and a section about "Windows NT/2000/XP roaming profiles" ------------------------------------------------------------------------ -r12367 | guy | 2004-10-21 14:12:22 -0500 (Thu, 21 Oct 2004) | 4 lines +r12765 | guy | 2004-12-17 13:14:24 -0600 (Fri, 17 Dec 2004) | 2 lines Changed paths: - M /trunk/gtk/capture_dlg.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ldap.c -The top-level window's list of capture filter expressions might not yet -exist if no filters have been remembered; don't set the popdown string -list for the filter combo box if the list is empty. +From Stefan Metzmacher: basic decoding for LDAP Controls. ------------------------------------------------------------------------ -r12363 | gerald | 2004-10-20 21:06:37 -0500 (Wed, 20 Oct 2004) | 7 lines +r12764 | guy | 2004-12-17 04:09:32 -0600 (Fri, 17 Dec 2004) | 3 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi - M /trunk/plugins/opsi/packet-opsi.c - M /trunk/plugins/opsi/packet-opsi.h - -From Laurent Rabret: + M /trunk/gtk/main.c -- enable Windows' ShellExecute command to call Ethereal without specifying - the installation path (a new key added in the registry) -- decode 2 more options in the OPSI plugin. +Don't start up a splash screen if "-G" is specified, even if we weren't +configured with libpcap support. +------------------------------------------------------------------------ +r12763 | lroland | 2004-12-16 13:36:23 -0600 (Thu, 16 Dec 2004) | 8 lines +Changed paths: + M /trunk/plugins/mate/Makefile.am + M /trunk/plugins/mate/Makefile.nmake + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/matelib/isup.mate + M /trunk/plugins/mate/packet-mate.c +Patch for Mate Plugin. +From Luis Ontanon: +- moves mate configuration from proto_register to proto_register_handoff +- add the config file protocol preference +- every item (gop,gog,pdu) has it's own ett +- the tap doesn't do nothing, it just primes the tree +- analyze_frame() what once was the tap now is called by the dissector +- should work with tethereal now (to be tested) ------------------------------------------------------------------------ -r12362 | guy | 2004-10-20 18:38:31 -0500 (Wed, 20 Oct 2004) | 11 lines +r12762 | gerald | 2004-12-16 13:06:52 -0600 (Thu, 16 Dec 2004) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-rpc.c + M /trunk/make-version.pl -At least some versions of the OS X NFS client (and possibly some if not -all other BSD NFS clients) retransmit on different ports from the port -on which the original request was set, so have the RPC "conversation" -for connectionless protocols use only the source address and destination -port. +From Thomas Boehne: Fix the version.conf status message and improve code +readability. -Use NO_ADDR_B and NO_PORT_B when looking up the conversation in those -cases, and use NO_ADDR2 and NO_PORT2 when creating the conversation in -those cases, to make it clearer that we're only using one address and -port. +Fix a bug in my previous checkin, so that svnversion.h will be created +even when the ".svn/" directory isn't present. ------------------------------------------------------------------------ -r12361 | gerald | 2004-10-20 14:14:51 -0500 (Wed, 20 Oct 2004) | 2 lines +r12761 | guy | 2004-12-15 11:50:11 -0600 (Wed, 15 Dec 2004) | 4 lines Changed paths: - M /trunk/ChangeLog - M /trunk/NEWS + M /trunk/epan/dissectors/packet-http.c + +From Yaniv Kaul: add the CCM_POST method. -Pull in versions from the 0.10.7 branch. +Tweak indentation. ------------------------------------------------------------------------ |