aboutsummaryrefslogtreecommitdiffstats
path: root/ChangeLog
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2014-12-10 09:30:32 -0800
committerGerald Combs <gerald@wireshark.org>2014-12-10 17:36:42 +0000
commit4c229ca40dcc0a75b356282e7e9dabd90fa7f1e3 (patch)
treebc6f726584523e5aa7c4e92cd0c2369bbbd22937 /ChangeLog
parenta97176853010e5e39492d8a1fea79799ef43758b (diff)
Build 1.99.1.
Change-Id: Ic6dcbfc880817ad4bcc07a21ec88d14c8c92df58 Reviewed-on: https://code.wireshark.org/review/5703 Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog30569
1 files changed, 7454 insertions, 23115 deletions
diff --git a/ChangeLog b/ChangeLog
index 31584e3941..a1bfdcf073 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,27234 +1,11573 @@
-commit 15e89ec
-Author: Richard Sharpe <realrichardsharpe@gmail.com>
-Date: Sat Oct 4 16:11:43 2014 -0700
-
- Dissect an SVHDX Open Device Context that appears as an Extra Create Parameter
- in a CREATE request. This helps understand HyperV over SMB 3.x stuff.
-
- Bug: 10527
- Change-Id: I1e206ed38e12fed419b1ac4a0793b91f9308f364
- Signed-off-by: Richard Sharpe <rsharpe@samba.org>
- Reviewed-on: https://code.wireshark.org/review/4477
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 4611b8d
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Tue Oct 7 01:05:17 2014 -0700
-
- Make the code a bit more like the pre-API change code.
-
- Change-Id: I9a8bd2c7ce97993c1b72caf63254d024950f8b94
- Reviewed-on: https://code.wireshark.org/review/4520
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 8439fd5
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Sat Oct 4 19:07:58 2014 +0200
-
- - Handle strings that have an opening but no closing quote
-
- fixes the endless loop reported in
-
- Bug: 10521
-
- - Fix a typo.
- Change-Id: I17b4a15e780d1d6122841a308348518063f82a59
- Reviewed-on: https://code.wireshark.org/review/4467
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 05d34b3
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Tue Oct 7 00:39:54 2014 -0700
-
- Clean up white space.
-
- Change-Id: I73f2406483c13c7917faed46db6fc1f5e2bc8fcd
- Reviewed-on: https://code.wireshark.org/review/4517
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 3f101f2
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Tue Oct 7 00:30:35 2014 -0700
-
- Fix a comment, clean up some whitespace.
-
- Change-Id: I5d3d518eee2d61dd896b44c2a61d66057f3c2f7f
- Reviewed-on: https://code.wireshark.org/review/4516
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 04bca65
-Author: Anish Bhatt <anish@chelsio.com>
-Date: Mon Oct 6 23:27:15 2014 -0700
-
- [bacnet] update vendor list
-
- Change-Id: I6b7bd3b3a110b8d393cd849c12890fff17446e54
- Reviewed-on: https://code.wireshark.org/review/4515
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit ffd48ce
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Oct 6 22:01:12 2014 -0700
-
- Whitespace cleanups.
-
- Change-Id: I92f983b2e04defab30eb31c14c484b9f0f582413
- Reviewed-on: https://code.wireshark.org/review/4513
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 683d657
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Oct 5 19:27:15 2014 +0200
-
- PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer
-
- packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined
- packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined
- packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined
- packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined
- packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value
- packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized]
-
- Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f
- Reviewed-on: https://code.wireshark.org/review/4478
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit de13887
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Oct 5 12:59:11 2014 +0200
-
- idl2wrs (DCERPC DRSUAPI): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Add a check if the struct is not empty
-
- budb and butc are also regenerate but no change
-
- Change-Id: I0d8cfc827f5451f1cdbd924628a263af9d483a7b
- Reviewed-on: https://code.wireshark.org/review/4473
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 670ebda
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Oct 6 18:00:57 2014 -0700
-
- Add some higher-level file-read APIs and use them.
-
- Add wtap_read_bytes(), which takes a FILE_T, a pointer, a byte count, an
- error number pointer, and an error string pointer as arguments, and that
- treats a short read of any sort, including a read that returns 0 bytes,
- as a WTAP_ERR_SHORT_READ error, and that returns the error number and
- string through its last two arguments.
-
- Add wtap_read_bytes_or_eof(), which is similar, but that treats a read
- that returns 0 bytes as an EOF, supplying an error number of 0 as an EOF
- indication.
-
- Use those in file readers; that simplifies the code and makes it less
- likely that somebody will fail to supply the error number and error
- string on a file read error.
-
- Change-Id: Ia5dba2a6f81151e87b614461349d611cffc16210
- Reviewed-on: https://code.wireshark.org/review/4512
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 6397ad4
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Oct 6 16:02:16 2014 -0700
-
- Revert "Qt: Try to fix a Visual C++ encoding warning."
-
- Revert gafa8c02 since it didn't work on Windows. Use a pragma to squelch
- Visual C++ instead.
-
- Qt's rich text renderer doesn't handle "&apos;". Replace it with "&#x27;".
- Remove a QDebug include.
-
- Change-Id: I0e6308efda74a4bc0e67ce841a50a0a9b68f4a8b
- Reviewed-on: https://code.wireshark.org/review/4511
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit a17067a
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Oct 6 15:33:50 2014 -0700
-
- Qt: Rename the "check for updates" slot.
-
- The "Check for Updates..." action doesn't exist when
- QMetaObject::connectSlotsByName is called. Rename
- on_actionHelpCheckForUpdates_triggered to checkForUpdates so that we
- don't get the warning
-
- QMetaObject::connectSlotsByName: No matching signal for on_actionHelpCheckForUpdates_triggered()
-
- at startup.
-
- Change-Id: Icbd7eb98731023c323212e6ec3d3c98f1321e245
- Reviewed-on: https://code.wireshark.org/review/4510
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 0644b34
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Oct 7 00:03:56 2014 +0200
-
- after an lupdate, I should also do an lrelease to keep the .ts file and
- the .qm file in sync
-
- Change-Id: I588f5ff7386bac13c8ce0bba82fee4807c490682
- Reviewed-on: https://code.wireshark.org/review/4509
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit b80d330
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Mon Oct 6 23:54:45 2014 +0200
-
- lupdate for Japanese
-
- Change-Id: Ifa7af35cfc18f85cd547aa7621c5ca7305a9242d
- Reviewed-on: https://code.wireshark.org/review/4508
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 02e902f
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Mon Oct 6 23:24:06 2014 +0200
-
- From 竹下 恵 (Megumi Takeshita)
-
- another update of the Japanese translation
- the translation is fairly complete now, only some recently added items
- are missing
-
- Change-Id: Iacd4ee2da7a83681b6119c5d02a40156b441065b
- Reviewed-on: https://code.wireshark.org/review/4507
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 25683ca
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Oct 6 14:44:17 2014 -0700
-
- Qt: QVector::length was added in Qt 5.2.
-
- Use ::count instead.
-
- Change-Id: Ic890ed8061b7e92eea65c3102de5219e5ac97a93
- Reviewed-on: https://code.wireshark.org/review/4505
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit cf201b0
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:39:12 2014 +0200
+commit a971768
+Author: Michael Mann <mmann78@netscape.net>
+Date: Mon Dec 8 21:40:24 2014 -0500
- UI (simple_dialog): fix warning: redundant redeclaration of .. [-Wredundant-decls]
+ Refactor "color" conversation filters
- simple_dialog.h:78:13: warning: redundant redeclaration of ‘simple_message_box’ [-Wredundant-decls]
- simple_dialog.h:85:13: warning: redundant redeclaration of ‘vsimple_error_message_box’ [-Wredundant-decls]
- simple_dialog.h:90:13: warning: redundant redeclaration of ‘simple_error_message_box’ [-Wredundant-decls]
+ Have dissectors register their desire to be part of "color" conversation filters and have the GUI use that registered list. GUI actually using API will come in a separate commit.
- Change-Id: I8f6363fc8ec46ba24895e5236368544f64354e42
- Reviewed-on: https://code.wireshark.org/review/4460
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I5ffe922d97894fe7bf3182056b76ab5839a9461a
+ Reviewed-on: https://code.wireshark.org/review/5658
Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 798eb97
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Oct 5 12:23:33 2014 -0700
-
- Qt: Packet list column sorting.
-
- Sorting behavior should be identical to GTK+.
-
- Pass the correct position to beginInsertRows. Add a list of to-do items
- to packet_list.cpp.
-
- Change-Id: Ie6ab4b9f2d780a2af430d0f90529edca5485dada
- Reviewed-on: https://code.wireshark.org/review/4481
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 5051ae1
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 14:03:47 2014 -0400
-
- Convert "4 space tabs" to spaces; Adjust editor modelines.
-
- Change-Id: I8d61d959c79e6aa9875c58680c54a331d18079cc
- Reviewed-on: https://code.wireshark.org/review/4504
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 24d50bc
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 12:55:18 2014 -0400
-
- Adjust indentation to match editor modelines; Do other minor whitespace changes.
-
- Change-Id: Ic020b2c92db5d14a2be9dc4d35aef4514b8b0353
- Reviewed-on: https://code.wireshark.org/review/4502
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit c822eea
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 12:51:29 2014 -0400
-
- packet-rpcap.c: Don't use mixed space/tab indentation;
-
- Change-Id: I21409a02fabc28951d9c15be7a160295f5fb35ca
- Reviewed-on: https://code.wireshark.org/review/4501
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 2d6621a
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 12:46:31 2014 -0400
-
- Adjust editor modelines to match actual format of the file; Adjust some whiotespace.
-
- Change-Id: If930f2c266b61c9348063eab0189af2582b0a331
- Reviewed-on: https://code.wireshark.org/review/4500
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 2005fc6
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 12:42:42 2014 -0400
-
- Convert (what appear to be) "4 space tabs"; Adjust editor-modelines; Do some minor reformatting.
-
- Change-Id: Ie078c826ed38a0d682f61fb3e95450b47a9d2c31
- Reviewed-on: https://code.wireshark.org/review/4499
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 3377eca
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 12:24:01 2014 -0400
-
- packet-g723.c: Remove some boilerplate comments.
-
- Change-Id: Ib322b33c304674835170e1ae2006aabf0f44fd9d
- Reviewed-on: https://code.wireshark.org/review/4498
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 3af9e33
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 12:21:48 2014 -0400
-
- packet-hclnfsd.c: Reformat hf[] entries; Adjust some whitespace.
-
- Change-Id: I84368080d12cb5001dd7847add0ec96608080604
- Reviewed-on: https://code.wireshark.org/review/4497
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 97e6c59
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Oct 6 12:16:15 2014 -0400
-
- packet-q931.c: Reformat hf[] entries; Convert apparent "4-space tabs" to spaces. Adjust editor modelines.
-
- Change-Id: Iaeb321f0facfc6b3176677779e6cdf5c92226dec
- Reviewed-on: https://code.wireshark.org/review/4496
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 4d93072
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Oct 6 16:11:14 2014 +0200
-
- Dissect 3GPP AVP Presence-Reporting-Area-Elements-List.
-
- Change-Id: Ic7b99d41a275fb6f50758ea87763844f24be537c
- Reviewed-on: https://code.wireshark.org/review/4495
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 9128e43
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Oct 5 21:25:19 2014 -0400
-
- tcp: default no-subdissector-on-error to TRUE
-
- Dissectors that need this set break badly when it isn't. Dissectors which don't
- need this set will still generally be understandable without it, since e.g.
- retransmissions will link to the original packet at the TCP layer, and
- presumably the subdissector payload is exactly the same in that case.
-
- Change-Id: I2871c2a90c601637bdfb8cffaa34a7407995c603
- Ping-Bug: 10525
- Ping-Bug: 10289
- Reviewed-on: https://code.wireshark.org/review/4487
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 47de5a1
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Oct 6 14:06:01 2014 +0200
-
- Expand dissection of 8.108 Presence Reporting Area Action.
-
- Change-Id: I2ad57d8cdb6758f01146b37ac924e2d8f2141546
- Reviewed-on: https://code.wireshark.org/review/4491
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 9c1225f
-Author: Tomasz Moń <desowin@gmail.com>
-Date: Fri Sep 19 19:34:07 2014 +0200
-
- Modify multicheck to accept parent parameter.
-
- This makes it possible for multicheck to become a tree-like structure.
-
- Example:
- arg {number=4}{call=--devices}{display=Devices}{tooltip=Device selector}{type=multicheck}
- value {arg=4}{value=dev1}{display=Parent Device}{enabled=t}{default=t}
- value {arg=4}{value=dev2}{display=Child Device}{parent=dev1}{enabled=t}
- value {arg=4}{value=dev3}{display=Another Parent Device}{enabled=t}
- value {arg=4}{value=dev4}{display=Non-clickable Child Device}{parent=dev3}
- value {arg=4}{value=dev5}{display=Non-clickable Child of Child}{parent=dev4}
-
- Change-Id: I59dd7208ca0ec90cccfc49ae049559cdc6c69a4b
- Reviewed-on: https://code.wireshark.org/review/4192
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Roland Knall <rknall@gmail.com>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 0784451
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Oct 5 23:40:42 2014 -0400
-
- Adjust some whitespace to match editor modelines.
-
- Change-Id: I9fda7de49255857cc1cf270d6202c85573d91674
- Reviewed-on: https://code.wireshark.org/review/4490
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 07698d5
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Oct 5 22:14:57 2014 -0400
-
- Adjust some whitespace to match editor modelines.
-
- Change-Id: Ia22cac3ebd7a454c156f98d967e6fd61f708a2b3
- Reviewed-on: https://code.wireshark.org/review/4489
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 0111e46
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Oct 5 21:34:19 2014 -0400
-
- plugins: Add editor modelines; Adjust whitespace as needed.
-
- Change-Id: I36124f6021d46a228721bdc976f6b9fef1c8c088
- Reviewed-on: https://code.wireshark.org/review/4488
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 9e776a1
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Sun Oct 5 12:18:49 2014 +0200
-
- mpeg-pes: don't modify source and destination address colums
-
- the mpeg-pes dissector replaced source or destination address with
- decoding timestamp, presentation timestamp or pack data rate
- these values don't belong into address columns and erase the IP
- addresses when mpeg-pes is transmitted over IP
-
- the timestamps etc can be displayed in a user-defined column if required
-
- this patch is part of
- Bug: 10505
-
- Change-Id: I1bf561648f848eb18818862edd138724abfc8e88
- Reviewed-on: https://code.wireshark.org/review/4472
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit ad6134b
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Oct 5 16:12:34 2014 -0400
-
- docsis: Add editor modelines; Adjust whitespace; Remove boilerplate comments.
-
- Change-Id: I78f9815616f4fc3c14204339c5826f0ca7d0680e
- Reviewed-on: https://code.wireshark.org/review/4485
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 0b18d6c
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Oct 5 15:57:05 2014 -0400
-
- Add editor modelines; Adjust whitespace as needed.
-
- Change-Id: I6e70c933ae61a97377235d67b2f6a1b3d67dc155
- Reviewed-on: https://code.wireshark.org/review/4484
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit e2bdfa1
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Oct 5 15:54:49 2014 -0400
-
- Reformat hfi entries; Add editor modelines; Adjust whitespace.
-
- Change-Id: Iead53f92cc847d04c32f4a307d45f9748c49a69c
- Reviewed-on: https://code.wireshark.org/review/4483
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 1e1d1de
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Oct 5 15:51:54 2014 -0400
-
- packet-igap.c: Reformat hf[] entries; Add editor modelines.
-
- Change-Id: I0ac4f2eb7f2b93aab864c6f43dee057774048165
- Reviewed-on: https://code.wireshark.org/review/4482
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 560e06d
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Oct 5 11:46:43 2014 -0700
-
- Read the record length in common code.
-
- Instead of reading the 16-byte blob and record length at the same time,
- just read the 16-byte blob, and then fall through to the record-length
- reading code.
-
- Change-Id: Ib2819a2d654e2670233821882bac79d7cd656b12
- Reviewed-on: https://code.wireshark.org/review/4480
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 66d9ca3
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Oct 5 08:06:06 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-10-05]
-
- Change-Id: Ib90638f6382b2112f0f49a2d8f5d2d10b4d3c520
- Reviewed-on: https://code.wireshark.org/review/4474
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit dbcd94d
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sat Oct 4 21:52:50 2014 +0200
+commit e050ad2
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Dec 6 15:39:26 2014 -0500
- DLT User: add ability to export PDUs
-
- It can be really useful to share hand crafted captures without the need to configure the DLT User table
+ Eliminate some proto_tree_add_text in packet-bgp.c
- Change-Id: Iefab00b741f95b1f3a3247cb28ed01a367fa4ff4
- Reviewed-on: https://code.wireshark.org/review/4469
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Change-Id: I05fabe9786125e2167fe4010733f61000d0e7914
+ Reviewed-on: https://code.wireshark.org/review/5670
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Matthieu Texier <matthieu@texier.tv>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit e731bc7
+commit d4476b1
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Oct 4 22:42:35 2014 -0700
+Date: Wed Dec 10 00:39:13 2014 -0800
- Fix a comment.
+ Expose find_heur_dissector_list().
- Change-Id: I875888753859488ed810cedb5656bd870bee7122
- Reviewed-on: https://code.wireshark.org/review/4471
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit e7dcf1b
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Oct 4 22:18:27 2014 -0700
-
- Improve comments, and add some #defines, to make it clearer what the code does.
+ We already have find_dissector_table(); expose
+ find_heur_dissector_list() as well, so that heuristic dissector lists
+ can be shared.
- Change-Id: I2cd8973bdce171053664cf4ed06a37bdd9b30353
- Reviewed-on: https://code.wireshark.org/review/4470
+ Change-Id: I3f50413b8b10fd3129fcdc2344cb1447f0946ce9
+ Reviewed-on: https://code.wireshark.org/review/5701
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit a13a2e6
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 18:40:18 2014 +0200
-
- DSR: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: Ifd694dc9a72cde787c00820ec5a02cc33d5157e0
- Reviewed-on: https://code.wireshark.org/review/4466
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 5377dee
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 18:35:10 2014 +0200
+commit bd8d2f5
+Author: Sergey Avseyev <sergey.avseyev@gmail.com>
+Date: Wed Dec 10 04:19:55 2014 +0300
- LLDP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
+ packet-couchbase.c: dissect more DCP commands
- Change-Id: I616e57c84c5721213ee12a41b63595547ab15f72
- Reviewed-on: https://code.wireshark.org/review/4465
+ Change-Id: I0e06c89cdda3c1f8e98412fd20737ff6afd26666
+ Reviewed-on: https://code.wireshark.org/review/5694
+ Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 249d075
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 18:34:57 2014 +0200
-
- EPL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: I88b90302df0202d38b7c089cf243e7860766e653
- Reviewed-on: https://code.wireshark.org/review/4464
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 973e09c
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 18:00:30 2014 +0200
-
- GSM-SMS: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: If0700726bf9a7359313d0cb69d959471c0ea9580
- Reviewed-on: https://code.wireshark.org/review/4463
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 8e17277
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:55:42 2014 +0200
-
- Juniper: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: I9178a3de683dda661ed68ef6d743036a9f8aa39e
- Reviewed-on: https://code.wireshark.org/review/4462
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 4d62642
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:55:23 2014 +0200
-
- RSVP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: Iccfeaa514cd60f02bb37e210c5f714bcb616521b
- Reviewed-on: https://code.wireshark.org/review/4461
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 3d7e5a6
-Author: Michael Mann <mmann78@netscape.net>
-Date: Sat Oct 4 13:50:42 2014 -0400
-
- Eliminate proto_tree_add_text from packet-gsm_a_bssmap.c
-
- Also remove other_decode_bitfield_value calls.
-
- Change-Id: I056fe74fbd547b690cd5ed60e3e8777df9474704
- Reviewed-on: https://code.wireshark.org/review/4468
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit fa5b76f
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:27:47 2014 +0200
-
- GTK (hostlist_table) fix indent (use 4 spaces) and modelines info
-
- Change-Id: I072de752df0c0e41be663889dafd0f5860a29c37
- Reviewed-on: https://code.wireshark.org/review/4458
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 6d44552
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:22:54 2014 +0200
-
- GTK (hostlist_table) warning: comma at end of enumerator list [-Wpedantic]
-
- Change-Id: I83e930b3179ce954fa4c09d1f46cc833517aa1f6
- Reviewed-on: https://code.wireshark.org/review/4457
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 75727dc
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:21:53 2014 +0200
-
- Qt (manage interface): fix warning: comma at end of enumerator list [-Wpedantic]
-
- Change-Id: I728a50e47fd0d8eea77bc1cdebe2a155184ea953
- Reviewed-on: https://code.wireshark.org/review/4456
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit acc19b7
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:11:18 2014 +0200
-
- extcap: warning: no previous prototype for ‘extcap_free_arglist’ [-Wmissing-prototypes]
-
- Remove extcap_free_arglist (never used)
-
- Change-Id: I1f751512be627380a992db63c3e4abd22b3aa486
- Reviewed-on: https://code.wireshark.org/review/4455
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit bedad69
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 17:05:38 2014 +0200
-
- CEPH: Fix comma at end of enumerator list [-Wpedantic]
-
- Change-Id: I0c04a3d217e75986878b276a1ac82b427de38384
- Reviewed-on: https://code.wireshark.org/review/4454
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit ab6f954
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 16:59:42 2014 +0200
+commit c46fa33
+Author: Sergey Avseyev <sergey.avseyev@gmail.com>
+Date: Thu Dec 4 13:22:22 2014 +0300
- DCERPC (butc): fix warning: no previous prototype for ... [-Wmissing-prototypes]
+ Riemann protocol dissector
- Fix a typo in last patch and regenerate file
+ Homepage: http://riemann.io/
- Change-Id: Id9083edd797af97d72a872187a0d0b5750e04547
- Reviewed-on: https://code.wireshark.org/review/4453
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit f1ba16a
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Oct 4 16:49:49 2014 +0200
-
- CP2179: Fix warning: no previous prototype for proto_register_cp2179 [-Wmissing-prototypes]
+ Sample capture:
+ http://files.avsej.net/riemann-sample.pcapng
- Move on top also prototype of proto_reg_handoff_cp2179
+ Protocol definition:
+ https://github.com/aphyr/riemann-java-client/blob/master/src/main/proto/riemann/proto.proto
- Change-Id: I00f23a88606426acd17d63104630a885682d3c02
- Reviewed-on: https://code.wireshark.org/review/4452
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit ebfe8f6
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sat Oct 4 11:28:35 2014 -0400
-
- Add editor modelines; Reformat as appropriate.
+ Implementor's guide:
+ http://riemann.io/howto.html#write-a-client
- Change-Id: I8e9c58b75eea85877d22024201e5d8d0e9a3dbfd
- Reviewed-on: https://code.wireshark.org/review/4459
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 2079592
-Author: Tomasz Moń <desowin@gmail.com>
-Date: Fri Oct 3 19:27:04 2014 +0200
-
- Update capture_opts in extcap_cleanup().
-
- This fixes redundant extcap_pid handle close that could occur in
- capture_opts_del_iface() which resulted in unhandled exception on
- Windows.
-
- Change-Id: I06b680fcb65cd6fd854a25fb1b01248dce3251a1
- Reviewed-on: https://code.wireshark.org/review/4447
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Roland Knall <rknall@gmail.com>
+ Bug: 10758
+ Change-Id: I28634453423127fe647eb92e48072a90a7f5d232
+ Reviewed-on: https://code.wireshark.org/review/5620
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 06926ae
-Author: Tomasz Moń <desowin@gmail.com>
-Date: Thu Oct 2 18:35:07 2014 +0200
+commit 1f8b16e
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Wed Dec 10 07:41:23 2014 +0100
- Wait for extcap to connect to pipe on Windows.
-
- This prevents dumpcap from failing with timeout exceeded error message
- with some extcaps (especially those that display UAC screen) by making
- sure that extcap connects to pipe before dumpcap is even started.
+ ICQ: fix icq.meta_user.found_authorization field registration
- Change-Id: I549da9217c7f4ae89509330ca4fa613a119a9523
- Reviewed-on: https://code.wireshark.org/review/4428
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Roland Knall <rknall@gmail.com>
+ Change-Id: I8c39073b8d1237f8af7f7061f331b3d59ae81142
+ Reviewed-on: https://code.wireshark.org/review/5699
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit a7d6321
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Oct 3 19:59:15 2014 -0700
-
- Use some macros to clean up the Snifer decompression code.
-
- For code that's used in more than one place, use macros. This combines
- a bunch of checks into the output macros.
-
- Change-Id: Ic32dce75e1c531fd28bfed180856e230277bfe58
- Reviewed-on: https://code.wireshark.org/review/4451
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit a6988b4
-Author: Tomasz Moń <desowin@gmail.com>
-Date: Fri Oct 3 19:01:46 2014 +0200
+commit f64f7c6
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Wed Dec 10 07:37:23 2014 +0100
- Fix memory leak and heap corruption on Windows.
+ NFS: do not duplicate field name in blurb
- LPSECURITY_ATTRIBUTES is type definition for pointer to SECURITY_ATTRIBUTES
- structure.
-
- Change-Id: I94a835bfd8f7eb76c808fac8286ca3f2db9b19c3
- Reviewed-on: https://code.wireshark.org/review/4449
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Change-Id: I565823e2ba3c712506710f911e118cd48c895523
+ Reviewed-on: https://code.wireshark.org/review/5698
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit 8b7d27c
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Oct 3 08:53:16 2014 -0700
-
- WSDG: Update the Windows Qt download text.
-
- Change-Id: I6fd027ff76b5b463f33992898965a3e037778071
- Reviewed-on: https://code.wireshark.org/review/4443
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit bb5daa6
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Oct 3 10:13:07 2014 -0400
-
- Add editor modelines; Adjust whitespace as needed.
-
- Change-Id: I391cdf80a6e4ae5b0f4068e0500a90d013588f8a
- Reviewed-on: https://code.wireshark.org/review/4442
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 451de17
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Oct 3 10:09:34 2014 -0400
-
- packet-aim-messaging.c: Add editor modelines; reformat various (including hf[] entries).
-
- Change-Id: Ie5973a717a80ba75b82e817cb9e30c3529afbb0c
- Reviewed-on: https://code.wireshark.org/review/4441
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit b15914f
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Oct 3 09:04:57 2014 -0400
-
- packet-dcerpc-fileexp.c: Add editor modelines; reformat various (including hf[] entries).
-
- Change-Id: I0d49f4c1c3a3960c3fdc9b1cd411c73097829c09
- Reviewed-on: https://code.wireshark.org/review/4440
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 956cfa2
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Fri Oct 3 15:18:44 2014 +0200
-
- LocationNumber digits is off by one(to many).
- Bug 10522.
-
- Change-Id: I7887f3ee229ac22d2aa37a3d8900d76d8b814ed0
- Reviewed-on: https://code.wireshark.org/review/4439
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 6621b1f
+commit 4af7482
Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Oct 2 21:04:55 2014 -0400
+Date: Sat Dec 6 12:57:33 2014 -0500
- Create field filters for gsm_rr_csn_HL_flag() usages.
+ Eliminate proto_tree_add_text from packet-icq.c
- Change-Id: I74f110b477a3bf7e0c374db3147604d50018deba
- Reviewed-on: https://code.wireshark.org/review/4435
+ Change-Id: I2f4bcd8c4a6cf534bb5b6b5c5aa7e21075968ee3
+ Reviewed-on: https://code.wireshark.org/review/5696
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit bdfff4d
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Oct 2 17:02:13 2014 -0700
-
- Re-enable the Wireshark test suite.
-
- Change-Id: Icfd9edb8c6ef7620878bc9d60c8dcc569ad2abad
- Reviewed-on: https://code.wireshark.org/review/4434
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 242a1e5
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Oct 1 17:18:31 2014 -0700
-
- CMake: Don't assume we have a "cat" command.
-
- Use "copy /B" on Windows to create wireshark.pod, similar to
- doc/Makefile.nmake.
-
- Change-Id: I454afca0bd3497cca795ca18256dd7c4e2f224d4
- Reviewed-on: https://code.wireshark.org/review/4415
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit ff7b51f
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Oct 2 13:59:16 2014 -0700
-
- Partially re-enable Wireshark tests.
-
- Qt requires Xrender and XKEYBOARD. Unfortunately the Ubuntu and Solaris
- buildbots run the test script under Xtightvnc, which provides neither of
- those. Only enable the tests on Windows and OS X for now.
-
- Change-Id: I84bc28f810782b862b4dca8fc8df088a4919066d
- Reviewed-on: https://code.wireshark.org/review/4430
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 482e8e5
+commit c449b43
Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Oct 2 17:47:19 2014 -0400
+Date: Tue Dec 9 23:48:46 2014 -0500
- Add editor modelines & adjust indentation/whitespace as needed.
+ nfs: expert...() shouldn't be called under 'if(tree)'
- Change-Id: Ice2d93632cd42dfcef3bfbf0e15f2a8a147278fc
- Reviewed-on: https://code.wireshark.org/review/4433
+ Change-Id: I4f8c55ea4194d1246ea19368e0f5890ad1248f47
+ Reviewed-on: https://code.wireshark.org/review/5697
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 70abd39
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Oct 2 17:43:54 2014 -0400
+commit dff05c9
+Author: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
+Date: Sun Nov 9 10:58:43 2014 +0100
- Reformat hf[] entries; Add editor modelines & adjust whitespace.
+ nfs: decode dCache NFS file handle
- Change-Id: I30b25db89d3fbae5f3913ede8bf7bd66fd2516da
- Reviewed-on: https://code.wireshark.org/review/4432
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 0299aa3
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Oct 2 17:26:35 2014 -0400
-
- packet-nfs.c: (trivial) Add dropped/missing newline; Adjust some whitespace.
+ add support for dCache NFS/pNFS
+ project page: http://www.dcache.org
- Change-Id: I2ef3af42a712ced6917d94e1dcf708b3f34d7e82
- Reviewed-on: https://code.wireshark.org/review/4431
+ Bug: 10765
+ Change-Id: I24a88419ec070305e609d1b49b44994a464eb098
+ Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
+ Reviewed-on: https://code.wireshark.org/review/5236
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 043e6f0
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Oct 2 14:15:05 2014 -0700
-
- Fix the release notes.
-
- The Bug Fixes section is empty, which creates an empty Docbook section,
- which isn't allowed. Comment out its header for now.
-
- AsciiDoc interprets single quoted text as emphasized, which probably
- isn't what was intended. Use curly quote markup instead.
-
- Add a link to the AsciiDoc cheat sheet.
-
- Change-Id: Ib9746ea714f90a28a2f1204e97e9e185aaef3df6
- Reviewed-on: https://code.wireshark.org/review/4429
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 5262591
-Author: Lukas Emersberger <lukas.emersberger@br-automation.com>
-Date: Mon Sep 22 14:43:02 2014 +0200
+commit 8375a66
+Author: J. Bruce Fields <bfields@redhat.com>
+Date: Thu Oct 30 14:53:07 2014 -0400
- epl: FIX PDO_Mapping
+ nfs: fix failure to parse EXCHANGE_ID arguments
- The subindex of the R/TPDO frames was interpreted false.
- Now the subindex is correctly interpreted.
+ The exchange_id spo_must_enforce/spo_must_allow bitmaps are exceeding
+ this arbitrary MAX_BITMAPS constant, causing EXCHANGE_ID parsing to
+ fail.
- ASend SDO Write Multiple Parameter by Index interpreted
- the mapping data false.
+ Even in the case of attributes we may need more than 4 words soon, even
+ if we don't I'm not sure if it's actually illegal to zero-pad them out
+ to something longer, and even if that is illegal I don't think it's
+ really helpful of wireshark to stop parsing.
- Change-Id: Icfb1896e96f5486c5479c1dd060eb1032695f9f6
- Reviewed-on: https://code.wireshark.org/review/4397
- Reviewed-by: Lukas Emersberger <lukas.emersberger@gmail.com>
- Reviewed-by: Roland Knall <rknall@gmail.com>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 617b826
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Oct 1 13:23:52 2014 +0200
-
- Upgrade GnuTLS 3.2.15 / Gcrypt 1.6.2 package
-
- We bundle a recompiled libcrypt library without AES-NI support so as to workaround a memory corruption seen when configuring AES keys
-
- Bug: 10476
- Change-Id: I7735343530ec90b7b67ece4c6eb5b4bf1ddb857e
- Reviewed-on: https://code.wireshark.org/review/4401
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 5c8457e
-Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Oct 2 11:18:00 2014 -0400
-
- Create field filters for gsm_rr_csn_flag() usages.
+ Keep the constant just as a sanity check but make it really large.
- Change-Id: I77b0c33c054397666f978a9ae175fa386cb87b59
- Reviewed-on: https://code.wireshark.org/review/4419
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Ping-Bug: 10649
+ Change-Id: I3dff3ebde2d7f74f8cbe60a92c853463da66ae6a
+ Reviewed-on: https://code.wireshark.org/review/5144
+ Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 3555c06
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Thu Oct 2 17:37:24 2014 +0200
-
- Add dissection of IS-IS Router CAPABILITY TLV.
- Bug 10520.
-
- Change-Id: I8d8d56e36d90088af3cd7d2490f95c5f87c75423
- Reviewed-on: https://code.wireshark.org/review/4420
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit c0cdf94
+commit e4b0141
Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Oct 2 09:28:28 2014 -0700
+Date: Tue Dec 9 16:54:17 2014 -0800
- Qt: Keep dialogs from blocking tests.
+ Qt: Obey main toolbar icon preferences.
- If WIRESHARK_QUIT_AFTER_CAPTURE is set, call exit(0). This keeps us from
- emitting the aboutToQuit signal and doing things that might pop up
- dialogs.
+ Remove the preferences for the filter toolbar and mark them GTK+-only.
- Change-Id: I6e986b6e7ad824d8b5258e34a12c32869f5b2d34
- Reviewed-on: https://code.wireshark.org/review/4421
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit abfa091
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Oct 1 11:17:44 2014 -0400
-
- Some Release Notes cleanup.
-
- - Don't list bugs which were fixed in 1.12 as being fixed in 1.99. (We probably
- should add some bugs to the bugs-fixed list.)
- - Remove new-features list for everything prior to 1.12 (so we only list
- improvements since 1.12).
- - Fix bug link to bug 1814.
- - Fix the wiki's URL (the wiki doesn't appear to support https today).
- - Remove bugs 4445 and 9242 from the Known Problems list: they've been fixed.
-
- Change-Id: Ideb9ddf24e429ee00c19ac975370aa4fe81e652b
- Reviewed-on: https://code.wireshark.org/review/4403
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 0efa992
-Author: Michele Baldessari <michele@acksyn.org>
-Date: Sat Aug 23 09:10:13 2014 +0200
-
- Extend X11 response parsing
-
- Add support to parse screens, depths, visual-types and
- pixel-formats in the X11 connection initial response.
-
- v1->v2:
- - Do not show unused bytes when their length is 0
- - Fix up tabs
-
- Change-Id: If62f0eab65a18e050fb3f830a6bd7574ab1f2de6
- Reviewed-on: https://code.wireshark.org/review/4249
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: Ie48b19aee29a1cfcea4c41ca6c08ddbba3102377
+ Reviewed-on: https://code.wireshark.org/review/5693
+ Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit 67f1fa5
-Author: Gerald Combs <gerald@zing.org>
-Date: Wed Oct 1 19:16:12 2014 -0700
-
- Temporarily disable the Qt tests added in g58cde5c.
-
- Apparently what works for me doesn't work for the Buildbot users.
-
- Change-Id: I7d3e4f2b89ae8ae3dadc8d92438c0e1923b97ace
- Reviewed-on: https://code.wireshark.org/review/4416
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 58cde5c
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Oct 1 12:44:14 2014 -0700
-
- Add tests for the Qt UI.
-
- Make sure the Qt UI quits if WIRESHARK_QUIT_AFTER_CAPTURE is set. Make
- sure Bourne shell scripts (*.sh) have UNIX/POSIX line endings. Reduce
- some time values so that the tests run faster.
-
- Change-Id: I81df7c6f72d7d807d1856863cbea1bb6326ca711
- Reviewed-on: https://code.wireshark.org/review/4407
- Tested-by: Gerald Combs <gerald@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit b5aa0d2
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Oct 1 14:59:45 2014 -0700
-
- Qt: Try to reduce the initialization time.
-
- Change-Id: I4f7e9abee9ebb7ecc862e2122bc47ec65252c3ec
- Reviewed-on: https://code.wireshark.org/review/4410
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit afa8c02
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Oct 1 14:16:50 2014 -0700
+commit c1d4a08
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Tue Dec 9 15:14:22 2014 -0800
- Qt: Try to fix a Visual C++ encoding warning.
-
- Try to fix
-
- .\simple_dialog.cpp(49) : warning C4566: character represented by universal-character-name '\uFFFF' cannot be represented in the current code page (1252)
+ Add media playback icons.
- We're assigning a delimiter. "Cannot be represented" is a feature,
- not a bug.
-
- Change-Id: Iba8bc5f5b42a43ec971d822b0e00f932787c7b16
- Reviewed-on: https://code.wireshark.org/review/4409
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I5a9ba1314b0c93098e7b802618f73c7fca608b04
+ Reviewed-on: https://code.wireshark.org/review/5692
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 2a2d75e
+commit 34cd063
Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Oct 1 22:22:35 2014 +0200
+Date: Tue Dec 9 23:46:05 2014 +0100
- GSM SMS: follow-up of gd65b7d5
+ LTE RRC: upgrade dissector to v12.3.0
- Change-Id: I221e1411501e7c15eafe43e109f478684fa5ef10
- Reviewed-on: https://code.wireshark.org/review/4408
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: Iac974bf505bed270fc1f9409a7d61c80ebca17a5
+ Reviewed-on: https://code.wireshark.org/review/5691
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit 1318d4c
-Author: Peter Wu <peter@lekensteyn.nl>
-Date: Mon Sep 29 01:39:32 2014 +0200
-
- http: ignore response body for HEAD requests
-
- Responses to HEAD requests must not have a message body, so do not
- attempt to use the Content-Length and similar headers that indicate a
- non-empty message body in the response. Those point to the entity that
- would be returned for non-HEAD requests.
-
- Requests do not have request_method set, so do not limit desegmentation
- by HEAD in that case. Verified by comparing the output of `tshark -O
- http` and by looking in the Wireshark GTK UI.
-
- Bug: 6064
- Change-Id: I7f027a06d8480673ca9754037d080c3b25cc5816
- Reviewed-on: https://code.wireshark.org/review/4357
- Reviewed-by: Peter Wu <peter@lekensteyn.nl>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit f351a58
+commit 4921e55
Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Oct 1 08:42:20 2014 -0700
-
- Update the release notes.
-
- Change-Id: I2a5b2d45be806cd873a62062924966d82ce4c296
- Reviewed-on: https://code.wireshark.org/review/4406
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit d65b7d5
-Author: Michael Mann <mmann78@netscape.net>
-Date: Tue Sep 30 21:42:48 2014 -0400
-
- Eliminate proto_tree_add_text from GSM_SMS dissector.
-
- Change-Id: Ibe189239735da2ebb1b0ce61a5af249975b38be3
- Reviewed-on: https://code.wireshark.org/review/4402
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit fa1d0be
-Author: Peter Wu <peter@lekensteyn.nl>
-Date: Fri Sep 26 00:10:13 2014 +0200
-
- cmake: update FindGTK2 to v3.0.1-1824-g0b12815
-
- Current FindGTK2.cmake as included with Wireshark cannot do a 32-bit
- build even after setting CMAKE_LIBRARY_PATH=/usr/lib32. After an update
- to upstream FindGTK2 (v3.0.1-1824-g0b12815), things build again.
-
- Compared to upstream FindGTK2, FindWSWinLibs and related hints have been
- added (note that "${GTK2_HINTS}/lib" is not a typo, it is needed as some
- headers are includes in locations like lib/gtk-2.0/include/). The
- include paths have become relative again as there are no files like
- FindPackageHandleStandardArgs in the Wireshark source tree. Diff between
- upstream FindGTK2 and the version in this patch:
-
- diff --git a/cmake/modules/FindGTK2.cmake b/cmake/modules/FindGTK2.cmake
- index 72bb8eb..9b4f989 100644
- --- a/cmake/modules/FindGTK2.cmake
- +++ b/cmake/modules/FindGTK2.cmake
- @@ -167,2 +167,5 @@
-
- +include( FindWSWinLibs )
- +FindWSWinLibs( "gtk2" "GTK2_HINTS" )
- +
- #=============================================================
- @@ -176,4 +179,4 @@
-
- -include(${CMAKE_CURRENT_LIST_DIR}/SelectLibraryConfigurations.cmake)
- -include(${CMAKE_CURRENT_LIST_DIR}/CMakeParseArguments.cmake)
- +include(SelectLibraryConfigurations)
- +include(CMakeParseArguments)
-
- @@ -289,2 +292,5 @@ function(_GTK2_FIND_INCLUDE_DIR _var _hdr)
- ${_suffixes}
- + HINTS
- + "${GTK2_HINTS}/include"
- + "${GTK2_HINTS}/lib"
- )
- @@ -395,2 +401,4 @@ function(_GTK2_FIND_LIBRARY _var _lib _expand_vc _append_version)
- [HKEY_LOCAL_MACHINE\\SOFTWARE\\gtkmm\\2.4;Path]/lib
- + HINTS
- + "${GTK2_HINTS}/lib"
- )
- @@ -409,2 +417,4 @@ function(_GTK2_FIND_LIBRARY _var _lib _expand_vc _append_version)
- [HKEY_LOCAL_MACHINE\\SOFTWARE\\gtkmm\\2.4;Path]/lib
- + HINTS
- + "${GTK2_HINTS}/lib"
- )
- @@ -829,3 +839,3 @@ set(_GTK2_did_we_find_everything true) # This gets set to GTK2_FOUND
-
- -include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)
- +include(FindPackageHandleStandardArgs)
-
- Change-Id: I02103409a79ea30d1bf7cc0dfb43a9e41f8a4db3
- Reviewed-on: https://code.wireshark.org/review/4293
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+Date: Tue Nov 18 16:21:42 2014 -0800
-commit 9506909
-Author: Peter Wu <peter@lekensteyn.nl>
-Date: Thu Sep 25 12:09:23 2014 +0200
-
- cmake: use pkg-config for resolving dependencies
-
- Changes:
- * Fix glib2 search path.
- * Add pkg-config support to CAP, GEOIP, GNUTLS, LUA, PortAudio (API
- 19), zlib, kerberos.
- * Add pkg-config support to libnl3, libnl2 and libnl1 (but tested only
- with libnl3).
-
- This makes it easier to do 32-bit builds on 64-bit hosts by just setting
- `PKG_CONFIG_LIBDIR`. Due to how HINTS work, it is still fragile though:
- missing 32-bit libraries will cause a fallback to 64-bit libraries.
-
- A future patch could check for `<PREFIX>_FOUND` and remove the manual
- `find_path` and `find_library` hackery since the paths are already
- known.
+ Qt: Initial VoIP Calls dialog.
- Change-Id: Ieb4fb74695c96afb1a4c70168e84abb1fa4612c6
- Reviewed-on: https://code.wireshark.org/review/4292
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 0ac441b
-Author: Anndy Ke <anndymaktub@yahoo.com.tw>
-Date: Tue Sep 30 17:10:56 2014 +0800
-
- Dissect ext_capab and alt_mac_addr subelements of wifi display IE.
+ Add Telephony menu items for VoIP Calls and SIP Flows. Put VoIP Calls at
+ the top, since that seems to be the primary item.
- Support two subelements of WFD IE:
- - WFD Extended Capability Bitmap
- - Alternative MAC Address
-
- Change-Id: Ic365fdd84a6db6cf7d21c6ea32924a094432f83a
- Reviewed-on: https://code.wireshark.org/review/4380
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 39c51be
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Sep 29 21:07:47 2014 +0200
-
- LLDP: TIA Network Policy Unknown Policy Flag Decode is not correct
-
- Wrong length for field...
-
- Bug:10512
- Change-Id: I416a34d5f50cc0e842612a084c95d885eea68ef1
- Reviewed-on: https://code.wireshark.org/review/4377
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 41ef2b0
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Oct 1 08:07:20 2014 +0200
-
- idl2wrs (DCERPC): fix some warning
+ Add configure-time checks for QtMultimediaWidgets in anticipation of
+ adding a VoIP playback dialog.
- * Fix -Wmissing-prototypes in
- * Fix unused variable for drusapi (using _U_)
+ Add an icon for the playback button. (Yes, I've been avoiding
+ GNOME-level gratuitous icons so far but this is one of the rare
+ occiasions where it makes sense.)
- Need to fix indent and some unused function/variable to remove from DIRTY list
+ Add a help link define for the VoIP calls dialog.
- Change-Id: Ib6f325f0b54e2eb254ec38a41199b4b60a4d90a1
- Reviewed-on: https://code.wireshark.org/review/4398
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I5d0799685c598ad9af76fe9667f8ea7d14b66050
+ Reviewed-on: https://code.wireshark.org/review/5674
+ Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 214b127
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Oct 1 07:49:38 2014 +0200
-
- GIF: add a missing hf registration
-
- Change-Id: Ib90054ef8a87f40249f644e8c7065b755419a11c
- Reviewed-on: https://code.wireshark.org/review/4396
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 01b093c
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 30 19:12:26 2014 -0400
-
- Add editor modelines; Adjust whitespace as needed.
-
- Change-Id: I434da226c842298f4fb2a4335d06d51e164af2af
- Reviewed-on: https://code.wireshark.org/review/4394
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 0cc027c
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Tue Sep 30 14:31:45 2014 -0700
-
- Note why strlen(args) could be < linelen.
-
- Change-Id: I8fb3c35be0aa80895b8a917af8a9fd2542fbd9d6
- Reviewed-on: https://code.wireshark.org/review/4393
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 514c101
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Sep 30 21:07:26 2014 +0200
-
- correct the line length if it was longer than the actual string supplied
- by the caller
-
- Bug: 10516
- Change-Id: Ib2c9ab449b95da92cc889d0992fad30f432a2836
- Reviewed-on: https://code.wireshark.org/review/4386
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 9b181b9
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 30 16:59:17 2014 -0400
-
- Add editor modelines; Adjust whitespace; Remove boilerplate comments
-
- Change-Id: I1f5f83ed441f6009125cf2cbe5023af04986898a
- Reviewed-on: https://code.wireshark.org/review/4392
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 6896c26
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 30 16:52:09 2014 -0400
-
- packet-fp_umts_fp.c: various
-
- - Use #if 0/#endif to comment out code instead of /* ... */
- = Add editor modelines and adjust whitespace as needed.
-
- Change-Id: I6f7e18a7955cd17d6d727090de802374a7cae0c4
- Reviewed-on: https://code.wireshark.org/review/4391
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit a585cd8
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 30 16:46:14 2014 -0400
-
- packet-ses.[hc], packet-pres.c: various:
-
- - Create/use extended value-strings;
- - Move proto-register...() to (near) the end of the file;
- - Add editor modelines and adjust whitespace as needed.
-
- Change-Id: I7ebe6dfd62b3fb190aa1cefc9b35d40f156f11ea
- Reviewed-on: https://code.wireshark.org/review/4390
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit f687d63
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 30 15:43:12 2014 -0400
-
- packet-simulcrypt.c: various
-
- - Add/use several extended value strings;
- - Add (what appear to be) 3 missing entries to a value-string array;
- - Add editor mode-lines and adjust whitespace as needed.
-
- Change-Id: Ia3bea3c52130ae07d1f0c271659fb010abecb179
- Reviewed-on: https://code.wireshark.org/review/4389
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit b57a8bb
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 30 15:15:13 2014 -0400
-
- packet-sscop.c: various:
-
- - Add/use extended value-string;
- - Add editor-modelines and adjust whitespace as needed.
-
- Change-Id: I5e03d6bcaeb2f4beee37ad4778a87657ae82128d
- Reviewed-on: https://code.wireshark.org/review/4388
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 22b5278
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 30 15:08:11 2014 -0400
-
- packet-mgcp.[hc]: Various changes:
-
- - Add/use extended value-string;
- - Move proto_register...() and proto_reg_handoff...() to the end of the file;
- - Add editor modelines and adjust whitespace as appropriate.
-
- Change-Id: Iede67c418d9f2b4e263113bb14e77d6a56a16225
- Reviewed-on: https://code.wireshark.org/review/4387
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit ff307c7
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 30 13:19:24 2014 -0700
-
- Add more HAVE_LIBPCAP checks.
-
- Change-Id: I82e62f6be03a2ae1617cd5b8e430b73ca8fbe7f8
- Reviewed-on: https://code.wireshark.org/review/4385
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 0050902
+commit 3147087
Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 30 12:59:51 2014 -0700
+Date: Tue Dec 9 13:22:20 2014 -0800
- Qt: Finish implementing -g
+ Fix ranlib "has no symbols" errors in the codecs directory.
- Should fix the current dist failure.
+ Don't build the G.722 or G.726 codecs for now. Each are wrapped in
+ "#ifdef HAVE_SPANDSP", which we don't define.
- Change-Id: Ib1b8d92f6267040c9eef2e4c27ca78c6dd0631be
- Reviewed-on: https://code.wireshark.org/review/4384
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 9fdc85d
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 30 12:15:17 2014 -0700
-
- Qt: Try to fix libpcap-less builds.
+ Conditionally compile the SBC codec.
- Change-Id: I64f4d6490388858306180445b58863d57217986a
- Reviewed-on: https://code.wireshark.org/review/4383
+ Change-Id: I5f09ff66514f967d4f0611c943b4e6a975b8994b
+ Reviewed-on: https://code.wireshark.org/review/5690
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit ced39b6
+commit f66de3a
Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Sep 29 16:27:11 2014 -0700
+Date: Tue Dec 9 11:24:59 2014 -0800
- Qt: Start capture from the command line.
-
- Fill in the capture-related mise en place so that -k and -i work. Get
- rid of global_capture_session in ui/qt and make it a member of
- MainWindow.
-
- Copy over privilege checking from GTK+.
+ Fix filename matching.
- Move the global capture session struct to MainWindow.
-
- Change-Id: Iab5ec683860a40255a7e1d82e3872ced24fd55cb
- Reviewed-on: https://code.wireshark.org/review/4382
+ Change-Id: I2bdfd3ad2798ed1443d06c42b05c9962b8e8041d
+ Reviewed-on: https://code.wireshark.org/review/5689
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 5330875
+commit bcaa5d8
Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Sep 29 14:34:13 2014 -0700
+Date: Wed Nov 12 14:24:16 2014 -0800
- GTK+: Revert back to 2.24.14-1.1 on Win64.
+ Qt: Update and rename the summary dialog.
- As Pascal discovered in
+ Go back to a single view similar to the GTK+ UI. Apply layouts using Qt
+ Designer.
- https://www.wireshark.org/lists/wireshark-dev/201409/msg00045.html
+ Rename the menu item and class to "Capture File Properties". It's not
+ really a summary if it contains details such as "marked average bits
+ per second". We might want to move this to a "Properties" item under
+ the "File" menu similar to other applications.
- Wireshark-gtk.exe crashes at startup on Windows 8.1 x64 when compiled
- with the GTK+ 2.24.23-1.1 bundle and Visual C++ 2013. Revert to the
- Win64 build to the prior GTK+ bundle, which works on my test system.
+ Add the GTK+ summary icon (for now) to the toolbar and open the
+ properties dialog on clicking.
- Update the release notes. Make sure we use a libintl-8.dll that's
- compatible with GnuTLS.
+ Singleton dialogs delenda est[1]. Let the user open as many summaries on
+ as many capture files as he or she wishes. Also, global cfile delenda
+ est[2].
- Ideally we'd just upgrade or rebuild the GTK+ bundle but so far that
- hasn't worked. Prior to this I tried:
+ Don't blindly include QtGui. Add specific components instead.
- Updating the gtk2 package at build.opensuse.org to 2.24.24. This fails with
+ Use consistent method names, variable names, and patterns. Try to
+ document what "consistent" means.
- [ 187s] make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/gtk+-2.24.24/gtk'
- [ 187s] /usr/bin/gtk-update-icon-cache --force --ignore-theme-index \
- [ 187s] --include-image-data \
- [ 187s] --source builtin_icons stock-icons > gtkbuiltincache.h.tmp && \
- [ 187s] mv gtkbuiltincache.h.tmp gtkbuiltincache.h
- [ 187s] gtk-update-icon-cache: No theme index file.
- [ 187s] make[2]: *** [gtkbuiltincache.h] Error 1
+ Adjust the way we display some statistics to match the summary bar, e.g.
+ displayed = captured if we don't have a filter applied.
- Switching to the OBS GTK+ 3.14 package. It looks like a lot of our GTK+ code is
- deprecated, including GtkAction and GtkAttachOptions.
+ [1] Not really.
+ [2] Yes, really.
- Change-Id: I1548c84022f02895e5d424cd61e0fed7b57b2e75
- Ping-Bug: 9914
- Reviewed-on: https://code.wireshark.org/review/4379
+ Change-Id: I11793b1d79dd0c3f70414ac8592b86181da59916
+ Reviewed-on: https://code.wireshark.org/review/5274
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 0744558
-Author: Michael Mann <mmann78@netscape.net>
-Date: Mon Sep 29 14:09:31 2014 -0400
-
- Improve filterability of GTP dissector.
-
- Eliminated many, but not all proto_tree_add_text calls (mostly thanks to convert_proto_tree_add_text.pl)
-
- Change-Id: I37d22ca9816ae1a3a42d911abeb73f7ba49f77d3
- Reviewed-on: https://code.wireshark.org/review/4378
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 1a50aee
-Author: Michael Mann <mmann78@netscape.net>
-Date: Sun Sep 28 21:09:06 2014 -0400
-
- Improve filterability of RSVP dissector.
-
- Eliminated many, but not all proto_tree_add_text calls.
-
- Change-Id: Ic904a0019a9d5d64d47b562bd282f1e6fad617cb
- Reviewed-on: https://code.wireshark.org/review/4366
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 4342d0f
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 29 11:59:26 2014 -0700
-
- High Throughput is 11n, not 11g or 11a.
-
- Change-Id: I86b6dac9cf3f1f524c1168d675bff4a04e361cee
- Reviewed-on: https://code.wireshark.org/review/4374
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 3c0a668
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Sep 29 14:42:55 2014 -0400
-
- Add editor modelines and adjust indentation as needed.
-
- Change-Id: I857700d685354b0bc9e0ca647c57faba981b520f
- Reviewed-on: https://code.wireshark.org/review/4373
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit ff5a772
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Sep 29 14:07:49 2014 -0400
-
- Add editor modelines and adjust indentation as needed.
-
- Change-Id: Id57d264299f2026d703c5b08bace4b24b32f184c
- Reviewed-on: https://code.wireshark.org/review/4371
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 1c055f5
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Sep 29 11:05:38 2014 -0400
-
- Add KNXnetIP and DSR to the list of new-to-1.99 protocols. Add the former's
- author to AUTHORS.
-
- Also mention support of nanosecond timestamps in PCAP-NG files.
-
- Change-Id: I31666de845240a311a8332cff42120d78d2d1474
- Reviewed-on: https://code.wireshark.org/review/4367
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 97d2030
-Author: Hadriel Kaplan <hadrielk@yahoo.com>
-Date: Mon Sep 29 11:34:46 2014 -0400
-
- Fix lua bindings for timestamp precision
-
- The changes to the timestamp define names broke the init.lua file
- generation. Change-id Id0c27b31c5 tried to fix this, but would break
- backwards compatibility of exisitng Lua scripts. This commit fixes
- that change by adding the timestamp variables in both a new Lua table
- as well as the old filetypes table.
-
- Change-Id: I74749acb51dc85094e8c63b240a1951bd4cc0330
- Reviewed-on: https://code.wireshark.org/review/4370
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit aef88f4
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Sep 29 17:05:34 2014 +0200
-
- Dissect more of the Presence Reporting Area Action IE.
-
- Change-Id: I4bf0c7890fff4162e1cf5faad8dd0ca008e0dbe6
- Reviewed-on: https://code.wireshark.org/review/4368
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit ff87bc8
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Sep 29 10:37:52 2014 -0400
-
- Add missing use of a value_string definition
-
- Change-Id: I865256633dbcc378b53eeabb62fcf84c617ea1b9
- Reviewed-on: https://code.wireshark.org/review/4365
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 1b733e1
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Sep 29 16:26:13 2014 +0200
-
- Fix a broken comment
-
- Change-Id: I4358c118ec890456468d7aa8eda00fb0ddbaea20
- Reviewed-on: https://code.wireshark.org/review/4364
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 1040687
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Sep 28 19:25:09 2014 -0400
-
- Add editor modelines; fix indentation as needed.
-
- Change-Id: I1ad94654343e5a018a0b3159481d45ffb3a91263
- Reviewed-on: https://code.wireshark.org/review/4363
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 768e36f
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 29 00:05:53 2014 -0700
-
- Remove duplicate packet-dcerpc-mapi.c.
-
- Change-Id: If2ffd01c29777840db8e305bee9565efaa58d253
- Reviewed-on: https://code.wireshark.org/review/4362
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit e976f68
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Sep 28 19:58:16 2014 +0200
-
- PIDL (DCERPC mapi): enhance dissector
-
- Correctly regenerate mapi dissector (launch via make in pidl/mapi folder)
-
- * Fix -Wunused-variable (fix in request/response.cnf files)
- * Fix trailing whitespace
-
- Not yet ready to remove from DIRTY list (there is always some warning about unused tree)
-
- Change-Id: I9759202e320e90f0cb91db5c7dd9650ff62bbadd
- Reviewed-on: https://code.wireshark.org/review/4347
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit cf3edd9
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Sep 28 18:16:58 2014 +0200
-
- PIDL (DCERPC mdssvc): enhance dissector
-
- * Fix -Wunused-function (Add functions to mdssvc.cnf with NOEMIT)
- * Remove dissector DCERPC mdssvc from DIRTY list
-
- Change-Id: Ic097b0067a44fcfd9298ace1abeb7ca8f0daf00b
- Reviewed-on: https://code.wireshark.org/review/4346
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 4110bde
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 19:51:34 2014 +0200
-
- PIDL: fix indent (use 4 tabs) and remove trailing whitespace
-
- Change-Id: I0ee63a040867b44ac9915704f5e581483ed6f7e2
- Reviewed-on: https://code.wireshark.org/review/4310
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit b2d81a2
+commit 9681bdd
Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Sep 26 22:43:25 2014 -0400
+Date: Fri Dec 5 19:41:12 2014 -0500
- Remove proto_tree_add_text_valist from dissectors.
+ Eliminate proto_tree_add_text from packet-ppp.c.
- The only remaining call to proto_tree_add_text_valist is in expert.c. Suggestions welcome on how to make it "private" enough so dissectors can't use it.
+ Some of the conversions to proto_tree_add_xxx calls involved using explicit sizes instead of the "option length", so there is skipping of the "byte highlighting" of the type + length bytes.
- Change-Id: I1b70789bd01a857c3ac06d198667aeb59c4d1be9
- Reviewed-on: https://code.wireshark.org/review/4333
+ Change-Id: Ibfe09a089fb33ba43121de079aca81742d48db4c
+ Reviewed-on: https://code.wireshark.org/review/5636
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 45fb377
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Sep 28 22:32:33 2014 -0400
-
- Fix lua bindings to handle timestamp precision changes
-
- The recent wiretap changes broke the generation of init.lua among other things,
- though it did coincidentally fix one of the "yuck" comments in the generator
- regex.
-
- (Note that this is entirely untested, because out-of-tree init.lua is and always
- has been broken, but it should work)
-
- Change-Id: Id0c27b31c596613997de4ba2f6088eb9d6c8fc53
- Reviewed-on: https://code.wireshark.org/review/4361
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 26e7201
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Sep 28 22:07:15 2014 -0400
-
- Update debian symbol files to satisfy the buildbot
-
- Why is this necessary again?
-
- Change-Id: Idf8981a00636b16ac06b5af5962131d29d88dfad
- Reviewed-on: https://code.wireshark.org/review/4360
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 94c47b1
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Sep 28 17:56:16 2014 -0400
-
- mrcpv2: don't use an uninitialized buffer as a string
-
- I have no idea what the original intent was with this magical
- otherwise-totally-unused buffer, but it clearly serves no purpose now. Stop
- reading garbage from it, and just read the data in the packet which is what the
- field name suggests.
-
- Bug: 10510
- Change-Id: I05d0b98c04e59ea70247811168c4c8a64861f43d
- Reviewed-on: https://code.wireshark.org/review/4352
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 9683518
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 28 17:10:24 2014 -0700
-
- Pass the global capture options to open_capture_device().
-
- If we support setting the time stamp precision, we need it to determine
- whether we're writing a pcap-ng file so we know whether to request
- nanosecond precision or not.
-
- Change-Id: I7df19c1afbe1ba90c40c49aef79f6f88ce5df29b
- Reviewed-on: https://code.wireshark.org/review/4359
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 34fc114
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 28 16:54:03 2014 -0700
-
- Support nanosecond-resolution time stamps when writing pcap-ng files.
-
- Pcap-ng files have supported variable time stamp resolutions since Day
- One, and any code that reads those files but can't handle
- nanosecond-resolution time stamps is broken.
-
- Pcap files got a separate magic number for nanosecond-resolution files
- relatively recently, and not all code that reads pcap files handles that
- magic number, so we don't support it for pcap files.
-
- Based on https://code.wireshark.org/review/#/c/4304/ from Peter Hatina.
-
- Change-Id: I4f4e3b5ca0ba4fe9394765edb54bb77a4a776237
- Reviewed-on: https://code.wireshark.org/review/4358
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 982c7d3
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 28 16:41:43 2014 -0700
-
- Support nanosecond-resolution time stamp adjustment.
-
- Based on https://code.wireshark.org/review/#/c/4304/ from Peter Hatina.
-
- Change-Id: Ibc5e230b0682990fd4ca1f29597a9a045cb73928
- Reviewed-on: https://code.wireshark.org/review/4356
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 392c41c
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 28 16:28:36 2014 -0700
-
- Add support for getting nanosecond time stamp resolution when capturing.
-
- If we have pcap_set_tstamp_precision(), use it to request nanosecond
- time stamp resolution *if* we're writing a pcap-ng file; any code that
- reads those files and can't handle nanosecond time stamp resolution is
- broken and needs to be fixed.
-
- If we're writing a pcap file, don't ask for nanosecond resolution time
- stamps, as that requires a different magic number for pcap files, and
- not all code that reads pcap files can handle that. (Unlike pcap-ng,
- where the ability to have non-microsecond time stamp resolution was
- present from Day One, it's a relatively recent addition to pcap.) We
- could add a command-line option/GUI option for that, like the option
- recent versions of tcpdump have, if it matters.
-
- Change-Id: I8fa464eb929feecb9a70be70712502c9f0cc5270
- Reviewed-on: https://code.wireshark.org/review/4355
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit f6b9e7a
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Sep 28 20:57:13 2014 +0200
-
- PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: Ibae478771b30d6e9ae07315985f1e71bc6b65423
- Reviewed-on: https://code.wireshark.org/review/4350
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
-commit fdf3585
+commit 74172ae
Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Sep 28 13:50:38 2014 +0200
+Date: Sun Dec 7 20:54:05 2014 +0100
- Stanag 4607: rename protocol abbreviation from 4607 to s4607 to avoid any collision with a frame number
+ LTE: Update MAC and RLC dissectors to Release 12
- Bug: 10509
- Change-Id: I6b97c979ed05378a7d3495fe455bc36b82b19cc9
- Reviewed-on: https://code.wireshark.org/review/4338
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: I036a0d1180b6481e8cc27210ed44eda4ba078a27
+ Reviewed-on: https://code.wireshark.org/review/5659
+ Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit 54b733c
+commit 58fc89a
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 28 11:37:06 2014 -0700
+Date: Tue Dec 9 00:54:34 2014 -0800
- Make the time stamp resolution per-packet.
-
- Pcap-ng files don't have a per-file time stamp resolution, they have a
- per-interface time stamp resolution. Add new time stamp resolution
- types of "unknown" and "per-packet", add the time stamp resolution to
- struct wtap_pkthdr, have the libwiretap core initialize it to the
- per-file time stamp resolution, and have pcap-ng do the same thing with
- the resolution that it does with the packet encapsulation.
-
- Get rid of the TS_PREC_AUTO_XXX values; just have TS_PREC_AUTO, which
- means "use the packet's resolution to determine how many significant
- digits to display". Rename all the WTAP_FILE_TSPREC_XXX values to
- WTAP_TSPREC_XXX, as they're also used for per-packet values.
+ Fix copy-and-pasteo.
- Change-Id: If9fd8f799b19836a5104aaa0870a951498886c69
- Reviewed-on: https://code.wireshark.org/review/4349
+ Change-Id: I181129595c7259f5c0af5308f0ca0190dce67eb7
+ Reviewed-on: https://code.wireshark.org/review/5687
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit efea8ce
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Sep 25 15:37:38 2014 -0700
-
- CMake: Conditional build fixes and updates.
-
- HAVE_PORTAUDIO_H didn't work for Stig. Use PORTAUDIO_FOUND instead,
- which is the correct name to use according to the
- FIND_PACKAGE_HANDLE_STANDARD_ARGS documentation. Use xxx_FOUND in a
- couple of other places.
-
- Conditionally build caputils/airpcap_loader.c.
-
- Change-Id: I6a134192902229a446dccf43bfb7bbfe2a55d1e2
- Reviewed-on: https://code.wireshark.org/review/4291
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
- Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
- Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
-
-commit 5517c42
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Sep 28 13:47:57 2014 -0400
-
- packet-netflow.c: Do various fixes and changes
-
- - Allow integer & float fields to have "reduced size encoding";
- Fixes Bug #8846;
- - Add a missing cflow field-type;
- - Update the names of a few cflow field-types;
- - Replace all-but-one use of proto_tree_add_text();
- - Fix encoding-args as appropriate;
- - Remove some obsolete comments;
- - Adust whitespace/indentation/formatting.
-
- Change-Id: I4271e3692288cef3ea0f1aa5eb44f5a0b05c29da
- Reviewed-on: https://code.wireshark.org/review/4348
- Petri-Dish: Bill Meier <wmeier@newsguy.com>
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 938008e
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Sep 28 17:49:58 2014 +0200
-
- PIDL (DCERPC lsa): enhance dissector
-
- * Fix -Wunused-function (Add functions to lsa.cnf with NOEMIT)
- * Remove also some MANUAL function (no unused too..)
- * Remove dissector DCERPC lsa from DIRTY list
-
- Change-Id: I7b7f924f244757207f378b8650b8dd30e739da08
- Reviewed-on: https://code.wireshark.org/review/4325
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 1633724
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 23:42:19 2014 +0200
-
- PIDL (DCERPC eventlog): enhance dissector
-
- * Fix -Wunused-function (Add functions to eventlog.cnf with NOEMIT)
- * Remove dissector DCERPC eventlog from DIRTY list
-
- Change-Id: I29710ce4f548a6e4d9bf1dd6e652acf1eeaddf2c
- Reviewed-on: https://code.wireshark.org/review/4324
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit d572634
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 23:35:40 2014 +0200
-
- PIDL (DCERPC dnsserver): enhance dissector
-
- * Fix -Wunused-function (Add functions to dnsserver.cnf with NOEMIT)
- * Remove dissector DCERPC dnsserver from DIRTY list
-
- Change-Id: Id1d4f43784bfbf417156353fd3254375365c35c8
- Reviewed-on: https://code.wireshark.org/review/4323
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 28ec9c2
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 23:29:43 2014 +0200
-
- PIDL (DCERPC winreg): enhance dissector
-
- * Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector)
- * Fix indent (use tabs)
- * Remove DCERPC winreg dissector from DIRTY list
-
- Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7
- Reviewed-on: https://code.wireshark.org/review/4322
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit e759d82
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 18:47:53 2014 +0200
+commit e5757d1
+Author: Irene Ruengeler <ruengeler@wireshark.org>
+Date: Fri Dec 5 10:04:29 2014 +0100
- PIDL: fix -Wmissing-prototype
+ Fix GTK warning in EXTCAP parts
- Change-Id: I4cae47450e8026b10bd373828f235184560e0a99
- Reviewed-on: https://code.wireshark.org/review/4308
+ Change-Id: I3a4d9baf3592db1394d1177a19014cbef9140759
+ Reviewed-on: https://code.wireshark.org/review/5628
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 2bd8f50
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Sep 28 08:05:48 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-09-28]
-
- Change-Id: I7604c01a061f4832e53aa88903a53c1d6a50e4dc
- Reviewed-on: https://code.wireshark.org/review/4339
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 5a16ae7
-Author: alage <sphinxs1988@googlemail.com>
-Date: Mon Aug 25 11:03:43 2014 +0200
-
- New dissector for KNXnetIP protocol
-
- Bug:10403
-
- Change-Id: I8c733ce69e6d44d1bff0ebbe72995f06212d9d93
- Reviewed-on: https://code.wireshark.org/review/3828
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit e9c4217
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 28 01:01:45 2014 -0700
-
- Don't change the packet list column precision in taps.
-
- The only place where the packet list column precision should be set is
- in the code for the column precision menu item, the code for the recent
- file item for that precision, and, if we were to provide it, code for a
- command-line optpion to set it. It's not up to some tap to change it.
-
- Change-Id: I547e606fb346b4c21674a66e883cbbe382055a37
- Reviewed-on: https://code.wireshark.org/review/4336
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit f0b5fb7
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 21:31:32 2014 +0200
-
- PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8
- Reviewed-on: https://code.wireshark.org/review/4319
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit 99f5c50
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 27 12:38:45 2014 -0700
-
- The Ubuntu build says to do this, so I'll believe it so it stops failing.
-
- We get rid of the exports file with ws_symbol_export.h, and then we
- bring it back with this.
-
- Change-Id: Ic689d20ec8ca5806677e1b52018c8c79b381508f
- Reviewed-on: https://code.wireshark.org/review/4335
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 0067909
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 27 11:29:03 2014 -0700
-
- Make get_column_longest_string() static.
-
- It's not used outside epan/column.c, so don't export it.
-
- Change-Id: I38e084946d92f3c31b06fc4fc1991c88e652f58a
- Reviewed-on: https://code.wireshark.org/review/4334
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 6e83b38
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Sep 26 19:41:43 2014 +0200
-
- Get rid of g_hash_table_lookup asserts when loading an external host file
-
- Only parse the host file syntax without trying to store the names in the hash tables (it will be done later in host_name_lookup_init())
-
- Change-Id: I2b8c7b29220e6413c1b5c0a0fa238ecb5388c962
- Reviewed-on: https://code.wireshark.org/review/4309
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Reviewed-by: Irene Ruengeler <iruengeler@googlemail.com>
-commit 6fad7d1
+commit 301a5b7c
Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Sep 26 19:28:01 2014 -0400
+Date: Thu Nov 27 23:18:32 2014 -0500
Eliminate proto_tree_add_text from some dissectors.
- Some other related cleanup.
-
- Change-Id: I45f54032aa8318858f4ee784945b6f2ed163b6ea
- Reviewed-on: https://code.wireshark.org/review/4328
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I44cc6b70ec4dfc565934da499f46fca60a4ded93
+ Reviewed-on: https://code.wireshark.org/review/5524
Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 65437a7
-Author: Simon Zhong <szhong.jnpr@gmail.com>
-Date: Wed Sep 24 22:09:24 2014 -0400
-
- Added support of
- - "PCEP Extensions for Stateful PCE" (draft-ietf-pce-stateful-pce-09)
- - "PCEP Extensions for PCE-initiated LSP Setup in a Stateful PCE Model" (draft-ietf-pce-pce-initiated-lsp-01)
- - "Optimizations of Label Switched Path State Synchronization Procedures for a Stateful PCE" (draft-ietf-pce-stateful-sync-optimizations-01)
-
- checkAPIs.pl executed, got "deprecated APIs tvb_length" warning, but I didn't modify them because I saw reverse operations.
-
- Fuzz test executed, no error.
-
- Can't submit pcap file because is captured during internal test.
-
- Change-Id: I063a7f6bda57543017b546506f9f89eda387daf6
- Reviewed-on: https://code.wireshark.org/review/4275
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit a3c4133
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sat Sep 27 01:21:10 2014 +0200
-
- tshark: fix -H option
-
- The dump of the address info list must be differed to the end of the processing so as to know which host name was actually used in the capture
-
- Bug: 10507
- Change-Id: I44dbfae918d4ae92f9740c309804c7ff21bb4e1b
- Reviewed-on: https://code.wireshark.org/review/4327
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 7477a46
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 23:39:46 2014 -0700
+commit 1952fef
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Fri Dec 5 07:42:34 2014 +0100
- Get rid of some unused members of wtapng_simple_packet_t.
+ SCTP: Missing break in switch (CID 1135556)
- Change-Id: I790d99cefdd58f01ec4a792d66144634862e7427
- Reviewed-on: https://code.wireshark.org/review/4331
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I00939bb9699493fe7af21497d9e9c013cc3d2e62
+ Reviewed-on: https://code.wireshark.org/review/5650
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 15569c6
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 18:27:30 2014 -0700
+commit 283e5c1
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Wed Dec 3 16:46:46 2014 +0100
- Regenerate PIDL dissectors with our current PIDL.
+ GVSP: Missing break in switch (CID 1247683 & 1247684)
- Change-Id: I63a1874d157c55df6c3c3f69c68098528adbb384
- Reviewed-on: https://code.wireshark.org/review/4330
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: Ibd3aef4101126f02453bab10cd5ca31e716334de
+ Reviewed-on: https://code.wireshark.org/review/5617
+ Reviewed-by: W Moxam <warrenm@ptgrey.com>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 8d0b793
+commit fbf08cf
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 18:25:48 2014 -0700
+Date: Mon Dec 8 20:04:23 2014 -0800
- "declare" apparently isn't a valid keyword; use typedef instead.
+ Nothing to free there.
- These changes came from the versions of those files at the tip of the
- Samba trunk, and fix the failures to compile with pidl.
+ pcapng_read_block() never sets *err_info if it returns
+ PCAPNG_BLOCK_NOT_SHB - that happens on an EOF, a short read, or on a
+ successful read of something that doesn't look like an SHB.
- Change-Id: Ifc3276d4bc2ff1cfdb19819811f5b8d1b91961b5
- Reviewed-on: https://code.wireshark.org/review/4329
+ Change-Id: I23ad6aa1c95d800b068a798a4aad1d70d07ac281
+ Reviewed-on: https://code.wireshark.org/review/5686
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 1749e5e
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Sep 26 15:54:09 2014 -0700
-
- Qt: Adjust X11 font search order.
-
- Liberation Mono appears to be the preferred font nowadays.
-
- Change-Id: Ie953bdb8ba77df6486607dc076daa24225b2f08f
- Reviewed-on: https://code.wireshark.org/review/4326
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit a2681cc
+commit 7b1c3ab
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 14:12:32 2014 -0700
+Date: Mon Dec 8 19:57:21 2014 -0800
- Note that errors are generated for dnsserver.idl and eventlog.idl.
+ Manually fix a pidl bug - that field should be an FT_STRING.
- Also fix a typo.
+ No, I don't know why it's making it FT_NONE; it's a bit of a weird data
+ type, with a string inside a structure.
- Change-Id: Id0713fbb722e88a911cae4ef4371b528fe73e048
- Reviewed-on: https://code.wireshark.org/review/4321
+ Change-Id: I27a6d7577ef4a9f4da8ddad2cad97ad097135e90
+ Reviewed-on: https://code.wireshark.org/review/5685
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 24ced90
+commit 5c29704
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 13:14:36 2014 -0700
+Date: Mon Dec 8 19:24:33 2014 -0800
- White space and typo cleanups.
+ LDAP's DirSyncFlags are a bitfield, so show it as an unsigned integer in hex.
- Change-Id: If064178a383ce805ed6f440a1a9d3642a706496c
- Reviewed-on: https://code.wireshark.org/review/4320
+ Change-Id: I2a06b13528ad7dfc587bfb9c1333d4f7a497614e
+ Reviewed-on: https://code.wireshark.org/review/5684
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit ef106f4
+commit 3d95c62
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 12:30:23 2014 -0700
+Date: Mon Dec 8 17:30:04 2014 -0800
- Update to latest version from Samba Git repository.
-
- Comments from Samba Git log:
-
- commit ee2148754e2e2604ac918343fa8769a25523eb49
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Tue Aug 26 21:33:05 2014 +0200
-
- pidl/wscript: remove --with-perl-* options
-
- These are not needed anymore as we have useful defaults now.
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Michael Adam <obnox@samba.org>
-
- commit b537c5a340bae2accbf35a4ec5eab7074b90f0b1
- Author: Michael Adam <obnox@samba.org>
- Date: Mon Aug 25 23:57:23 2014 +0200
-
- pidl: fix the perl module search path (use lib ...) when installing pidl.
-
- This way, pidl can also run with modules installed under the $prefix.
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Michael Adam <obnox@samba.org>
-
- commit 191fc0e541e7c9d0a1095dc287402df9947ce779
- Author: Michael Adam <obnox@samba.org>
- Date: Thu Sep 4 01:38:14 2014 +0200
-
- pidl/wscript: don't check for perl again.
-
- This is done at the toplevel now.
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
- Signed-off-by: Michael Adam <obnox@samba.org>
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
-
- commit 9e591e3d619d127c5ec5f6ac86326c84f59878fa
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:59:45 2014 +0100
-
- pidl-waf: Check for system perl(Parse::Yapp::Driver).
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit 410ada45b7041be6976fcfefadccbb99212a15a3
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:59:41 2014 +0100
-
- pidl-waf: Add a function to check for a system perl module.
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit 17244ef750f699b30ff7ff3a71264f4c76adad6d
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:53:10 2014 +0100
-
- pidl-waf: Install pidl modules to the perl vendorlib directory.
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit 0bb6b0102f6fa21e6c9f8010421386a660c5a5e0
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:54:09 2014 +0100
-
- pidl-waf: Remove unused variable pidl_src.
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit 87976b4e45bd71b086e9201f0d0a563b9071ca4a
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:46:01 2014 +0100
-
- Revert "pidl: Install pidl files corrently."
-
- This reverts commit cee11cfa4544425099268cd32393169afb4bb107.
-
- Reviewed-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit c2d58c3c2059ef3d43f876df547cbc7256235563
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:45:51 2014 +0100
-
- Revert "waf: Add option to specify perl vendor dir."
-
- This reverts commit 9b200555fec2e33da9521db388d1839375aa8d83.
-
- Reviewed-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit c46aaf1102da5e8ba53e9f89f2f756fe8dce83c5
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:45:35 2014 +0100
-
- Revert "pidl: Make perl(Parse:Yapp:Driver) installation optional."
-
- This reverts commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838.
-
- Reviewed-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838
- Author: Andreas Schneider <asn@samba.org>
- Date: Thu Feb 27 13:14:56 2014 +0100
-
- pidl: Make perl(Parse:Yapp:Driver) installation optional.
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
-
- Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
- Autobuild-Date(master): Thu Feb 27 18:47:03 CET 2014 on sn-devel-104
-
- commit 9b200555fec2e33da9521db388d1839375aa8d83
- Author: Andreas Schneider <asn@samba.org>
- Date: Tue Feb 25 17:16:37 2014 +0100
+ Don't try to look in a non-existent hash table.
- waf: Add option to specify perl vendor dir.
+ We only create hash tables if somebody puts a handler in one, so we need
+ to check whether the hash table exists first, to avoid run-time warnings.
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Kai Blin <kai@samba.org>
-
- Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
- Autobuild-Date(master): Thu Feb 27 11:48:54 CET 2014 on sn-devel-104
-
- commit cee11cfa4544425099268cd32393169afb4bb107
- Author: Andreas Schneider <asn@samba.org>
- Date: Tue Feb 25 16:04:24 2014 +0100
-
- pidl: Install pidl files corrently.
-
- Globbing is a really bad idea in installtion system. One of them is if
- you use patch -b to create a backup, you will end up installing the
- backup file too!
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Kai Blin <kai@samba.org>
-
- Change-Id: I9c4491f0d74c24d7c45a59e98825c789097a0c7b
- Reviewed-on: https://code.wireshark.org/review/4318
+ Change-Id: I739d2d808935e651b11bd44b258f168a42ca4b7c
+ Reviewed-on: https://code.wireshark.org/review/5683
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 6700a12
+commit f34bcb7
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 12:27:13 2014 -0700
+Date: Mon Dec 8 16:13:39 2014 -0800
- Update to current version from Samba Git repository.
-
- Changes from Samba Git log:
-
- commit fac24e11655c554cd3113dfb6fc918a0fd3c880c
- Author: Michael Adam <obnox@samba.org>
- Date: Mon Aug 25 23:58:48 2014 +0200
+ Don't put bitmasks under an FT_NONE.
- pidl: remove superfluous "use lib ...".
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Michael Adam <obnox@samba.org>
-
- Change-Id: I8a2460a9168ef5989e9f5e95b51cca73987b80a4
- Reviewed-on: https://code.wireshark.org/review/4317
+ Change-Id: I172c68d233e3887a94c0835234613dfd483ee5af
+ Reviewed-on: https://code.wireshark.org/review/5682
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 44551d3
+commit 260af59
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 12:21:19 2014 -0700
+Date: Mon Dec 8 16:06:11 2014 -0800
- Update to latest version from Samba Git repository.
-
- Changes from Samba Git log:
-
- commit cf75ef9f73f2cdbf2a039bbc9468f5da6a14834e
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Fri May 9 11:49:10 2014 +0200
-
- pidl/lib/wscript_build: make use of PERL_LIB_INSTALL_DIR
-
- Bug: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Andreas Schneider <asn@samba.org>
-
- Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
- Autobuild-Date(master): Sat May 10 01:37:33 CEST 2014 on sn-devel-104
-
- commit ee8f98f26a3d6f02a0d10ceeac1194675d505246
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 16:00:54 2014 +0100
-
- pidl-waf: Only install Yapp::Driver if it is not available.
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
- Autobuild-Date(master): Thu Mar 6 23:30:47 CET 2014 on sn-devel-104
-
- commit b7b0ca1ba9067362bb8a4b901f3a7f2f3bcbd6a1
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:55:46 2014 +0100
-
- pidl-waf: Do not glob to install pidl modules.
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit 17244ef750f699b30ff7ff3a71264f4c76adad6d
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:53:10 2014 +0100
-
- pidl-waf: Install pidl modules to the perl vendorlib directory.
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit 87976b4e45bd71b086e9201f0d0a563b9071ca4a
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:46:01 2014 +0100
-
- Revert "pidl: Install pidl files corrently."
-
- This reverts commit cee11cfa4544425099268cd32393169afb4bb107.
-
- Reviewed-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit c2d58c3c2059ef3d43f876df547cbc7256235563
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:45:51 2014 +0100
-
- Revert "waf: Add option to specify perl vendor dir."
-
- This reverts commit 9b200555fec2e33da9521db388d1839375aa8d83.
-
- Reviewed-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit c46aaf1102da5e8ba53e9f89f2f756fe8dce83c5
- Author: Andreas Schneider <asn@samba.org>
- Date: Fri Feb 28 15:45:35 2014 +0100
+ Values in a value_string_ext *must* be sorted.
- Revert "pidl: Make perl(Parse:Yapp:Driver) installation optional."
-
- This reverts commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838.
-
- Reviewed-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Stefan Metzmacher <metze@samba.org>
-
- commit f0030c619bcf22dbe9eed54b2c0dc9c61f564838
- Author: Andreas Schneider <asn@samba.org>
- Date: Thu Feb 27 13:14:56 2014 +0100
-
- pidl: Make perl(Parse:Yapp:Driver) installation optional.
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
-
- Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
- Autobuild-Date(master): Thu Feb 27 18:47:03 CET 2014 on sn-devel-104
-
- commit 9b200555fec2e33da9521db388d1839375aa8d83
- Author: Andreas Schneider <asn@samba.org>
- Date: Tue Feb 25 17:16:37 2014 +0100
-
- waf: Add option to specify perl vendor dir.
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Kai Blin <kai@samba.org>
-
- Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
- Autobuild-Date(master): Thu Feb 27 11:48:54 CET 2014 on sn-devel-104
-
- commit cee11cfa4544425099268cd32393169afb4bb107
- Author: Andreas Schneider <asn@samba.org>
- Date: Tue Feb 25 16:04:24 2014 +0100
-
- pidl: Install pidl files corrently.
-
- Globbing is a really bad idea in installtion system. One of them is if
- you use patch -b to create a backup, you will end up installing the
- backup file too!
-
- BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
-
- Signed-off-by: Andreas Schneider <asn@samba.org>
- Reviewed-by: Kai Blin <kai@samba.org>
-
- Change-Id: I4372f2c0854743a0339c7d85ace9e67ce9f8bd02
- Reviewed-on: https://code.wireshark.org/review/4316
+ Change-Id: I0c2bcd81955375abf3af24e42c70bea0bb960083
+ Reviewed-on: https://code.wireshark.org/review/5681
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 788de8d
+commit 32e1ff9
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 12:16:35 2014 -0700
+Date: Mon Dec 8 15:36:26 2014 -0800
- Update to current version from Samba Git repository.
-
- Changes from Samba Git log:
+ Don't put bitmasks under an FT_NONE.
- commit d29c143fae4b67c9680a0b9773db3461f2d0d2b7
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Thu Mar 27 14:56:23 2014 +0100
+ proto_tree_add_bitmask() requires that the field under which it's
+ putting the bitmasks be an FT_INTn or FT_UINTn, so that it can determine
+ the length of the field.
- pidl:Samba4/Python: add interface.abstract_syntax() to each interface
+ Arguably, proto_tree_add_bitmask() should, instead, take a length
+ argument, just as other proto_tree_add_ routines do, and, arguably, we
+ should perhaps not even have FT_UINTn and FT_INTn, just FT_UINT and
+ FT_INT, with the display width for hex and octal (leading zeroes)
+ determined by the actual length of the field or something such as that,
+ or as part of the field that also contains the base.
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Andrew Bartlett <abartlet@samba.org>
+ But, even with that, we might want to require an FT_UINTn or FT_INTn
+ anyway, at least in cases where the value of the field as a whole is
+ interesting.
- Change-Id: I9f4650c603ea8b2eff05e7b79d7f44452e1337ab
- Reviewed-on: https://code.wireshark.org/review/4315
+ Change-Id: I4dff8fb1686a30b7d145c089dd1be7f96ecf23e0
+ Reviewed-on: https://code.wireshark.org/review/5680
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit d720fe8
+commit ffcacae
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 12:10:32 2014 -0700
+Date: Mon Dec 8 15:25:50 2014 -0800
- Update to the latest version from the Samba Git repository.
+ Have different MTP2 dissectors for different metadata and CRC.
- Changes from the Samba Git log:
+ Have separate MTP2 dissectors for:
- commit 2ba9453e9ff5d911a146e786ff8878ef67717366
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Thu Sep 26 20:38:12 2013 +0200
+ MTP2 frames with no pseudo-header and no CRC;
- pidl:NDR/Client: avoid useless memcpy()
+ MTP2 frames with a pseudo-header and no CRC;
- If the src and dest pointer of memcpy would be the same
- we should avoid it in order to avoid valgrind warnings.
+ MTP2 frames with no pseudo-header and a CRC;
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Andreas Schneider <asn@samba.org>
+ and call the appropriate dissector in the appropriate places.
- commit f50b561336c7b6c08300e6e477859d1f9fab62c2
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Thu Sep 26 01:20:10 2013 +0200
+ While we're at it, get rid of a global variable - pass the "use extended
+ sequence numbers" flag down through the dissection code path, rather
+ than having it as a global.
- pidl:NDR/Client: fix dcerpc_function() with [out,ref] pointers
-
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Andreas Schneider <asn@samba.org>
-
- commit 662fc2de8c2896503026a2a4052ed1ea8ce78af5
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Fri Aug 30 08:54:10 2013 +0200
-
- pidl:NDR/Client: simplify tevent_req_nterror() usage
-
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Andreas Schneider <asn@samba.org>
-
- commit 02c34fe4e51b5e62157eaf2de1d0aaf9fc6b8d72
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Fri Aug 30 08:53:18 2013 +0200
-
- pidl:NDR/Client: add missing TALLOC_FREE(subreq) after dcerpc_binding_handle_call_recv()
-
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Andreas Schneider <asn@samba.org>
-
- Change-Id: I19017fd216df8d8d202b995305f4eb7b7a8b9a35
- Reviewed-on: https://code.wireshark.org/review/4314
+ Change-Id: Id8da1fbe3529e3ffadd5c30646cbc922f506a01f
+ Reviewed-on: https://code.wireshark.org/review/5679
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit df685fc
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 12:05:40 2014 -0700
-
- Update to the latest version from the Samba Git repository.
-
- Changes from the Samba log:
-
- commit 3a0fa3605b8eb995a8cc4696256129893e1f6f7e
- Author: Stefan Metzmacher <metze@samba.org>
- Date: Sat Sep 21 23:46:01 2013 +0200
-
- pidl:Samba3/ServerNDR: skip DCERPC pipe elements and leave NULL pointers.
-
- We don't support them anyway, but this lets us adding them to the idl
- file and only ignore it on the server.
-
- Signed-off-by: Stefan Metzmacher <metze@samba.org>
- Reviewed-by: Andreas Schneider <asn@samba.org>
-
- Change-Id: Idbe742fa13e5d3892343fde2b3943f38a6e90a8c
- Reviewed-on: https://code.wireshark.org/review/4313
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit bcae048
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 26 12:02:05 2014 -0700
+commit 8a446e9
+Author: Balint Reczey <balint@balintreczey.hu>
+Date: Sat Nov 15 09:44:22 2014 +0100
- Update to the latest version from the Samba Git repository.
-
- From the Samba log:
-
- commit bfdc874e8b98c8ea147dbcc986f96ad4f73d800f
- Author: Jelmer Vernooij <jelmer@samba.org>
- Date: Sat Aug 30 01:59:26 2014 +0200
-
- Various updates to the pidl README file.
-
- Remove samba3/samba4-specific comments, add comments about backends and files.
+ Add missing build-dependencies for the Debian package
- Change-Id: Id2253ce85eab7a684b2c50d25f6f2604dc146a8e
- Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
- Reviewed-by: David Disseldorp <ddiss@samba.org>
+ They are libparse-yapp-perl and libsbc-dev.
- Autobuild-User(master): David Disseldorp <ddiss@samba.org>
- Autobuild-Date(master): Sun Aug 31 23:47:49 CEST 2014 on sn-devel-104
-
- commit 6824f1aa67f0a75df5c94921e334c2b7c7771611
- Author: Jelmer Vernooij <jelmer@samba.org>
- Date: Sat Aug 30 01:59:25 2014 +0200
-
- Remove trailing whitespace.
-
- Change-Id: I1e0948da34bac278edc62cd63dedd08112426e7a
- Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
- Reviewed-by: David Disseldorp <ddiss@samba.org>
-
- Change-Id: Ifd445bf32aca2d30a6e501fc8c8dd030471ad284
- Reviewed-on: https://code.wireshark.org/review/4312
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I474179bb805acb87f8bf316730d63eb294e10a69
+ Reviewed-on: https://code.wireshark.org/review/5322
+ Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
+ Reviewed-by: Balint Reczey <balint@balintreczey.hu>
-commit c90acf2
+commit d87a952
Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Sep 26 08:30:44 2014 -0700
+Date: Mon Dec 8 14:09:33 2014 -0800
- Qt: Capture fixes.
-
- Don't check syntax when we rebuild the CaptureFilterCombo.
+ It's a reasonable expectation that we will have C++ style comments in
+ ui/qt.
- Make sure we switch back to the main window when capturing fails.
-
- Change-Id: Id4137e33a8135645f29ca7b2836c76b90f09e3ac
- Reviewed-on: https://code.wireshark.org/review/4311
+ Change-Id: Iedbf2a2d3cbfee00912e6e883928836932dea566
+ Reviewed-on: https://code.wireshark.org/review/5678
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 69337f1
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 15:05:42 2014 +0200
-
- Modbus: Add value 90 (0x5A) used by Unity (Schneider)
-
- Change-Id: I205f77bccb8ca042da1a699d49844e305612aac2
- Reviewed-on: https://code.wireshark.org/review/4307
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 9c8f10e
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 14:53:43 2014 +0200
-
- Modbus: fix indent and add modelines info
-
- Change-Id: Idfcdaa13c24791cf2b765b02d8235e9b3a9cd775
- Reviewed-on: https://code.wireshark.org/review/4306
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 2d7c113
+commit 08e624f
Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Sep 25 16:21:02 2014 -0700
+Date: Mon Dec 8 13:41:02 2014 -0800
- Move the console log handling code to ui/console.[ch].
+ Remove an unnecessary include.
- Change-Id: I8e554a8e17399d78b0ef29dfb68109a219cd9f1b
- Reviewed-on: https://code.wireshark.org/review/4294
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I55332c21ea66ee7d564c2b338cba524ea774b19c
+ Reviewed-on: https://code.wireshark.org/review/5677
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit ce36b20
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 26 11:56:31 2014 +0200
-
- Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: Ia0f29a491af920415d6e56f30ef436544f7d5ddf
- Reviewed-on: https://code.wireshark.org/review/4303
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit a7591fb
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Fri Sep 26 14:57:51 2014 +0200
-
- Added basic decoding of new IEs
-
- Change-Id: I7982fe6ccee806b574f780cc2e96d7139a6a74c5
- Reviewed-on: https://code.wireshark.org/review/4305
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 4319ab3
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Fri Sep 26 13:24:41 2014 +0200
-
- Add basic dissection for new IEs
-
- Change-Id: Ie9fc9ac4672a80c82c3b09188752c928b1e7d6c1
- Reviewed-on: https://code.wireshark.org/review/4302
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 1275d05
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Mon Sep 22 10:25:32 2014 +0200
-
- Reduce compilator warnings
-
- warning: cast from 'const guint8 *' (aka 'const unsigned char *') to
- 'const guint16 *' (aka 'const unsigned short *') increases required
- alignment from 1 to 2 [-Wcast-align]
- warning: cast from 'const guint8 *' (aka 'const unsigned char *') to
- 'const struct logger_entry *' increases required alignment
- from 1 to 4 [-Wcast-align]
-
- Change-Id: I1ef8bfedb31c3f633166405689d8d788d45365db
- Reviewed-on: https://code.wireshark.org/review/4236
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit e179870
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Sep 26 10:49:47 2014 +0200
-
- ANSI IS-637 A: remove a useless variable
-
- Change-Id: I50077329d6e78ca39312e72eb04b7a5db85b977b
- Reviewed-on: https://code.wireshark.org/review/4301
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 95dc9a9
+commit d5f771c
Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Sep 25 23:11:34 2014 -0700
+Date: Mon Dec 8 11:40:35 2014 -0800
- Update a comment as per the previous commit.
+ Use correct expression in a "length too short" message.
- Change-Id: Ic7adba4302d4d4abff7012cf09d68246ebade922
- Reviewed-on: https://code.wireshark.org/review/4296
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 92a0cb8
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Sep 25 23:05:20 2014 -0700
-
- Renaming libtool* to glibtool* might require root permission.
-
- Define DO_MV as "mv" or "sudo mv", depending on whether the user has
- write access to /usr/local/bin, and use it to rename libtool* to
- glibtool* and vice versa.
+ Doesn't change the behavior of the code, but makes it more consistent.
- Change-Id: Ifbef4daa4521852bc200522743df9d23e7f0d1c2
- Reviewed-on: https://code.wireshark.org/review/4295
+ Change-Id: I6f07fbbb4c7d14d8a46ecfd1c419d951c356fd77
+ Reviewed-on: https://code.wireshark.org/review/5672
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 82d1a85
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Thu Sep 25 23:11:10 2014 +0200
-
- GTP: display SAC as BASE_HEX_DEC
-
- Bug: 10490
- Change-Id: I0afe1f2ff51f2452830bfc57210dc3a298b68cbf
- Reviewed-on: https://code.wireshark.org/review/4290
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit a26b751
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Thu Sep 25 22:40:00 2014 +0200
-
- CFM: display MEP ID in decimal in OAM Y.1731 Synthetic Loss Message and Reply PDU
-
- Bug: 10500
- Change-Id: I70dab8fb86965fedbe8739e265db81fe310518cf
- Reviewed-on: https://code.wireshark.org/review/4289
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit ea6fa04
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Sep 24 14:06:23 2014 -0700
-
- Update the simple dialog code.
-
- Rename simple_dialog_qt.{cpp,h} to simple_dialog.{cpp,h}. Make it a
- subclass of QMessageBox. Queue messages at startup similar to GTK+.
-
- Move the GTK+-specific simple_dialog declarations to
- gtk/simple_dialog.h.
-
- Don't yell at the user so much. Replace exclamation points with periods.
-
- Change-Id: I1cc771106222d5e06f1f52d67ac29d6dc367cce4
- Reviewed-on: https://code.wireshark.org/review/4288
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 2ee45fe
-Author: Roland Knall <roland.knall@br-automation.com>
-Date: Mon Sep 22 11:05:59 2014 +0200
-
- openSAFETY: Heuristic marks packet as truncated
-
- - There are cases, where the heuristic detection tries
- to access bytes, after a correct openSAFETY frame has
- been detected, leading to "Packet truncated" messages
- in the correct and complete detected packet
-
- Change-Id: Ie389edf82144283ad2c15f0bf975066de01e3409
- Reviewed-on: https://code.wireshark.org/review/4237
- Reviewed-by: Roland Knall <rknall@gmail.com>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 7c54eb2
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Thu Sep 25 17:48:26 2014 +0200
-
- ANSI IS-637 A: get rid of tvb_length() deprecated API
-
- Change-Id: I40de03605c051024c604679a1e141afa841a77e9
- Reviewed-on: https://code.wireshark.org/review/4287
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit e520b2b
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Thu Sep 25 15:21:11 2014 +0200
-
- ANSI IS-637-A: fix dissection of fragmented Unicode SMS
-
- The computation of the number of characters available was wrong when the User Data Header is present
-
- Change-Id: I2809c1460316530654a997b26cfc33c60a32fd6f
- Reviewed-on: https://code.wireshark.org/review/4284
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit db277bc
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Thu Sep 25 16:23:37 2014 +0100
-
- Freeze Info column while dissecting RRC transparent container
-
- Change-Id: I30900fd6a73ca38736b3f28eb416820f74003768
- Reviewed-on: https://code.wireshark.org/review/4285
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
-
-commit a5a8721
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Thu Sep 25 16:43:30 2014 +0200
+commit 0bd79c5
+Author: Hannes Mezger <hannes.mezger@ascolab.com>
+Date: Mon Dec 8 11:20:16 2014 +0100
- Add comments about new IEs
+ Fix full name of NodeId namespace index field, was a copy&pase error
- Change-Id: Ibc035872ff6406830a06bcfd365047a6d8c2478f
- Reviewed-on: https://code.wireshark.org/review/4283
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I7b1eea9965880e35c65f04406ff756d245b568d4
+ Reviewed-on: https://code.wireshark.org/review/5668
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 0fa7b01
+commit 52df6ef
Author: AndersBroman <anders.broman@ericsson.com>
-Date: Thu Sep 25 16:25:48 2014 +0200
+Date: Wed Dec 3 12:36:18 2014 +0100
- Add 3 new 3GPP AVP:s
+ Try to improve reassembly when SIP PDU starts in the middle of a segment
+ and continues trough the next segment(s).
- Change-Id: I47742f83a7e515f6fc449daf9492dcf8a5a68410
- Reviewed-on: https://code.wireshark.org/review/4282
+ Change-Id: I8efe69361fda0c60ec6544cc6bbe28c91f07207c
+ Reviewed-on: https://code.wireshark.org/review/5583
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 91d1c3c
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Sep 21 22:49:41 2014 -0400
-
- reassembly: fix when fragment cut off by snapshot
-
- Also add an assertion to tvb_generic_clone_offset_len so that it throws an
- error *before* allocating memory, as otherwise that memory is leaked.
-
- Bug: 10474
- Change-Id: I5036cefac16841914a59670c64979cf599bf7969
- Reviewed-on: https://code.wireshark.org/review/4234
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit d094eab
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Sep 25 01:15:29 2014 -0700
+commit f16376e
+Author: Maarten Bezemer <maarten.bezemer@gmail.com>
+Date: Thu Nov 27 15:09:52 2014 +0100
- The length of the pktap header isn't fixed, it's a field in the header.
+ Fix showing error dialog when calling vsimple_error_message_box()
- Don't assume that, once we've dissected the fields in the header we know
- about and skipped past them, that the payload follows immediately
- afterwards; use the header length from the header to find the payload.
+ SimpleDialog requires a parent, when none is provided (as there is no parent available during startup), the error message is queued and displayed after MainWindow is available.
+ Calling SimpleDialog::exec() directly returns if no parent is set (hence the dialog is not shown)
- Bug: 10502
- Change-Id: I645fe652240e0068d99cf00d19e3705615857d5b
- Reviewed-on: https://code.wireshark.org/review/4280
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit a87ea36
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Sep 25 00:48:43 2014 -0700
-
- Fix a record size check.
+ This resulted in silently ignoring error messages that were shown using vsimple_error_message_box(), as this function did not provide a parent (and the queue messages were not dequeued anymore as the MainWindow was already available)
- It was being checked against the wrong value, so some invalid records
- passed the check.
-
- Also, change one comparison (rec_size is in the range [0, 65535], even
- though it's in an int, so we can safely cast it to guint) and fix the
- metadata length value when reading Ethernet packets.
-
- Bug: 10495
- Change-Id: I2ce5c93fe50d836ec0accfcdef31654ba6b5b7c7
- Reviewed-on: https://code.wireshark.org/review/4278
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 38ae61f
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Sep 24 20:32:26 2014 -0700
-
- radcom_read_rec() should always read from the file specified by the fh argument.
-
- It's called both from the read and seek-read routines, so it shouldn't
- always read from the sequential handle.
-
- Change-Id: I8cb33b9f5b7219f335b0aeeef29c479916276f89
- Reviewed-on: https://code.wireshark.org/review/4276
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I2f4c1b4926c196ab40b035161cec530105396537
+ Reviewed-on: https://code.wireshark.org/review/5519
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 42018cf
-Author: Evan Huus <eapache@gmail.com>
-Date: Wed Sep 24 09:07:50 2014 -0400
+commit e172ebb
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 29 15:58:56 2014 -0500
- pcapng: respect the fact that wblock->data is a union
+ Add proto_tree_add_bitmask_with_flags.
- Make sure to zero the *entire* thing, and only access it as a given type when
- that's the type indicated by the (non-union) type field.
+ It's proto_tree_add_bitmask with the ability to control the data appended to header.
- Bug: 10498
- Change-Id: I3e94a9c5d399d3ee4aedcd49f1aa2d7678ecf7ce
- Reviewed-on: https://code.wireshark.org/review/4273
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Icce97437ba7cfc9158ec204a837da8db8138424a
+ Reviewed-on: https://code.wireshark.org/review/5533
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit a1604bd
-Author: Alex Badea <abadea@ixiacom.com>
-Date: Wed Sep 17 14:40:48 2014 +0300
+commit 75cdf92
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Fri Dec 5 09:02:37 2014 +0100
- test: add decryption test for isakmp with certificates
+ 802.11: fix indent (use 2 spaces) and modelines for 802.11 h file
- This was suggested in review 2297. Capture and key are from bug 7951.
-
- Bug: 7951
- Change-Id: I820c5e839b20ec464cc1be438633d5311f657fb2
- Signed-off-by: Alex Badea <abadea@ixiacom.com>
- Reviewed-on: https://code.wireshark.org/review/4143
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: If886809d9eeb900bb94c045413ff1295519b8311
+ Reviewed-on: https://code.wireshark.org/review/5641
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 4652f95
-Author: Gilles Roudiere <gilles@roudiere.net>
-Date: Mon Sep 22 19:42:59 2014 +0200
+commit f47bc26
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Nov 25 12:23:52 2014 +0100
- Added a new DSR dissector
+ CAPWAP: Add some IEE802.11 Message Element Type (RFC5416)
- Added a new dissector for the Dynamic Source Routing (DSR) protocol (RFC 4728)
- It should correctly dissect all DSR packets, including the "Flow State
- Extension" DSR packets.
+ * IEEE 802.11 Antenna (1025)
+ * IEEE 802.11 Direct Sequence Control (1028)
+ * IEEE 802.11 MAC Operation (1030)
+ * IEEE 802.11 MIC Countermeasures (1031)
+ * IEEE 802.11 Multi-Domain Capability (1032)
+ * IEEE 802.11 Station (1036)
+ * IEEE 802.11 Supported Rates (1040)
+ * IEEE 802.11 Tx Power (1041)
+ * IEEE 802.11 Tx Power Level (1042)
+ * IEEE 802.11 WTP Radio Configuration (1046)
- See Bug #10499 for capture file
+ Enhance 802.11 Rate Set (1034)
- Change-Id: Ie33a1a2fe095cab19d5abfbfa8e1c79fec664a35
- Reviewed-on: https://code.wireshark.org/review/4251
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: Ib37bc4081e75af051d80d023ddba689ecd9bf9ff
+ Reviewed-on: https://code.wireshark.org/review/5481
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 8fc2327
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 23 16:39:52 2014 -0700
+commit 58b7277
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Fri Dec 5 09:00:13 2014 +0100
- Qt: Fix preference bugs.
-
- Make sure we set the "resolved" member of the column fmt_data struct.
+ 802.11: Add ieee80211_supported_rates_vals_ext to be exported
- Emitting WiresharkApplication::AppSignals from a modal dialog can cause
- event loop problems on OS X. Queue them up in PreferencesDialog and emit
- them after closing.
+ It will be reused by CAPWAP dissector (* Rates Message Element)
- Change-Id: I2de77778a0448db3b87d402e431b8e5f325cbbda
- Reviewed-on: https://code.wireshark.org/review/4274
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit ffe30fb
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Tue Sep 23 18:05:56 2014 +0100
-
- Allow the HandoverPreparationInfoPDU dissector to be looked up by name and called.
-
- Change-Id: I9c22b74d5c3329b6c7d74547d26e940c84ffc66c
- Reviewed-on: https://code.wireshark.org/review/4247
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I60ce12f382a35cdc2747baf23e2e3c30a305a8bd
+ Reviewed-on: https://code.wireshark.org/review/5640
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 5f096ac
+commit 212ba58
Author: Guy Harris <guy@alum.mit.edu>
-Date: Tue Sep 23 17:09:46 2014 -0700
+Date: Sun Dec 7 12:17:48 2014 -0800
- Fix presumed cut-and-pasteo.
-
- On errors *other* than a short read, we were driving on and processing
- the non-data that we didn't read.
+ Add checks for non-null-terminated strings.
- Change-Id: I6289ddf31ff7896918a030af9d1261bdc194e7d3
- Reviewed-on: https://code.wireshark.org/review/4270
+ Change-Id: Iaad2d2f76e5d554800ba2c79d5c01f4b9da6fa0b
+ Reviewed-on: https://code.wireshark.org/review/5660
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 31e8699
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 23 13:35:10 2014 -0700
-
- Qt: Add zoom and column resize actions.
-
- Plumb signals and slots for changing the text size in the main window.
- Remove the bold font code from WiresharkApplication. It was only used in
- ByteViewText. Adjust the icons a bit.
-
- Bug: When we change the font preferences the packet list stops drawing
- cached strings. I haven't been able to track down the cause.
-
- Change-Id: I609d740c9f26265628fa4b7de1b75b0e56651387
- Reviewed-on: https://code.wireshark.org/review/4269
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 3a85a5e
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Sep 23 17:02:13 2014 +0200
-
- Add decoding of part of access network identifier option
- fixes Bug 10492.
-
- Change-Id: Ib01f457b74825e6c2a7aa1dc1d0f43ff4b104dea
- Reviewed-on: https://code.wireshark.org/review/4267
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 717ff08
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Sep 22 16:33:05 2014 -0700
-
- Qt: Add the colorization action.
-
- Change-Id: I846a48c35c4ef3bbbcf17d03885acc5be8c9a6b5
- Reviewed-on: https://code.wireshark.org/review/4259
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit ad6a663
-Author: Evan Huus <eapache@gmail.com>
-Date: Tue Sep 23 00:26:28 2014 -0400
-
- pcapng: ensure the values we now free are initialized
-
- Should fix the remaining test suite failures.
-
- Change-Id: I50a6cb1bf57bd6a973d4777349708b75aeb41620
- Reviewed-on: https://code.wireshark.org/review/4264
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 7255380
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Sep 22 20:31:31 2014 -0700
-
- Try to fix dist.
-
- Change-Id: I73d269c67a0ad5bb6f67fef8da5fc4ca86f169e3
- Reviewed-on: https://code.wireshark.org/review/4263
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit d3cd4c4
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Sep 22 09:59:02 2014 -0700
-
- Qt: Re-enable menu icons.
-
- The GNOME HIG says "Where a corresponding toolbar icon exists, a menu
- icon should mirror its design." The Windows and OS X HIGs say that you
- should use them for common or familiar actions but otherwise avoid
- clutter. I think icons in the "File" menu look like crap. Try to strike
- a balance.
-
- Use the 16x16 application icon for both the main web site and the wiki
- since that's the favicon used on both sites.
-
- Assume that "Reload" isn't used very often and remove it from the
- toolbar.
-
- Don't use a menu icon for the about box.
-
- Other minor fixups.
-
- Change-Id: I855211c218d266c2e9ed5acbe05a08750ab6d157
- Reviewed-on: https://code.wireshark.org/review/4246
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit be32460
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 22 18:37:50 2014 -0700
+commit 5f79940
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Fri Dec 5 07:56:36 2014 +0100
- Make peekclassic_read_packet_v56() more like the _v7 version.
-
- We can't use wtap_file_read_expected_bytes() in the _v7 version, as that
- version returns an int, not a Boolean; just expand
- wtap_file_read_expected_bytes() in the _v56 version, to make it look
- similar to the _v7 version.
+ Endpoint: wrong filter when select a SCTP endpoint (INVALID == a.x.y.z ...)
- Change-Id: Id907bac265c123ad5821591c1cf081b5747724d8
- Reviewed-on: https://code.wireshark.org/review/4262
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I396e9af7971ee8be6fc9548162ff37fe704f0289
+ Reviewed-on: https://code.wireshark.org/review/5651
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit e543818
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 22 18:13:59 2014 -0700
+commit 42cdc2b
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sun Dec 7 19:51:16 2014 +0100
- Remove misuse of wtap_file_read_expected_bytes().
-
- wtap_file_read_expected_bytes() is a macro that can return a Boolean
- FALSE; it should not be used in routines that don't return a Boolean.
-
- In addition, both EOF *and* a short read, in that routine, should be
- treated as a "not an IPFIX file" indication.
-
- While we're at it, a seek failure should be treated as an error.
+ dcerpc: Missing break in switch (CID 280449 & 280450 & 284051)
- Change-Id: I97815bc9e78169ded567b60835cc7bcf6a0e6f0c
- Reviewed-on: https://code.wireshark.org/review/4261
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I68fa9650c234c0f1fb8464b464a781b54f2c728c
+ Reviewed-on: https://code.wireshark.org/review/5657
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 6ebffcc
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 22 17:59:39 2014 -0700
+commit 9d8cb74
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sun Dec 7 19:48:17 2014 +0100
- Make sure the option string pointers are set before freeing them.
+ iec104: Missing break in switch (CID 280459)
- Change-Id: If86327a02e4fac7d3ed2d02b2a0c95906209dea0
- Reviewed-on: https://code.wireshark.org/review/4260
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I6abc157368a78e1abfde672728b88a36ba6e76cc
+ Reviewed-on: https://code.wireshark.org/review/5656
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit bd43331
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Sep 22 19:06:12 2014 -0400
+commit fd087fb
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sun Dec 7 19:46:53 2014 +0100
- packet-openflow_v1.c: Rename "Padding" fields & filter-names to be consistent with those in packet-openflow_v5.c
+ AFS: Missing break in switch (CID 280434 & 280435)
- Change-Id: Idd78b49cad86db6f63b4f14edbf4d954120665e3
- Also: remove some commented-out "Padding" hf[] entries.
- Reviewed-on: https://code.wireshark.org/review/4257
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: Ia0a39f7e4670d74325ddc40b34cd56ca018c0bde
+ Reviewed-on: https://code.wireshark.org/review/5655
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 4c3655e
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Sep 22 18:36:27 2014 -0400
+commit a68a3da
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Sun Dec 7 19:36:32 2014 +0100
- packet-openflow_v1.c: Fix a bug in dissection of openflow_features_reply_v1
-
- Fixes Bug #10493
+ make our counting a bit clearer
- Change-Id: Ia330a7b087ea184865fc437d77ee6ca57b1f2e44
- Reviewed-on: https://code.wireshark.org/review/4256
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: Ie64573f5a0b6e921a5011e487eea8e55f72b9a0b
+ Reviewed-on: https://code.wireshark.org/review/5653
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 02d50a5
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Sep 22 16:55:32 2014 -0400
+commit e456dec
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Sun Dec 7 19:27:57 2014 +0100
- Ensure pcapng application name is dynamically allocated
+ don't initialize variables if the first thing we do is assign a
+ different value to them
- I was hasty with my original fix...
-
- Change-Id: I339994c1afc34274a5d73eff98c4ebbf030e0f36
- Reviewed-on: https://code.wireshark.org/review/4255
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I719db9180b2ba5f21653086f2697ca9bac68d6b1
+ Reviewed-on: https://code.wireshark.org/review/5652
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit df35a95
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Sep 22 16:53:02 2014 -0400
+commit ade2bef
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Sat Dec 6 18:28:37 2014 +0100
- Ensure pcapng application name is always dynamically allocated
+ make sure that we don't read past the end of the compressed buffer
- Change-Id: I408944dfb0fa35bae6019ed0d6d810525b2ffcae
- Reviewed-on: https://code.wireshark.org/review/4254
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Bug: 10757
+ Change-Id: I30054c4a75ec86ea603cf78b702be5255c35f549
+ Reviewed-on: https://code.wireshark.org/review/5642
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 1db95f7
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Sep 22 07:43:14 2014 -0400
+commit 1bc8791
+Author: Michael Mann <mmann78@netscape.net>
+Date: Fri Dec 5 19:42:47 2014 -0500
- pcapng: don't leak block option strings
-
- I *think* I got all the cases; I got most of them, at any rate, and enough to
- shut up valgrind in all the test cases I ran.
+ Eliminate proto_tree_add_text from packet-telnet.c
- Change-Id: I393bac0756f577b65e400b792f6719fa6ec4056a
- Reviewed-on: https://code.wireshark.org/review/4244
+ Change-Id: I0e8610f381e650f2c5b3f78ea927b727ec9ac62a
+ Reviewed-on: https://code.wireshark.org/review/5637
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit ec5915a
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 22 11:53:34 2014 -0700
-
- Make style more consistent.
-
- Change-Id: I4ba40504d8cc308f7c13b465fcfaa9ff5eeebcf2
- Reviewed-on: https://code.wireshark.org/review/4252
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 72805be
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 22 11:50:02 2014 -0700
- Consistently use tab indentation.
-
- (If somebody wants to convert the entire file to 4-space indentation, go
- ahead.)
-
- Change-Id: I1e3829289ac67db79eea2eb16e6a4ba40c449a8d
- Reviewed-on: https://code.wireshark.org/review/4250
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 05d1f60
+commit afa5558
Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Sep 22 11:10:06 2014 -0700
+Date: Sun Dec 7 08:05:11 2014 -0800
- Fix dist.
+ [Automatic manuf, services and enterprise-numbers update for 2014-12-07]
- Change-Id: I68963f000dc927398d7d41193674e55050e7c634
- Reviewed-on: https://code.wireshark.org/review/4248
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 2474af6
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Sep 21 13:28:29 2014 -0700
-
- Qt: Use wsiconcap while we're capturing.
-
- Set the main window icon to the "wsiconcap" version while we're capturing
- similar to the GTK+ version. Verified on Windows. Not sure if this will
- do anything on other platforms.
-
- Change-Id: I9b082601a2c47e5f52cc38ac8d9b4d9f5fb9a4d9
- Reviewed-on: https://code.wireshark.org/review/4230
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: Ice8195b09120fb21144e504289a64fd5af84775b
+ Reviewed-on: https://code.wireshark.org/review/5647
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 19d55ca
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Sep 22 10:26:33 2014 -0400
-
- fix-encoding-args.pl: Don't use a feature available only starting with perl 5.14
-
- Specifically: Window msys git uses an earlier version of Perl (5.8) and thus
- invoking fix-encoding-args.pl in the pre-commit hook script
- gives a Perl syntax error.
-
- See https://code.wireshark.org/review/4172 for details
-
- (Also see following for Perl info:
- http://www.perl.com/pub/2011/05/new-features-of-perl-514-non-destructive-substitution.html)
-
- Change-Id: I95a222eaa31942cc6e873ffbde57c5fa5bd2a625
- Reviewed-on: https://code.wireshark.org/review/4245
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit aac1cb2
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Fri Aug 29 10:43:31 2014 +0200
-
- Bluetooth: Handle LE ACL session
-
- Low Energy use LE Meta event for creating connection so add session
- when it occur.
-
- Change-Id: I6fad42651a3dc6a45cfb1cf679660de5955e76b0
- Reviewed-on: https://code.wireshark.org/review/4168
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit eab7961
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Tue Aug 26 12:29:49 2014 +0200
-
- extcap: Always create extcap/ dir in run/
-
- Change-Id: I5d0a2591b9086a138cefb0019f710ffb34a34c52
- Reviewed-on: https://code.wireshark.org/review/3876
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 56a09d2
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Wed Jul 23 12:26:05 2014 +0200
-
- Try to fix some buildbot warnings
-
- Most interesting are:
- warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
- warning: ISO C forbids zero-size array [-Wpedantic]
- warning: ISO C90 doesn't support unnamed structs/unions [-Wpedantic]
- warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wcast-qual
- warning: initializer element is not computable at load time [enabled by default]
-
- Change-Id: I5573c6bdca856a304877d9bef643f8c0fa93cdaf
- Reviewed-on: https://code.wireshark.org/review/3174
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit c1d6a41
+commit de61f06
Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 22 03:47:24 2014 -0700
+Date: Sat Dec 6 15:59:07 2014 -0800
- Clean up reading code.
-
- The only place where a short read should be treated as an EOF is if the
- read of the block header reads 0 bytes. All other short reads,
- including reads of the block header returning at least 1 byte but not
- enough for a complete block header, and any reads of the stuff
- *following* the block header even if they return 0 bytes, should be
- treated as "short read" errors.
-
- If the option length is bigger than the option buffer size, treat that
- as a bad file (I'm not sure that can happen, so maybe it should be
- treated as an internal error instead).
-
- Use file_skip() rather than file_seek() when skipping forward N bytes.
- If it fails, treat that as an error under all circumstances.
-
- When reading the first section header block in the open routine, have
- pcap_read_block() return -2 if it doesn't look like an SHB (too short,
- wrong block type, bad block length, unknown byte-order magic number), as
- that means the file isn't a pcap-ng file and the open should return 0.
-
- Return -1, not 0, for all errors in various block-reading routines.
-
- file_seek() returning 0 is *not* an error. file_seek() returning -1 (or
- any other negative number *is* an error; its return value is signed, so
- don't assign it to an unsigned variable.
+ The packet encapsulation is in pkt_encap, not rec_type.
- This might fix the test errors for the Lua file format handler tests.
+ rec_type is the type of record (which isn't necessarily a packet; future
+ work on libwiretap will let it return non-packet data); if it's a packet
+ (REC_TYPE_PACKET), then pkt_encap contains the "link-layer"
+ encapsulation for the packet (in quotes because it may contain metadata
+ not transmitted over the network).
- Change-Id: Ifa7d9834c38bf238461c9cc9625a2aa761cb6ff2
- Reviewed-on: https://code.wireshark.org/review/4238
+ Change-Id: I6f32b02f4466df6d7b07dbdc9d77e881830ac749
+ Reviewed-on: https://code.wireshark.org/review/5645
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit a886f8f
-Author: Wasim Abu Moch <wasim@mellanox.com>
-Date: Wed Sep 17 19:14:52 2014 +0300
-
- packet-infiniband: added support for RoCE-v2 (RRocE)
-
- Added support for the new Routable RDMA over Converged Ethernet.
- (NEW PATCH)
-
- Change-Id: I857a27c4f29cc78fcea8efa113e3c7e968eb041b
- Reviewed-on: https://code.wireshark.org/review/4156
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit b8065a5
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Sep 21 22:10:33 2014 -0400
-
- dcerpc: correctly initialize certain struct fields
-
- Bug: 10482
- Change-Id: I4d39d6a79d4ab89685a17a0c622c6181e4fada3d
- Reviewed-on: https://code.wireshark.org/review/4233
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit e483772
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Sun Sep 21 21:36:14 2014 -0400
-
- Fix up formatting (bring function names over to column 0).
-
- Change-Id: I054f3ec13fd5907c8f1e0546292777a5596fc029
- Reviewed-on: https://code.wireshark.org/review/4232
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit a1840c2
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Sep 21 21:01:51 2014 +0200
-
- Fix dissection of 7 bits ASCII/GSM strings when the bit offset is not byte aligned
-
- Bug: 10491
- Change-Id: Ib55d83b7739050ba5afd84e8184af3c4608d5776
- Reviewed-on: https://code.wireshark.org/review/4228
- Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 5d1aafb
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Sep 20 19:27:24 2014 -0700
-
- Qt: Multi-state capture start icon.
-
- Add ".on" versions of the x-capture-start icon along with corresponding
- code in the StockIcon constructor to look for ".on" variants and add
- them with the QIcon::On state.
-
- Make the plain versions of x-capture-start blue to match the general
- application icon. The goal is to make the toolbar and app icon fins blue
- when Wireshark is "at rest" and green when it's capturing.
-
- Change-Id: I31f4f9d910fc99c41d7c63bd9a722db1611760c7
- Reviewed-on: https://code.wireshark.org/review/4225
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit e1a420a
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Sep 21 08:05:28 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-09-21]
-
- Change-Id: I1057fe3657c400a6a0b10a67a7e2451d1266bf44
- Reviewed-on: https://code.wireshark.org/review/4222
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 1952d95
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Sep 20 14:49:25 2014 -0700
+commit 22da8a3
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Dec 6 16:21:07 2014 -0500
- CMake: Add conditional builds.
-
- In my version of XCode ranlib complains bitterly and returns an error if
- a module has no symbols. Make the AirPcap, RTP player, and remote
- capture code conditional. We could also try passing
- "-no_warning_for_no_symbols" to ranlib but we probably shouldn't try to
- comple the code in the first place.
+ Remove annex_a_used from packet_info structure.
- Change-Id: Ide4f3d649eac354d54f0dde27dbc8e9cb270c65f
- Reviewed-on: https://code.wireshark.org/review/4220
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I660caa8283aecff5060c6ed476f316bc5793373e
+ Reviewed-on: https://code.wireshark.org/review/5643
+ Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
-commit 5e231d1
+commit 6d4c0ed
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 15:51:10 2014 -0700
+Date: Fri Dec 5 20:53:39 2014 -0800
- Fix wslua_filehandler_open() to work as wiretap open routines should.
+ Don't go past the end of the "extra data".
- They should return 1 on success, -1 on error, and 0 if there was no
- error but the file isn't one of the type for the routine. They must not
- return any other value. If they return -1, they must set *err.
+ The "extra data", according to the RF5 API manual I have, is "hardware
+ parameters", so change some names.
- Change-Id: I0f1e1675b4cc8f0214ad67a23de0e4ecb09cabea
- Reviewed-on: https://code.wireshark.org/review/4221
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 8605bbf
-Author: Michael Mann <mmann78@netscape.net>
-Date: Sat Sep 20 18:11:05 2014 -0400
-
- Restore the inclusion of request.cnf.c and response.cnf.c in the generated DCE/RPC MAPI dissector.
+ Report an error if the variable parts of the configuration event record
+ run past the record length.
- Also remove the use of proto_tree_add_text for something filterable.
+ Report an error if the hardware parameters are too short.
- Change-Id: I7c252fb24f5ab51e4d1913fe3b0e520a4150baec
- Reviewed-on: https://code.wireshark.org/review/4214
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit be7f053
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 13:18:53 2014 -0700
-
- Report (and free) err_info for WTAP_ERR_DECOMPRESS.
+ For the purportedly DS0 hardware parameters, don't assume they'll be
+ long enough for the mask; they might not be.
- Change-Id: I61ecc58be4b0688c43df0b0f006fb899bdc1721c
- Reviewed-on: https://code.wireshark.org/review/4216
+ Change-Id: Ib63d042e4ede32216fb474c4ecdba84db1387abc
+ Reviewed-on: https://code.wireshark.org/review/5638
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit e419ea8
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Sep 20 13:10:48 2014 -0700
-
- Qt: Update the x-capture-file-close icon.
-
- Change-Id: I9ea4fe42ccdbc85c8c3f22a426b6e08d595a7460
- Reviewed-on: https://code.wireshark.org/review/4215
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 047bd36
+commit 8c190d6
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Sep 20 18:32:17 2014 +0200
+Date: Wed Dec 3 16:39:58 2014 +0100
- PIDL: fix trailing tabspace
+ RPKI-RTR: Missing break in switch (CID 1233099)
- Change-Id: If3b623d82d6bbbf9943a35c8885620881eedb091
- Reviewed-on: https://code.wireshark.org/review/4204
+ Change-Id: I01f01ce51fb1c9deb857ef01696b406b97dca3a9
+ Reviewed-on: https://code.wireshark.org/review/5616
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 8576e1c
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Sep 18 14:09:55 2014 -0700
-
- Qt: Add stock icons.
-
- The new icons are patterned after the existing capture icons. They could
- probably benefit from some adjustments here and there.
-
- Start moving toward icon names and a directory layout compliant with
- freedesktop.org's Icon Naming Specification and Icon Theme
- Specification. We aren't fully compliant and might never be but anyone
- with exposure to FDO icon themes should at least know where everything
- is.
-
- Make Capture Start (x-capture-start) the first icon in the toolbar.
-
- Define the Colorize Packets, Auto Scroll, and zoom icons even though the
- Qt UI doesn't use them yet.
-
- Leave the Capture Filter, Display Filter, Coloring Rules, Preferences,
- and Help icons off for now. The GTK+ toolbar is overly cluttered and I'm
- not sure they're necessary.
-
- Try not to break ui/gtk/toolbar_icons.h.
-
- Remove welcome.qrc. I initially added it in case we needed to overlay
- the welcome screen with translucent .pngs but that never happened.
-
- To do:
-
- - Move the old GTK+ icons to their own directory.
-
- - Find a better name for the "toolbar" directory. "stock"?
-
- - Make the toolbar configurable.
-
- Change-Id: Ie07592113d307b8db786aedace672312a870fe38
- Reviewed-on: https://code.wireshark.org/review/4182
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 801824b
+commit 646d52e
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 27 21:50:14 2014 +0200
+Date: Wed Dec 3 16:48:48 2014 +0100
- Add .travis.yml for Travis CI (for Github user...)
+ PCEP: Missing break in switch (CID 1247685)
- 4 jobs
- * autotools / gcc
- * autotools / clang
- * cmake / gcc
- * cmake / clang
-
- Change-Id: Ifc5b079415232b77680c87b2dee441566e08c835
- Reviewed-on: https://code.wireshark.org/review/3944
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: Id001a6c1e116fdabfd51c354832ca68f50e65e7d
+ Reviewed-on: https://code.wireshark.org/review/5618
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 29d9114
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 12:16:15 2014 -0700
+commit a5fe0d4
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Thu Dec 4 10:57:16 2014 +0100
- Make load_cap_file() just return a success/fail indication.
-
- We don't care *why* it fails; it's printed a message to indicate that.
- Just have it indicate whether it succeeded or not.
+ BT obex: Missing break in switch (CID 1132031)
- Change-Id: I98160999baa5f25ea03ef803b7dbf77dff1518de
- Reviewed-on: https://code.wireshark.org/review/4213
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I6b8fc8db006bc3b8f8f4bac019cb7e240931d3b5
+ Reviewed-on: https://code.wireshark.org/review/5619
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 22a0d65
+commit bb00570
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 12:06:58 2014 -0700
+Date: Fri Dec 5 15:46:58 2014 -0800
- Free err_info on WTAP_ERR_DECOMPRESS.
+ Fix some copy-and-pasteos in error messages.
- Change-Id: I57fbb17baf43b0f1365fef72778ac0e65935456a
- Reviewed-on: https://code.wireshark.org/review/4210
+ Change-Id: I1fe3434e69a08aae3d7413067275b3d7ee1552f5
+ Reviewed-on: https://code.wireshark.org/review/5634
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 10b33c0
+commit 4510306
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 11:53:51 2014 -0700
+Date: Fri Dec 5 13:14:31 2014 -0800
- Remove file_error() calls after pcap_read_block() calls.
+ Get rid of a trailing blank.
- pcap_read_block() takes err and err_info arguments, and sets them on
- error; no need to call file_error() if pcap_read_block() fails.
-
- Change-Id: I33b96d31395bf7d66abdecbebd5cf775e8662004
- Reviewed-on: https://code.wireshark.org/review/4209
+ Change-Id: I0cf6d04f5075ba1f064c40f4b39b32b6976b54c7
+ Reviewed-on: https://code.wireshark.org/review/5633
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 32c38a4
+commit b98c570
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 11:30:57 2014 -0700
+Date: Fri Dec 5 13:04:59 2014 -0800
- Add file_error() calls after file_read().
+ Fix varargs handling in col_{add,append}_lstr().
- If file_read() doesn't return the exact number of bytes you asked for,
- and you really need all those bytes to be there, you have to call
- file_error() to find out what the problem is.
+ We do multiple va_start() calls using the first string in the list of
+ strings; do *not* use the first-string argument to iterate over all the
+ argument strings, as that means that only the first va_start() call will
+ do the right thing, use a separate variable.
- Change-Id: I4cc87bc1b6cc5a49bbcbf93b56106f57af290d20
- Reviewed-on: https://code.wireshark.org/review/4205
+ Bug: 10755
+ Change-Id: Ic4a6c24f911e335d147883a25d30289628836875
+ Reviewed-on: https://code.wireshark.org/review/5630
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 2cd9784
+commit 18fabb4
Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Sep 18 16:19:33 2014 -0400
+Date: Tue Dec 2 09:40:46 2014 -0500
- Fix sizing of qtshark based on the saved (recent) geometry.
+ Strengthen association matching when we haven't seen the INIT/INIT-ACK.
- Do this by emitting the StaticRecentFilesRead signal after reading the static
- portion of the recent file.
+ The fact that the vtag matches the initiate tag doesn't mean much if both are 0
+ (uninitialized).
- Unfortunately this results in the main window appearing in one size and
- then resizing to the saved size but I haven't figured out how to fix that yet.
- At the very least this prevents qtshark's default geometry from being saved to
- my recent file and affecting wireshark-gtk's geometry.
+ Also leave in some (commented-out) debug to make debugging this stuff easier
+ in the future.
- Change-Id: I47b66078a9d00cb321badc744f1337ff39ca42a7
- Reviewed-on: https://code.wireshark.org/review/4177
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 845e5e5
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Sep 18 22:15:39 2014 +0200
-
- Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: I5bfbfc03795cd8ba3cd102d2249672ce3e48bc5f
- Reviewed-on: https://code.wireshark.org/review/4179
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Id007de8bf9d2d4e0bb18309ed3e2572fedda45f1
+ Reviewed-on: https://code.wireshark.org/review/5571
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 846a933
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Fri Aug 22 15:33:17 2014 +0200
+commit 0867344
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Thu Dec 4 16:59:43 2014 -0700
- Bluetooth: HCI: Add support for user/vendor commands
+ Look for python3 in addition to python in configure script.
- Some Vendors can provide own subset of HCI commands/events, so provide them
- possibility to write own dissectors and use them by "Decode As".
-
- Change-Id: I87ff60ae12ac63ddd4b12b26951aa9f5143eabc6
- Reviewed-on: https://code.wireshark.org/review/4166
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I77ff22aabdbbbf7376483b53d8795e7fbf0c0433
+ Reviewed-on: https://code.wireshark.org/review/5627
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit 3623fce
-Author: Josip Medved <jmedved@jmedved.com>
-Date: Wed Sep 17 22:47:45 2014 -0700
+commit d5a4cc3
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Thu Dec 4 13:15:41 2014 -0700
- Added Wx Application-Id.
+ Make autogen.sh look for "python3" if "python" isn't found before
+ giving up.
- Change-Id: I46152382be0a374019d51f18e7116aad8241e95a
- Reviewed-on: https://code.wireshark.org/review/4162
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Id109c78f90da71c54c7b4fd6df20cc153248f46f
+ Reviewed-on: https://code.wireshark.org/review/5623
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit ba8617f
-Author: kardam <netkardam@gmail.com>
-Date: Sun Sep 14 03:01:05 2014 +0200
-
- Add -I option in editcap to extend Duplicate packet removal
- Description:
- Ignore the specified bytes number at the beginning of the frame during MD5 hash calculation.
- Useful to remove duplicated packets taken on several routers or SW(differents mac addresses for example).
- e.g. -I 26 in case of Ether/IP/ will ignore ether(14) and IP header(20 - 4(src ip) - 4(dst ip)).
- The default value is 0.
- This option is only relevant when used with -d|-D|-w
-
- Bug: 8511
- Change-Id: I009a09d32778a182b2d88f372651f658a4938882
- Reviewed-on: https://code.wireshark.org/review/4104
- Tested-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 2154e23
-Author: Evan Huus <eapache@gmail.com>
-Date: Tue Sep 16 21:34:37 2014 +0000
+commit 3b7c165
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Thu Dec 4 22:49:42 2014 +0100
- ssl: allocate regexes with glib
-
- they're stored in a static variable so we only ever need compile them once and
- they can just hang around forever
+ use the same data types as in i2c_phdr
- Change-Id: Icf43745ad80f4984443a67af21c979625363fc6f
- Ping-Bug: 10474
- Reviewed-on: https://code.wireshark.org/review/4139
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Ic0abcf8173a690a1dc0cd250f5e8770eb92a5aa9
+ Reviewed-on: https://code.wireshark.org/review/5626
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 3c55419
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 10:45:28 2014 -0700
+commit 5d95067
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Thu Dec 4 22:38:16 2014 +0100
- Set err_info if the attempts to read record headers fail.
+ simplify dissect_i2c()
- If it fails due to, for example, the file being gzipped and having a bad
- gzip CRC, the error returned is WTAP_ERR_DECOMPRESS and, for that error,
- err_info is expected to be set to a string giving details of the
- problem, so we need to pass back to our caller the string in question.
-
- Bug: 10484
- Change-Id: I3aa2a92d04fcc08946ff073a40efa708079bbb3e
- Reviewed-on: https://code.wireshark.org/review/4201
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I67dd6ae5dc48b297e5c04aba2fe53e3e159d2611
+ Reviewed-on: https://code.wireshark.org/review/5625
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 06237e4
-Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Sep 19 22:23:27 2014 -0400
+commit 73f48a0
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Thu Dec 4 22:25:39 2014 +0100
- proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors.
+ dont't manually throw a ReportedBoundsError if the packet is empty
+ use tvb_captured_length() instead of tvb_length()
- Change-Id: I84755d059ef70ca98b0e7626b6425360daf0529d
- Reviewed-on: https://code.wireshark.org/review/4199
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: I7e7efd69515fc3e30c986ac5d9a56b4db1931c10
+ Reviewed-on: https://code.wireshark.org/review/5624
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 1e47e05
+commit 70ca52c
Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Thu Sep 18 07:20:01 2014 +0200
+Date: Thu Dec 4 14:38:35 2014 +0100
- 6LoWPAN: fix encapsulating address decoding when a Mesh header is present
+ 3GPP: upgrade 2G/3G NAS dissector to v12.7.0 and NAS EPS dissector to v12.6.0
- Bug: 10462
- Change-Id: I37d532edc41193123b1a7bb380d48cb76c118bf4
- Reviewed-on: https://code.wireshark.org/review/4161
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I1e5bc5d28cb956b333c302b1cb18335b59d096a8
+ Reviewed-on: https://code.wireshark.org/review/5621
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 6f16f26
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 20 02:15:44 2014 -0700
- The Shomiti document is available on the Wayback Machine.
-
- I don't know why it was unavailable at some point, but it appears to be
- available again. Update the comment to reflect that.
-
- Change-Id: I7dc1fcb554e73d3b0fc2bd2fbdf6235e791a4253
- Reviewed-on: https://code.wireshark.org/review/4200
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 4fd89b0
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Mon Sep 1 15:45:49 2014 +0200
+commit ab3c182
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Thu Dec 4 09:54:08 2014 -0500
- Logcat: Fix crashes when try to use logcat_text open routine on binary file
+ There's no need to talk about update-alternatives here.
- Change-Id: Ied0778af9d5ff0e49c6efd4ea9411ae1a72cb8e5
- Reviewed-on: https://code.wireshark.org/review/4190
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit e489df5
-Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Sep 18 22:40:49 2014 -0400
-
- Don't assert that values fit in 32 bits if the NDR64 flag is set.
+ Our "make install" process does nothing with 'alternatives'. Our RPMs do use
+ alternatives but they do the necessary update-alternatives stuff already.
- For now, this just pacifies fuzz-testing. If real world examples have this, there needs to be a drastic overhaul to support fields that could be either 32 or 64-bit values.
+ (If someone wants to set up Linux "make install"s to use alternatives it would
+ make sense to put these notes to the user back in.)
- Bug:9329
- Change-Id: I3e28808ca0291868a5f84258b0ee1e2a922703c2
- Reviewed-on: https://code.wireshark.org/review/4189
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: Ib7f4655a222ccaee83830a97b213656856cee73e
+ Reviewed-on: https://code.wireshark.org/review/5622
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 9fce9ba
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Tue Aug 26 15:37:00 2014 +0200
+commit b2fcbb2
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Wed Dec 3 22:12:52 2014 -0500
- Bluetooth: ACL/AVDTP: Fix ACL session handling
+ Add a MIME type for Tektronix rf5 files and register Wireshark for that type of
+ file.
- In case like reusing "connection handle" number in next connection
- (2 -> 3 -> 2 again) AVDTP dissector does not properly dissected packets
- (it should be Signal, but dissect as Media).
+ The magic matching comes from wiretap/k12.c.
- Add expert error to all packets that are not in ACL connection. This will
- show invalid packages (send after dissconnect), however incomplete
- (mostly beginning) connection will be marked too, but I think it have more
- pros than cons.
+ (Yes, I just made the application/x-tektronix-rf5 MIME type up.)
- Change-Id: I29cf706600cb12c8b93d0188dd2fba18dd5eba88
- Reviewed-on: https://code.wireshark.org/review/4167
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit cbe7741
-Author: Gerald Combs <gerald@zing.org>
-Date: Fri Sep 19 08:44:58 2014 -0700
-
- Update the documentation to use "Wireshark.pro".
-
- Change-Id: I024a882030e489cbd273a4245b0cd3be656f060f
- Reviewed-on: https://code.wireshark.org/review/4191
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: Iafd7300aa7f2664bb06e1330caede10785c21d68
+ Reviewed-on: https://code.wireshark.org/review/5607
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit a58c986
-Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Sep 18 00:10:51 2014 -0400
+commit a919566
+Author: Steve Karg <skarg@users.sourceforge.net>
+Date: Wed Dec 3 13:30:42 2014 -0600
- Update generated DCE/RPC dissectors.
+ BACnet: fix dissection of exception-schedule property.
- Now all generated dissectors can successfully compile.
+ The exception schedule special-event disection already used matched
+ open-close tags and only needed to check for an unmatched close tag
+ to exit when used with ReadPropertyMultiple service.
- Change-Id: I74728926915d5a9f1694cc49c753b80f213df767
- Reviewed-on: https://code.wireshark.org/review/2598
+ Bug: 10691
+ Change-Id: I54f2f6f3f470138a6a88f84c62fd15b07ea74c37
+ Reviewed-on: https://code.wireshark.org/review/5593
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit b794004
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 18 22:29:29 2014 -0400
+commit f27c345
+Author: Michele Baldessari <michele@acksyn.org>
+Date: Wed Dec 3 20:14:33 2014 +0100
- packet-http2.c: Do encoding-arg changes (all benign)
+ Add resource-id parsing to the X11 errors that return it
- For:
- - FT_BYTES: Always use just ENC_NA
- - integral/floating (other than FT_[U]INT8): Do ENC_NA --> ENC_BIG_ENDIAN
+ - Rename BadColor to BadColormap as the former does not exist in the X11
+ specs
+ - Parse the bad resource id field in case of the following errors:
+ BadColormap, BadWindow, BadPixmap, BadCursor, BadFont, BadDrawable,
+ BadGC and BadIDChoice
- Change-Id: I0885f7d110014cb8a7eba1c1892ed8d0852d076a
- Reviewed-on: https://code.wireshark.org/review/4187
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: I5b23d32189e1a8bb291c656cf6383a85b3e89642
+ Reviewed-on: https://code.wireshark.org/review/5592
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit ea1b746
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 18 22:25:01 2014 -0400
+commit b8a2364
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Thu Dec 4 00:03:03 2014 -0800
- packet-http2.c: Fix a very minor bug
+ Don't do the desktop integration stuff if we're not building Wireshark.
- - incorrect fetch/display of hf_http2_push_promise_r field
+ Wireshark is the desktop app; if we're not building it (i.e., we're only
+ building the command-line TShark), we don't need any desktop files.
- Change-Id: Iddf2db4807713017519b5abcbff3ba824b3624c6
- Reviewed-on: https://code.wireshark.org/review/4186
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit cd7a11c
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 18 21:56:44 2014 -0400
-
- Add editor modelines; Adjust indentation as needed.
-
- Change-Id: Ie8d4056ab706bbc85c8247682b1a64ea98bc89f2
- Reviewed-on: https://code.wireshark.org/review/4185
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: Id8244b417fd53c9d55b4d77fe3ad748c98868ad7
+ Reviewed-on: https://code.wireshark.org/review/5615
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 18d7298
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 18 21:18:34 2014 -0400
+commit c02417f
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Wed Dec 3 23:56:10 2014 -0800
- Do encoding-arg changes (all benign)
-
- For:
- - FT_BYTES: Always use just ENC_NA
- - integral/floating (other than FT_[U]INT8): Do ENC_NA --> ENC_BIG_ENDIAN
+ Don't do all the fd.o desktop integration stuff on OS X.
- Also:
- - FT_UINT... --> FT_UINT8 in a few cases (to match proto_tree_add_item...)
- - Change one case of incorrect '||' to '|'
+ It doesn't need it, so don't install those files, or uninstall them, or
+ suggest running various unnecessary commands after the installation
+ finishes.
- Change-Id: I427e0e61618ff8faf55691c8a695930f67d455b0
- Reviewed-on: https://code.wireshark.org/review/4184
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: Ieecab22884723670f47f2fc7cc1ac827f48c1967
+ Reviewed-on: https://code.wireshark.org/review/5614
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 4bdf514
+commit 6e5d84f
Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 18 18:41:57 2014 -0400
+Date: Wed Dec 3 15:22:39 2014 -0500
- fix-encoding-args.pl: Add a few additional fixups;
-
- Specifically: A number of cases of the use of the encoding arg
- "ENC_ASCII | ENC_NA" for FT_BYTES FIELDTYPEs seem to
- have crept into Wireshark source.
+ Rename some filter names to fix cases of duplicate filter names.
- Also: Add a ToDo comment as to code rework needed to be able to
- better *validate* encoding args.
+ Note: Use of most of these filter names could have caused a Wireshark crash.
- Change-Id: I9d4b10b869fe2aef3f20bcd2d7ad6531375aba87
- Reviewed-on: https://code.wireshark.org/review/4183
+ Change-Id: I393402a25dd26d174baff77f4706f6d5f43a94ae
+ Reviewed-on: https://code.wireshark.org/review/5610
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 7b20afc
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Tue Sep 16 17:34:29 2014 +0200
-
- Qt: add support for some more command line options
-
- Change-Id: I63b2c51ba857dc5282897c32594102aad2ef9e2f
- Reviewed-on: https://code.wireshark.org/review/4127
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 3397618
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Thu Aug 28 08:23:27 2014 +0200
-
- Bluetooth: Fix some Clang Analyzer warnings
-
- Logic error Dereference of null pointer epan/dissectors/packet-bthci_acl.c 379
- Logic error Dereference of null pointer epan/dissectors/packet-bthci_acl.c 390
- Logic error Dereference of null pointer epan/dissectors/packet-btsdp.c 3673
- Logic error Dereference of null pointer epan/dissectors/packet-btsdp.c 1439
- Logic error Dereference of null pointer epan/dissectors/packet-btsdp.c 1662
-
- Thanks for Alexis La Goutte for pointing that.
-
- Change-Id: Ia646b33de9e368d32983efddfaa41edf7896d7fd
- Reviewed-on: https://code.wireshark.org/review/4165
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 051b000
+commit f8c0bff
Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 18 10:44:56 2014 -0400
+Date: Wed Dec 3 15:19:36 2014 -0500
- fix-encoding-args.pl: Add a few fixups for FT_UINT_STRING
+ mac-lte: Rename expert filter name to fix conflict with same name in hf[]
- Change-Id: Ic22e154859877c48a85b808d0029e10e07876b73
- Reviewed-on: https://code.wireshark.org/review/4174
+ Change-Id: I906a195b3c6a1e68f273decc9c443a233af4f9be
+ Reviewed-on: https://code.wireshark.org/review/5609
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 36ce5e1
+commit d519617
Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 18 10:35:48 2014 -0400
+Date: Wed Dec 3 14:14:53 2014 -0500
- Fix encoding-arg mostly for FT_UINT_STRING; Also: Do misc as needed.
+ mausb: Rename expert filter names to fix dup filter names.
- Misc: (as needed)
- - Add editor modelines;
- - Adjust whitespace.
-
- Change-Id: I0e5d877a2a6273842ad8e771ac0c0acbfcb83200
- Reviewed-on: https://code.wireshark.org/review/4173
+ Change-Id: Id650c3aff6d073b05e844574ffbde8fec4368f49
+ Reviewed-on: https://code.wireshark.org/review/5608
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit dbb01af
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Sep 17 14:47:17 2014 -0400
+commit 245bdd1
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Wed Dec 3 18:37:50 2014 -0800
- fix-encoding-args.pl: Fix bug: certain patterns found only in 1st,3rd,... file checked
+ Put a bunch of suggestions in post-install/post-uninstall hooks.
- Another perl "You can't DO that" ...
+ This covers a bunch of commands that might have to be run after "make
+ install". ("might" - none are needed on OS X, for example, as it's a
+ different desktop and its dynamic loader doesn't have a cache that you
+ have to manually update whenever you install a new shared library.)
- Change-Id: I56e11bec19515f883f15286c6aa45018a255ab53
- Reviewed-on: https://code.wireshark.org/review/4172
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: I21e1728bdde26a7ab1585fdfb54f63fdc1c25dd6
+ Reviewed-on: https://code.wireshark.org/review/5606
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 4b15171
+commit 1ffe32b
Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Sep 18 10:26:35 2014 -0400
+Date: Wed Dec 3 16:59:08 2014 -0500
- Fix compilation when we don't HAVE_GEOIP.
+ Fix building of RPMs and get RPM builds working with a prefix other than /usr again.
- We really need a buildbot or Petri-Dish which doesn't have GeoIP because
- this problem keeps popping up.
-
- Bug: 10480
- Change-Id: Iccba50dfcafd2dbacb315b9416324de4114be220
- Reviewed-on: https://code.wireshark.org/review/4171
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 1315ee1
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Fri Aug 29 15:18:23 2014 +0200
-
- Bluetooth: Fix packet types additional description
-
- Change-Id: Idddd491da8b6c1d5d2824121f9c334d864aafb8c
- Reviewed-on: https://code.wireshark.org/review/4169
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit fe829dc
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Tue Jun 24 15:57:18 2014 +0200
-
- Update Polish Translation
-
- It still not complete.
-
- Change-Id: I53c3efe9c6cf0456fcea55336114086445d3bfe9
- Reviewed-on: https://code.wireshark.org/review/2719
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 39864c1
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Thu Sep 18 10:47:41 2014 +0200
-
- Logcat: Add more save formats over exported pdu
-
- Add all logcat format like brief, threadtime, long, etc. when try to save
- logcat logs where there is EXPORTED_PDU layer.
-
- Change-Id: I338f0bbd46dd8db984efc1c03980c7e9c7401a44
- Reviewed-on: https://code.wireshark.org/review/4164
- Reviewed-by: Michal Orynicz <michal.orynicz@tieto.com>
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
- Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 3b46e6e
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Thu Sep 18 08:05:48 2014 +0200
-
- Having CmakeListsCustom.txt in git defeats the purpose of its existence:
- If it is used, there is a modified file in git.
- Fix this by only including the file if it exists.
- Other changes:
- - Rename the existing Custom files to CMakeListsCustom.txt.example.
- - Move the plugins custom file to the top level (same level as its
- including parent).
- - Optionally allow a list of custom includes instead of the default one.
-
- Change-Id: I8960eac6222f741c045055d43d1d5a2d4979caf6
- Reviewed-on: https://code.wireshark.org/review/4163
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit 84629f4
-Author: Joseph Huffman <jhuffman@qce.qualcomm.com>
-Date: Mon Aug 11 14:26:35 2014 -0700
-
- AJTOOLS-4 Data field not being parsed properly by WireShark plugin if two or more AllJoyn Messages are combined in single TCP packet.
-
- Fixed bugs where multiple messages are combined in a single packet.
- Fixed bugs where a single message is distributed across multiple packets.
- Fixed bug where arrays of zero length were not dissected properly.
-
- Change-Id: Icfb83e73519d8217d6c477edf531ba6d3f3dcd48
- Reviewed-on: https://code.wireshark.org/review/4159
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 5d80686
-Author: chrysn <chrysn@fsfe.org>
-Date: Tue Sep 16 08:27:02 2014 +0200
-
- CoAP dissector: Update option numbers from RFC7252
+ (Change I567269d8e45e6543d9e39dbedc49830adf7edb9f made the desktop files
+ install outside of /usr/share/ .)
- * "Accept" option: The option number was changed late in the
- specification process.
- * "Proxy-Scheme" / "Size1": After including those, all option numbers
- specified in the RFC can be dissected by wireshark.
+ RPMs now build and work regardless of the prefix but the desktop integration stuff
+ only works if the prefix is /usr or (if you're lucky) /usr/local .
- Change-Id: I1b475ac6920fd021e3217cd3b44c173d264a5298
- Reviewed-on: https://code.wireshark.org/review/4123
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit b2f03f1
-Author: Hannes Mezger <hannes.mezger@ascolab.com>
-Date: Wed Sep 17 15:48:58 2014 +0200
-
- opcua: prefix all hf_register_info with opcua, unify naming
-
- Change-Id: I575bd2f93202837b2ce15a39b1b0bd9b5c53f5bf
- Reviewed-on: https://code.wireshark.org/review/4151
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 095a0e8
-Author: Hannes Mezger <hannes.mezger@ascolab.com>
-Date: Wed Sep 17 15:41:27 2014 +0200
-
- opcua: use BASE_NONE instead of 0
-
- Change-Id: I5ca5d41edf1f56b24da6360a10f0c6e2600572d2
- Reviewed-on: https://code.wireshark.org/review/4150
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 769a984
-Author: Hannes Mezger <hannes.mezger@ascolab.com>
-Date: Wed Sep 17 15:36:59 2014 +0200
-
- opcua: format all hf_register_info tables by aligning them to longest value
-
- Change-Id: I0b533edd7bad52922dd1e0aaa2c980e56dd88b78
- Reviewed-on: https://code.wireshark.org/review/4149
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit d8afd59
-Author: Hannes Mezger <hannes.mezger@ascolab.com>
-Date: Wed Sep 17 15:06:03 2014 +0200
-
- opcua: remove unused code
-
- Change-Id: I78963640e32393f3ac399e59a659ddf619d15c3d
- Reviewed-on: https://code.wireshark.org/review/4148
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 17c14d6
-Author: Hannes Mezger <hannes.mezger@ascolab.com>
-Date: Wed Sep 17 15:03:54 2014 +0200
-
- opcua: add hint to OPCUA settings tooltip
-
- It's unclear how the ports should be separated, this additional text in the tooltip clarifies it
-
- Change-Id: I686482522d006024f920a3cc26b83cd21c19f8a5
- Reviewed-on: https://code.wireshark.org/review/4147
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit ec2a20f
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Thu Sep 18 00:09:06 2014 +0200
-
- Add a missing cast to the sample code
-
- Change-Id: Id4f258e0e45e44c1ab63bd77a6fab10013a4810c
- Reviewed-on: https://code.wireshark.org/review/4160
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
+ Change-Id: If20e0127a044eac1ba099f959a90d068c4bb2ae5
+ Reviewed-on: https://code.wireshark.org/review/5600
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 7e63805
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Sep 5 11:17:17 2014 -0700
+commit 44e2716
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Wed Dec 3 20:02:04 2014 -0500
- Qt: Add the "Map" button to the Endpoints dialog.
+ Tell the loader where to find our libraries if we're being installed
+ someplace other than /usr .
- Move the map creation code from ui/gtk/hostlist_table.c to
- ui/traffic_table_ui.c.
-
- Add CMake commands to copy ipmap.html to the run directory so that
- WIRESHARK_RUN_FROM_BUILD_DIRECTORY works for the endpoint map. Not sure
- if they're entirely correct but they appear to work.
-
- Add boundary checkes to geoip_db_lookup_ipv[46].
-
- To do:
-
- - It looks like there are prettier maps and newer APIs that we
- might want to use.
-
- Change-Id: Ie06992c9bc9c9aa683328aecab3f5f69c9cab966
- Reviewed-on: https://code.wireshark.org/review/4011
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I42cbe98bcfc0e8ba2aa08f651044db051d31205c
+ (cherry picked from commit 25d9695cb3536b672f4cd8bc280e2a3c816a0d8a)
+ Conflicts:
+ packaging/rpm/SPECS/wireshark.spec.in
+ Reviewed-on: https://code.wireshark.org/review/5605
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 478fab5
+commit f0bd311
Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Sep 11 18:03:31 2014 -0700
+Date: Wed Dec 3 16:05:29 2014 -0800
- Qt: Remove duplicate GeoIP columns.
+ CMake: Don't cache LUA_LIBRARIES.
- Different GeoIP databases have the same column name, e.g. "City"
- currently matches two revisions each for IPv4 and IPv6. Map each
- uniquely named column to a list of databases and populate
- EndpointTreeWidgetItem columns based on the first database match.
+ Don't cache the LUA_LIBRARIES variable. This matches the behavior of the
+ other library modules and fixes a compilation problem on my machine
+ where /usr/local/lib/liblua.dylib wasn't showing up in the various
+ build.make and link.txt files.
- Fix a copy/pasteo introduced in g30f3d52: Make sure
- geoip_db_lookup_ipv[46] returns longitude instead of latitude.
-
- Change-Id: Idd31f976dfd1cb011cfa7b5aec14b7031ee0e25e
- Reviewed-on: https://code.wireshark.org/review/4157
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: Ib75ef303f2e67b266a246621718d0ea2ab885dca
+ Reviewed-on: https://code.wireshark.org/review/5603
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit f0b4411
-Author: Evan Huus <eapache@gmail.com>
-Date: Wed Sep 17 14:11:11 2014 +0000
-
- Revert "packet-infiniband: added support for RoCE-v2 (RRocE)"
-
- This reverts commit 07078921e42cae2ff31ac6e11951bb9986ffe5db.
-
- Change-Id: I5b88f0203558c86562694ca841d28314bff336a5
- Reviewed-on: https://code.wireshark.org/review/4152
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 933ae8e
-Author: Evan Huus <eapache@gmail.com>
-Date: Wed Sep 17 09:36:30 2014 -0400
-
- Add missing initializer
-
- Change-Id: I60917502ef869bb519b37bb0252371dbc91a608d
- Reviewed-on: https://code.wireshark.org/review/4146
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 0707892
-Author: Wasim Abu Moch <wasim@mellanox.com>
-Date: Tue Aug 19 18:45:29 2014 +0300
-
- packet-infiniband: added support for RoCE-v2 (RRocE)
-
- Added support for the new Routable RDMA over Converged Ethernet.
-
- Change-Id: I97bc29fdc92bdcb12888f38383107a965837963e
- Reviewed-on: https://code.wireshark.org/review/3723
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit c4c8257
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Sep 17 12:14:32 2014 +0200
-
- GTPv2: further fixes for Trace Information IE dissection
-
- Bug: 10470
- Change-Id: I8b61e5601379a568da39cce2335122e91ab37ec4
- Reviewed-on: https://code.wireshark.org/review/4142
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit d05a44c
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Mon Sep 15 14:26:05 2014 -0700
+commit 0d20456
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Wed Dec 3 17:54:45 2014 -0500
- Show endpoint direction based on EPHandle bit
-
- Interpret the meaning of the endpoint handle direction bit,
- instead of just saying if it is set.
+ Make a note that cmake needs to install the freedesktop integration files too.
- Change-Id: I9fc0d6f95f6c3a94d6db90c8394fe3ca8fc83715
- Reviewed-on: https://code.wireshark.org/review/4119
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I5eeeb2fa32e8f90bc56f0515e0fc9f6c5f88eb79
+ Reviewed-on: https://code.wireshark.org/review/5602
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit b53405c
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Tue Sep 16 14:03:03 2014 -0700
+commit 7ef5abc
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Wed Dec 3 17:05:00 2014 -0500
- Fixed dissection of 8-byte device descriptors
-
- during usb device enumeration, a host may attempt to only read the
- first 8 bytes of a device descriptor. Dissecting a partial device
- descriptor was throwing a bounds error.
+ Don't run gtk-update-icon-cache when uninstalling the Qt package. But do run
+ it when installing the gnome package.
- Change-Id: I09cdd356d15153afc93ee478fdd98329495a642a
- Reviewed-on: https://code.wireshark.org/review/4137
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I0bbd9c0edc3fb6fe0e672aa3dbea5ba23d847d87
+ Reviewed-on: https://code.wireshark.org/review/5598
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 4cf9e71
+commit c86d1d2
Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Tue Sep 16 19:25:37 2014 +0200
-
- GTPv2: fix dissection of Triggering Events IE
-
- Bug: 10470
- Change-Id: Ieb9819e578f078e956861a4e2d7ab3d8b96416d6
- Reviewed-on: https://code.wireshark.org/review/4130
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 71bb171
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 16 17:15:56 2014 -0700
-
- Update the docbook directory to use https://www.wireshark.org.
-
- Change-Id: Ied91158cb055b0235b4a5106c3eb6b9300997c32
- Reviewed-on: https://code.wireshark.org/review/4141
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 1750391
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 16 17:08:53 2014 -0700
-
- Update the doc directory to use https://www.wireshark.org.
-
- Change-Id: I9bfc57cb6b6ab6962b80ff58d98eb351d6f69829
- Reviewed-on: https://code.wireshark.org/review/4140
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit b5296f4
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Tue Sep 16 14:30:16 2014 -0700
-
- Use tvb_new_subset_length() rather than tvb_new_subset().
-
- We rarely, if ever, want to, or need to, explicitly set the captured
- length of a packet; we want to set the *reported* length and let the
- tvbuff code figure out how much of that data was actually captured.
-
- Change-Id: I9b93d296197989f677d888b10954589dfc1edc59
- Reviewed-on: https://code.wireshark.org/review/4138
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 1cbd9c7
-Author: Evan Huus <eapache@gmail.com>
-Date: Tue Sep 16 20:28:19 2014 +0000
-
- Fix compilation in weird cases
-
- Change-Id: I6c52ea9954a4c96f525e6d064dbf3fc2c71bea68
- Reviewed-on: https://code.wireshark.org/review/4136
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 983ae6c
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 16 13:12:10 2014 -0700
+Date: Wed Dec 3 20:48:08 2014 +0100
- Fix the patch-bzip2 target.
+ FC: fix dissection when packets are captured with Fibre Channel FC-2 encapsulation type
- The main site URI scheme is now https. Update the URL in some other
- places while we're here.
+ This is broken since ga9dd765
- Change-Id: Ib03d4fd1c58dabd3cf5050dc4f79216e0b94d525
- Reviewed-on: https://code.wireshark.org/review/4133
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit eefdaf6
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Sep 16 10:02:25 2014 -0400
-
- Fix typo in French translation.
-
- Bug: 10471
- Change-Id: I0e191d4f6b53a16236953d4e5b80956fa421008e
- Reviewed-on: https://code.wireshark.org/review/4125
+ Bug: 10751
+ Change-Id: Id4f282d9e0104bfa2314e2348aedf31233a671bd
+ Reviewed-on: https://code.wireshark.org/review/5594
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit a379ac7
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 16 11:25:17 2014 -0400
-
- Fix spelling: cant-->can't, wont-->won't, etc
-
- Change-Id: Ia6c3e7a25615bf8e052c3bacf096d76df775c9c2
- Reviewed-on: https://code.wireshark.org/review/4126
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit b14bf98
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 16 09:43:06 2014 -0400
-
- Fix spelling: cant-->can't, wont-->won't, etc
-
- Change-Id: I4497f1b8b6eab0e576d9dd31b732965f9a6679c6
- Reviewed-on: https://code.wireshark.org/review/4124
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit fee9277
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Sep 15 14:28:07 2014 -0400
-
- Fix some logically dead code reported by Coverity (CIDs 1158807, 1158808, 1229737).
-
- Replace some conditional + fprintf + DISSECTOR_ASSERT()s with
- DISSECTOR_ASSERT_HINT() or just change the DISSECTOR_ASSERT() to
- DISSECTOR_ASSERT_NOT_REACHED() when the hint requires formatting.
-
- Change-Id: I80c7c6579d7755a60d644b5ef60ec4e3299ba0ab
- Reviewed-on: https://code.wireshark.org/review/4115
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
+ Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 126b4a6
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Sep 15 19:32:13 2014 -0400
-
- expert.[hc] Minor changes:
-
- - Fix a few parameter descriptions in expert.h;
- - Do whitespace changes;
- - Add editor modelines.
-
- Change-Id: I1b75fa88021f1f44bd607cd33d0ab7f9ec672ab7
- Reviewed-on: https://code.wireshark.org/review/4122
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 85dceb3
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 15 13:43:52 2014 -0700
-
- Handle SRVLOC-over-TCP like other XXX-over-TCP protocols.
-
- No need to wrap each SRVLOC PDU, which contains a SRVLOC protocol layer,
- in *another* SRVLOC protocol layer.
-
- Change-Id: I25e05d94bb9968eb4e26b63beb09fd151820d750
- Reviewed-on: https://code.wireshark.org/review/4118
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit ed7c328
+commit 0a30f68
Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Sat Sep 13 21:51:24 2014 +0200
+Date: Sat Nov 29 19:00:58 2014 +0100
- dissect the alphanumeric message that's part of operation 30
- Bug: 10464
+ start dissecting the stsz box
- Change-Id: I1a42877ee549b40e0c739dd2d1cbe4615ed9b9bd
- Reviewed-on: https://code.wireshark.org/review/4098
+ Change-Id: Ia8fce9307bae33c44d630af403980d162afd88c2
+ Reviewed-on: https://code.wireshark.org/review/5597
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 6422563
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Mon Sep 15 11:24:18 2014 +0100
-
- Show RRC Release cause in the Info column
-
- Change-Id: I138859ce735a9ff6541d6852dec29a13c1034c36
- Reviewed-on: https://code.wireshark.org/review/4114
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
-
-commit 8f84fe9
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 15 03:13:38 2014 -0700
+commit 2f39f2e
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Sat Nov 29 18:50:59 2014 +0100
- Clean up handling of the message type.
-
- Don't use try_val_to_str() and then never test the result to see whether
- it's null. Instead, use val_to_str_const().
-
- Don't use proto_tree_add_uint_format_value() to emulate what
- proto_tree_add_uint() does unless the string for the value isn't
- computed from the value_string for the field.
-
- Also, prepend to the Info column as soon as we have the data with which
- to do so.
+ BOX_TYPE_STZ2
- Change-Id: Iae9bdfc7c80cbd1ec63e1bbb8d43560adec558bd
- Reviewed-on: https://code.wireshark.org/review/4113
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I4eadf2b613b7803c81593e517408631f8375ab2c
+ Reviewed-on: https://code.wireshark.org/review/5596
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit f30bba3
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Thu Sep 11 18:11:50 2014 -0700
+commit ee48194
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Sat Nov 29 12:58:20 2014 +0100
- USB feature selectors now per USB 3.1 spec
+ start dissecting the mvhd box
- previously per USB 2 spec.
-
- Change-Id: Ifb25614785bcaf80148c32938f966c8cdded6be2
- Reviewed-on: https://code.wireshark.org/review/4087
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: I66c1973daa89690f6aaa10891408e93e886875ea
+ Reviewed-on: https://code.wireshark.org/review/5595
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 176bd64
+commit b088ca5
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 14 14:08:11 2014 -0700
-
- TRY_TO_FAKE_THIS_ITEM() doesn't take a tvbuff_t * argument.
-
- Change-Id: I782f73dd072f515e34ce98892340dc176978a364
- Reviewed-on: https://code.wireshark.org/review/4112
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit af9d2df
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Sep 12 17:21:53 2014 -0400
+Date: Wed Dec 3 11:03:23 2014 -0800
- Don't try to set the length, end, or text of a faked item.
+ Squelch some "can't happen in reality" warnings.
- If we try we may (in the case of setting the length or end) mistakenly assert
- out.
+ (I guess newer versions of GCC/Clang know that dissect_eh_frame() is
+ never called with a segment_size of 0, so the loop is traversed at least
+ once. NOTE: if it ever *is* called with a segment_size of 0, then
+ that's a genuine bug and needs to be fixed.)
- Bug: 10329
- Change-Id: I52083ba17f6427712a6a363f48f1f7ae51f2b74b
- Reviewed-on: https://code.wireshark.org/review/4093
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 36ddf54
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Sep 12 21:18:49 2014 +0000
-
- Revert "Only fake an item by returning 'tree' if they use the same TVB"
-
- This reverts commit 5460d7fa0cd13f84ff567c96ee89d07b37cd4b62.
-
- Bug:10329
- Change-Id: I6f13f9c18bb23fd10b3a574e42ad2d3f6c7beadb
- Reviewed-on: https://code.wireshark.org/review/4092
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit a41c122
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 14 10:23:24 2014 -0700
-
- Consistent white space.
+ Also, segment_size is used; no need to mark it as unused.
- Change-Id: I7c19a16a671db7b68ef2f680813a9a190ed1e13d
- Reviewed-on: https://code.wireshark.org/review/4109
+ Change-Id: I63b7a580a853b55f22494de73b4c4e6f9a387647
+ Reviewed-on: https://code.wireshark.org/review/5591
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 32ee46b
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Sep 14 08:05:34 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-09-14]
-
- Change-Id: Ib519e0a0ed3e11eb555c338f2e808b555cc6931d
- Reviewed-on: https://code.wireshark.org/review/4106
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit e74ae46
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 14 02:57:05 2014 -0700
+commit db462ce
+Author: AndersBroman <anders.broman@ericsson.com>
+Date: Wed Dec 3 12:57:38 2014 +0100
- Show BER identifiers and lengths in SNMP variable bindings.
-
- If the user turns on the "show internal BER encapsulation tokens"
- preference, show them the tokens inside SNMP variable bindings.
+ Try to please the buildboots by plasing th '#' at the begining of the
+ line.
- Change-Id: Ief9040f422cb214bbff8e4cfd45a2e05c7106480
- Reviewed-on: https://code.wireshark.org/review/4105
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 3031247
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 13 17:21:56 2014 -0700
+ Change-Id: Ie17e83504e7fbccb71190b3fdbfb6ad3507a806e
+ Reviewed-on: https://code.wireshark.org/review/5584
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
- Don't use the captured length as the packet length.
-
- Add a routine ber_tvb_new_subset_length() used to construct tvbuffs for
- parts of the packet, and have it check the specified length against the
- *reported* length. NOTE: that routine should really take an item and an
- expert info value as arguments and, if the length is greater than the
- remaining packet length, add an expert info for that.
-
- Also, when counting items in a SEQUENCE-OF:
-
- keep track of whether we succeeded in counting them, and report
- an "unknown number of items" if we didn't;
-
- if the length of an item in the SEQUENCE-OF is so big we get an
- overflow, just bail out of the count loop and indicate that we
- didn't succeed in counting them - let the error be reported in
- the process of dissection.
-
- Change-Id: I32172737baaed35fc9a0e6c19a727a6ac71ddfb2
- Reviewed-on: https://code.wireshark.org/review/4103
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+commit c4602e1
+Author: Peter Wu <peter@lekensteyn.nl>
+Date: Tue Nov 25 15:16:48 2014 +0100
+
+ elf: fix .eh_frame parsing, add expert info for bad CIE length
+
+ Fixes, matching LSB 4.1[1] and the AMD64 ABI[2]:
+ - Multiple CIE entries can exist after the first one. Introduce a CFI
+ subtree and add CIE and FDE records below it. Merge comon parsing
+ functionality of CIE/FDE. A CIE terminator is treated specially, and
+ added instead of a CFI subtree.
+ - Validate the header length before using it to avoid a dissector
+ assert. This condition is triggered by a binary produced by a buggy
+ gold linker[3].
+ - Add two expert items: one to detect an invalid CIE length (too small
+ or too large) and one to detect a segment which is larger than the
+ CFI records (to catch the gold linker bug[3] where the segment begins
+ with zeroes).
+ - Do not overload the elf.eh_frame.length field with the value of the
+ Extended Length, instead use elf.eh_frame.extended_length (likewise
+ for FDE).
+ - Stop tracking the subsection size with another variable
+ (remaining_length), just store the end of the entry.
+ - Fix typos in descriptions, improved / shortened field descriptions.
+
+ Tested with the 'bad' and 'good' binary from bug 10726 as well as the
+ 'a' binary from bug 8818 (which introduced this code). Decodes properly.
+
+ [1]: https://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/ehframechpt.html
+ [2]: http://www.x86-64.org/documentation/abi.pdf
+ [3]: https://sourceware.org/bugzilla/show_bug.cgi?id=17639
+
+ Bug: 10726
+ Change-Id: I523600b8141bd8953ae468051a57357ab199a258
+ Reviewed-on: https://code.wireshark.org/review/5488
+ Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
+ Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 21adbaa
+commit c69ccab
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 13 17:10:49 2014 -0700
+Date: Wed Dec 3 01:06:02 2014 -0800
- Don't use the captured length, and don't fetch the version until we need it.
-
- The captured length reflects the way the capture was done; it should not
- affect actual lengths used in the dissection.
+ Install the other desktop files with "make install" as well.
- Don't fetch the version until we need it; that lets us dissect more of
- the packet if the previous change caused us to throw an exception trying
- to fetch the version from the correct location rather than not throwing
- an exception by fetching it from an incorrect location that happens to
- be within the captured data.
+ (And remove them with "make uninstall".)
- Change-Id: I9f63afd4ef51f46c19b3afd2a651a5bb768fecaf
- Reviewed-on: https://code.wireshark.org/review/4101
+ Change-Id: I76b554bf1a1272813d61c8d2c96cda0a152eebb5
+ Reviewed-on: https://code.wireshark.org/review/5582
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 1277839
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 13 16:49:50 2014 -0700
+commit 08c0247
+Author: Maarten Bezemer <maarten.bezemer@gmail.com>
+Date: Fri Nov 28 16:53:04 2014 +0100
- Clean up indentation.
+ Support dissecting REAL (BER) data values
- Change-Id: Ie43c3a55aa954c1ec640ec90c74356b2b19e4156
- Reviewed-on: https://code.wireshark.org/review/4100
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit e6d7116
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Sat Sep 13 21:39:14 2014 +0200
-
- update the URL of the specification
+ Both exponent and 'integer N' values are limited:
+ * max exponent is 3 octets/24-bits
+ * max integer N is 8 octets/64-bit
- Change-Id: I7301a739a28c20ece274293447713fd02ffab385
- Reviewed-on: https://code.wireshark.org/review/4097
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit f0982e2
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Sep 13 10:20:38 2014 -0700
-
- GTK+: Make sure we package up Wireshark-gtk.pdb.
-
- Make sure we use $(PROGRAM_NAME_GTK) consistently. We still need to add
- the Qt UI .pdb to the archive but I'm not in front of a proper Windows
- development environment right now.
+ Tested with zero value/length, integers, doubles, positive and negative numbers all using the Basic Encoding Rules (BER)
- Change-Id: Ie917f68e3e8349fc7955b3b7e68d446b6fe88235
- Reviewed-on: https://code.wireshark.org/review/4096
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
+ Change-Id: If92e1b3e209c42909b8cb76e6f50b8e6cd1da0da
+ Reviewed-on: https://code.wireshark.org/review/5527
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 2838618
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Sep 10 23:03:57 2014 +0200
-
- when we check the parameter for upper(), lower() or len(),
- return an error if the parameter is _no_ string
-
- Bug: 10401
- Change-Id: I5643ef05009072538155e63c3178071ed6bab061
- Reviewed-on: https://code.wireshark.org/review/4071
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 6a7414f
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Sat Sep 13 07:31:14 2014 +0200
-
- README.dissector was split from README.developer in 2013 - update some
- documents referring to the split out sections.
- Remove trailing whitespace while at this.
-
- Change-Id: I36cfe0ac55e8f653bffbf850e01f582aacf85557
- Reviewed-on: https://code.wireshark.org/review/4094
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 0a0654a
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Sep 12 15:56:29 2014 +0200
+commit e55fe95
+Author: AndersBroman <anders.broman@ericsson.com>
+Date: Wed Dec 3 09:55:08 2014 +0100
- IPSec: fix compilation when building without libgcrypt
+ Make dissect_sip_tcp() a new style dissector.
- Change-Id: Iea3de2f0a54f9c0703afbeb42722d18da99f5c9a
- Reviewed-on: https://code.wireshark.org/review/4090
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I773f6738b3ed507e1ce031ee308d16de4bdeb7d4
+ Reviewed-on: https://code.wireshark.org/review/5580
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 5ade437
+commit fb0999a
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 12 09:59:34 2014 -0700
+Date: Wed Dec 3 00:21:59 2014 -0800
- Treat a length of -1 as a Very Large Length in most cases.
+ Use $(srcdir) when installing image/wsicon.svg.
- For field types where it doesn't mean "to the end of the tvbuff", treat
- it like other negative length values - as if it were unsigned and thus
- Very Large and thus likely to be past the end of the tvbuff. That way,
- some of the "we hax0red your SNMP packets" captures, with length fields
- of 0xffffffff, report malformed packets rather than dissector bugs.
+ We're not necessarily running from the top-level source directory.
- Change-Id: Id53f828b06b6febe7d79f8539e54523e0b43e5c2
- Reviewed-on: https://code.wireshark.org/review/4091
+ Change-Id: I0bb815275f85630e5316bf593f4ac098d9475308
+ Reviewed-on: https://code.wireshark.org/review/5579
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 887f7f1
+commit d6d55b2
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 12 01:01:00 2014 -0700
+Date: Wed Dec 3 00:18:01 2014 -0800
- Register hfi_rip_zero_padding.
+ Uninstall the icons with "make uninstall".
- Also, sort the hfi[] array to be in the same order as the declarations
- of the fields, to make it easier to check that all fields are being
- registered.
+ Just in case not all shells expand {list}, create the apps/icons and
+ apps/mimetypes directories separately; that makes it a bit clearer in
+ any case.
- Change-Id: Ida530590ebd00bbf206e0f6041b8da880bce2c6f
- Reviewed-on: https://code.wireshark.org/review/4089
+ Change-Id: I25b3426a17a2ca7e1ce3ce1f7f9e1c650db511a7
+ Reviewed-on: https://code.wireshark.org/review/5578
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 9accfd1
+commit b5a52ee
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 12 00:48:45 2014 -0700
+Date: Tue Dec 2 22:21:13 2014 -0800
- Do FT_{U}INT64 the same way we do other FT_{U}INTn types.
+ Get rid of trailing blank.
- Change-Id: Iae9c66fa82abfe20e9e8c922ddedfe87b0ab2abe
- Reviewed-on: https://code.wireshark.org/review/4088
+ Change-Id: Ia0eecbbe1ff1778d5c34338e042c0518895663b4
+ Reviewed-on: https://code.wireshark.org/review/5577
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 3df42e7
-Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Sep 11 16:43:00 2014 -0400
-
- proto_tree_add_text cleanup
-
- Create filters (expert and hf_) that have the "most bang for the buck" (ie have many instances for a single filter)
-
- Change-Id: I61995e41c5b298df77e084e65cdf30ebe95da1e6
- Reviewed-on: https://code.wireshark.org/review/4086
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 47c5929
+commit cff44e5
Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Sep 11 13:29:37 2014 -0700
+Date: Tue Dec 2 22:19:01 2014 -0800
- Add some additional checks in SnifferDecompress().
+ Always install icons, and install them under $(datadir).
- Check the input pointer in the while clause of the loop, so that we
- handle an empty input buffer.
+ We always install them because of bug 10737.
- When reading a bit mask, check before fetching the bit mask that we have
- two bytes of bit mask and the byte after it.
+ We install them under $(datadir) because that's where we should install
+ our data - if your desktop environment can't find the icons there,
+ either it's broken (file a bug) or misconfigured (fix the configuration
+ or, if you didn't configure it, file a bug).
- Before putting an uncompressed input byte into the output, make sure we
- wouldn't run past the end of the output buffer.
-
- Before copying an earlier string from the output buffer, make sure it
- doesn't run past the end of the data we've decompressed so far.
-
- Bug: 10461
- Change-Id: I8bb8d0d291368ae8bf0ac26970ff54d3262a7e6e
- Reviewed-on: https://code.wireshark.org/review/4083
+ Bug: 10737
+ Change-Id: I567269d8e45e6543d9e39dbedc49830adf7edb9f
+ Reviewed-on: https://code.wireshark.org/review/5576
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit ab6ad63
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Sep 11 15:16:45 2014 -0400
-
- Show the sctp.checksum_bad filter rather than hiding it.
-
- Follow TCP's lead by putting the filter in a subtree under the checksum.
-
- Change-Id: I9351ee865011cd04bc3d3e88c51e8dbb3dc23f07
- Reviewed-on: https://code.wireshark.org/review/4082
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 0ec1793
+commit c681091
Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 11 14:19:03 2014 -0400
+Date: Tue Dec 2 17:34:29 2014 -0500
- packet-cfm.c: Update some comments; Add editor modelines.
-
- - Indicate that ITU-T G.8013/Y.1731 (11/2013) is the latest spec
- (and that the cfm dissector has not been updated to reflect same).
- - Remove a comment about a "discrepancy in the recommendation
- ITU-T Y.1731". The discrepancy has been corrected in the latest
- spec.
+ Fix instances of duplicate display-filter-names with incompatible types.
- Change-Id: I5a5f873d2a0a5fdee3aef1688403bb317a155cdf
- Reviewed-on: https://code.wireshark.org/review/4081
+ Change-Id: I3b5afb8a59f6443624708b9fecfdcbe93dad59ef
+ Note: Some of the filters, when/if used, could have caused Wireshark crashes.
+ Reviewed-on: https://code.wireshark.org/review/5575
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 6e81f1d
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Sep 11 14:10:55 2014 -0400
+commit 43e759e
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Tue Dec 2 22:18:55 2014 +0100
- Don't use tvb_bytes_exist() to check if we captured the whole frame, just
- compare captured_length to reported_length (which we've already retrieved
- anyway).
+ L2TP: add dissection of H bits
- Replace calls to tvb_length() with non-deprecated versions.
+ As requested in https://ask.wireshark.org/questions/38280/l2tp-dmpt-header-h-bit
- Change-Id: I9f6f3461915573fb21716a87cb6af416a3656097
- Reviewed-on: https://code.wireshark.org/review/4080
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Change-Id: If6cb61c720505e547432e87faf2a36bb4ec6e7c5
+ Reviewed-on: https://code.wireshark.org/review/5574
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit a8fabb9
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 11 12:43:08 2014 -0400
+commit 5abfc60
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Dec 2 16:09:26 2014 +0100
- packet-cfm.c: Fix Bug 10385: "Ethernet OAM (CFM) frames including TLV's are wrongly decoded as malformed"
-
- Regression introduced in ga06cccb (svn #50352) [Jul 3 16:43:40 2013]
+ Couchbase: fix missing comma...
- Bug 10385
- Change-Id: I3f5c5518a5804a1f31cac554323a6fa8d3d55d5d
- Reviewed-on: https://code.wireshark.org/review/4078
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: Ic86e07b434e693d2f0fbd9518a23ed49cf49f24d
+ Reviewed-on: https://code.wireshark.org/review/5572
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit e485bcd
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Thu Sep 11 17:27:08 2014 +0100
+commit d5aa8a4
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Dec 2 15:32:34 2014 +0100
- Fix an incorrect comment
+ Couchbase: fix Extended value string 'opcode_vals' forced to fall back to linear search
- Change-Id: Ic60c67fcc554b5ceb0b359a992fafd0f84521eef
- Reviewed-on: https://code.wireshark.org/review/4077
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
-
-commit 94f90e5
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Thu Sep 11 12:31:47 2014 +0200
-
- Code simplification from Hadriels abandoned change.
+ entry 85, value 128 [0x80] < previous entry, value 245 [0xf5]
- Change-Id: If859ff904b254d3bc62d1d0dc5cf26cace11cae3
- Reviewed-on: https://code.wireshark.org/review/4075
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I14bbe276eef5fdaa70561764ac4e6f2e174ceabe
+ Reviewed-on: https://code.wireshark.org/review/5570
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit ca04418
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Tue Sep 9 23:26:31 2014 +0100
+commit f6a4f32
+Author: Stig Bjørlykke <stig@bjorlykke.org>
+Date: Mon Dec 1 15:00:13 2014 +0100
- Do simple sequence analysis on ESP Sequence Number field
+ cms: Handle media_type pkcs7-mime and pkcs7-signature
- Change-Id: I84e204fb7a84eb821f4728a50945f34f4bdba73f
- Reviewed-on: https://code.wireshark.org/review/4057
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
+ Change-Id: I7db4e67ffe99a9f3b41d0b507d9837e0237d4547
+ Reviewed-on: https://code.wireshark.org/review/5558
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 29993d5
-Author: Michael Mann <mmann78@netscape.net>
-Date: Wed Sep 10 20:04:22 2014 -0400
+commit 077b45e
+Author: Stig Bjørlykke <stig@bjorlykke.org>
+Date: Mon Dec 1 15:13:25 2014 +0100
- Eliminate proto_tree_add_text from some dissectors.
+ imf: Added base64 content encoding support
- Change-Id: Ie41ac30f8edaeee75b23717ef1d5147d804a65b3
- Reviewed-on: https://code.wireshark.org/review/4074
+ Change-Id: I668b9c3dfcac83c698e83d4111af8bd19ec8076c
+ Reviewed-on: https://code.wireshark.org/review/5559
Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit d5940f5
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Sep 10 14:29:18 2014 -0400
+commit 485399a
+Author: Sergey Avseyev <sergey.avseyev@gmail.com>
+Date: Tue Nov 18 21:11:22 2014 +0300
- Clarify that 16777229 is the AppID for 3GPP Rx Release 6.
+ Update Couchbase dissector
- (Later releases have a different AppID.)
+ * Include DCP port to the list default ports
+ * Parse payloads for DCP commands:
+ * OPEN_CONNECTION
+ * ADD_STREAM
+ * STREAM_REQUEST
+ * Reorganize if conditions to cases
+ * Update list of known commands
- Change-Id: I41d4a498461e777f570641936db64d0551e36186
- Reviewed-on: https://code.wireshark.org/review/4070
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 8a580b3
-Author: Michael Mann <mmann78@netscape.net>
-Date: Wed Sep 10 19:58:33 2014 -0400
-
- Make all "padding" fields filterable
-
- Change-Id: Ic4e4d9142a9b05ef3b628fac2e8766014c5fccec
- Reviewed-on: https://code.wireshark.org/review/4073
- Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Change-Id: Id37b5c61f0d1084628c6286fd6e4ad722e1d6d99
+ Reviewed-on: https://code.wireshark.org/review/5388
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 76d776e
+commit 9c05b7f
Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Sep 10 18:14:44 2014 +0200
+Date: Tue Dec 2 12:53:46 2014 +0100
- Update to V12.2.0 (2014-06), remove deprecated APIs
+ Make it possible to register an OID dissector to dissect
+ ManagementExtension.
- Change-Id: Icfd140f39a440dda197c6e68a4cb7daec2ae0e09
- Reviewed-on: https://code.wireshark.org/review/4066
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 0164b75
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Sep 10 12:51:34 2014 -0400
-
- packet-netflow.c: fix bug: "top-of-stack" --> "bottom-of-stack"
-
- Bug #10458
- Change-Id: I733bb54b13da8dd5b96837b57c1893e14f9622ec
- Reviewed-on: https://code.wireshark.org/review/4067
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit cc286ba
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Sep 10 12:07:04 2014 -0400
-
- Various minor changes:
-
- - Create/use some extended value_strings
- - Remove unneeded #includes;
- - Do whitespace changes;
- - Add editor modelines.
-
- Change-Id: I2e1ea37dddfd5e8656c90c0d45a6596c4912bb2c
- Reviewed-on: https://code.wireshark.org/review/4065
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 4567134
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Sep 10 16:30:41 2014 +0200
-
- Update to revission V12.2.0 (2014-06)
- Remove soft deprecated APIs
-
- Change-Id: I30adcb9f381c77142385c22fcc4a208169b0cf5e
- Reviewed-on: https://code.wireshark.org/review/4062
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I52c626b0d7a63214ccecf13d62e0a2850c2dee07
+ Reviewed-on: https://code.wireshark.org/review/5569
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit cc412a6
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Sep 10 10:24:10 2014 -0400
-
- packet-opensafety.c: Fix two bugs:
-
- - Actually register dissector on default UDP ports upon startup.
- - expert_...() shouldn't be called under 'if (tree)'
-
- Also: cleanup proto_reg_handoff...() and apply_prefs() code.
-
- Change-Id: I6390d9bf311c9a62fbc43647d9bb19f90156baec
- Reviewed-on: https://code.wireshark.org/review/4063
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 5ff7a26
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Sep 10 15:13:46 2014 +0200
+commit 987383d
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Mon Dec 1 17:21:41 2014 +0100
- Minor performance tweaks:
- - Only calculate tvb length once.
- - Use tvb_reported_length() instead of tvb_reported_length_remaining() as
- this is a subtvb offset is always 0.
+ 6LoWPAN: use manually managed memory for the stateful address decompression preferences
- Change-Id: I03bd7a95061488d4576fa93f26e6b31d55f88738
- Reviewed-on: https://code.wireshark.org/review/4060
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Bug: 10747
+ Change-Id: I9d1b7ce2782f7cd133ab3ba02b0dd43afab3e145
+ Reviewed-on: https://code.wireshark.org/review/5560
+ Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
+ Reviewed-by: Evan Huus <eapache@gmail.com>
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit c6c8dc2
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Wed Sep 10 13:08:08 2014 +0100
+commit f260f9a
+Author: Matthieu Texier <matthieu@texier.tv>
+Date: Mon Dec 1 23:48:44 2014 +0100
- Make expert info text less verbose for missing ICMP response - no point in including frame number
+ BGP: Incorrect decoding AS numbers when mixed AS size
- Change-Id: I47ca8159c0716cb49da7ff77b1087cf37babe97e
- Reviewed-on: https://code.wireshark.org/review/4059
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
-
-commit f9d4e0a
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Sep 8 21:59:38 2014 -0400
-
- Replace deprecated tvb_length calls
+ Fix AS Path Heuristic
- And a few other misc. cleanups while in the neighbourhood.
+ Issue reported by Jon
- Change-Id: Ic0d6836dec9c36d31ea244a6adc74d4713565090
- Reviewed-on: https://code.wireshark.org/review/4047
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Bug: 10742
+ Change-Id: Ie5e4108bd93464a2d1076dcc4f322171ea8e68cb
+ Reviewed-on: https://code.wireshark.org/review/5564
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 1bf82c3
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Sep 10 09:51:34 2014 +0200
+commit 5eec6bb
+Author: Stig Bjørlykke <stig@bjorlykke.org>
+Date: Mon Dec 1 14:57:07 2014 +0100
- Add tche custom taps to WIRESHARK_TAP_SRC
+ multipart: Handle multipart/signed
- Change-Id: Ifedcc261585ea7308dbe3d493711d055d6d48237
- Reviewed-on: https://code.wireshark.org/review/4058
+ Change-Id: I39742dcce79fc41344c64e5266304c8c120aeb7c
+ Reviewed-on: https://code.wireshark.org/review/5557
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit f93c53e
-Author: Roland Knall <roland.knall@br-automation.com>
-Date: Tue Sep 9 14:27:02 2014 +0200
+commit 325014a
+Author: Stig Bjørlykke <stig@bjorlykke.org>
+Date: Mon Dec 1 14:47:02 2014 +0100
- EPL: Fix offset calculation
+ multipart: Don't include boundary in preamble.
- The offset was calculated too high, as it was added
- to itself and sizes were added multiple times
-
- Change-Id: I1a581e96e2ab66e40f5566074e8bd1089f55bdb0
- Reviewed-on: https://code.wireshark.org/review/4049
- Reviewed-by: Roland Knall <rknall@gmail.com>
+ Change-Id: I2d2fd28462b974e4ad656e36f2562633d0743962
+ Reviewed-on: https://code.wireshark.org/review/5556
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 93cc6f0
+commit 9441909
Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 9 14:05:52 2014 -0400
+Date: Mon Dec 1 23:08:50 2014 -0500
- Fix some spelling & grammar.
+ dftest: load plugins so plugin display filters can also be tested.
- Change-Id: Iedeaa411caa0823922dd79c27897a2349d4e6907
- Reviewed-on: https://code.wireshark.org/review/4054
+ Change-Id: Ideab88b525cf58b05502f11fb1cf0f58b2864c42
+ Reviewed-on: https://code.wireshark.org/review/5566
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 6e7f9ec
+commit d643325
Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 9 10:27:46 2014 -0400
+Date: Mon Dec 1 12:13:03 2014 -0500
- packet-sip.c: col_...() functions must not be called under 'if(...tree)' (even indirectly).
+ alljoyn: Rename some filters; Fix some filter types.
- Fixes Bug #10453
+ Details:
+ - Rename various "alljoyn.header..." display filter
+ names releated to the alljoyn "message header"
+ to "alljoyn.mess_header..." to distinguish
+ the fields from actual alljoyn "header" fields.
+ This also fixes the duplicate use of the display
+ filter name "alljoyn.header".
+ - Don't use FT_PROTOCOL for a field type.
- Change-Id: I39f64b801ce9231059ee7e03416dd3828dffeb1f
- Reviewed-on: https://code.wireshark.org/review/4051
+ Change-Id: Id4e78f36716cf6064638aecd5faf561bcbc88b46
+ Reviewed-on: https://code.wireshark.org/review/5561
+ Petri-Dish: Bill Meier <wmeier@newsguy.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Joe Huffman <jhuffman@codeaurora.org>
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit bf371e3
-Author: Anish Bhatt <anish@chelsio.com>
-Date: Thu Jul 10 19:51:50 2014 -0700
+commit 05c1aa2
+Author: Yann Lejeune <ylejeune@netyl.org>
+Date: Mon Dec 1 19:08:31 2014 +0100
- OSPF : cleanup hf_filter array
+ BGP: fix dissection of BGP community tag
- hf_filter array was removed. Compiles, did some manual testing and didn't see any regression. Bitfield still not changed over to inbuilt functions
+ The offset used for BGP community tag dissection is a wrong one.
- Change-Id: I510da6160c0f2375398b9ab30042ff172ae31c9f
- Reviewed-on: https://code.wireshark.org/review/3147
+ Bug: 10746
+ Change-Id: I1d1d443568bb97a0b3b95a312762ac0a3102326a
+ Reviewed-on: https://code.wireshark.org/review/5562
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit f91ef6d
+commit 6d207fe
Author: Michael Mann <mmann78@netscape.net>
-Date: Mon Sep 8 15:09:50 2014 -0400
+Date: Mon Nov 24 10:10:12 2014 -0500
- General cleanup of RTP-MIDI dissector.
+ Remove private_data member from packet_info structure.
- The biggest changes involved:
- 1. Use the "bounds checking" of proto_tree_add_xxx, instead of doing it manually. There are still places where it's done "manually", but they have been drastically reduced. Someone with more understanding of the protocol/dissector would need to take a look at them.
- 2. proto_tree_add_text -> proto_tree_add_subtree[_format]
- 3. Use proto_tree_add_bitmask when appropriate.
+ Dissectors should pass data directly to their subdissectors through the data parameter (of new-style dissectors). This avoids unintentional "trampling" from other dissectors trying to "share" private_data member.
- Change-Id: Iddbd2aadf5fd27f2cf9ba63873eb59dbd93b6394
- Reviewed-on: https://code.wireshark.org/review/4039
+ Change-Id: I2efef5c8dfeef64588ba3ac6e695b469238c6468
+ Reviewed-on: https://code.wireshark.org/review/5487
Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 80407a4
+commit e77507b
Author: Michael Mann <mmann78@netscape.net>
-Date: Sat Sep 6 08:44:23 2014 -0400
+Date: Mon Dec 1 00:18:41 2014 -0500
- Eliminate proto_tree_add_text from some of the dissectors.
+ Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
- Other minor cleanups while in the area.
+ Part 3 of many, but this concludes the strict conversion to proto_tree_add_bitmask. Patches to follow with use proto_tree_add_bitmask_xxx (some functions still need to be written)
- Change-Id: I99096ade9c69a4c148962d45bb6b0bd775040ba1
- Reviewed-on: https://code.wireshark.org/review/4020
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: Ic2435667c6a7f1d40602124e5044954d2a296180
+ Reviewed-on: https://code.wireshark.org/review/5553
Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 124923b
-Author: Michael Mann <mmann78@netscape.net>
-Date: Mon Sep 8 19:41:07 2014 -0400
-
- proto_tree_add_text -> something filterable.
-
- Most of the items fell under the same 3 filterable fields. Many got converted to proto_tree_add_bitmask. Also removed the superfluous return statements
-
- Change-Id: Ib429f986d1c3648e51add8ad3d208428b0ba898c
- Reviewed-on: https://code.wireshark.org/review/4044
Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit a23bbaf
-Author: Evan Huus <eapache@gmail.com>
-Date: Tue Sep 9 00:00:10 2014 +0000
-
- Revert "Explicitly lengthen some constants to 64 bits"
-
- Guy already fixed the issue, I was looking at a stale buildbot page.
-
- This reverts commit f9bfa976e67da2f8065f172de9ed06fad61762a8.
-
- Change-Id: I04e2f1ddfae9558b6cec40740ffbb66a16c3fecb
- Reviewed-on: https://code.wireshark.org/review/4046
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit f9bfa97
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Sep 8 19:52:56 2014 -0400
-
- Explicitly lengthen some constants to 64 bits
-
- Hopefully squashes the mac buildbot error
-
- packet-mp2t.c:993: warning: implicit conversion shortens 64-bit value into a
- 32-bit value
-
- Change-Id: I9ca6420925442b56cfdf5db629b63d6ead7bdfbd
- Reviewed-on: https://code.wireshark.org/review/4045
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit e8491ce
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Sep 8 17:40:30 2014 -0400
-
- Fix automatic generation of the dcerpc-eventlog dissector.
-
- The problem described in the README is simply because the conformance file
- hadn't been updated.
-
- Remove trailing white space from the .idl and .cnf files.
-
- Change-Id: I778f206aa103e5f60574fe2c5c699597969dc644
- Reviewed-on: https://code.wireshark.org/review/4042
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 7143bd7
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Sep 8 14:49:53 2014 -0700
-
- Do the PCR and the original PCR the same way.
-
- In both cases, make the extension a 16-bit variable, cast the result of
- extracting the extension to guint16 to clarify that only the 9 bits
- visible through the mask matter.
-
- While we're at it, there's no need to use
- "proto_tree_add_uint64_format_value() if the format is just the standard
- format for a 64-bit unsigned integer.
-
- Change-Id: I8f1f48595830d4672984f3797be1c9d994e64ea0
- Reviewed-on: https://code.wireshark.org/review/4043
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 4af01a8
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Sun Sep 7 18:40:36 2014 +0200
+commit 542439e
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Dec 1 10:29:29 2014 +0100
- don't skip another 6 bytes after OPCR
- Bug: 10446
+ SNA: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
- simplify OPCR calculation while we're at it
-
- Change-Id: I8590e409895e712fe6bbb64ab23093caf5795fa7
- Reviewed-on: https://code.wireshark.org/review/4040
- Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: I7a491488e67890c6cde98beec6a4935b10505afb
+ Reviewed-on: https://code.wireshark.org/review/5555
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 412662af
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Sep 8 11:50:41 2014 -0400
-
- Register the dicom dissector by name so it can be used with SSL.
-
- Bug: 10450
- Change-Id: I786de3de39c6d4829135b67a64936c28757d1ff4
- Reviewed-on: https://code.wireshark.org/review/4038
- Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 00a2444
-Author: Jérôme LAFORGE <jerome.laforge@gmail.com>
-Date: Sun Sep 7 16:35:10 2014 +0200
+commit 0415df8
+Author: Marko Hrastovec <marko.hrastovec@gmail.com>
+Date: Mon Dec 1 09:43:26 2014 +0100
- Check hopcount is correctly incremented by 1
-
- Extract RFC3315 about hop-count :
- 20.1.2. Relaying a Message from a Relay Agent
+ Asterix: fix Coverity scan (1025624 & 1025625: Missing break in switch)
- If the message received by the relay agent is a Relay-forward message
- and the hop-count in the message is greater than or equal to
- HOP_COUNT_LIMIT, the relay agent discards the received message.
- The relay agent copies the source address from the IP datagram in
- which the message was received from the client into the peer-address
- field in the Relay-forward message and sets the hop-count field to
- the value of the hop-count field in the received message incremented
- by 1.
+ Two comments are added to the code to notify Coverity scan that breaks are not put in switch statement intentionally.
- Bug:10449
- Change-Id: Ifb94e7c54c0a26714fc543862d4358d3e60c2676
- Reviewed-on: https://code.wireshark.org/review/4017
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Ie391790ee7365da56ddf0bf7b19042c9a11efddd
+ Reviewed-on: https://code.wireshark.org/review/5554
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit cf8f11f
+commit 4f9af86
Author: Michael Mann <mmann78@netscape.net>
-Date: Sat Sep 6 18:04:28 2014 -0400
+Date: Sun Nov 30 12:51:30 2014 -0500
- Eliminate proto_tree_add_text from some of the dissectors.
+ Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
- Other minor cleanups while in the area.
+ Part 2 of many
- Change-Id: I623d941e53128f169e55dfc629547b4221fa72fc
- Reviewed-on: https://code.wireshark.org/review/4021
+ Change-Id: I50815e7738b011382392f3078a7107d3d9eec4ec
+ Reviewed-on: https://code.wireshark.org/review/5542
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 433a444
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Sep 8 08:11:40 2014 -0400
-
- ses: initialize pres_ctx_id in session struct
-
- Bug: 10454
- Change-Id: Ib381646cad0a039514117735c48b461c9950f705
- Reviewed-on: https://code.wireshark.org/review/4033
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 3f04830
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Mon Sep 8 15:37:27 2014 +0100
-
- Try to fix build error by giving function a return type
-
- Change-Id: I157b6309bc8cb0bef6fc0cd213fd4ec7e4c375ef
- Reviewed-on: https://code.wireshark.org/review/4035
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
-
-commit 806981d
-Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
-Date: Mon Sep 8 13:55:23 2014 +0100
-
- Show band info for inter-freq entries in UE capabilities. Addresses Pascal's comments.
-
- Change-Id: Ie60dc73e40a2ac1d80197fa712075ccff83cf797
- Reviewed-on: https://code.wireshark.org/review/4032
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
-
-commit c1bc1b6
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Sep 7 15:01:10 2014 -0400
-
- Convert some deprecated tvb_length calls
-
- Change-Id: I6337f8e02a41106a363b9bf767bc4b3697442d41
- Reviewed-on: https://code.wireshark.org/review/4027
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 64cabe9
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Sep 8 14:39:19 2014 +0200
-
- Use dissect_e164_msisdn() for MSISDN.
-
- Change-Id: I297241cafee8ec504b46044cacba457c5f261d6e
- Reviewed-on: https://code.wireshark.org/review/4034
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 3a4b3e1
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Mon Sep 8 10:04:26 2014 +0200
-
- ZigBee: fix compilation when building without libgcrypt
-
- Change-Id: I4e60cbdaa7c56eca8f95945066dd31660fba045b
- Reviewed-on: https://code.wireshark.org/review/4031
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 95c3f06
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Sep 7 23:51:58 2014 -0400
-
- packet-gnm.h: remove: (should have been part of 07b003a "Remove obsolete dissectors")
-
- Change-Id: I80455f69c2830609fe34ee79492d37dc4103de10
- Reviewed-on: https://code.wireshark.org/review/4030
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 79d7e5d
-Author: Ronnie Sahlberg <ronniesahlberg@gmail.com>
-Date: Sun Sep 7 18:12:08 2014 -0700
-
- SCSI: fix dissection of ElementAddress... mode page for SMC devices
-
- Change-Id: If16ad422ab851f538af309fbf7d567bd2a13cace
- Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
- Reviewed-on: https://code.wireshark.org/review/4029
-
-commit aebd9d3
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 7 14:01:56 2014 -0700
-
- Remove blank line, add newline at the end of the file.
-
- Change-Id: I26bed6f3493ee7bb52439af9d72790a0133485c9
- Reviewed-on: https://code.wireshark.org/review/4028
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 2b27d91
+commit 86c659c
Author: Michael Mann <mmann78@netscape.net>
-Date: Sat Sep 6 21:32:39 2014 -0400
+Date: Sun Nov 30 15:53:45 2014 -0500
- Eliminate proto_tree_add_text from some of the dissectors.
+ Improve checkfiltername.pl for pre-commit script.
- Other minor cleanups while in the area.
+ 1. Bugfix grep statement checking if file is "autogenerated"
+ 2. Add to the list of "whitelist" duplicates. Many more were found after #1 was changed.
- Change-Id: Id8dab02df6f111c3462238c3de1bf201e037ca48
- Reviewed-on: https://code.wireshark.org/review/4022
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: Idea764c0c8b5fa4f30c9acaab9ba10340834d4f5
+ Reviewed-on: https://code.wireshark.org/review/5547
+ Petri-Dish: Evan Huus <eapache@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit f76b4d9
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Sep 7 08:06:30 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-09-07]
-
- Change-Id: I35bc2282b41810cc9644ded0b5c4036f4508264b
- Reviewed-on: https://code.wireshark.org/review/4024
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit ef444d3
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Sep 7 02:15:45 2014 -0700
-
- Squelch a compiler warning and get rid of an unnecessary variable.
-
- Just use "sizeof line" for the size of that array; don't have a separate
- variable with the number of elements of the array (which at least is
- equal to the size of the array, as it's an array of char), as that means
- that you have to remember to change both of them.
-
- Then cast "sizeof line" to int, as the second argument to fgets() is an
- int, not a size_t (fgets(), as I remember, existed before size_t).
-
- Change-Id: I3c65774527f4fcd824d7ae39208ab6e8e33eb9b4
- Reviewed-on: https://code.wireshark.org/review/4023
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 419de19
+commit 90977c7
Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Sep 4 08:35:51 2014 -0400
+Date: Sun Nov 30 16:17:26 2014 -0500
- Create subdissector table for RTAC Serial and have dissectors register with it, rather than have the RTAC Serial dissector go find all of the dissectors its interested in.
+ Update display filter names per checkfiltername.pl
- Change-Id: I6b6a05ec242e4798fb56ffa43c661ec277aca955
- Reviewed-on: https://code.wireshark.org/review/3984
- Reviewed-by: Chris Bontje <cbontje@gmail.com>
+ Change-Id: I7694a6f8d8ccec3109fb86ccefee5798de57757d
+ Reviewed-on: https://code.wireshark.org/review/5548
Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 0d6fb09
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Sep 6 10:32:29 2014 +0200
-
- GTK (conversations table): Fix Dereference of null pointer found by Clang analyzer
-
- Change-Id: Iebe0c581259b80d905f0ef3e26c1caae07f715d1
- Reviewed-on: https://code.wireshark.org/review/4012
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 24d1295
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 6 15:58:54 2014 -0700
-
- Don't give names to parameters you don't use.
-
- C++, unlike C, lets you do that. This squelches warnings from MSVC++.
-
- Change-Id: Id7127392b7690769111afdb951951d743f1d5e63
- Reviewed-on: https://code.wireshark.org/review/4019
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit d853e92
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 6 15:36:44 2014 -0700
+commit cd14ff3
+Author: Peter Wu <peter@lekensteyn.nl>
+Date: Sat Nov 29 19:32:30 2014 +0100
- Convert all the other function-defining macros.
+ qt: use qstring_strdup
- (Perhaps C2099 will finally deprecate old-style function definitions and
- allow you to declare parameters without names, just as C++ does, and
- compilers will - obviously - not warn about those parameters being
- unreferenced, obviating the need for __attribute((unused))__ and the
- like. And perhaps monkeys will fly out of....)
+ Replaces the more verbose `g_strdup(foo.toUtf8().constData())` by
+ `qstring_strdup(foo)`. While at it, plug a minor memleak in
+ MainWindow dialogs.
- Change-Id: Iff295c1854e66eb4f9e02cdd5761e0191d371365
- Reviewed-on: https://code.wireshark.org/review/4018
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I32b53f972b4e3998ac9beabd98647a381b7b42e3
+ Reviewed-on: https://code.wireshark.org/review/5531
+ Petri-Dish: Gerald Combs <gerald@wireshark.org>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 746a265
+commit 0cf2f74
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 6 13:08:40 2014 -0700
+Date: Sun Nov 30 17:03:20 2014 -0800
- Try to suppress MSVC++ unused parameter warnings.
-
- I haven't found a way to with MSVC to mark parameters in the argument
- list as unused. MSVC doesn't give warnings about them in C code, but
- does appear to give them with C++ code. An answer to
-
- http://stackoverflow.com/questions/3020584/avoid-warning-unreferenced-formal-parameter
+ Squelch another compiler warning.
- suggests not giving the formal parameter a name in C++.
-
- Have a macro UNUSED_PARAMETER(), which takes as an argument a variable
- name, and expands to nothing in C++ and to the variable name followed by
- _U_ in C, and use that for some unused parameters. If it works, we'll
- use it for all of them.
-
- Change-Id: I76107bed037f1f0d94615adb42234c9faf83b4db
- Reviewed-on: https://code.wireshark.org/review/4016
+ Change-Id: Ib79bb30e67dacdda2e87f39438c4a836632d55bd
+ Reviewed-on: https://code.wireshark.org/review/5552
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit afb939b
+commit cc0b083
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 6 11:51:59 2014 -0700
+Date: Sun Nov 30 17:00:04 2014 -0800
- Make the count of bytes read from the file 64 bits.
-
- We probably won't get files that big, but let's at least be prepared;
- that squelches some compiler warnings.
+ Squelch a compiler warning.
- Change-Id: Ia43ff78af7df63c7204c41d8331fea946de63116
- Reviewed-on: https://code.wireshark.org/review/4015
+ Change-Id: Ic904f9b8551353192e872cb896f198572da83e27
+ Reviewed-on: https://code.wireshark.org/review/5551
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 8482173
+commit ff18b35
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 6 11:44:15 2014 -0700
+Date: Sun Nov 30 16:57:09 2014 -0800
- Make some variables size_t, as values of that width are assigned to it.
-
- (I'd say "as values of that *type* are assigned to it", but the "len"
- field of a GString is of type "gsize", and, for some unknown reason, the
- GLib folks, rather than just using size_t, which is required by C89 to
- be available, invented their own "gsize" type, defined as "long", which
- happens to be narrower than "size_t" on LLP64 platforms such as 64-bit
- Windows. Sigh....)
+ Fix compile error.
- This squelches some compiler warnings.
-
- Change-Id: Ifca1300297b2e9b777fb2c426dda822ba157cfe5
- Reviewed-on: https://code.wireshark.org/review/4014
+ Change-Id: I858248e252a09f4348e7ab88bef81c8452f39051
+ Reviewed-on: https://code.wireshark.org/review/5550
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 0bafffb
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Sep 6 04:15:52 2014 -0700
+commit 18f0109
+Author: Peter Wu <peter@lekensteyn.nl>
+Date: Sat Nov 29 19:29:26 2014 +0100
- Put asn1 back as a distributed subdirectory.
+ qt: fix use-after-free pattern
- If it's not there, "make distcheck" fails. In addition, 1) "make
- distclean" doesn't clean out the Makefile.in files under asn1 and 2) you
- don't get to see the source from which the ASN.1 dissectors were built
- if you have a source tarball.
+ qstring.toUtf8() returns a QByteArray object and .constData() returns
+ a pointer inside that object. It is not safe to store this pointer as
+ it will become invalid after the statement. Store a const reference
+ instead. (Due to scoping differences, some are copy-assigned though.)
- Change-Id: Ied59d42950373476a535fcf9cfccece46de92599
- Reviewed-on: https://code.wireshark.org/review/4013
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 07b003a
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Fri Sep 5 15:40:18 2014 +0200
-
- Remove obsolete dissectors.
-
- Change-Id: Icd480491670de9d8495a95861b18a8a5cb9724b4
- Reviewed-on: https://code.wireshark.org/review/4006
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit ceef7eb
-Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Sep 5 08:48:37 2014 -0400
-
- Eliminate proto_tree_add_text from some of the dissectors.
+ In the UAT dialog, strlen(bytes.constData()) has also been replaced by
+ bytes.size() as an optimization.
- Other minor cleanups while in the area.
+ Caught by ASAN.
- Change-Id: I8ea59205cfe6fab643d8fe01b75ce91532004fd9
- Reviewed-on: https://code.wireshark.org/review/4004
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Change-Id: Ie09f999a32d0ef1abaa1e658b9403b74bedffc37
+ Reviewed-on: https://code.wireshark.org/review/5528
+ Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit f1ad9eb
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 5 15:21:37 2014 +0200
+commit 846bb53
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sun Nov 30 16:30:19 2014 -0800
- MySQL : Eliminate proto_tree_add_text (use proto_tree_add_debug...)
+ Add a Buffer to wtap_pkthdr to hold file-type-specific packet metadata.
- Change-Id: I2e14328715cd11bc1ce31dad91b1cc5ef4091130
- Reviewed-on: https://code.wireshark.org/review/4005
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit 914169f
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Sep 5 08:59:10 2014 +0200
-
- MySQL: add decode connattrs when use COM_CHANGE_USER
+ For example, this can be used for pcap-ng options not mapped to
+ file-type-independent metadata values.
- Change-Id: I5c24f0bf3d756abed0db17bf2ae8ab0dbf695c43
- Ping-Bug:10351
- Reviewed-on: https://code.wireshark.org/review/4000
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: I398b324c62c1cc1cc61eb5e9631de00481b4aadc
+ Reviewed-on: https://code.wireshark.org/review/5549
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit b515cd3
+commit 35b1bc5
Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sat Sep 6 00:32:05 2014 +0200
+Date: Sun Nov 30 20:29:34 2014 +0100
- 6LoWPAN: fix storage of contexts coming from ICMPv6 Router Advertisement messages
+ win32: use target file format when checking if it supports comments
- Bug: 10443
- Change-Id: I1a74b4d3036c61f0c8e1fca6373845ea40d87808
- Reviewed-on: https://code.wireshark.org/review/4008
+ Bug: 10656
+ Change-Id: Ib74f213630d6d382118c09b3cbf998b28cbc045e
+ Reviewed-on: https://code.wireshark.org/review/5544
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 56ae87a
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Sep 5 10:42:02 2014 -0400
- Fix compilation when we don't HAVE_GEOIP.
-
- Change-Id: Ib72178aab69c266cb903ef5ad5587cc0b80eb1fd
- Reviewed-on: https://code.wireshark.org/review/4007
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 8df622b
+commit 6c7af1d
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Sep 5 01:13:30 2014 -0700
+Date: Sun Nov 30 11:27:18 2014 -0800
- Fix compiler warnings.
-
- In our build environment, some UN*Xes define the historic index()
- routine in addition to the standard strchr() routine.
+ Change some names to make them the same in multiple lists.
- Change-Id: Id39ad42a60def6af4c5b3625528207e9d2948392
- Reviewed-on: https://code.wireshark.org/review/4002
+ Change-Id: I20ca39f69052b4134147577ae5be74c05b4d5e48
+ Reviewed-on: https://code.wireshark.org/review/5543
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 63d7f7f
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Sep 4 23:35:06 2014 +0200
-
- adjust the path to the translation files
- they were renamed from qtshark_... to wireshark_...
-
- Change-Id: I97b245a9028b4ed99812204114ba8f59357d49e8
- Reviewed-on: https://code.wireshark.org/review/3995
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit f4e2819
-Author: Gerald Combs <gerald@zing.org>
-Date: Thu Sep 4 20:42:42 2014 -0700
+commit 10046cc
+Author: Gerald Combs <gerald@wireshark.org>
+Date: Sun Nov 30 08:05:01 2014 -0800
- Fix compiler warnings from g30f3d52.
+ [Automatic manuf, services and enterprise-numbers update for 2014-11-30]
- Change-Id: I76fa088f72f0e31da9be105919d56fd8db1ea7b5
- Reviewed-on: https://code.wireshark.org/review/3999
+ Change-Id: I582091ce31fdd9e961b1000c2b58ef6cb2adca0d
+ Reviewed-on: https://code.wireshark.org/review/5539
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 97b0738
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Sep 4 15:14:59 2014 +0200
+commit 090a046
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sat Nov 29 16:57:20 2014 -0800
- CAPWAP: Add some new Message Element Type (RFC5415)
-
- * AC Timestamp (6)
- * Add Station (6)
- * CAPWAP Local IPv4 Address (30)
- * CAPWAP Local IPv6 Address (50)
- * CAPWAP Transport Protocol (51)
- * MTU Discovery Padding (52)
- * ECN Support (53)
+ Update to reflect current reality.
- Change-Id: Ib8b2768d5df4b0e1b5b8b5bd28ae66e825020205
- Reviewed-on: https://code.wireshark.org/review/3986
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I6defd7ffe92e9e07f4ff41166449d5a086800846
+ Reviewed-on: https://code.wireshark.org/review/5538
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 00cc4c7
-Author: Gerald Combs <gerald@zing.org>
-Date: Thu Sep 4 19:59:34 2014 -0700
+commit e28a847
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sat Nov 29 15:01:34 2014 -0800
- Fix the GeoIP include path.
+ Fix tfshark.c to match changes to epan/print.[ch].
- Change-Id: Ib4b3264a4da5b54b01061153e383f21e1bcf00b2
- Reviewed-on: https://code.wireshark.org/review/3998
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I765cd0dbb5451b578ccabd221afc477a6559e60c
+ Reviewed-on: https://code.wireshark.org/review/5537
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 74ca94b
-Author: Gerald Combs <gerald@zing.org>
-Date: Thu Sep 4 18:45:47 2014 -0700
+commit 81ab601
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sat Nov 29 14:43:22 2014 -0800
- Add the GeoIP include path to the Windows qmake build.
+ Clean up routine names, don't pass capture_file into libwireshark.
- It looks like we need to install and/or configure Qt on the Windows
- petri dish builder.
+ Give all routines in epan/print.c that write a particular format a name
+ beginning with write_{formatname}.
- Change-Id: I2bdde7cd9216e311d6402116d6c67b37d37e182d
- Reviewed-on: https://code.wireshark.org/review/3997
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 30f3d52
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Aug 6 10:07:42 2014 -0700
-
- Qt: Refactor ConversationDialog for endpoints.
+ If routines write columns, rather than the raw protocol tree, don't give
+ it a name containing proto_tree.
- Create a TrafficTableDialog (for lack of a better name) parent class
- from the general parts of ConversationDialog. Use it to create
- EndpointsDialog.
+ Get rid of empty preamble/finale routines.
- Move the contents of conversation_tree_widget.{cpp,h} to
- conversation_dialog.{cpp,h} to match endpoint_dialog and
- traffic_table_dialog.
+ For CSV, the preamble routine writes out column titles, so call it
+ write_csv_column_titles().
- Fill in GeoIP columns dynamically instead of using a hard-coded limit.
+ For C arrays, the body routine writes out raw hex data, so call it
+ write_carrays_hex_data().
- Use "endp_" and "ENDP_" prefixes for a lot of endpoint variables and
- defines.
+ capture_file isn't a structure defined by libwireshark, so don't make it
+ an argument passed into libwireshark.
- Try to make geoip_db_lookup_ipv4 and geoip_db_lookup_ipv6 more robust.
+ Change-Id: I5a7e04de9382cf51a59d9d9802f815b8b3558332
+ Reviewed-on: https://code.wireshark.org/review/5536
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
+
+commit 05516b0
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 29 15:41:12 2014 -0500
+
+ Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
- Clean up some includes. Fix a shadowed variable.
+ Part 1 of many
- Change-Id: I23054816ac7f8c6edb3b1f01c8536db37ba4122d
- Reviewed-on: https://code.wireshark.org/review/3462
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I77a5789ac23388e6a5f8098dc398592f39638124
+ Reviewed-on: https://code.wireshark.org/review/5532
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 382815d
+commit e399382
Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Sep 4 17:57:15 2014 -0400
+Date: Sat Nov 29 17:01:30 2014 -0500
- packet-netflow.c: Update "Information Elements" dissected based upon 08/13/2014 IANA IPFIX assignments document
+ Rename some hf[] display filter names to fix dups.
- Change-Id: Icfabdf5b77cdeef686620b75e649fc5bc270197a
- Reviewed-on: https://code.wireshark.org/review/3996
+ Change-Id: Ibe932bc37e03194f1801ec4eed4da1ff31370de3
+ Reviewed-on: https://code.wireshark.org/review/5535
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 4147b45
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Sep 4 23:08:59 2014 +0200
+commit 1aeab74
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Sat Nov 29 17:00:07 2014 -0500
- another lupdate + lrelease for Japanese
- this fixed the line numbers, marked some items as obsolete and added new
- items
-
- corrected some minor problems
+ ieee80211; Rename some hf[] display filter names to fix dups and for clarity.
- Promiscious Mode was changed to Monitor Mode, update the translation
- accordingly
-
- Change-Id: I63b3ef0fb3488d941d6d1170b911026281f94a0a
- Reviewed-on: https://code.wireshark.org/review/3994
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: Ibcca2d7f85130b4a5a74808d88735513cfc0b580
+ Reviewed-on: https://code.wireshark.org/review/5534
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 3b60797
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Sep 4 22:05:42 2014 +0200
+commit 785ef83
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sat Nov 29 07:26:42 2014 +0000
- From 竹下 恵 (Megumi Takeshita)
- japanese language update
+ Revert "Add QNX' QNET protocol"
- Change-Id: I92a68f389a7ac1e07eb11c970d5e37c31fde22c1
- Reviewed-on: https://code.wireshark.org/review/3993
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 82f5bdf
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Sep 4 20:11:37 2014 +0200
-
- ICMPv6: Remove soft deprecated API (tvb_length -> tvb_captured_length)
+ This reverts commit 72b91a56f86e3bbab700900366f81dc8c353b91d.
- Change-Id: Ib6161f778d902430f0903f5aef2df40c8166c5aa
- Reviewed-on: https://code.wireshark.org/review/3992
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 5ec1ab4
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Sep 4 20:05:47 2014 +0200
-
- tvbuff composite: add modelines infos (tabs)
+ value_string_ext tables ***MUST*** be sorted numerically, otherwise the code prints warnings such as the ones in
- Change-Id: I9ea2160b550243b45f6798ad3339f6a45b34a4ef
- Reviewed-on: https://code.wireshark.org/review/3991
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 67bff64
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Sep 4 20:04:56 2014 +0200
-
- tvbuff composite: fix Dereference of null pointer found by Clang Analyzer
+ http://buildbot.wireshark.org/trunk/builders/Ubuntu%2014.04%20x64/builds/1419/steps/test.sh/logs/stdio
- Change-Id: Ia43cb2e1cab99e4b769c8dfa0805d8e38e225a1c
- Reviewed-on: https://code.wireshark.org/review/3990
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit cccc927
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Sep 4 11:31:30 2014 -0400
-
- Update NEWS: Add S7 Communication dissector and the extcap interface.
+ Fix this and resubmit.
- Also add the S7 Communication dissector's author to AUTHORS.
- Mention that the Qt UI is now the default.
-
- Change-Id: Ie2629333fd48bbe1ce95052292336a4f8608ea17
- Reviewed-on: https://code.wireshark.org/review/3988
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: I448025bb7b19a607e992831202ed31d243ce70d8
+ Reviewed-on: https://code.wireshark.org/review/5530
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 3b20e02
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Sep 4 16:17:12 2014 +0200
+commit 1429986
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Fri Nov 28 23:10:44 2014 -0800
- Fix Mac OS X buildbot
-
- packet-s7comm.c:962: warning: declaration of 'time' shadows a global declaration
+ Sadly, index() was the name of a routine in V7, so....
- Change-Id: I4020b780e787a91c42f08f7b7b1c7feabcabdc62
- Reviewed-on: https://code.wireshark.org/review/3987
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: Id83899de08e0ad8e5664dddfb6ca268e7d0bd54d
+ Reviewed-on: https://code.wireshark.org/review/5529
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 2c9af79
-Author: Roland Knall <roland.knall@br-automation.com>
-Date: Wed Jun 25 18:17:50 2014 +0200
+commit 72b91a5
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Jun 17 17:03:11 2014 +0200
- openSAFETY: Add datafield for preload
+ Add QNX' QNET protocol
- - Block Up-/Download will be removed from the protocol
- It has never been implemented => no impact
- - Preload will be added in future versions of the
- openSAFETY specification
- - Better definition of SSDO ACMD sets to ensure correct
- protocol dissection
- - Use TFS.h t/f strings where applicable, remaining
- strings are referenced directly from specification
+ no ethertype 0x8203-0x8205 support in trunk.
+ 0x8204 is QNX OS VER 6's qnet ethernet protocol number.
- Change-Id: I9c809098938333c914e1f8ba67d100b994fd33f4
- Reviewed-on: https://code.wireshark.org/review/2647
- Reviewed-by: Roland Knall <rknall@gmail.com>
+ Bug:3934
+ Change-Id: I5f3e910876bb7fb86de2111f856d026fdf220917
+ Reviewed-on: https://code.wireshark.org/review/2954
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 1c1f187
-Author: Thomas Wiens <th.wiens@gmx.de>
-Date: Thu Aug 21 19:25:06 2014 +0200
+commit 8e17fd6
+Author: cbontje <cbontje@gmail.com>
+Date: Thu Nov 20 15:13:37 2014 -0700
- s7comm: Add dissector for S7 Communication
+ Add optional user Fast SER preference for SEL Fast Message Protocol
- S7 Communication is a Siemens proprietary protocol that runs between
- programmable logic controllers (PLC) of the Siemens S7-300/400 family.
+ * Also cleanup description of remaining preferences
- Dissector T.125 has to be disabled to let this dissector work.
+ See Bug 10719
- Change-Id: I578cf270a4ae567f8e20dbabec1ce1e13fc08e6e
- Reviewed-on: https://code.wireshark.org/review/3777
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: I81faba77d8b88b24c65156f5139067233869154b
+ Reviewed-on: https://code.wireshark.org/review/5416
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 27d1b6a
-Author: Evan Huus <eapache@gmail.com>
-Date: Wed Sep 3 22:48:46 2014 -0400
+commit ca95800
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Thu Nov 27 16:23:58 2014 +0100
- Bump the time limit for valgrind fuzzing
-
- Some captures are still hitting the limit as a false positive.
+ Endpoint: wrong filter when select a TCP endpoint (INVALID == a.x.y.z ...)
- Bug: 10122
- Change-Id: I12dd26ba0f96f44799f5ae642b1f9b0487f86a8a
- Reviewed-on: https://code.wireshark.org/review/3982
+ Change-Id: If56209f1274245f54100d0acfaf14098c8df4582
+ Reviewed-on: https://code.wireshark.org/review/5520
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 2497482
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Sep 3 21:57:02 2014 -0400
+commit f1b37bc
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Thu Nov 27 12:29:13 2014 +0100
- Don't print non-printable characters in AX.25 addresses.
+ Endpoint: wrong filter when select a UDP endpoint (INVALID == a.x.y.z ...)
- Add a new routine to wsutil to make this easy: printable_char_or_period().
-
- Bug: 10439
- Change-Id: I0eb2bb6bc0676a1035c3d845b5e20276fa04de60
- Reviewed-on: https://code.wireshark.org/review/3981
+ Change-Id: Ie46d6c201df0b0164a8bf96c02d6430734fd2948
+ Reviewed-on: https://code.wireshark.org/review/5518
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 1192606
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Sep 4 13:53:52 2014 +0200
-
- Fix Mac OS X buildbot
-
- packet-cp2179.c:719: warning: declaration of 'index' shadows a global declaration
-
- Change-Id: Ic622b4f90f9816a43bc62bcb3ce438fbfab3d8a5
- Reviewed-on: https://code.wireshark.org/review/3983
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit b4045ba
-Author: Stig Bjørlykke <stig@bjorlykke.org>
-Date: Wed Sep 3 08:49:54 2014 +0200
-
- Fix unused variable... [-Werror,-Wunused-const-variable]
-
- Use DATA_FRAG_FLAGS, disabled unused NACK_FLAGS
-
- Change-Id: I2d3dda2c3ab1ebbd66e32bf5ec1b62b521a7140d
- Reviewed-on: https://code.wireshark.org/review/3968
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit 23adc87
-Author: Qiaoyin Yang <qiaoyin.yang[AT]gmail.com>
-Date: Wed Jul 16 10:50:41 2014 -0600
-
- Add dissector for CP "Cooper" 2179 Protocol
-
- All credit for development should go Qiaoyin Yang
-
- CP2179 protocol is a serial based protocol. The 2179 protocol is implemented with minor variations between vendors.
- The RTAC implemented the 2179 client supporting a limited function codes and command codes. The RTAC doesn't support
- multiple function codes in a single request and the dissector also doesn't support decoding these or corresponding responses.
-
-
- Bug:10285
- Change-Id: I217bf4185c52b0b183f69b3b5aa84613340d3944
- Reviewed-on: https://code.wireshark.org/review/3089
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit 511e1fb
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Sep 3 21:39:04 2014 -0400
-
- Fix up some formatting.
-
- Change-Id: Ib38561ad5cf0f532e43ae3e10bbb857bb24ab9b6
- Reviewed-on: https://code.wireshark.org/review/3980
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 5e3a8fa
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Sep 3 14:41:02 2014 -0700
-
- Work around an apparent bug in GtkFileChooserButton.
-
- It looks like some versions of GTK+ intialize GtkFileChooserButton with a
- location set to NULL and crash when you select an item from the dropdown
- menu. Make sure we have a valid location set in that case.
-
- Change-Id: If2556ef939b95d8af12581a7116a48fb46586f57
- Bug: 10434
- Reviewed-on: https://code.wireshark.org/review/3977
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 3582029
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Tue Aug 26 16:41:45 2014 +0200
+commit 3355ed6
+Author: Peter Wu <peter@lekensteyn.nl>
+Date: Tue Nov 25 19:40:12 2014 +0100
- RPKI RTR: Add support draft-ietf-sidr-rpki-rtr-rfc6810-bis-01
+ elf: fix FDE Count formatting
- Add new PDU : Router Key (9)
- Add new field (Expire, Retry... interval) for END OF DATA PDU
+ Displays the FDE Count as a number, not a series of bytes.
- Ping-Bug:8296
- Change-Id: Ic30ab0ff9d0f9989eb7d157f85b74a54d09fb0e7
- Reviewed-on: https://code.wireshark.org/review/3948
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit bf8d601
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Sep 3 17:59:06 2014 +0200
-
- RTPS: Add Modelines info
-
- Change-Id: Ib29fb16d3b82b53aba52e2d13be2ce8e8727ccfb
- Reviewed-on: https://code.wireshark.org/review/3973
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I60dd426cb5305a5001a8200578008b7c4a99c64e
+ Reviewed-on: https://code.wireshark.org/review/5489
+ Reviewed-by: Peter Wu <peter@lekensteyn.nl>
+ Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 3e5ef80
+commit e8cda3b
Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Thu Aug 28 20:08:39 2014 +0200
+Date: Tue Nov 25 23:14:50 2014 +0100
- tvbparse: do not increment the token length when the new sub token length is 0
+ TCP: move Windows Scaling and SCPS checks after options decoding
- It fixes the unwanted addition of ignore characters when using tvbparse_some as seen with the capture from bug 10417
+ This was changed in g8881f3f in an attempt to avoid throwing an exception when decoding the options field
- Change-Id: If68b587e1821fb34aa1fb56666986e1fa6385c33
- Reviewed-on: https://code.wireshark.org/review/3905
+ Bug: 10514
+ Change-Id: Ia4b49f484d6255090c5a6e425a9716b48ccc4cb5
+ Reviewed-on: https://code.wireshark.org/review/5495
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 660da5e
+commit afcdff0
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Sep 3 17:56:21 2014 +0200
+Date: Thu Nov 27 11:11:18 2014 +0100
- RTPS: fix Result of operation is garbage or undefined
-
- Missing get num_virtual_guids value...
+ Endpoint dialog (Qt): Add missing text to translate
- Change-Id: I81a3dea3c96fb946c5c26ffe4ab2bfb82d1d8222
- Reviewed-on: https://code.wireshark.org/review/3972
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I375b348b6d6e35c212f76fc73135990a93560a75
+ Reviewed-on: https://code.wireshark.org/review/5517
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 241df85
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Sep 3 17:22:52 2014 +0200
+commit a67d0d2
+Author: Michael Mann <mmann78@netscape.net>
+Date: Thu Nov 27 22:33:22 2014 -0500
- ICMPv6: fix missing space before 6LBR
+ Eliminate proto_tree_add_text from packet-sna.c.
- Change-Id: Ibfb53df05691b67ac08a4f54ab0949ea17a89f89
- Reviewed-on: https://code.wireshark.org/review/3971
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Also convert many of the proto_tree_add_boolean calls into proto_tree_add_bitmask.
+
+ Change-Id: I1fb2f943abed28434a2aadc48eb7e9ffb766f463
+ Reviewed-on: https://code.wireshark.org/review/5523
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 01ca28d
+commit 3f85761
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri May 16 15:13:48 2014 +0200
+Date: Wed Nov 26 20:08:07 2014 +0100
- Don't need include ipproto.h
+ RADIUS: Sync with FreeRADIUS Master
- Change-Id: Ia2fe7df0ec72c0ba9eb77ea4beafe58be20d901d
- Reviewed-on: https://code.wireshark.org/review/3970
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 4ca9a5e
-Author: AlexL <loginov.alex.valer@gmail.com>
-Date: Wed Sep 3 13:50:21 2014 -0400
-
- Updated translations (add Comment fields) for desktop integration.
+ commit 30dac6d3dc87aaaa9c29ecdb33874fa57c2bcbc6
+ Author: Alan T. DeKok <aland@freeradius.org>
+ Date: Tue Nov 25 16:45:45 2014 -0500
- Patch submitted via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10442
+ as found on the net
- Bug: 10442
+ commit ee79c59d3a1cae76fcb1940710d9a0f7fbdf8427
+ Author: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
+ Date: Thu Nov 13 17:39:46 2014 -0500
- Change-Id: Idf73b058cff5db520cde951e58e85e5f71c680e2
- Reviewed-on: https://code.wireshark.org/review/3975
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 4c0fed8
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Sep 3 09:10:35 2014 -0700
-
- Don't override the PA package naming convention. Use our full version in
- the package name. Set a minimum OS version (Vista). Update some comments.
+ Add memcached rlm_cache_driver
- Change-Id: I28096276d2588993136b008a307dbcc7983496b0
- Reviewed-on: https://code.wireshark.org/review/3974
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit c1325e8
-Author: Jérôme LAFORGE <jerome.laforge@gmail.com>
-Date: Mon Sep 1 11:15:47 2014 +0200
-
- Check whether the hop-count of most inner message is equal to 0
-
- Extract RFC3315 about relay message and hop-count :
-
- 20.1.1. Relaying a Message from a Client
-
- If the relay agent received the message to be relayed from a client,
- the relay agent places a global or site-scoped address with a prefix
- assigned to the link on which the client should be assigned an
- address in the link-address field. This address will be used by the
- server to determine the link from which the client should be assigned
- an address and other configuration information. The hop-count in the
- Relay-forward message is set to 0.
-
- 20.3. Construction of Relay-reply Messages
-
- A server uses a Relay-reply message to return a response to a client
- if the original message from the client was relayed to the server in
- a Relay-forward message or to send a Reconfigure message to a client
- if the server does not have an address it can use to send the message
- directly to the client.
-
- A response to the client MUST be relayed through the same relay
- agents as the original client message. The server causes this to
- happen by creating a Relay-reply message that includes a Relay
- Message option containing the message for the next relay agent in the
- return path to the client. The contained Relay-reply message
- contains another Relay Message option to be sent to the next relay
- agent, and so on. The server must record the contents of the
- peer-address fields in the received message so it can construct the
- appropriate Relay-reply message carrying the response from the
- server.
-
- For example, if client C sent a message that was relayed by relay
- agent A to relay agent B and then to the server, the server would
- send the following Relay-Reply message to relay agent B:
-
- msg-type: RELAY-REPLY
- hop-count: 1
- link-address: 0
- peer-address: A
- Relay Message option, containing:
- msg-type: RELAY-REPLY
- hop-count: 0
- link-address: address from link to which C is attached
- peer-address: C
- Relay Message option: <response from server>
-
- Change-Id: I774cc22c9c090af1a5d3732115c7cd3478343288
- Bug:10437
- Reviewed-on: https://code.wireshark.org/review/3936
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 798b1e1
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Sep 3 13:07:26 2014 +0200
-
- Actually use the define of custom plugins...
-
- Change-Id: Id831e3bff943d9000969f951c3a2b9ead173e033
- Reviewed-on: https://code.wireshark.org/review/3969
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 8eaf902
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Jun 9 12:16:19 2014 +0200
-
- ieee802.11: Add VHT Action (802.11ac)
+ commit 6277960bc830891123b00400af56912e51d4d311
+ Author: Alan T. DeKok <aland@freeradius.org>
+ Date: Tue Oct 28 17:01:49 2014 -0400
- Add VHT MIMO Control (Part of VHT Compressed Beamforming)
+ Add FreeRADIUS-Response-Delay-USec
- No yet supported :
- * VHT Compressed Beamforming Report, MU Exclusive Beamforming Report (8.5.23.2)
- * Membership Status Array, User Position Array (8.5.23.3: Group ID Management)
- * Operation Mode (8.5.23.4: Operation Mode Notification)
-
- Bug:10169
- Change-Id: I182a487687d44f0ef77a045a99f82c92fba8ff2c
- Reviewed-on: https://code.wireshark.org/review/2146
+ Change-Id: I705d0e852d38eaace4f71cfc0a38ecdd41c0b58f
+ Reviewed-on: https://code.wireshark.org/review/5510
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 8ffd2f3
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Tue Sep 2 16:15:14 2014 +0200
-
- CAPWAP: fix some message type with wrong length (don't use optlen for "fixed type length")
-
- Change-Id: Id666086abdd55e38bcb470f8015363585d40728f
- Reviewed-on: https://code.wireshark.org/review/3957
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 4f4c6ed
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 25 12:54:11 2014 +0200
-
- CAPWAP: Add some news expert info
-
- When it is the mininum wrong length for Message Element Type or
- when the Message Element Type is not yet decoded by Wireshark
-
- Change-Id: I49aca0df5ba5ec70d8fb764fef39c17c46ee22a0
- Reviewed-on: https://code.wireshark.org/review/3956
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit ee92864
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 20 10:08:15 2014 +0200
+commit 8839d7b
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Thu Nov 27 16:07:16 2014 -0800
- CAPWAP: Add new ett variable
+ Make the ENTTEC dissector reject packets that don't look like ENTTEC packets.
- Avoid to have all subtree has expended
+ This should avoid questions like
- Only 2 ett actually and there is > 20 subtree...
+ https://ask.wireshark.org/questions/38198/what-is-enttec-in-a-pcap-file
- Change-Id: Ia4af85345a6f1963d24d1fd589ff8ee09a8ef412
- Reviewed-on: https://code.wireshark.org/review/3955
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 7a87447
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 20 09:46:47 2014 +0200
-
- CAPWAP: Split CAPWAP Control and Data in 2 different protocol
+ It also splits DMX-over-UDP and DMX-over-TCP into separate dissectors,
+ as
- Avoid to have 2 CAPWAP in Decode as (and more easy to use too...)
+ 1) DMX-over-TCP has only config packets, DMX-over-UDP has the
+ others;
- Change-Id: I3a332e9b4b069b9215c38b5c08872bd07ac4c2c3
- Reviewed-on: https://code.wireshark.org/review/3954
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 653dc8b
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 11 23:55:30 2014 +0200
-
- CAPWAP: Use standard boilerplate (see doc/packet-PROTOABBREV.c)
-
- For hf field, reindent code
- Use 0x0 by default for bitmask
- Remove also some "boilerplate" comment..
+ 2) that would let us do reassembly, if necessary, for
+ DMX-over-TCP.
- Change-Id: I552ccca2e444f3686ee9ecdad456f2ecfbaa5cba
- Reviewed-on: https://code.wireshark.org/review/3953
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I2606c814693028c7ba2bbc458e45c853372baaf3
+ Reviewed-on: https://code.wireshark.org/review/5522
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit ec2fe0f
+commit a30f3d5
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 11 17:34:28 2014 +0200
+Date: Wed Nov 26 16:38:30 2014 +0100
- CAPWAP: Wrong usage of FT_BOOLEAN for Reserved field...
+ Qt: Add long option for -R (--read-filter) and -Y (--display-filter)
- Change-Id: Ie1c472f4db105a1a8db9dba265039282872dffb2
- Reviewed-on: https://code.wireshark.org/review/3952
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Id535c04493f6c6df88006d922ee43cff9f4b70a1
+ Reviewed-on: https://code.wireshark.org/review/5507
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-commit 6b5669d
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 2 22:36:03 2014 -0700
+commit b4b6a5d
+Author: Enrico Jorns <ejo@pengutronix.de>
+Date: Fri Sep 26 12:07:03 2014 +0200
- Fix dist. Remove unused files.
+ canopen: LSS dissection
- Change-Id: I44b2dbfa3859841c67e933d8e7c510834b7cc2ee
- Reviewed-on: https://code.wireshark.org/review/3967
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit cf3218d
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 2 18:05:03 2014 -0700
-
- OS X packaging fix.
+ Dissection of Layer setting services (LSS) sub-protocol
+ according to CiA 305.
- Change-Id: I82936bb1dcfa3a7ca1aea8a3ded388015aa37531
- Reviewed-on: https://code.wireshark.org/review/3966
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I24ca1827b25c30a672fb31cad390b3c1486102f4
+ Reviewed-on: https://code.wireshark.org/review/5516
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit b03eeeb
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 2 17:55:48 2014 -0700
+commit 608d83c
+Author: Maarten Bezemer <maarten.bezemer@gmail.com>
+Date: Thu Nov 27 11:24:40 2014 +0100
- Fix the PortableApps package name.
+ LEX and YACC are required
- Remove Installer.nsi while we're here.
+ When building both LEX (flex) and YACC (bison or yacc) are required to generate C files from l(ex) and y(acc) files
- Change-Id: I739d5d825fd76eac9b50d26fab2d44e853dc83f9
- Reviewed-on: https://code.wireshark.org/review/3965
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit d3e1164
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 2 17:19:56 2014 -0700
-
- PortableApps: Remove invalid makefile commands.
-
- Change-Id: I6ed0f72a6915cd12d7866c978dce0d25c328dffd
- Reviewed-on: https://code.wireshark.org/review/3964
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit ccb0a88
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Tue Sep 2 16:35:58 2014 -0700
-
- Added name to AUTHORS
-
- Change-Id: I7f65d22d4dd96908033c764461196a75716b298a
- Reviewed-on: https://code.wireshark.org/review/3961
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: I8892a05eb437d0bef613b68f681225df2cb2c6b4
+ Reviewed-on: https://code.wireshark.org/review/5515
+ Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-commit aee3de9
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 2 16:56:42 2014 -0700
+commit 121d9ae
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Thu Nov 27 00:15:24 2014 -0800
- OS X packaging fix: wireshark-qt → wireshark.
+ Note that this document is a bit old.
- Change-Id: Ie95c28ca47baf453335abab23eb7baba63d52f47
- Reviewed-on: https://code.wireshark.org/review/3963
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: Ie9a45acf1d3bc116d73b6430b058ffdcabead42b
+ Reviewed-on: https://code.wireshark.org/review/5514
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 85eec7f
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Tue Sep 2 12:18:20 2014 -0700
+commit 4469346
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Wed Nov 26 20:41:16 2014 -0500
- Fix PortableApps packaging.
-
- Our Windows portable packaging environment has a lot of cruft which is
- no longer relevant. We removed support for U3 packages and the method
- we use to generate PortableApps packages has been deprecated for a while.
-
- Create PortableApps packages using current file formats (AppInfo v3.0)
- and tools. Generate the PA launcher using the PortableApps.com Launcher
- generator. Copy files and directories from the top level instead of using
- a manifest derived from the NSIS installer.
-
- The manifest is a good idea, but we should create a central manifest
- and use that to generate the NSIS and PortableApps packages instead of
- trying to parse wireshark.nsi.
-
- The new package still needs a bit of work but it installs and runs in
- the current version of the PA Platform.
-
- Remove the define for MAKENSIS_UNICODE. It doesn't look like we were
- using it.
+ Fix a number of dup hf[] filter-names probably mostly resulting from cut/paste errs
- Start tearing down makefiles and scripts that we no longer use.
-
- Ping-Bug: 4191
- Change-Id: Ib7173eec887d0abf69bb176a1e3f943a5a63bee4
- Reviewed-on: https://code.wireshark.org/review/3962
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: Id658b9e1803b2f5b92e711a3ce981ff602333d98
+ Reviewed-on: https://code.wireshark.org/review/5513
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 9555c24
+commit c28f280
Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Sep 2 14:41:52 2014 -0400
+Date: Wed Nov 26 18:18:57 2014 -0500
- packet-netflow.c: netflow v9: Allow options template with zero-length scope section
-
- Fixes Bug #10432
-
- Also: rework several comments.
+ Fix a number of dup hf[] filter-names probably resulting from cut/paste errs.
- Change-Id: I292829f6dffaf5f500cb089cc8a45e1203a2e731
- Reviewed-on: https://code.wireshark.org/review/3959
+ Change-Id: I9242300b2ace3155c1506b584a90f073100a305e
+ Reviewed-on: https://code.wireshark.org/review/5512
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 1a44607
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Aug 11 16:18:08 2014 -0400
+commit cc893ab
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Wed Nov 26 23:01:48 2014 +0100
- Simplify ./configure logic for telling rpmbuild which GUI(s) we're building.
-
- Rather than checking for all the "--with" arguments just use the "$have_xxx"
- variables.
+ XML: pass XML structure to caller through p_(add|get)_proto_data functions
- Don't allow rpmbuild's ./configure to decide to build a GUI just because it's
- available: make it build only what was ./configure'd.
+ Since ge3a04bb data parameter is used for the media-type string
- Change-Id: I68582b4c13da7b52d56591dce68ac426e9f607f1
- Reviewed-on: https://code.wireshark.org/review/3958
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Bug: 10729
+ Change-Id: I3df640079a8bf57f4bd86a1baa08cbf9a3a7e1b3
+ Reviewed-on: https://code.wireshark.org/review/5511
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit b7fb116
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Aug 28 16:48:53 2014 -0700
+commit c2913d2
+Author: Enrico Jorns <ejo@pengutronix.de>
+Date: Thu Sep 25 12:53:26 2014 +0200
- Qt → wireshark. GTK+ → wireshark-gtk.
+ canopen: Enhanced SDO decoding
- Make sure the Qt UI is named "Wireshark" and its executable is named
- "wireshark" or "wireshark.exe". Make sure the GTK+ UI is named
- "Wireshark 1" or "Wireshark (GTK+)" depending on how much the target
- audience is likely to care about UI toolkits. Make sure the GTK+
- executable is named "wireshark-gtk" or "wireshark-gtk.exe".
+ * Move sdo dissection to separate function
- It looks like moving to Qt 5.3 (g978faf3) broke the PortableApps
- package. It's likely even more broken now.
+ Added dissect_sdo() function to handle the more complex SDO dissection.
- Autotools out-of-tree builds also broke on Ubuntu 12.02 (automake
- 1.11.3) at some point. The first attempt to compile in ui/qt returns
- "error: source_file.cpp: No such file or directory". The second attempt
- works. Out-of-tree builds work fine on Ubuntu 14.04 (automake 1.14.1).
+ * SDO command specifier decoding
- Tested:
+ Decoding of both client and server command specifier for SDO transfers
+ according to CiA 301 Chaper 7.2.4.3.
- - Nmake builds
+ Note: Fully decoding block transfer frames is more complex and not supported
+ yet.
- - NSIS packaging
+ * basic SDO abort code decoding
- - CMake builds (Windows, OS X)
+ SDO abort codes as specified in CiA 301 Chapter 7.2.4.3.17 (Table 22).
- - Autotools build and distcheck
+ * Basic value ranges for object dict index parameter
- - RPM packaging
+ Object dict ranges as specified in CiA 301 7.4.1 (Table 41)
- To do:
+ * cs-based multiplexer and data decoding
- - Test Debian packaging
+ A data width of 4 byte is valid only for expedited transfer and a
+ multiplex value is present only in initialisation messages.
- - Fix PortableApps
+ This patch now handles also normal sdo segment data.
- Change-Id: I66429870e05fd2d6fc901942477959ed6164fce2
- Reviewed-on: https://code.wireshark.org/review/3919
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit b9e61be
-Author: Juanjo <juanjo@rti.com>
-Date: Mon Aug 25 17:11:20 2014 +0200
-
- RTPS: added new PIDs and included minor improvements
- - (Updated) Fixed code review issues
- - (Updated) Fixed whitespaces and code review issues
- - Representing now some NTP times as duration (not as date)
- - Added some vendor specific PIDs (RTI)
- - Added dissect_APP_ACK_CONF, dissect_APP_ACK and
- dissect_HEARTBEAT_VIRTUAL
- - Added is_discovery to dissect_serialize_data to avoid malformed
- packets when using mutable types (Wireshark assumes serialized
- data with CDR-PL encapsulation is always discovery data, what
- is not true when using Mutable types)
-
- Change-Id: I491750d95b12f386c41d7de4ae7e280781efa375
- Reviewed-on: https://code.wireshark.org/review/3836
- Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reference: CiA 301, Chapter 7.2.4.3.3 and 7.2.4.3.6
+
+ Change-Id: I37005894082d62eed1ddd85e09e3676aa3af8222
+ Reviewed-on: https://code.wireshark.org/review/5504
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit db6f197
-Author: Roland Knall <roland.knall@br-automation.com>
-Date: Fri Aug 29 14:52:29 2014 +0200
+commit d77c5a5
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Wed Nov 26 10:09:03 2014 -0700
- openSAFETY: Adapt CRC for false-positives
-
- - There are rare false-positives, where the entire
- frame consists of 0 except the addr and id field,
- which will lead to a correct crc#1 calculation,
- but still to a false-positive detection. This
- patch fixes that
-
- - Two undefinite-loop errors are corrected as well
+ Update the URL for the CPUID instruction documentation.
- Change-Id: Ibe5e56e0172ad3a3046bdc024da3711987116e8e
- Reviewed-on: https://code.wireshark.org/review/3918
- Reviewed-by: Roland Knall <rknall@gmail.com>
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Change-Id: I9729b3aa11027783a3557468743e91e180a6de8d
+ Reviewed-on: https://code.wireshark.org/review/5509
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit 9ee7c38
+commit a159ced
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Sep 1 08:29:50 2014 +0200
+Date: Wed Nov 26 15:20:27 2014 +0100
- NDMP: Fix Dereference of null pointer found by Clang analyzer
+ WCCP: Remove uneeded check (pinfo & info_tree)
- Change-Id: I314e7e00633f93dead6a092e059336a304e4a946
- Reviewed-on: https://code.wireshark.org/review/3940
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 53dbc0e
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Sep 1 08:38:14 2014 +0200
-
- NDMP: Fix indent (use tab)
+ Remove also some false positive Dereference of null pointer
- Change-Id: I00f4d206e9c27801f8557414b8cd1b5c52752b44
- Reviewed-on: https://code.wireshark.org/review/3941
+ Change-Id: I09687993531827c6e4f5178f3414ddd9a2702038
+ Reviewed-on: https://code.wireshark.org/review/5506
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 906f6b0
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Mon Sep 1 09:51:51 2014 +0100
-
- Removed unnecessary chmod commands
-
- Change-Id: Ia6e3f8c567159fc2cf19a8d427a29c5c6dcdf038
- Reviewed-on: https://code.wireshark.org/review/3942
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
- Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit b95e6e3
+commit a2c2f87
Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Aug 15 21:32:57 2014 -0400
+Date: Sat Nov 22 16:15:17 2014 -0500
- Escape double quotes when printing ABSOLUTE_TIME field
-
- This regression was introduced by the commit e5353bf1198d6abf748de78084ff64f597f13663 done for bug 10081
+ Remove the use of pinfo->private_data from dissectors that just save it to restore it.
- Bug: 10213
- Change-Id: I3925a47ef13055f10f49fa9fefd022731746fbb8
- Reviewed-on: https://code.wireshark.org/review/2572
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I13197cc48068bb35ee12a7023cfe5f76bbc4e264
+ Reviewed-on: https://code.wireshark.org/review/5486
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit f2a7a6d
-Author: Jamil Nimeh <jnimeh@gmail.com>
-Date: Tue Aug 26 18:26:19 2014 +0200
-
- TLS: fix dissection of status_request_v2 hello extension
-
- Bug: 10416
- Change-Id: I58a3faef227f7eafd61942cafa6e38a17557ee61
- Reviewed-on: https://code.wireshark.org/review/3865
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit f20d5d7
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 31 21:52:32 2014 -0700
+commit 449bc19
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Sat Nov 22 12:58:43 2014 +0100
- WSUG: Convert ``Telephony'' to AsciiDoc.
+ Qt: support the -R option to set a read filter on the command line
- Leave most of the content intact for now.
+ rename display_filter to read_filter in some places to make it clear
+ what it's used for
- Change-Id: I21aad681194d1bb1841e29f4ac41be4677fcb909
- Reviewed-on: https://code.wireshark.org/review/3939
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit f0ce0d7
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Sep 1 16:33:56 2014 +0200
-
- Add CMake stuff for custom plugins.
+ modify MainWindow::openCaptureFile() so that a read filter can be set
+ when the file name is passed in cf_path, not only when it's chosen from
+ a file selection dialogue
- Change-Id: I1eff6b902d9bd9fb8f3073ab0f4fc3dd143d0fc4
- Reviewed-on: https://code.wireshark.org/review/3946
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit c343932
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Sep 1 15:54:15 2014 +0200
-
- Add abillity to add custom crypto files.
+ don't display the read filter string in the filter toolbar
- Change-Id: I6c5b1cdb0a90f7604bdde088332c171332b43dcc
- Reviewed-on: https://code.wireshark.org/review/3945
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Ie8dc94cbd1ff7e61ce1e2a55518a28297daa5d51
+ Reviewed-on: https://code.wireshark.org/review/5446
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 85734de
+commit 691f647
Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Sep 1 10:51:21 2014 +0200
+Date: Wed Nov 26 13:36:03 2014 +0100
- Make it possible to build builtin custom dissectors and GUI files with cmake too.
+ [MGCP] When changing tvb_length(tvb) -> tvb_reported_length(tvb) it turns
+ out that tvb_new_subset(tvb, tvb_sectionbegin, sectionlen, -1) causes a
+ problem as reported_length is set to -1, set it to sectionlen.
- Change-Id: I28eee44f7c3a7e44da89f8b71cdacbe78115c7e3
- Reviewed-on: https://code.wireshark.org/review/3943
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I650d3fa1390be5add66ed44d0f70929b9eb0aad6
+ Reviewed-on: https://code.wireshark.org/review/5505
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit af3e2db
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 31 18:40:56 2014 -0700
+commit ab8cad28
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 22 11:54:54 2014 -0500
- WSUG: Convert ``Advanced Topics'' to AsciiDoc.
+ Remove sccp_info member from packet_info structure.
- Leave most of the content intact for now.
+ sccp_msg_info_t* is now passed from SCCP dissector to its subdissectors through dissector data parameter.
- Change-Id: Ie91fda8a3fe6ea2eb4c47acf7c41d7e6979235b0
- Reviewed-on: https://code.wireshark.org/review/3938
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: Iab4aae58f8995e844f72e02e9f2de36e83589fc0
+ Reviewed-on: https://code.wireshark.org/review/5442
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit a11b7bf
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 26 14:49:24 2014 +0200
+commit 7c47503
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Tue Nov 25 13:49:12 2014 -0500
- Use a common hf for international E164 numbers (MSISDN).
+ openflow: Use (what appear to be the) correct filter names for a few fields.
- Change-Id: Ie0103c04033d7bf69c92947b789ba4f5a300a74b
- Reviewed-on: https://code.wireshark.org/review/3863
+ Change-Id: I2acd93d99942601b34c85177d21bbc2c4a4e2633
+ Reviewed-on: https://code.wireshark.org/review/5492
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 5e6e060
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 31 13:47:39 2014 -0700
+commit 5464bc6
+Author: Enrico Jorns <ejo@pengutronix.de>
+Date: Thu Oct 2 16:09:38 2014 +0200
- WSUG: Convert ``Working with captured packets'' to AsciiDoc.
+ canopen: Improve NMT error control and SYNC message dissection
- Leave most of the content intact for now.
+ 1. Also show Reserved/Toggle bit of NMT error control
- Change-Id: Ic264814aa8e442df100ae8533098843ef6a2e6c9
- Reviewed-on: https://code.wireshark.org/review/3937
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit eb14a1f
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Aug 30 18:02:52 2014 -0700
-
- WSUG: Convert the ``File I/O'' chapter to AsciiDoc.
+ In case of the node guarding protocol this bit is used as a toggle bit.
+ In case of the hearbeat protocol this bit is reserved.
- Leave most of the content intact for now. Remove images for
- no-longer-supported versions of GTK+. Add an example for building the
- Guides to README.cmake.
+ Reference: CiA 301 (rev 4.2.0), Chap. 7.2.8.3.2
- Change-Id: Id9e6a308c91b594d1fb7f107d7b9b28074a92a8b
- Reviewed-on: https://code.wireshark.org/review/3931
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 4a3e62c
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 24 23:34:00 2014 +0400
-
- Don't show the echo/python command lines when making plugin.c
+ 2. Show optional 'counter' parameter of SYNC messages if available
- For consistency with epan/dissectors/Makefile.am. Also, remove the
- "with python" parts, since that's the only option now.
+ Reference: CiA 301 (rev 4.2.0), Chap. 7.2.5.3.1
- Change-Id: I761e1bf7995c1cc1ebd790013181fd6116b289a1
- Reviewed-on: https://code.wireshark.org/review/3925
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
+ Change-Id: I5dc0ab65e95fec4846a9c8bd8972ef2eba664ee2
+ Reviewed-on: https://code.wireshark.org/review/5484
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 95cd6b7
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 24 23:23:45 2014 +0400
+commit a559f2a
+Author: Evan Huus <eapache@gmail.com>
+Date: Tue Nov 25 20:27:07 2014 -0500
- Remove make-tapreg-dotc and its uses, since Python is now mandatory
+ dec-dnart: use pinfo-scoped memory for addresses
- Change-Id: I13fd57a288be68d18819826bf566ed7b5688ebaa
- Reviewed-on: https://code.wireshark.org/review/3926
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-
-commit 4f95327
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Aug 31 20:19:23 2014 +0200
-
- Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
+ They may be accessed during the print phase, at which point packet-scope memory
+ has already been freed.
- Change-Id: I0593b659dcd28929cf51a8b1147392f070574c9e
- Reviewed-on: https://code.wireshark.org/review/3934
- Reviewed-by: Roland Knall <rknall@gmail.com>
+ Bug: 10724
+ Change-Id: Ifcf5fc0c0857614edf85349b12dfe605abf6fef7
+ Reviewed-on: https://code.wireshark.org/review/5497
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 6c93cc4
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Aug 31 20:18:35 2014 +0200
+commit e843c67
+Author: Evan Huus <eapache@gmail.com>
+Date: Tue Nov 25 20:16:05 2014 -0500
- Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
+ wccp: use pinfo-scope memory for addresses
- Change-Id: I32ca31b879ccc458f12f37375c32bc089978b114
- Reviewed-on: https://code.wireshark.org/review/3933
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit eaaa35f
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sun Aug 31 20:35:14 2014 +0200
-
- conv is always used, remove _U_ (unused) flag
+ They may be accessed during the print phase, at which point packet-scope memory
+ has already been freed.
- Change-Id: I648b365b662bd902e26e0c61f6d3499e8543e504
- Reviewed-on: https://code.wireshark.org/review/3935
+ Bug: 10720
+ Change-Id: Ia2b160fd9de4ccaa3a4b8d9cb70fb9b32d4e08a0
+ Reviewed-on: https://code.wireshark.org/review/5496
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 37c23fc
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 31 11:31:33 2014 -0700
-
- WSUG: Fix URLs
-
- Fix broken download URLs in the introduction. Update some macros to use
- https:// URLs.
-
- Change-Id: I145e74e14ec04ce5fcf94a65cd5623059875c6e1
- Reviewed-on: https://code.wireshark.org/review/3932
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 446125a
+commit 85ca1cf
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 21 09:06:57 2014 +0200
+Date: Tue Nov 25 12:39:53 2014 +0100
- DNS: Add OpenPGP KEY (61) RRtype (draft-ietf-dane-openpgpkey-00)
-
- Not yet tested on real dns traffic
-
- Update also last updated DNS parameters (2014-08-12)
+ conversation_table: fix indent (use 4spaces) and add modelines info
- Change-Id: I6109d585584e5fca11c606a2230d8ef89cdbf7b6
- Reviewed-on: https://code.wireshark.org/review/3870
+ Change-Id: I76784f0252dcd095a3016ed014632e2a5c09265b
+ Reviewed-on: https://code.wireshark.org/review/5483
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 5bec37f
+commit f449be8
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 28 12:53:45 2014 +0200
+Date: Tue Nov 25 12:37:59 2014 +0100
- Fix error: parameter 'XX' not found in the function declaration (-Wdocumentation)
+ conversation_table: fix warning when generate documentation (doxygen)
- Change-Id: I0a56fb79d2ac3d874a48695ad0499bda96b4b655
- Reviewed-on: https://code.wireshark.org/review/3892
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit caf7352
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 28 18:49:03 2014 +0200
-
- Fix parameter 'key' not found in the function declaration (-Wdocumentation)
+ epan/conversation_table.h:335: warning: The following parameters of add_hostlist_table_data(conv_hash_t *ch, const address *addr, guint32 port, gboolean sender, int num_frames, int num_bytes, hostlist_dissector_info_t *host_info, port_type port_type_val) are not documented:
+ parameter 'host_info'
+ parameter 'port_type_val'
- Change-Id: Ie7f3e192d8980968da15921a8497153506df1fde
- Reviewed-on: https://code.wireshark.org/review/3903
+ Change-Id: I6c3b29750c856eb2665981553fcb8eecd8fe34ee
+ Reviewed-on: https://code.wireshark.org/review/5482
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit c14cac7
+commit 2ebaa59
Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Aug 31 08:06:02 2014 -0700
+Date: Mon Nov 24 14:51:13 2014 -0600
- [Automatic manuf, services and enterprise-numbers update for 2014-08-31]
+ Consolidate sequence analysis code.
- Change-Id: I35507fe1b4ac8ff3ec9391679769764656b9ff27
- Reviewed-on: https://code.wireshark.org/review/3928
+ Move scattered code for seq_analysis_info_t creation and destruction to
+ tap-sequence-analysis.[ch].
+
+ Change-Id: I87c14b1c83105a48d0ab149a3abba71e2a2fe21f
+ Reviewed-on: https://code.wireshark.org/review/5479
+ Petri-Dish: Gerald Combs <gerald@wireshark.org>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 26731e8
-Author: Jérôme LAFORGE <jerome.laforge@gmail.com>
-Date: Sun Aug 31 00:17:07 2014 +0200
+commit 5b360a9
+Author: Yaniv Kaul <mykaul@gmail.com>
+Date: Tue Nov 25 21:24:23 2014 +0100
- Check whether the hop-count exceeds the HOP_COUNT_LIMIT or not.
+ SCSI: type and scope fields are ignored in some SCSI persistent reserve service actions
- Change-Id: If1c089e069b93a7b90cb525cd642ac26c5efa2d0
- Reviewed-on: https://code.wireshark.org/review/3924
+ Bug: 10727
+ Change-Id: Id34f57b2a0b89867eec1b0a13db2eba037835804
+ Reviewed-on: https://code.wireshark.org/review/5493
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-commit f415e1c
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 30 16:21:10 2014 -0700
+commit e2ef6c4
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Tue Nov 25 14:44:03 2014 -0700
- Remove some unnecessary definitions.
-
- text2pcap.c uses pcapio.c to write pcap files, so it doesn't itself need
- to know what those files look like.
+ Add on to the dummy.cpp hack that forces wireshark to be linked with a
+ c++ compiler to automatically create a dummy.cpp file and remove it when
+ make clean is issued. This allows make tags to work again since the
+ file isn't missing.
- Change-Id: I013d0c094c27515af91f352b565bc9a8bad3e842
- Reviewed-on: https://code.wireshark.org/review/3927
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I17191ad2acc281734fa12da4d347fd3116018f67
+ Reviewed-on: https://code.wireshark.org/review/5494
+ Petri-Dish: Stephen Fisher <sfisher@sdf.org>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit 0d7c4fd
-Author: Michael Tüxen <tuexen@wireshark.org>
-Date: Sat Aug 30 20:38:33 2014 +0200
+commit e2132f9
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Tue Nov 25 00:43:06 2014 -0500
- Fix char signess issue.
+ openflow: Minor changes
- This bug was found by compiling wireshark on a Wandboard Quad
- using FreeBSD.
+ - Remove unneeded/undefined forward declarations;
+ - Create/use some extended value-strings;
+ - Do some whitespace changes.
- Change-Id: I34ac8a04612a918782160947599245539d6e9427
- Reviewed-on: https://code.wireshark.org/review/3923
- Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
+ Change-Id: I7961864f0e404e141d2887584751116011f8d941
+ Reviewed-on: https://code.wireshark.org/review/5490
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 2eced36
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Aug 29 13:19:13 2014 +0200
+commit 2015398
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Tue Nov 25 12:53:43 2014 -0500
- 6LoWPAN: fix dissection when using multicast address compression
+ proto.c: proto_registrar_dump_values(): don't skip "same name" fields.
- Also update the value_string arrays with the various SAM/DAM combinations
+ It appears that Wireshark allows (and currently has) fields with the
+ same name with differing "strings" content.
- Bug: 10426
- Change-Id: I87f13c29f42770ec655d85e2247b847bfe28e3ba
- Reviewed-on: https://code.wireshark.org/review/3915
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Iddac5a2c9f456a97ea676f2007f43d786482eebd
+ Reviewed-on: https://code.wireshark.org/review/5491
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 437b448
-Author: Stig Bjørlykke <stig@bjorlykke.org>
-Date: Fri Aug 29 19:36:59 2014 +0200
+commit 152b0c9
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 22 19:24:06 2014 -0500
- Mark Trap-PDU as obsolete for SNMP versions > 1
+ Remove support for pinfo->private_data in "data-text-lines", "data-l1-events" and "urlencoded-form" dissectors. Data must be passed from parent through dissectors data parameter.
- Change-Id: I967a1547eb97619042b620bb3d803a29cce9ebe1
- Reviewed-on: https://code.wireshark.org/review/3920
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I24ab56ce7d99f8ed670f4a50453223d4e6a46983
+ Reviewed-on: https://code.wireshark.org/review/5463
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 26ab2e4
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 29 07:48:18 2014 +0200
+commit e3a04bb
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 22 20:47:59 2014 -0500
- Qt Follow Stream Dialog : Add some missing text to translate
+ Ensure dissector data parameter is used instead of pinfo->private_data when passing data between dissectors using the "media_type" subdissector.
- Fix also indent
-
- Change-Id: I864cd785f3b17e6360be63922ca63e349ae13f25
- Reviewed-on: https://code.wireshark.org/review/3913
+ Change-Id: I82cbfed770b41404bc42cb6a4413db07d04dffdc
+ Reviewed-on: https://code.wireshark.org/review/5462
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 021351f
+commit 7f22ce7
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 29 07:54:59 2014 +0200
+Date: Mon Nov 24 19:50:11 2014 +0100
- PROTOABBREV: minor fix
-
- Fix typo PROTO_ABBREV -> PROTOABBREV
- Uncomment FIELDCONVERT
+ pre-commit tools: Add arg option to specify the commit id to be checked
- Change-Id: I7b64c09ecf0c22a38042156d958e1c6c850c839a
- Reviewed-on: https://code.wireshark.org/review/3914
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 0622e34
-Author: Diederik de Groot <ddegroot@talon.nl>
-Date: Fri Aug 29 01:57:03 2014 +0200
-
- Skinny:
+ If no commit id specify, it is HEAD
- Fix: ensure that string created in dissect_skinny_displayLabel is always NULL terminated (Fixing Bug: 10429 (Pascal))
- Fix: MiscCommandType should use videoFastUpdateGOB Union when command enum is videoFastUpdatePicture
- Manual Merge PatchSet 4 (Me) and Patchset 7 (Pascal)
- Fix Merged PatchSet 8 (Pascal)
+ Thanks to Michal for the help :-)
- Bug: 10429
- Change-Id: I87bc7c6eaff976d7a70856f5fbe8c0ded6257064
- Reviewed-on: https://code.wireshark.org/review/3893
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: Ibf579aed47c7574f9a01d868ae0d55bbe789a8a2
+ Reviewed-on: https://code.wireshark.org/review/5474
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 47f96d9
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Aug 29 13:37:16 2014 +0200
+commit b01ff09
+Author: Enrico Jorns <ejo@pengutronix.de>
+Date: Tue Nov 25 10:08:05 2014 +0100
- 802.11: rename Control Frame Extension field to match the spec
+ canopen: Fixed tree expansion
- As reported by Richard Sharpe on -dev: https://www.wireshark.org/lists/wireshark-dev/201408/msg00236.html
+ Previously the COB-ID and Type subtree also used the main ett_canopen
+ variable. This made control of subtree expansion impossible as both
+ parent and subtree nodes shared the same state.
- Change-Id: I16638982e14e566bb7e584a2d030c546d2223ebe
- Reviewed-on: https://code.wireshark.org/review/3916
+ Change-Id: I3dabf7f399e83bfcfbf78bc0e633e3696776c043
+ Reviewed-on: https://code.wireshark.org/review/5480
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 8db0144
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 28 21:20:56 2014 -0400
-
- Consolidate several 3GPP Diameter xml files into one.
-
- Change-Id: If6ef48fbcceaf0b3a3591086015b021c6a80956b
- Reviewed-on: https://code.wireshark.org/review/3911
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit fcf6794
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 28 21:37:25 2014 -0400
-
- Remove AVPs that aren't really 3GPP2 (they are 3GPP).
-
- (The 3GPP2 Ty trace in the menagerie wrongly marks several of these AVPs
- as being 3GPP2.)
-
- Change-Id: I27963fbf8e1da51e430c609784e0c8bb4575549d
- Reviewed-on: https://code.wireshark.org/review/3912
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit a71f680
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Aug 14 13:20:09 2014 -0700
-
- Qt: Rework the "Manage Interfaces" dialog.
-
- Convert QTableWidget to QTreeWidget.
-
- It looks like the GTK+ version has a separate set of apply/save buttons
- for each tab which *only* operates on that tab. This can result unexpected
- behavior which throws away changes if the user updates more than one
- tab. Use a single "OK" button that applies all of our changes instead.
-
- Reorder the tabs. Put Local Interfaces first and select it by default.
- Always show Remote Interfaces. Disable it on platforms that don't have
- PCAP_REMOTE.
-
- Automatically start editing when we add a new pipe. Don't immediately
- update pipe interface settings. Wait until we hit "OK" instead.
-
- Rename NewFileDelegate to PathChooserDelegate. Note that we might want
- to move it use it elsewhere in the application.
-
- Try switching the user-facing terminology from "Hide" to the more
- positive "Show".
-
- Tell the user that we don't save pipe or remote interface settings.
-
- Add a help URL for the "Manage Interfaces" dialog box.
-
- Use the GLib and Qt string functions and classes to split and join
- comma-separated preferences. This makes sure capture_dev_user_descr_find
- doesn't skip over the first interface. It also keeps the Qt code from
- adding a leading comma to our capture preferences.
-
- Add a note about strings to README.qt. Summary: Use QStrings.
-
- For another day:
-
- - If we *do* save remote settings we need to store credentials securely,
- e.g. with CryptProtectData.
-
- - Get rid of the remote settings dialogs. Their controls should fit in the
- remote settings tab.
-
- - Add an extcap tab.
-
- - We need getter/setter functions for global_capture_opts.all_ifaces. We
- iterate over it *way* too much.
-
- Change-Id: Ib7b61972f3ece4325e0230f725e7f2678acbb24b
- Reviewed-on: https://code.wireshark.org/review/3873
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit b65d0e0
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Aug 28 23:21:36 2014 +0200
-
- set usb_dissector_table for control messages to "other" and "reserved"
- add a comment to explain this
-
- Change-Id: I7aa04ab1653cd8e6ae82c230d93c4c8ead677ace
- Reviewed-on: https://code.wireshark.org/review/3910
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 9eb855b
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Aug 28 19:02:10 2014 +0200
-
- remove offset parameter from try_dissect_next_protocol()
-
- Change-Id: I7452e6c5a9a24d44f83338aeb1dae389b87c8701
- Reviewed-on: https://code.wireshark.org/review/3909
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit e3cbc06
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 28 15:28:27 2014 -0400
-
- Add 3GPP2 Tx AVPs. Move all the 3GPP2 stuff into its own XML file.
-
- Change-Id: I7197f84472139c99bafa5b68f724abaab0453faa
- Reviewed-on: https://code.wireshark.org/review/3908
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit c2f1511
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 27 23:15:19 2014 +0200
+commit c39776c
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Mon Nov 24 12:01:46 2014 -0700
- handle standard and non-standard setup requests in the same function
+ Remove unused ui_simple_dialog.h from qt Makefile.common
- Change-Id: I5204a2fc1082e8a6b8082ad58fb252d4ba6c8bcb
- Reviewed-on: https://code.wireshark.org/review/3901
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit c361211
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 27 23:03:59 2014 +0200
-
- simplify dissect_nonstandard_usb_setup_request()
- create setup_tvb in the calling function
-
- Change-Id: Id34635afbd25817b09535fc52d1ba396b2597e5a
- Reviewed-on: https://code.wireshark.org/review/3900
- Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: I366a52a037462cb059565365ea1eec5be228078f
+ Reviewed-on: https://code.wireshark.org/review/5475
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 6603ac9
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Aug 28 20:56:00 2014 +0200
-
- correct detection of USB header type
- this fixes a regression for linux USB headers without 64 bytes extension
-
- Change-Id: Icb79d983dac6dca25d04657d3324286c73d31f29
- Reviewed-on: https://code.wireshark.org/review/3906
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 7312c07
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Thu Aug 28 18:25:03 2014 +0200
+commit a600ef6
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 22 18:17:20 2014 -0500
- - Use e212 routine for IMSI.
- - Add top_tree to function calls to avoid a crash.
- - Set a21_prefs_initialized.
+ Have media dissector take its "media type parameter" from dissector data parameter instead of pinfo->private_data.
- Change-Id: I193ae87189dda9b3806f43c9be3916f1adf7bda2
- Reviewed-on: https://code.wireshark.org/review/3902
+ Change-Id: I0a0cb0b4838bc4e55a759fb6031355892c220c8e
+ Reviewed-on: https://code.wireshark.org/review/5461
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 384d95c
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 27 12:07:37 2014 +0200
+commit 518bb10
+Author: Michael Mann <mmann78@netscape.net>
+Date: Mon Nov 24 10:26:00 2014 -0500
- remove unnecessary try_dissect_linux_usb_pseudo_header_ext() call
+ Remove use of pinfo->private_data since it's not used anywhere.
- Change-Id: Iafe173d4625d7e57ee3bd9c2fe9a6e6176624dcc
- Reviewed-on: https://code.wireshark.org/review/3899
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: Ibb47fd1a0d498cc9791ca31ee625395905a7e999
+ Reviewed-on: https://code.wireshark.org/review/5464
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit c527d1a
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 27 11:40:46 2014 +0200
+commit 392dae5
+Author: Joe Fowler <fowlerja@us.ibm.com>
+Date: Tue Nov 18 13:13:46 2014 -0500
- merge dissect_linux_usb_pseudo_header_ext() and
- try_dissect_linux_usb_pseudo_header_ext()
+ Add new dissector for Shared Memory Communications over RDMA protocol (SMC-R)
- Change-Id: Ica9e3089cc6bfde9b52158ef5e161dfcddeb716a
- Reviewed-on: https://code.wireshark.org/review/3898
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 2fe2c62
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 27 11:32:04 2014 +0200
-
- remove two obsolete comments
+ RFC draft http://www.ietf.org/id/draft-fox-tcpm-shared-memory-rdma-05.txt
+ used as reference for packet dissection.
- Change-Id: I339655b699d998bd4194363df64d98543dcae624
- Reviewed-on: https://code.wireshark.org/review/3897
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 95194f9
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 27 11:29:18 2014 +0200
-
- NULL check for usb_conv_info
+ A small change was made to packet-infiniband, to add the Queue Number to the
+ info column. This allows for easy indentification of session traffic for a
+ particular QP.
- Change-Id: I6cb4347f73afcfe561d3dca846c846d481c1c3bd
- Reviewed-on: https://code.wireshark.org/review/3896
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit fa40c3a
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 26 16:00:28 2014 +0200
-
- req_type is the same as type
+ Also: infiniband: tvb_length() --> tvb_captured_length()
- Change-Id: Icdc94d65043feb5927aa0194cbef796e634bf3a9
- Reviewed-on: https://code.wireshark.org/review/3895
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Bug: 10715
+ Change-Id: I774ceffaa5c271cb6a28ab4ed21e53cd42f2547b
+ Reviewed-on: https://code.wireshark.org/review/5386
+ Petri-Dish: Bill Meier <wmeier@newsguy.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit ab03797
+commit 363b87a
Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 26 12:15:02 2014 +0200
-
- use proto_tree_add_subtree()
-
- Change-Id: I0182397a7a208a2be8587fa4060a8497b54bb273
- Reviewed-on: https://code.wireshark.org/review/3894
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit e7c11be
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 28 09:44:28 2014 +0200
-
- Fix error: not a Doxygen trailing comment found by Clang (-Wdocumentation)
-
- Change-Id: Ieff4b888b39c8da82f00b00e0609d89d1203aef9
- Reviewed-on: https://code.wireshark.org/review/3891
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit cf3b238
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 20 09:19:44 2014 +0200
+Date: Sat Nov 22 11:59:50 2014 +0100
- OSI util: Add modelines info
+ Qt: support the -Y option to set an initial display filter
- Change-Id: I15e44f2f10b80b7c7ce78ce84b748ce8ec7a2eff
- Reviewed-on: https://code.wireshark.org/review/3890
+ Change-Id: I7627265b876c6994b163df1c5b037f4dae2f6d42
+ Reviewed-on: https://code.wireshark.org/review/5445
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit c76e496
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 21 08:54:16 2014 +0200
-
- DNS: Update CDS and add CDNSKEY (draft-ietf-dnsop-delegation-trust-maintainance-14)
-
- Use DS dissector for CDS (see section 3.1) and DNSKEY dissector for CDNSKEY (see section 3.2)
-
- Change-Id: I2ee11dc0eb2b5c74447b58604b1611ed249bc329
- Reviewed-on: https://code.wireshark.org/review/3869
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 7660da2
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 21 08:43:57 2014 +0200
-
- DNS: Update EUI48 and EUI64 to final draft (RFC7043)
-
- Change-Id: I2b18ccb874a51e5e752462a34175df8d8a90ce41
- Reviewed-on: https://code.wireshark.org/review/3868
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit edcd2dd
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Aug 27 23:57:19 2014 +0200
+commit e899c3e
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sun Nov 23 23:06:34 2014 -0500
- NTP: fix parsing of control assignments with empty value
-
- Consider that ',' is a separator between assignments and make value presence optional
+ Eliminate proto_tree_add_text from some dissectors.
- Bug: 10417
- Change-Id: I23f2b4029548a1263d65ee11c6356270e7a89bd7
- Reviewed-on: https://code.wireshark.org/review/3884
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: Iadd80aab291e5de714891a9f3c79edeca19e9b93
+ Reviewed-on: https://code.wireshark.org/review/5458
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit 14b0d71
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 28 08:47:57 2014 +0200
-
- RPKI-RTR: enhance dissector
-
- * fix no display all append COL_INFO... (reset by col_set_clear...)
- * fix dissection when type is unknown
- * fix warning about soft-deprecated (tvb_length..)
- * fix indent
- * fix some typo (IPV6 => IPv6...)
-
- Ping-Bug:8296
- Change-Id: I246b04098200afd1528f632cc709f631422e745b
- Reviewed-on: https://code.wireshark.org/review/3888
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 845b781
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Tue Aug 26 13:13:57 2014 +0200
+commit 4f8a6ec
+Author: Matthieu Coudron <mattator@gmail.com>
+Date: Tue Nov 18 19:33:53 2014 +0100
- Bluetooth: btle: Clear info column before use it
+ TCP: fix wrongly set base_seq when ISN is 0 and tcp_relative_seq is
+ enabled
- This fix "btle" over "ubertooth" dissector, so messeges from both
- will not be merged.
+ tcp_analysis::base_seq could be set several times when the
+ TCP ISN was set to 0, thus inducing some undesired wraps such as 0-1
- Change-Id: I587b81a405f37d16e8ab417d94edfc633bfc14fc
- Reviewed-on: https://code.wireshark.org/review/3877
- Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
+ Bug: 10713
+ Change-Id: I69a0dfe677e93bf51015bf7a39ebf888631b12a4
+ Reviewed-on: https://code.wireshark.org/review/5387
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 852493a
+commit d5713e2
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 20 19:05:20 2014 +0200
+Date: Wed Nov 19 21:34:20 2014 +0100
- TCP/UDP/SCTP: fix Dereference of null pointer found by Clang Analyzer
-
- The warning coming after change in g018b84de8
+ hostlist_table (GTK): Fix Dereference of null pointer found by Clang analyzer
- Change-Id: Ia96cdb2993a6283d8de2647c6723ec6b2b0977eb
- Reviewed-on: https://code.wireshark.org/review/3752
+ Change-Id: If74dc38b2a9724b9d924092796db5b6beb97043c
+ Reviewed-on: https://code.wireshark.org/review/5400
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 4b11680
-Author: Luke Chou <luke.chou@gmail.com>
-Date: Thu Aug 14 03:38:54 2014 -0400
+commit 159626c
+Author: Maarten Bezemer <maarten.bezemer@gmail.com>
+Date: Mon Nov 24 16:30:52 2014 +0100
- 11ac decode update for IE196 Channel Switch Wrapper.
+ Update debian symbols
- Bug:10258
- Change-Id: Ic8d3ee5323b95c9e827b47ad284be58e11bc97f4
- Reviewed-on: https://code.wireshark.org/review/3593
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 5ee328e
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Aug 27 13:55:12 2014 -0700
-
- Increase the error buffer size for rpcap.
-
- If the rpcap port is unreachable pcap_findalldevs_ex can write more
- than PCAP_ERRBUF_SIZE bytes to errbuf. E.g. if we try to capture from
- Google's all-eights public DNS server we get:
-
- ----
- Can't get list of interfaces: Is the server properly installed on 8.8.8.8?
- connect() failed: A connection attempt failed because the connected
- party did not properly respond after a period of time, or established
- connection failed because connected host has failed to respond. (code 1
- ----
-
- Set the buffer to PCAP_ERRBUF_SIZE*4 bytes. Hopefully that's large enough.
+ * register_tap_ui is removed in a21436eaed
+ * wtap_read_bytes(_or_eof) are introduced in 670ebda4a6
- Change-Id: I19f34cda16050c1ba8b9d7d6ed2d8e77b945a2af
- Ping-Bug: 3554
- Ping-Bug: 6922
- Ping-Bug: 7021
- Reviewed-on: https://code.wireshark.org/review/3880
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: If815c686d57310f0d87f965b5b5c2a71b651cbad
+ Reviewed-on: https://code.wireshark.org/review/5465
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit a8523d7
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 27 15:06:09 2014 -0700
-
- At least some compilers don't allow warning pragmas inside functions.
-
- So wrap the entire function in USES_APPLE_DEPRECATED_API/USES_APPLE_RST.
-
- Change-Id: I6ae3e8ecc40bc407e6f7156ccc5d9dd8c51d650d
- Reviewed-on: https://code.wireshark.org/review/3885
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 2e67941
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 27 14:56:29 2014 -0700
-
- Use the <wsutil/ws_diag_control.h> stuff to disable -Wdeprecated-declarations.
-
- Change-Id: I4b1fcbf5b25f2515d45015c9e1c4a94d6cfbc79c
- Reviewed-on: https://code.wireshark.org/review/3883
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit c7ce0e0
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 27 14:48:22 2014 -0700
-
- Be more selective about turning off deprecation warnings.
-
- Only turn them off in the vicinity of those nasty cross-platform APIs.
-
- (This also checks in the generated Kerberos dissector, which we forgot
- to do in the last checkin.)
-
- Change-Id: I5dc9162ff64afe764e37866706590ed2ed965acb
- Reviewed-on: https://code.wireshark.org/review/3882
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit d04ec41
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 27 14:16:33 2014 -0700
+commit 059c257
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Mon Nov 24 16:50:10 2014 -0700
- Use FreeRADIUS's warning pragma controls to suppress Apple complaints.
-
- Apple would really rather that you use their Shiny Happy Frameworks
- rather than those crufty old cross-platform APIs. We are a
- cross-platform program, and will use platform-specific APIs only if
- there's enough benefit to doing so - and, in this case, that means
- "using the platform-specific APIs on OS X and the other APIs on other
- platforms", so that's two code paths to maintain, so "enough benefit"
- has to outweigh the issues with that.
+ Allow html version of man pages to be found when running from build
+ directory (they're in doc/ of the build directory).
- Change-Id: I370ba469a6f5892143d72179d15c9fe22d664fdf
- Reviewed-on: https://code.wireshark.org/review/3881
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I425fa847952cf9f74a948a89c0048077dfcf0ae2
+ Reviewed-on: https://code.wireshark.org/review/5478
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit 1b3bc9b
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Aug 27 12:12:57 2014 -0400
+commit 1cdf644
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Fri Nov 21 11:24:50 2014 +0100
- checkhf.pl: (Trivial) remove trailing whitespace.
+ A21: fix warning: no previous prototype for function ... [-Wmissing-prototypes]
- Change-Id: I37ece54d936541b5d92e8c323ffeb429d9cc5f33
- Reviewed-on: https://code.wireshark.org/review/3879
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit f4b135c
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Aug 25 22:39:59 2014 -0400
-
- packet-mausb.c: proto-reg-handoff() fixes
+ Second try... ;-)
- - proto_reg_handoff...():
- Fix handling of tcp port pref change;
- Rename 'gPORT_PREF' to 'mausb_tcp_port_pref';
- Do 'dissector_add_uint("llc.mausb_pid",..)' only once;
+ Remove also double space
- Change-Id: Ic4498560f61d0ce95f8109c3a1bb3c407221269b
- Reviewed-on: https://code.wireshark.org/review/3854
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: I77aa269c1abae18b4fb9daec6cc0ac862cf4ab9f
+ Reviewed-on: https://code.wireshark.org/review/5421
+ Petri-Dish: Anders Broman <a.broman58@gmail.com>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit cac381b
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Aug 27 15:40:33 2014 +0200
+commit 605a6ae
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 24 21:12:55 2014 +0100
- E.164: update list to Operational Bulletin No. 1057 (1.VIII.2014)
+ Mate: Fix indent (use tabs)
- Change-Id: If1767dcf9a533d10e0ac946a2f31d7f58ea7b01c
- Reviewed-on: https://code.wireshark.org/review/3875
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Change-Id: I9a02e4a063dc4fc173ff9b7596acd7f9ceba7aa7
+ Reviewed-on: https://code.wireshark.org/review/5477
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 41764ec
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Aug 27 15:36:45 2014 +0200
+commit e02c03b
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Mon Nov 24 12:07:59 2014 -0700
- E.212: update list to Operational Bulletin No. 1058 (15.VIII.2014)
+ Change capitalization of "DNS UDP [p]orts" to match "DNS TCP ports" in prefs
- Change-Id: I79d12c4699df01f3435fae5342aa5ec295316959
- Reviewed-on: https://code.wireshark.org/review/3874
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Change-Id: Ib0bffc6d5e4bd6b68f48a843b4b4cab7422aceb7
+ Reviewed-on: https://code.wireshark.org/review/5476
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit 2263b73
+commit 4b57edb
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Tue Aug 26 21:36:53 2014 +0200
+Date: Mon Nov 24 18:11:30 2014 +0100
- CAPWAP : Fix wrong offset for AC Name with Priority
+ MIPv6: Enhance ANI dissection
- Thanks to Massimo Velluci for sample
+ * Fix wrong length for Operator Identifier
+ * Display Latitude and longitude in Degrees
- Change-Id: Ibab2658c2c11c9940d3fdebb0bdc42752d57e1ae
- Reviewed-on: https://code.wireshark.org/review/3871
+ Bug:10712
+ Change-Id: Idf6ba63db3ff16710fd0de7a7fd2233148cbaf4a
+ Reviewed-on: https://code.wireshark.org/review/5473
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit c612029
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Tue Aug 26 10:16:58 2014 -0700
-
- Exclude MA USB TransferAck's from USB conversation
-
- the usb_trans_info struct only understands Requests & Responses.
- TransferAcks are currently treated as responses, which throws off
- the Request/Response pairing & dissection.
-
- This patch fixes tracking in the case when a TransferAck & TransferReq
- are in the same TCP packet. It does not fix the case where there are
- multiple TransferReq's or TransferResp's in 1 TCP packet.
-
- Eventually I want to revamp usb_trans_info structure to support:
- -multiple requests/responses per transaction (IE: retries)
- -TransferAck tracking
- -handling of multiple requests/responses in 1 TCP packet
-
- Change-Id: I09be6fecf55a40b4ea2a4f27bd753f3991ccabbd
- Reviewed-on: https://code.wireshark.org/review/3866
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit d6aa77d
-Author: Diederik de Groot <ddegroot@talon.nl>
-Date: Tue Aug 26 18:33:54 2014 +0200
+commit 15f6f56
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 24 18:34:19 2014 +0000
- Skinny:
+ Revert "Allow "(g)make tags" to work again"
- Do not try to create a wmem_strbuf whose size is bigger than the max size allowed -> using wmem_strbuf_new instead of wmem_strbuf_sized_new (Evan Huus)
- While we are at it, fix errors spotted by the pre-commit tools/SkinnyProtocolOptimized -> Did not get any, can you specify which errors ? (Pascal Quantin)
- FT_IPv6: 'ENC_BIG_ENDIAN | ENC_NA' -> 'ENC_NA' only (2) (Pascal Quantin)
- Revert back to wmem_strbuf_sized_new instead of wmem_strbuf_new (Pascal Quantin)
- Use wmem_strbuf_sized_new maxlength = 0 (Pascal Quantin)
+ This reverts commit 6b8fe87ef48abb95dd303871d0835c153cf8c891.
- Bug: 10409
- Bug: 10410
- Change-Id: Iebfcb53bc0a6289e02d10c38ecb717aa5c89389e
- Reviewed-on: https://code.wireshark.org/review/3862
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Change-Id: Ie4f681186c1555e6ab966e7db687035f7fc5e60f
+ Reviewed-on: https://code.wireshark.org/review/5472
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit efd9534
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 25 10:35:09 2014 +0200
+commit 6b8fe87
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Thu Nov 20 10:35:45 2014 -0700
- Add custom_layer_chm.xsl to UNKNOWN (fix checklicence)
+ Allow "(g)make tags" to work again
- Change-Id: I4c336f21f721443e83eca7b9bf8d7a6138b367f4
- Reviewed-on: https://code.wireshark.org/review/3827
+ Change-Id: Idcff82aceedbf42652741564e06ca53984078361
+ Reviewed-on: https://code.wireshark.org/review/5413
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 88a3b30
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Aug 24 23:43:46 2014 +0200
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
- Extcap: prevent a GLib assert when interface_opts.extcap_args is NULL
-
- I was able to trigger it when trying to change the options of extcap_example.py interface
-
- Change-Id: I9ecff51d47b3ef6e178637b31d49af46a1928acd
- Reviewed-on: https://code.wireshark.org/review/3822
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit e28f490
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Aug 24 22:35:52 2014 +0200
+commit 2baac34
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 24 18:18:00 2014 +0100
- Extcap: restore compatibility with GLib 2.16.0
+ CPHA : tvb_length -> tvb_reported_length
- While we are at it, fix what seem to be a memory leak in extcaps_init_initerfaces()
-
- Change-Id: I1bb9a1b44d16f986eedd192b15cce84c5881a917
- Reviewed-on: https://code.wireshark.org/review/3820
- Reviewed-by: Roland Knall <rknall@gmail.com>
+ Change-Id: I49a7ffb1fcff71d49593ab009036f21c3ae6a2d0
+ Reviewed-on: https://code.wireshark.org/review/5471
Reviewed-by: Anders Broman <a.broman58@gmail.com>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 8fee04a
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Tue Aug 26 10:38:20 2014 +0200
-
- USB: fix dissection of non standard USB setup requests
-
- Otherwise captures like the one found in bug 8161 do not dissect properly anymore (sub dissector is called twice)
-
- While we are at it, reorganize functions order to void a forward declaration
-
- Change-Id: Id02ef835ba24981902a1702f976db099fa07b0fd
- Reviewed-on: https://code.wireshark.org/review/3858
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit ff59722
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Tue Aug 26 12:05:49 2014 +0200
-
- USB: get rid of the remaining proto_tree_add_text instances
-
- Change-Id: I6acaa32745e32ec5728874549e420468499d9b24
- Reviewed-on: https://code.wireshark.org/review/3860
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit 7836a71
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Tue Aug 26 13:01:24 2014 +0200
+commit 1f5dbb0
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 24 17:16:52 2014 +0100
- Skinny: do not try to create a wmem_strbuf whose size is bigger than the max size allowed
+ CPHA: Update versions lists
- While we are at it, fix errors spotted by the pre-commit tools/SkinnyProtocolOptimized
+ Use also value_string ext
- Bug: 10409
- Change-Id: Ic84632e0563f801239603534121e3487cf0d6d24
- Reviewed-on: https://code.wireshark.org/review/3861
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 338f6ac
-Author: Josip Medved <jmedved@jmedved.com>
-Date: Mon Aug 25 20:56:17 2014 -0700
-
- Added Authentication-Method and afew other AVPs that appear in the SIP-Auth-Data-Item grouped AVP.
+ Request from Hugo van der Kooij
- Change-Id: Ie90ec71d8d574d38f32a5ff3de6ad5433b9e5e9f
- Reviewed-on: https://code.wireshark.org/review/3823
+ Bug:10723
+ Change-Id: I0603687215b7e82a987a4a6cde00eb996b04a77c
+ Reviewed-on: https://code.wireshark.org/review/5466
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 64cd827
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Mon Aug 25 15:02:10 2014 -0700
+commit 10803f2
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Fri Nov 21 16:23:24 2014 -0700
- Have dissect_usb_setup_request handle non-standard requests
-
- Moved code for parsing non-standard setup requests from
- dissect_usb_common() to dissect_usb_setup_request().
+ Second attempt at putting a description in the preferences page
- Also added header_info flag USB_HEADER_IS_MAUSB & updated mausb
- dissector.
-
- Change-Id: Ifa8abccbd57bf4dd3965f582872952383e6f737d
- Reviewed-on: https://code.wireshark.org/review/3851
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I6d196486e824c82d29f1c233ef3230ad8619715d
+ Reviewed-on: https://code.wireshark.org/review/5434
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit 3d4d021
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Mon Aug 25 12:56:14 2014 -0700
+commit 953e6b1
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 22 14:13:10 2014 -0500
- Non-standard USB control requests now handled in own function
+ Pass data to JSON through dissector data, not pinfo->private_data.
- Change-Id: Icf56f3f5899d17908dac4783d2b3e30373186eba
- Reviewed-on: https://code.wireshark.org/review/3850
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Change-Id: I21dc2777822f0836f486432343cc1238886ad29d
+ Reviewed-on: https://code.wireshark.org/review/5460
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 8d54f8a
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Fri Aug 22 17:40:48 2014 -0700
+commit 0c716f7
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Mon Nov 24 11:38:43 2014 -0500
- further rearranged control URB request conditionals
+ openflow; Fix a (no-effect) typo in openflow_version_values[]
- combined 2 sections for dissecting non-standard requests into 1
-
- Change-Id: I181346a69e2f96ff47b82f82d3aa69846c45614f
- Reviewed-on: https://code.wireshark.org/review/3849
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I7a51face9c675ac3c03f2306ec40293b4835e02e
+ Reviewed-on: https://code.wireshark.org/review/5468
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 3439943
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Fri Aug 22 17:11:16 2014 -0700
+commit 7309664
+Author: AndersBroman <anders.broman@ericsson.com>
+Date: Mon Nov 24 17:22:02 2014 +0100
- added try_dissect_linux_usb_pseudo_header_ext helper function
+ [SIP/DIAMETER] Reinstate the lost dfilter_store_sip_from_addr() and use it
+ for 3GPP AVP 601 Public-Identity.
- Change-Id: I05b0adaef2b979432e293bc26e2a122a0d3551fc
- Reviewed-on: https://code.wireshark.org/review/3848
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I5ef6608e7821779b00f79486860ee5f578828dfc
+ Reviewed-on: https://code.wireshark.org/review/5467
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 259e09e
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Fri Aug 22 16:31:28 2014 -0700
+commit 78849d0
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Mon Nov 24 15:51:27 2014 +0100
- rearranged control URB request conditionals
+ SMTP: escape ASCII strings printed to COL_INFO
- Rearranged conditionals for control URB request to limit variable scope.
- Now there are 2 major branches based on weather the URB has setup data.
+ This is already done automatically for the hf entries thanks to hfinfo_format_text() function
- Change-Id: I67172c4e949bbda363ccf939d404957258b73840
- Reviewed-on: https://code.wireshark.org/review/3847
+ Bug: 10536
+ Change-Id: I9ee56b795234a94f0e59c82a96e3e6cedf71c4e6
+ Reviewed-on: https://code.wireshark.org/review/5459
+ Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 827d899
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Tue Aug 26 06:32:55 2014 +0200
-
- The remaining build systems didn't know about the change of the
- capture chapter from xml to asciidoc either.
-
- Change-Id: Ia48d4e0e4b445aedabd29a8483bcc19f12c13b20
- Reviewed-on: https://code.wireshark.org/review/3857
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit 1b42025
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Tue Aug 26 06:29:55 2014 +0200
-
- Whitespace fix
-
- Change-Id: Ie42cc8df1066078d26966129fdd3e8b5643c722f
- Reviewed-on: https://code.wireshark.org/review/3856
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit 0be336c
-Author: David Ameiss <netshark@ameissnet.com>
-Date: Mon Aug 25 21:28:38 2014 -0500
-
- Added missing name to AUTHORS file.
-
- Change-Id: I674c60a39e9e85e441fdb28c14a0845e34115b53
- Reviewed-on: https://code.wireshark.org/review/3853
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 9f6afbc
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Aug 25 20:40:19 2014 -0400
-
- Fix typo
-
- Change-Id: I8e3b3115191ca7a9c5388e866e9add12b7689039
- Reviewed-on: https://code.wireshark.org/review/3852
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 7749263
-Author: Diederik de Groot <ddegroot@talon.nl>
-Date: Tue Aug 26 01:46:21 2014 +0200
-
- Skinny Dissector:
-
- Source Fix: Trailing Whitespace (Reported by Graham Bloice).
- Dissection Fix: ProtocolVer needed to be split up into two fields to display the protocol version correct during device registration
- Segfault Fix: Null Pointer Check required after returning from tvb_memdup, before calling strlen (Reported by Evan Huus)
- Fix: Whitespace (again)
-
- Bug: 10409
- Change-Id: Ib253ea843363792f678f2e724359f83f12ebfadc
- Reviewed-on: https://code.wireshark.org/review/3844
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 1c98a12
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Tue Aug 26 00:41:07 2014 +0200
-
- WSUG_chapter_capture is now an asciidoc file that gets converted
- into an xml file.
-
- Change-Id: I43ae59d14cbdcf460250cf62005aea4a2772d11f
- Reviewed-on: https://code.wireshark.org/review/3846
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit 0f8e506
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Tue Aug 26 00:26:46 2014 +0200
-
- The timezone for generating the NEWS file timestamp was changed to UTC
-
- Change-Id: I77187bf4738a20bcebd899e2a01afd6077ae7e6c
- Reviewed-on: https://code.wireshark.org/review/3845
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit 7f05ae6
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Mon Aug 25 07:54:13 2014 +0200
-
- As long as NEWS is still part of the git tree: At least don't differ
- because of different timezones.
-
- Change-Id: I93809447db29c2cc5f848edb438ee16372b57453
- Reviewed-on: https://code.wireshark.org/review/3824
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit a849371
-Author: Gerald Combs <gerald@zing.org>
-Date: Mon Aug 18 09:31:26 2014 -0700
-
- WSUG: Convert the "Capturing" chapter to AsciiDoc.
-
- Leave most of the content intact for now. Add a section on markup
- conventions to README.txt. Remove the .mediaobject border.
-
- Change-Id: I06cfd482a4c8ea63c90b9f59fcdf2afaf636a4a2
- Reviewed-on: https://code.wireshark.org/review/3821
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit d372873
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Sun Aug 24 19:06:56 2014 +0100
-
- Updates for docbook builds on Windows
-
- In config.nmake search for multiple versions of fop in a couple of places, preferring fop 1.1
- In Makefile.nmake remove any PYTHONPATH env var (as that's probably for Windows)
- and not the Cygwin python used in asciidoc
- In Readme.txt update some Cygwin package info
-
- Change-Id: I117ec6bbdabc34829b421fd514508383b925090f
- Reviewed-on: https://code.wireshark.org/review/3816
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-
-commit 1aead57
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 09:27:29 2014 +0200
-
- reformat dissect_usb_setup_response()
- make sure it can handle usb_conv_info==NULL
-
- Change-Id: I5f53b26fd6fe22471906b07b5dad8f4c07dffa55
- Reviewed-on: https://code.wireshark.org/review/3843
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit bfe9332
-Author: Diederik de Groot <ddegroot@talon.nl>
-Date: Mon Aug 25 19:00:05 2014 +0200
+commit daed807
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sun Nov 23 00:12:57 2014 -0500
- SKINNY: Fix some warning
+ Pass FrameID as data to the heuristic table, rather than use pinfo->private_data.
- Fix: cog [[[END]]] in packet-skinny.h.in
- Fix: error: expression which evaluates to zero treated as a null pointer constant of type 'const gchar *' (aka 'const char *') [-Werror,-Wnon-literal-null-conversion] (Reported by Alexis La Goutte and found by Clang 3.6)
-
- Change-Id: Ic354f349eef8a12a7e18e841b517ea4f72ba86f2
- Reviewed-on: https://code.wireshark.org/review/3842
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: Idd5818cbb2b1f8628bb29c2c71dfc6d41df89b5d
+ Reviewed-on: https://code.wireshark.org/review/5448
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit ab33c40
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Aug 25 09:37:35 2014 -0700
-
- More README.cmake updates.
-
- Change-Id: I1c7e51ee397171af0703878e509665c8119b37ba
- Reviewed-on: https://code.wireshark.org/review/3841
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit e2acc23
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Mon Aug 25 08:58:43 2014 -0700
-
- Use Segoe UI to render the HTML Help text.
-
- Change-Id: I0ff717dda35a39f34c3140f920f8ac2fe74e24bc
- Reviewed-on: https://code.wireshark.org/review/3840
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit cdc80af
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Aug 25 11:44:36 2014 -0400
-
- checkhf.pl: (Trivial) fix two typos
-
- Change-Id: I2a63127dcf819d671a4c814dcbd82b2dca5022d3
- Reviewed-on: https://code.wireshark.org/review/3838
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 3ba56ca
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Mon Aug 25 11:22:32 2014 -0400
-
- packet-a21.c: Minor changes
-
- - Comment out several "set but unused" lines of code;
- - initialize 'gcsna_handle' only once.
-
- Change-Id: I17a89ccff228b28d075d9db9289ad412892b2639
- Reviewed-on: https://code.wireshark.org/review/3837
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit d127b57
-Author: Matthieu Texier <matthieu@texier.tv>
-Date: Mon Aug 25 15:22:07 2014 +0200
+commit 6dbb97d
+Author: Dave Tapuska <dtapuska@google.com>
+Date: Mon Nov 17 17:12:36 2014 -0500
- BPG : issue with BGP AS path heuristic (AS_CONFED_SET)
-
- Add also a expert info when unable determine ASN length (2 or 4 bytes)
+ SSL: Implement Extended Master Secret
+ Store all handshake mesages in a buffer so that we can hash them
+ correctly when generating the master secret.
+ This change does not work correctly for DTLS retransmitted packets; that
+ are in the handshake as they will be hashed twice; which is bad. Looking
+ for ideas to implement this.
- Bug: 10399
- Change-Id: I24978e29e24f38c2e01e4b953a5a51496f0cf5a6
- Reviewed-on: https://code.wireshark.org/review/3831
+ Bug: 10686
+ Change-Id: Ied01d4cc37b4270f325070a8d1630d3123577a0d
+ Reviewed-on: https://code.wireshark.org/review/5168
+ Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit f1dd9bc
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 7 14:39:28 2014 +0200
-
- Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: I19df790d18e71d45df28dc6e8731cd2e1acb098b
- Reviewed-on: https://code.wireshark.org/review/3826
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 3eb3762
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Thu Aug 7 14:38:31 2014 +0200
-
- Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
-
- Change-Id: I4a2ba6902acc0cbd224a8926eeb7bd0b62b4d29e
- Reviewed-on: https://code.wireshark.org/review/3825
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit d3c649b
-Author: Marian Durkovic <md@bts.sk>
-Date: Sun Aug 17 09:18:34 2014 +0200
-
- TRILL ISIS: Implement all RFC7176 section 2.2 SubTLVs
-
- Bug:10391
- Change-Id: Ibdf3e4964668a57362b6d25ef4ae106d368f0e69
- Reviewed-on: https://code.wireshark.org/review/3668
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit f44e082
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 25 16:02:07 2014 +0200
-
- RPKI RTR: Wrong decoding of RPKI RTR End of Data PDU
-
- The decoding of the End of Data PDU ignores the Serial Number, i.e., the last 32 bit of this PDU. Instead of that the current dissector implementation starts to decode a new RTR PDU.
-
- Details of packet format see http://tools.ietf.org/html/rfc6810#section-5.8
-
- Found by Matthias Wählisch
-
- Bug: 10411
- Change-Id: I8451b5fbda18a034022b97ff442ddb2a2dabed7b
- Reviewed-on: https://code.wireshark.org/review/3832
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit c697a86
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Aug 24 16:36:26 2014 -0400
-
- packet-a21.c: Fix a bug; Do some other misc cleanup.
-
- - expert_...() and external dissectors shouldn't be called under 'if (tree)';
- - Remove (what appear to be) some unneeded casts;
- - (Misc cleanup)
-
- Change-Id: I5ced313d3342125b918e179529b12d2f3bc4d87a
- Reviewed-on: https://code.wireshark.org/review/3830
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit b737e2e
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 20 14:32:40 2014 +0200
-
- remove trans_info parameter from dissect_usb_endpoint_descriptor()
- (remove it in the call from mausb as well)
-
- add NULL checks for usb_conv_info, usb_trans_info
-
- Change-Id: I95d52b85e3fa0d42b6a20047053259aaca8754fe
- Reviewed-on: https://code.wireshark.org/review/3784
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit c284e12
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 20 14:41:26 2014 +0200
-
- remove trans_info parameter from dissect_usb_unknown_descriptor()
- remove now unused trans_info variable in mausb
-
- Change-Id: I99df8a1ed039134c9448546d0f1a738f203f9610
- Reviewed-on: https://code.wireshark.org/review/3785
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit d87fbc9
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 13 23:09:49 2014 +0200
-
- an endpoint_descriptor may only be sent from a USB device to the host
- as part of a GET DESCRIPTOR Response
-
- therefore, pinfo->destport==NO_ENDPOINT is always true for valid USB
- packets and we can remove the else branch
-
- Change-Id: I2163e3000cafa27113ee0e6173fd69b7ef17b812
- Reviewed-on: https://code.wireshark.org/review/3585
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit a6cbcb1
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Aug 25 13:25:10 2014 +0200
-
- Fix a typo RELEASE_OTHER_REASON 4 -> RELEASE_OTHER_REASON 3
- RFC 3057 3.3.1.2
- RELEASE_OTHER 0x3 Other reasons
-
- Change-Id: I5c2344600646cbfbef379aed5d3ffa9fc48da639
- Reviewed-on: https://code.wireshark.org/review/3829
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit e784002
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Sat Aug 23 16:26:50 2014 +0200
-
- TRILL ISIS: SubTLVs of Router Capability TLV are valid for MT-Capability TLV as well
-
- Change-Id: Idf466c021b1b188d9c6d55ba73a25257ba352412
- Reviewed-on: https://code.wireshark.org/review/3803
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 7fab56a
-Author: Diederik de Groot <ddegroot@talon.nl>
-Date: Sun Aug 24 21:46:18 2014 +0200
-
- Skinny: packet-skinny
- Add tools path to the python search path, fixing cog.py generation of package-skinny.c from packet-skinny.c.in
- Add GPLv2 License to parse_xml2skinny_dissector.py
-
- Change-Id: I91b76867b02d8cebc40bba35151db48bc2fcaeca
- Reviewed-on: https://code.wireshark.org/review/3819
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 549f5c4
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 24 23:29:01 2014 +0400
-
- Remove obsolete comments regarding the shell version of make-dissector-reg
-
- Change-Id: I93470e8c6e9afd6c1ebf735eb13141586964be0e
- Reviewed-on: https://code.wireshark.org/review/3818
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 7d81eab
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 24 11:24:20 2014 -0700
-
- Fix Autotools AsciiDoc configuration + CSS updates.
-
- Fix --asciidoc-opts in Makefile.am.
-
- Add borders around menu and keycap markup. I like the latter but the
- former could probably use more work.
-
- Change-Id: If02e3d00875106d6b8f8bcf01cd52b1df4f9b6c8
- Reviewed-on: https://code.wireshark.org/review/3817
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 7de88cc
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 24 09:13:11 2014 -0700
+commit eb93f3b
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sun Nov 23 17:03:42 2014 -0800
- Try to get HTML Help to render SVG.
-
- Add a custom stylesheet that inserts
+ Don't do unsafe pointer casting
- <meta http-equiv="X-UA-Compatible" content="IE=9" >
+ Don't cast a pointer-to-int into a pointer-to-pointer and pass the
+ resulting pointer to g_hash_table_lookup_extended() - pointers and ints
+ are *not* guaranteed to be the same size. Instead, just have a variable
+ of type gpointer, pass a pointer to *that*, and then run that result
+ through GPOINTER_TO_UINT().
- at the top of our HTML Help output. This *should* convince the
- WebBrowser control to draw our new SVG images.
+ This fixes a reproducible crash.
- Change-Id: Iae491128195d3738951f3d19e2f82dd3fc73d1d8
- Reviewed-on: https://code.wireshark.org/review/3814
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I42954f222ab59866cb909b80d9dbb1d2668d2aff
+ Reviewed-on: https://code.wireshark.org/review/5457
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit a68eab6
+commit ec650d4
Author: Peter Wu <peter@lekensteyn.nl>
-Date: Wed Jul 30 13:13:10 2014 +0200
+Date: Sun Nov 23 23:58:24 2014 +0100
- Hack to fix RTP player progress line position
+ elf: separate ett for program and sections entries
- PortAudio seems to return 0 as value for Pa_GetStreamTime() on
- a PulseAudio system using the ALSA host API. This is known for 3 years,
- but still has not been fixed. As this function basically gives us a
- monotonically increasing clock in seconds as double, just use the Glib
- library function for that. I don't know whether this adds much latency,
- but it is certainly better than breaking the progress line (and also
- the related auto-scroll).
-
- While at it, split the idx calculation and explain what each part does
- and add modelines. Remove invalid _U_ annotations.
-
- [1]: http://music.columbia.edu/pipermail/portaudio/2011-June/012452.html
-
- Bug: 10307
- Change-Id: I67fff531e0577add4b9b76052e286fb3fd5d01ff
- Reviewed-on: https://code.wireshark.org/review/3260
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit ed090dd
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Aug 24 08:05:34 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-08-24]
+ This makes it easier to focus on a single section entry, collapsing all
+ other entries.
- Change-Id: Ibe3e8e23f8ae5a136c1acb0eda4cfe03928616d2
- Reviewed-on: https://code.wireshark.org/review/3811
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 276a697
-Author: Diederik de Groot <ddegroot@talon.nl>
-Date: Wed Aug 13 12:44:57 2014 +0200
-
- [RFC] Skinny: Rewrite using automatic code generation
-
- Support: Protocolversion 0 - 22
- Includes: Callmanager to/from Cisco Phones, Inter CallManager Messages and CallManager to/from Cisco ASA
- Code Generator not included, because protocol does not evolve anymore / No newer versions to be expected
- Fixed: Added more readable information for SoftKeyTemplateRes and SoftKeySetRes, Added Bitfield processing, Added Longer Field Descriptions
- Fixed: message_handle array overrun, message_ids, hf_skinny fields format
- Fixed: dialedNumber Message, Setting data on si->fields (tap.h)
- Fixed: Comments made by Peter Wu
- Added: Code Generator Sources
- Fixed: hf_skinny blurp, XML Truncation, Updated ButtonTemplate, SoftKeyTemplate and SoftKeyRes presentation
- Fixed: EnblocMessage, DialedNumberMessage
- Added: DisplayLabels
- Added: dissect_skinny_DisplayLabel function to Lookup and Translate in the phone embedded strings to human readable form
- Fixed: CallInfoV2, OpenReceiveChannelAck, KeypadButton when generated by a 7912 running old firmware.
- Fixed: Made changes requested by Peter Wu, in last 2 reviews
- Fixed: ConfigStatV2, ServerRes
- Fixed: Comment made by Michael Mann
- Fixed: CheckAPI.pl / Petri Dish
- Fixed: Included packet-skinny.h and epan/dissectors/packet-skinny.h.in -> Petri Dish
-
- Change-Id: Ic2d2ead8ff0ce80668c9b2e249ce69f53e25a383
- Bug: 10262
- Reviewed-on: https://code.wireshark.org/review/2921
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
+ Change-Id: I3de72065eb279e9449496a7224508e5be85c3757
+ Reviewed-on: https://code.wireshark.org/review/5456
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit cda5c16
+commit 4d55e1f
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 24 01:56:36 2014 -0700
+Date: Sun Nov 23 12:30:59 2014 -0800
- Clean up capinfos output.
+ Presumably the intent is to dump *non*-dummy entries.
- Make sure there's always a space between a number and "[TGMK]bytes",
- "[TGMK]bits", and "[TGMK]packets".
+ I.e., presumably the intent is to dump *resolved* hosts, rather than
+ *unresolved* hosts where there's no known host name and the name field
+ is a string form of the address (the premise being that looking the
+ address up in the hash table repeatedly, and using the already-generated
+ string, will be faster than generating the string repeatedly).
- Change-Id: I710385303e451e9aea6fc9bbea562f59ca0d22c9
- Reviewed-on: https://code.wireshark.org/review/3810
+ Change-Id: Iad1beb1d5f9cd9ed92bad5386111cb659614ee4d
+ Reviewed-on: https://code.wireshark.org/review/5455
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit a52939c
+commit da5487f
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 24 01:12:13 2014 -0700
+Date: Sun Nov 23 00:20:10 2014 -0800
- Fix trailing blank.
+ Newlines at the ends of lines, please.
- Change-Id: Ide4afb2fb78c80800f04a40031fa1f35804f6464
- Reviewed-on: https://code.wireshark.org/review/3809
+ Change-Id: I7b484e3ddac7cb1330c966819514a9468ea69066
+ Reviewed-on: https://code.wireshark.org/review/5454
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit bb0c175
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 24 01:06:35 2014 -0700
-
- Strengthen the heuristics for pcap subtypes.
-
- When trying to guess what type of capture a file is, look for as many
- bogosities (caplen > len, microseconds >= 10^6/nanoseconds >= 10^9,
- too-high caplen, too-high original len, caplen > snapshort length), to
- increase the chances of guessing correctly.
-
- (Every time somebody uses 0xa1b2c3d4 as the magic number for a capture
- file that isn't standard pcap format, God kills a kitten. Please, think
- of the kittens.)
-
- Change-Id: I3f397d598ed61dc82e2832be30452ebe8ace98e8
- Reviewed-on: https://code.wireshark.org/review/3808
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 28bea6f
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Fri Aug 22 23:01:11 2014 +0100
-
- Add captype to the CMake options so it gets built if required
-
- Change-Id: I915a7caa32a1f644c30c1579a8ad15e39db9e02a
- Reviewed-on: https://code.wireshark.org/review/3799
- Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-
-commit 9754616
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Fri Aug 22 22:13:05 2014 +0100
-
- Modify includes of config.h so that out-of-tree builds, i.e. CMake
- don't pick up the in-tree copy.
-
- Change-Id: I7ec473876cdba1a025c52362d7f6adc62d24ce71
- Reviewed-on: https://code.wireshark.org/review/3798
- Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Roland Knall <rknall@gmail.com>
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-
-commit f88eca4
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Aug 23 22:21:38 2014 -0700
-
- Fix admon.graphics.path.
-
- Change-Id: I43d7d56f0fc2bd73efc54a685aea90f635b145ff
- Reviewed-on: https://code.wireshark.org/review/3807
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit d310115
-Author: Gerald Combs <gerald@zing.org>
-Date: Wed Jul 23 18:28:32 2014 -0700
-
- Convert admon graphics to SVG.
-
- Use a common set of SVG files for AsciiDoc / DocBook admonition
- graphics. Put them in a common directory. According to
- http://caniuse.com/svg all common browsers have had SVG support for
- a while now.
-
- The graphics themselves were created with Inkscape. If you would like
- to refine them further you are more than welcome.
-
- Use variables to assemble xsltproc commands in Autotools and Nmake
- while we're here.
-
- Try to update Debian rules to reflect ga92c3fb.
-
- Change-Id: If82647af27a60117c517125dff0aca81c033be72
- Reviewed-on: https://code.wireshark.org/review/3206
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 7d035a1
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Aug 23 18:15:52 2014 -0700
-
- WSUG: Minor fixups for the statistics chapter.
-
- Fix a quotation warning. Use the menu:[] and button:[] macros. Other
- minor changes. Clean up whitespace.
-
- Change-Id: I3ae98ddcbd90c8d22284a9ef467268dabee8f829
- Reviewed-on: https://code.wireshark.org/review/3806
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit a92c3fb
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sat Aug 23 16:09:58 2014 -0700
-
- CMake: More a2x / asciidoc fixes.
-
- Create graphics directories and copy files into them similar
- to Autotools and Nmake. Adjust some xsltproc arguments. Fix the
- --asciidoc-opts flag.
-
- Note: Admon graphics are broken pending change 3206.
-
- Change-Id: I94d498de36150a7cb4ffd080581523300b222bd4
- Reviewed-on: https://code.wireshark.org/review/3805
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 40c367e
+commit b2030ca
Author: Gerald Combs <gerald@wireshark.org>
-Date: Sat Aug 23 19:51:22 2014 +0000
+Date: Sun Nov 23 08:04:42 2014 -0800
- Windows: Fix AsciiDoc / DocBook builds.
-
- The "quotes" section of the Asciidoctor compatibility file appears to
- be incompatible with Cygwin's version of AsciiDoc (8.6.3).
+ [Automatic manuf, services and enterprise-numbers update for 2014-11-23]
- Change-Id: Ifd08095effa07bc7277a2fff9de322dda51a8d47
- Reviewed-on: https://code.wireshark.org/review/3804
+ Change-Id: I6f8a66b742571dcde011125df9295daedc5652a7
+ Reviewed-on: https://code.wireshark.org/review/5450
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 02c5a12
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 17 09:23:31 2014 -0700
-
- WSUG: Convert the "User Interface" chapter to AsciiDoc.
-
- Add the "asciidoc.conf" compatibility configuration file from
- Asciidoctor. Although we don't use Asciidoctor it gives us macros that
- keep us from losing some useful DocBook elements. Update various CMake
- files to support multiple AsciiDoc configuration files.
-
- Leave most of the content intact for now. Hopefully the other chapters
- aren't as laden with markup.
-
- Change-Id: Id69757342b86abb2b3130cb61e90f5695a26ea8a
- Reviewed-on: https://code.wireshark.org/review/3680
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 6854d89
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sat Aug 23 13:02:48 2014 +0200
-
- USB: call USB control dissector table when recipient is "other"
-
- Otherwise USB HUB dissector is no more called (see the capture in bug 8161 for an example)
-
- Change-Id: Ie8ac1c8ca19bf292d8fc69d9b0b3729f696ffc07
- Reviewed-on: https://code.wireshark.org/review/3802
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 59b750c
-Author: Michael Tüxen <tuexen@wireshark.org>
-Date: Sat Aug 23 12:44:31 2014 +0200
-
- Update the SCTP PPIDs.
-
- Change-Id: I0b34e544d4332f2b5d8dcc287861636db86ac1b9
- Reviewed-on: https://code.wireshark.org/review/3801
- Petri-Dish: Michael Tüxen <tuexen@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
-
-commit 2068b31
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 22 21:17:36 2014 -0400
-
- Add the 3GPP2 Ty Application ID and a bunch of Ty AVPs.
-
- Change-Id: If36c8a22c34a88bbb43afbc932cd0b8193dd9c7b
- Reviewed-on: https://code.wireshark.org/review/3800
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit df335d5
-Author: Garming Sam <garming@catalyst.net.nz>
-Date: Fri Nov 22 14:19:03 2013 +1300
+commit e50095c
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 22 23:11:32 2014 -0500
- Cope with MIT being line wrapped when compiling with kerberos
+ Remove use of pinfo->private_data (which doesn't appear to be used anyway) and pass it as dissector data.
- The line "Massachusetts Institute of Technology" now appears
- across two lines in the header file.
+ Some other minor cleanup while in the neighborhood.
- Change-Id: I618b520d6c15f51180b47d93c75e29a6f43b868b
- Reviewed-on: https://code.wireshark.org/review/3790
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
+ Change-Id: I1b0c0567488fa350c14d21c5f5e4cb9746177af1
+ Reviewed-on: https://code.wireshark.org/review/5447
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 06565a7
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Wed Aug 20 22:29:33 2014 +0100
-
- Add WinSparkle to the CMake build to bring it into line with
- the nmake build
-
- Change-Id: I944d0fe15b396cad4d0054b6fc359acb42ae3c9c
- Reviewed-on: https://code.wireshark.org/review/3755
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-
-commit 863b664
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 22 15:44:20 2014 -0400
-
- Replace a couple of implementations of unpack_digits() with tvb_bcd_dig_to_wmem_packet_str().
-
- Change-Id: Ic9e740345fb3a748f6df4f624441bb947bbd9429
- Reviewed-on: https://code.wireshark.org/review/3797
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 2d74838
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 22 15:14:00 2014 -0400
-
- Decode the 3GPP MSISDN AVP using the E.164 routines.
-
- Rename dissect_e164_utf8_number() to dissect_e164_msisdn() and give it an
- 'encoding' argument.
-
- Change-Id: I49cf5d2b24b44a0e69427ceae331f378024391c5
- Reviewed-on: https://code.wireshark.org/review/3796
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 923ba9d
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 22 14:39:42 2014 -0400
-
- Fix a comment typo: tvb_bcd_dig_to_wmem_packet_str() returns a WMEM-allocated
- string, not an EP-allocated one.
-
- Change-Id: I3918ed66429c588d4503d98e10dc460b099e550e
- Reviewed-on: https://code.wireshark.org/review/3795
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 28acde1
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Wed Aug 20 11:30:44 2014 +0200
+commit e908804
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sat Nov 22 12:20:05 2014 -0800
- Parse Capabilities & Flags section of TRILL Version Sub-TLV
+ Update symbol list.
- Change-Id: Ic82a2368c865031eaeee291055b6a4f176cde759
- Reviewed-on: https://code.wireshark.org/review/3792
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Ib1cb41f212bbccd4e20d3621110cbb98c01a7196
+ Reviewed-on: https://code.wireshark.org/review/5444
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 76a674f
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Tue Aug 19 15:33:26 2014 +0200
+commit 08cf40e
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 22 13:13:22 2014 -0500
- TRILL ISIS: Implement TRILL Neighbor TLV (145)
+ Use dissector data to "return" XML data to XMPP dissector.
- Change-Id: I1b17b0ef26150fdc68b966f4837953f9832883cb
- Reviewed-on: https://code.wireshark.org/review/3717
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I9abdc8c3deed35131af1537733d624d5cfced182
+ Reviewed-on: https://code.wireshark.org/review/5443
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit ff94a7f
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Fri Aug 22 12:53:27 2014 +0200
+commit 534b596
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sun Nov 16 10:22:34 2014 -0500
- Move generating HAVE_AIRPCAP to main CMakeLists.txt as is done with
- other liberaries. Also: After set( variable 0 ) the variable is defined.
+ Cleanup packet-sccp.c in preparation of trying to remove sccp_info member of packet_info.
- Change-Id: Id26a771875b7643c19f173ce77bb29a4059a1bd0
- Reviewed-on: https://code.wireshark.org/review/3793
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit d5ba8b4
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Tue Aug 19 14:22:49 2014 +0200
-
- TRILL updates
+ Convert a handful of global variables into function parameters that get passed through the dissector, so we shouldn't be dependent on pinfo->sccp_info anymore. Removal of pinfo->sccp_info will be done in a separate patch (when the dissectors that use it can be updated).
- Update Version info
- Update Nickname IDs
- Add new multicast MAC addresses
+ packet-sua.c may need similar treatment.
- Change-Id: I72647b5f98a48267340d51df428602e1c77cb206
- Reviewed-on: https://code.wireshark.org/review/3714
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: If0001638d666afc07e04b02aa32ef31d6223a5de
+ Reviewed-on: https://code.wireshark.org/review/5343
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit b6cb2ad
-Author: Wasim Abu Moch <wasim@mellanox.com>
-Date: Tue Aug 19 16:58:04 2014 +0300
+commit e2b597a
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Wed Nov 19 22:22:12 2014 -0500
- packet-infiniband: added support for Mellanox DC transport type
+ Fix problem where the profile bar moves further left every time Wireshark is
+ run.
- *marked parse_DCCETH() function's unesed parameters with _U_ macro instead of (void) */
- *Added few whitespaces (new lines), were mistakenly removed"*
+ For the saved/restored geometry to be consistently correct we need to always
+ show the expert info and capture file comment icons. Disable them if no
+ capture file is open.
- Adding minimal support for Mellanox DC transport type which
- replaces RD (RD isn't implemented in any HW yet).
- It's minimal in the sense of skipping new headers without
- parsing/showing them, this allows at least to keep correct IB packet parsing
- due to the new added header for this TS. (in this stage we can't expose
- the protocol details including it's header layout)
-
- Change-Id: I6cffa6497632ba19a6f9ec60a4f68da60b28e821
- Reviewed-on: https://code.wireshark.org/review/3719
+ Bug: 10518
+ Change-Id: I6e254f66a17f8f54f28cfbafb4e0f92e02cff70c
+ Reviewed-on: https://code.wireshark.org/review/5404
Reviewed-by: Evan Huus <eapache@gmail.com>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 8b5ca59
-Author: Masayuki Takemura <masayuki.takemura@gmail.com>
-Date: Fri Aug 22 13:08:13 2014 +0900
+commit c61a037
+Author: Jesse Gross <jesse@nicira.com>
+Date: Tue Nov 18 14:36:30 2014 -0800
- TGPPRx: Add AF-Signalling-Protocol AVP dissection support
+ Add version check in Geneve dissector.
- The AVP is defined in 3GPP TS 29.214, Table 5.3.1: Rx specific Diameter AVPs.
+ We should warn when decoding Geneve packets with an unknown
+ version number.
- Change-Id: Ib0a525f97206ff61bb0d390df81e3d6ebbef59bb
- Reviewed-on: https://code.wireshark.org/review/3791
+ Change-Id: Id40b756c3bb0320b69fbd8ee98830a2b05834a48
+ Reviewed-on: https://code.wireshark.org/review/5420
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit c2eb021
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Wed Aug 20 08:11:29 2014 +0200
-
- TRILL ISIS: Fix incorrectly equal ett variables for different subtrees
-
- Change-Id: I38d886d50d74d75a900274df8bc24114e84926e7
- Reviewed-on: https://code.wireshark.org/review/3744
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 50bb930
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 21 20:06:14 2014 -0400
-
- Regenerate the X11 dissector with the latest mesa, xcb, and process-x11-xcb.pl
-
- Change-Id: Ie05f9b780011b215ca3ad3293b3daefbcbee68ce
- Reviewed-on: https://code.wireshark.org/review/3789
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 331d87e
-Author: Peter Harris <pharris@opentext.com>
-Date: Wed Aug 20 11:29:35 2014 -0400
-
- X11: Support xcb's new <case>
-
- Change-Id: I32c6ab15d6dc7a67cdb50c4187e2752730315588
- Reviewed-on: https://code.wireshark.org/review/3751
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 0c38cf3
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Aug 20 20:11:49 2014 -0400
-
- plugins.c: cleanup plugins_scan_dir()
-
- add_plugin() no longer returns ENOMEM. Remove code in
- plugins_scan_dir() which printed an error message
- if ENOMEM returned by add_plugin().
-
- Fix comment re add_plugin() return values.
-
- Change-Id: Id5170c28e2a55884d41ceebc4e07f16389b75a2a
- Reviewed-on: https://code.wireshark.org/review/3774
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit f580ebe
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 21 18:44:07 2014 -0400
-
- packet-gsm_cbch.c: various minor changes
-
- - tvb_length() --> tvb_reported_length();
- - Use -1 for length arg in proto_tree_add_protocol_format();
- - Remove unused 'for' loop increment which caused Windows
- warning: "C4701: potentially uninitialized local variable";
- - Add editor modelines.
-
- Change-Id: I37833b750c100e333f4fa76d9465169be456d7c1
- Reviewed-on: https://code.wireshark.org/review/3788
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 5b5ef96
+commit 01f9706
Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Thu Aug 21 23:48:48 2014 +0100
+Date: Fri Nov 21 23:27:56 2014 +0000
- Fix CMake checks of PCap functions, along with AirPCap
+ Add the required c flags for some test executables
- Change-Id: If55498167d5e357258841f2194962749c0dfc81e
- Reviewed-on: https://code.wireshark.org/review/3787
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
+ Change-Id: I93b0c346fff162899e5f97dd2366e01cf99ec38e
+ Reviewed-on: https://code.wireshark.org/review/5435
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
- Reviewed-by: Roland Knall <rknall@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 87b2364
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 21 10:41:22 2014 -0400
-
- Add a license to this new file (GPLv2+) so we pass the license check.
-
- (This change needs to be approved Roland Knall--by the file's author--in
- Gerrit.)
-
- Change-Id: I58285cb1d773a57fe7d087799bf6d2ffbd962364
- Reviewed-on: https://code.wireshark.org/review/3773
- Reviewed-by: Roland Knall <rknall@gmail.com>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 6edc166
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 21 17:40:04 2014 -0400
-
- Decode User-Name as an IMSI in S13/S13' and S7a/S7d.
-
- Also move the application ID macros into the diameter header file.
-
- Change-Id: Iaca5707c8476d81f50ecdb3aab76be293b5ccfe7
- Reviewed-on: https://code.wireshark.org/review/3786
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit b6df4a5
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 20 14:42:40 2014 +0200
-
- usb_conv_info is no longer unused
-
- Change-Id: I27e5c8686e7f7a907bdcec59e97ae93a090b7185
- Reviewed-on: https://code.wireshark.org/review/3783
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit c8d9d29
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 20 14:38:01 2014 +0200
-
- remove trans_info parameter from dissect_usb_interface_assn_descriptor()
-
- Change-Id: I9069835a824abcb004b05659a20b00a783a28ed6
- Reviewed-on: https://code.wireshark.org/review/3782
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 3313e2d
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 20 13:58:21 2014 +0200
-
- remove usb_trans_info from dissect_usb_interface_descriptor()
-
- Change-Id: Ia1bfdd705021e784213e00b70cfabc42b524384d
- Reviewed-on: https://code.wireshark.org/review/3781
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit a87112f
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 20 13:49:51 2014 +0200
-
- set usb_conv_info->endpoint to "no endpoint" for interface conversations
-
- Change-Id: I625d20cc2c874f5b28c063590878077f8aa80196
- Reviewed-on: https://code.wireshark.org/review/3780
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit b72acf3
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Aug 21 12:08:24 2014 +0200
-
- add component descriptor values for HEVC services
-
- Change-Id: I28e55dc95a55ad80aa2ce59ab6c5d495d8eb7d99
- Reviewed-on: https://code.wireshark.org/review/3779
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 5a3faf9
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Aug 21 11:53:38 2014 +0200
-
- add service type for HEVC digital television service
-
- Change-Id: I9aab67250d9fe7dc83243b55bbc2cb964c140e46
- Reviewed-on: https://code.wireshark.org/review/3778
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 8fad638
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 21 13:03:45 2014 -0400
-
- text2pcap-scanner.l: On Windows: #include <io.h> req'd for isatty()
-
- Change-Id: I6464f11c3bc5f8dd671f6f36006fb74059d30b26
- Reviewed-on: https://code.wireshark.org/review/3776
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 45a7b6c
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 21 13:00:56 2014 -0400
-
- uat_load.l: Fix "unreachable code" warning (Windows 4702)
-
- Change-Id: I0f50bc9f1970578a7a2a44a8a3149173f5935f14
- Reviewed-on: https://code.wireshark.org/review/3775
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 1460575
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 21 09:34:16 2014 -0400
-
- Fix compilation when we don't HAVE_LIBSMI or HAVE_GEOIP.
-
- Change-Id: I7523c183fd46a649947ad316518dfffaddb02dbe
- Reviewed-on: https://code.wireshark.org/review/3772
- Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit a3d8f31
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 20 22:47:22 2014 -0400
-
- Add a function to dissect an E.164 (MSISDN) number in UTF8 format and use it
- in the Diameter dissector.
-
- This new API adds a filter for the MSISDN as well as a subtree and filter for
- the Country Code.
-
- Change-Id: Ibcbf4b5f72178b7e4af63efa7496188d608a9de7
- Reviewed-on: https://code.wireshark.org/review/3760
- Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit c7c4aba
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Sat Aug 16 00:28:58 2014 +0200
-
- Bluetooth: btle: Fix reserved field dissection
-
- Also cosmetic changes:
- 1. Clear Info Column at start (fix garbages from previous protocols like Ubertooth)
- 2. Refactor a little all expert field definitions
-
- Change-Id: Ie1cba8c1578597f2d896ec75f7d2af4987325bf3
- Reviewed-on: https://code.wireshark.org/review/3768
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 6cae829
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Thu Aug 21 12:05:04 2014 +0200
-
- Bluetooth: HCI_EVT fix fuzz failture
-
- Fix possible "Conditional jump or move depends on uninitialised value"
-
- Bug: 10396
- Change-Id: I2c57f8310f88c68ae921d7e5bd1c060d0df27b8e
- Reviewed-on: https://code.wireshark.org/review/3769
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 8a0d456
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Fri Aug 15 23:43:57 2014 +0200
-
- Bluetooth: Fix Delete opcode in Linux Monitor transport
-
- -1 -> tvb_captured_length(tvb) fixed zero-length packet.
-
- Change-Id: I0748fa4e29d91a098f6222d162bce3177b9306e7
- Reviewed-on: https://code.wireshark.org/review/3767
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 98f16d5
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Tue Aug 12 15:47:04 2014 +0200
-
- Bluetooth: RFCOMM: Fix recognizing services
-
- Add support for missing direction flag in dlci.
-
- Change-Id: I1429eb65374014e7b840bb31ca1d6f2ab1959160
- Reviewed-on: https://code.wireshark.org/review/3766
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 87550a6
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Mon Aug 4 15:38:22 2014 +0200
-
- Bluetooth: L2CAP: Clear channel options if configure fails
-
- On every configuration request clean options before setting anything.
- Then if configuration will be rejected options will not be set to
- something that is not set in next configure request.
-
- Change-Id: I5acedde96f7ff720e916256d683937acbcd13a48
- Reviewed-on: https://code.wireshark.org/review/3765
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 3d445dd
-Author: Michal Labedzki <michal.labedzki@tieto.com>
-Date: Mon Aug 11 11:48:02 2014 +0200
-
- Update AUTHORS
-
- Thanks to Michał Orynicz for finish Logcat support.
- Also update our hall of fame. One note:
- my real name is Michał Łabędzki, but if you write
- Michal Labedzki it will be ok too.
-
- Change-Id: I81ae563fa1347f1fee316e0ff79a87722ff88d0b
- Reviewed-on: https://code.wireshark.org/review/3764
- Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-
-commit 7b9b881
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Aug 21 01:05:52 2014 -0700
-
- Float constants end with "f"; assign float constants to gfloats.
-
- This squelches some compiler warnings about assigning double values to
- floats (no, there's no precision in 0 to lose, but the compiler warns
- anyway).
-
- Change-Id: Ia49618cb8582c5afcdc5bdc5334fe20724b85eda
- Reviewed-on: https://code.wireshark.org/review/3762
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 66318ad
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Aug 21 00:35:38 2014 -0700
-
- Don't assert out on tvb_memcpy() with a null data pointer if the length is 0.
-
- If the length is 0, there's nothing to copy, so it doesn't matter if
- there's no data to copy from. This fixes problems caused by allocating
- a zero-length buffer and using that as the data for a tvbuff; the
- allocation returns null, so the data pointer is null.
-
- Change-Id: I8037ae4b96d30e90a716852bb7e22d3980444f83
- Reviewed-on: https://code.wireshark.org/review/3761
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit bed29af
-Author: Roland Knall <roland.knall@br-automation.com>
-Date: Tue Feb 25 14:05:11 2014 +0100
-
- Extcap Capture Interface
-
- Extcap is a plugin interface, which allows for the usage
- of external capture interfaces via pipes using a predefined
- configuration language which results in a graphical gui.
-
- This implementation seeks for a generic implementation,
- which results in a seamless integration with the current
- system, and does add all external interfaces as simple
- interfaces.
-
- Windows Note: Due to limitations with GTK and Windows,
- a gspawn-winXX-helper.exe, respective gspawn-winXX-helper-console.exe
- is needed, which is part of any GTK windows installation.
-
- The default installation directory from the build is an extcap
- subdirectory underneath the run directory. The folder used by
- extcap may be viewed in the folders tab of the about dialog.
-
- The default installation directory for extcap plugins with
- a pre-build or installer version of wireshark is the extcap
- subdirectory underneath the main wireshark directory.
-
- For more information see:
-
- http://youtu.be/Nn84T506SwU
- bug #9009
-
- Also take a look in doc/extcap_example.py for a Python-example
- and in extcap.pod for the arguments grammer.
-
- Todo:
- - Integrate with Qt - currently no GUI is generated, but
- the interfaces are still usable
-
- Change-Id: I4f1239b2f1ebd8b2969f73af137915f5be1ce50f
- Signed-off-by: Mike Ryan <mikeryan+wireshark@lacklustre.net>
- Signed-off-by: Mike Kershaw <dragorn@kismetwireless.net>
- Signed-off-by: Roland Knall <rknall@gmail.com>
- Reviewed-on: https://code.wireshark.org/review/359
- Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 4014698
-Author: Wasim Abu Moch <wasim@mellanox.com>
-Date: Sun Aug 17 15:24:14 2014 +0300
-
- packet-erf: added dissector table for "erf.types.type" type field.
-
- 1- removed unnecessary include <wiretap/erf.h>
- 2- used fall through in protocol switch case instead of calling same
- function with same params.
-
- fixes/changes after review with Evan Huus, changes ETH/IPv4/IPv6/Infiniband/InfinibandLink
- to use dissector table instead of direct function calls.
- other protocols should be called in the same way, we'll do it when have
- the time.
-
- instead of calling subdissector directly from packet-erf.c code it's
- easier to declare this and each time we need to register a new
- protocol over erf format we sould easily extend it from the protcol module
- instead using "dissector_add_uint()" function.
-
- the change is still backward compatible, if no upper protocol is
- registered for the specifc type an old fasion direct function call
- is performed.
-
- Change-Id: I3ae1ccfdd49ab8f90667185296cc950dc2184475
- Reviewed-on: https://code.wireshark.org/review/3670
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-commit ca5fa53
+commit 741db4c
Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 20 15:51:40 2014 -0700
+Date: Sat Nov 22 01:07:13 2014 -0800
- Create an IE item for the "Apparent Address" IE.
+ Get rid of another global in the print code.
- Also, don't initialize ie_item, in the hopes that cases where we don't
- set it will be caught at compile time rather than run time.
+ Pass the "output only these protocols" hash table as an argument,
+ instead.
- Change-Id: I768251d19a7508ec876af44b987a4ecfd04258f7
- Reviewed-on: https://code.wireshark.org/review/3759
+ Change-Id: Id8540943037e7b9bbfe377120c3f60dbe54fe0f1
+ Reviewed-on: https://code.wireshark.org/review/5440
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit ca1ac2c
+commit c68e77b
Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 20 15:15:15 2014 -0700
+Date: Sat Nov 22 00:28:12 2014 -0800
- 9P2000.L also has the UID field in tattach.
-
- See, for example:
-
- http://code.google.com/p/diod/wiki/protocol#attach,_auth_--_messages_to_establish_a_connection
+ Pass a capture_file * to write_psml_preamble() in tfshark as well.
- and
-
- http://code.google.com/p/diod/wiki/protocol#Overview
-
- where the latter says
-
- 9P2000.L consists of a subset of the canonical 9P2000
- operations, the 9P2000.u attach and auth messages, plus new
- operations designed to map to the Linux VFS in a straightforward
- way.
-
- so tattach and tauth are the same as 9P2000.u.
-
- Don't throw a dissector assertion of there's data at the end of the
- packet; in the particular case that found this bug, yes, it was a
- dissector bug, but it could also be a malformed packet, and we should
- not throw dissector assertions unless we know *for certain* that the
- problem is a dissector bug rather than a malformed packet.
-
- Change-Id: I5ef5d837bccb4e7c4844d31a138aa55a85ec1b60
- Reviewed-on: https://code.wireshark.org/review/3758
+ Change-Id: I2b2ae78d4b75bb27a44d185b48e3d85794effdb7
+ Reviewed-on: https://code.wireshark.org/review/5439
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 2afb736
+commit b19b12a
Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 20 14:46:37 2014 -0700
+Date: Sat Nov 22 00:06:54 2014 -0800
- Sort hfi[] to match the definitions, and add a missing entry that found.
-
- Sorting them to match the definitions of the hfi variables makes it
- easier to compare the two lists.
+ Get rid of write_headers global variable.
- Comparing the lists found a missing entry; add it.
+ Have write_psml_preamble() and write_csv_preamble() take a capture_file *
+ as an argument, so they can print the column titles themselves, rather
+ than having to defer it to the routine that prints packet data.
- Change-Id: I3517667336b1355195c5a227f0d02f1740a7c4cd
- Reviewed-on: https://code.wireshark.org/review/3757
+ Change-Id: Ifd1b7a13062be8ad46846315976922a752778153
+ Reviewed-on: https://code.wireshark.org/review/5438
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 74e75c5
+commit 6e1214c
Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 20 14:36:44 2014 -0700
+Date: Fri Nov 21 19:32:33 2014 -0800
- Sort the fc_lctl_rjt_val values.
-
- That avoids a warning printed when making a value_string_ext table out
- of it.
+ Fix comments.
- Change-Id: I7874e6db9d6805abcc21f113f1de7c2cf687e624
- Reviewed-on: https://code.wireshark.org/review/3756
+ Change-Id: I3b7340939b8204102bfc7e2e7d83f4d978cf7bad
+ Reviewed-on: https://code.wireshark.org/review/5437
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit c16db66
+commit 7d7fc47
Author: Guy Harris <guy@alum.mit.edu>
-Date: Wed Aug 20 14:23:56 2014 -0700
+Date: Fri Nov 21 19:22:54 2014 -0800
- Various dissection improvements.
-
- In WCCP V2, check whether the length field runs past the end of the
- packet (actual packet data, not captured data) and, if so, report an
- error with expert info, otherwise use the length field to set the length
- of the tvbuff. That allows the dissector to just use the tvbuff checks
- to do length checks, so eliminate manual length checks.
-
- In find_wccp_address_table(), stop if we run past the reported length or
- packet length; if we fail to find an address table because we run past
- the captured length, we should probably note that if we're trying to
- dissect addresses.
+ Split the low-level print stream code into a separate file.
- Don't do any other checks against the captured length, just throw the
- BoundsError assertion, to report that the packet was cut short during
- the capture process.
+ Put the low-level print stream code from epan/print.c into
+ epan/print_stream.c, leaving the higher-level stuff in print.c
- When creating a protocol subtree for an item, give it a "to the end"
- initial length", and only set the length when we're finished dissecting
- the item, based on the amount of data dissected.
-
- Don't speak of dissectors in expert info - the user needn't know what a
- dissector is; what matters is what the protocol specifies.
-
- Properly report "item is too short" errors - those are indicated by item
- dissectors returning a negative value, so show the negative of that
- value.
-
- Make the top level item for a capability element be a separate item from
- the element type; use hf_capability_element_type for the type rather
- than the entire element, and put the type and length into the protocol
- tree in that order, as that's the order in which they appear in the
- packet.
-
- Don't do capability element length checks in the capability element
- dissector, do it in the dissector for the particular capability element,
- and don't fail with a dissector bug report, fail with an expert info.
-
- Sort the ett[] array to match the list of ett_ definitions, to make it
- easier to check that they're all registered.
-
- Change-Id: I6545e000b6caf9824f89234602635668fa1d38d6
- Reviewed-on: https://code.wireshark.org/review/3754
+ Change-Id: Iae961f168ec655a29f434257b1af0937fca9f025
+ Reviewed-on: https://code.wireshark.org/review/5436
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 4ac0438
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Wed Aug 20 13:31:19 2014 +0100
-
- In Visual Studio builds, enable the L4 warning
- 4189: Local variable is initialized but not referenced
-
- Fix some variables found by this
-
- Change-Id: Icc13def5413f1fe885ec25e659462c8906a6cfa0
- Reviewed-on: https://code.wireshark.org/review/3748
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
- Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 8fc0ee4
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 20 15:08:21 2014 -0400
-
- Decode IMSIs found in Subscription-Id AVPs.
-
- Move decode of the User-Name AVP out of the 3GPP-specific file.
- Add a couple of macros for 3GPP AppIDs (rather than using the number directly)
- in both files.
-
- Change-Id: I496b4ae86b05264462167b6e41ce1451392de11b
- Reviewed-on: https://code.wireshark.org/review/3753
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 61b01c3
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 20 11:14:38 2014 -0400
-
- If the user explicitly requested gnutls or libgcrypt generate an error if they
- are not found.
-
- Accurately describe the default behavior: Wireshark will use the libraries if
- they are available.
-
- May help avoid problems like that described in:
- https://ask.wireshark.org/questions/35600/not-able-to-configure-wireshark-with-gnutls
-
- Change-Id: I5f0b2ce87cb7c6b337de93609f13d8027e662263
- Reviewed-on: https://code.wireshark.org/review/3750
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 3adaf99
+commit 08475ff
Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Aug 20 11:05:03 2014 -0400
+Date: Wed Nov 19 13:52:52 2014 -0500
- proto.h; (try to) fix bug in DISSECTOR_ASSERT_CMP... macros;
+ README.heuristic: rework example code.
- Also: re-enable use of DISSECTOR_ASSERT_CMP... macros in packet-ceph.c
+ Specifically: show the use of tcp_dissect_pdus()
+ for a TCP heuristic dissector
- Change-Id: Icee80381f5c8feb14cfc7e4033bdeb893018ce95
- Reviewed-on: https://code.wireshark.org/review/3749
+ Change-Id: I02f184b2c8ef6ed128ef3d0bc59eed759aae54bb
+ Reviewed-on: https://code.wireshark.org/review/5399
Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit ca390ef
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Aug 20 13:34:41 2014 +0200
-
- Remove now unused code, do API changes missed in previous commit.
-
- Change-Id: Ibc814fb56f34b6c74cb7751e790978748ea8b1db
- Reviewed-on: https://code.wireshark.org/review/3747
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 9f43bbd
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Aug 20 13:19:38 2014 +0200
-
- Use dissect_e212_imsi() to dissect IMSI.
- Fix deprecated APIs
- Restore delted hf.
-
- Change-Id: I5c08dd8e702a6fadd0409cec608d9a7b153f8164
- Reviewed-on: https://code.wireshark.org/review/3746
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 0685380
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Aug 20 12:54:59 2014 +0200
-
- Use dissect_e212_mcc_mnc_wmem_packet_str() to dissect PLMN(id).
- Fix a few deprecated APIs
-
- Change-Id: I8a535417234a6e739eeb0835e524d6e367150340
- Reviewed-on: https://code.wireshark.org/review/3745
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 1c10c7b
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Tue Aug 19 22:54:08 2014 +0100
-
- Modified script to not use PS 3.0 constructs
-
- Change-Id: I0a4a738a410f0aece9459852a51d6c96f11aae76
- Reviewed-on: https://code.wireshark.org/review/3739
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
- Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 097401c
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Wed Aug 20 01:48:42 2014 -0400
-
- packet-ceph.c: Temporarily comment out the use of DISSECTOR_ASSERT_CMP... macros since they have a bug.
-
- Change-Id: I007931980644a9283083052f8c27d553f052470a
- Reviewed-on: https://code.wireshark.org/review/3743
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 41af6dd
-Author: Kevin Cox <kevincox@kevincox.ca>
-Date: Wed Aug 6 09:56:38 2014 -0400
-
- Add more messages for the Ceph protocol.
-
- New messages:
- - Mon Paxos.
- - Mon Global ID.
- - Mon Get Version
- - OSD Ping
- - Ping
- - OSD Boot
- - OSD PG Create.
- - PG Stats.
-
- Other updates:
- - Documentation for modifying the dissector.
- - Update assertions to show values.
- - Replace proto_tree_add_text()/expert_add_info...() by proto_tree_add_expert...().
- - Fix a bug: misplaced break.
- - Do some minor whitespace & other cosmetic changes.
- Change-Id: Ib19ce509b67fb5e6fb31e82b5a551a9e952a9c6d
- Reviewed-on: https://code.wireshark.org/review/3623
- Petri-Dish: Bill Meier <wmeier@newsguy.com>
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit b9a94f0
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 19 22:50:17 2014 -0400
+commit fecea97
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Wed Nov 19 21:34:50 2014 +0100
- Add a routine to dissect an UTF8-encoded IMSI (as you'd find in Diameter) and use it to decode the User-Name AVP of S6a/S6d messages.
+ VoIP Call (GTK): Fix Dereference of null pointer found by Clang analyzer
- Also clean up some white space/formatting.
-
- Change-Id: Idf2d4cad2af1826b24de7d59407ffeb36100c19b
- Reviewed-on: https://code.wireshark.org/review/3742
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Change-Id: I80029b6238c78dcab83a6a70eca0af5b66e1488d
+ Reviewed-on: https://code.wireshark.org/review/5401
+ Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 9d7784d
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 19 22:00:22 2014 -0400
+commit c07e9fe
+Author: Irene Ruengeler <ruengeler@wireshark.org>
+Date: Mon Nov 17 08:51:12 2014 +0100
- Get it compiling again.
+ Add minimize and maximize buttons to the SCTP analysis windows.
- Remove set-but-not-used variable.
- Mark a parameter as unused.
+ As suggested by Jeff Morriss.
- Change-Id: I7c3af353da2967e5d611deb2cb027a9e30e54bdf
- Reviewed-on: https://code.wireshark.org/review/3741
+ Change-Id: Ibe2d30c31d51ab92377d64068527b424a92e8a64
+ Reviewed-on: https://code.wireshark.org/review/5361
+ Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 47b7df8
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Tue Aug 19 23:57:18 2014 +0200
-
- NAS EPS: remove a now unused hf entry and convert tabs to spaces
-
- Change-Id: I3d5e91bd0bdb44fe033284aa38bc1f3a1dc35f4f
- Reviewed-on: https://code.wireshark.org/review/3740
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit c7da116
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 23:37:30 2014 +0200
-
- actually store the endpoint in the conversation
-
- this fixes the bugfix for
- https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10386
- (hopefully)
-
- Change-Id: Ib61e1033cae7516181c3557bf78d01b4249a7393
- Reviewed-on: https://code.wireshark.org/review/3738
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit cdfd6e4
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 18:08:34 2014 +0200
-
- handle all combinations of request type and recipient
- for USB control messages
-
- Change-Id: I9d2ad2995975e1853c73d712b429a30cead8f473
- Reviewed-on: https://code.wireshark.org/review/3737
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 7146999
-Author: AndersBroman <a.broman@bredband.net>
-Date: Tue Aug 19 23:00:57 2014 +0200
-
- Use dissect_e212_imsi() to dissect IMSI
- Fix dissection when MCC starts in the high nibble.
- Replace deprecated APIs
-
- Change-Id: Ic08a1db9ee7ebb535bf7914191807304e9f88981
- Reviewed-on: https://code.wireshark.org/review/3736
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit e5e8828
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 22:12:17 2014 +0200
-
- start simplifying the parsing of USB control URBs
-
- Change-Id: Ie527b89f6be2d100dfd8bc7c96c2f2ac7efa3efc
- Reviewed-on: https://code.wireshark.org/review/3735
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 22dc992
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 15:46:38 2014 +0200
-
- remove product_data, protocol_data parameters from try_dissect_next_protocol()
- (another small step to make this function understandable)
-
- Change-Id: Ib00aa00af8287969dd2d80a33c1f0ebd0b8f2248
- Reviewed-on: https://code.wireshark.org/review/3734
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 74c8ded
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 15:40:45 2014 +0200
-
- reformat dissect_usb_setup_get_descriptor_response()
-
- Change-Id: I8004c4fd6e9cac3615d27b375229a79d01dfcd68
- Reviewed-on: https://code.wireshark.org/review/3733
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit ea7a549
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 15:39:25 2014 +0200
-
- remove the usb_trans_info parameter from dissect_usb_hid_get_report_descriptor()
-
- Change-Id: If14357a02a60eff5fc7e50567c2c6bfc6ee3dcc6
- Reviewed-on: https://code.wireshark.org/review/3732
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit a1b4025
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 21:56:32 2014 +0200
-
- remove the parameter usb_trans_info from the functions that dissect the
- standard descriptors
-
- usb_trans_info is a part of usb_conv_info, there's no need to have it as
- a separate parameter
-
- Change-Id: I3608c10543b896ca04c6062de23297d852dae31a
- Reviewed-on: https://code.wireshark.org/review/3731
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 543153b
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 21:51:11 2014 +0200
-
- interface and endpoint descriptors can't possibly appear in a
- get descriptor response on their own, only as part of a configuration
- descriptor
-
- Change-Id: I2d70ab1d1adc19cbc0fe8c2c835071153a40ae7d
- Reviewed-on: https://code.wireshark.org/review/3730
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 5dc742b
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 12:01:15 2014 +0200
-
- now that we have a routine to clean up the packet-specific infos in the
- usb conversation, there's no need to clean up usb_conv_info after
- parsing the configuration descriptor
-
- this wouldn't work anyway if one of the subfunctions throws an exception
-
- Change-Id: Ifd13f320db1ec17c3b706778ce0f5dffa1349770
- Reviewed-on: https://code.wireshark.org/review/3729
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit d6775dc
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Mon Aug 18 14:56:52 2014 +0200
+commit d7e277a
+Author: Michael Mann <mmann78@netscape.net>
+Date: Fri Nov 21 10:43:40 2014 -0500
- Revert "Revert "create audio-specific part of the usb conversation""
-
- This reverts commit 22e10bea0cbd2b29d6e7b82a3ead3910d71988a2.
+ CANopen bugfixes
- Now that the fuzz failures are fixed, we can re-enable the
- audio-specific extensions.
+ 1. Fixed endianess in CANopen dissector.
+ According to CiA 301, 7.1.1. (p. 26):
+ "For numerical data types the encoding is little endian style."
- Change-Id: Id788e10aaa3dbf289df364f7da9ef01e24ba47f9
- Reviewed-on: https://code.wireshark.org/review/3728
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 1194061
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 21:33:18 2014 +0200
-
- clear the temporary components of usb_conv_info_t before we dissect a
- new packet
+ 2. Fixed NMT type string in CANopen dissector
+ NMT function code should not display 'EMERGENCY'
- this fixes the fuzz failures in
- https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10386
+ 3. Fixed time stamp decoding
- Change-Id: I8c0ba8c8da9af8d7a3ef9cdd7781769b9966f1a2
- Reviewed-on: https://code.wireshark.org/review/3727
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 8c84a23
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 09:16:04 2014 +0200
-
- these two vars are initialized to NULL,
- we don't have to set them to NULL again
+ * Offset increment was too low for data type size
+ * Decoding of time_stamp_days must equal time_stamp_msec and thus be letohs instead of ntohs. CANopen data is little-endian encoded.
- Change-Id: Iacd01ca207d2b74ebdbd5a7635f00e6d03b13721
- Reviewed-on: https://code.wireshark.org/review/3726
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 5c554c9
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 19 21:04:38 2014 +0200
-
- fix
+ 4. Fix: Use correct description string for NMT error control state bits
+ canopen.nmt_guard.state was faulty named "Node-ID". This was changed to "State".
- packet-gtp.c: In function 'decode_gtp_imsi':
- packet-gtp.c:3210:18: error: variable 'imsi_str' set but not used [-Werror=unused-but-set-variable]
- cc1: all warnings being treated as errors
- make[5]: *** [libdissectors_la-packet-gtp.lo] Error 1
+ 5. Fix nmt_guard_state value_string array
+ CiA 301 desribes only 4 valid values. All other were deleted.
+ 0x00 was renamed from 'Initalisation' to 'Boot-up' following CiA301.
- by commenting out the unused variable
+ 6. Shortened EMERGENCY to EMCY
- Change-Id: I498595f93423c599f902a1a0cc42b63cef2c4d7c
- Reviewed-on: https://code.wireshark.org/review/3725
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 8670d9f
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Tue Aug 19 11:53:55 2014 +0200
-
- TRILL ISIS: Unify MTID presentation in all cases
+ The term EMCY is the standard abbreviation used in CiA standard for Emergency service.
- Change-Id: I66eb683d6b1f9dccae3e566ad4dd4cfd18b81ddb
- Reviewed-on: https://code.wireshark.org/review/3713
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 2e3bc57
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Aug 19 13:25:11 2014 -0400
-
- packet-PROTOABBREV.c: various minor changes:
+ 7. Fix: Allow SYNC and NMT error frames without any payload
+ NMT node guard remote requests do note have a payload,
+ SYNC frames only have an optional payload (counter)
- - Specify that proto_register...() and proto_reg_handoff...() prototypes are required;
- - Indicate that certain #includes should be used only as needed;
- - Don't use CamelCase (or CAPS) in variable names;
- - Do some reformatting of certain lines;
- - Futz hf[] array entry so checkAPIs and checkhf tests don't fail.
+ If item length is set to -1, decode will cause a 'Malformed Packet' error.
- Change-Id: Ie03846f4bebd2a9bece464c85cc3c2ef46dd4fe5
- Reviewed-on: https://code.wireshark.org/review/3724
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 0cda27c
-Author: Michael Mann <mmann78@netscape.net>
-Date: Sun Aug 17 20:31:04 2014 -0400
-
- "Highly discourage" use of proto_tree_add_text.
+ 8. Rename MT_NMT_GUARD to MT_NMT_ERR_CTRL which better reflects its scope
- Change-Id: I2e8d18df71688c654f7acaff51fae7823c08aa6a
- Reviewed-on: https://code.wireshark.org/review/3677
+ Change-Id: I676f9b5f2e4efd8e7c9528fe289e7510c4d43235
+ Reviewed-on: https://code.wireshark.org/review/5425
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit d7e4564
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 19 17:45:19 2014 +0200
-
- Use dissect_e212_imsi() to dissect IMSI
- fix offset in dissect_e212_mcc_mnc_in_address().
-
- Change-Id: I68006ea3e2c79e2549e6f2d2c8a997e44fc3cdf1
- Reviewed-on: https://code.wireshark.org/review/3722
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 88e8025
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 19 16:55:52 2014 +0200
-
- Use e212 function to dissect IMSI.
- Remove deprecated APIs
-
- Change-Id: I1d5a1437000c5bc4ffd7708bc5b3ab42f7019acf
- Reviewed-on: https://code.wireshark.org/review/3721
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 93da617
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 19 16:02:40 2014 +0200
-
- Remove unused hf and deprecated API
-
- Change-Id: I5196f2be4b15704517ff1dc8bfacc6f9b52ecd71
- Reviewed-on: https://code.wireshark.org/review/3720
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 5041319
+commit f2fc562
Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 19 15:36:33 2014 +0200
+Date: Fri Nov 21 15:54:59 2014 +0100
- Use the E212 function to dissect IMSI correct the filter Id string in
- E212.
+ Replace tvb_length()
- Change-Id: I203502b39d4ef216282d305f90c930aca84241bf
- Reviewed-on: https://code.wireshark.org/review/3718
+ Change-Id: I0b5ad4d588f0b658abaf3892d08d6520ecd2f645
+ Reviewed-on: https://code.wireshark.org/review/5431
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 7cc8b7c
+commit 96fb347
Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 19 09:01:43 2014 -0400
+Date: Thu Nov 20 19:35:25 2014 -0500
- Don't mark a used parameter as unused.
-
- Also fix up some whitespace.
+ Remove some leftover debug printfs.
- Change-Id: I7cd78740199ce7b2682902a5687c4f05c2c963b2
- Reviewed-on: https://code.wireshark.org/review/3716
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 1cdef1d
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 19 14:24:13 2014 +0200
-
- Implement a common function to dissect IMSI and use it GSM MAP as a start.
- - remove soft deprecated APIs and unused hf.
-
- Change-Id: Id00c3dd35f3fc65f543bc29df6d35515c45fe7e1
- Reviewed-on: https://code.wireshark.org/review/3715
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit fc43a8c
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Mon Aug 18 19:08:54 2014 +0200
-
- TRILL ISIS: Implement Group IPv4/IPv6 Address Sub-TLVs
-
- Change-Id: If75925224fc487f583635d9a4346fa900cb0d1d1
- Reviewed-on: https://code.wireshark.org/review/3703
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit a23a4f6
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Tue Aug 19 00:09:43 2014 -0700
-
- The error report timer is non-negative; make it FT_UINT16.
-
- This squelches an assertion.
-
- Use %u to print it, while we're at it.
-
- Reformat the generated named fields to match the others.
-
- Use proto_tree_add_item for the beacon type.
-
- Change-Id: I1dcf161141638de8d7314a3733391a63e0608f67
- Reviewed-on: https://code.wireshark.org/review/3711
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 3128589
-Author: Kevin Cox <kevincox@kevincox.ca>
-Date: Mon Aug 18 20:42:25 2014 -0400
-
- Fix Ceph packet length determination.
-
- The authentication string was not being factored in on the length reply.
- Also there was an issue with different banners. Now the banner length
- must match what we expect or the packet is rejected. If the banner
- length changes the protocol is different and we won't be able to parse
- it anyways.
-
- Change-Id: I0c1a7379edaa203042486a0e6f9ce3642427da99
- Reviewed-on: https://code.wireshark.org/review/3710
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit cf0cb90
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Aug 18 20:17:53 2014 +0000
-
- ceph: use col_add_str instead of col_set_str
-
- The argument is no longer guaranteed to be a const that hangs around.
-
- Bug: 10395
- Change-Id: I3c658f6db5927e09a9a38f9ec0fbce153b3e1bc2
- Reviewed-on: https://code.wireshark.org/review/3709
+ Change-Id: I9f4c7f71ae403059a2a236ba095b21753f7938fa
+ Reviewed-on: https://code.wireshark.org/review/5417
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 7b7dd1e
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 18 12:43:59 2014 -0700
+commit 1cde318
+Author: Michał Orynicz <michal.orynicz@tieto.com>
+Date: Thu Nov 20 13:16:33 2014 +0100
- Don't use -1 as the length of an integer.
+ Fix for very big pid and tid numbers in logcat_text
- That's not supported. Put the unknown enterprise number in a a 4-byte
- value, as that's what it is, and then just skip to the end of the
- packet.
+ There can be no space after pid colon if tid is big enough
+ in logcat long format.
- Change-Id: I2cce84bfbb46a114d4809dbc61a021d497eb87a8
- Reviewed-on: https://code.wireshark.org/review/3708
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I8e03e78c88e4bef1a5fdb3a04b77f58fa7d055bc
+ Reviewed-on: https://code.wireshark.org/review/5411
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 9d6d192
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 18 12:29:45 2014 -0700
+commit 1d8673c
+Author: Michał Orynicz <michal.orynicz@tieto.com>
+Date: Thu Nov 20 13:09:31 2014 +0100
- Use expert info to report unknown TLV types.
+ Move text logcat regex strings to shared header
- Unless we plan to fill in all 256 entries in the TLV type table, and
- unless that's because all 256 types are valid, we should report unknown
- types with an expert info, not a dissector assertion.
+ To avoid further duplication of work and bugfixing,
+ move regex strings to wiretap/logcat_text.h and include
+ this file in epan/dissectors/packet-logcat-text.c
- Change-Id: Ia6fca37ad6a5969caad3229abaf08a25e20ba992
- Reviewed-on: https://code.wireshark.org/review/3707
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I82773cda0e3240844139b104c68738ec82788014
+ Reviewed-on: https://code.wireshark.org/review/5410
+ Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit a3cecb2
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 18 12:08:53 2014 -0700
+commit 1b9dd75
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Thu Nov 20 20:30:32 2014 -0500
- Don't use proto_tree_add_expert() with an item rather than a tree.
+ Fix the build: dissect_a21_ie_common() can't be static any more.
- proto_tree_add_expert() is to be used only on an item that's been
- created as a tree (i.e., an interior node, complete with an ett_ value);
- to hang expert info off of an *item*, which might *not* have been set up
- to take subtree items, use expert_add_info().
-
- Change-Id: Icdcdf39c31c0a03ff80dbb629186e8f6fa82e8ab
- Reviewed-on: https://code.wireshark.org/review/3705
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I93db6bc35aef9c36a294e530730cd295ad6851ef
+ Reviewed-on: https://code.wireshark.org/review/5419
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 4a16ffc
+commit 1df0d9c
Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 18 11:12:59 2014 -0700
+Date: Thu Nov 20 16:57:24 2014 -0800
- Fix handling of STRING16.
-
- When part of a ListOfTextItem, show the STRING16 the same way in both
- places where its value is shown - hex digits or text string.
+ Include "ws_symbol_export.h" to make sure WS_DLL_PUBLIC is defined.
- If the STRING16 contains only 8-bit characters, treat it as ASCII; the
- values 0x20 through 0x7E are *probably* ASCII (although that's not
- guaranteed), but the values above 0x7F aren't guaranteed to be anything.
- *Don't* use tvb_get_ptr() to fetch the string value; that's not
- guaranteed to work with strings.
+ Wrap the declaration for C++ while we're at it.
- Don't impose an upper limit on the maximum displayed length of a
- STRING16.
-
- Change-Id: Ia14812335b9afbff695efe5046dc0ffc2483a351
- Reviewed-on: https://code.wireshark.org/review/3704
+ Change-Id: Ifcc1b47bab139f5fb8da8c3dd4f20b1ebb99739e
+ Reviewed-on: https://code.wireshark.org/review/5418
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 8f0d81d
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Mon Aug 18 09:14:30 2014 +0200
-
- TRILL TREE Sub-TLV fixes
-
- 1) Fix starting tree number
- 2) Display Nicknames both in hex and dec
-
- Change-Id: If58d034e98429019d769ebe7be635a296e8ef18d
- Reviewed-on: https://code.wireshark.org/review/3687
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 3788097
-Author: Anders Broman <a.broman58@gmail.com>
-Date: Mon Aug 18 14:02:46 2014 +0000
-
- Revert "Fix warning: no previous prototype for ... [-Wmissing-prototypes]"
-
- This reverts commit 9918435ed70a1e386e1501982c2bbe0eed25e723.
-
- Change-Id: I122b65ec59f48b8a21e2b43ccdad0ed146b0e78f
- Reviewed-on: https://code.wireshark.org/review/3702
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 9918435
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 10:00:26 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: If41ffdfa15fb24af3e6846f1cfc855eb6cfffb77
- Reviewed-on: https://code.wireshark.org/review/3699
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 31f3187
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:59:54 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I8be913c41695177064985848995db2c0a570c612
- Reviewed-on: https://code.wireshark.org/review/3698
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 3adbd93
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:59:42 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I59e744d905a0a13eea4ff649a984b2ed9f1f51e7
- Reviewed-on: https://code.wireshark.org/review/3697
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit a913bdd
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:59:14 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Add static before function
-
- Change-Id: I42c5be7a1436160bcb82d0cb4309959802b7b3cb
- Reviewed-on: https://code.wireshark.org/review/3696
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 005a494
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:58:22 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Add static before function
-
- Change-Id: Ia34e4786d6181c7849094dd0c27445b29dd89f10
- Reviewed-on: https://code.wireshark.org/review/3695
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit de275db
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:57:56 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Add static before function
-
- Change-Id: I5e112bee776b149ba7390b4aa2c36cb212d2eeb5
- Reviewed-on: https://code.wireshark.org/review/3694
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 9911f1f
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:56:52 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Add static before function
-
- Change-Id: Iddf2879407cfc78734719e7ea2a9eb047045c100
- Reviewed-on: https://code.wireshark.org/review/3693
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 7b2c3cd
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:55:56 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Add static before function
-
- Change-Id: I64e50f0b0349a2ba21cd5d8b8c9ea22e6e960eb3
- Reviewed-on: https://code.wireshark.org/review/3692
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit c8646fa
+commit 9732398
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:54:21 2014 +0200
+Date: Thu Nov 20 20:04:42 2014 +0100
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
+ A21: fix warning: no previous prototype for function ... [-Wmissing-prototypes]
- Add static before function
-
- Change-Id: I0d6d2dc5715c15522190132bfdcb2da1245b9ef7
- Reviewed-on: https://code.wireshark.org/review/3691
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 940532e
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:52:37 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Add static before function
-
- Change-Id: Icb54ccf58e5752892e7217327380a0af7da45647
- Reviewed-on: https://code.wireshark.org/review/3690
+ Change-Id: Ib2f3816892f1682c175b0dee3c80725caebf3d4d
+ Reviewed-on: https://code.wireshark.org/review/5415
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 5833d6b
+commit 5e932ad
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 19:57:12 2014 +0200
+Date: Thu Nov 20 20:04:26 2014 +0100
- Corosync : fix encoding args (for proto_tree_add_item)
+ EPL: fix warning: no previous prototype for function ... [-Wmissing-prototypes]
- Change-Id: I908046c04df7f7218627330f64040fafbce6739e
- Reviewed-on: https://code.wireshark.org/review/3689
+ Change-Id: I40de0c8c2bd40f18a33947367fdeec5a22a3093a
+ Reviewed-on: https://code.wireshark.org/review/5414
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 82d8877
-Author: Irene Ruengeler <ruengeler@wireshark.org>
-Date: Mon Aug 18 10:04:16 2014 +0200
+commit e77261f
+Author: Michael Mann <mmann78@netscape.net>
+Date: Mon Nov 17 20:04:30 2014 -0500
- Capture Options: Add functionality to options and output tab
+ Eliminate proto_tree_add_text from some dissectors.
- Change-Id: I4a2116fe5b7ae3997dd7b0f2693aa511f9d52061
- Reviewed-on: https://code.wireshark.org/review/3688
+ Change-Id: Ib160211198ca02f7eacf29d04568628c11f208a5
+ Reviewed-on: https://code.wireshark.org/review/5407
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit f53c6b3
+commit 9611e75
Author: AndersBroman <anders.broman@ericsson.com>
-Date: Mon Aug 18 13:22:27 2014 +0200
+Date: Thu Nov 20 16:07:55 2014 +0100
- Add missing parameter to proto_tree_add_bytes_format_value()
- tvb_lenght -> tvb_reported_length
+ Replace tvb_length...() calls.
- Change-Id: Ibcb4a7caceaa8207877bdec0f770ad77f84dbe56
- Reviewed-on: https://code.wireshark.org/review/3701
+ Change-Id: Idda7cd56a12b36d18774a1fe324c69eb8f5e4330
+ Reviewed-on: https://code.wireshark.org/review/5412
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 29c4c36
-Author: Michael Mann <mmann78@netscape.net>
-Date: Sun Aug 17 20:00:43 2014 -0400
+commit 9145acb
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Tue Nov 18 22:53:32 2014 -0500
- Remove proto_tree_add_text from gryphon dissector.
+ uat: tighten up dec/hex uat field validity checking
- Change-Id: If9f85a6cda483c5b89f9bee3524502b888ccb1d1
- Reviewed-on: https://code.wireshark.org/review/3676
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Specifically:
+ - Use the proper code for testing strtol() result;
+ - Also: Values greater than 32-bits treated as an error
+ (on LP64 architectures);
+
+ Change-Id: I56e8e734fbb9a22dbd9ed4112e24327ffd7ee3c0
+ Reviewed-on: https://code.wireshark.org/review/5394
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Petri-Dish: Bill Meier <wmeier@newsguy.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 945b371
+commit ead585f
Author: Michael Mann <mmann78@netscape.net>
-Date: Sun Aug 17 16:11:15 2014 -0400
+Date: Sun Nov 16 15:15:52 2014 -0500
- Eliminate proto_tree_add_text from some dissectors.
-
- Other minor cleanup while in the neighborhood.
+ Give better hints as to where the "expert info" fields go.
- Change-Id: I77cac916d617f56f92f686e9cd9f15fba058facf
- Reviewed-on: https://code.wireshark.org/review/3675
+ Change-Id: I9b1cee43ef9280504745b136b87507c2b6bb5369
+ Reviewed-on: https://code.wireshark.org/review/5406
Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 83ad0d0
-Author: Marian Ďurkovič <md@bts.sk>
-Date: Mon Aug 18 07:38:14 2014 +0200
+commit f7f19f0
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Wed Nov 19 20:10:15 2014 +0100
- Fix TRILL LSP display issues
+ IrDA: always initialize buffer before accessing it
- 1) Sub-TLVs unknown to wireshark are not necessarily invalid
- 2) Properly show Root Bridge ID
- 3) Unify Nickname format to HEX_DEC
-
- Change-Id: Ib62f2e2a23f27221b303eaf544868746f56ff6df
- Reviewed-on: https://code.wireshark.org/review/3686
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Bug: 10716
+ Change-Id: I8e54f750b70076758d5fd0d7f35f9c782f5d0bf9
+ Reviewed-on: https://code.wireshark.org/review/5398
+ Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit e3779f1
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Aug 16 15:22:42 2014 +0200
+commit bcc4c7f
+Author: Balint Reczey <balint@balintreczey.hu>
+Date: Fri Nov 14 21:39:00 2014 +0100
- BGP ISIS: Add TLV 14 (Originating LSP Buffer Size)
-
- Need more work for TLV 149
+ Fix global plugin folder when it is set as an absolute path
- Ping-Bug: 10304
- Change-Id: I3953b8d1fdee33253601aa7b443edd37417046e4
- Reviewed-on: https://code.wireshark.org/review/3336
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 30f3a71
-Author: Eugene Sukhodolin <eugene@sukhodolin.com>
-Date: Sun Aug 17 20:10:06 2014 -0700
-
- Parse client and server blocks of settings data introduced in newer RDP versions
+ This fixes regression in creating Debian packages caused by
+ 80b36cdbde90ac9639938a14e8fd90a79602666a
- Change-Id: I46b4557623921e1c2c093ca5e3e75908826358e3
- Reviewed-on: https://code.wireshark.org/review/3681
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I46702ad4c9a11ce317da7ef664c84e1f22d3f709
+ Reviewed-on: https://code.wireshark.org/review/5316
+ Reviewed-by: Evan Huus <eapache@gmail.com>
+ Petri-Dish: Evan Huus <eapache@gmail.com>
+ Reviewed-by: Balint Reczey <balint@balintreczey.hu>
-commit 018b84d
-Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Jul 25 11:34:51 2014 -0400
+commit 6fbcc18
+Author: Michał Orynicz <michal.orynicz@tieto.com>
+Date: Thu Nov 20 09:55:40 2014 +0100
- Refactor "common" hostlist/endpoint table functionality.
+ Fix text logcat for changes in android L
- This is very similar in architecture to the changes made to the Conversation table functionality. Since all conversations have endpoints/hostlists, the "registered" list is shared for both.
+ In L, in line "-- beginning of /<buffer>" the "/" was removed.
+ This commit accomodates text logcat to that change.
- Change-Id: Ie8c6910a68a1b3f27c5b18c4494f49b9404a7b31
- Reviewed-on: https://code.wireshark.org/review/3214
- Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Change-Id: I4cbfadf5a8169589f2848ce1a5793cea593ba459
+ Reviewed-on: https://code.wireshark.org/review/5405
+ Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit a76c888
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 17 21:11:48 2014 -0700
+commit 087518b
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Wed Nov 19 19:18:39 2014 +0100
- Add missing field to the list of fields to register.
+ MIP6: Access network identifier option is not full decoded
- Change-Id: I2590bf69f6778deb15f405c0976c9849af5b4a4e
- Reviewed-on: https://code.wireshark.org/review/3685
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 970446f
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 17 21:06:53 2014 -0700
-
- Sort the elements of ett[] to match the definitions, and add a missing entry.
+ * Add subtype Geo Location (2) and Operator Identifier (3)
+ * Use also offset to calculate the length
+ * Remove proto_tree_add_text
- Sorted so that we can find missing entries; fixed so that there aren't
- any missing entries.
+ Issue reported by Ravindranath K M
- Change-Id: Ic05e4d30f7b65be5ecbba3ff89b7bd13870aba25
- Reviewed-on: https://code.wireshark.org/review/3684
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Bug:10712
+ Change-Id: I9ad81ece856df134f3a706ad774d34e638cb5c94
+ Reviewed-on: https://code.wireshark.org/review/5397
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit e926023
+commit d23247e
Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 17 20:58:52 2014 -0700
+Date: Wed Nov 19 16:53:36 2014 -0800
- Squelch unused parameter warnings.
+ White space tweaking to match what's in Samba git.
+
+ (Samba git also needs some white space tweaking; this only changes the
+ cases where we're not obviously "better".)
- Change-Id: I3bf3c0500bf27e6f1a3c1df57f3141ea34692304
- Reviewed-on: https://code.wireshark.org/review/3683
+ Change-Id: Iafb9cf8fea67b898b12850a7793806e3fccb39ac
+ Reviewed-on: https://code.wireshark.org/review/5403
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 6768255
+commit 4fdabdc
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 19:27:58 2014 +0200
-
- Kerberos : Fix indent (use tabs) and add modelines info
-
- Change-Id: I7965332ee474d10c90dfb2ef63a66f610cd6fc71
- Reviewed-on: https://code.wireshark.org/review/3655
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 4095bbf
-Author: Marian Durkovic <md@bts.sk>
-Date: Sun Aug 17 11:24:14 2014 +0200
+Date: Wed Nov 19 21:35:14 2014 +0100
- Make TRILL NEIGHBOR TLV (145) known to ISIS dissector
- Update RFC references
+ SBC: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
- Change-Id: I977190e6bfce2c27d33f940d058be3be6a5ef3c0
- Reviewed-on: https://code.wireshark.org/review/3669
+ Change-Id: I6ac8e0eed88e78521f7d5623b9afdb6a42900ede
+ Reviewed-on: https://code.wireshark.org/review/5402
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit b8293f9
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 17 17:32:16 2014 -0700
-
- If we don't find a NetScaler signature, don't report an error.
-
- It's *NOT* an error; it's just a file that isn't a NetScaler file.
- Otherwise, we report errors on files that should just be passed on to
- other open routines.
-
- Also, NetScaler files are *NOT* text files, and we should *NOT* use
- ".txt" as the suffix.
-
- Change-Id: If001abbbbc3de3ea27439a44a47ce1d6071d38ae
- Reviewed-on: https://code.wireshark.org/review/3678
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 6a82672
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 17 16:02:19 2014 -0700
-
- Return 0, not -1, for "this isn't my type of file".
-
- -1 means "I got an error reading this file, so there's no point in
- trying any more open routines". It doesn't mean "I couldn't find any
- matching pattern in the text"; that's 0, for "this isn't my type of
- file, but keep trying".
-
- Change-Id: I9d2e8b8fe6720052cacf70f0bacdcbc1175202cc
- Reviewed-on: https://code.wireshark.org/review/3674
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 2d2ecfb
-Author: Marian Durkovic <md@bts.sk>
-Date: Sun Aug 17 07:38:43 2014 +0200
+commit 06dc2a7
+Author: Gerald Combs <gerald@wireshark.org>
+Date: Wed Nov 19 09:03:44 2014 -0800
- Fix TRILL LSP dissector
+ voip_calls: Fix tap callbacks.
- - correctly compute length/offset in all SubTLVs
- - initialize variable before while() loop
- - fix VLAN_GROUP SubTLV according to RFC7176 sec. 2.3.7
+ We don't need to call the VoIP tap reset and draw callbacks repeately.
+ Do so only once from the RTP tap. Packet callbacks should return a
+ gboolean.
- Change-Id: Ib5cc4ce82f63ad39e83c8b1f4a630708f8a8aa88
- Reviewed-on: https://code.wireshark.org/review/3667
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit e1449a8
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Aug 17 08:05:36 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-08-17]
+ Clean up some function names and make some static.
- Change-Id: I81d4f5ea28eb12eb8d32a6d9ba4a61fff3cab86f
- Reviewed-on: https://code.wireshark.org/review/3671
+ Change-Id: I5c934ce8ce7f279861e8cc73235bbfc27d7fe622
+ Reviewed-on: https://code.wireshark.org/review/5396
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 95ddeed
-Author: Marian Durkovic <md@bts.sk>
-Date: Sat Aug 16 13:45:09 2014 +0200
+commit cb090e8
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Wed Nov 19 11:25:17 2014 -0500
- Fix uninitialized variable and print VLAN numbers in decimal
+ [pedantic] Replace usage of 'long' and 'long long'
- Change-Id: Icf3b3ea4968d1ed94a11ce8eb4b4fdd09ed69012
- Reviewed-on: https://code.wireshark.org/review/3660
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I78fc82c1a83eb04d78a11fc76710c92dfc916208
+ Reviewed-on: https://code.wireshark.org/review/5395
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 9de7f56
-Author: Marian Durkovic <md@bts.sk>
-Date: Sat Aug 16 14:15:34 2014 +0200
+commit 67ab27a
+Author: Michael Tüxen <tuexen@wireshark.org>
+Date: Wed Nov 19 15:57:48 2014 +0100
- Fix incorrect SubTLV values and properly handle both old and new
- variant of TRILL Version SubTLV
+ Add support for PAD chunks.
- Note that the SubTLV values have not changed in RFC7176.
+ Add support for PAD chunks as defined in RFC 4820.
- Bug: 10387
- Change-Id: I452debb7165e70f31f1a3a19a44c488c5bbdb959
- Reviewed-on: https://code.wireshark.org/review/3661
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I66a83d5d133429154fe40ccef26687c8350463cf
+ Reviewed-on: https://code.wireshark.org/review/5393
+ Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
-commit 0c3e0db
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 15 14:20:01 2014 -0400
+commit d7179ac
+Author: Michael Tüxen <tuexen@wireshark.org>
+Date: Wed Nov 19 15:35:36 2014 +0100
- Add a few more NEWS items.
+ Fix the length reported as value length.
- Fix a typo in the generation of top_srcdir NEWS.
+ The length reported as value length for unknown chunks
+ was actually the chunk length. Therefore it was off by 4.
- Change-Id: I20a140a68b9afca5096d33d99a3ea5d24e776f05
- Reviewed-on: https://code.wireshark.org/review/3626
- Tested-by: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: Ieea79d2c51b4729fc139395174625d1f362d1ee5
+ Reviewed-on: https://code.wireshark.org/review/5392
+ Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
-commit 7b38bc2
+commit c62dac1
Author: Michael Mann <mmann78@netscape.net>
-Date: Sat Aug 16 22:29:15 2014 -0400
+Date: Sun Nov 16 13:10:37 2014 -0500
- Remove unnecessary includes
+ Eliminate proto_tree_add_text from packet-mate.c
- Change-Id: Ib1a90a07b2d467a81927c53917e05a1af6ba4ee6
- Reviewed-on: https://code.wireshark.org/review/3666
+ Change-Id: I3f4b3eb23b91b219df373b3012fbefa63abfa4d3
+ Reviewed-on: https://code.wireshark.org/review/5350
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit e7853d3
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 19:54:01 2014 +0200
-
- prefs.h : fix indent (use 4 spaces) and add modelines info
-
- Change-Id: I319b76973ade38261f40e6120c436de923b5d5bf
- Reviewed-on: https://code.wireshark.org/review/3658
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 721008c
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 19:49:52 2014 +0200
-
- DCERPC PN IO: Add modelines info
-
- Change-Id: I124c5d38f8f3b4aee6d5dbee0367555742350e55
- Reviewed-on: https://code.wireshark.org/review/3657
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 305f36d
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 19:48:22 2014 +0200
-
- Wimax Plugins: Fix indent (use tabs) and modelines
-
- Change-Id: I27a976c9cac598be5a90412da171915181a784d3
- Reviewed-on: https://code.wireshark.org/review/3656
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit c8cb153
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 19:27:23 2014 +0200
-
- Stats Tree: Add Modelines
-
- Change-Id: Id4b2a2837377d52e9f6c9145f9fbed2465a538df
- Reviewed-on: https://code.wireshark.org/review/3654
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 5673893
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 19:04:35 2014 +0200
-
- PCAPNG Block: Add modelines info
-
- Change-Id: I15ddf62318fc8783a2318025fa6ca110b7991ff5
- Reviewed-on: https://code.wireshark.org/review/3653
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit ef77c1c
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 18:58:30 2014 +0200
-
- OptoMMP: Add modelines info
-
- Change-Id: Ia9ea6e553d92d1045f022254d714fea5440257a5
- Reviewed-on: https://code.wireshark.org/review/3652
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit f17dd37
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 18:57:06 2014 +0200
-
- LLDP: Fix indent (use 4 spaces)
-
- Change-Id: I392d1d23d590187128f81763a937d35229ed6929
- Reviewed-on: https://code.wireshark.org/review/3651
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 1111538
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 18:54:14 2014 +0200
-
- IUUP: Add modelines info
-
- Change-Id: I6cde1a17d917b9cf4c08ca202571fd07bb9302ba
- Reviewed-on: https://code.wireshark.org/review/3650
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit ae6c433
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 18:53:05 2014 +0200
-
- IPMI Update: Add modelines info
-
- Change-Id: I5edf987e0df4c1d363d29ef4b48d901873c1c817
- Reviewed-on: https://code.wireshark.org/review/3649
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 762e762
-Author: Marian Durkovic <md@bts.sk>
-Date: Sat Aug 16 13:42:17 2014 +0200
-
- Fix TRILL ISIS Hellos:
- - MT Port Capability TLVs are present in L1 Hellos
- - unify texts
-
- Change-Id: I3dade81ad4487620a8e46e0b242bbbffbb6c2d49
- Reviewed-on: https://code.wireshark.org/review/3659
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit e9135ce
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 18:44:11 2014 +0200
-
- LINK16: Add modelines info
-
- Change-Id: I4267de691f9b7064b6110eba1c85ddb6b755d3f5
- Reviewed-on: https://code.wireshark.org/review/3648
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 71901b6
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 18:43:34 2014 +0200
-
- OUI: Fix indent (use 4spaces) and modelines info
-
- Use the same indent like epan/oui.h
-
- Change-Id: I02018788bc3f62d170a87a40bd4495630bded1c5
- Reviewed-on: https://code.wireshark.org/review/3647
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit af8f962
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 10:05:14 2014 +0200
-
- tap-iousers: fix indent and add modelines info
-
- Change-Id: Ia144e016bd7fb0b8d4770d45afa1145057d0a5e9
- Reviewed-on: https://code.wireshark.org/review/3646
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 0a8a36e
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Aug 16 10:15:41 2014 +0200
-
- ISIS:LSP : fix indent (remove last tab) and reindent hf
-
- Change-Id: I615e777b4b6af073c174fe0c3554ed0e33f5e68e
- Reviewed-on: https://code.wireshark.org/review/3645
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit a4c0989
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 13 13:09:14 2014 +0200
-
- Fix ISO C does not allow extra ';' outside of a function [-Wpedantic]
-
- Change-Id: I7c0be29b5e5a54e269fec928e6058395ada7e04b
- Reviewed-on: https://code.wireshark.org/review/3644
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 9f96842
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 13 13:09:00 2014 +0200
-
- Fix ISO C does not allow extra ';' outside of a function [-Wpedantic]
-
- Change-Id: Ia956c108d3493e54578247f08ac7b167d8b71f0f
- Reviewed-on: https://code.wireshark.org/review/3643
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 7395915
-Author: Evan Huus <eapache@gmail.com>
-Date: Sat Aug 16 13:58:26 2014 -0400
-
- rtsp: parse the correct token for the status code
-
- Don't call get_token_len on next_token *and* pass in next_token to store the
- subsequent pointer - the token we want to parse is the *current* value of
- next_token, not the next next token (which may be beyond the end of the buffer,
- if next_token happens to be the *last* token).
-
- Bug: 10381
- Change-Id: I9fb27e8bdaf2f9556f61841de30cec04b98ffb96
- Reviewed-on: https://code.wireshark.org/review/3663
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 22e10be
-Author: Evan Huus <eapache@gmail.com>
-Date: Sat Aug 16 13:32:25 2014 -0400
-
- Revert "create audio-specific part of the usb conversation"
-
- Also revert "dissect as interface general descr for v1.00"
-
- This reverts commit 7cd4e8930454b3afa8e73eacd62bafc6f029022b and commit
- 152c6b06f1bb8193b6d2682ae40c61a1d642b7c1 to fix the fuzz failures while we work
- out a proper solution.
-
- Ping-Bug:10386
- Change-Id: I6302b95c103f17bb2b48d43f8fc06352587b9e95
- Reviewed-on: https://code.wireshark.org/review/3662
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit fc2d1bd
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 13 13:08:37 2014 +0200
-
- Fix comma at end of enumerator list [-Wpedantic]
-
- Change-Id: Ib50ddb969471c03cf0ce2f240c3586fe2274965a
- Reviewed-on: https://code.wireshark.org/review/3642
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 72229b2
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 13 13:03:51 2014 +0200
-
- Fix comma at end of enumerator list [-Wpedantic]
-
- Change-Id: If8b817e8276bb065a257f209bf5b0f566d9f7907
- Reviewed-on: https://code.wireshark.org/review/3641
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 3cddcc2
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:51:03 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: Id61288a6abcff44ba813daaa48d403ee5c769da3
- Reviewed-on: https://code.wireshark.org/review/3640
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 91e449e
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:51:00 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I059af62625941e9900b3618aa5721b3b82a2c823
- Reviewed-on: https://code.wireshark.org/review/3639
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 5d9709b
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:50:20 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I78f50ade1febc0dcb2231d742e2213f012535bc7
- Reviewed-on: https://code.wireshark.org/review/3638
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 0517093
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:49:55 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I7e935114417712d1101ea2d6f4b236fac44698d0
- Reviewed-on: https://code.wireshark.org/review/3637
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 772a7ba
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:48:23 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I6790a6c990bd531362171742b938c9f26cb2e1d5
- Reviewed-on: https://code.wireshark.org/review/3636
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 53045fa
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:44:18 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I9dfff8032e8aa4634466fb4cb3b136ff6df1c4b7
- Reviewed-on: https://code.wireshark.org/review/3635
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 370bab2
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:44:08 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: Idd1cf83809877d12b18362e722c6c37251b02495
- Reviewed-on: https://code.wireshark.org/review/3634
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 3f7b762
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:42:36 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I4e3e6ffbdae988a37904cba4d43dc5a1c5f66ed6
- Reviewed-on: https://code.wireshark.org/review/3633
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit fc752f7
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 15 09:40:32 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: Ic3152356c51ebe554e2356a360df5b0c23d89d63
- Reviewed-on: https://code.wireshark.org/review/3632
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 9bd79f4
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 13 17:04:02 2014 +0200
-
- Fix warning: no previous prototype for ... [-Wmissing-prototypes]
-
- Change-Id: I6e545cb85b6a75cde0ca6c41c57e8c7d69ae4dcb
- Reviewed-on: https://code.wireshark.org/review/3631
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit bba8edc
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Aug 15 16:52:40 2014 -0700
-
- README.cmake: List more cmake options.
-
- Change-Id: I80b5c82f57c4de55aba9c7ee8044f565c9819d7e
- Reviewed-on: https://code.wireshark.org/review/3630
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit e5c1f7b
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Aug 14 22:52:50 2014 +0200
+commit 61b0638
+Author: Graham Bloice <graham.bloice@trihedral.com>
+Date: Tue Nov 18 15:59:44 2014 +0000
- get rid of type_2 in most places
-
- type_2 is nothing else but the request type in a setup packet
- this is already stored in the conversation / transaction structure
+ Remove Windows linker flags from the CMake link flags test as the
+ test doesn't actually pass the flags to the VS linker.
- Change-Id: I4dda7aff423eb1b6174a1a630d57e126662abed4
- Reviewed-on: https://code.wireshark.org/review/3598
- Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I5d546afcb80a49e39143078bc8f0855b0ba0f7e8
+ Reviewed-on: https://code.wireshark.org/review/5384
+ Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 61c038e
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 12 17:19:25 2014 +0200
-
- simplify try_dissect_next_protocol()
-
- Change-Id: Idd9690689217bdfc66f9eee1461422358e837774
- Reviewed-on: https://code.wireshark.org/review/3597
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit f0e6239
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Aug 15 11:23:14 2014 -0700
-
- Qt: Disable main menu items that don't do anything.
-
- The functionality associated with Capture → Capture Filters, Analyze
- → Display Filters, Analyze → Display Filter Macros, and Analyze →
- Apply As Column haven't been implemented yet. Disable each menu item
- for now so that we don't play tricks on our users.
-
- Follow our current action naming convention. Rename "Apply as Column"
- to "Create a Column".
-
- Change-Id: I01901db05adc897d877f6a0a699e3049b0149b4a
- Reviewed-on: https://code.wireshark.org/review/3629
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-commit 978faf3
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Aug 14 09:52:09 2014 -0700
+commit 39b0c2d
+Author: Stig Bjørlykke <stig@bjorlykke.org>
+Date: Thu Oct 16 13:58:58 2014 +0200
- NSIS/Qt: Move Qt version logic to windeployqt-to-nsis.
+ Wiretap: Added file_seek SEEK_END support.
- Move Qt version checking from packaging/nsis/Makefile.nmake to
- windeployqt-to-nsis.ps1. Get rid of the -Windeployqt parameter since
- its absence is a condition we now handle.
+ This is needed for Lua File:seek("end").
- Change-Id: Ieba86d5a91e8217ed11dbe57e80bedaccd2e99cf
- Reviewed-on: https://code.wireshark.org/review/3595
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I28fb23f2f29ca8083c77bf065db8816e039ae5a1
+ Reviewed-on: https://code.wireshark.org/review/4722
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
+ Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
+ Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
-commit 4e267ba
+commit cfa0e5f
Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Aug 15 08:59:02 2014 -0700
+Date: Tue Nov 18 13:13:35 2014 -0800
- Windows: Fix PowerShell 2.0 compatibility.
-
- PowerShell 2.0's Get-ChildItem doesn't support "-File" even though
- http://technet.microsoft.com/en-us/library/hh847897.aspx says otherwise.
+ voip_calls: Regression fixes.
- Add a config.nmake option to test PS 2.0 compatibility.
+ Fix struct initialization logic. Clear a GQueue instead of deleting it.
+ Don't crash if we have no sequence diagram items. Make sure we show all
+ flows and not just invites. Zero allocated memory in a couple of places.
- Change-Id: I8de83cd0841d4ab0b01351c2d39084578a2c84ee
- Reviewed-on: https://code.wireshark.org/review/3625
+ Change-Id: Ia5bb3ba57cf625de4b554b354e098aa0361dff28
+ Reviewed-on: https://code.wireshark.org/review/5390
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit a3db896
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Aug 15 10:33:44 2014 -0400
-
- packet-k12.c: Various minor changes:
-
- - Simplify proto_reg_handoff() & move it to the end of the file as per convention;
- - Reformat hf[] & ei[] for readability;
- - Add editor modelines & do whitespace changes.
-
- Change-Id: If01432c5b86129aaaab478493bbb218295bcb65c
- Reviewed-on: https://code.wireshark.org/review/3622
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 271deaa
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Aug 15 09:40:00 2014 -0400
-
- paacket-llc.c: Minor changes
-
- - Remove unneeded '#include <epan/conversation.h>';
- - tvb_length_remaining() --> tvb_reported_length_remaining();
- - Add editor modelines.
-
- Change-Id: I8410a1286238c0fa1ec9f6b680ab0eb2665672f9
- Reviewed-on: https://code.wireshark.org/review/3621
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 60707f8
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Aug 15 09:21:22 2014 -0400
-
- packet-usb-audio.c: Trivial changes
-
- - Remove unneeded #include;
- - Remove some trailing whitespace;
-
- Change-Id: Iddf137d1d507dea4e3e892831fe6a05b80d2fa50
- Reviewed-on: https://code.wireshark.org/review/3620
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 56bd0a2
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 14 21:08:43 2014 -0400
-
- Remove unneeded #include; As needed: Add editor modelines & do whitespace changes.
-
- Change-Id: Ib345833114aab0c70fc20b1fc74c90abecec486e
- Reviewed-on: https://code.wireshark.org/review/3619
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 4945599
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 14 15:00:37 2014 -0400
-
- packet-scsi-ssc.c: remove empty 'proto_reg_handoff_scsi_ssc()'
-
- Change-Id: I1b83d4333644807961922f5adb7be3040fe53e19
- Reviewed-on: https://code.wireshark.org/review/3618
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 0fc977d
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 14 14:55:06 2014 -0400
-
- (Minor) add editor-modelines; Adjust whitespace as needed.
-
- Change-Id: Ife2ec66c7985149d3e31e96e9eade3903d235cc4
- Reviewed-on: https://code.wireshark.org/review/3617
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 23104e9
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 14 14:52:04 2014 -0400
-
- packet-umts_mac.c: remove 'g_warning()' calls; Add editor-modelines; Fix whitespace.
-
- Change-Id: Ia05aba095ce9fbf54039e224a4cbb986ceae8868
- Reviewed-on: https://code.wireshark.org/review/3616
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 3c073f2
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 14 14:28:33 2014 -0400
-
- packet-fclctl.c: remove unnbeeded #include; Create/use value_string_ext; Add editor modelines
-
- Change-Id: I1b9547ec33031b9645648c20be3ca20b07b80d76
- Reviewed-on: https://code.wireshark.org/review/3615
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 7a1b46a
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 14 14:25:40 2014 -0400
-
- packet-catapult-dct2000.c: Create/use and extended value-string; Add editor modelines.
-
- Change-Id: I881700ec2ec011f22172ff21f2f13dfaa6dae68e
- Reviewed-on: https://code.wireshark.org/review/3614
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 43afcb4
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Thu Aug 14 13:51:36 2014 -0400
-
- Remove unneeded #include <epan/prefs.h>; As needed: Add editor-modelines & adjust whitespaxcce.
-
- Change-Id: I6f79357e0f3906f6ccc5b68eb451b69b68636335
- Reviewed-on: https://code.wireshark.org/review/3613
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit facb76a
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Aug 10 21:52:54 2014 -0400
+commit dc5b8f1
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Sun Nov 16 19:09:57 2014 +0200
- packet-gsm_a_dtap.c: various changes (mostly indentation/whitespace/formatting);
+ dissect TA(1)
- - Remove #include <epan/prefs.h> (no prefs);
- - tvb_length() --> tvb_reported_length()
- - Use '4 space' indentation;
- - Use consistent whitespace formatting;
- - Reformat hf[] entries for readability;
-
- Change-Id: I4fd7e860efa795256972d6a31155f0502fb7dcfd
- Reviewed-on: https://code.wireshark.org/review/3612
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: If618b0c3dc0502f5a31dcc580b9116daacb40239
+ Reviewed-on: https://code.wireshark.org/review/5389
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit c84578c
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Aug 10 20:29:16 2014 -0400
+commit 7cdfe52
+Author: Sergey Avseyev <sergey.avseyev@gmail.com>
+Date: Tue Nov 18 21:11:22 2014 +0300
- packet-ppp.h/packet-rmt-common.h: Add #include <epan/params.h> (so certain other files need not do so).
-
- Also: Add editor-modelines (packet-rmt-common.h)
+ Update Couchbase dissector:
- Change-Id: Ib0c45285a9102bb21e8e3c216763ff8cc0150c32
- Reviewed-on: https://code.wireshark.org/review/3611
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 78dab88
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Aug 10 20:19:39 2014 -0400
-
- params.h: Yet another Ethereal --> Wireshark
+ * Register new commands:
+ * 0x5c: DCP_NOOP
+ * 0x5d: DCP_BUFFER_ACKNOWLEDGEMENT
+ * 0x5e: DCP_CONTROL
+ * 0x5f: DCP_RESERVED4
- Change-Id: I301d1ea80333419141850f944977a67f131e07c2
- Reviewed-on: https://code.wireshark.org/review/3610
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: I22d8eb8f6628e07b2e2ab2bc137688329eead1be
+ Reviewed-on: https://code.wireshark.org/review/5385
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 7ee2d6b
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Thu Aug 14 14:02:04 2014 -0400
+commit e97d235
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Mon Nov 17 22:49:24 2014 +0100
- Mark echld and tfshark as experimental in the ./configure help.
+ SPDY: do not try to access an uninitialized tvb
- Move them to the end of the list of optional programs.
- Make it clear that echld is not built by default.
- Change capitalization of tshark and tfshark.
+ Coming when data length = 0
- Change-Id: Ib702ed72eb2469968e06a16c73a4009ba4cf68ad
- Ping-Bug: 10380
- Reviewed-on: https://code.wireshark.org/review/3596
+ Bug: 10704
+ Change-Id: Ibd0730be661d966aa0429480dba97ed7d3e5c471
+ Reviewed-on: https://code.wireshark.org/review/5377
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 8ef6f58
-Author: oyv <ronningstad@gmail.com>
-Date: Fri Aug 15 11:56:28 2014 +0200
+commit 4b96030
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Thu Oct 30 09:16:51 2014 +0100
- btle advertising header flags (RxAdd/TxAdd) dissected incorrectly
+ 802.11: Remove proto_tree_add_text
- bug:10384
- Signed-off-by: oyv <ronningstad@gmail.com>
-
- Change-Id: Ic31772c551f36fc8d144a5eaeae987a1e5f3e3f1
- Reviewed-on: https://code.wireshark.org/review/3601
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- (cherry picked from commit 9337e7962df8bc12f27019b20dedbb2311669949)
- Change-Id: Ic31772c551f36fc8d144a5eaeae987a1e5f3e3f1
- Reviewed-on: https://code.wireshark.org/review/3609
+ Change-Id: I40d351e3317ff7e207e5c68a39aaedb73faf54f9
+ Reviewed-on: https://code.wireshark.org/review/5281
Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 50c8cc6
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 15 03:34:11 2014 -0700
-
- Regenerate manuf with the updated wka.tmpl.
-
- Bug: 10383
- Change-Id: I5ab14ecd0e460e39c2ec5f9259a8b9dd93c3eeb6
- Reviewed-on: https://code.wireshark.org/review/3604
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 47bb34a
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 15 03:26:02 2014 -0700
-
- Add some missing group addresses.
-
- Bug: 10383
- Change-Id: I94c9604824f25347fcd3c7bfd5c18aabdbe0a332
- Reviewed-on: https://code.wireshark.org/review/3603
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 2cab876
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 15 03:15:32 2014 -0700
-
- An NLPID of 0xc0 refers to TRILL.
-
- This will, at least, make it show up as the meaning of a field
- containing an NLPID; whether it's actually used to say "a TRILL packet
- follows" is another matter.
-
- At least partially addresses bug 10382, and fully addresses it if it's
- never actually used to say "a TRILL packet follows".
-
- Change-Id: Ic9dc8ec432532bde692fad3aa9cc97a3109aa634
- Reviewed-on: https://code.wireshark.org/review/3602
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 480fcfd
+commit c2f971d
Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Aug 14 18:28:43 2014 -0700
+Date: Mon Nov 17 21:16:19 2014 -0800
- Update some URLs.
+ Fix indentation.
- Change-Id: Iaba677670907dbfb028c1112cd11986d859329cb
- Reviewed-on: https://code.wireshark.org/review/3600
+ Change-Id: Icc474748f755c21d281620c3b0f5d4d90f09223b
+ Reviewed-on: https://code.wireshark.org/review/5380
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 02187b0
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Thu Aug 14 22:37:26 2014 +0100
-
- Remove errant #! from powershell script
-
- Change-Id: I6c94ce5983654eba20aa8c852efe300e06c957a5
- Reviewed-on: https://code.wireshark.org/review/3599
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
-
-commit 297237b
-Author: Evan Huus <eapache@gmail.com>
-Date: Thu Aug 14 09:40:10 2014 -0400
-
- fix one last reference to textify.sh
-
- Change-Id: I2f8bd5a69fd80d6d34a4079cd05a4f4b278274fd
- Reviewed-on: https://code.wireshark.org/review/3594
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 673247f
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Aug 7 17:30:45 2014 -0700
-
- Windows: Clean up text file packaging.
-
- Convert textify.sh to PowerShell. Use PowerShell's built-in line ending
- conversion so that we don't depend on unix2dos.
-
- Only copy the help toc and text files to the staging directory.
-
- Add PowerShell to the Developer's Guide. Fixup some other content.
-
- (asn1/Makefile.inc.nmake contains a call to u2d. Hopefully that's not
- a problem.)
-
- Change-Id: I61a92aa54820d01015abb9ffa65815558ae31c71
- Reviewed-on: https://code.wireshark.org/review/3487
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
- Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
-
-commit d68d0e8
-Author: Michael Mann <mmann78@netscape.net>
-Date: Wed Aug 13 08:56:22 2014 -0400
+commit 36837a2
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Mon Nov 17 23:22:08 2014 +0100
- Eliminate proto_tree_add_text from some dissectors.
-
- Other minor cleanup while in the neighborhood.
+ MIPv6: display Experimental Mobility Message Data as such
- Change-Id: If73a029f564219782c313d4154c24c7ce7458b52
- Reviewed-on: https://code.wireshark.org/review/3574
+ Bug: 10703
+ Change-Id: I9b16f503418d7464234be3c772b5dae3fb5eb7a9
+ Reviewed-on: https://code.wireshark.org/review/5378
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit f64421d
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Tue Aug 12 17:01:25 2014 +0200
-
- Qt: Add note about relaunch Wireshark to apply change about language
-
- Change-Id: Ibdc7d6b664d681de990608d689170b02439f0ae7
- Reviewed-on: https://code.wireshark.org/review/3559
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 4469825
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 13 21:05:38 2014 -0400
-
- Fix the uninitialized-read error reported in bug 10370.
-
- Fix apparent cut-n-pasteo: if offset_e is set then we should be looking
- at offset_e (instead of offset_s) and ts_end (instead of ts_start).
-
- Bug: 10370
- Change-Id: I0683ad55ac782c7fd03b7dbdf3f34df713267de5
- Reviewed-on: https://code.wireshark.org/review/3589
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 4388b56
+commit 1dec509
Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Aug 13 17:27:26 2014 -0700
+Date: Mon Nov 17 16:43:39 2014 -0800
- CMake: More Qt5WinExtras plumbing.
+ voip_calls: Move to ui.
- Change-Id: I7474e8373668ba554d3574193fec59daceafe00d
- Reviewed-on: https://code.wireshark.org/review/3588
+ Move voip_calls.[ch] to ui. Add callbacks to voip_calls_tapinfo_t.
+ Remove unused function definitions.
+
+ Change-Id: Ib12db7053d53afa81ef2a66dc0cfe681bc624dd2
+ Reviewed-on: https://code.wireshark.org/review/5379
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit e99bbef
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 13 20:30:25 2014 -0400
+commit a07f081
+Author: Gerald Combs <gerald@zing.org>
+Date: Sun Nov 16 11:32:11 2014 -0800
- Don't show us the full Python command-line for building register.c.
+ voip_calls: Get rid of global variables.
- The echo and output of make-dissector-reg.py is sufficient.
+ Move the members of voip_rtp_tapinfo_t to voip_calls_tapinfo_t. Move a
+ bunch of formerly static variables there as well. Note that we might
+ want to make them private again at some point. Remove launch_count. It
+ appeared to be unused.
- Change-Id: I89462435e8966012ec057ccd45adb595f692b0fb
- Reviewed-on: https://code.wireshark.org/review/3587
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit e397827
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Aug 13 08:10:44 2014 -0700
-
- Windows Qt: Add taskbar progress support
+ Wrap the individual registration routines in voip_calls_init_all_taps.
+ Wrap the removal routines in voip_calls_remove_all_tap_listeners.
- Add support for the taskbar progress indicator on Windows via
- QtWinExtras. It is almost as if we're a grown up Windows application.
+ Move voip_calls_get_info() to voip_calls_dlg.c. Make it static.
- Change-Id: I378206b49510d4bd08f2437d8e9a1b01bc6f1351
- Reviewed-on: https://code.wireshark.org/review/3576
+ Change-Id: I58f9d91f55cfb5e4b0c048a5a1d5d4b947f4641b
+ Reviewed-on: https://code.wireshark.org/review/5372
Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit a83f67c
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 13 17:40:16 2014 -0400
-
- Use a wildcard to exclude all Wireshark (GUI) binaries: rpmbuild in RHEL6
- errors out if you %exclude a file that's not there.
-
- Fixes the issue reported by Chris on the -dev list.
-
- Change-Id: If8d8b6a9ee69c3d94756b729a809f3c04fc2517f
- Reviewed-on: https://code.wireshark.org/review/3586
- Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
- Petri-Dish: Christopher Maynard <Christopher.Maynard@gtech.com>
-
-commit e21fbd1
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 12 18:00:36 2014 +0200
-
- initialize bus_id and device
-
- Change-Id: I18b6e17091c0f019535a0dc1734e60795339bb04
- Reviewed-on: https://code.wireshark.org/review/3584
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 797d286
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 12 17:07:46 2014 +0200
-
- add the bus_id when we search for an existing conversation to our endpoint
- (the existing code uses bus_id 0 by default and creates a new conversation)
-
- Change-Id: I33a105bdf4218ac2dd21cf76825e972ff2dd1b9b
- Reviewed-on: https://code.wireshark.org/review/3583
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 152c6b0
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Mon Aug 11 11:48:10 2014 +0200
+commit 5c7c701
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 17 19:10:14 2014 +0100
- dissect as interface general descr for v1.00
+ 802.11: Enhance Supported Operating Classes
- Change-Id: I338ce8d6eb0865af9d0f5669c44389ade2bf0f49
- Reviewed-on: https://code.wireshark.org/review/3582
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 7cd4e89
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Mon Aug 11 11:06:52 2014 +0200
-
- create audio-specific part of the usb conversation
- store the major spec version there
+ * Use expert_info to display warning about length (Remove proto_tree_add_text)
- Change-Id: I55564cbca7fb9faa307f1a684858d2e5d2393fc9
- Reviewed-on: https://code.wireshark.org/review/3581
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: I36ce6b6fc1138c53621da4913e23f9f1ceaaca50
+ Reviewed-on: https://code.wireshark.org/review/5369
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit a2e99f5
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Fri Aug 8 11:37:45 2014 +0200
+commit 4b63d9f
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 17 19:03:46 2014 +0100
- distinguish between different audio descriptor types and subtypes
- dissect the AC interface header descriptor
+ 802.11: Enhance Extenede Channel Switch Announcement
- Change-Id: I10f81e5cbf3837d958b255b5a3405ac2465b171f
- Reviewed-on: https://code.wireshark.org/review/3580
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit b7c02da
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Aug 7 23:10:19 2014 +0200
-
- get conversation info when we parse audio class-specific descriptors
- reject the descriptor if the class is not audio
+ * Use expert info to display warning about launch (remove proto_tree_add_text)
+ * Remove a check about Unknown data (Not need)
- Change-Id: Ie07f0fb711884e63cbe86d9417570108edd6b5ab
- Reviewed-on: https://code.wireshark.org/review/3578
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: I3ec1d0f5b955019cfe43141df5f712eb1446dce3
+ Reviewed-on: https://code.wireshark.org/review/5368
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 2952daa
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Fri Aug 8 10:42:32 2014 +0200
+commit f4ad915
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 17 21:43:36 2014 +0100
- rename the defines to make it clear that these are interface subclasses
+ H248: Fix Dereference of null pointer found by Clang analyzer
- Change-Id: I0ad2168f89f8c4fbb2d2324f60de1276d023b41c
- Reviewed-on: https://code.wireshark.org/review/3579
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit cef38a7
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Fri Aug 8 16:56:51 2014 +0200
-
- additional parentheses around the macro argument
+ Also fix some indent issue
- Change-Id: Idd590dc4d79c1a550d35544b46a79a5cc755f503
- Reviewed-on: https://code.wireshark.org/review/3577
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: I262bdddd031fec6a0f91b7172bb2d67be3c33000
+ Reviewed-on: https://code.wireshark.org/review/5370
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 3e1fec0
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 12 20:35:56 2014 -0400
+commit da69b51
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Mon Nov 17 21:59:14 2014 +0100
- More INSTALL updates.
-
- - We now support Gtk+-3, Gtk+-2, and Qt (Gtk+-1 is long dead).
- - Sync several of the configure options to what ./configure actually does
- (don't bother listing features which default to disabled though).
- - Don't mention sysconfdir since manuf doesn't go there any more (it goes
- in datadir).
- - Remove special install instructions for an ancient version of libpcap.
- - Point users to the Q&A site.
+ DECT: ensure that bfield_data buffer is always fully initiated
- Change-Id: I96a9e13fcf4225c526c5d9b536425b2d20e659f6
- Reviewed-on: https://code.wireshark.org/review/3566
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Bug: 10710
+ Change-Id: I444bc4ff7e542a8aa5ac8e20bac44a823ac74cfd
+ Reviewed-on: https://code.wireshark.org/review/5371
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 9e560bc
+commit 7a7a763
Author: Joerg Mayer <jmayer@loplof.de>
-Date: Wed Aug 13 14:33:34 2014 +0200
+Date: Mon Nov 17 21:12:54 2014 +0100
- Fix warning when compiling with -O3
-
- /home/jmayer/work/wireshark/git/epan/dissectors/packet-lmp.c: In function ‘dissect_lmp’:
- /home/jmayer/work/wireshark/git/epan/dissectors/packet-lmp.c:776:13: error: array subscript is below array bounds [-Werror=array-bounds]
- ti = proto_tree_add_item(lmp_tree,
- ^
+ cmake:
+ Avoide rebuilding the guides each and every time.
+ Don't print the single file guides to stdout.
- Change-Id: Ie949b4280f71a8f9f480a8e1d6592098ee7e67b5
- Reviewed-on: https://code.wireshark.org/review/3573
+ Change-Id: Ie94fc4b24676e9abc7258c4ea1c7fd3049a96fb6
+ Reviewed-on: https://code.wireshark.org/review/5367
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-commit 633f156
+commit 4a86d62
Author: Joerg Mayer <jmayer@loplof.de>
-Date: Wed Aug 13 14:18:16 2014 +0200
+Date: Mon Nov 17 21:05:11 2014 +0100
- Fix warning when compiling with -O3:
+ Use ntoh24 instead of less readable and less correct code.
+ Remove redundant / wrong comments.
+ Add two small (helpful) comments :-)
- /home/jmayer/work/wireshark/git/epan/dissectors/packet-ipp.c: In function ‘dissect_ipp’:
- /home/jmayer/work/wireshark/git/epan/dissectors/packet-ipp.c:583:78: error: ‘name_val’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
- if ((name_length > 5) && name_val && !strcmp(name_val+name_length-5, "-time")) {
- ^
- /home/jmayer/work/wireshark/git/epan/dissectors/packet-ipp.c:557:11: note: ‘name_val’ was declared here
- char *name_val;
- ^
-
- Change-Id: I5e49596010572b285e4ca8f210cdcf49d56bfc10
- Reviewed-on: https://code.wireshark.org/review/3572
+ Change-Id: I9c5451587d744a8418e6a90139b771a055e93387
+ Reviewed-on: https://code.wireshark.org/review/5366
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-commit ea87383
-Author: Luke Chou <luke.chou@gmail.com>
-Date: Thu Jul 10 01:37:58 2014 -0400
+commit 82bb363
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Mon Nov 17 17:10:36 2014 +0100
- 802.11 : 11ac decode update , base on IEEE-11ac-2013
- IE193 Extended BSS Load element (8.4.2.162)
- IE194 Wide Bandwidth Channel Switch element (8.4.2.163)
- IE199 Operating mode notification
- And extend capabilities octet 8.
+ LLDP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
- Bug:10258
- Change-Id: If5ef2b72eec2bdbf1d111eaa2b4d2d5954b7413b
- Reviewed-on: https://code.wireshark.org/review/2915
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: I8c750ed9ad775b9be9d12050d200d7f1b4ddb86e
+ Reviewed-on: https://code.wireshark.org/review/5365
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit acf39ff
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 13 08:51:20 2014 +0200
+commit 3ce0167
+Author: AndersBroman <anders.broman@ericsson.com>
+Date: Mon Nov 17 13:36:17 2014 +0100
- SNMP : Continue to fix indent (use tab)
+ [BSSMAP] de_mid() used with wrong length.
- Change-Id: I6b92deb2dbf9b9c4be7fd75d6d788755524a7483
- Reviewed-on: https://code.wireshark.org/review/3570
+ Change-Id: Ia64f254d85845ff39eacc7a339fdfa646ff9bb50
+ Reviewed-on: https://code.wireshark.org/review/5364
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 3841821
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 13 08:25:21 2014 +0200
+commit 3815b14
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Mon Nov 17 10:44:36 2014 +0100
- SNMP: Remove some unused hf field
+ E212: fix bytes highlighting when dissecting the high nibble variant
- Change-Id: I33c89d07af6658569df3a9a094e2865e28ed0acb
- Reviewed-on: https://code.wireshark.org/review/3569
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit f59e694
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Wed Aug 13 07:59:35 2014 +0200
-
- Fix warning (turning error) when compiling with -O3
-
- In file included from /home/jmayer/work/wireshark/git/epan/wslua/lrexlib_glib.c:199:0:
- /home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h: In function ‘generic_find_func’:
- /home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h:486:14: error: ‘ud’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
- TUserdata *ud;
- ^
- /home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h: In function ‘algf_gsub’:
- /home/jmayer/work/wireshark/git/epan/wslua/lrexlib_algo.h:281:14: error: ‘ud’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
- TUserdata *ud;
- ^
-
- Change-Id: I835103ea562ced44bc3cce5fadf6115476a78d0e
- Reviewed-on: https://code.wireshark.org/review/3568
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
+ Change-Id: I376dcb333f7768242dbdb73313870e1e22d959ff
+ Reviewed-on: https://code.wireshark.org/review/5362
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit d9e5021
-Author: Evan Huus <eapache@gmail.com>
-Date: Tue Aug 12 20:21:19 2014 -0400
+commit bea106c
+Author: Michael Mann <mmann78@netscape.net>
+Date: Fri Nov 14 15:12:06 2014 -0500
- hip: fix infinite loop in dissect_hip_tlv
+ Eliminate proto_tree_add_text
- We can't use tree_item == NULL to determine which branch of the previous if was
- hit, since proto_tree_add_item can return NULL when run without tree, which was
- leading to an infinite loop since we were never advancing the offset. Use the
- actual locator_type instead.
+ Also some other cleanup to simplify dissector logic.
- Introduced by either g3635d7bed70 or gebff85fdbb although neither of them
- directly touch this code path. I'm guess that g3635d7bed70 removed an if (tree)
- guard in some calling function which would have prevented this, but I haven't
- checked. The bug would still have been there before, it just wouldn't have been
- hit because it's only present with a NULL tree. Somebody more familiar with the
- protocol should probably go over a capture or two and make sure this isn't a
- symptom of some other decoding gone awry in the recent changes.
-
- Change-Id: Ie1ce89b16ef667b437c0d99c25e3f3cb2504347d
- Reviewed-on: https://code.wireshark.org/review/3564
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Ia84300b7eadafe292361014dd0e565ec250cae44
+ Reviewed-on: https://code.wireshark.org/review/5311
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 20721cb
-Author: Evan Huus <eapache@gmail.com>
-Date: Tue Aug 12 20:39:07 2014 -0400
+commit f3f833c
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Tue Nov 11 21:05:03 2014 +0100
- http2: C90 doesn't permit anonymous structs or unions
+ display filter: the body of a range should only be
+ a string, a field name or another range - not an unparsed element
- Change-Id: I88d048e4012109957a0b5e7a2480faed9fbe9cc4
- Reviewed-on: https://code.wireshark.org/review/3565
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Bug: 10690
+ Change-Id: I126143636c940cc73ed6467660f0a573209e2ae9
+ Reviewed-on: https://code.wireshark.org/review/5243
+ Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-commit a5405e0
-Author: Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com>
-Date: Mon Aug 4 21:06:14 2014 +0900
+commit 25f950e
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sun Nov 16 18:25:56 2014 -0800
- http2: Add additional header decoding information
+ Add tshark -G dissector-tables to dump a list of dissector tables.
- This patch adds additional header decoding information, such as header
- encoding representation, including header table size update (HPACK
- draft-09, section 7).
+ That list doesn't show the entries in the dissector tables, just
+ information about the tables themselves.
- Previously when user clicks the decoded header info, it highlights
- wrong byte sequence in compressed pane. This patch fixes this and now
- clicking header will highlight the byte sequence it was decoded from.
+ Clean up some tshark man page issues while we're at it.
- Change-Id: I611a34edef31640c59a1f8bbc26db1c42eb16ce2
- Reviewed-on: https://code.wireshark.org/review/3407
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I70beee34110f5c0d58105944dd71105a8400f5ca
+ Reviewed-on: https://code.wireshark.org/review/5360
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 61d522f
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 12 18:02:11 2014 -0400
+commit 57b7227
+Author: Michael Mann <mmann78@netscape.net>
+Date: Fri Nov 14 15:13:05 2014 -0500
- Indicate that Python is required to compile Wireshark.
-
- Remove some trailing white space at the same time.
+ Eliminate proto_tree_add_text by formatting field hf_opcua_ByteString in a few places.
- (The ./configure options in INSTALL are significantly out of date--that will
- be the subject of a separate commit.)
-
- Change-Id: I3c03f90dab099e6d3386a235f35b691e7ff671be
- Reviewed-on: https://code.wireshark.org/review/3563
- Reviewed-by: Daniel Black <danielblack@fedoraproject.org>
+ Change-Id: I9606aa36b7d7b6bb2ef2e7685e6629163ca83ef7
+ Reviewed-on: https://code.wireshark.org/review/5312
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit 65ac652
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Tue Aug 12 23:30:16 2014 +0200
-
- Remove make-dissector-reg and require python for autotool builds as well
-
- Change-Id: I6239063a08ba37199a4e95302a3650a80544c750
- Reviewed-on: https://code.wireshark.org/review/3562
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit 433eeda
+commit 14bc6d8
Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 12 10:09:03 2014 -0400
+Date: Sun Nov 16 12:17:40 2014 -0500
- When checking if a message is Diameter also check for a minimum message length.
+ Remove some ununused/unmatched <resources/> tags.
- This improves the detection of Diameter messages within a TCP bytestream (i.e.,
- when the Diameter PDUs don't neatly align with frames).
-
- Bug: 10362
- Change-Id: I49a6e8cf076a6ab8a14761493aab9f3b11e4756e
- Reviewed-on: https://code.wireshark.org/review/3557
- Petri-Dish: Evan Huus <eapache@gmail.com>
+ Change-Id: I0f8e4381b27d1defeb5980692823d297d2f48bab
+ Reviewed-on: https://code.wireshark.org/review/5349
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit b698426
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Tue Aug 12 18:58:29 2014 +0200
-
- Remove unneeded include of config.h
-
- Change-Id: I7688c9a9dc88023d562fb665109185e22f2d06e8
- Reviewed-on: https://code.wireshark.org/review/3560
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
-
-commit 7b05f6c
-Author: Eugene Sukhodolin <eugene@sukhodolin.com>
-Date: Sun Aug 10 20:24:05 2014 -0700
-
- Remove parsing of non-existing TS_UD_SC_SEC1 fields
-
- When RDP encryption method/level is NONE (CredSSP implies this case), TS_UD_SC_SEC1::encryptionLevel is the last present field. Subsequent fields aren't present in this case.
-
- Change-Id: I44cfea3ed52fae1ed6c416aeb01c3cf6ff002a3c
- Reviewed-on: https://code.wireshark.org/review/3545
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit ddada16
+commit cacbffe
Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Aug 10 16:48:40 2014 +0200
-
- NSIS: check Windows version before running uninstaller
-
- Change-Id: Icc8d725bff484c48d14e0a9208c545ca512a9768
- Reviewed-on: https://code.wireshark.org/review/3533
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
- Petri-Dish: Christopher Maynard <Christopher.Maynard@gtech.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 0ea25a6
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 10 18:21:31 2014 +0400
+Date: Sun Nov 16 21:58:36 2014 +0100
- Remove a bogus make-dissector-reg dependency from UseMakeDissectorReg.cmake
+ PortableApps: ensure that the personal folder is set to the App directory
- The shell script is not used in the CMake build system.
+ Otherwise the portable version ends up loading the user local personal profile
- Change-Id: I97d3d750f2521c626594200da8fc9a4453414576
- Reviewed-on: https://code.wireshark.org/review/3530
+ Change-Id: Ib670c065319b0dd9673f239ae9459f6ee530f69e
+ Reviewed-on: https://code.wireshark.org/review/5351
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 4fd9809
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Aug 11 16:41:38 2014 -0400
+commit e26e1dc
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sun Nov 16 16:12:40 2014 +0100
- Fix generation of wslua taps in out-of-source-tree builds when the source tree
- is a source tarball (rather than git):
+ BATMAN: fix indent and encoding args
- Don't put the $(srcdir) path (from when the source tarball was made) into the
- C file: that file isn't regenerated when ./configure is run. (This is a
- correction to 0996730b91fddbf8aa7c61730a50da28ea1ab6a0).
+ use tabs for indent and use fix-encoding-args tools
- Also change a few dependency paths so they'll work in out-of-source-tree builds.
-
- Change-Id: I416f2d3611fb61659b9a7f7285e5f54a354fbe7d
- Reviewed-on: https://code.wireshark.org/review/3554
- Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Change-Id: I5e066c6cbc429021cf21a55d5ffd5b60718ad5f8
+ Reviewed-on: https://code.wireshark.org/review/5340
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 50c7d8e
-Author: Tim Furlong <tim.furlong@gmail.com>
-Date: Tue Jun 17 13:00:03 2014 -0700
+commit 9d0085f
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sun Nov 16 15:21:12 2014 -0800
- Use an explicit path for stats_tree_dialog.cpp.
+ Make sure the NLPID appears in the protocol tree.
- Change the entry for stats_tree_dialog.cpp in ui/qt/QtShark.pro to
- have a relative "../qt/" path, so that Qt Creator can find it from its
- build...-release temporary directory.
+ For protocols for which the NLPID is not considered part of the PDU, put
+ the NLPID into the protocol tree ourselves.
- Change-Id: I8fa40e15a7fbb643d5565e216ce92f73afcd4871
- Reviewed-on: https://code.wireshark.org/review/2340
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Bug: 10706
+ Change-Id: I2676d1934dd468ec755a6f94d95a23f025ba0f25
+ Reviewed-on: https://code.wireshark.org/review/5358
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit f022e15
-Author: Dom Gifford <Dominic.Gifford@atmel.com>
-Date: Mon Aug 11 14:53:04 2014 +0100
+commit 08a9478
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Sun Nov 16 14:59:23 2014 -0800
- Guard against buffer overflow when copying group key bytes into
- security association structure.
+ Fix a comment to reflect reality.
- Change-Id: I2f573a0626bab44aaca1ac6716bf5ac3d6a9b7ed
- Reviewed-on: https://code.wireshark.org/review/3553
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I812b0246368266c76f7fe9ef355619603c5d37b0
+ Reviewed-on: https://code.wireshark.org/review/5357
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit cb44442
+commit 7b558dd
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 11 09:35:11 2014 +0200
+Date: Sun Nov 2 16:15:31 2014 +0100
- SNMP: fix mixed indent (use tab)
+ Add unused-const-variable (enable by default on new clang release)
- Change-Id: I19fde26bf7d1d2b19fcb56573f6e0814d1a7b8ab
- Reviewed-on: https://code.wireshark.org/review/3551
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I1d882e02188ba38ec1b5583c5933d0c92f0539e4
+ Reviewed-on: https://code.wireshark.org/review/5068
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Balint Reczey <balint@balintreczey.hu>
-commit 4c131ce
+commit 05acb67
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 11 09:16:18 2014 +0200
+Date: Sun Nov 16 16:28:51 2014 +0100
- SNMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
+ mcast_stream: fix indent (use 4 spaces)
- Change-Id: I00d66ff57fd3ea1ede692c85b2ae0286c30557b7
- Reviewed-on: https://code.wireshark.org/review/3550
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit db7143d
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 11 09:05:18 2014 +0200
-
- SNMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
+ Add also modelines info
- Change-Id: Ifd4fef4ff7cc5a3197a802e0da5851370ddcd715
- Reviewed-on: https://code.wireshark.org/review/3549
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Idea65bfa25ce8a379c590074ab89a06f935c6648
+ Reviewed-on: https://code.wireshark.org/review/5344
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit aaeedcb
+commit 7213ad5
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 11 08:58:13 2014 +0200
+Date: Sun Nov 16 16:42:32 2014 +0100
- Fix modeline (use Wireshark standard with C comment and no C++ comment)
+ rtp_stream: fix indent (use 4 spaces)
- Fix also some indent (tab->4spaces)
+ Add also modelines info
- Change-Id: Ieef26591d405c6abe622f9fa26d2a7117af3c259
- Reviewed-on: https://code.wireshark.org/review/3548
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit a2090cd
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 11 02:40:17 2014 -0700
-
- Give more information about string encodings.
-
- Fix some indentation while we're at it.
-
- Change-Id: I887af6e7507e1cd3c7e2b5bb5124d913aea01f9c
- Reviewed-on: https://code.wireshark.org/review/3552
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I4c4c6d7e292ba387aacb3f71afcac756b2875847
+ Reviewed-on: https://code.wireshark.org/review/5345
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 9deb769
-Author: Eugene Sukhodolin <eugene@sukhodolin.com>
-Date: Sun Aug 10 23:02:30 2014 -0700
+commit b867baf
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sun Nov 16 16:15:27 2014 +0100
- Minor typo corrections
+ BATMAN: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
- Change-Id: I5962ba6a9b9285095ddacf00307a3094c697461a
- Reviewed-on: https://code.wireshark.org/review/3546
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: I6cfabc18921397002a2303f3511fa51bf5b41956
+ Reviewed-on: https://code.wireshark.org/review/5341
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 9c79921
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Fri Aug 8 23:14:54 2014 +0100
+commit 9f0fb57
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sun Nov 16 16:00:35 2014 +0100
- Fix the CMake QT build
-
- The HAVE_PCAP_REMOTE definition is in config.h, so the .h files
- that depend on the definition must include it so the MOC compiler
- will generate the required code.
+ RADIUS: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
- Change-Id: Ifc17db4fc3f0e3323726792308e303d28d8bcc7f
- Reviewed-on: https://code.wireshark.org/review/3516
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I5127b737c0d9db08c61a70bb6c16fef030d39f83
+ Reviewed-on: https://code.wireshark.org/review/5339
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 93e03e6
-Author: Gerald Combs <gerald@zing.org>
-Date: Sun Aug 10 17:53:00 2014 -0700
+commit 0cc6a7e
+Author: Gerald Combs <gerald@wireshark.org>
+Date: Sun Nov 16 08:06:50 2014 -0800
- IAPP: Remove an unused variable.
+ [Automatic manuf, services and enterprise-numbers update for 2014-11-16]
- Change-Id: Iee584bdb384056afe0f980bf18163b449ccecf59
- Reviewed-on: https://code.wireshark.org/review/3544
+ Change-Id: Ie677285f75a7ef0390d93469a4f97eaad813fdc0
+ Reviewed-on: https://code.wireshark.org/review/5346
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit d161f21
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sun Aug 10 17:34:52 2014 -0400
-
- packet-hislip.c: various minor fixes
-
- - Create/use an extended value-string;
- - Clean up code relating to setting COL_PROTO & COL_INFO;
- - Use consistent whitespace formatting.
-
- Change-Id: I3087d959db09cd90c1a5dd53fe7af7baf999b76c
- Reviewed-on: https://code.wireshark.org/review/3542
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit e7301a1
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Sat Aug 9 11:51:10 2014 -0400
-
- packet-hislip.c: Fix various bugs and deficiencies
-
- - Remove an incorrect call to conversation_new()
- (which messed up TCP sequence number analysis).
- - hislip Request/Response analysis must be done during 'pass1'
- (i.e. when 'flags.visited == 0');
- Not doing so caused various problems including
- tshark '1 pass' poor dissection.
- - Remove 'if (tree)' around a call to expert_...().
- - Don't show "unknown" for Async/Sync when the value is actually known.
- - Simplify some code.
- - Mark a field as GENERATED.
-
- Change-Id: I286c12f52e5f73377bed3a2792f3ff0003e2785f
- Reviewed-on: https://code.wireshark.org/review/3541
- Petri-Dish: Bill Meier <wmeier@newsguy.com>
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit d13b031
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Aug 8 11:55:25 2014 -0400
-
- packet-lg8979.c: Various minor changes
-
- - tvb_length() --> tvb_reported_length();
- - Add an XXX comment re use of 'get_length' for tcp_dissect_pdus();
- - Remove a few unneeded initializers;
- - Simplify/adjust code in a few places;
- - Remove some boilerplate comments;
- - Reformat some whitespace and long-lines.
-
- Change-Id: I17b9750cc1bdb5140edc28efbae5bf0f6ec23b6e
- Reviewed-on: https://code.wireshark.org/review/3538
- Petri-Dish: Bill Meier <wmeier@newsguy.com>
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 52ddc45
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Aug 8 12:34:46 2014 -0400
+commit 7f7d566
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sun Nov 16 15:27:06 2014 +0100
- packet-epon.c: remove an unneeded #include
+ btavdtp: Add missing break;
- Change-Id: Ia8af5d6ff496c099ba3c38d393a622f3a6c8fe67
- Reviewed-on: https://code.wireshark.org/review/3540
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 468cead
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Fri Aug 8 12:22:47 2014 -0400
-
- packet-elmi.c: Remove an unneeded #include.
+ Issue found by Clang Analyzer:
+ Value stored to 'codec_dissector' is never read
- Change-Id: I55d9fef94467d03f88f5acad6cb6ada3fc873b7c
- Reviewed-on: https://code.wireshark.org/review/3539
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: I7a9fc5e3ffd04c77cbbb8d5e5b885d8a29468cfd
+ Reviewed-on: https://code.wireshark.org/review/5330
+ Reviewed-by: Balint Reczey <balint@balintreczey.hu>
-commit 3635d7b
+commit b12be84
Author: Michael Mann <mmann78@netscape.net>
-Date: Sat Aug 9 13:43:44 2014 -0400
+Date: Sat Nov 15 21:24:27 2014 -0500
- Eliminate proto_tree_add_text from some dissectors.
+ Remove file_type_subtype member from packet_info.
- Other minor cleanup while in the neighborhood.
+ Just pass the necessary data to the frame dissector.
- Change-Id: Ib76f4a9f89b5933425760af0a980c6a549031b8f
- Reviewed-on: https://code.wireshark.org/review/3537
+ Change-Id: I1a4bab32f7b5e28f4e7707794d71b04dab388908
+ Reviewed-on: https://code.wireshark.org/review/5328
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 18346c8
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 10 21:17:53 2014 +0400
+commit d1696a6
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 15 18:47:06 2014 -0500
- ssh.dh_gex.nbits: there's only one number
+ "Bubble up" the use of pinfo->circuit_id and pinfo->ctype to make it more obvious where in used in hopes that it can be eliminated through passing dissector data (or methods other than using packet_info)
- Change-Id: Ia3bd392b2223cf666828d65a61e069c465d3894a
- Reviewed-on: https://code.wireshark.org/review/3536
+ Change-Id: Ib0e7efc123a3f9c06f58b5579c3c25b18818205c
+ Reviewed-on: https://code.wireshark.org/review/5326
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit e1de06f
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 10 21:05:52 2014 +0400
+commit f92ed4d
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 15 20:35:51 2014 -0500
- SSH: don't display "Payload" if it's empty
-
- The "Payload" field only makes sense for packets that have unknown
- type or are unexpectedly long. For normal traces, it will always be
- empty, so hide it.
+ Remove ipproto member of packet_info.
- Note: this length check used to be implicitly performed by
- ssh_proto_tree_add_item before 2aa66aa2b2daf0693e405371a5f9037a43896441,
- so this just restores the former behaviour.
+ All situations can be handled with "shimmed" dissector functions.
- Change-Id: I948935bce660018377a004c661b829a19eb0a53b
- Reviewed-on: https://code.wireshark.org/review/3535
+ Change-Id: Ic85483b32d99d3270b193c9f6b29574d8fad46a8
+ Reviewed-on: https://code.wireshark.org/review/5327
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit ed85bd3
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Aug 10 08:05:44 2014 -0700
+commit 3b8ed36
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Fri Nov 14 17:42:44 2014 +0100
- [Automatic manuf, services and enterprise-numbers update for 2014-08-10]
+ DNS: NAPTR RR Replacement Length is incorrect
- Change-Id: I052b92f415e7ccfb84db47d0d3102d4bdfcfe25c
- Reviewed-on: https://code.wireshark.org/review/3531
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 6bddb0e
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Aug 10 15:25:59 2014 +0200
-
- PIM: fix a copy/paster error introduced in gebff85f
+ It seems the Replacement Length field calculated by Wireshark (which Wireshark calls "rReplacement Length"), is the length of the first label of the DNS name in the Replacement, instead of the entire DNS name length.
- Bug: 10358
- Change-Id: Iddfd5dcd53e80a18cb253834920d9625195b3669
- Reviewed-on: https://code.wireshark.org/review/3529
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 6034a60
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Aug 10 10:43:33 2014 +0200
-
- CredSSP: update ASN.1 source file with the change done in gd2396d2
+ Issue found by Boaz
- Change-Id: I87d0f212f485b9e28fa00101eec9e3c07bc57c67
- Reviewed-on: https://code.wireshark.org/review/3528
+ Bug:10700
+ Change-Id: I8b726f3a3bf316d688a40c3ade100d255ca3be42
+ Reviewed-on: https://code.wireshark.org/review/5300
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit d2396d2
-Author: Eugene Sukhodolin <eugene@sukhodolin.com>
-Date: Sat Aug 9 21:24:09 2014 -0700
+commit 4960171
+Author: Gerald Combs <gerald@zing.org>
+Date: Sat Nov 15 10:36:16 2014 -0800
- The version of the CredSSP protocol can be 2 or 3
+ VoIP calls: Fixup whitespace.
- According to Microsoft documentation, valid values for the Version field are 2 and 3. Newer servers (like Windows 2012 R2) respond with Version=3.
+ Set modelines and reindent to match the files in the top-level ui
+ directory.
- Change-Id: Ifb0c6f52d09c75bbde2b4a46d13366461736b9c0
- Reviewed-on: https://code.wireshark.org/review/3527
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Change-Id: I7ea221e76a4b0ad3b6bcf7a3c8b4645c16aecbba
+ Reviewed-on: https://code.wireshark.org/review/5325
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 2f0278c
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sat Aug 9 21:21:27 2014 +0200
+commit 51c5b7a
+Author: Gerald Combs <gerald@zing.org>
+Date: Sat Nov 15 09:18:06 2014 -0800
- ULP: upgrade to approved version 2.0.2
+ VoIP calls: Start separating common and GTK+-dependent code.
- Change-Id: Icf09e430a1732708ddd9e7abb49f7b1a6225afde
- Reviewed-on: https://code.wireshark.org/review/3526
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit dc748b1
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 3 23:47:42 2014 +0400
-
- Now that Python is mandatory on Windows, remove checks for it from nmakefiles
+ Remove more calls to voip_calls_get_info. Get rid of the global cfile.
+ Lowercase more function names.
- Change-Id: I2ca6abb372ec4bda0af1aa40089082533a61df3a
- Reviewed-on: https://code.wireshark.org/review/3392
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Ieda779779cce9f05e07c54314bceab4a18bae22f
+ Reviewed-on: https://code.wireshark.org/review/5324
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit a4a94af
-Author: Evan Huus <eapache@gmail.com>
-Date: Sat Aug 9 09:33:23 2014 -0400
+commit 7f3f4a5
+Author: Robert Grange <robionekenobi@bluewin.ch>
+Date: Sat Nov 15 11:35:09 2014 +0100
- Fix regression introduced by gf3b631668b
+ paquet-mq: Eliminiate proto_tree_add_text
- I made a stupid when simplifying the bit-twiddling, and accidentally reversed
- two of the bytes which completely broke MAC address name resolution.
+ Eliminate proto_tree_add_text for Expert Info
+ Improve PCF Parameters numeric value display
- Bug: 10344
- Change-Id: I0720755fb290423150e4d84da9d45cb0b76341e4
- Reviewed-on: https://code.wireshark.org/review/3522
+ Change-Id: Ibc259ba05d0591d434e7638d91d6943101d45305
+ Reviewed-on: https://code.wireshark.org/review/5080
+ Reviewed-by: Robert Grange <robionekenobi@bluewin.ch>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit ddeac70
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sat Aug 9 18:18:08 2014 +0200
+commit d550b17
+Author: Gerald Combs <gerald@zing.org>
+Date: Fri Nov 14 18:43:28 2014 -0800
- LTE RRC: fix dissection of CDMA System Time broken in gcd02af5
-
- Also put back initial text indentation
+ VoIP calls: Use our tap offsets.
- Change-Id: I6fe207086018a806a258b1de2888ac0b9310aac6
- Reviewed-on: https://code.wireshark.org/review/3524
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit 020d0f8
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 8 19:50:24 2014 +0200
-
- Qt: Fix when build with Qt < 4.8.0
+ Add convenience functions to convert between tap IDs and tapinfo
+ pointers. Use them to get rid of some calls to voip_calls_get_info().
- StyleName is not available in Qt < 4.8
+ Lowercase function names. Remove more exit()s.
- Change-Id: Icbfcef7c62b124ce67f1a02ed928a96233ae2d9d
- Reviewed-on: https://code.wireshark.org/review/3508
- Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
+ Change-Id: I187fdc505bc22cc05edafed9e97ede8279ea53f9
+ Reviewed-on: https://code.wireshark.org/review/5321
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 6379236
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 8 17:27:53 2014 +0200
+commit 0be9e7d
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Fri Nov 14 19:37:32 2014 -0800
- Qt: Add missing text to translation
+ 0.0 is a double, 0.0f is a float.
- Change-Id: I49d00f73e3e1cf662ead1b01e5d1c0b420c6ccef
- Reviewed-on: https://code.wireshark.org/review/3504
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I882bbda2c579cfd7a1b96ce190541262193405e0
+ Reviewed-on: https://code.wireshark.org/review/5320
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 3035e6e
-Author: MarkPhillips <mark.s.phillips@outlook.com>
-Date: Sat Aug 9 11:03:01 2014 +0100
+commit 3428361
+Author: Gerald Combs <gerald@wireshark.org>
+Date: Fri Nov 14 19:30:42 2014 -0800
- 802.11 BA sequence number decode is broken
+ Fix a pointer type.
- Bug: 10334
- Change-Id: If2da1c5ed63d7e2684a107181d56be38ed921106
- Reviewed-on: https://code.wireshark.org/review/3519
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Change-Id: I5cc67fa320b3241d6793575d59e49160ef40b260
+ Reviewed-on: https://code.wireshark.org/review/5319
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit cd02af5
-Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Aug 8 09:19:29 2014 -0400
+commit 3275ba2
+Author: Gregor Miernik <gregor.miernik@hytec.de>
+Date: Tue Nov 4 11:53:39 2014 +0100
- Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.
+ LLDP: Dissector for Hytec specific extensions added
- This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions.
+ It provides dissection of objects with additional neighbor and link information
+ defined by Hytec (pcap example available on wiki.wireshark.org/HYTEC).
+ Also OUI of "Hytec Geraetebau GmbH" added.
- Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree.
-
- Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141
- Reviewed-on: https://code.wireshark.org/review/3500
+ Change-Id: I92119e46fd5f4c4b385ac3df3170a4766fe056b7
+ Reviewed-on: https://code.wireshark.org/review/5107
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit bb15274
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 18:15:34 2014 -0700
-
- Update symbol lists.
-
- Change-Id: I55ce6396b943ce9376649a9a8973a6e1cadcced7
- Reviewed-on: https://code.wireshark.org/review/3518
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit ebff85f
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 18:09:00 2014 -0700
+commit 1e2a3dc
+Author: Gerald Combs <gerald@wireshark.org>
+Date: Fri Nov 14 13:53:58 2014 -0800
- Clean up Internet checksum handling.
-
- Add macros to set entries of a vec_t, one for use when you have a
- pointer to private data, and one for use when you have data in a tvbuff.
- The latter wraps the use of tvb_get_ptr(), so that you're not directly
- calling it in a dissector.
-
- Move ip_checksum() to epan/in_cksum.c, and add an ip_checksum_tvb() that
- wraps the use of tvb_get_ptr().
-
- In the CARP dissector, give the length variable an unsigned type -
- there's no benefit to it being signed, and that requires some casts to
- be thrown around.
-
- In the DCCP dissector, check only against the coverage length to see if
- we have enough data, combine the "should we check the checksum?" check
- with the "*can* we check the checksum?" check in a single if, and throw
- a dissector assertion if the source network address type isn't IPv4 or
- IPv6.
+ VoIP calls: Clean up tap registration and removal.
- Get rid of inclues of <epan/in_cksum.h> in dissectors that don't use any
- of the Internet checksum routines.
+ Start moving away from a global voip_calls_tapinfo_t. Pass the
+ voip_calls_tapinfo_t struct address to each registration and removal
+ routine.
- In the HIP dissector, make sure we have the data to calculate the
- checksum before doing so.
+ All of the tap registration and removal routines are called at the same
+ time. Replace the individual registration tracking booleans with a
+ central one.
- Change-Id: I2f9674775dbb54c533d33082632809f7d32ec8ae
- Reviewed-on: https://code.wireshark.org/review/3517
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit fe74e31
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Aug 8 23:44:42 2014 +0200
-
- BOFL: fix assertion introduced in g5db1352
-
- Bug: 10356
- Change-Id: Ie3846d6462f212c7fd5162e65e9f83c1524aee36
- Reviewed-on: https://code.wireshark.org/review/3515
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit bbdd34a
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 13:02:46 2014 -0700
-
- Add a tvbuff version of crc6_compute().
+ Calling exit() from the GUI is rude. Don't do that.
- Use it in the MBMS synchronisation protocol dissector, rather than
- calling tvb_get_ptr() there.
-
- Change-Id: I7ddb3c6b30547826cb5372352c7c483d8a24dc8e
- Reviewed-on: https://code.wireshark.org/review/3514
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I9535002e2905a45a8cfc9643590b5d2d360ffc24
+ Reviewed-on: https://code.wireshark.org/review/5318
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 479e288
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 12:51:32 2014 -0700
+commit 62fd2ac
+Author: Michael Mann <mmann78@netscape.net>
+Date: Fri Nov 14 15:18:23 2014 -0500
- The "MPEG-2" CRC-32 is also the ATM CRC-32.
+ Eliminate proto_tree_add_text from some plugin dissector files.
- Use it in the ATM dissector, and use a tvbuff version, so that we don't
- do tvb_get_ptr() ourselves.
-
- Change-Id: I0bd3594bc739e0cca447ac06f34a471441cf2e70
- Reviewed-on: https://code.wireshark.org/review/3513
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: Ib2d900833a8763307be6b1cfc8df20d7019d2706
+ Reviewed-on: https://code.wireshark.org/review/5313
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit cf5f0d3
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 12:20:12 2014 -0700
+commit ba3bc1e
+Author: Gerald Combs <gerald@wireshark.org>
+Date: Fri Nov 14 13:15:38 2014 -0800
- Fix the polynomial for the CCITT CRC.
+ VoIP calls tap ID cleanup.
- And note that it's the same polynomial for the MPEG-2 CRC.
+ Remove all of the public dummy members from voip_calls_tapinfo_t. Use
+ pointer arithmetic to generate private, unique IDs instead.
- Change-Id: Ie89e392156ae77a2adeec3eb8e704aa75c0cd0dc
- Reviewed-on: https://code.wireshark.org/review/3512
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 8b364ea
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Aug 8 11:20:53 2014 -0700
-
- Autodiscover flex and bison in config.nmake.
+ We weren't removing the SUA listener. Do so. Use the correct M3UA ID.
- Change-Id: I4683d0eeb06e5616103f3e6e25ce7f1549a2bb05
- Reviewed-on: https://code.wireshark.org/review/3510
+ Change-Id: I8e8cdb6addbc4868aebc004be20a2f57b4acf75b
+ Reviewed-on: https://code.wireshark.org/review/5315
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 24da9a8
+commit 225c86f
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 11:29:28 2014 -0700
+Date: Fri Nov 14 15:59:38 2014 -0800
- Don't subtract 4 from the length passed to update_crc10_by_bytes_iuup().
+ Do the "-z help" processing separately, and do it for Wireshark as well.
- The length passed to it already has 4 subtracted from it by the caller.
+ Yes, Wireshark does a bunch of GUI stuff, and then takes the window down
+ before printing the help, but the same is true for some command-line
+ error messages as well.
- Change-Id: I6e047c6c4c4cd5220be923b4663088b6b275d768
- Reviewed-on: https://code.wireshark.org/review/3511
+ Change-Id: Id501468416c83308e4c0a9e7a66116d8d33a9d84
+ Reviewed-on: https://code.wireshark.org/review/5317
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 6f104a0
+commit 3554580
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 11:08:35 2014 -0700
+Date: Fri Nov 14 12:29:04 2014 -0800
- Clean up the CRC-10 code.
+ It's not missing, it's passed on.
- Have the wsutil routine just accumulate the stuff from the buffer handed
- to us. Have the IUUP dissector deal with the extra stuff. Add a
- update_crc10_by_bytes_tvb() routine, which is passed a tvbuff, offset,
- and length, and use that rather than using tvb_get_ptr() in dissectors.
-
- Change-Id: Iadd0823c764080e60d1339abb94d2e19150eabfe
- Reviewed-on: https://code.wireshark.org/review/3509
+ Change-Id: Id1b1c7501f357667abb961948afdd816e13a7ad3
+ Reviewed-on: https://code.wireshark.org/review/5314
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 9b9005e
+commit 1b4d51e
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 10:10:36 2014 -0700
+Date: Fri Nov 14 12:24:51 2014 -0800
- The DRM DCP CRC-16 is the same as the X.25 CRC-16.
-
- So just use crc16_x25_ccitt_tvb(), which goes a byte at a time rather
- than a bit at a time, and which takes a tvbuff rather than requiring you
- to call tvb_get_ptr().
+ Update Debian symbol files.
- It also doesn't 1's-complement the result, so we can compare it against the
- 0x1D0F in ETSI TS 102 821 V1.4.1 (2012-10) rather than against a
- 1's-complement version, 0xE2F0.
-
- Change-Id: Ia513f851f0a8ff1e7853278ddf3618c532fb2aba
- Reviewed-on: https://code.wireshark.org/review/3507
+ Change-Id: Iee66cf87d742780740b572b39c8ecf94f93dc142
+ Reviewed-on: https://code.wireshark.org/review/5310
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 57927c8
+commit 99b6afb
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 09:17:58 2014 -0700
+Date: Fri Nov 14 12:21:12 2014 -0800
- Fix compiler warning.
+ Add a name field to tap_param, for use in error messages.
- Change-Id: Idf275d89591558fd2ea082c886ce07e62523807a
- Reviewed-on: https://code.wireshark.org/review/3506
+ Change-Id: Ia4317b61ff30e269eba0ee2ea2c46f1668544b1b
+ Reviewed-on: https://code.wireshark.org/review/5309
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 22ad90c
+commit 04ab731
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 08:57:31 2014 -0700
+Date: Fri Nov 14 12:05:31 2014 -0800
- Add routines for CRC-16 with a polynomial of 0x3D65.
+ The registered -z parameter string shouldn't end with a comma.
- There are routines that take a buffer and a length and that take a
- tvbuff, offset, and length; use those routines in the DNP dissector
- (which no longer needs its own table and loop), and use the tvbuff
- routine instead of calling tvb_get_ptr().
+ If it ends with a comma, then, if you don't provide any parameters, you
+ get a "no such -z statistic" message followed by a list of available
+ statistics.
- Change-Id: Ic67b0f3b65b94ea47c0fdc2f3d3b6f88df77f9c6
- Reviewed-on: https://code.wireshark.org/review/3505
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 8da72cd
-Author: Dom Gifford <Dominic.Gifford@atmel.com>
-Date: Thu Jul 24 15:32:55 2014 +0100
-
- Fix support for decrypting 802.11 broadcast messages.
-
- A little bit of guess work is involved as the group key can use a
- different cipher to the pairwise key, and we are trying to do this
- purely based on the EAPOL messages with no prior knowledge of the
- associate request. We try to guess the cipher based on the lengths.
-
- Bug:8734
- Change-Id: I4c456b45939c00a9d1122406891f704fa037349c
- Reviewed-on: https://code.wireshark.org/review/3183
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 345a1d2
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 8 08:35:41 2014 +0200
-
- ISIS: Fix reachability IPv4 Interface/Neighbor (wrong length)
-
- Change-Id: I8903a097a59bf9bf1ec62b59e57cdc60e382bdb5
- Reviewed-on: https://code.wireshark.org/review/3490
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 143cdf1
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 6 22:22:17 2014 +0200
-
- ISIS: Add type and length to CLV
-
- Change-Id: If6dc8e3a9328571ccdb106b0aabc617889c434c7
- Reviewed-on: https://code.wireshark.org/review/3465
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 6fd6955
-Author: Stig Bjørlykke <stig@bjorlykke.org>
-Date: Fri Aug 8 10:06:55 2014 +0200
-
- The -k flag has been removed from Makefile.common
-
- Change-Id: Ib7399c4b5457c5810df3ce2160a56813785b11ec
- Reviewed-on: https://code.wireshark.org/review/3498
- Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
- Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
- Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
-
-commit aa6400a
-Author: Stig Bjørlykke <stig@bjorlykke.org>
-Date: Fri Aug 8 10:35:34 2014 +0200
-
- Sync t125 from asn1.
-
- This adds "Remove unused hf entries" from Anders.
-
- Change-Id: I1150f34f0eafab03415339d4b34f5f2e7f69f85b
- Reviewed-on: https://code.wireshark.org/review/3499
- Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
- Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
-
-commit 735263e
-Author: Michał Orynicz <michal.orynicz@tieto.com>
-Date: Fri Aug 8 09:06:38 2014 +0200
-
- Logcat text: small fixes
-
- * fix exporting "beginning of" frame logs into info field
- * add missing "Failure" level to regexp in wiretap part
- * remove usage of GDateTime from wiretap part
-
- Change-Id: Ibdea730623241cccbbc1694a34daa308e48c0a89
- Reviewed-on: https://code.wireshark.org/review/3493
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-
-commit ad4d672
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 01:05:47 2014 -0700
-
- Add a CRC32_ACCUMULATE() macro for a single CRC-32 step and use it.
+ If it doesn't end with a comma, then, if you don't provide any
+ parameters *and* a parameter is required, you get a usage message, which
+ is more useful - and, in many of those cases, a parameter *isn't*
+ required.
- Change-Id: I9462d45c5db6d54c0ee695046cb72be1acf379e8
- Reviewed-on: https://code.wireshark.org/review/3497
+ Change-Id: I81275ea41ad4611d8210ca3cb07c09f0abde58f2
+ Reviewed-on: https://code.wireshark.org/review/5308
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 4a30cfd
+commit 4729e13
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 00:47:11 2014 -0700
+Date: Fri Nov 14 11:25:04 2014 -0800
- Use crc32_ccitt_tvb_offset_seed().
+ Add an optional flag and a type for UUID parameters for stat taps.
- One fewer tvb_get_ptr() call. Yay!
+ For future use, with common code to parse the -z argument.
- Change-Id: I08ac4888d696f0b6b6a17e9e22f3dfec5aedad59
- Reviewed-on: https://code.wireshark.org/review/3496
+ Change-Id: Ib2a11bd5c91b5ac48ced2cd2d112b97c301ff72a
+ Reviewed-on: https://code.wireshark.org/review/5307
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit d3832d7
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 00:36:12 2014 -0700
+commit 42c6e57
+Author: Stephen Fisher <sfisher@sdf.org>
+Date: Fri Nov 14 12:17:36 2014 -0700
- Get rid of no-longer-used variable.
+ Update my e-mail address again.
- Change-Id: I63bde706a6561c834aab9b10975dbb242c65d998
- Reviewed-on: https://code.wireshark.org/review/3495
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I0083bbf84658dbb0d4cef91e9e8f5855b8a2ba4f
+ Reviewed-on: https://code.wireshark.org/review/5306
+ Reviewed-by: Stephen Fisher <sfisher@sdf.org>
-commit 6495ab4
+commit c3582a6
Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 00:20:19 2014 -0700
+Date: Fri Nov 14 10:55:50 2014 -0800
- Get rid of no-longer-used variable.
+ There's nothing GTK+ about TShark.
- Change-Id: I64d1177b9a424ede9d1f687843e38bd37723c137
- Reviewed-on: https://code.wireshark.org/review/3494
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 7431229
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Fri Aug 8 00:19:07 2014 -0700
-
- Fix indentation.
+ Remove gtk from routine names in CLI taps.
- Change-Id: I4342ec7723c43f8e12d6187609a1493a61725d31
- Reviewed-on: https://code.wireshark.org/review/3492
+ Change-Id: I0846da9b1e8119ed966b441cb1ca0ce1820fd1c8
+ Reviewed-on: https://code.wireshark.org/review/5305
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 39d919b
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 8 09:01:37 2014 +0200
-
- Qt: Make buildbot happy
-
- capture_interfaces_dialog.cpp: In member function ‘void CaptureInterfacesDialog::updateStatistics()’:
- capture_interfaces_dialog.cpp:483:100: error: operation on ‘points’ may be undefined [-Werror=sequence-point]
- QList<int> *points = points = ti->data(col_traffic_, Qt::UserRole).value<QList<int> *>();
-
- Change-Id: I63afb0f207142d516403968f6a3e988f8ad61d4d
- Reviewed-on: https://code.wireshark.org/review/3491
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit b8a6cfc
-Author: Роман Донченко <dpb@corrigendum.ru>
-Date: Sun Aug 3 03:21:31 2014 +0400
-
- Make Python mandatory to build on Windows
-
- While nominally optional, building without it doesn't work, so just make it
- mandatory.
-
- The verify_tools target already passes $(PYTHON) to win-setup.sh --appverify;
- we just need to supply a default value for PYTHON, so that $(PYTHON) doesn't
- expand to an empty string. It's also convenient for the developer if Python
- can be automatically found on the PATH.
-
- Change-Id: I4f54695625b74c5b4c758ef1e3bc9ed4467db514
- Reviewed-on: https://code.wireshark.org/review/3391
- Petri-Dish: Jörg Mayer <jmayer@loplof.de>
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
- Tested-by: Jörg Mayer <jmayer@loplof.de>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 4da7570
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Wed Aug 6 14:50:48 2014 -0700
-
- Use a QTreeWidget instead of QTableWidget.
-
- Even though Qt's widget naming suggests otherwise, a QTreeWidget is
- usually a better choice for tables than QTableWidget. The former gives
- you a nice, clean Plain Old Table while the latter gives you something
- that looks and acts like a spreadsheet.
-
- In this particular instance using QTreeWidget also gives us the option
- of adding sub-items with detailed information. Do so for attached
- addresses.
-
- Allow sorting by traffic while we're here. Simplify the column hiding
- logic. Make sure the sparkline delegate isn't editable.
-
- Change-Id: Ia36ba2e12c1c0cb86ae5b2154e6afcf6549ae049
- Reviewed-on: https://code.wireshark.org/review/3466
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
- Tested-by: Gerald Combs <gerald@wireshark.org>
- Petri-Dish: Gerald Combs <gerald@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 40d5c50
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Aug 8 00:02:16 2014 +0200
-
- Logcat Text: drop use of GDateTime
-
- It's only available from GLib 2.26 while we only require 2.16
-
- Change-Id: I3c2e6748aa93b9af7158f5051433baff6a7c0324
- Reviewed-on: https://code.wireshark.org/review/3480
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 4b78ead
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Fri Aug 8 00:31:09 2014 +0200
+commit 4d3c4c4
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Fri Nov 14 10:51:40 2014 -0800
- Logcat Text: fix assert when dissecting PID or TID
+ Rename stat_cmd_args.[ch] to stat_tap_ui.[ch].
- Per Android documentation, the PID and TID are int
+ The intent is to handle more than just command-line arguments; reflect that.
- Change-Id: I05326d134047315d61a873c33dd02a48d1849f8d
- Reviewed-on: https://code.wireshark.org/review/3481
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Ia10efda85a9d11c6579d1bec6f789cee30d9e825
+ Reviewed-on: https://code.wireshark.org/review/5304
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit a22b707
-Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Aug 7 08:36:30 2014 -0400
+commit 0dae81b
+Author: Irene Ruengeler <ruengeler@wireshark.org>
+Date: Fri Nov 14 10:06:51 2014 +0100
- Eliminate proto_tree_add_text from some dissectors.
+ Allow SCTP graphs to resize with the window they're in.
- Change-Id: I6f1710a093fc548c718defa9b40ab68877ede977
- Reviewed-on: https://code.wireshark.org/review/3470
- Reviewed-by: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Bug: 10698
+ Change-Id: I3304bd36945619aeb405c74917f21de3faa3fcbb
+ Reviewed-on: https://code.wireshark.org/review/5284
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 532a98d
+commit a21436e
Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Aug 7 20:56:22 2014 -0700
+Date: Fri Nov 14 10:42:26 2014 -0800
- Wrap tvb_get_ptr() calls in the CRC routines.
+ tap_ui -> stat_tap_ui.
- That doesn't eliminate them, but at least it encapsulates them.
+ The old routine had stat_ in the name, as the expectation was that they
+ were for statistics taps; that's still the expectation, so have stat_ in
+ the data structure and routine names.
- Change-Id: I78f0202cb7d2eb86e2dce220b2b97acc256d1e42
- Reviewed-on: https://code.wireshark.org/review/3489
+ Change-Id: Ic98d011012b8641173d41fa0ec4f4e625614370a
+ Reviewed-on: https://code.wireshark.org/review/5303
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 20c0fff
+commit 0e64efc
Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Aug 7 20:38:11 2014 -0700
+Date: Fri Nov 14 10:35:42 2014 -0800
- Wrap some tvb_get_ptr calls in crc32c_tvb_offset_calculate().
+ Use G_GUINT64_FORMAT to format a guint64.
- This eliminates some tvb_get_ptr calls from dissectors, as part of
- trying to minimize if not eliminate its use in dissectors (it's a bit of
- what's called an "attractive nuisance", in that users who don't
- understand what it does - and doesn't! - do may use it in ways that are
- unsafe, e.g. thinking you can use it to get a null-terminated string
- from a packet).
+ A 64-bit integer isn't necessarily a long, it might be a long long. Use
+ G_GUINT64_FORMAT to format it.
- It also eliminates the possibility of passing one length to
- tvb_get_ptr() and another to crc32c_calculate().
+ Make it a guint64 while we're at it - the field is a FT_GUINT64.
- Change-Id: I8a07168d0bc088b45d607e00c5bb1d98421ebc73
- Reviewed-on: https://code.wireshark.org/review/3488
+ Change-Id: I7ee855905ea77347576005441824b1c4630f5659
+ Reviewed-on: https://code.wireshark.org/review/5302
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit c10396d
-Author: Evan Huus <eapache@gmail.com>
-Date: Thu Aug 7 20:25:34 2014 -0400
-
- Fix read-past-end-of-buffer in CUPS dissector
-
- Even when the protocol specifies that a string ends in a null-terminator, there
- are packets which won't. Therefore:
-
- **the result of tvb_get_ptr SHALL NOT be treated as a null-terminated string**
-
- We need to post that in big neon lettering somewhere obvious.
-
- Bug: 10353
- Change-Id: Ie30cd13353a9830311e573e734dd89dc07622c98
- Reviewed-on: https://code.wireshark.org/review/3485
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit dea377b
+commit 7390516
Author: Guy Harris <guy@alum.mit.edu>
-Date: Thu Aug 7 17:07:46 2014 -0700
+Date: Fri Nov 14 10:31:04 2014 -0800
- Put setargv.obj back in the list of objects for mergecap.
-
- This should enable automatic wildcard expansion and fix bug 10354.
+ For tap UIs, register a list of parameters and some menu information.
- Add the usual setargv.obj comment for reordercap, which also links with
- setargv.obj.
+ The intent here is to centralize more UI information so that we can move
+ more tap UI stuff to common code. This is a beginning.
- Change-Id: I2ceee700ae274713bf7a6d5fae0d523e9feca481
- Fixes-Bug: 10354
- Reviewed-on: https://code.wireshark.org/review/3483
+ Change-Id: Ic35ac0c01bc7b942aab88177db4065847a5e6c30
+ Reviewed-on: https://code.wireshark.org/review/5301
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 8a34884
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Aug 7 16:56:17 2014 -0700
+commit 09f0d2c
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Wed Nov 12 23:38:40 2014 -0500
- Update the Developer's Guide for Chocolatey's Win flex-bison.
+ hiqnet: Improve dissection for hiqnet over TCP or UDP
- Change-Id: Id86a00b521e112e445856251f0c242fbb7a2573b
- Reviewed-on: https://code.wireshark.org/review/3482
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 714fa85
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Thu Aug 7 14:07:16 2014 -0700
-
- Win flex-bison and Chocolatey updates.
+ -- Use tcp_dissect_pdus() for hiqnet over tcp so as to properly
+ handle hiqnet PDUS is a TCP stream of data;
- Chocolatey's latest winflexbison package is usable. Update
- config.nmake, FindLEX.cmake, and FindYACC.cmake accordingly. Rename
- CHOCOLATEY_INSTALL_PATH to CHOCOLATEY_BIN_PATH since that's what we're
- finding.
+ -- Handle possible multiple hiqnet PDUs in a UDP payload.
- Change-Id: I39973fba0531b3f7a1315ca010a8bd70581db3fb
- Reviewed-on: https://code.wireshark.org/review/3479
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 1dc88ed
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Thu Aug 7 22:55:21 2014 +0200
-
- Add back a comment lost in 8b2a8a9636d090
+ -- Add Fixme: re multiple hiqnet PDUs in a frame.
- Change-Id: I7bdd4767bdffdc23b964898085a216f6ef7c8aff
- Reviewed-on: https://code.wireshark.org/review/3474
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
+ Change-Id: I3527c6ea13571d16bcf23dd3771d0a89734a7c5a
+ Reviewed-on: https://code.wireshark.org/review/5267
+ Reviewed-by: Raphaël Doursenaud <rdoursenaud@free.fr>
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit e44e407
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Thu Aug 7 17:41:39 2014 +0200
+commit a55d18e
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Wed Nov 12 22:04:37 2014 -0500
- Change the application Ids to avoid duplicates.
+ hiqnet: Simplify code somewhat; Adjust the "names" and display of certain fields.
- Change-Id: I127ac215b0b8ed1615e4d11c9a5a5952e3ea8d88
- Reviewed-on: https://code.wireshark.org/review/3473
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 35453cf
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 4 19:09:10 2014 +0200
-
- HTTP: Fix indent (use tab)
+ Specifically: Use proto_tree_add_bitmask() to show the "flags" and
+ "categories" bitfields (instead of building the fields
+ display "by hand").
+ The bitfield display changed as follows:
+ - A bitfield with all bits=0 will have a detailed
+ dissection tree; (for both 'flags' & 'categories');
+ - The 'categories' individual bitfields are now
+ displayed as FT_BOOLEAN (not FT_UINT32).
- Change-Id: I4056d8b876f71c1f9ce4804a4dc4b0d16ab5afda
- Reviewed-on: https://code.wireshark.org/review/3409
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Icd35698aae492b81b340d08030e6a1563f1640ae
+ Reviewed-on: https://code.wireshark.org/review/5266
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 5b5d9a8
+commit 9a1df71
Author: AndersBroman <anders.broman@ericsson.com>
-Date: Thu Aug 7 15:30:24 2014 +0200
+Date: Fri Nov 14 15:39:45 2014 +0100
- Add two new true_fals strings.
+ [S1AP) Wrong tree used
+ s1ap.cnf:547:14: error: variable 'subtree' set but not used
- Change-Id: I43440ef6fac1a0c01eec630d2238fcfb085255a5
- Reviewed-on: https://code.wireshark.org/review/3471
+ Change-Id: I84a345709b1ef9688f3f1a4e876a75dd575c1c2e
+ Reviewed-on: https://code.wireshark.org/review/5299
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit ccbe5fd
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Wed Aug 6 19:50:06 2014 +0200
+commit 56fa29e
+Author: AndersBroman <anders.broman@ericsson.com>
+Date: Fri Nov 14 14:53:02 2014 +0100
- MIPv6: fix dissection of Service Selection Identifier
+ [S1AP] Let the A21 dissector do further dissection of Cdma2000SectorID
- APN field is not encoded as a dotted string so the first character is not a length
-
- Bug: 10323
- Change-Id: Ia62137c785d505e9d0f1536a333b421a85480741
- Reviewed-on: https://code.wireshark.org/review/3461
- Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Change-Id: I8c503acf6860b34d24769cdf981dcaeea4667ffb
+ Reviewed-on: https://code.wireshark.org/review/5298
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 378e8b7
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Wed Aug 6 17:59:16 2014 +0200
-
- we're matching against {any}/port_b, not address_b
-
- Change-Id: Ief00f09225805c6c7488d92f8aa5b59c21575788
- Reviewed-on: https://code.wireshark.org/review/3464
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 083006b6
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Thu Jul 31 23:15:38 2014 +0200
-
- when a linux USB isochronous descriptor is selected,
- highlight its data part as well
-
- Change-Id: Ia69ac6b1460245ffa44b6ad3b17f07948baf03d4
- Reviewed-on: https://code.wireshark.org/review/3463
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit 7bf2f2e
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Aug 4 19:08:05 2014 -0400
-
- Support building the NEWS file in out-of-source-tree builds.
-
- Copy the built file into the source directory (since it's generated but checked
- in). Don't fail to build, though, if we can't do that copy.
-
- Change-Id: Ia94a19b6f813ee78b191cd09d51198462f95b223
- Reviewed-on: https://code.wireshark.org/review/3425
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 2c79761
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 6 17:12:05 2014 +0000
-
- Revert "Add a cmake build to distcheck to ensure that we distribute all the files necessary to do a cmake build."
-
- We can't know, in autofoo, what arguments are necessary to make 'cmake' actually run successfully on a given system. We should probably just add a buildbot step to build cmake from the source tarball.
-
- This reverts commit 70a6d204a7f0b4039ee986cd6557cd7242e5ff0c.
-
- Change-Id: I1961b79ece2e26bafad3eddb189bd0cfab2af846
- Reviewed-on: https://code.wireshark.org/review/3460
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit 2c59a6d
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Wed Aug 6 17:10:57 2014 +0000
-
- Revert "When doing the distcheck cmake check only verify that cmake runs, don't verify that it can build Wireshark."
-
- This change doesn't help: we can't get cmake to run properly.
-
- This reverts commit 956f4423df447f2e7c0f9691ba9928f104d79820.
-
- Change-Id: If1c0ec13ff35fdaa266dcd491350477e2bd91bd1
- Reviewed-on: https://code.wireshark.org/review/3459
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit d55e1b5
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Tue Aug 5 17:23:41 2014 +0200
+commit d6f2392
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Fri Nov 14 13:39:29 2014 +0100
- NSIS: Fix multiple issues.
-
- Restore the "!include qt-dll-manifest.nsh" clobbered by ga722f83 and
- which resulted in missing DLL warnings (e.g. QT5PrintSupport.dll).
+ Fix declaration in btavrcp
- Fix overly aggressive search+replace in wireshark.nsi which broke the
- WinPcap installation page and GTK+ selection. Try to finish the work on
- promoting Qt started in ga722f83.
-
- Bug: 10349
- Change-Id: I7086be7c5272f4ae1b2cc26bbd5d5b725f013573
- Reviewed-on: https://code.wireshark.org/review/3428
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
+ Change-Id: I47e4ad2baa7ca4c48e8c0eea472e568fc06d3386
+ Reviewed-on: https://code.wireshark.org/review/5297
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit 892703f
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Aug 6 15:26:20 2014 +0200
+commit d7cc141
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Wed Nov 12 12:00:46 2014 +0100
- The heuristic for T.125 per is too week and we do not have a PER dissector
- for T.125 so remove the test.
- Remove unused hf entries.
- Fixes bug 10350.
+ Bluetooth: Ubertooth: Update to the latest firmware
- Change-Id: If28de7877388c669082f8c8a21dd63107d417fbf
- Reviewed-on: https://code.wireshark.org/review/3458
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 53b2096
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Wed Aug 6 09:07:02 2014 +0200
-
- Add Modelines and fix indent
+ Changelog:
+ - add some assign numbers
+ - implement new type of usb_rx_packet: LE_PROMISC
- Change-Id: I7abb415bccff4de846ab273eed3e3b2a434d94b7
- Reviewed-on: https://code.wireshark.org/review/3455
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Iffe01a50f873221c695f16a76c1954d6c82d73df
+ Reviewed-on: https://code.wireshark.org/review/5289
+ Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
+ Reviewed-by: Michal Orynicz <michal.orynicz@tieto.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 530f70f
+commit 9952e7c
Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Aug 6 12:42:52 2014 +0200
+Date: Fri Nov 14 12:54:33 2014 +0100
- Try to fix:
- packet-mq.c:3653: warning: declaration of 'tree' shadows a parameter
+ [BSSMAP] Handle vendor specific encoding of "Layer 3 Message Contents".
- Change-Id: I1226dac3764b15a097378aed7696567b9224f4c4
- Reviewed-on: https://code.wireshark.org/review/3457
+ Change-Id: I351bc0a6a8ae636b2f888a80f61e526096a61b64
+ Reviewed-on: https://code.wireshark.org/review/5295
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit d67e40e
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Fri Aug 1 10:23:28 2014 -0700
+commit e83c7f0
+Author: Pascal Quantin <pascal.quantin@gmail.com>
+Date: Fri Nov 14 10:07:52 2014 +0100
- Added dissection of Device Capability Descriptors in CapResp Packets
-
- CapResp Packets may contain Device Capability Descriptors.
- This patch allows wireshark to show what descriptors are present,
- & checks that their length fields are valid.
+ NAS EPS: fix dissection of APN AMBR IE when first byte is set to 0xFE
- See section 6.3.3 of the MA USB spec for more information.
-
- Change-Id: Ia120435bdffcced091b67e66e0ba8f1a750358db
- Reviewed-on: https://code.wireshark.org/review/3330
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Bug: 10699
+ Change-Id: I0f359639d5836f557370ab6d6aad45faa4417b6e
+ Reviewed-on: https://code.wireshark.org/review/5285
+ Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
+ Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
-commit febbe12
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Wed Aug 6 10:29:10 2014 +0200
+commit f172791
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Sun Nov 2 18:55:40 2014 +0100
- Add casts to make logcat-text build on Win64
+ Translations: Update Polish translation
- Change-Id: I38d65a06b925653e22a59a4a4cd0a53a87072b49
- Reviewed-on: https://code.wireshark.org/review/3456
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 09357c1
-Author: robionekenobi <robionekenobi@bluewin.ch>
-Date: Sun Aug 3 21:49:29 2014 +0200
-
- mq improvements:
+ All messages are translated now.
- - handle RFH structure
- - use tvb_reported_length...,
- - Add Conversation/Request in row display
+ Tłumaczenie Wiresharka jest teraz kompletne. Zachęcam do testowania
+ i wytykania błędów.
- Change-Id: I84c5cf3e9479d91b363eb093e71bb6bdf07e8194
- Reviewed-on: https://code.wireshark.org/review/3354
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Iaffb2e581c765b5b3dff7750f878e6391539ebd6
+ Reviewed-on: https://code.wireshark.org/review/5293
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 1a02ca0
-Author: Michał Orynicz <michal.orynicz@tieto.com>
-Date: Wed May 14 09:45:23 2014 +0200
+commit f1dee59
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Wed Nov 12 11:57:12 2014 +0100
- Add support for android logcat text files
-
- Wireshark already supports reading and writing logcat
- logs saved in binary files. Binary format, although
- better, is used less often than saving those logs to
- text files.
+ Bluetooth: A2DP: Add AVRCP song position indicator
- This patch extends wireshark's support for android logcat
- logs to reading and writing logcat logs in text files.
+ "sbc.avrcp_song_position" can be used to determine time synchronization
+ between AVRCP and A2DP. It is updated on every
+ AVRCP PlaybackPositionChanged. Also provide version for aptx.
- Features:
- * support for tag, brief, process, thread, time, threadtime
- and long formats
- * saving in original format
- * it's generally awesome
-
- Change-Id: I013d6ac2da876d9a2b39b740219eb398d03830f6
- Reviewed-on: https://code.wireshark.org/review/1802
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I48cd49f0fee54131a738290e2a70a24d33ba1d22
+ Reviewed-on: https://code.wireshark.org/review/5290
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 71d07bc
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Aug 2 10:23:52 2014 +0200
+commit ad1977b
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Thu Nov 13 10:52:16 2014 +0100
- MySQL: Add support of SSL in MySQL
+ Qt: Fix non-translate-able text
- Launch SSL dissector when MySQL switch to SSL
-
- Ping-Bug:9515
- Bug:10338
- Change-Id: I96487d6d2131db3678f4a24095d702b6cd4ea5b2
- Reviewed-on: https://code.wireshark.org/review/3411
- Reviewed-by: Daniël van Eeden <wireshark@myname.nl>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I8c2376117ca1ac92c341ba938929af2d13e23f72
+ Reviewed-on: https://code.wireshark.org/review/5291
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 91b2adf
-Author: Daniël van Eeden <wireshark@myname.nl>
-Date: Tue Aug 5 21:43:30 2014 +0200
+commit 6d678ff
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Thu Nov 13 19:42:36 2014 +0100
- MySQL: add utf8mb4 charsets
+ Qt: Fix typo
- Change-Id: I7dfda411ed1d91e9eea43a1eb0cbc70807fedfbb
- Reviewed-on: https://code.wireshark.org/review/3451
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: Idc2b945ac3bd5de961cc9c581398dc12f6831070
+ Reviewed-on: https://code.wireshark.org/review/5292
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 2dcec4e
-Author: Daniël van Eeden <wireshark@myname.nl>
-Date: Tue Aug 5 21:29:08 2014 +0200
+commit 38218df
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Fri Nov 7 15:41:29 2014 +0100
- MySQL: decode pwd and charset for COM_CHANGE_USER
+ Bluetooth: AVRCP: Improve command/response trancing
- This fixes decoding of authetication data in MySQL 5.6+
- It also decodes the charset.
-
- Bug: 10351
- Change-Id: Ic76961e94d2e3bf15bc72e279128a5251acfd749
- Reviewed-on: https://code.wireshark.org/review/3441
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 657d5f9
-Author: Joerg Mayer <jmayer@loplof.de>
-Date: Tue Aug 5 23:51:16 2014 +0200
-
- - Fix the whitespace fix
- - Also, trying to commit this "properly" gave this message:
- Error: Found prohibited APIs in dumpcap.c: strncpy,htons,strerror,open
- How does this happen? Why does gerrit accept this stuff in case a
- user does not have the (current) hooks installed?
+ Make command/response tracking field filterable and jumpable.
- Change-Id: I692d053dcd9221aee31ed2780170c0671b856264
- Reviewed-on: https://code.wireshark.org/review/3454
- Reviewed-by: Jörg Mayer <jmayer@loplof.de>
+ Change-Id: Ib0dfc9ea9954f8d29d06ceda3d44a7f95c94bc53
+ Reviewed-on: https://code.wireshark.org/review/5288
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit f3dd7fe
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Aug 5 16:10:44 2014 -0400
+commit 5a46f26
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Fri Nov 7 10:47:33 2014 +0100
- Fix whitespace/indentation to match editor modelines.
+ Bluetooth: AVRCP: Fix swappend SongPosition and SongLength
- Change-Id: I3445ae22f10584582d465bf632942e016f5f70ca
- Reviewed-on: https://code.wireshark.org/review/3452
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit dfe331e
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 5 21:09:54 2014 +0200
-
- we may set a TFTP port via Decode As
- take this setting into account when we try to detect the first packet of
- a tftp transfer
+ SongPosition and SongLength are swapped in Info column. Fix it.
- Change-Id: Ia80f9b5f994b02ecaaa063308b1a87d00fe0dafe
- Reviewed-on: https://code.wireshark.org/review/3450
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: I4c9bece51dbfe62885e8426a8aef07f336670099
+ Reviewed-on: https://code.wireshark.org/review/5287
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit 7f030bb
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 5 20:59:29 2014 +0200
+commit 6e44997
+Author: Michal Labedzki <michal.labedzki@tieto.com>
+Date: Mon Nov 3 10:14:28 2014 +0100
- we either have a source or a destination file name
- when we set one, we clear the other
+ Bluetooth: AVDTP: Add possibility to force decode as APT-X
- Change-Id: I7c316dc9cc7b2c93cfa1b00eb617553f55a58715
- Reviewed-on: https://code.wireshark.org/review/3449
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: Id99647846c9bc7666f33938c811358576353390d
+ Reviewed-on: https://code.wireshark.org/review/5286
+ Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
-commit ad20fd6
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 5 11:04:08 2014 +0200
+commit 2986388
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Wed Nov 12 16:40:02 2014 +0100
- delete the port range before re-creating it
+ dtd_preparse : fix indent (Use tabs)
- Change-Id: I80f7e438cbb44c40ee28f1eb78a7779f43563732
- Reviewed-on: https://code.wireshark.org/review/3448
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: Iec6ef7109ccea8a164db4f62af9fae1dceba6ae6
+ Reviewed-on: https://code.wireshark.org/review/5282
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit cbb68ba
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 5 10:33:37 2014 +0200
+commit 2788df9
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Wed Nov 12 17:10:40 2014 +0100
- if the original packet already contains a file name,
- don't add a generated tree item with the filename stored in the
- conversation
+ Gtk Utils: fix unknown command tag name 'parm'; did you mean 'param'? (-Wdocumentation)
- Change-Id: Ia9a7fe712d0dd8241399e456509019b8e3902554
- Reviewed-on: https://code.wireshark.org/review/3447
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Change-Id: I89f242bf916d22e0a4a665696ec3fe5ee02b8a1f
+ Reviewed-on: https://code.wireshark.org/review/5283
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit d60ce0b
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 5 10:29:24 2014 +0200
+commit 6e535a8
+Author: Michael Mann <mmann78@netscape.net>
+Date: Thu Nov 13 20:37:46 2014 -0500
- no need for if(tree)
- display the opcode first, followed by the file name
+ Multipath TCP checksum requires M flag set as well as enough option length.
- Change-Id: Ic5dd7409414d2f748c326c59a4b850dc2244da1f
- Reviewed-on: https://code.wireshark.org/review/3446
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Bug: 10692
+ Change-Id: I8d9874a2c0a6b98497d43804bcf27a8c7e152a9b
+ Reviewed-on: https://code.wireshark.org/review/5275
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit c5ca59f
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 5 10:21:32 2014 +0200
+commit 4a7dd62
+Author: Michael Mann <mmann78@netscape.net>
+Date: Thu Nov 13 22:38:54 2014 -0500
- delete unnecessary return;
+ Always create a subtree for Mobility options, even if it doesn't have a specific dissection function.
- Change-Id: Ia91d51acd7dedd18ba5d0a73bc353b2d198474c7
- Reviewed-on: https://code.wireshark.org/review/3445
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
+ Bug: 10618
+ Change-Id: Ic4d52485a6bd96f906b4a0d61b75a31bfad4e8f8
+ Reviewed-on: https://code.wireshark.org/review/5276
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 956f442
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 5 12:17:23 2014 -0400
+commit c2e090f
+Author: Ryan Doyle <ryan@doylenet.net>
+Date: Wed Nov 12 20:36:49 2014 +1100
- When doing the distcheck cmake check only verify that cmake runs, don't verify
- that it can build Wireshark.
-
- The purpose of the cmake check is to ensure we are distributing all the of
- necessary cmake files. We don't want to get into the business of giving cmake
- all the options required to actually build Wireshark (e.g., which version of
- Qt is installed and where).
+ Dissector for elasticsearch protocol
- This also means that distcheck doesn't compile Wireshark twice.
+ Provides dissection for the elasticsearch protocol. This includes full
+ dissection of the multicast discovery protocol, the HTTP query interface
+ and partial dissection of the binary protocol.
- Change-Id: I62f5c42df7c710f7695bd020b0dda80e54435829
- Reviewed-on: https://code.wireshark.org/review/3432
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I738fb498976e44fa05168c2bc3a7e842a9e96df9
+ Reviewed-on: https://code.wireshark.org/review/4948
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 81134a8
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Tue Aug 5 21:39:51 2014 +0200
+commit 4cc4315
+Author: Sven Eckelmann <sven@open-mesh.com>
+Date: Wed Oct 1 18:26:12 2014 +0200
- fix a warning with gcc 4.7.2 on linux
+ batadv: Add dissector support for batadv v15
- packet-isakmp.c: In function 'dissect_isakmp':
- packet-isakmp.c:1873:6: error: 'ivd' may be used uninitialized in this function [-Werror=maybe-uninitialized]
- packet-isakmp.c:1747:14: note: 'ivd' was declared here
- cc1: all warnings being treated as errors
+ The packet format for batman-adv v15 supports:
- (not sure why the compiler complains here)
+ * Complete reordered packet type ids
+ * reordered flags
+ * type-version-length-value data containers
+ * new types for coding packets and unicast transfer of TVLVs
+ * dropped packet types for vis, translation table query and roaming
+ * reordered packet formats
+ * transparent fragmentation of batadv packets
- Change-Id: I9b9589d3193b0dc37f2db8f6c4c6727b2a92eaaa
- Reviewed-on: https://code.wireshark.org/review/3444
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit b76e0f7
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Tue Aug 5 15:31:55 2014 -0400
-
- Fix some dates in the changelog; add some recent changes to the changelog.
-
- Apparently rpmbuild now verifies the dates (including the day of the week)
- you entered.
-
- Change-Id: I1c67fb3170de3199b5fe5f8c117eaefb4d4d28c7
- Reviewed-on: https://code.wireshark.org/review/3442
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Change-Id: I9e6733f9dd6b54eeecda19cf570599161d28b46e
+ Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
+ Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
+ Reviewed-on: https://code.wireshark.org/review/5175
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 72c2a33
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Aug 5 14:54:55 2014 -0400
+commit 9cc9028
+Author: Lukas Emersberger <lukas.emersberger@br-automation.com>
+Date: Fri Oct 17 14:13:06 2014 +0200
- Do various minor dissector changes:
+ epl: Duplicated Frames
- - remove unneeded initializers;
- - replace tabs in files with editor mode line 'expandtabs';
- - col_set_str() --> col_add_str() (in one case);
- - tvb_length() -- > tvb_reported_length() (in one case);
- - do some whitespace & indentation fixes/changes.
+ Remake of the duplicated frames filter with
+ less memory usage.
- Change-Id: Ib8ffbbcdb6e4a74c0df6021a75430ae1ef9ae089
- Reviewed-on: https://code.wireshark.org/review/3435
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Change-Id: I7c8694b5ae69c919b866bbc661bad5e3f0a3e1d7
+ Reviewed-on: https://code.wireshark.org/review/4773
+ Reviewed-by: Roland Knall <rknall@gmail.com>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Lukas Emersberger <lukas.emersberger@gmail.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 9dc3324
-Author: Bill Meier <wmeier@newsguy.com>
-Date: Tue Aug 5 12:35:36 2014 -0400
+commit ab7f35d
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Thu Nov 13 00:43:17 2014 -0800
- Various minor dissector fixes/changes
+ hf_cc_loss is supposed to be a floating-point value, divided by 65535.
- - Fix a few minor bugs;
- - Remove unneeded #includes;
- - Do some whitespace/long_lines formatting changes.
+ That's what the code did when it used proto_tree_add_text(); make it do
+ so now. That squelches a run-time error.
- Change-Id: I97239fa20727498604682239cda0e1b87b10f4bc
- Reviewed-on: https://code.wireshark.org/review/3434
- Petri-Dish: Bill Meier <wmeier@newsguy.com>
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit 79c55a3
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 5 15:22:14 2014 +0200
-
- Fix Bug #10348 Different dissection results for same file.
- The fault is that reassembly_table_init() must be called when reloading
- the file - move it to an init routine and register the init routine.
- While there move the proto_register_opcua() routine to the end of the file
- to be more consistent with other dissectors.
- Change soft deprecated APIs
+ Reformat the script-added hf_ values while we're at it.
- Change-Id: I2b93692be24dbf60f4ef09aa7283e55ebf3c1874
- Reviewed-on: https://code.wireshark.org/review/3431
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit 8b2a8a9
-Author: Graham Bloice <graham.bloice@trihedral.com>
-Date: Tue Aug 5 13:27:24 2014 +0100
-
- Suppress 10 of the CMP0020 CMake warnings on Windows, only 8 left now.
-
- Change-Id: I2f85529728e0346b8c4888cd1c23e86a306cc613
- Reviewed-on: https://code.wireshark.org/review/3430
- Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
+ Change-Id: I48d16280c523faa3b266e8df37f5e0e0b2827712
+ Reviewed-on: https://code.wireshark.org/review/5270
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 1de0203
-Author: AndersBroman <anders.broman@ericsson.com>
-Date: Tue Aug 5 13:57:16 2014 +0200
+commit 67f86dd
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Wed Nov 12 21:22:05 2014 -0800
- device.remote_opts.sampling_method and device.remote_opts.sampling_param
- only exists if we have HAVE_PCAP_SETSAMPLING.
+ Get rid of spaces before tabs.
- Change-Id: I60b98fd0539d1a8f4fcdd3a079f39f8062a43844
- Reviewed-on: https://code.wireshark.org/review/3429
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Change-Id: I70ff250a905ac578d7e3afc63a82a5fcb3983608
+ Reviewed-on: https://code.wireshark.org/review/5269
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 601d99d
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 4 18:24:34 2014 +0200
+commit d1ccc33
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sun Nov 9 21:13:38 2014 -0500
- MySQL: Request Unknown (133) (SSL: Handshake response packet)
+ Add dissector table for sFlow header dissection.
- After the MySQL protocol has established a SSL connection the first packet is a HandshakeResponse packet (aka Login Request).
-
- http://dev.mysql.com/doc/internals/en/ssl.html
- http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::HandshakeResponse
-
- The loginrequest within the SSL stream is not packet_number 1. (it however is the first packet in the ssl stream)
-
- Issue found by Daniël van Eeden
-
- Change-Id: Ic6110c38f7206a9788158c5c6861064939644221
- Ping-Bug:10338
- Reviewed-on: https://code.wireshark.org/review/3408
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Daniël van Eeden <wireshark@myname.nl>
+ Change-Id: I189a5b2d5f769395fa5e387f8be49b81903fb252
+ Reviewed-on: https://code.wireshark.org/review/5262
Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit f080b43
-Author: Irene Ruengeler <ruengeler@wireshark.org>
-Date: Mon Aug 4 13:57:17 2014 +0200
-
- Windows: Manage remote interfaces
-
- Add remote interfaces to capture from a remote host.
-
- Change-Id: I34e31d865304f3c6dd972ab9ab1c23829d564665
- Reviewed-on: https://code.wireshark.org/review/3405
- Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 3b91474
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Thu Jul 31 15:54:24 2014 -0700
+commit 17798bc
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Wed Nov 12 21:19:41 2014 -0800
- Dissection of CapResp Packets
+ Handle duplicate attribute and TLV entries specially.
- Added dissection of MAUSB Capability Response (CapResp) fields.
+ For attributes, handle them the same way we handle duplicate vendors.
- Change-Id: I41044a25c72b72ef9c8ef5640a609eb6448b054d
- Reviewed-on: https://code.wireshark.org/review/3329
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ For TLVs, ignore duplicates; they shouldn't happen.
+
+ Change-Id: Ie968478c40a9b7848fa8ea25b144eda8656e5874
+ Reviewed-on: https://code.wireshark.org/review/5268
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 9d5f914
+commit f8e24c9
Author: Michael Mann <mmann78@netscape.net>
-Date: Sun Aug 3 21:10:24 2014 -0400
+Date: Wed Nov 5 23:07:35 2014 -0500
- Eliminate proto_tree_add_text from some dissectors.
+ Eliminate proto_tree_add_text for some dissectors.
- Other minor cleanup while in the area.
-
- Change-Id: Id8d957d3d68a2e3dd5089f490bd59d773e1be967
- Reviewed-on: https://code.wireshark.org/review/3427
+ Change-Id: Ide14bcac0b1563bee4260ac9c1a280ba99e97e71
+ Reviewed-on: https://code.wireshark.org/review/5261
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit edbb9ed
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Aug 4 19:02:09 2014 -0400
-
- Add Stateless Transport Tunneling to the list of new protocols and its author
- to AUTHORS.
-
- Change-Id: I2afcdb88b43fc8360b05d69ebc7d261e9bc84b32
- Reviewed-on: https://code.wireshark.org/review/3421
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit bbda3dd
+commit 0515087
Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 4 16:37:48 2014 -0700
+Date: Wed Nov 12 19:01:26 2014 -0800
- Write out decode_as entries from the actual dissector tables.
+ Handle new vendors and changes to vendors differently.
- Have a save_decode_as_entries() routine in ui/decode_as_utils.c, that
- does all the work of saving the entries by iterating through all the
- changed entries with dissector_all_tables_foreach_changed().
+ If, when adding a new vendor, we already find a vendor with the given
+ ID, don't bother adding it to the vendors-by-ID table with the same ID,
+ and, if and only if the vendor name has changed, remove it from the
+ vendors-by-name table, free the old name, replace it with the new name,
+ and, add it back to the vendors-by-name table with the new name.
- When doing so, write out the selector for integral values in decimal, as
- older versions of Wireshark only handled decimal values, and some of
- those older versions are EOLed and won't be fixed.
-
- Change-Id: I2dab461604524b98e3515867839a4b86c86c5d7b
- Reviewed-on: https://code.wireshark.org/review/3426
+ Bug: 10666
+ Change-Id: I43ebcb57c742563157c71b01ebc0b35797a408e1
+ Reviewed-on: https://code.wireshark.org/review/5265
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit ce7b041
+commit f598fa8
Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 4 16:04:06 2014 -0700
+Date: Wed Nov 12 18:11:00 2014 -0800
Squelch a compiler warning.
- Change-Id: I8916bb3cc136c03c39fbdaf5d7bb61c3dae137e6
- Reviewed-on: https://code.wireshark.org/review/3422
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit e095b53
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 4 15:34:37 2014 -0700
-
- Add in a missing newline.
-
- Change-Id: I704be0f8a87c939b5058d574da833b237a32148d
- Reviewed-on: https://code.wireshark.org/review/3419
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 01361a9
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 4 15:26:00 2014 -0700
-
- Support both decimal and hex values for uint dissectors.
-
- And, while we're at it, reject entries with invalid numbers.
-
- Change-Id: Ifefe28396cfe391d2d5c7f7ff335d0f041e35a03
- Reviewed-on: https://code.wireshark.org/review/3417
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 7c72f70
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 4 15:00:42 2014 -0700
-
- Remove a comment asking a question, as the answer is "no".
-
- I.e., no, the epan/decode_as.c stuff belongs in libwireshark, not libui,
- because dissectors need to be able to say "I support decode-as...".
- Code to implement the UIs that allow decode-as entries to be specified
- would belong in libui.
-
- Change-Id: Ibf9da19e752481a3892d0f03d0a0537590ab1811
- Reviewed-on: https://code.wireshark.org/review/3416
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 7bc0b9b
-Author: Kevin Cox <kevincox@kevincox.ca>
-Date: Thu May 1 17:13:35 2014 -0400
-
- Initial Ceph Dissector.
-
- This is the first version of a Ceph dissector. It is not complete but
- is far enough along to be helpful to many people working with Ceph.
-
- Currently the dissector can fully dissect the Ceph protocol and has
- support for full dissection of most common messages. For the other
- messages for which full dissection is not available their metadata is
- parsed and shown along with the raw data of the different message
- sections.
-
- Change-Id: Ic7917a3d01148c6fe2f9ea2c13ecd09ecc06c2d7
- Reviewed-on: https://code.wireshark.org/review/1889
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
-
-commit d434e08
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Mon Aug 4 13:42:00 2014 -0700
-
- Fix a comment.
+ Some compilers complain that we're casting a 16-bit integer to a
+ pointer; making it a standard-size integer squelches the warning.
- Change-Id: I4dff4912ad8355552ba9efee73c0aae9a2a55000
- Reviewed-on: https://code.wireshark.org/review/3415
+ Change-Id: Iba0e767d7801afdc369b64a1cf050bf8db37da7b
+ Reviewed-on: https://code.wireshark.org/review/5264
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 70a6d20
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 1 11:10:55 2014 -0400
+commit f7d91bd
+Author: Gerald Combs <gerald@zing.org>
+Date: Tue Nov 11 09:56:58 2014 -0800
- Add a cmake build to distcheck to ensure that we distribute all the files
- necessary to do a cmake build.
+ Qt: Flatten group boxes.
- Note that this does mean that anyone doing "make distcheck" needs cmake.
+ As discussed in change 5185, the "big 3" HIGs discourage the use of
+ traditional group boxes. Flatten our existing ones.
- Bug: 10331
- Change-Id: I4360a305aa7f6ffc1b5a5dffad24b928eed45016
- Reviewed-on: https://code.wireshark.org/review/3326
+ Change-Id: I68ef4aa9fd0f69a42750bf735df2250a468bfb2d
+ Reviewed-on: https://code.wireshark.org/review/5263
Reviewed-by: Gerald Combs <gerald@wireshark.org>
- Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 644b2e7
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Mon Aug 4 15:44:02 2014 -0400
+commit 6df5252
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sun Nov 9 15:44:56 2014 -0500
- Fix RPM builds with a prefix other than /usr.
+ Add Decode As functionality for MPLS PW Associated Channel Type.
- The location of update-alternatives does not depend on Wireshark's
- installation prefix: it's always in /usr/sbin/.
+ Add CFM and MPLS dissector as possible decoders.
- Change-Id: I7dda9cebec83bc64133adfeb5ee6af70dc6dc7ab
- Reviewed-on: https://code.wireshark.org/review/3413
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Bug: 10574
+ Change-Id: Ic39c6b8d68b965ff9d342f5ee789a8eff3134a5a
+ Reviewed-on: https://code.wireshark.org/review/4935
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 4a2e968
+commit ae1630d
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Mon Aug 4 19:42:29 2014 +0200
+Date: Wed Nov 12 12:57:36 2014 +0100
- MySQL: decoding response fails
-
- MySQL Response packets within an SSL stream are not correctly decoded.
-
- When not using SSL:
- - Decoding works
- - Multiple MySQL protocol entries per frame
- - Info==Response
-
- With SSL:
- - Decoding partly works
- - One MySQL protocol entry per fram
- - Info==Response Tabular
+ Fix warning: no previous prototype for function ... [-Wmissing-prototypes]
- From me:
- call dissect_mysql (with tcp_dissect_pdus..) and not dissect_mysql_pdu !
-
- Bug: 10339
- Change-Id: I253f6683105ed23b49a72865fea005e31e2594d8
- Reviewed-on: https://code.wireshark.org/review/3412
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit c540e55
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Tue Jul 22 18:01:50 2014 +0200
-
- DNS: Fix minor typo (Missing a space...)
+ warning coming after g055e4768ece and g421913b721
- Change-Id: Ie983ba3b88102c4f3749ab2f13d519eb78838bbc
- Reviewed-on: https://code.wireshark.org/review/3410
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I5caeeb89c559faef8007f2946c68c7172b75dfa8
+ Reviewed-on: https://code.wireshark.org/review/5250
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 37b5b09
-Author: Evan Huus <eapache@gmail.com>
-Date: Mon Aug 4 07:22:59 2014 -0400
+commit 54aea45
+Author: AndersBroman <anders.broman@ericsson.com>
+Date: Wed Nov 12 14:15:48 2014 +0100
- Rip out the filetap code
-
- We decided at sharkfest that this wasn't the right design for file dissection;
- we have more-or-less settled on way forward, but nobody's shown interest in
- implementing it. Whether or not that ever happens, this code is effectively
- dead and should be removed.
+ [Art-Net]
+ - The heuristic chek was missing "e" out of "Art-Net\0"
+ - tvb_length() - tvb_captured_length()
- Change-Id: I14d6086df3204fffb6485228db39d9f407661417
- Reviewed-on: https://code.wireshark.org/review/3400
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Iad9900f3a22e2fdbd0d6056efc1af90511cc458a
+ Reviewed-on: https://code.wireshark.org/review/5257
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 76e4698
-Author: Jakub Zawadzki <darkjames@darkjames.pl>
-Date: Mon Aug 4 07:39:49 2014 +0200
+commit 63cf939
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Wed Nov 12 12:26:22 2014 +0100
- Always create subtree in proto_item_add_subtree().
+ ADB: fix warning: no newline at end of file [-Wnewline-eof]
- It might fix bug #10345
+ Warning found by Clang
- Ping-Bug: 10345
- Change-Id: I695a2955a9bb0248ff3967bdaef004389500bbc9
- Reviewed-on: https://code.wireshark.org/review/3402
+ Change-Id: I7b801808aefa294e32fff560ea1a49620f0e0ea0
+ Reviewed-on: https://code.wireshark.org/review/5249
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Reviewed-by: Michal Orynicz <michal.orynicz@tieto.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
- Tested-by: Anders Broman <a.broman58@gmail.com>
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-commit f25f1ea
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Aug 3 22:59:57 2014 -0400
+commit 2043c9d
+Author: Dario Lombardo <lomato@gmail.com>
+Date: Wed Nov 12 11:06:45 2014 +0100
- Don't try and run checkAPIs.pl on deleted files
+ Updates in it translation.
- It fails, for obvious reasons, and makes it impossible to commit the removal of
- c/h files.
-
- Change-Id: Ifcd067f8959684e2e0191983fd60fb94ae86bca3
- Reviewed-on: https://code.wireshark.org/review/3401
+ Change-Id: I9e90fca521f17f4ae49e132990f77b2610807e6d
+ Reviewed-on: https://code.wireshark.org/review/5248
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-commit da5dd18
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 23:39:05 2014 -0700
+commit f2d94e1
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Nov 11 12:52:04 2014 +0100
- CMake 2.8+ supports CMAKE_OSX_DEPLOYMENT_TARGET; don't do that stuff ourselves.
-
- Do, however, do the "for a target of 10.4 or 10.5, build 32-bit only"
- stuff, as that's specific to programs that capture traffic, such as
- Wireshark (well, I guess we could just limit it to dumpcap, but...).
+ PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
- Change-Id: I5f4d4d57fd126e5c295dedae9ed13b263035a911
- Reviewed-on: https://code.wireshark.org/review/3403
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I1540c7878692625a9e38b48f8681c07bab852a64
+ Reviewed-on: https://code.wireshark.org/review/5234
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 0294b29
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Aug 3 20:30:52 2014 -0400
+commit 219cf30
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Tue Nov 11 15:22:12 2014 -0500
- Try to detect overflow without causing signedness warnings.
+ Fix SMPP timestamp decoding when the current date/time's offset to UTC is
+ different from the timestamp's offset to UTC.
- Change-Id: I957ead1f674e2c56e9c741841fea11395769b238
- Reviewed-on: https://code.wireshark.org/review/3398
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit efb8a1e
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Aug 3 17:48:06 2014 -0400
-
- Check for multiplicative overflow in the wmem_alloc_array macros.
+ The fix for bug 6712 ignored the fact that daylight savings will affect the
+ offset from UTC--and whether daylight savings is in effect today might be
+ different than whether it was in effect in the timestamp we're decoding.
- Bug:10343
- Change-Id: Iea511c806b92999b3b497f94886c46a818100a23
- Reviewed-on: https://code.wireshark.org/review/3396
- Reviewed-by: Bill Meier <wmeier@newsguy.com>
+ Bug: 10672
+ Change-Id: Ie513c361cff41007f2328cd9ca9ca4800ffef500
+ Reviewed-on: https://code.wireshark.org/review/5245
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 5b9acda
-Author: rvichery <remi.vichery@gmail.com>
-Date: Mon Jul 14 12:51:24 2014 +0200
+commit cfd71d7
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Tue Nov 11 20:48:39 2014 -0500
- Stateless Transport Tunneling: Add STT dissector support
+ Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up
+ on the OSX 10.5 buildbot.
- Bug: 10282
- Change-Id: Id3e53c53d024a74df0dfb5254e26d4594eb2e9a4
- Reviewed-on: https://code.wireshark.org/review/3036
- Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Change-Id: I49e066feab8b980ea85371095234e96e89db71e1
+ Reviewed-on: https://code.wireshark.org/review/5247
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 6af0631
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 13:53:58 2014 -0700
+commit ea5b234
+Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
+Date: Tue Nov 11 15:37:04 2014 -0500
- Remove duplicate line.
+ Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up with gcc 4.8.3.
- Change-Id: I0b32ccaaa7c9e0294ee7bc96fe4937a98d8461d5
- Reviewed-on: https://code.wireshark.org/review/3394
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I71c9013670dd6e8c74e039bd252cfac2c9e95a18
+ Reviewed-on: https://code.wireshark.org/review/5246
+ Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-commit 79f9665
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 13:19:41 2014 -0700
+commit 2f3e577
+Author: AndersBroman <a.broman@bredband.net>
+Date: Tue Nov 11 21:21:28 2014 +0100
- Squelch some compiler warnings.
+ [GTP] Fix decoding of UMTS GTP QoS Profile i n Radius and Diameter
+ messages.
+ Fixes Bug 10688
- The version of GCC on the OS X 32-bit buildbot isn't smart enough to
- figure out that this can't happen (it's one of those "if (xxx) foo =
- bar; ... if (xxx) use foo;" cases.)
-
- Change-Id: I04fef2d602c913761ae7832c4f568aaaad398c87
- Reviewed-on: https://code.wireshark.org/review/3390
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: Iff29ae3f6cee1b4ad12a0e5c5d7fd3da1c9343af
+ Reviewed-on: https://code.wireshark.org/review/5244
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 3b72a7d
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 13:13:23 2014 -0700
+commit feedcb0
+Author: AndersBroman <a.broman@bredband.net>
+Date: Tue Nov 11 21:00:16 2014 +0100
- Add some issues that came up when comparing autotools and CMake compile flags.
+ [Radius] Make dictionary.starent.vsa1 the default dictionary.
+ at least with the trace in Bug 10688 that makes the most sense.
- Also be consistent about whether OS X is working or not, and note that
- we're also doing CMake builds on Solaris.
-
- Change-Id: I2da18d2fb5aec7e5806dc7ea186f729acef94272
- Reviewed-on: https://code.wireshark.org/review/3389
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I76213449076a2f49a4b72c6dd87b022fb10b9eef
+ Reviewed-on: https://code.wireshark.org/review/5242
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 2d126cf
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 13:07:46 2014 -0700
+commit b1c91b0
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Nov 11 19:35:55 2014 +0100
- Add an OSX_DEPLOY_TARGET option to control building for a target OS version.
-
- It should be set to an OS version, such as "10.5" or "10.6" or..., and,
- if set (and if you're building for "APPLE"), it'll try to find the SDK
- (and fail if it's not found), and add appropriate -isysroot,
- -mmacosx-version-min, and, if appropriate, -m32 compiler options.
-
- (It will need more work once we support building OS X app bundles and
- installers; pick up more stuff from configure.ac for that.)
+ Tools: Add fix_pragma_wdocumentation to UNKNOWN licence
- Change-Id: I0aebf2db8aa39304a41be4e2a9879dea6f308ec7
- Reviewed-on: https://code.wireshark.org/review/3388
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: Ib5665924b99644c52c95d408c7cff19509cf3eb2
+ Reviewed-on: https://code.wireshark.org/review/5241
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 27cfea6
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 11:48:44 2014 -0700
+commit dfaaba8
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Tue Nov 11 12:56:34 2014 -0500
- Define INET6 in config.h rather than in the Makefile.
+ hiqnet: Use correct filter names; Fix specification of hf_dhcp
- That's what we do with nmake and CMake; this makes it uniform, so it's
- easier to compare compiler commands.
+ "foo.flags..." --> "hiqnet.flags...";
+ Use BASE_NONE for hf_dchp.
- Change-Id: Ice2c4bd796e921fa3089e8a45a32ad14d9b0e0a4
- Reviewed-on: https://code.wireshark.org/review/3387
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: Ic3ca4754a1daeefc831dbfcd6a280fe19f8efbf3
+ Reviewed-on: https://code.wireshark.org/review/5240
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 53957d8
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 11:28:36 2014 -0700
+commit bd9ff6b
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Sat Nov 8 18:21:07 2014 +0100
- Go back to non-verbose Makefiles.
+ Add tools for fix -Wdocumentation
- (The difference in question turned out to be that optimization wasn't
- turned on for autotools builds but was turned on for CMake builds.
- Comparing the compiler options also found some other differences that
- should be cleaned up.)
+ Use pragma to disable -Wdocumentation when include glib.h, gmodule or gtk/gtk.h
- Change-Id: I2edb28dedc47fe10b3f68f25d3e302430b27bf46
- Reviewed-on: https://code.wireshark.org/review/3386
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I576c0d5c4a12ac3b505ac9543646356ff29ac814
+ Reviewed-on: https://code.wireshark.org/review/5198
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 3da89d6
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Aug 3 13:54:30 2014 -0400
+commit 7e2ede3
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Nov 11 17:56:05 2014 +0100
- Add missing macro parameter
+ Hiqnet: fix warning found by fix-encoding-args tools
- This is what you get for forward-cherrypicking commits you made on master-1.12.
-
- Change-Id: I8e51181d497dc63c614fe623439506cfe99c6fa3
- Reviewed-on: https://code.wireshark.org/review/3385
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I7e513ec5b617217cd238861f5f02d44edce0bedd
+ Reviewed-on: https://code.wireshark.org/review/5239
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 0996730
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 1 16:14:23 2014 -0400
+commit 0f4860b
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Nov 11 17:50:17 2014 +0100
- Make Lua taps work in out-of-source-tree builds.
-
- make-taps.pl needs to know where to find the source files in order to build
- the taps.
-
- This makes the wslua test suite run in autofoo out-of-source-tree builds too.
- To make it work with cmake builds requires putting all the epan/wslua/ output
- (or at least init.lua) in epan/wslua/ instead of epan/.
+ Hiqnet: fix Mac OS X buildbot
- Change-Id: I1b3c517f08d3c752ee03cb89482ee4951ceb5bf3
- Reviewed-on: https://code.wireshark.org/review/3348
- Petri-Dish: Evan Huus <eapache@gmail.com>
+ Change-Id: Ia4fec86ed389ccb558fe9e1acfb6e87b7012bb75
+ warning: declaration of 'strlen' shadows a global declaration
+ Reviewed-on: https://code.wireshark.org/review/5237
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit d34d09e
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Aug 3 13:25:19 2014 -0400
+commit 41cc80e
+Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
+Date: Tue Nov 11 17:54:09 2014 +0100
- Initialize a variable to squelch a false-positive warning on the mac buildbot
+ Hiqnet: fix typo lenght => length
- Change-Id: I43f5ea7a73941b518c714216df0d7e25ad260012
- Reviewed-on: https://code.wireshark.org/review/3384
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I104d8bb0c56899faef6f4d608859e7b1a34e45a4
+ Reviewed-on: https://code.wireshark.org/review/5238
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit 5460d7f
-Author: Evan Huus <eapache@gmail.com>
-Date: Fri Aug 1 21:27:01 2014 -0400
+commit 8b5b0b3
+Author: Raphaël Doursenaud <rdoursenaud@free.fr>
+Date: Mon Oct 20 13:07:56 2014 +0200
- Only fake an item by returning 'tree' if they use the same TVB
+ Initial Harman HiQnet dissector
- Otherwise the offsets will be wrong when calling, e.g. proto_item_set_end.
-
- Bug:10329
- Change-Id: I5ae0c660af90678e446817b65f83c075e7c0b84e
- Reviewed-on: https://code.wireshark.org/review/3341
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I43042edde09395e328d84bf4b172465829915a98
+ Reviewed-on: https://code.wireshark.org/review/5014
+ Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-commit a6fc5a3
-Author: Evan Huus <eapache@gmail.com>
-Date: Sun Aug 3 12:29:36 2014 -0400
+commit 7469fab
+Author: desolat <nuabaranda@web.de>
+Date: Tue Nov 11 00:46:05 2014 +0100
- Cast G_STRUCT_OFFSET to gint to fix mac buildbot
-
- glib casts the result to glong for no apparent reason (has anybody ever defined
- a structure of more than 2^32 bytes?) which was causing a whole bunch of useless
- 64-to-32-bit conversion warnings.
+ BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Status_Flags
- Change-Id: I70305fb3b03332bb876023acdd107eb1e95fea27
- Reviewed-on: https://code.wireshark.org/review/3383
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 5db1352
-Author: Michael Mann <mmann78@netscape.net>
-Date: Fri Aug 1 10:08:57 2014 -0400
-
- Eliminate proto_tree_add_text from some dissectors.
+ Implementation for this event parameter type was missing
- Change-Id: I398e9cf4f6882e76644aa758e12c39a39159e95f
- Reviewed-on: https://code.wireshark.org/review/3319
- Petri-Dish: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Evan Huus <eapache@gmail.com>
+ Bug: 9626
+ Change-Id: Iea0bc819858bbf5660d97cfd0c418a963ac149fb
+ Reviewed-on: https://code.wireshark.org/review/5228
Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 3fa5625
-Author: Michael Mann <mmann78@netscape.net>
-Date: Thu Jul 31 12:39:40 2014 -0400
-
- Eliminate proto_tree_add_text from some dissectors.
-
- Change-Id: Ib6024307e85d6c23decf40e9759f549c19ffe136
- Reviewed-on: https://code.wireshark.org/review/3318
Petri-Dish: Michael Mann <mmann78@netscape.net>
- Petri-Dish: Evan Huus <eapache@gmail.com>
- Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
- Reviewed-by: Michael Mann <mmann78@netscape.net>
-
-commit 7a7a72e
-Author: Pascal Quantin <pascal.quantin@gmail.com>
-Date: Sun Aug 3 15:03:50 2014 +0200
-
- Fix TCP/UDP/SCTP conversations broken by g59ef97d and g31ecdf5
-
- Bug: 10336
- Change-Id: Ia0dbe3abfade59a1c9714eacd8a854eafa6cf879
- Reviewed-on: https://code.wireshark.org/review/3379
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 50b6e16
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Sun Aug 3 08:05:47 2014 -0700
-
- [Automatic manuf, services and enterprise-numbers update for 2014-08-03]
-
- Change-Id: Icb7fc56e6127761465c38deed755ae54bef6f272
- Reviewed-on: https://code.wireshark.org/review/3380
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit af6ea57
-Author: Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com>
-Date: Sat Aug 2 16:22:28 2014 +0900
-
- http2: Update to h2-14
-
- * Expand frame length field to 24 bits
- * Add new SETTINGS:
- - SETTINGS_MAX_FRAME_SIZE
- - SETTINGS_MAX_HEADER_LIST_SIZE
- * Update libnghttp2 HPACK
- * Remove END_SEGMENT flag
-
- Change-Id: I5906322ad5a4d61c963ed95fada9415e66e146da
- Reviewed-on: https://code.wireshark.org/review/3357
- Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
-
-commit 5ced893
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Aug 2 10:36:34 2014 +0200
-
- HTTP2: Fix README about change of nghttp2
-
- nghttp2ver.h is a local header, so use "" not <>
-
- See commit 4a182d48b1105889b51ee3bb06b033c636965130
-
- Change-Id: I49210906290210fde8f496996e0e5ae69d697338
- Reviewed-on: https://code.wireshark.org/review/3349
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 518f339
-Author: Peter Wu <peter@lekensteyn.nl>
-Date: Fri Aug 1 14:40:24 2014 +0200
-
- lbm: fix "member access within null pointer" warning
-
- This patch avoids the following warning with `clang -fsanitize=undefined`:
-
- epan/dissectors/packet-lbtrm.c:1519:36: runtime error: member access within null pointer of type 'lbtrm_hdr_t'
-
- Change-Id: I973caf92547f5d16c0de20908b2b3fbc09227df0
- Reviewed-on: https://code.wireshark.org/review/3313
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 2d50397
-Author: Peter Wu <peter@lekensteyn.nl>
-Date: Fri Aug 1 14:28:11 2014 +0200
+commit b2c2deb
+Author: Guy Harris <guy@alum.mit.edu>
+Date: Mon Nov 10 19:47:59 2014 -0800
- paltalk: fix undefined behavior (shift out of range)
-
- The shift `(gint32)0xFF << 24` invokes undefined behavior as it may not
- fit in a signed integer. Fix this by explicitly casting 0xFF as
- unsigned. Caught by `clang -fsanitize=undefined`.
-
- While at it, convert to tvb_captured_length and add modelines.
+ Fix a problem that causes build failures with CMake on Yosemite.
- Change-Id: I241ff8ed91815369ec0c19719750cee4b6b12343
- Reviewed-on: https://code.wireshark.org/review/3311
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I52e81656470df887eb3c53b2632bf5a310b1b063
+ Reviewed-on: https://code.wireshark.org/review/5229
+ Reviewed-by: Guy Harris <guy@alum.mit.edu>
-commit 0b23e0f
-Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Sat Aug 2 12:00:59 2014 +0200
+commit afae2b6
+Author: David Ameiss <netshark@ameissnet.com>
+Date: Mon Nov 10 14:24:18 2014 -0600
- HTTP2: Add a preference to enable/disable HTTP2 (weak) heuristics
+ Allow building under OSX Yosemite using cmake.
- By default, the heuristic is disabled
+ CFPropertyListCreateFromStream() has been deprecated in Yosemite, in favor of CFPropertyListCreateWithStream(). The autotools
+ build checks for the existence of the new function, but the cmake build does not. So, add a check for it to CMakeLists.txt, and
+ update cmakeconfig.h.in to provide the "template" for HAVE_CFPROPERTYLISTCREATEWITHSTREAM.
- Change-Id: I26ef23e8b153576a4fabd2e3324e830756e64bb7
- Ping-Bug:10335
- Ping-Bug:10310
- Reviewed-on: https://code.wireshark.org/review/3350
- Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I1a4e3e1ce83092ecf7725527b921eeca80b18d4b
+ Note: CFPropertyListCreateWithStream() works under Mavericks as well.
+ Reviewed-on: https://code.wireshark.org/review/5226
+ Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
+ Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
-commit 7df03a7
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sun Aug 3 03:40:11 2014 -0700
+commit c44ff77
+Author: Bill Meier <wmeier@newsguy.com>
+Date: Mon Nov 10 15:07:51 2014 -0500
- Get rid of debugging output, and get CMake to produce verbose makefiles.
+ amqp: Misc changes;
- On the 32-bit OS X buildbot, automake is old enough that autotools
- builds are verbose, printing the command line for each compile step; if
- we cause CMake to produce verbose makefiles, they will also print the
- command line, so we can see what differences there are.
+ - amqp_1_0_dissectiom: Use MIN(32-bit-length, 0xFFFF) as the length to dissect;
+ The original code just used the low-order 16 bits of the 32-bit length
+ field as the length to dissect.
+ Add an expert warning if the actual PDU length is > 65K.
- This means the other debugging output we added isn't necessary; remove
- it.
-
- Sort the extra warning options in configure.ac based on whether they're
- for C and C++ or just C, just as is the case in CMake, to make it easier
- to keep the lists in sync; add comments to configure.ac to mirror the
- ones in CMakeLists.txt.
-
- Get rid of -Wno-deprecated-declarations; the CMake build doesn't use it,
- and it doesn't appear to be necessary - if we ever have problems with OS
- X complaining about using OpenSSL, for example, we should do as tcpdump
- does and wrap uses of the "deprecated"-but-cross-platform APIs in
- the appropriate pragmas.
+ - tvb_length() --> tvb_reported_length()
- Change-Id: I0b8b45f00481ac2b67da5c7dd028a029b130dcc4
- Reviewed-on: https://code.wireshark.org/review/3377
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I3230600f460a8bd495eeec17fa6e704bf24de1a2
+ Reviewed-on: https://code.wireshark.org/review/5225
+ Reviewed-by: Bill Meier <wmeier@newsguy.com>
-commit 8d51a50
-Author: Evan Huus <eapache@gmail.com>
-Date: Thu Jul 31 13:25:00 2014 -0400
+commit bc990fc
+Author: Martin Kaiser <wireshark@kaiser.cx>
+Date: Mon Sep 1 09:47:26 2014 +0200
- Remove get_next_di() and just use packet-scope for those
+ USB: consider the device class when we try to select the next dissector
- Presumably that was added for tap purposes, but packet-scope is much simpler and
- less dangerous. Noticed while investigating the scan-build issues with
- stack-local variables being pointed to by globals.
+ at the moment, we only use the interface class, even in situations where
+ it's not applicable (e.g. control request that's not addressed to an
+ interface or an endpoint) - this is a hack that works because some
+ dissectors register for interface class "unknown", I'm trying to make
+ this workaround obsolete
- Change-Id: I851d756b103df71079b656e624f7472354c15862
- Reviewed-on: https://code.wireshark.org/review/3290
+ Change-Id: I6bf4253a2f8bf5a75ea1a08c3e52d36f80abd7ab
+ Reviewed-on: https://code.wireshark.org/review/5215
+ Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Sean Stalley <seanstalley@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Petri-Dish: Anders Broman <a.broman58@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 9112a09
-Author: Evan Huus <eapache@gmail.com>
-Date: Fri Aug 1 22:05:32 2014 -0400
+commit 0f7aedc
+Author: AndersBroman <anders.broman@ericsson.com>
+Date: Mon Nov 10 17:43:53 2014 +0100
- Fix an infinite loop when the line has no length
+ Use correct offset and lenght for Choice EOC.
- Bug:10333
- Change-Id: Ia2dae94095dddf57e4c75792b5477b0eb37c29c9
- Reviewed-on: https://code.wireshark.org/review/3343
+ Change-Id: I8152e1a07768a3bc245bbafa7c24901ba26a2478
+ Reviewed-on: https://code.wireshark.org/review/5224
Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 06ba328
-Author: Peter Wu <peter@lekensteyn.nl>
-Date: Fri Aug 1 12:32:43 2014 +0200
+commit 0f758fa
+Author: Victor Voronkov <victor.voronkov@gmail.com>
+Date: Mon Nov 10 12:07:15 2014 +0100
- Fix uninitialized session ticket
-
- If the tvb contained too few data,
- ssl_dissect_hnd_hello_ext_session_ticket would then allocate
- session_ticket, but not initialize the contents. Fix this by adding a
- check for the TVB length.
-
- The same is done for ssl_dissect_hnd_new_ses_ticket. That might, or
- might not, be necessary as proto_tree_add_item() is called with the
- range. When tree is NULL, ssl is usually NULL too. For clarity (and to
- avoid surprises in the future), add it anyway.
+ WCCP: fix parsing of extended assignment data element
- Bug: 10330
- Change-Id: I469e97542542aaef4cbd660086bedf92ba1c0b6e
- Reviewed-on: https://code.wireshark.org/review/3309
- Reviewed-by: Evan Huus <eapache@gmail.com>
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
+ Bug: 10641
+ Change-Id: I51322757c5aa7877fa8ff7915330ff24e7a8cbe2
+ Reviewed-on: https://code.wireshark.org/review/5221
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 9dc3d67
-Author: Evan Huus <eapache@gmail.com>
-Date: Sat Aug 2 10:51:55 2014 -0400
+commit ea16705
+Author: Stig Bjørlykke <stig@bjorlykke.org>
+Date: Thu Nov 6 11:19:25 2014 +0100
- wmem: get rid of the allocator timing test
+ Improved deregistering fields.
- Some of the allocators are close enough that a little bit of system load at the
- time of the test was enough to throw them off, and it was causing unnecessary
- buildbot failures. Benchmarking on real-world cases at the time of
- implementation (as well as reliable "average" results on the buildbots) has left
- me confident that block_fast is, in fact, faster than block, which is faster
- than simple/strict.
+ This improvement avoids use of deallocated memory (crash) if using a
+ deregistered field in display filter, color filter, custom column and
+ other cases when the field is used as "interesting field".
- Additionally, the allocators are effectively "done" and unlikely to change, so
- the possibility of uncaught performance regressions is low.
+ This functionality is currently used in http, imf and ldap preferences.
- Change-Id: I144ea4cd9d6000edc4075ed682ce6a4aeaf5e28a
- Reviewed-on: https://code.wireshark.org/review/3356
- Reviewed-by: Anders Broman <a.broman58@gmail.com>
-
-commit fb68a0c
-Author: Gerald Combs <gerald@zing.org>
-Date: Sat Aug 2 19:31:33 2014 -0700
-
- Have ConversationDialog retain data between captures.
+ Also removed unused proto_registrar_n() as this does not work correctly
+ after deregistering fields.
- Remove our tap listeners when the capture file closes. This lets us view
- conversation data for multiple capture files.
- Change-Id: Ifaa1d2c9d3cd10b1d282aa0070ee2edacc7ce3b0
- Reviewed-on: https://code.wireshark.org/review/3376
- Reviewed-by: Gerald Combs <gerald@wireshark.org>
-
-commit 363f1e5
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 18:34:11 2014 -0700
-
- Print the actual compiler, not its "CMake-id".
-
- Hopefully this will help figure out whether we're using different
- compilers for the autotools and CMake builds.
-
- Change-Id: If6d2ee93cd14570c53723140dcedf347600cbe34
- Reviewed-on: https://code.wireshark.org/review/3375
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I043e3bf7a98bd773c9801e712a012d1eab8a7f94
+ Reviewed-on: https://code.wireshark.org/review/5161
+ Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
+ Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
-commit 5234d4c
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 17:46:32 2014 -0700
+commit d58567b
+Author: Stig Bjørlykke <stig@bjorlykke.org>
+Date: Wed Nov 5 14:36:29 2014 +0100
- OK, try sorting the compiler options.
+ Fixed memory leakage in col_cleanup.
- Also, comment out the addition of -Wno-deprecated-declarations, as the
- CMake build doesn't use it.
+ Several fields in cinfo is allocated memory and must be freed here
+ to avoid memory leakage when recreating the packet list.
- If this succeeds in making the autotools and CMake builds compile C code
- with the same -W and -f flags in the same order, that should eliminate
- at least one reason why the CMake build produces compiler warnings that
- the autotools build doesn't.
+ Do not allocate memory for col_expr[] as this points to static strings
+ or other allocated strings.
- Change-Id: I0eaeae91b8e3c39c53f502daef86c2d103c8bdab
- Reviewed-on: https://code.wireshark.org/review/3374
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 2dd2690
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 16:26:50 2014 -0700
-
- Note that the ...COMMON_FLAGS are for C and C++.
-
- Change-Id: I0ef87b3b4aaed984a8a53660b36746345626583a
- Reviewed-on: https://code.wireshark.org/review/3373
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I840377e3c590b1a3e2a38e0537465a028041d1e9
+ Reviewed-on: https://code.wireshark.org/review/5137
+ Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Reviewed-by: Anders Broman <a.broman58@gmail.com>
-commit 43eea3c
+commit 64b8759
Author: Gerald Combs <gerald@zing.org>
-Date: Sat Aug 2 15:42:20 2014 -0700
+Date: Sun Nov 9 22:16:15 2014 -0800
- Convert the Statistics chapter to AsciiDoc.
-
- Don't update any content for now.
+ Try to fix dist.
- Change-Id: Ib4f6402d9b23bd1ad57a57831b63c63a150391aa
- Reviewed-on: https://code.wireshark.org/review/3372
+ Change-Id: Ib4332bace88f9db7a06867861c40627e2bdc55f0
+ Reviewed-on: https://code.wireshark.org/review/5218
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 27c68f0
+commit cd5b402
Author: Gerald Combs <gerald@zing.org>
-Date: Sat Aug 2 15:47:03 2014 -0700
+Date: Sun Nov 9 21:28:00 2014 -0800
- Fix markup.
+ Fix an include.
- Change-Id: I370af51abca6156a5ce293485970896b417bd7bf
- Reviewed-on: https://code.wireshark.org/review/3371
+ Change-Id: Ic46b24cac01c49be01c7ad9e8a12b276fcdf81a5
+ Reviewed-on: https://code.wireshark.org/review/5217
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 55646c8
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 15:45:44 2014 -0700
-
- Always check some -f flags.
-
- Now that we check each flag with all previously-accepted flags, this
- catches the case where -fwrapv causes -fno-strict-overflow to produce a
- warning when tested.
-
- This way, what we do matches what the autotools do.
-
- Change-Id: I68ce281dc33a32b591e3137db626f2749c4a0708
- Reviewed-on: https://code.wireshark.org/review/3370
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit e2969cb
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 15:43:36 2014 -0700
+commit 6228930
+Author: Gerald Combs <gerald@zing.org>
+Date: Sun Nov 9 18:13:57 2014 -0800
- When testing compiler flags, test them with previously-tested flags.
+ Finish converting the User's Guide to AsciiDoc.
- That mirrors what we're doing with autotools, and catches cases where
- an earlier-tested flag affects the results for a later-tested flag
- (e.g., -fwrapv can affect whether -fno-strict-overflow produces a
- warning when tested).
+ As with the Developer's Guide, add user-guide-docinfo.xml, which lets us
+ carry over DocBook front matter. Remove the meta_info chapter. Most of
+ its contents are now in user-guide-docinfo.xml. Add a DocBook revision
+ history based on hints from the Git/SVN/CVS revision history.
- Change-Id: I8ca0b6f5dee14d2394af9b6b8b93b9dbda2702d7
- Reviewed-on: https://code.wireshark.org/review/3369
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 81f5d71
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 14:18:31 2014 -0700
-
- Get rid of trailing blank line.
+ Remove the various makefile targets for converting AsciiDoc files to
+ DocBook chapters. Remove GPL_appendix.xml. We use the AsciiDoc version.
- Change-Id: Ibcdacbad865478ee682995170937cedd575389ec
- Reviewed-on: https://code.wireshark.org/review/3368
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I543fa2a92f2c735c5f00c97ec65cff2187e09e3a
+ Reviewed-on: https://code.wireshark.org/review/5216
+ Petri-Dish: Gerald Combs <gerald@wireshark.org>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit b273563
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 14:17:09 2014 -0700
+commit 055e476
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sun Nov 9 14:00:01 2014 -0500
- Fix Debian package build complaints.
-
- Apply the patches printed out when the Debian package build complains,
- and then remove the #MISSING indications that correspond to routines we
- don't export outside the library (either because we don't declare them
- as exported outside the library, because they've been removed, or
- because they've been moved to another library).
+ Add subdissector table for MPLS PW Associated Channel Type
- Change-Id: Iba2d5c5436dabd31d7f84fd400bb78afcb5ee69f
- Reviewed-on: https://code.wireshark.org/review/3367
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: Id72fcbe74b91b4eb25fb4d3f3d47a1d53c2857b2
+ Reviewed-on: https://code.wireshark.org/review/5212
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit a722f83
+commit 3924310
Author: Gerald Combs <gerald@zing.org>
-Date: Tue Jul 29 18:31:43 2014 -0700
+Date: Sun Nov 9 11:39:15 2014 -0800
- Convert the build and install chapter to AsciiDoc.
+ WSUG: Convert ``Command Line Tools'' to AsciiDoc.
- Add OS X content. Remove GTK+ content. Update the names in the NSIS
- package to match the documentation (untested).
+ Move the idl2wrs section to the Developer's Guide. Leave most of the
+ other content intact for now.
- Change-Id: Id8fd08982bc26871bb8a319b0319808bcdba878c
- Reviewed-on: https://code.wireshark.org/review/3366
+ Change-Id: I98c6eeab62af5cc55e3ce23ab1107df02b1a22cf
+ Reviewed-on: https://code.wireshark.org/review/5214
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 50b6734
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 14:01:07 2014 -0700
-
- Dump additional debugging information.
-
- For autotools, dump CC, CFLAGS, CXX, and CXXFLAGS.
-
- For CMake, dump CMAKE_C_COMPILER_ID and CMAKE_CXX_COMPILER_ID.
-
- Hopefully this will help figure out why CMake builds catch different
- warnings from autotools builds.
-
- Change-Id: I26955ad955f60e8bad248562fa87963a3a1bb42f
- Reviewed-on: https://code.wireshark.org/review/3365
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 493c4c2
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 13:53:44 2014 -0700
-
- Wait until the C and C++ compiler flags are fully set before showing them.
-
- That way, we report the *full* contents of those flags.
-
- Change-Id: Idab78049247c04b7d35a3ce804c8ea9daaf84312
- Reviewed-on: https://code.wireshark.org/review/3364
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 7f937c9
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 11:54:54 2014 -0700
-
- Add tvb_ensure_bytes_exist64 to the API list.
-
- I thought ws_symbol_export.h was supposed to eliminate API list files.
- Apparently it didn't, so we have to update this file every time we add a
- new API.
-
- Change-Id: I93dda6ccc992c79d52d2b460e818995e6332f1be
- Reviewed-on: https://code.wireshark.org/review/3363
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit f4d2421
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 11:32:42 2014 -0700
-
- Add a routine to check whether all bytes implied by a 64-bit length exist.
-
- This lets us blow up with oversized 64-bit length values, before casting
- them to the 31-bit lengths we can actually handle in Wireshark, rather
- than blindly casting them with weird results.
-
- Use that in the MySQL dissector, and, if we get past the test, cast the
- lengths to int to squelch warnings.
-
- Change-Id: I3a5e9bd0027fa4ddcb9622f77952dba8f6b23c27
- Reviewed-on: https://code.wireshark.org/review/3362
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit d888087
-Author: Daniël van Eeden <wireshark@myname.nl>
-Date: Sun Jul 20 21:37:22 2014 +0200
-
- MySQL: Support authplugin and connattrs
-
- Bug:10294
-
- Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
- Change-Id: I65ec69821fd562da8f873ae85b1846c79ab400d9
- Reviewed-on: https://code.wireshark.org/review/3138
- Reviewed-by: Daniël van Eeden <wireshark@myname.nl>
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit b5f4cb5
-Author: Martin Kaiser <wireshark@kaiser.cx>
-Date: Fri Aug 1 12:32:21 2014 +0200
-
- fix multi-byte entries in Operator Profile capability loops
- (this problem showed up in an APDU with two 16bit application ids)
-
- Change-Id: Ie4842181b19db984a693534144fac5e91b217b34
- Reviewed-on: https://code.wireshark.org/review/3358
- Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
- Tested-by: Martin Kaiser <wireshark@kaiser.cx>
-
-commit fde0dbe
-Author: Evan Huus <eapache@gmail.com>
-Date: Sat Aug 2 10:45:28 2014 -0400
-
- fix warning: 'cipher_hd' may be used uninitialized in this function
-
- I don't think it's an actual issue, but the new compiler on the mac buildbots
- isn't smart enough to tell that.
-
- Change-Id: I759e1afe9c4011d5612be0d15282076be6f5a331
- Reviewed-on: https://code.wireshark.org/review/3355
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 2a3dba5
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 04:27:05 2014 -0700
-
- Add a cast to squelch a warning.
-
- Change-Id: Id8eba103b9edd54bdfdea9144c807c3fbe0cb4e4
- Reviewed-on: https://code.wireshark.org/review/3353
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
-
-commit 0734ac3
-Author: Guy Harris <guy@alum.mit.edu>
-Date: Sat Aug 2 04:00:48 2014 -0700
+commit c61df20
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sun Nov 9 14:01:39 2014 -0500
- Rename buffer_ routines to ws_buffer_ to avoid name collisions.
+ Restore a "ti" assignment that slightly altered dissection.
- In particular, epan/wslua/lrexlib.c has its own buffer_ routines,
- causing some linker warnings on some platforms, as reported in bug
- 10332.
-
- (Not to be backported to 1.12, as that would change the API and ABI of
- libwsutil and libwiretap. We should also make the buffer_ routines in
- epan/wslua/lrexlib.c static, which should also address this problem, but
- the name change avoids other potential namespace collisions.)
-
- Change-Id: I1d42c7d1778c7e4c019deb2608d476c52001ce28
- Reviewed-on: https://code.wireshark.org/review/3351
- Reviewed-by: Guy Harris <guy@alum.mit.edu>
+ Change-Id: I94cd7893a2e6b3668499d41519649f6a7782aa60
+ Reviewed-on: https://code.wireshark.org/review/5213
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
-commit 41e3225
-Author: Evan Huus <eapache@gmail.com>
-Date: Sat Aug 2 02:11:29 2014 +0000
+commit b41f0c3
+Author: Gerald Combs <gerald@zing.org>
+Date: Sun Nov 9 10:20:26 2014 -0800
- Revert "Make Lua taps work in out-of-source-tree builds."
-
- Breaks on windows...
+ WSUG: Convert ``Troubleshooting'' to AsciiDoc.
- This reverts commit 6b11cd97f2153bb015ade6efd05929999de85457.
+ The chapter is disabled so its final output hasn't been checked. Leave
+ most of the content intact for now.
- Change-Id: I1caf5500da993d7988e09fc0758950469f8252cf
- Reviewed-on: https://code.wireshark.org/review/3346
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I2147ee2863e7ededadf892794a836b4dc8055649
+ Reviewed-on: https://code.wireshark.org/review/5211
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit fade4b4
-Author: Evan Huus <eapache@gmail.com>
-Date: Fri Aug 1 22:13:24 2014 -0400
+commit f8f915c
+Author: Gerald Combs <gerald@zing.org>
+Date: Sun Nov 9 10:07:46 2014 -0800
- Fix another (valid) complaint from the mac buildbot
+ WSUG: Convert ``Protocols'', ``Messages'', and ``How Wireshark Works''
+ to AsciiDoc.
- What mystical new compiler upgrade is this?
+ ``How Wireshark Works'' is disabled, so its final output hasn't been
+ checked.
- Change-Id: I89b3bfb53b9a19bbfb1cc8339d38cdc4a4652c62
- Reviewed-on: https://code.wireshark.org/review/3347
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 005fd7e
-Author: Evan Huus <eapache@gmail.com>
-Date: Fri Aug 1 21:12:19 2014 -0400
-
- Rename variable to avoid -Wshadow on mac buildbots
-
- Change-Id: I13d591248718fcc36cd300bf28f779e2d9e0265a
- Reviewed-on: https://code.wireshark.org/review/3339
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit edb7a91
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 1 15:26:18 2014 -0400
-
- Make the nameres test suite work out of tree by looking for the global hosts
- file in the build directory (rather than the source directory).
+ Leave most of the content intact for now.
- Change-Id: I365e573ee84e9a41aa76f4aa9a4a6efaf42fb60e
- Reviewed-on: https://code.wireshark.org/review/3334
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: Ia78951faa3ffd9c6d2e23067dbfb954ab4042f60
+ Reviewed-on: https://code.wireshark.org/review/5210
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 6b11cd9
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 1 16:14:23 2014 -0400
+commit d8a0757
+Author: Gerald Combs <gerald@zing.org>
+Date: Sat Nov 8 22:05:52 2014 -0800
- Make Lua taps work in out-of-source-tree builds.
-
- make-taps.pl needs to know where to find the source files otherwise none of
- the tap data gets built correctly.
+ WSUG: Convert ``Files'' to AsciiDoc.
- This makes the wslua test suite run in out-of-source-tree builds too.
+ Leave most of the content intact for now.
- Change-Id: I059474d90d59e87bd57dba18530a66a927a014cf
- Reviewed-on: https://code.wireshark.org/review/3337
- Reviewed-by: Evan Huus <eapache@gmail.com>
+ Change-Id: I78f47b8310cb41ac5a07d352e56ec907b36665f8
+ Reviewed-on: https://code.wireshark.org/review/5209
+ Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 69d0788
+commit 2dda088
Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Aug 1 16:32:02 2014 -0700
+Date: Sun Nov 9 08:05:15 2014 -0800
- CompiledFilterOutput dialog fixes and updates.
+ [Automatic manuf, services and enterprise-numbers update for 2014-11-09]
- Apply a layout to the "Compiled Filter Output" dialog. Render the filter
- as monospaced text.
-
- Don't add an "expert OK" icon to the list. It doesn't seem to indicate
- any sort of status.
-
- Use a "Close" button instead of "OK". According to
-
- http://uxmovement.com/buttons/why-the-ok-button-is-no-longer-okay/
-
- "OK" implies we're going to perform some sort of action.
-
- Add a "Copy" button while we're here.
-
- Change-Id: Ia63f3032916e322fa9f4f2d465140b128b4f8078
- Reviewed-on: https://code.wireshark.org/review/3338
+ Change-Id: Icfdef00a4b9b303bde89bf57077817f25e47d190
+ Reviewed-on: https://code.wireshark.org/review/5206
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit 45f3dee
-Author: Matthieu Texier <matthieu@texier.tv>
-Date: Fri Aug 1 20:59:19 2014 +0200
-
- Fixing indentation with tabs in isis dissector
-
- Change-Id: I4f6296f1cb988dca8c94ca5089ff6aa03439da32
- Reviewed-on: https://code.wireshark.org/review/3333
- Reviewed-by: Evan Huus <eapache@gmail.com>
-
-commit 2fbd9e1
-Author: Sean O. Stalley <sean.stalley@intel.com>
-Date: Thu Jul 31 12:23:51 2014 -0700
+commit f7ac077
+Author: Michael Mann <mmann78@netscape.net>
+Date: Sat Nov 8 21:08:52 2014 -0500
- Fix variable-length managment packet dissection
-
- Before, several managment packets were dissected incorrectly as
- EPHandleDeleteReq's. Now they are dissected with the generic managment
- packet dissector.
+ Create a subdissector table for juniper payload protocols.
- Change-Id: Id2f0951b91b99ba2340ff77c6285f382436788ef
- Reviewed-on: https://code.wireshark.org/review/3328
+ Change-Id: I60fd9c6c486b9b3b90e32fb9ccce3973569cc2ee
+ Reviewed-on: https://code.wireshark.org/review/5204
+ Reviewed-by: Michael Mann <mmann78@netscape.net>
+ Petri-Dish: Michael Mann <mmann78@netscape.net>
+ Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>
-commit e70251e
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Aug 1 12:29:12 2014 -0700
+commit 8153cbc
+Author: Gerald Combs <gerald@zing.org>
+Date: Sat Nov 8 22:23:25 2014 -0800
- Fix comparison.
+ Try to fix wsluarm dependency.
- Change-Id: If2af35c8a49f405bee70eb144e26e539a7dc61f2
- Reviewed-on: https://code.wireshark.org/review/3335
+ Change-Id: I90f6a400bb5078c7719c3088d87c4632b810346b
+ Reviewed-on: https://code.wireshark.org/review/5205
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit c93297c
-Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
-Date: Fri Aug 1 14:51:53 2014 -0400
+commit 04aad36
+Author: Gerald Combs <gerald@zing.org>
+Date: Sun Nov 2 13:20:08 2014 -0800
- Remove the old wireshark binary during RPM upgrades.
+ Convert the Lua reference to AsciiDoc.
- If we have a pre-alternatives wireshark binary out there (e.g., because
- we're upgrading from wireshark-1.10 to wireshark-1.12), get rid of it
- in the %pre script. Otherwise the binary gets left there (because it's
- listed as a %ghost in the new spec file).
+ Move it to the Developer's Guide while we're here.
- Change-Id: I5828fcff486af3d269bad8dfe544c7659179bf5e
- Reviewed-on: https://code.wireshark.org/review/3332
- Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
-
-commit fb52620
-Author: Gerald Combs <gerald@wireshark.org>
-Date: Fri Aug 1 11:25:08 2014 -0700
-
- Fix the CMake WinPcap library path check.
-
- Look for wpcap.lib in WpdPack/Lib/x64 when our target platform is Win64.
+ Nudge the markup in epan/wslua where needed. Note that we should
+ probably convert it to AsciiDoc (if we're going to keep it in the DG) or
+ Doxygen.
- Change-Id: I9a1bac22106bcb6a1f155ce83c02e344e6ec0d55
- Reviewed-on: https://code.wireshark.org/review/3331
+ Change-Id: Ie175111043f98b7a37eeeb8d185a833d8e866f8b
+ Reviewed-on: https://code.wireshark.org/review/5203
Reviewed-by: Gerald Combs <gerald@wireshark.org>
-commit fbc1a9a
+commit 5020856
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
-Date: Fri Aug 1 17:09:07 2014 +0200
+Date: Sat Nov 8 18:03:23 2014 +0100
- Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
+ Fix error: parameter 'XX' not found in the function declaration (-Wdocumentation)
- Change-Id: I847c7217b520a5f7ec581e6170fe3dc77c628e96
- Reviewed-on: https: