aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Quantin <pascal.quantin@gmail.com>2017-09-27 14:49:04 +0200
committerMichael Mann <mmann78@netscape.net>2017-09-27 14:34:46 +0000
commitf83587549942332ed08b51f4e7d21e03ccdcf022 (patch)
tree1404f88718847cca780348f62113a46f9b139129
parentdc527152a8d01eef5868c625d327f6291f3b09ad (diff)
GRPC: fix a control flow issue (CID 1418525)
If no HTTP2 path is retrieved, we cannot really guess the direction. Let's not append it then. Change-Id: Ib06b103079cea8a82dbd45a7d4ac4d6a8e673857 Reviewed-on: https://code.wireshark.org/review/23764 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
-rw-r--r--epan/dissectors/packet-grpc.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/epan/dissectors/packet-grpc.c b/epan/dissectors/packet-grpc.c
index 9fc0f5efe4..140c912499 100644
--- a/epan/dissectors/packet-grpc.c
+++ b/epan/dissectors/packet-grpc.c
@@ -331,8 +331,6 @@ dissect_grpc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data _U_
if (http2_path) {
proto_item_append_text(ti, ": %s, %s", http2_path, (is_request ? "Request" : "Response"));
- } else {
- proto_item_append_text(ti, ": %s", (is_request ? "Request" : "Response"));
}
offset = dissect_grpc_message(tvb, offset, GRPC_MESSAGE_HEAD_LEN + message_length, pinfo, grpc_tree, http2_path, is_request);