diff options
| author | Guy Harris <guy@alum.mit.edu> | 2004-05-04 06:21:17 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2004-05-04 06:21:17 +0000 |
| commit | eecdd42293af1175fbf6c1772cfcdcdb351fbe92 (patch) | |
| tree | 854d665f5fbf9aaa2f30f989dd659ca2b3cac3bf | |
| parent | 3621c52cc4c03077723c0868f9b84d2f0f0e2157 (diff) | |
Note that the way we currently handle the chunked encoding doesn't work
if the HTTP data takes more than one packet.
svn path=/trunk/; revision=10785
| -rw-r--r-- | packet-http.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/packet-http.c b/packet-http.c index b97afaef52..1fa17b8467 100644 --- a/packet-http.c +++ b/packet-http.c @@ -7,7 +7,7 @@ * Copyright 2002, Tim Potter <tpot@samba.org> * Copyright 1999, Andrew Tridgell <tridge@samba.org> * - * $Id: packet-http.c,v 1.100 2004/04/30 17:07:20 obiot Exp $ + * $Id: packet-http.c,v 1.101 2004/05/04 06:21:17 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -799,6 +799,13 @@ basic_response_dissector(tvbuff_t *tvb, proto_tree *tree, int resp_strlen) /* * Dissect the http data chunks and add them to the tree. + * + * XXX - this needs to handle chunked responses that take more than + * one packet. To do that, the chunked data reassembly would have to be + * done in "req_resp_hdrs_do_reassembly()", before we actually do any + * dissection - once you start building the protocol tree, you can't + * do reassembly, as you can't just say "oops, sorry, forget about + * the stuff I've added to the protocol tree, I need to get more data". */ static int chunked_encoding_dissector(tvbuff_t **tvb_ptr, packet_info *pinfo, |