diff options
| author | Jakub Zawadzki <darkjames-ws@darkjames.pl> | 2018-01-22 18:28:16 +0100 |
|---|---|---|
| committer | Jakub Zawadzki <darkjames-ws@darkjames.pl> | 2018-01-22 20:19:57 +0000 |
| commit | e6eb4815cd426d8ea30d0ef3225bc27f39dab776 (patch) | |
| tree | ed032eba030c42b8395a271e97aa3a62ba439ef4 | |
| parent | 862c881318b80070d4394726a64feb538999269f (diff) | |
gtk: Fix memory error/double free.
pathname is freed by caller of firewall_save_as_ok_cb(). Make pathname const.
Found by clang scan.
Change-Id: I3a0ab85494a9194edb825bae33eca979c7f8faf3
Reviewed-on: https://code.wireshark.org/review/25417
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
| -rw-r--r-- | ui/gtk/firewall_dlg.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ui/gtk/firewall_dlg.c b/ui/gtk/firewall_dlg.c index f671465c17..ec422e9e53 100644 --- a/ui/gtk/firewall_dlg.c +++ b/ui/gtk/firewall_dlg.c @@ -462,7 +462,7 @@ firewall_copy_cmd_cb(GtkWidget *w _U_, gpointer data) } static gboolean -firewall_save_as_ok_cb(char *to_name, rule_info_t *rule_info) +firewall_save_as_ok_cb(const char *to_name, rule_info_t *rule_info) { FILE *fh; gchar *rule; @@ -473,7 +473,6 @@ firewall_save_as_ok_cb(char *to_name, rule_info_t *rule_info) fh = ws_fopen(to_name, "w"); if (fh == NULL) { open_failure_alert_box(to_name, errno, TRUE); - g_free(to_name); return FALSE; } |