aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJaap Keuter <jaap.keuter@xs4all.nl>2018-02-05 16:53:23 +0100
committerGuy Harris <guy@alum.mit.edu>2018-02-05 17:19:12 +0000
commite4a6383cafa83c025bdffe1f29795d9a3d6fd028 (patch)
treedc4c2c793a6181d4d2e6c440b7fb8671d4ae6a35
parent4adb67fc163f1094e14083cb6183b8e882a81767 (diff)
Amend the comment with some background for the workaround.
The added comment only explains what the cause of the problem is, and the subsequent workaround, without going into how this could be properly addressed. Add some lines to add that information. Change-Id: I74e4df0e0c4b41fe8d52d9abf2d15335d2b327d6 Reviewed-on: https://code.wireshark.org/review/25614 Reviewed-by: Guy Harris <guy@alum.mit.edu>
-rw-r--r--caputils/ws80211_utils.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/caputils/ws80211_utils.c b/caputils/ws80211_utils.c
index cff2e88d90..6ac8a2c099 100644
--- a/caputils/ws80211_utils.c
+++ b/caputils/ws80211_utils.c
@@ -150,6 +150,10 @@ static int nl80211_do_cmd(struct nl_msg *msg, struct nl_cb *cb)
* err as a side-effect, so it thinks this can loop
* infinitely.
*
+ * The proper way to address this is to help Coverity to
+ * understand the behaviour of nl_recvmsgs(), in that it
+ * does call the callback, setting err. This help would be
+ * provided through a so called 'model' of this function.
* We declare err to be volatile to work around it.
*
* XXX - that workaround provokes a compiler complaint that