diff options
| author | Guy Harris <guy@alum.mit.edu> | 2010-09-01 17:49:27 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2010-09-01 17:49:27 +0000 |
| commit | ca02af324838558802ca5c15399909476b0110ea (patch) | |
| tree | d5b807509a79b5cfbf77961b8b4acabfcc97f02c | |
| parent | 5ed49416361c3bc447fa61e963e70c709319070f (diff) | |
Expand and update comments.
svn path=/trunk/; revision=34037
| -rw-r--r-- | gtk/voip_calls.c | 30 |
1 files changed, 24 insertions, 6 deletions
diff --git a/gtk/voip_calls.c b/gtk/voip_calls.c index a5ec8be7bd..c7c52c3a48 100644 --- a/gtk/voip_calls.c +++ b/gtk/voip_calls.c @@ -2562,8 +2562,13 @@ mgcp_calls_init_tap(void) if(have_MGCP_tap_listener==FALSE) { - /* don't register tap listener, if we have it already */ - /* we send an empty filter, to force a non null "tree" in the mgcp dissector */ + /* + * Don't register the tap listener if we have it already. + * We set TL_REQUIRES_PROTO_TREE to force a non-null "tree" + * in the MGCP dissector; otherwise, the dissector + * doesn't fill in the info passed to the tap's packet + * routine. + */ error_string = register_tap_listener("mgcp", &(the_tapinfo_struct.mgcp_dummy), NULL, @@ -3721,8 +3726,13 @@ skinny_calls_init_tap(void) if(have_skinny_tap_listener==FALSE) { - /* don't register tap listener, if we have it already */ - /* we send an empty filter, to force a non null "tree" in the SKINNY dissector */ + /* + * Don't register the tap listener if we have it already. + * We set TL_REQUIRES_PROTO_TREE to force a non-null "tree" + * in the SKINNY dissector; otherwise, the dissector + * doesn't fill in the info passed to the tap's packet + * routine. + */ error_string = register_tap_listener("skinny", &(the_tapinfo_struct.skinny_dummy), NULL, @@ -3903,8 +3913,16 @@ iax2_calls_init_tap(void) if(have_iax2_tap_listener==FALSE) { - /* don't register tap listener, if we have it already */ - /* we send an empty filter, to force a non null "tree" in the IAX2 dissector */ + /* + * Don't register the tap listener if we have it already. + * We set TL_REQUIRES_PROTO_TREE to force a non-null "tree" + * in the IAX2 dissector; otherwise, the dissector + * doesn't fill in the info passed to the tap's packet + * routine. + * XXX - that appears to be true of the MGCP and SKINNY + * dissectors, but, unless I've missed something, it doesn't + * appear to be true of the IAX2 dissector. + */ error_string = register_tap_listener("IAX2", &(the_tapinfo_struct.iax2_dummy), NULL, |