aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2017-10-11 08:54:12 -0700
committerGerald Combs <gerald@wireshark.org>2017-10-11 16:31:21 +0000
commitb2467fddb1d83a0667970968493a9dad1dfb0be1 (patch)
tree709f28d405fa5a1ae57ebc337d87fdbcfa11c9a9
parent95c50e3dd766e919953def30f65ba5496226a660 (diff)
ProtoBuf: Remove an unused variable.
Remove protobuf_message_direction_type: ../epan/dissectors/packet-protobuf.c:125:20: error: unused variable 'protobuf_message_direction_type' [-Werror,-Wunused-const-variable] VALUE_STRING_ARRAY(protobuf_message_direction_type); ^ Have dissect_one_protobuf_field return a gboolean while we're here. Change-Id: I5d9d2e3414b5668ca26d5c0a450225c3cdf5da56 Reviewed-on: https://code.wireshark.org/review/23887 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
-rw-r--r--epan/dissectors/packet-protobuf.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/epan/dissectors/packet-protobuf.c b/epan/dissectors/packet-protobuf.c
index 3eb38429bb..4ee4ea56ba 100644
--- a/epan/dissectors/packet-protobuf.c
+++ b/epan/dissectors/packet-protobuf.c
@@ -116,14 +116,6 @@ static int protobuf_wire_to_field_type[6][9] = {
PROTOBUF_TYPE_NONE }
};
-/* request or response message type */
-#define protobuf_message_direction_type_VALUE_STRING_LIST(XXX) \
- XXX(PROTOBUF_MESSAGE_REQUEST, 0, "request") \
- XXX(PROTOBUF_MESSAGE_RESPONSE, 1, "response")
-
-VALUE_STRING_ENUM(protobuf_message_direction_type);
-VALUE_STRING_ARRAY(protobuf_message_direction_type);
-
void proto_register_protobuf(void);
void proto_reg_handoff_protobuf(void);
@@ -381,7 +373,7 @@ protobuf_try_dissect_field_value_on_multi_types(proto_tree *value_tree, tvbuff_t
}
}
-static guint
+static gboolean
dissect_one_protobuf_field(tvbuff_t *tvb, guint* offset, guint maxlen, packet_info *pinfo,
proto_tree *protobuf_tree, void *data)
{