diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2017-10-17 03:34:35 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-10-17 03:37:25 +0000 |
| commit | a3ba3ba94337007a458e2d4c40f3a36ad4b0e9c1 (patch) | |
| tree | 9cdce309c24307b8fd964a3c9b58a54f043ee4d9 | |
| parent | 731434cbca7404d5e9f9ecd1cc6a32e6635fd684 (diff) | |
CMake: fix Qt build with CMake 2.8.12 and before
The Qt5Widgets_EXECUTABLE_COMPILE_FLAGS option is only needed for CMake
before 2.8.12 and before as documented by Qt, so this ugly piece can be
restricted to older CMake versions. That also helps avoiding exposing
the Qt 5.5.0 in Windows since that requires a much newer CMake version.
For those older versions, use COMPILE_FLAGS such that -fPIC is added
after -fPIE (the latter is enabled by CMAKE_POSITION_INDEPENDENT_CODE).
Tested with CMake 2.8.11, 2.8.12.2, 3.0.2 and 3.9.4 using Qt 5.9.2 and
GCC 7.2.0.
Change-Id: I4962f7f5a087ee5b8c79905dd3b2cce17c731bdf
Fixes: v2.1.0rc0-566-gd66d379ac8 ("Try retroactively applying the Qt folks' fix for QTBUG-47942.")
Reviewed-on: https://code.wireshark.org/review/23954
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | CMakeLists.txt | 43 |
1 files changed, 15 insertions, 28 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 06eb0c6709..c1ba80e9cc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1152,33 +1152,6 @@ if(SNAPPY_FOUND) set(HAVE_SNAPPY 1) endif() if (Qt5Widgets_FOUND) - # - # Qt5CoreConfigExtras.cmake in Qt 5.5.0 sets -fPIC unconditionally: - # - # https://bugreports.qt.io/browse/QTBUG-47942 - # - # There's a fix in Gerrit for that: - # - # https://codereview.qt-project.org/#/c/139645/ - # - # Do the same check as that fix does and, if the check says we - # should *not* add -fPIC, remove it. - # - # XXX - if that check gets changed in the future, we'll have to - # detect that and change it. - # - if (CMAKE_VERSION VERSION_LESS 2.8.12 - AND (CMAKE_CXX_COMPILER_ID STREQUAL \"GNU\" - AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)) - # - # Yes, it should have been; leave it there. - # - else() - # - # No, it shouldn't have been; remove it. - # - list(REMOVE_ITEM Qt5Widgets_EXECUTABLE_COMPILE_FLAGS "-fPIC") - endif() if (Qt5Widgets_VERSION VERSION_GREATER 5.6 AND (CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID MATCHES "Clang")) # Qt 5.7 and later require C++ 11. If our minmimu required CMake version @@ -1190,7 +1163,6 @@ if (Qt5Widgets_FOUND) endif() set(CMAKE_CXX_FLAGS "-std=c++11 ${CMAKE_CXX_FLAGS}") endif() - set(CMAKE_CXX_FLAGS "${Qt5Widgets_EXECUTABLE_COMPILE_FLAGS} ${CMAKE_CXX_FLAGS}") set (QT_FOUND ON) set (QT_LIBRARIES ${Qt5Widgets_LIBRARIES} ${Qt5PrintSupport_LIBRARIES}) if(Qt5Multimedia_FOUND) @@ -2187,6 +2159,21 @@ if(BUILD_wireshark AND QT_FOUND) add_executable(wireshark WIN32 MACOSX_BUNDLE wireshark-qt.cpp ${wireshark_FILES} ${EXTRA_BUNDLE_FILES}) add_dependencies(wireshark version) set(PROGLIST ${PROGLIST} wireshark) + if(CMAKE_VERSION VERSION_LESS "2.8.12" + AND (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" + AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)) + # + # https://doc.qt.io/qt-5/cmake-manual.html says that for CMake + # versions older than 2.8.12, + # Qt5<Module>_EXECUTABLE_COMPILE_FLAGS must be added such that + # -fPIC is included. We should not do add this to + # CMAKE_CXX_FLAGS though since it may end up before the -fPIE + # option. Instead, add it to the target COMPILE_FLAGS. This + # option is deprecated in newer CMake versions and not necessary + # either since Qt uses the INTERFACE_COMPILE_OPTIONS property. + # + set_target_properties(wireshark PROPERTIES COMPILE_FLAGS "${Qt5Widgets_EXECUTABLE_COMPILE_FLAGS}") + endif() set_target_properties(wireshark PROPERTIES LINK_FLAGS "${WS_LINK_FLAGS}" FOLDER "Executables" |