aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Quantin <pascal.quantin@gmail.com>2016-10-29 20:15:45 +0200
committerMichael Mann <mmann78@netscape.net>2016-10-30 00:29:31 +0000
commit929ad3805fa31431c39de629e9b09e77e8152709 (patch)
treeda0b9019cfcffd90156bce75d80c9ebd0afb7c8c
parent1e1679db4671ce0745d516e9fb8dbd43a9677d05 (diff)
DCERPC: save strings in wmem file scope
Bug: 13072 Change-Id: Ib5f3d91be822a3d7180d95e3299dec978941c1d5 Reviewed-on: https://code.wireshark.org/review/18564 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
-rw-r--r--epan/dissectors/packet-dcerpc-nt.c4
-rw-r--r--epan/dissectors/packet-dcerpc-spoolss.c2
2 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-dcerpc-nt.c b/epan/dissectors/packet-dcerpc-nt.c
index 745e8978cc..d1a060b0a8 100644
--- a/epan/dissectors/packet-dcerpc-nt.c
+++ b/epan/dissectors/packet-dcerpc-nt.c
@@ -1261,7 +1261,7 @@ void cb_wstr_postprocess(packet_info *pinfo, proto_tree *tree _U_,
/* Save string to dcv->private_data */
if (options & CB_STR_SAVE) {
dcerpc_call_value *dcv = (dcerpc_call_value *)di->call_data;
- dcv->private_data = s;
+ dcv->private_data = wmem_strdup(wmem_file_scope(), s);
}
}
@@ -1324,7 +1324,7 @@ void cb_str_postprocess(packet_info *pinfo, proto_tree *tree _U_,
if (options & CB_STR_SAVE) {
dcerpc_call_value *dcv = (dcerpc_call_value *)di->call_data;
- dcv->private_data = s;
+ dcv->private_data = wmem_strdup(wmem_file_scope(), s);
}
}
diff --git a/epan/dissectors/packet-dcerpc-spoolss.c b/epan/dissectors/packet-dcerpc-spoolss.c
index c44db46d51..62d92825ea 100644
--- a/epan/dissectors/packet-dcerpc-spoolss.c
+++ b/epan/dissectors/packet-dcerpc-spoolss.c
@@ -627,7 +627,7 @@ dissect_SYSTEM_TIME_ptr(tvbuff_t *tvb, int offset, packet_info *pinfo,
offset = dissect_SYSTEM_TIME(
tvb, offset, pinfo, tree, di, drep, NULL, FALSE, &str);
- dcv->private_data = str;
+ dcv->private_data = wmem_strdup(wmem_file_scope(), str);
return offset;
}