diff options
| author | Guy Harris <guy@alum.mit.edu> | 2016-10-15 14:27:17 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2016-10-15 22:12:19 +0000 |
| commit | 74174367ff72257a7bd485f9a48c3c3667bd8e3b (patch) | |
| tree | 28aeaf78e75a93aba304582d7f93eae019921a10 | |
| parent | 5d5f58fb78ab7037db3ec03d3a4541b3adcfcb7a (diff) | |
Fix bin2hex().
It was repeatedly overwriting the first character in the buffer, rather
than appending characters.
Change-Id: Ie34d194d69ac3d685416323c93764aa401d78faa
Reviewed-on: https://code.wireshark.org/review/18209
Reviewed-by: Guy Harris <guy@alum.mit.edu>
| -rw-r--r-- | epan/dissectors/packet-iso8583.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-iso8583.c b/epan/dissectors/packet-iso8583.c index dd44607635..a689cf1498 100644 --- a/epan/dissectors/packet-iso8583.c +++ b/epan/dissectors/packet-iso8583.c @@ -560,7 +560,7 @@ static gchar* bin2hex(const guint8 *bin, enum bin2hex_enum type, guint32 len) if(size % 2) /* odd */ { ch = *str & 0x0f; - *buff = NIBBLE_2_ASCHEX(ch); + *buff++ = NIBBLE_2_ASCHEX(ch); str++; size--; } @@ -570,9 +570,9 @@ static gchar* bin2hex(const guint8 *bin, enum bin2hex_enum type, guint32 len) while(size-- > 0) { ch = (*str >> 4) & 0x0f; - *buff = NIBBLE_2_ASCHEX(ch); + *buff++ = NIBBLE_2_ASCHEX(ch); ch = *str & 0x0f; - *buff = NIBBLE_2_ASCHEX(ch); + *buff++ = NIBBLE_2_ASCHEX(ch); str++; } *buff = '\0'; |