aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2019-02-04 23:19:20 +0000
committerGerald Combs <gerald@wireshark.org>2019-02-04 23:21:27 +0000
commit68efe641c8e93461820c63ad7ab54928309ec15b (patch)
treea3eae10ed96b37fe2b0df683a524b4ff626835e4
parentcdfc56b340a8120c9766b75a70f2af231609c4ac (diff)
make-version.pl: Fix version variable checks.
Use "defined" instead of checking the variable's value (which might be zero). Change-Id: Id24aa25971f73526761c9821846ac0abcf252978 Reviewed-on: https://code.wireshark.org/review/31882 Reviewed-by: Gerald Combs <gerald@wireshark.org>
-rwxr-xr-xtools/make-version.pl6
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/make-version.pl b/tools/make-version.pl
index 976b3336aa..c579e69c94 100755
--- a/tools/make-version.pl
+++ b/tools/make-version.pl
@@ -626,9 +626,9 @@ sub get_version
close(CFGIN);
- die "Couldn't get major version" if (!$version_major);
- die "Couldn't get minor version" if (!$version_minor);
- die "Couldn't get micro version" if (!$version_micro);
+ die "Couldn't get major version" if (!defined($version_major));
+ die "Couldn't get minor version" if (!defined($version_minor));
+ die "Couldn't get micro version" if (!defined($version_micro));
}
# Read values from the configuration file, if it exists.