diff options
| author | Guy Harris <guy@alum.mit.edu> | 2018-02-03 18:31:10 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2018-02-04 02:45:10 +0000 |
| commit | 676d4668c83f8c78f35098d9c4ef8851729460fc (patch) | |
| tree | f35899f6329399028756ac96f5e02e80b82976b5 | |
| parent | 2385ec8776eb3d04fd29b40f7bc8029f5390c652 (diff) | |
Note that we should show ISBs in the "packet" list.
Change-Id: Id39712f9926f05528e4e6120d0feba7c319b3bb2
Reviewed-on: https://code.wireshark.org/review/25588
Reviewed-by: Guy Harris <guy@alum.mit.edu>
| -rw-r--r-- | wiretap/pcapng.c | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/wiretap/pcapng.c b/wiretap/pcapng.c index 41e722f17b..d81aca3e7f 100644 --- a/wiretap/pcapng.c +++ b/wiretap/pcapng.c @@ -2671,7 +2671,26 @@ pcapng_read(wtap *wth, int *err, gchar **err_info, gint64 *data_offset) break; case(BLOCK_TYPE_ISB): - /* Another interface statistics report */ + /* + * Another interface statistics report + * + * XXX - given that they're reports, we should be + * supplying them in read calls, and displaying them + * in the "packet" list, so you can see what the + * statistics were *at the time when the report was + * made*. + * + * The statistics from the *last* ISB could be displayed + * in the summary, but if there are packets after the + * last ISB, that could be misleading. + * + * If we only display them if that ISB has an isb_endtime + * option, which *should* only appear when capturing ended + * on that interface (so there should be no more packet + * blocks or ISBs for that interface after that point, + * that would be the best way of showing "summary" + * statistics. + */ pcapng_debug("pcapng_read: block type BLOCK_TYPE_ISB"); if_stats_mand_block = (wtapng_if_stats_mandatory_t*)wtap_block_get_mandatory_data(wblock.block); if (wth->interface_data->len <= if_stats_mand_block->interface_id) { |