diff options
| author | Gerald Combs <gerald@wireshark.org> | 2016-01-06 10:48:53 -0800 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2016-02-02 00:27:42 +0000 |
| commit | 5cad2cd09b2e1612c0e14ee3cc28bcaed19cf6f0 (patch) | |
| tree | 606f1f996c186af05c9c3e92077d1c52f05d803d | |
| parent | 8294e773b0d8b8d0cc0cb3da104fb4c621b4a3ae (diff) | |
Add configure-time synchronous DNS warnings.
In CMake and Autotools, warn the user when neither c-ares nor ADNS is
present. Note that we might want to make asynchronous DNS a requirement.
Change-Id: Ia9cce56cc2286cdc72303fc1410f899f9c320d84
Reviewed-on: https://code.wireshark.org/review/13080
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
| -rw-r--r-- | CMakeLists.txt | 5 | ||||
| -rw-r--r-- | configure.ac | 10 |
2 files changed, 13 insertions, 2 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 90fde1e1a2..1c7589dd20 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -885,6 +885,11 @@ endif() if(HAVE_LIBADNS) set(HAVE_GNU_ADNS 1) endif() +if(NOT HAVE_LIBCARES AND NOT HAVE_LIBADNS) + # We should make this an error at some point. + message(WARNING "Not using c-ares or ADNS.") + message(WARNING "Synchronous name resolution can seriously degrade performance.") +endif() if(HAVE_LIBNL AND HAVE_AIRPCAP) message(ERROR "Airpcap and Libnl support are mutually exclusive") endif() diff --git a/configure.ac b/configure.ac index 20feedb705..bfd87bb001 100644 --- a/configure.ac +++ b/configure.ac @@ -3392,7 +3392,12 @@ fi if test "x$have_good_c_ares" = "xyes" ; then c_ares_message="yes" else - c_ares_message="no" + if test "x$have_good_adns" = "xyes" ; then + c_ares_message="no" + else + # We should make this an error at some point. + c_ares_message="no. This can cause serious performance issues." + fi fi if test "x$have_good_adns" = "xyes" ; then @@ -3401,7 +3406,8 @@ else if test "x$have_good_c_ares" = "xyes" ; then adns_message="no (using c-ares instead)" else - adns_message="no" + # We should make this an error at some point. + adns_message="no. This can cause serious performance issues." fi fi |