diff options
| author | Dario Lombardo <lomato@gmail.com> | 2018-02-18 18:36:49 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-02-21 17:14:30 +0000 |
| commit | 566d20f444f1a526910e4c78579e8703c63c19aa (patch) | |
| tree | d45a5c308ece6668dfb76d1dd9cc1ee631ec9467 | |
| parent | 0a3c713d8c87ef64761027012e33f54507521fc4 (diff) | |
dfilter: use g_malloc0 to prevent uninitialized memory to be used.
Found by clang.
Change-Id: I89497bd0f32c79f82218c6d254a214364c930eb3
Reviewed-on: https://code.wireshark.org/review/25884
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | epan/dfilter/gencode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/epan/dfilter/gencode.c b/epan/dfilter/gencode.c index 7554e6e7f6..769fcc3143 100644 --- a/epan/dfilter/gencode.c +++ b/epan/dfilter/gencode.c @@ -169,7 +169,7 @@ dfw_append_function(dfwork_t *dfw, stnode_t *node, dfvm_value_t **p_jmp) /* Array to hold the instructions that need to jump to * an instruction if they fail. */ - jmps = (dfvm_value_t **)g_malloc(num_params * sizeof(dfvm_value_t*)); + jmps = (dfvm_value_t **)g_malloc0(num_params * sizeof(dfvm_value_t*)); /* Create the new DFVM instruction */ insn = dfvm_insn_new(CALL_FUNCTION); @@ -185,7 +185,6 @@ dfw_append_function(dfwork_t *dfw, stnode_t *node, dfvm_value_t **p_jmp) i = 0; while (params) { - jmps[i] = NULL; reg = gen_entity(dfw, (stnode_t *)params->data, &jmps[i]); val = dfvm_value_new(REGISTER); |