diff options
| author | Dario Lombardo <lomato@gmail.com> | 2018-03-01 13:35:42 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-03-07 16:52:58 +0000 |
| commit | 5375283f9294d444fcda14df74fed77160bf1d1d (patch) | |
| tree | 72aa528ca2bcb3fdb5432749226b964277e26160 | |
| parent | 4f36a28acbc06781740cf4105375ae7759b6606b (diff) | |
Qt: remove leak in simple_statistics_dialog (found by clang).
Change-Id: Ie1b6d6e8039eeaeb08f2d59c21a88298d55ea797
Reviewed-on: https://code.wireshark.org/review/26145
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Roland Knall <rknall@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | ui/qt/simple_statistics_dialog.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/ui/qt/simple_statistics_dialog.cpp b/ui/qt/simple_statistics_dialog.cpp index 5114b4107f..2587623b10 100644 --- a/ui/qt/simple_statistics_dialog.cpp +++ b/ui/qt/simple_statistics_dialog.cpp @@ -201,10 +201,12 @@ void SimpleStatisticsDialog::addMissingRows(struct _stat_data_t *stat_data) } for (guint element = ti->childCount(); element < st_table->num_elements; element++) { stat_tap_table_item_type* fields = stat_tap_get_field_data(st_table, element, 0); - SimpleStatisticsTreeWidgetItem *ss_ti = new SimpleStatisticsTreeWidgetItem(ti, st_table->num_fields, fields); - for (int col = 0; col < (int) stu_->nfields; col++) { - if (stu_->fields[col].align == TAP_ALIGN_RIGHT) { - ss_ti->setTextAlignment(col, Qt::AlignRight); + if (stu_->nfields > 0) { + SimpleStatisticsTreeWidgetItem *ss_ti = new SimpleStatisticsTreeWidgetItem(ti, st_table->num_fields, fields); + for (int col = 0; col < (int) stu_->nfields; col++) { + if (stu_->fields[col].align == TAP_ALIGN_RIGHT) { + ss_ti->setTextAlignment(col, Qt::AlignRight); + } } } } |